Commit Graph

903 Commits

Author SHA1 Message Date
Jack Grigg 87beee32f4 dev: Add CircuitCost tool with proof size measurement 2021-07-20 03:17:56 +01:00
ebfull ca44b40009
Merge pull request #322 from zcash/coset-optimization
Support rotations while in extended domain
2021-07-19 09:16:05 -06:00
Sean Bowe ce319c8da8
Add clarifying comment to `distribute_powers_zeta`. 2021-07-19 09:08:24 -06:00
Jack Grigg 1e33570c7a cargo fmt 2021-07-19 14:46:02 +01:00
str4d c0d2aa1286
Merge branch 'main' into coset-optimization 2021-07-19 14:43:37 +01:00
str4d 96b1196bce
Merge pull request #330 from zcash/permutation-common
Merge the common pieces of the permutation argument into a separate proof component
2021-07-19 14:38:24 +01:00
str4d dda1be4731
Merge pull request #336 from zcash/dev-layout-equality
dev: Enable visualizing equality constraints in circuit layouts
2021-07-16 23:03:01 +01:00
str4d 874b52a7f7
dev: Fix typo in doc comment
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-16 23:02:18 +01:00
Jack Grigg 3fe004a794 dev: Reduce opacity of marked equality cells to add a border 2021-07-16 23:00:49 +01:00
Jack Grigg 56a6107cdf dev: Enable visualizing equality constraints in circuit layouts 2021-07-16 15:01:55 +01:00
str4d 36fa8f6fea
Merge pull request #331 from zcash/dev-poison-unusable-cells
MockProver: Poison unusable advice cells
2021-07-16 01:02:56 +01:00
Jack Grigg 8e71415933 MockProver: Limit table expression evaluations to usable rows
Also refactors the lookup argument to only compute table expressions
once per lookup argument.
2021-07-16 00:26:16 +01:00
Sean Bowe b0a4a19093
Rename CommonCommitted to CommonEvaluated. 2021-07-15 15:22:51 -06:00
Jack Grigg 7dae8698b6 MockProver: Poison unusable advice cells
Circuit developers need to use selectors (or equivalent) to prevent their
custom gates from being active on unusable rows. By marking the advice
cells in these rows as "poisoned" and tracking this through expressions,
we can provide a better error message to developers that indicates the
missing selector issue.

Closes zcash/halo2#329.
2021-07-15 22:12:50 +01:00
Sean Bowe 3cae0d5f19
Merge the common pieces of the permutation argument into a separate proof component. 2021-07-15 14:30:52 -06:00
ebfull 4a9e329ded
Merge pull request #316 from zcash/zk-changes-again
Final ZK changes
2021-07-14 16:19:06 -06:00
Sean Bowe 070beafa53
Address minor review comments. 2021-07-14 15:19:26 -06:00
Sean Bowe 1f75dc25ee
Make plonk_api test exercise multiple permutation sets. 2021-07-14 10:24:31 -06:00
Sean Bowe 0a3ae6f1eb
Add clarifying comment.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-14 10:17:44 -06:00
Sean Bowe bbe06ac61e
Add clarifying comment.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-14 10:08:49 -06:00
Sean Bowe af01af8fa5
Remove unnecessary collect. 2021-07-14 10:07:30 -06:00
Sean Bowe 11a1fc7d4a
Fix stale comment 2021-07-14 09:48:56 -06:00
Sean Bowe ef01b9310a
Fix examples broken by verifier API changes. 2021-07-14 09:47:53 -06:00
Sean Bowe 99a0e675f1
Minor changes to comments. 2021-07-14 09:46:29 -06:00
Sean Bowe b4bd4ada9a
Clarify barycentric weight doc comment. 2021-07-14 09:19:56 -06:00
ebfull 29fc0a781a
Simplify `l_i_range` using `rotate_omega`.
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-14 09:07:21 -06:00
ebfull dfe716dbc1
Describe `l_i_range` implementation in doc comment
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-14 09:05:40 -06:00
Sean Bowe 74f3e1c6d9
Fix omitted notation to explicitly designate l_last and l_blind as polynomials. 2021-07-13 16:30:52 -06:00
Sean Bowe 4cd0bffc8e
Collapse random_{poly,blind} fields back into Committed in other structures. 2021-07-13 16:19:44 -06:00
Sean Bowe 8caafc0abf
Change n to u in sanity check. 2021-07-13 16:12:21 -06:00
Sean Bowe dd41cfa022
fix clippy lint 2021-07-13 16:02:41 -06:00
Sean Bowe d0950c6d4c
Add explanation of lookup table degree nuances. 2021-07-13 16:02:27 -06:00
Sean Bowe 0dc4447ad8
Change verification API to allow the caller to supply instances as slices of scalars rather than commitments. 2021-07-13 12:08:16 -06:00
Sean Bowe f532b7e973
Return error if supplied instance slice is too large. 2021-07-13 11:44:58 -06:00
Sean Bowe f314f66f69
Fix clippy lint 2021-07-13 10:11:38 -06:00
Sean Bowe 574ce73d80
Minor changes to `distribute_powers_zeta`. 2021-07-13 10:10:03 -06:00
Sean Bowe c05ceab04d
Switch 5 to 3 in benchmark. 2021-07-13 09:15:30 -06:00
Sean Bowe 9155cd174b
Introduce `set_minimum_degree` to avoid performance regression in benchmark. 2021-07-12 15:28:16 -06:00
Daira Hopwood 20c347b269
Merge pull request #320 from daira/book-zk-changes
[Book] Zero knowledge changes (and misc cleanups)
2021-07-12 20:35:20 +01:00
Sean Bowe 827132302a
Remove the ability to rotate when switching to the extended domain. 2021-07-12 12:57:09 -06:00
Sean Bowe a091795aca
Switch to computing only Rotation::cur() cosets until rotation is needed. 2021-07-12 12:53:12 -06:00
Sean Bowe 55424c8c2f
Add `{mul,add,sub}_extended` and `rotate_extended` methods to `EvaluationDomain`. 2021-07-12 11:44:09 -06:00
Daira Hopwood 103c93391d Clarify the statement about the δ^i being distinct quadratic non-residues.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 17:24:21 +01:00
Daira Hopwood 8ac20608e4 Merge branch 'kw-halo-book' into book-zk-changes
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:32:36 +01:00
Daira Hopwood 06ff90ba95 Rename UPA to PLONKish.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:12:58 +01:00
Daira Hopwood 0a39457780
Merge pull request #319 from zcash/book-fixes
Book fixes
2021-07-12 02:06:14 +01:00
Daira Hopwood 6a11c2b97e Update the circuit commitments section for the changes to the permutation argument.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood 1b3241d757 Clarify product argument and add a diagram.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood fedcc1960d Permutation argument cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood 69ca38d2b1 Update permutation argument for zero knowledge changes in #316.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00