Commit Graph

3343 Commits

Author SHA1 Message Date
Francisco Gindre 17f074d460
PR Suggestion by @nuttycom: remove the `FullNodeParameters` enum 2024-01-17 18:55:21 -03:00
Francisco Gindre 529fd3d562
Add Regtest variant of `Network` and Parameter
closes #1051

Also:
Adds encoding tests + cargo fmt
Adds tests on ZIP-321
Adds coverage on new code
Supports nu6 activation
`local-consensus` feature is disabled by default
2024-01-17 18:21:06 -03:00
str4d efc0d7d697
Merge pull request #1118 from nuttycom/fix/zcash_client_backend_features
zcash_client_backend: Add missing `orchard` feature dependency.
2024-01-17 18:10:43 +00:00
Kris Nuttycombe 876f53e295 zcash_client_backend: Add missing `orchard` feature dependency. 2024-01-17 10:09:12 -07:00
Kris Nuttycombe 9f6bc0956e
Merge pull request #1115 from zcash/1109-ci-unstable-features
CI: Move testing of unstable features into a separate job
2024-01-16 18:16:48 -07:00
Jack Grigg 4c3571cb32 zcash_keys: Fix proptest when orchard feature flag disabled 2024-01-16 23:08:49 +00:00
Jack Grigg 05f9252cb0 Fix `zcash_keys` feature flag enabling in `zcash_client_*` crates 2024-01-16 22:47:35 +00:00
Jack Grigg c8d4dacfc1 CI: Move testing of unstable features into a separate job
Closes zcash/librustzcash#1109.
2024-01-16 22:36:53 +00:00
str4d b6caa483b4
Merge pull request #1116 from zcash/zcash_keys
Split `zcash_keys` crate out from `zcash_client_backend`
2024-01-16 22:09:41 +00:00
str4d eb8a73938f
Merge pull request #1108 from nuttycom/builder_bundle_metadata
zcash_primitives: Add Orchard bundle metadata to transaction builder.
2024-01-16 22:08:43 +00:00
Kris Nuttycombe 0ca955336d Split `zcash_keys` crate out from `zcash_client_backend`
This change makes it easier for third parties to make use of the Unified
key infrastructure without incurring a dependency upon the rest of the
`zcash_client_backend` interfaces.
2024-01-16 13:49:42 -07:00
Kris Nuttycombe cc39bf4429 zcash_primitives: Add Orchard bundle metadata to transaction builder. 2024-01-16 13:19:24 -07:00
str4d 75184acfdb
Merge pull request #1113 from zcash/zcash_address-remove-type-aliases
zcash_address: Remove private type aliases for raw data sizes
2024-01-12 15:15:55 +00:00
Jack Grigg 29dc5d1d5c zcash_address 0.3.1 2024-01-12 04:53:39 +00:00
Jack Grigg 22271145a7 zcash_address: Improve documentation 2024-01-12 04:53:39 +00:00
Jack Grigg 6570116384 zcash_address: Show feature flags in documentation 2024-01-12 02:45:22 +00:00
Jack Grigg 3f006bffac zcash_address: Remove private type aliases for raw data sizes
These served no type safety purpose; they were just to make developing
the crate easier. However, while docs.rs correctly shows these in trait
APIs as their plain `[u8; N]` form, editor LSPs like `rust-analyzer`
assume the crate-private types are public and auto-create stubs that
reference them, which is not good UX for downstream developers.
2024-01-12 00:15:55 +00:00
Kris Nuttycombe 47d432820a
Merge pull request #1112 from nuttycom/get_accounts
Add WalletRead::get_account_ids (subsumes #1106 to fix formatting issues)
2024-01-11 15:05:03 -07:00
Kris Nuttycombe 60336714f7 Fix Rust formatting. 2024-01-11 14:31:19 -07:00
Andrew Arnott 28ed048c7e
Add punctuation to changelog
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
2024-01-11 12:02:24 -07:00
Andrew Arnott 69d92808f3
Add `WalletRead::get_account_ids` function 2024-01-10 13:01:01 -07:00
Kris Nuttycombe a99e842404
Merge pull request #829 from nuttycom/wallet/select_ua_receivers
Add receiver type selection to unified address derivation.
2024-01-09 11:52:13 -07:00
Kris Nuttycombe 6cbdd494cf zcash_client_backend: Add receiver type selection to unified address derivation. 2024-01-09 10:48:13 -07:00
Kris Nuttycombe c3a630bac3
Merge pull request #1060 from nuttycom/wallet/generalize_proposals
Add Orchard support to fees & transaction proposals.
2024-01-09 09:20:41 -07:00
Kris Nuttycombe 3bce5afea5
Merge pull request #1078 from nerdcash/displayableErrors
Implement Display trait for `DecodingError`
2024-01-08 10:06:43 -07:00
Kris Nuttycombe b399599bd4
Merge pull request #1104 from nerdcash/dropMainNetFeature
Drop unused `mainnet` feature
2024-01-08 10:05:02 -07:00
Andrew Arnott 52a91a0ee7
Drop unused `mainnet` feature
Nothing seems to have depended on it, and my testing suggests the same build of this crate can work on both networks.
2024-01-08 06:32:21 -07:00
Kris Nuttycombe 24ebe4c643 Address comments from code review.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2024-01-05 17:00:46 -07:00
Kris Nuttycombe adc75566a0 zcash_client_backend: Add Orchard support to transaction proposals. 2024-01-05 16:59:54 -07:00
Kris Nuttycombe 56f2ac573c zcash_client_backend: Add Orchard support to change strategies.
This modifies the `compute_balance` method to operate in a
bundle-oriented fashion, which simplifies the API and makes it easier to
elide Orchard functionality in the case that the `orchard` feature is
not enabled.
2024-01-05 16:59:54 -07:00
Kris Nuttycombe 2d5bf5d8d9
Merge pull request #1100 from zcash/1098-ci-lint-protobuf
CI: Add lint to check protobuf consistency with generated files
2024-01-05 16:32:15 -07:00
Jack Grigg 3789e46700 CI: Add lint to check protobuf consistency with generated files
Closes zcash/librustzcash#1098.
2024-01-05 21:03:01 +00:00
str4d 0548b3dd9b
Merge pull request #1090 from nuttycom/rename_wallet_note
zcash_client_backend: rename `WalletNote` to `Note`
2024-01-05 17:16:29 +00:00
Kris Nuttycombe 5d7638ccf8
Merge pull request #1089 from rex4539/typos
Fix typo
2024-01-05 09:57:17 -07:00
Kris Nuttycombe 1b036f1e0d zcash_client_backend: rename `WalletNote` to `Note` 2024-01-05 09:13:53 -07:00
Dimitris Apostolou 652c393896
Fix typo 2024-01-05 12:44:57 +02:00
Kris Nuttycombe 28319ffc38
Merge pull request #1085 from nuttycom/wallet/common_input_source
Replace SaplingInputSource and TransparentInputSource with InputSource
2024-01-04 15:07:23 -07:00
Kris Nuttycombe 5126fd6b5f
Merge pull request #1086 from zcash/docs-rs-feature-flags
Show feature flags in documentation
2024-01-04 14:34:40 -07:00
str4d 3ea8b909c9
Merge pull request #1077 from nerdcash/unstableVsCode
Enable unstable features when editing in VS Code
2024-01-04 21:19:48 +00:00
Kris Nuttycombe d4aa2d6f06 Replace SaplingInputSource and TransparentInputSource with InputSource
This unification allows us to better isolate transparent-input dependent
functionality. Previously, `TransparentInputSource` could not be placed
under a feature flag because the interface was needed for proposal
deserialization; by instead making the transparent input source methods
flag-dependent, we can correctly produce an error when proposal
deserializaiton attempts to select transparent inputs and the feature
flag is off.
2024-01-04 14:00:20 -07:00
str4d b83877f44b
Merge pull request #1080 from nuttycom/wallet/orchard_feature_flag
zcash_client_backend: Introduce an "orchard" feature flag.
2024-01-04 20:59:51 +00:00
Jack Grigg 3989ee9926 Show feature flags in documentation
This can be rendered locally with:
    RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --no-deps --workspace --all-features
2024-01-04 19:07:22 +00:00
Kris Nuttycombe 967fd36d39
Apply suggestions from code review
Co-authored-by: str4d <thestr4d@gmail.com>
2024-01-04 11:56:59 -07:00
Andrew Arnott 1804647112
Update .vscode/settings.json
Co-authored-by: str4d <thestr4d@gmail.com>
2024-01-04 11:44:17 -07:00
Kris Nuttycombe 857e44a11c zcash_client_backend: Use a polymorphic type for `ScannedBlock` note commitment and nullifier data. 2024-01-04 11:19:22 -07:00
Kris Nuttycombe f18d082aa3 zcash_client_backend: Introduce an "orchard-client" feature flag.
We plan to also introduce a similar flag to gate access to Sapling
functionality. Since introduction of Orchard functionality is still
nascent, it's the correct time to introduce this isolation, before
there's more functionality that needs to be isolated in this fashion.
2024-01-03 17:05:20 -07:00
str4d 4bd6520013
Merge pull request #1081 from zcash/api-cleanups
API cleanups
2024-01-03 20:43:27 +00:00
Jack Grigg 2ea83243a7 Document the feature flags 2024-01-03 20:15:21 +00:00
Jack Grigg 0df4c6f043 Remove implicit feature flags for optional dependencies
All optional dependencies are enabled as part of dedicated feature
flags.
2024-01-03 20:15:21 +00:00
Jack Grigg b7bba9bbb2 zcash_primitives: Remove `keys` module 2024-01-03 17:29:59 +00:00