0994282019
Fix typos
2022-11-25 23:09:48 +02:00
f6a4f68115
Merge pull request #6122 from nuttycom/wallet/listunspent_as_of
...
Add `asOfHeight` argument across the RPC API
2022-11-23 21:20:20 -07:00
368d04245d
Change asOfHeight to preserve Bitcoin compat
2022-11-22 22:06:51 -07:00
7792228bab
Revert change to getbalance minconf
...
It was the docs that were wrong. In this case, the default `minconf` _should_ be
0 (to match upstream).
2022-11-22 16:47:40 -07:00
d444f8b586
Fix small error in code review suggestions
2022-11-22 16:47:40 -07:00
f290b9a7b4
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-22 15:59:07 -07:00
4f85307186
Add FIXMEs to repair comments after #6262 is fixed
2022-11-22 10:36:34 -07:00
0a87047186
Merge pull request #6245 from sellout/wallet_accounts-formatting
...
Small formatting change
2022-11-22 07:55:40 -07:00
b9158fe377
Merge pull request #6259 from str4d/debugmetrics
...
Place zcashd.debug.* metrics behind a -debugmetrics config option
2022-11-22 06:05:47 +00:00
b27fdf54fd
Add matured_at_height test helper
2022-11-21 22:36:12 -07:00
3b3f8f4cac
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-11-21 21:15:07 -07:00
71b5f99ede
Work around #6262 in wallet_listunspent
2022-11-21 20:44:21 -07:00
952a1ac433
Ignore mempool when asOfHeight is set
...
This also catches a case where the default minconf was 0 (which disagreed with
the docs), and a case where asOfHeight checked the wrong param entry.
2022-11-21 20:44:21 -07:00
c267c3ee26
Merge pull request #6192 from daira/reduce-equihash-solution-memory
...
Reduce memory usage of CBlockIndex
2022-11-21 22:25:30 +00:00
93de2aae0e
Place zcashd.debug.* metrics behind a -debugmetrics config option
2022-11-21 20:50:02 +00:00
27ffefed12
Merge pull request #6248 from sellout/reuse-python
...
Avoid inconsistent Python lookup
2022-11-18 22:52:38 +00:00
d796114b2e
Add additional asOfHeight tests
2022-11-18 01:20:00 -07:00
2c487c9430
Add RPC test for wallet_listunspent changes
2022-11-18 01:20:00 -07:00
3529097153
Fix a dependency of the `show_help` RPC test on the number of cores,
...
and an incompatibility with Python 3.9 in the test framework that
affected the `receivedby` extended RPC test.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-15 13:58:26 +00:00
c12fb6ad5b
Avoid inconsistent Python lookup
...
When executing a Python script from within Python, rather than looking for
`python3` in /usr/local/bin and falling back to the script’s shebang line,
_always_ use the same Python that is executing the caller.
I don’t know why this script doesn’t just run `bitcoin_util_test.py`
directly (always using the shebang line), but I assume that is
intentional (but that should be documented). Otherwise, I’d prefer that
approach.
2022-11-14 06:37:51 -10:00
2ee172fe15
Error reporting improvements.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-11-13 18:46:30 +00:00
4ec2642f94
Small formatting change
2022-11-10 20:50:22 -07:00
e417ba89a6
Merge pull request #6211 from sellout/updatecheck-token-path
...
Improve token handling in the updatecheck script
2022-10-26 12:15:29 -06:00
1296b646b3
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-26 09:07:58 -06:00
87aa33ecc4
`zcash --help` test improvements
...
Applying suggestions from @daira’s review of #6204 .
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-21 19:03:13 -06:00
8e333b3f49
updatecheck: support XDG-based token location
...
Have updatecheck look in $XDG_DATA_HOME/zcash/updatecheck/token for the GH
token. Having one in the repo will still take precedence (for pre-existing
users, as well as if you want to override the token used in a particular
case). The new location is standardized, exists at the user level (as the token
logically does), and means that you don't need to copy files around if you get a
new clone or worktree to do a release.
2022-10-20 12:25:13 -06:00
4c21d6f444
updatecheck: simplify token handling
...
- make the token optional (just will hit a rate limit after a few runs of the
script)
- only load the token once, rather than once per request (this is necessary
after the above change, so you don't get the warning printed repeatedly)
- switch from BasicAuth to an Authorization header (this means we no longer need
the GitHub username, just the token)
- support a token file that doesn't contain a username (it will still parse old
versions of the file properly)
2022-10-20 12:13:30 -06:00
9c4bf36c45
updatecheck: fix GitHub auth
...
The script was accessing nonexistent vars, so auth wasn't working. Mostly not
noticable until you hit the API's unauthed request rate limit.
2022-10-20 10:48:02 -06:00
06a1c78941
Certify librustzcash crate upgrades.
2022-10-20 08:35:29 -06:00
2f734ce6ea
Vet cxxbridge upgrade.
2022-10-19 12:21:37 -06:00
05110068d9
Update and/or postpone dependencies for 5.3.0
2022-10-19 10:09:03 -06:00
04d314d067
Apply suggestions from code review
...
Co-authored-by: Kris Nuttycombe <kris.nuttycombe@gmail.com>
2022-10-18 13:43:14 -06:00
5c19487991
Add test for `zcashd --help`
...
Currently failing.
2022-10-18 13:42:02 -06:00
774fa691aa
Always use a tuple as right argument of % in new Python code.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-18 13:42:02 -06:00
1e480d2b4d
Address review feedback and fixed test failures
...
Some tests were checking error message strings, but the check was still
hardcoded to “bitcoind”.
2022-10-18 13:42:02 -06:00
8cb655c3ff
Fix display of binary name in error messages.
...
Ensures that test failures report the name of the actual binary that was run.
2022-10-18 13:42:02 -06:00
ebea82c96c
Merge pull request #6165 from sellout/rpc-tests-binary-name
...
Fix display of binary name in error messages.
2022-10-11 16:25:51 -06:00
4871fba26a
rust: Update remaining dependencies
...
The audit exemptions have been regenerated for these dependencies.
2022-10-11 10:13:41 +00:00
2477ef9c4b
rust: Audit some dependency updates
2022-10-11 05:08:07 +00:00
7788afcf54
Always use a tuple as right argument of % in new Python code.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2022-10-10 20:50:59 +01:00
13657342c8
qa: Recommend cargo-upgrades instead of cargo-outdated
...
Closes zcash/zcash#6090 .
2022-10-10 19:05:51 +00:00
9a69c2b01e
rust: Update to `cpufeatures 0.2.5`
...
Closes zcash/zcash#6195 .
2022-10-10 19:04:39 +00:00
f7b59a5ddb
qa: Postpone Clang 15.0.2
2022-10-10 18:56:49 +00:00
1f836859f3
depends: Update cxx to 1.0.78
2022-10-10 18:56:12 +00:00
3b9f7c2a69
rust: Update to `metrics 0.20`
2022-10-10 18:44:33 +00:00
ad47364f31
Address review feedback and fixed test failures
...
Some tests were checking error message strings, but the check was still
hardcoded to “bitcoind”.
2022-10-04 10:21:06 -06:00
6a7c86e63b
Fix display of binary name in error messages.
...
Ensures that test failures report the name of the actual binary that was run.
2022-10-04 10:21:06 -06:00
225c8b8a03
test_framework: fix AttributeError in sapling_spends_compact_digest
...
Without this fix we will get:
AttributeError: 'SpendDescriptionV5' object has no attribute 'anchor'
On certain V5 transactions rehash / calc_sha256, for example:
ca6abd8ef7d6ef158a4a35ea2c2c0cf122f2f664a88f8fa5b6fd79e48c5bed59
2022-10-04 01:54:34 +02:00
f466eb0484
Merge pull request #6156 from daira/prepare-epks-and-ivks
...
Switch to a version of librustzcash that prepares ivk and epk when doing trial decryption
2022-09-27 22:59:45 +01:00
0e3fc36a47
wallet: Correctly track heap usage of batch items
...
As of zcash/librustzcash#633 , `SaplingDomain::IncomingViewingKey` now
allocates memory internally, and this memory persists as long as the
`BatchRunner` is alive. Now that we have decoupled the measurement of
heap usage for batch tasks from their internals, we can add bounds to
all of the generic parameters of `Batch` to enable correctly measuring
their actual heap usage.
Ported from zcash/librustzcash@913aa0a988 .
2022-09-26 22:19:33 +00:00
Dimitris Apostolou
Greg Pfeil
Greg Pfeil
Kris Nuttycombe
str4d
Jack Grigg
Daira Hopwood
DeckerSU