Commit Graph

15360 Commits

Author SHA1 Message Date
str4d 33a963f3ce
Merge pull request #5326 from str4d/5325-cwallettx-isfromme-fix
wallet: Check spent shielded notes in CWalletTx::IsFromMe
2021-09-29 01:30:52 +13:00
Jack Grigg fd49f78042 wallet: Check spent shielded notes in CWalletTx::IsFromMe
The "IsFromMe" logic was implemented in several places in the Bitcoin
Core wallet. We had correctly updated CWallet::IsFromMe(CTransaction)
(which was used in most places in the wallet) to check for shielded
notes being spent, but did not notice that CWalletTx::IsFromMe also
needed this check.

This bug has existed since before Zcash launched. It went unnoticed
because CWalletTx::IsFromMe was previously only called from code
used to either create purely-transparent transactions, or provide
informational output on non-critical RPC methods.

Closes zcash/zcash#5325.
2021-09-28 02:51:04 +01:00
str4d 4f43b694c4
Merge pull request #5322 from str4d/release-v4.5.0
Release v4.5.0
2021-09-23 22:40:49 +12:00
Jack Grigg 4fb372efdd Add notable changes to v4.5.0 release notes 2021-09-23 05:09:55 +01:00
Jack Grigg 872e95a599 Set testnet activation height for NU5 2021-09-23 05:09:42 +01:00
Jack Grigg a1d17292b4 make-release.py: Updated release notes and changelog for 4.5.0. 2021-09-23 04:20:16 +01:00
Jack Grigg 5ceb64682c make-release.py: Updated manpages for 4.5.0. 2021-09-23 04:20:15 +01:00
Jack Grigg 1bd9152daa make-release.py: Versioning changes for 4.5.0. 2021-09-23 04:12:06 +01:00
str4d 343c4342de
Merge pull request #5320 from str4d/final-deps-4.5.0
Final dependecy updates for 4.5.0
2021-09-23 15:06:44 +12:00
Jack Grigg 00724c9f5a Update halo2 and orchard dependencies with BOSL Zcash exception 2021-09-22 23:10:57 +01:00
Jack Grigg 660e938499 cargo update
Includes pasta_curves 0.2.1, which relicenses to MIT OR Apache-2.0.
2021-09-22 22:51:26 +01:00
str4d 9338ecd0d6
Merge pull request #5305 from str4d/rust-deps
contrib: Add script for generating a graph of our Rust dependencies
2021-09-23 09:48:56 +12:00
str4d 5ef1b9b8cc
Merge pull request #5312 from str4d/fix-connectblockslow-bench
bench: Add Orchard logic to zcbenchmarks
2021-09-23 06:45:45 +12:00
Jack Grigg 5731ba431c bench: Add Orchard logic to zcbenchmarks
The missing `ORCHARD` case in `FakeCoinsViewDB::GetBestAnchor` caused
an exception to be thrown during the `connectblockslow` benchmark.
2021-09-22 17:32:17 +01:00
str4d 38bdae6df9
Merge pull request #5311 from str4d/wallet-load-orchard-perf
Fix regression in wallet load performance
2021-09-23 04:22:38 +12:00
Jack Grigg 03ecb13300 rust: Skip running the Orchard batch validator on an empty batch
An empty batch will always succeed, but costs a 2-base multi-scaler
multiplication.
2021-09-22 14:52:47 +01:00
Jack Grigg 092ffed2cc wallet: Batch-validate all Orchard signatures in the wallet on load
A batch item is 128 bytes, so for a wallet with 200k Orchard actions
this would require around 25MiB, which is reasonable.
2021-09-22 14:01:53 +01:00
Jack Grigg f9a1986e43 rust: Move Orchard batch logic into BatchValidator methods 2021-09-22 12:36:01 +01:00
str4d a88a98af23
Merge pull request #5307 from str4d/fix-gitian
Fix Gitian builds
2021-09-21 10:34:17 +12:00
Jack Grigg 416a4d453f build: Add missing source file to zcash_gtest_SOURCES 2021-09-20 20:15:38 +01:00
Jack Grigg 49cacbc49f build: Ensure that cargo uses vendored dependencies for git repos 2021-09-20 19:11:55 +01:00
Jack Grigg 9c20d7405f build: Add primitives/orchard.h to list of header files 2021-09-20 15:49:28 +01:00
Jack Grigg d087c8b089 cargo update 2021-09-17 13:52:09 +01:00
Jack Grigg 9803111210 contrib: Add script for generating a graph of our Rust dependencies
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-09-17 13:38:01 +01:00
str4d 91bb1d3b46
Merge pull request #5304 from str4d/release-v4.5.0-rc1
Release v4.5.0-rc1
2021-09-17 23:47:57 +12:00
Jack Grigg 2aa9f766b2 Migrate to latest revisions of orchard and the zcash_* crates 2021-09-17 03:56:32 +01:00
Jack Grigg bfd7b31efe make-release.py: Updated release notes and changelog for 4.5.0-rc1. 2021-09-16 23:34:14 +01:00
Jack Grigg 518895a3dd make-release.py: Updated manpages for 4.5.0-rc1. 2021-09-16 23:34:14 +01:00
Jack Grigg 8a9f29eaf1 make-release.py: Versioning changes for 4.5.0-rc1. 2021-09-16 23:15:40 +01:00
str4d 498d42219c
Merge pull request #5303 from str4d/zip-239-reject-unknown-cinv
ZIP 239: Reject unknown CInv message types
2021-09-17 01:08:12 +12:00
Jack Grigg 5a2e6183f3 net: Reject unknown CInv message types
Nodes will now reject messages containing unknown CInv message types,
instead of (mostly) ignoring them.
2021-09-15 20:08:01 +01:00
Jack Grigg 07143679dc test: Set up mininodes at the start of feature_zip239 2021-09-15 17:50:57 +01:00
str4d e989923041
Merge pull request #5291 from str4d/zip-239
ZIP 239 support
2021-09-16 03:08:25 +12:00
str4d 5d643898e7
Merge pull request #5293 from mdr0id/smoke_tests_update
Smoke Test Updates (Remove Sprout Logic )
2021-09-15 20:38:40 +12:00
str4d 3467f37c6d
Merge pull request #5299 from str4d/update-deps-4.5.0
Update dependencies for 4.5.0
2021-09-15 20:35:41 +12:00
Jack Grigg 710a5f8a9e Migrate to latest revisions of Zcash Rust crates 2021-09-15 00:35:53 +01:00
Jack Grigg 4b8885759e cargo update 2021-09-15 00:35:53 +01:00
Jack Grigg 1ad8ee8735 qa: Boost 1.77.0
- The patches `iostreams-106.patch` and `signals2-noise.patch` were
  incorporated into Boost 1.75.
- The allocator access deprecation issue was fixed in Boost 1.76.

Closes zcash/zcash#4945.
2021-09-15 00:35:53 +01:00
Jack Grigg 95280c10b0 Add named constants for legacy tx authDigest placeholder value 2021-09-14 21:26:05 +01:00
Jack Grigg befa57d0a6 test: Fix bug in mininode.SpendDescription.deserialize 2021-09-14 21:18:06 +01:00
Jack Grigg 966e285b61 depends: Update Rust to 1.54.0 2021-09-14 17:40:18 +01:00
Jack Grigg 6e562a27df Postpone dependency updates that require CMake 2021-09-14 17:33:25 +01:00
str4d 445d91f7c5
Merge pull request #5295 from daira/librustzcash-authors
Update authors of librustzcash to everyone currently and formerly on Core team (in alphabetical order)
2021-09-14 13:31:01 +01:00
Daira Hopwood dffeb7df04 Update authors of librustzcash to everyone currently and formerly on Core team (in alphabetical order).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-14 10:15:35 +01:00
mdr0id dc41c13593 Update funding logic 2021-09-13 09:54:29 -07:00
mdr0id b6987844f8 Add usage documentation for manual and faucet driven tests 2021-09-10 19:49:52 -07:00
mdr0id 7d7d0e8565 Update funding logic bug 2021-09-10 19:46:33 -07:00
Jack Grigg a97cfd241d test: Implement CInv.__eq__() for mininode to simplify RPC test 2021-09-10 22:13:53 +01:00
Jack Grigg fc8726e6a4 Use wtxid for peer state management 2021-09-10 21:50:24 +01:00
Jack Grigg d503691778 Add MSG_WTX support to inv messages
The change to AlreadyHave() means that nodes will also now send getdata
requests for v5 transactions.
2021-09-10 21:47:42 +01:00