zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
15,383 Commits 27 Branches 108 Tags 109 MiB
Commit Graph

15383 Commits

Author SHA1 Message Date
str4d 59a75f9007
Merge pull request #5343 from nuttycom/feature/listaddresses 
Add `listaddresses` RPC method.
 2021-10-09 05:35:59 +13:00
Kris Nuttycombe d867a8dc67 Use lowerCamelCase for listaddresses JSON 2021-10-08 10:30:39 -06:00
Kris Nuttycombe 23507899a3 Consistently group Sapling addresses by IVK for every source. 2021-10-07 19:58:31 -06:00
Kris Nuttycombe 2221bf5484 Add listaddresses check to wallet_addresses.py 2021-10-07 18:12:13 -06:00
Kris Nuttycombe 9e83d28afb Include `ImportedWatchOnly` as a PaymentAddressSource result. 2021-10-07 17:43:56 -06:00
Kris Nuttycombe 7b40f87404 Update release notes for v4.5.1-1 to reflect the addition of `listaddresses` 2021-10-07 14:25:50 -06:00
Kris Nuttycombe 6b1d290789 Group legacy_hdseed Sapling addresses by account ID. 2021-10-07 13:48:55 -06:00
Kris Nuttycombe f8350ce93d
Apply suggestions from code review 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-10-07 07:41:15 -06:00
Daira Hopwood ee8a8e67e8
Merge pull request #5345 from str4d/nu5-standard-tx 
Mark v5 transaction format as standard for NU5
 2021-10-07 14:14:24 +01:00
Kris Nuttycombe 33e449fcd1
Apply suggestions from code review 
Co-authored-by: str4d <jack@electriccoin.co>
 2021-10-06 20:43:48 -06:00
Kris Nuttycombe 6be880fe34 Correctly handle imported Sapling addresses 
Update the tests to reflect the new listaddresses result
structure.
 2021-10-06 20:39:52 -06:00
Jack Grigg eb85b06c5a Fix comment 
We switched testnet to follow standard rules in zcash/zcash#1604, in
order to find bugs such as the one fixed in the previous commit.
 2021-10-06 20:47:34 +00:00
Jack Grigg a165733372 Mark v5 transaction format as standard for NU5 
Without this change, mainnet and testnet nodes following standard rules
will not accept v5 transactions into their mempools, causing them to be
ignored.
 2021-10-06 20:47:34 +00:00
Kris Nuttycombe 9a11ac73a4 Categorize listaddresses result by source type. 
Addresses managed by the zcashd wallet may be generated using
multiple different sources of randomness and/or the wallet's
HD seeds. Depending upon how addresses are generated, they may
divided into multiple sets, each associated with a separate
spend authority and treated as an independent pool of funds.
In the future, the root spend authority for a wallet will
be a mnemonic seed phrase; the API represented by this PR
anticipates that future and attempts to provide functionality
that will serve both current and future needs, as well as the
transition between them.
 2021-10-06 14:24:35 -06:00
Kris Nuttycombe 64ecf700fc Add `listaddresses` RPC method. 
Closes #5328
Fixes #5338
 2021-10-06 13:55:26 -06:00
str4d e86a1f4927
Merge pull request #5332 from str4d/release-v4.5.1 
Release v4.5.1
 2021-09-29 15:22:22 +13:00
Jack Grigg 4bfbdfa4ef make-release.py: Updated release notes and changelog for 4.5.1. 2021-09-29 01:49:51 +01:00
Jack Grigg 283fd6feda make-release.py: Updated manpages for 4.5.1. 2021-09-29 01:49:50 +01:00
Jack Grigg 3822c716fd make-release.py: Versioning changes for 4.5.1. 2021-09-29 01:40:44 +01:00
Marshall Gaucher 68096bf846
Merge pull request #5331 from str4d/postpone-updates 
depends: Postpone native_ccache 4.4.2
 2021-09-28 17:40:05 -07:00
Jack Grigg a7342cff71 depends: Postpone native_ccache 4.4.2 2021-09-29 01:36:35 +01:00
str4d 9d78cecede
Merge pull request #5330 from str4d/nu5-testnet-update 
Fix bugs in testnet Orchard circuit
 2021-09-29 13:30:30 +13:00
Jack Grigg 6e90c84be7 Fix bugs in testnet Orchard circuit 
The consensus branch ID is updated (as the NU5 consensus rules are
altered). The testnet NU5 activation height is also reset.
 2021-09-28 22:56:37 +01:00
str4d 33a963f3ce
Merge pull request #5326 from str4d/5325-cwallettx-isfromme-fix 
wallet: Check spent shielded notes in CWalletTx::IsFromMe
 2021-09-29 01:30:52 +13:00
Jack Grigg fd49f78042 wallet: Check spent shielded notes in CWalletTx::IsFromMe 
The "IsFromMe" logic was implemented in several places in the Bitcoin
Core wallet. We had correctly updated CWallet::IsFromMe(CTransaction)
(which was used in most places in the wallet) to check for shielded
notes being spent, but did not notice that CWalletTx::IsFromMe also
needed this check.

This bug has existed since before Zcash launched. It went unnoticed
because CWalletTx::IsFromMe was previously only called from code
used to either create purely-transparent transactions, or provide
informational output on non-critical RPC methods.

Closes zcash/zcash#5325.
 2021-09-28 02:51:04 +01:00
str4d 4f43b694c4
Merge pull request #5322 from str4d/release-v4.5.0 
Release v4.5.0
 2021-09-23 22:40:49 +12:00
Jack Grigg 4fb372efdd Add notable changes to v4.5.0 release notes 2021-09-23 05:09:55 +01:00
Jack Grigg 872e95a599 Set testnet activation height for NU5 2021-09-23 05:09:42 +01:00
Jack Grigg a1d17292b4 make-release.py: Updated release notes and changelog for 4.5.0. 2021-09-23 04:20:16 +01:00
Jack Grigg 5ceb64682c make-release.py: Updated manpages for 4.5.0. 2021-09-23 04:20:15 +01:00
Jack Grigg 1bd9152daa make-release.py: Versioning changes for 4.5.0. 2021-09-23 04:12:06 +01:00
str4d 343c4342de
Merge pull request #5320 from str4d/final-deps-4.5.0 
Final dependecy updates for 4.5.0
 2021-09-23 15:06:44 +12:00
Jack Grigg 00724c9f5a Update halo2 and orchard dependencies with BOSL Zcash exception 2021-09-22 23:10:57 +01:00
Jack Grigg 660e938499 cargo update 
Includes pasta_curves 0.2.1, which relicenses to MIT OR Apache-2.0.
 2021-09-22 22:51:26 +01:00
str4d 9338ecd0d6
Merge pull request #5305 from str4d/rust-deps 
contrib: Add script for generating a graph of our Rust dependencies
 2021-09-23 09:48:56 +12:00
str4d 5ef1b9b8cc
Merge pull request #5312 from str4d/fix-connectblockslow-bench 
bench: Add Orchard logic to zcbenchmarks
 2021-09-23 06:45:45 +12:00
Jack Grigg 5731ba431c bench: Add Orchard logic to zcbenchmarks 
The missing `ORCHARD` case in `FakeCoinsViewDB::GetBestAnchor` caused
an exception to be thrown during the `connectblockslow` benchmark.
 2021-09-22 17:32:17 +01:00
str4d 38bdae6df9
Merge pull request #5311 from str4d/wallet-load-orchard-perf 
Fix regression in wallet load performance
 2021-09-23 04:22:38 +12:00
Jack Grigg 03ecb13300 rust: Skip running the Orchard batch validator on an empty batch 
An empty batch will always succeed, but costs a 2-base multi-scaler
multiplication.
 2021-09-22 14:52:47 +01:00
Jack Grigg 092ffed2cc wallet: Batch-validate all Orchard signatures in the wallet on load 
A batch item is 128 bytes, so for a wallet with 200k Orchard actions
this would require around 25MiB, which is reasonable.
 2021-09-22 14:01:53 +01:00
Jack Grigg f9a1986e43 rust: Move Orchard batch logic into BatchValidator methods 2021-09-22 12:36:01 +01:00
str4d a88a98af23
Merge pull request #5307 from str4d/fix-gitian 
Fix Gitian builds
 2021-09-21 10:34:17 +12:00
Jack Grigg 416a4d453f build: Add missing source file to zcash_gtest_SOURCES 2021-09-20 20:15:38 +01:00
Jack Grigg 49cacbc49f build: Ensure that cargo uses vendored dependencies for git repos 2021-09-20 19:11:55 +01:00
Jack Grigg 9c20d7405f build: Add primitives/orchard.h to list of header files 2021-09-20 15:49:28 +01:00
Jack Grigg d087c8b089 cargo update 2021-09-17 13:52:09 +01:00
Jack Grigg 9803111210 contrib: Add script for generating a graph of our Rust dependencies 
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
 2021-09-17 13:38:01 +01:00
str4d 91bb1d3b46
Merge pull request #5304 from str4d/release-v4.5.0-rc1 
Release v4.5.0-rc1
 2021-09-17 23:47:57 +12:00
Jack Grigg 2aa9f766b2 Migrate to latest revisions of orchard and the zcash_* crates 2021-09-17 03:56:32 +01:00
Jack Grigg bfd7b31efe make-release.py: Updated release notes and changelog for 4.5.0-rc1. 2021-09-16 23:34:14 +01:00