Commit Graph

1091 Commits

Author SHA1 Message Date
Alfredo Garcia 0a6ab8a5ab return address info in z_importviewingkey 2020-04-07 08:38:12 -03:00
Homu 1be7250db9 Auto merge of #4411 - str4d:2074-rpc-test-harness-1, r=mdr0id
Backport RPC test harness PRs

Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6548
- https://github.com/bitcoin/bitcoin/pull/6804
  - Just the coverage backend, not the flag to enable it for all RPC tests.
- https://github.com/bitcoin/bitcoin/pull/7744
- https://github.com/bitcoin/bitcoin/pull/9832
  - Excludes `wallet-hd.py` change (missing bitcoin/bitcoin#8309).

Part of #2074.
2020-04-03 03:14:04 +00:00
Homu b5f179d207 Auto merge of #4370 - str4d:3060-sapling-viewing-keys, r=str4d
Add support for Sapling full viewing keys

This PR adds Sapling support to `z_exportviewingkey` and `z_importviewingkey`, and stores imported Sapling viewing keys in the wallet.

Closes #3060.
2020-03-28 02:41:26 +00:00
NicolasDorier b0d81be4cd [qa] assert_start_raises_init_error
Zcash: Excludes wallet-hd.py change (missing bitcoin/bitcoin#8309)
2020-03-24 21:55:08 +13:00
Wladimir J. van der Laan 11240d0928 test_framework: detect failure of bitcoind startup
Replace the `bitcoin-cli -rpcwait` after spawning bitcoind
with our own loop that detects when bitcoind exits prematurely.

And if one node fails to start, stop the others.

This prevents a hang in such a case (see #7463).
2020-03-24 21:55:08 +13:00
James O'Beirne d38a012970 Add basic coverage reporting for RPC tests
Thanks to @MarcoFalke @dexX7 @laanwj for review.

Zcash: Includes all the backend changes, but excludes the --coverage flag
added to rpc-tests.py as we have not yet migrated away from rpc-tests.sh.
2020-03-24 21:51:51 +13:00
ptschip 8f863b2817 Enable python tests for Native Windows
1) Multiplatorm support for devnull
2) Fixed a bug in the handling of cache files
3) Deleted run-bitcoin-cli as no longer needed
2020-03-24 18:05:30 +13:00
Homu c3df71a8e9 Auto merge of #4386 - oxarbitrage:issue4385, r=daira
add check_node_log utility function

Closes https://github.com/zcash/zcash/issues/4385
2020-03-19 13:26:42 +00:00
Alfredo Garcia 77219bdc6c remove unused import 2020-03-19 08:46:33 -03:00
Alfredo Garcia 2707e6ff6c preserve test semantics
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-03-18 22:49:44 -03:00
Taylor Hornby acdad52602 Update updatecheck.py with the new Rust dependencies and improve the error message in case the untracked dependency list becomes out of date. 2020-03-17 14:05:50 -06:00
Homu a125f3f5f8 Auto merge of #4403 - ebfull:rust-tests, r=str4d
Additional librustzcash integration

This adds librustzcash tests to the full test suite, and brings in the release profile configurations that are currently present in the librustzcash workspace on the other repository. It's very important that we build librustzcash with panic=abort because otherwise the unwinding panics across FFI boundaries could cause undefined behavior.
2020-03-17 07:50:48 +00:00
Homu 52f4794055 Auto merge of #4395 - defuse:fix-updatecheck, r=daira
Fix bug in updatecheck.py and add utfcpp to its dependency list
2020-03-16 19:14:48 +00:00
Sean Bowe 81a633c9c3
Simplification for MacOS in rust-test. 2020-03-14 11:06:13 -06:00
Sean Bowe 531c7c2881
Minor typo fixes. 2020-03-14 11:04:39 -06:00
Sean Bowe 7767f8e9e0
Add librustzcash tests to the full test suite. 2020-03-14 10:58:09 -06:00
mdr0id e5e639ae22 Update RPCs to support cross platform paths and libs 2020-03-12 10:27:12 -07:00
Alfredo Garcia b7c8ee64d7 minor cleanup style, var names 2020-03-11 13:43:47 -03:00
Taylor Hornby 11470a3107 Fix typo in updatecheck.py 2020-03-11 10:07:13 -06:00
Taylor Hornby d582270abb Fix bug in updatecheck.py and add utfcpp to its dependency list 2020-03-11 09:11:28 -06:00
Alfredo Garcia 1485c596e7 add stop_node argument to check_node_log, use it in shieldingcoinbase 2020-03-10 14:21:05 -03:00
Alfredo Garcia 1aae365438 use check_node_log in turnstile.py 2020-03-10 11:06:56 -03:00
Alfredo Garcia 461047ac99 move check_node_log framework test to a new file 2020-03-10 11:05:49 -03:00
Alfredo Garcia 9f71fbecca remove space after new line 2020-03-07 09:26:25 -03:00
Alfredo Garcia aa89d3c342 add check_node_log utility function 2020-03-06 19:17:18 -03:00
Homu 35bff6ac7c Auto merge of #4256 - str4d:zip-213-shielded-coinbase, r=daira
[NU3 Heartwood] Shielded Coinbase

Implements [ZIP 213](https://github.com/zcash/zips/pull/217).
2020-03-06 10:19:13 +00:00
Jack Grigg 6fd1b7c2e4 test: Check that shielded coinbase can be spent to a t-address 2020-03-06 13:10:39 +13:00
Jack Grigg 675a9b5fd3 test: RPC test for shielded coinbase 2020-03-06 10:41:27 +13:00
Homu 6c00a8ccf9 Auto merge of #4280 - oxarbitrage:issue2197, r=daira
Allow negative heights in RPC calls

For issue https://github.com/zcash/zcash/issues/2197

Currently adding the feature to `getblock` and `getblockhash`. There is another candidate: `getblocksubsidy` however i want to have some review about these 2 first before repeating what could be a bad approach.
2020-03-05 16:36:32 +00:00
Jack Grigg a62405f44f Store imported Sapling ExtFVKs in wallet database 2020-02-21 01:32:15 +00:00
Jack Grigg 1bcbe4e21d Add in-memory Sapling ExtFVK support to z_importviewingkey 2020-02-21 01:30:02 +00:00
Homu 27c04c8f9c Auto merge of #4146 - str4d:z_viewtransaction, r=str4d
z_viewtransaction

This RPC method returns all decryptable information for any transaction in the wallet.

Several values are conditionally included in the output for convenience:
- `recovered`: True if an output is not for a Sapling address in the wallet.
- `memoStr`: The text form of an output's memo, if it is valid UTF-8.
- Values are provided both in decimal currency units, and integer zatoshis.
2020-02-19 20:52:47 +00:00
Jack Grigg ef5fb6a93c test: Fix pyflakes warnings 2020-02-13 20:04:33 +00:00
Jack Grigg 0d5d329312 test: Hard-code hex memo in wallet_listreceived for Python3 compatibility 2020-02-13 20:04:33 +00:00
Alfredo Garcia 70d5682e31
Merge branch 'master' into issue4004 2020-02-11 10:58:33 -03:00
Alfredo Garcia ebd9d0c562
remove unused imports 2020-02-11 10:56:45 -03:00
mdr0id 1ce2e86612 Update #! env for python3 2020-02-10 13:34:29 -08:00
mdr0id 7300db81ed Updating remaining python3 conventions 2020-02-10 13:15:26 -08:00
mdr0id 4cb368a8d9 Update remaining Python3 conventions 2020-02-10 12:46:41 -08:00
mdr0id 826135d5ed Fix remaining python3 conventions 2020-02-10 12:38:46 -08:00
mdr0id fdac835b13 update comment regarding prior py2 exception 2020-02-09 12:38:01 -08:00
mdr0id 5ac9cb85f3 fix string pattern issue on byte object 2020-02-09 09:07:42 -08:00
mdr0id 9592ded3cc clean up conventions and whitespace 2020-02-09 08:44:23 -08:00
mdr0id 8f859cbf85 fix pyflakes errors 2020-02-09 08:18:00 -08:00
mdr0id 93c625397f Update py3 division 2020-02-09 08:18:00 -08:00
mdr0id c7113bd6f1 Update json to simplejson to remove unicode and str issue from py2 to py3 2020-02-09 08:18:00 -08:00
mdr0id 3eb6512b78 cleanups and fixing odd casting 2020-02-09 08:18:00 -08:00
mdr0id b2752948c0 fix url and port issue 2020-02-09 08:18:00 -08:00
mdr0id 08cfd935d6 clean up 2020-02-09 08:17:32 -08:00
mdr0id 4801c316fc clean up 2020-02-09 08:17:32 -08:00
mdr0id ff5a47acfa clean up 2020-02-09 08:17:32 -08:00
mdr0id 44834ed01c Clean up import calls 2020-02-09 08:17:32 -08:00
mdr0id 3ae42f1e75 Fix decimal 0 issues 2020-02-09 08:17:32 -08:00
mdr0id 0b1a644d54 remove u encoding 2020-02-09 08:17:32 -08:00
mdr0id f26269c512 clean up to minimize diff 2020-02-09 08:17:32 -08:00
mdr0id 2d4f4f0b13 remove debug lines from prior commits 2020-02-09 08:17:32 -08:00
mdr0id 89307b131a update type for decimal 0 2020-02-09 08:15:43 -08:00
mdr0id 8240f73c68 clean up initiliaze statements from imports 2020-02-09 08:15:43 -08:00
mdr0id 4a6aac2c5c fix initialize statements for imports 2020-02-09 08:15:43 -08:00
mdr0id 198b70aa09 fix type issue 2020-02-09 08:15:43 -08:00
mdr0id 51c020bc68 Use upstream encoding for encodeDecimal 2020-02-09 08:15:43 -08:00
mdr0id af903084c7 clean up 2020-02-09 08:15:43 -08:00
mdr0id 7b81c00ee4 clean-up imports, keep string notation consistent, remove spacing 2020-02-09 08:15:43 -08:00
Marshall Gaucher 5ae91f2dcb Update qa/rpc-tests/addressindex.py
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-02-09 08:15:43 -08:00
mdr0id 75c199ead4 correct update to python3 2020-02-09 08:15:43 -08:00
mdr0id 623f3eb9da make import urlparse module consistent,httplib update to py3 2020-02-09 08:15:43 -08:00
mdr0id a9aa622359 Remove semi colons 2020-02-09 08:15:43 -08:00
mdr0id 59068ea071 fix except bug for undefined url 2020-02-09 08:15:43 -08:00
mdr0id 785c3abf05 Clean up code from upstream we dont use 2020-02-09 08:15:43 -08:00
mdr0id 6ed23daf6f Use more meaningful assert_equal from our original codebase 2020-02-09 08:15:43 -08:00
mdr0id 80e4406ee1 update remaining encoding issues, add pyblake2 2020-02-09 08:15:43 -08:00
mdr0id 3f751205b1 update io module, fix py3 division, and string encoding 2020-02-09 08:15:43 -08:00
mdr0id bc14f56398 Clean up code not needed from upstream 2020-02-09 08:15:43 -08:00
mdr0id 99e8292538 Update to py3, ISSUE with encoding in create_block 2020-02-09 08:15:43 -08:00
mdr0id 57ec715d4c Update to py3, ISSUE with encoding in create_block 2020-02-09 08:15:43 -08:00
mdr0id 344ea4433b Update to py3, ISSUE with encoding 2020-02-09 08:15:43 -08:00
mdr0id 2c8b85f612 Update to py3, ISSUE with encoding 2020-02-09 08:15:43 -08:00
mdr0id c36414896e Update io modules for py3, ISSUE with create_transaction function 2020-02-09 08:15:43 -08:00
mdr0id 7648ebf57e update to py3 conventions, BUG with last assert_equal 2020-02-09 08:15:43 -08:00
mdr0id 4c887d528b Update type to be decimal 2020-02-09 08:15:43 -08:00
mdr0id c92cac4776 update encoding, decoding, serialize funcs for py3 2020-02-09 08:15:43 -08:00
mdr0id 09fa601617 update to py3 encodings 2020-02-09 08:15:43 -08:00
mdr0id 843df2a31d update to py3 conventions, clean up code to be upstream consistent 2020-02-09 08:15:43 -08:00
mdr0id be0d6ea8c2 update to py3 conventions, update functions to be upstream consistent 2020-02-09 08:15:43 -08:00
mdr0id f4dcf02062 update to py3 env path 2020-02-09 08:14:21 -08:00
mdr0id 04d218f49d Add keyerror execption 2020-02-09 08:14:21 -08:00
mdr0id c0d7fde366 clean up binascii call 2020-02-09 08:14:21 -08:00
mdr0id 45915145cf update str cast to prevent address assert issues 2020-02-09 08:14:21 -08:00
mdr0id 4403515487 update to py3 conventions, preserve ipv6 patch 2020-02-09 08:14:21 -08:00
mdr0id 1e71f89ffd update to py3 conventions, update cmp to be py3 compatible, update map to return list for py3 2020-02-09 08:14:21 -08:00
mdr0id c3de8a7da5 update to py3 convention, update execfile to py3 call 2020-02-09 08:14:21 -08:00
mdr0id f09e57395f update to py3 conventions, update range to return list for py3 2020-02-09 08:14:21 -08:00
mdr0id 64d767314a Update to py3 conventions, update filter to return list 2020-02-09 08:14:21 -08:00
mdr0id 4fb6d38c38 Update to py3 conventions, update decimal calls to be consistent 2020-02-09 08:14:21 -08:00
mdr0id 6644c70c64 Update py2 modules to py3, update encoding to be py3 compatible 2020-02-09 08:14:21 -08:00
mdr0id 65a02f0984 Standard py2 to py3 updates 2020-02-09 08:14:21 -08:00
mdr0id e241df647f Update cmp to py3 functions, update map return to list for py3 2020-02-09 08:14:21 -08:00
mdr0id d093e45db4 Update py2 env path, remove py2 assert, update http module and assert encoding 2020-02-09 08:14:21 -08:00
mdr0id 32d0583c92 Update py2 env path, remove py2 assert, update filter to return list for py3 2020-02-09 08:14:21 -08:00
mdr0id efc5455d91 Update py2 env path, remove py2 assert 2020-02-09 08:14:21 -08:00
mdr0id 10b25c2b53 Update py2 env path, remove py2 assert 2020-02-09 08:14:21 -08:00
mdr0id 78e6f25820 Update py2 conventions to py3, update Decimal calls 2020-02-09 08:14:21 -08:00
mdr0id a7381d24ee Update py2 conventions to py3, remove py2 env and assert 2020-02-09 08:14:21 -08:00
mdr0id cb81b81576 Update py3 env path, remove py2 assert 2020-02-09 08:14:21 -08:00
mdr0id e017e5c93f Update hexlify for encoding, update to py3 io module 2020-02-09 08:14:21 -08:00
mdr0id 79484ef854 Update python3 env path, remove python 2.7 assert 2020-02-09 08:14:21 -08:00
mdr0id 0123af354b Update ignored testScriptsExt to Python3 2020-02-09 08:14:21 -08:00
mdr0id 82162e7d20 Update rpc-test/test_framework to Py3 convention,modules,encoding 2020-02-09 08:14:21 -08:00
mdr0id bda88213a6 update test_framework modules 2020-02-09 08:09:31 -08:00
mdr0id 3dde472c96 update /usr/bin/env; fix print conventions 2020-02-09 08:09:31 -08:00
Homu e93586a0c4 Auto merge of #4331 - zcash:hotfix-v2.1.1-1, r=ebfull
Hotfix v2.1.1-1

The commits in this PR have been reviewed internally by our team.
2020-02-07 04:50:43 +00:00
Jack Grigg 5199ecdf41 test: Update RPC test cache generation to handle new consensus rule
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-02-04 23:12:36 +00:00
Homu ca55eb4794 Auto merge of #3870 - defuse:update-check-script, r=str4d
Add Python script for checking if dependencies have updates.
2020-01-30 18:27:56 +00:00
Taylor Hornby 1ecf2bae48 Make updatecheck.py compatible with python2 2020-01-30 11:11:37 -07:00
Jack Grigg 877707798c test: Check z_viewtransaction output in wallet_listreceived RPC test 2020-01-29 16:05:44 +00:00
Taylor Hornby 5274f322b6 Cache releases to reduce network usage and improve performance 2020-01-28 14:53:36 -07:00
Taylor Hornby 992de545f9 Wrap long lines 2020-01-28 14:45:13 -07:00
Alfredo Garcia 0f5ef52d2e add estimatedheight to getblockchaininfo
Co-authored-by: Aditya Kulkarni <adityapk@gmail.com>
2020-01-25 13:24:18 -03:00
Alfredo Garcia 76a43b6790 Return address and type of imported key in z_importkey
Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>
2020-01-22 14:41:02 -03:00
Alfredo Garcia 3fb8af512c change regex 2020-01-21 21:24:21 -03:00
Alfredo Garcia 7cb45243fe change convention 2020-01-20 12:23:52 -03:00
Alfredo Garcia fce6000f76 allow negative index to getblockhash 2019-12-31 09:35:37 -03:00
Alfredo Garcia 3ac6dd5f5d add negative height to getblock 2019-12-31 09:16:29 -03:00
Taylor Hornby d7108d36b1 Update list of dependencies to check 2019-12-19 14:33:51 -07:00
Taylor Hornby 49f94dbe3d Add GitHub API credential 2019-12-19 14:33:41 -07:00
Taylor Hornby d83e8a6a44 Add Python script for checking if dependencies have updates. 2019-12-19 13:58:36 -07:00
Homu 0a31c163c6 Auto merge of #4252 - str4d:wallet-interface-refactor, r=str4d
Wallet interface refactor

This refactors the logic introduced in #4144 to improve the separation between the node and wallet. The notifier thread now lives next in `src/validationinterface.cpp` directly next to the existing `CMainSignals` node-wallet interface.

Part of #3877.
2019-12-18 22:48:26 +00:00
Jack Grigg f93db1219b
test: Update wallet RPC test with change to "absurdly high fee" limit 2019-12-18 15:40:50 -06:00
Jack Grigg e77e8660e3
test: Add missing sync_all point
This file was renamed in master, so it was missed in the first commit.
2019-12-18 15:06:54 -06:00
Jack Grigg 4f6b477fb6
test: Reverse hashtx and hashblock ordering at start of ZMQ RPC test
The "hashtx" message was previously triggered synchronously inside
ConnectBlock, while the "hashblock" message is triggered in ConnectTip
immediately after ConnectBlock returns. Thus ZMQ would see a "hashtx"
for every relevant transaction, followed by a "hashblock".

Now, "hashtx" is triggered asynchronously once the cs_main lock is
dropped, which does not occur until after ConnectTip returns. Thus ZMQ
will see a "hashblock" immediately after the block is connected, and
then a "hashtx" for relevant transactions at some point afterwards.
2019-12-18 15:06:54 -06:00
Jack Grigg d57af95802
test: Remove genesis-block Sapling activation from shorter_block_times
Sapling can't be activated in the genesis block without recomputing it,
and we already activate Sapling by default in block 1, which is fine for
this RPC test.
2019-12-18 15:06:54 -06:00
Jack Grigg f7eaf921bc
test: Add sync_all points after block generation to RPC tests
Previously we only required synchronization points where blocks were
sent between nodes; now we need them between action and query operations
on the same node, because wallet notification of mined blocks no longer
occurs in real-time.
2019-12-18 15:06:54 -06:00
Jack Grigg 03db5c8ca3
Tie sync_blocks in RPC tests to notifier thread 2019-12-18 15:06:54 -06:00
MarcoFalke 6d2629dd64
[doc] Fix markdown 2019-12-17 12:18:50 -06:00
Alfredo Garcia 910ff448d6 remove SignatureHash from python rpc tests 2019-12-11 14:46:56 -03:00
Dimitris Apostolou f0003239f8
Change "protect" terminology to "shield" 2019-12-04 23:17:06 +02:00
Homu 868c63f92d Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
Misc upstream PRs

Cherry-picked from the following upstream PRs:

- https://github.com/bitcoin/bitcoin/pull/6077
  - Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
  - Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993)
- https://github.com/bitcoin/bitcoin/pull/6961
  - Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002

Part of #2074 and #2132.
2019-12-04 19:20:44 +00:00
Jack Grigg 1088866455
pyflakes fixes 2019-12-04 19:16:20 +00:00
Gregory Sanders f4d9e06a90
Added additional config option for multiple RPC users. 2019-12-04 17:18:43 +00:00
Homu 9a06ea5ab8 Auto merge of #4221 - rex4539:typo, r=mdr0id
Fix typo
2019-12-03 22:12:39 +00:00
Homu 2383d1b1de Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
Remove option mempooltxinputlimit

This option is no longer used after Overwinter. Fixes #4209.
2019-12-03 20:07:20 +00:00
Alfredo Garcia 7e946d7ccb add blockheight, blockindex and blocktime to z_listreceivedbyaddress 2019-12-03 11:24:30 -03:00
Homu 5e26d48a39 Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id
Bitcoin 0.12 wallet PRs 1

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415

Part of #2074. Closes #3700.
2019-12-03 06:53:27 +00:00
Homu cc807987c9 Auto merge of #4244 - charlieok:add_check_depends_build_step, r=mdr0id
Add check-depends step to STAGE_COMMANDS list

Added to the beginning of the list of stage commands
2019-12-03 03:11:32 +00:00
Marshall Gaucher 017682f993
Update to stop random race error from assert 2019-12-02 17:39:00 -08:00
Marshall Gaucher acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0') 2019-12-02 15:37:10 -08:00
Marshall Gaucher 62f5bdfbdc
Update `import *` to unblock pyflakes from failing 2019-12-02 11:38:33 -08:00
Alfredo Garcia de47393848 fix rpc testcase 2019-11-29 18:27:41 -03:00
Charlie O'Keefe d4f70e5536 Add check-depends step to STAGE_COMMANDS list 2019-11-27 14:12:18 -08:00
Wladimir J. van der Laan e427f70a8c make proxy_test work on servers without ipv6 2019-11-27 10:38:14 -08:00
Dagur Valberg Johannsson fe1ff82a7d Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209.
2019-11-19 10:35:39 +01:00
Matt Corallo 60dc0a9e8e
Implement watchonly support in fundrawtransaction
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524).
2019-11-14 15:46:07 +00:00
Matt Corallo a0d211537c
Add p2sh option to importaddress to import redeemScripts 2019-11-14 14:48:21 +00:00
Dimitris Apostolou 40609b95ff
Fix typo 2019-11-12 12:51:45 +02:00
Homu fd8444d0b7 Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
Remove z_mergetoaddress from experimental state

Closes #3731.
2019-11-11 01:57:21 -08:00
Alfredo Garcia 01998bdc9e remove zmergetoaddress from experimental state in rpc-tests 2019-11-06 10:57:10 -03:00
Eirik Ogilvie-Wigley 1ddc9ff231 Show time elapsed when running RPC tests 2019-10-23 15:04:14 -06:00
Eirik Ogilvie-Wigley 40a7156026 Remove dots and underscores from parameter names 2019-10-21 09:20:17 -06:00
Eirik Ogilvie-Wigley 64fc25ed6e Update parameter names to match ZIP 2019-10-17 16:39:32 -06:00
Eirik Ogilvie-Wigley 2033395e51 minor rpc test clean up 2019-10-17 12:37:05 -06:00
Eirik Ogilvie-Wigley b680185f48 mempool_limit rpc test cleanup 2019-10-09 12:50:00 -06:00
Eirik Ogilvie-Wigley a515b0057a No need to activate Overwinter/Sapling in rpc test 2019-10-07 14:43:44 -06:00
Eirik Ogilvie-Wigley 1a06727c0c Performance: Store weighted transactions in a tree 2019-10-07 14:23:42 -06:00
Eirik Ogilvie-Wigley 0b2c5cfcc2 Grammatical fixes
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley a48b1ba7e2 Rebuild weighted list on removal and fix size calculation 2019-10-07 14:23:41 -06:00
Eirik Ogilvie-Wigley ae9ecf09e8 DoS protection: Weighted random drop of txs if mempool full 2019-10-07 14:23:41 -06:00
Daira Hopwood 7167dc9b2c Test setting an expiry height of 0.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
Homu 961c0d58ec Auto merge of #4060 - str4d:remove-libsnark, r=daira
Remove libsnark

Closes #167. Closes #416. Closes #418. Closes #437.
Closes #521. Closes #743. Closes #750. Closes #894.
Closes #903. Closes #1125. Closes #1136. Closes #1240.
Closes #1264. Closes #1516. Closes #1517. Closes #1651.
Closes #2064. Closes #2158. Closes #3478. Closes #3652.
Closes #3744.
2019-09-26 11:21:40 -07:00
Homu 62dc5f0821 Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
Jack Grigg 9d8322a341
Enable RPC tests to wait on mempool notifications 2019-09-20 21:41:49 +01:00
Jack Grigg 982e924e98
tests: Clean up use of repr() in mininode 2019-09-16 12:23:46 +01:00
Homu 06507722ac Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
insightexplorer: formatting, pyflakes cleanups

These changes were too late (post-review) for the Insight Explorer PRs, see #3708. No functional differences.
2019-09-04 10:57:56 -07:00
Jack Grigg 8669cb692d
test: Update RPC tests to use a minimum of Sapling
The p2p_nu_peer_management and rewind_index RPC tests still start from
Sprout, because they are explicitly (and only) testing network behaviour
across network upgrades.

The mempool_tx_input_limit test is removed because the flag has been
ignored since Sapling activation, and will be removed at some point in
the near future.
2019-08-22 17:26:54 +01:00
Jack Grigg d7d4dd8a0f
test: Add hashFinalSaplingProxy to create_block 2019-08-22 15:44:18 +01:00
Jack Grigg 0097df5c7a
test: Add Sapling v4 transactions to mininode framework 2019-08-22 15:44:16 +01:00
Jack Grigg 3019c0be14
test: Require minimum of Sapling for all RPC tests 2019-08-22 15:42:54 +01:00
Jack Grigg 1f38ad2536
Remove libsnark unit tests from full test suite 2019-08-22 15:42:54 +01:00
Eirik Ogilvie-Wigley b54725fbed
Remove constant
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-19 12:30:24 -06:00
zebambam 5ac48d8ebc Updated location to new download server, fixing #4100 2019-08-18 14:38:49 +01:00
Eirik Ogilvie-Wigley 94f642c80a Enable shorter block times rpc test 2019-08-16 13:21:33 -06:00
Daira Hopwood f58bc7b638 Add RPC test and test framework constants for Sapling->Blossom activation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-16 20:19:18 +01:00
Jack Grigg cfdf040332 test: Fix AuthServiceProxy closed conn detection 2019-08-16 20:19:18 +01:00
zebambam 929b302e40 Updated location to new download server 2019-08-14 11:42:31 -07:00
Larry Ruane 7c5a791b73 insightexplorer: formatting, pyflakes cleanups 2019-08-09 15:27:52 -06:00
Homu 5fd1f5afc0 Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
3708 getblockhashesrpc

Part of #3708
2019-08-09 08:00:17 -07:00
Homu 2528af69ff Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
Implement ZIP 208: Shorter Block Target Spacing

Closes #3690.
2019-08-09 02:35:30 -07:00
Larry Ruane 2e505df351 add timestampindex related RPC getblockhashes 2019-08-08 14:35:07 -06:00
Larry Ruane 86b23f37ad add spentindex RPC for bitcore block explorer 2019-08-07 14:23:42 -06:00
Eirik Ogilvie-Wigley 2f00729061 Add copyright info 2019-08-05 19:05:11 -06:00
Eirik Ogilvie-Wigley 42a21ef004 Test clean up and fixes 2019-08-05 14:52:34 -06:00
Eirik Ogilvie-Wigley 65df6225a6 Do not create transactions that will expire after the next epoch 2019-08-02 16:01:20 -06:00
Homu c68511b876 Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
add addressindex RPC for bitcore block explorer

Addresses #3708
2019-08-01 05:43:29 -07:00
Homu 2300b911f8 Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
Use CommitTransaction

This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.

Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
Jack Grigg 907554be3a
test: Fix pyflakes warnings 2019-08-01 10:43:03 +01:00
Jack Grigg 8e48ca1fb2
test: Fix permissions on wallet_changeaddresses RPC test 2019-08-01 10:21:27 +01:00
Larry Ruane 68e174e22b add addressindex related RPCs 2019-07-31 10:31:16 -06:00
Jack Grigg 6bc69c39cb
test: Check for change t-addr reuse in z_sendmany 2019-07-31 12:11:14 +01:00
Eirik Ogilvie-Wigley 07851670b4 Temporarily disable test 2019-07-29 15:04:34 -06:00
Eirik Ogilvie-Wigley 102dafdf89 Update block subsidy halving for zip208 2019-07-29 13:44:53 -06:00
Homu 5306121e5c Auto merge of #4075 - Eirik0:4059-fix-migration-test, r=Eirik0
Fix nondeterministic failure in sapling migration test

Fixes #4059
2019-07-26 01:06:55 -07:00
Eirik Ogilvie-Wigley a63ec6e717 Shorter block times rpc test 2019-07-25 12:49:15 -06:00
Eirik Ogilvie-Wigley 5fc227c7dd
Apply suggestions from code review
Show migration status in assertion failures

Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-07-25 12:35:10 -06:00
Eirik Ogilvie-Wigley 6a3f9d8260 Clean up and fix typo 2019-07-24 15:43:08 -06:00
Homu 6da42887f1 Auto merge of #3944 - daira:update-license-info, r=daira
Update license info

Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.

Fixes #2827.
2019-07-24 04:07:03 -07:00
Eirik Ogilvie-Wigley ded45b90d7 Fix nondeterministic failure in sapling migration test 2019-07-20 14:36:08 -06:00
Daira Hopwood 2fe59a5681 qa/zcash/checksec.sh is under a BSD license, with a specialized non-endorsement clause.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:31:39 +01:00
Daira Hopwood bc909a7a7f Replace http with https: in links to the MIT license.
Also change MIT/X11 to just MIT, since no distinction was intended.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
Homu 1c899f5a83 Auto merge of #4044 - Eirik0:fix-mergetoaddress-test-comment, r=Eirik0
Fix comment in mergetoaddress RPC test
2019-07-18 06:12:22 -07:00
Dimitris Apostolou f57f76d789
Rename vjoinsplit to vJoinSplit 2019-06-16 19:13:49 +03:00
Eirik0 c9d14272af Fix comment in mergetoaddress RPC test 2019-06-11 14:32:57 -06:00
Larry Ruane f381d4e085 add spentindex to getrawtransaction RPC results 2019-06-11 10:29:51 -06:00
Eirik0 a8055cfe10 Fix z_mergetoaddress sending from ANY_SPROUT/ANY_SAPLING when the wallet contains both note types 2019-06-10 13:21:25 -06:00
Eirik0 bb0a3e1cb5 Remove old mergetoaddress RPC test 2019-05-22 16:01:50 -06:00
Eirik0 23d9826ef9 Fix LogPrint statements 2019-05-10 17:25:30 -06:00
Eirik0 7470ae8885 Do not automatically remove async migration operations and return txids 2019-05-10 17:19:56 -06:00
Daira Hopwood e7529049fb Test the expiry height of migration transactions.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
Eirik0 7cf4749d0d Correctly account for migration transactions in the mempool
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
Eirik0 345177cfc1 Do not look at vin/vout when determining migration txs and other cleanup 2019-04-30 09:52:53 -06:00
Eirik0 e9530f40f2 use -valueBalance rather than vpub_new to calculate migrated amount 2019-04-29 17:00:26 -06:00
Eirik0 108e587c14 Fix typos and update documentation 2019-04-29 15:29:29 -06:00
Eirik0 2276133bb3 Test migration using both the parameter and the default Sapling address 2019-04-29 15:29:29 -06:00
Eirik0 6e82d72852 Add rpc to get Sprout to Sapling migration status 2019-04-29 15:28:35 -06:00
Eirik0 6acb37bcee Check for full failure message in test case 2019-04-26 19:01:23 -06:00
Eirik0 5519d16997 Set min depth when selecting notes to migrate 2019-04-25 13:43:23 -06:00
Eirik0 d2a584e35a Refactor wait_and_assert_operationid_status to allow returning the result 2019-04-24 11:31:14 -06:00
Eirik0 699288b4b4 Documentation cleanup 2019-04-24 11:31:14 -06:00
Eirik0 81a45d6984 Add rpc to enable and disable Sprout to Sapling migration 2019-04-24 11:31:14 -06:00
Simon d6b47948bf Add qa test for experimental feature: -developersetpoolsizezero 2019-04-23 15:05:15 -07:00
Jack Grigg 3cb20f26a1
test: Make expected_utxos optional in get_coinbase_address() 2019-03-06 09:03:55 +13:00
Jack Grigg b0f1d643aa
test: Fetch coinbase address from coinbase UTXOs
After upstream PR bitcoin/bitcoin#5994, the first call to getnewaddress after
startup does not return the address being used by the miner.
2019-03-06 09:03:51 +13:00
Homu 48b7dea5a8 Auto merge of #3639 - leto:size_on_disk, r=bitcartel
Port getblockchaininfo.size_on_disk from BTC master

Closes #3630.
2019-02-25 10:08:44 -08:00
Jack Grigg ecde950bac
Add Sapling benchmarks to benchmark runner 2019-02-16 18:44:16 +00:00
Eirik Ogilvie-Wigley a482e4c9fa Strategically sync to prevent intermittent failures 2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley 32212cbad7 Extract helper methods 2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley 5e654035a6 fail test if pong is not received 2019-01-17 15:00:57 -07:00
Eirik Ogilvie-Wigley 3dab742638 Check entire contents of mempool 2019-01-17 15:00:52 -07:00
Eirik Ogilvie-Wigley 57dcc9e6bf Make variables local 2019-01-17 14:58:50 -07:00
Eirik Ogilvie-Wigley 73859fd218 Move common code to helper 2019-01-17 14:58:46 -07:00
Eirik Ogilvie-Wigley 23b329d912 flake8 cleanup 2019-01-14 14:00:24 -07:00
mdr0id 4ca5def62f Make pythonisms consistent 2018-12-18 12:16:23 -08:00
Simon 067b6f9373 For ZEC-013. Update qa tests broken by expiring soon threshold. 2018-11-17 09:02:10 -08:00
Simon 4484c76202 For ZEC-013. RPC createrawtransaction returns error if tx expiring soon. 2018-11-17 09:02:10 -08:00
Simon cc1ab2db55 For ZEC-013. Don't propagate txs which are expiring soon in p2p messages.
When responding to "mempool" message, do not include the txid of an
expiring soon transaction in the "inv" message reply.
When responding to "getdata" message, do not reply with a "tx" message
for a transaction which is expiring soon.
2018-11-17 09:02:00 -08:00
Simon f8cd79c2de For ZEC-013. Mitigate potential tx expiry height related DoS vector.
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
2018-11-17 09:01:49 -08:00
Simon 43040e9384 Add support for "notfound" message to mininode. 2018-11-17 08:27:41 -08:00
Homu a47e1fda73 Auto merge of #3684 - str4d:load-sapling-chain-value, r=bitcartel
Load sapling chain value into memory

`CBlockIndex::nSaplingValue` has been correctly set and written to disk since before Sapling activated, meaning that all nodes now are correctly tracking the Sapling shielded pool value on-disk. However, on restart the per-block values are not being read into memory, and so the in-memory pool value appears to be zero on every restart. Setting `nSaplingValue` in-memory during block index loading fixes the problem.
2018-11-16 21:07:46 -08:00
Eirik Ogilvie-Wigley e0b89f59f9 Adjust z_mergetoaddress assertions in Sapling rpc test 2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley 0adb77d32e Add locking for Sapling notes 2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley 487c9020bd Add Sapling support to z_mergetoaddress 2018-11-16 18:14:58 -07:00
Eirik Ogilvie-Wigley e0c491c073 Extend Sprout mergetoaddress rpc test to also work for Sapling 2018-11-16 18:14:57 -07:00