Commit Graph

504 Commits

Author SHA1 Message Date
Matthew Kennedy 54a4eed7d7 trigger decoder init 2024-04-25 16:58:19 -07:00
Matthew Kennedy f60845e38c fix sim 2024-04-25 16:42:40 -07:00
Matthew Kennedy 79dfb0f2c4 wrap times in simple structs 2024-04-25 15:46:53 -07:00
Matthew Kennedy e332b32ed1 distinguish between "timestamp" and "duration" 2024-04-25 12:57:10 -07:00
Matthew Kennedy 61dd44a4ba test for noisy triggers and another fix 2024-04-12 11:29:38 -07:00
Matthew Kennedy 52c2aa45ea
fix overdwell in case of noisy trigger (#410) 2024-04-12 04:08:58 -05:00
Matthew Kennedy a427a46ffc dead line 2023-11-01 16:40:53 -07:00
Matthew Kennedy baebd29adb shadowing in trigger land 2023-11-01 15:54:03 -07:00
Matthew Kennedy ce2198270e avoid some misc shadowing 2023-11-01 13:58:39 -07:00
Matthew Kennedy 7b955cb1b3 fixAngle -> wrapAngle 2023-10-19 14:34:29 -07:00
Matthew Kennedy 7ae11160d9 simplify adjustCrankPhase 2023-06-28 18:12:38 -07:00
Matthew Kennedy 06b39dbb07
trigger and engine types -> enum class (#113)
* trigger type is enum class

* java tooling

* enum class engine_type_e

* enum class engine_type_e
2023-06-01 13:47:49 -07:00
Matthew Kennedy d5f9479f28
ObdCode is enum class (#77)
* change ObdCode to enum class builds firmware

* test builds

* don't need this line at all

* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy 1adc62deaf trigger decoder less TriggerValue #55 2023-02-28 02:44:46 -08:00
Matthew Kennedy d7681bf194 no TriggerValue for vvt: #55 2023-02-28 02:11:28 -08:00
Matthew Kennedy e6b07e636d guard 2023-02-22 23:46:16 -08:00
Matthew Kennedy 1440647ba5 better self stim behavior: allow sync w/ NB trigger 2023-02-22 23:16:01 -08:00
Andrey 0337cb44ac Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey eb9c096ab7 a bit of dead code 2023-01-03 07:49:17 -05:00
Andrey 77caa77b4b trigger refactoring: instance RPM fix #4740 2022-11-06 12:03:55 -05:00
Andrey 153a454472 trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
Andrey 9edfda7f72 trigger refactoring: instance RPM #4740 2022-11-06 11:45:51 -05:00
Andrey f7daa5df72 trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey ba17b83bea trigger refactoring: instance RPM #4740 2022-11-06 11:12:20 -05:00
Andrey f8cce72779 trigger refactoring: instance RPM #4740 2022-11-06 10:58:04 -05:00
rusefillc 2d96fb3ef6 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc 8bcbb2b9b1 learning C++ 2022-11-06 00:17:24 -04:00
rusefillc 6c8325c0c2 more fancy 2022-11-06 00:10:50 -04:00
Andrey 72ed388948 minor trigger refactoring 2022-11-05 21:43:12 -04:00
rusefillc cb9e33d501 dead lines 2022-11-05 17:21:30 -04:00
rusefillc bcafeb471b dead lines 2022-11-05 15:20:02 -04:00
Andrey G cc9b1517ac compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
Matthew Kennedy f2c8a0192c fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy dbf8a1ea2a #4619 (#4620) 2022-09-25 07:40:28 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc b4bc5551db tear down Engine god object #4511 2022-09-15 22:06:16 -04:00
rusefillc 918112d588 tear down Engine god object #4511 2022-09-15 22:00:07 -04:00
rusefillc 03d176ca61 tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
rusefillc 1c28ca0582 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey G 1ca5988877 time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc f9b849dd8f refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 3c647c6442 huh? dead code? how can we get NAN from eventAngles table? (#4549) 2022-09-07 23:45:33 -04:00
Andrey 3c1cc0b857 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 8253156233 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 21:45:59 -04:00