Commit Graph

624 Commits

Author SHA1 Message Date
Matthew Kennedy d19e2b2499 refacto 2020-07-24 18:26:24 -07:00
Matthew Kennedy b1747ea48b goodbye plain maf 2020-07-23 02:46:45 -07:00
Matthew Kennedy 7940b84778 start refactor 2020-07-22 13:11:07 -07:00
Matthew Kennedy 5fce27da8b Merge remote-tracking branch 'upstream/master' into reset-overlap 2020-07-19 13:52:45 -07:00
rusefi 26f85c4e11 better unit test logging 2020-07-19 14:58:46 -04:00
Matthew Kennedy c21b60eeb8 add reset 2020-07-14 23:54:41 -07:00
Matthew Kennedy a79153bbea correct batch fuel cylinder pairing (#1595)
* correct batch fuel cylinder pairing

* param

* only change behavior on two wire batch

* Add tests for two wire batch & sequential

* improve testing a little bit

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
Matthew Kennedy c60b425ef0 plumb new load channels (#1573)
* wire up new channels

* add deprecation comment

* add gauges

* these tables are indeed used in those modes

* simplify

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-05 16:25:19 -04:00
Matthew Kennedy cf624a7ab1 support 1-3-2 firing order (#1537)
* support 1-3-2

* oops

* correct TS

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-26 09:07:43 -04:00
Matthew Kennedy 2525a9a22c Factor out airmass logic (#1483)
* refactor

* extract more airmass

* rename, fix tests
2020-06-06 07:25:19 -04:00
Matthew Kennedy 9ecb0a4e55 refactor (#1481) 2020-06-03 21:12:12 -04:00
Matthew Kennedy 38cb254de3 remove maf2map mode (#1474)
* remove

* remove fully

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
rusefi 5d39e3e088 partial rollback 2020-05-23 19:17:15 -04:00
rusefi 6f5592ed2a partial rollback 2020-05-23 18:11:04 -04:00
rusefi 44b4c4bf25 partial rollback 2020-05-23 18:01:40 -04:00
rusefi d75a50fde5 partial rollback 2020-05-23 18:00:20 -04:00
Matthew Kennedy a2313a853c switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi 4015c600e9 MRE pre-sets 2020-05-21 20:44:14 -04:00
rusefi a390ec744e no comments 2020-05-21 18:28:35 -04:00
Matthew Kennedy 424a86be7b short term fuel trim: part 2 (#1405)
* add tooltip

* add other direction to deadband

* add impl

* test partitioning

* makefile

* wrong comment

* fix include
2020-05-07 08:52:32 -04:00
Matthew Kennedy 55159cae44 short term fuel trim: part 1 (#1402)
* add cell

* add stft cell tests

* add bit

* minimally generate

* config defaults
2020-05-06 21:00:40 -04:00
Matthew Kennedy 10903c4659 remove "plain MAP" mode (#1398)
* consumers

* enums, input, config

* java

* default config cleanup
2020-05-05 15:04:55 -04:00
rusefi 65fde14800 Add firing order fix #1385 2020-04-29 16:46:59 -04:00
Matthew Kennedy 1397a718a9 improve tcharge error handling (#1328) 2020-04-19 15:02:40 -04:00
Matthew Kennedy 83592f0dff New clt consumers part 1 (#1301)
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup
2020-04-15 09:48:17 -04:00
Matthew Kennedy 606a7fff0d More TPS consumers: VE lookup (#1256)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
Matthew Kennedy 0ac3e06149 cleanup extern mess (#1237)
* cleanup

* move outside define
2020-03-29 19:06:03 -04:00
Matthew Kennedy a2a5b40ced Support disabling most/all features (#1162)
* this flag did nothing

* guard features properly
2020-02-26 18:16:35 -05:00
Matthew Kennedy fa8553b00d Stricter compile options (#1132)
* stricter

* don't warn on that one

* this code was dead
2020-02-08 08:05:40 -03:00
rusefi a222ecdfe1 happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 63e3e84e08 happy new year 2020-01-08 00:02:40 -05:00
rusefi 4605c64a07 that's not a worth a file 2019-12-24 00:03:53 -05:00
rusefi f47a1a16d1 getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi bcec694eb1 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi 07b7b62bca refactoring 2019-12-02 23:08:18 -05:00
rusefi c5e60a7f93 improving API? 2019-11-24 00:15:44 -05:00
Matthew Kennedy 0a7535fb1f Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
Matthew Kennedy 8fd603dca9 Merge remote-tracking branch 'origin/master' into perf-tracing 2019-11-19 16:28:58 -08:00
rusefi 12f65748b3 typo 2019-11-17 09:18:43 -05:00
rusefi 17a2847424 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-06 18:26:50 -05:00
rusefi 92d1842bd0 refactoring 2019-11-05 23:17:44 -05:00
rusefi 359f7c437b skeleton & docs (#995)
* Documentation additions and clarifications.

Added config/boards/skeleton/ as an example and starting point for
board-specific support.

* Describe where the generated files came from.

* Minor rewording

* Delete mistakenly added emacs backups

* Added an overall description and build notes
2019-11-03 08:41:14 -05:00
rusefi be9a67e67e IM_TWO_COILS 2019-10-27 16:19:59 -04:00
rusefi a8a0bc007a docs 2019-10-26 21:53:22 -04:00
Matthew Kennedy 97d848bb3e profile all the things 2019-10-13 13:14:08 -07:00
rusefi 9776d3c57d better handling of corner case 2019-10-10 07:07:59 -04:00
rusefi 15ae9b1580 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 46e1ff671a refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi 9a961fd0c2 do not let "Use fixed baro corr from MAP" kill VE fix #960 2019-09-29 09:58:29 -04:00
rusefi 7d68b3d829 firing order 1-2-7-8-4-5-6-3 2019-09-28 10:25:57 -04:00
rusefi 0a92693729 Most important feature: VAG W12 firing order 2019-09-14 14:47:22 -04:00
rusefi 8be592f3d4 Live Data progress 2019-09-01 13:56:46 -04:00
rusefi de813b5f2c unit tests code coverage #653
one day I will migrate rusEfi to java
2019-08-25 13:42:07 -04:00
rusefi d861b1af90 unit tests code coverage #653
reducing technical debt just a little
2019-08-25 10:19:01 -04:00
rusefi 3ae955b3e5 reducing unit test noise 2019-08-25 02:01:09 -04:00
rusefi 91bcd035af reducing unit test noise 2019-08-25 01:15:18 -04:00
rusEfi 92f371c121 new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
rusefi 6c45dfbc50 new 4 cylinder firing order! 2019-08-15 19:36:16 -04:00
rusefi f6971c2bea WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
refactoring to begin with, zero logic change
2019-08-08 00:19:09 -04:00
Matthew Kennedy e4a0a0ae91 Fix some maf logic (#880)
* fix maf

* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
Matthew Kennedy 0b52f5b542 Template-ize bin/value length for interpolation (#878)
* update consumers

* tests

* whitespace

* format
2019-07-09 21:16:36 +03:00
rusefi f906098718 refactoring 2019-07-08 18:02:21 -04:00
rusefi e309e223aa Refactoring: OS access should be explicit #867 2019-07-04 03:57:21 -04:00
rusefi 777eb532dc Refactoring: OS access should be explicit #867 2019-07-03 21:48:04 -04:00
rusefi c21e4c2efa Refactoring: OS access should be explicit #867 2019-07-03 21:01:48 -04:00
rusefi d8a64f1cce fixing build 2019-06-19 23:32:09 -04:00
rusefi f2a034b5aa Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-19 22:34:11 -04:00
rusefi 35d3cc0ac4 docs/type safety 2019-06-19 21:24:09 -04:00
rusefi ed4b2cc17e Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-19 00:05:23 -04:00
rusefi dd43f62706 Annotations in C++ code to produce formulas in rusEfi console #807 2019-06-18 23:23:30 -04:00
rusefi d90c6ee1a3 Annotations in C++ code to produce formulas in rusEfi console #807 (#847)
* Annotations in C++ code to produce formulas in rusEfi console #807
firmware part of the change

* removing unneeded stuff & fixing unit test compilation

* not complete better unit test compilation fix  :(

* better C++ usage
2019-06-17 12:18:55 -04:00
Matthew Kennedy 89f59db75f Fix tunerstudio ratio vs. percent (#838)
* fix ratio vs pct

* fix idle cranking clt position

* fix defaults

* fix typo

* fix baro corr gauge

* baro default

* fix degree symbols

* fix testFuelMap

* fix testPlainCrankingWithoutAdvancedFeatures

* test testFasterEngineSpinningUp
2019-06-13 09:05:22 -04:00
Matthew Kennedy 515ab03688 const, explicit, and override (#831)
* const, explicit, and override

* more const

* more const

* missed a spot
2019-06-08 09:51:36 -04:00
rusefi 998345ef9e unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi c52e5aa465 refactoring: better variable names 2019-05-27 11:17:28 -04:00
rusefi 65fb45c8a6 The Big Refactoring of 2019: folder structure #723 2019-04-25 22:10:58 -04:00
rusefi 884c54a185 defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi 59d33c4cdc The Big Refactoring of 2019: folder structure #723 2019-03-31 17:44:34 -04:00
rusefi e28ce71bb8 unifying_file_naming 2019-03-29 09:11:13 -04:00
rusefi cb559a3259 #657 fixing fresh defect 2019-02-01 22:55:35 -05:00
rusefi a9d39f760d #657 2019-02-01 21:24:07 -05:00
rusefi cffac9b28e better conditional compilation 2019-01-31 18:30:40 -05:00
rusefi f475fb1691 better conditional compilation 2019-01-31 17:55:23 -05:00
rusefi 175a9f8ca5 #656 trying a new idea 2019-01-28 03:25:28 -05:00
rusefi db9a99b0c5 #656 global is not great 2019-01-28 02:29:13 -05:00
rusefi f1485cf8b4 #657 2019-01-28 01:25:23 -05:00
rusefi 0cd324ecac better (?) location for files 2019-01-28 01:09:13 -05:00
rusefi 5c40815758 no comment 2019-01-28 00:00:19 -05:00
rusefi 6607b833f7 #657 2019-01-27 23:41:46 -05:00
rusefi afc4f1da51 #669 renaming error code 2019-01-26 13:19:18 -05:00
rusefi ad64e1b410 refactoring around GET_RPM 2019-01-21 20:33:21 -05:00
rusefi 6244cda6b4 better method name and docs related to improved craking logic 2019-01-20 11:33:40 -05:00
rusefi 1bcefa5690 MAF2MAP convestion #538 2019-01-13 01:53:58 -05:00
rusefi c1509dd0b7 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-10 19:25:07 -05:00
Matthew Kennedy a75e5fb007 const (#648) 2019-01-05 08:06:18 -05:00
rusefi 7ba963ab3b #635 2019-01-01 14:05:11 -05:00
Fabien Poussin 1f29b5dd37 Workarounds for GCC 8 (#637) 2018-12-27 09:40:40 -05:00
rusefi 095d9d4417 #625 big step - no more engine dependency from TriggerShape 2018-12-25 22:47:29 -05:00
rusefi fdddbc976b #635 2018-12-25 12:27:34 -05:00
rusefi c81a9c8fd1 better location for shared input 2018-12-08 16:06:14 -05:00
rusEfi 9c6bb2d08f better logging 2018-11-26 21:40:41 -05:00
rusEfi 7f90b056cc better logging 2018-11-26 21:14:21 -05:00
rusEfi 0964c347cf little progress 2018-11-25 23:13:03 -05:00
rusefi 5534dec66e PID auto tune unit test 2018-11-22 23:42:30 -05:00
rusefi 14d0183ebc docs 2018-11-22 23:15:05 -05:00
rusefi f1aaf779ce PID auto tune unit test 2018-11-22 23:06:06 -05:00
rusefi b646c994d7 PID auto tune unit test 2018-11-22 22:14:32 -05:00
rusefi db29fac09e PID auto tune unit test 2018-11-22 18:56:51 -05:00
rusefi b07e904adf PID auto tune unit test 2018-11-22 18:43:41 -05:00
rusefi 10bf805f14 migrating to a much nicer pid auto tune lib 2018-11-20 23:19:16 -05:00
rusefi a48efd2624 unused 2018-11-18 23:51:47 -05:00
rusefi 7e5850fa60 moving to nicer implementation 2018-11-18 23:28:18 -05:00
andreika-git bfb07e1522 STM32F7: Fix Unit-tests (#621) 2018-11-16 08:08:20 -05:00
andreika-git 96dfebc542 STM32 Nucleo144-F767ZI board: Initial support (#620)
* More EFI_ #ifdefs for config flexibility

* Even more config flexibility

* New firmware/config/stm32f7ems/* files

* New firmware/config/boards/NUCLEO_F767/* files

* New firmware/hw_layer/stm32f7/* files

* Fix for EFI_USB_SERIAL

* Adding #if defined(STM32F7XX)

* SPI flags changed in F7: SPI_CR1_DFF --> SPI_CR1_CRCL

* I2Cv2 config changed in F7

* More versatile CCM defines

* Makefiles

* Double #ifs cleanup

* docs
2018-11-16 07:40:06 -05:00
rusEfi ff447e7e3c better error handling 2018-11-10 20:53:28 -05:00
rusefi 42b68c6d1e docs 2018-10-13 09:24:41 -04:00
rusEfi 6a53e870a4 new debug field 2018-10-10 22:19:20 -04:00
andreika-git 3001f2837d AirFlow-interpolated tCharge Mode (#612)
* Add vars & enums

* updateTChargeK()

* limitRateOfChange()

* Impl. AirFlow-interpolated tCharge mode

* Update tsOutputChannels: tCharge & airFlow

* Set default config params

* Unit-tests

* Fix tChargeMode_e
2018-09-29 12:16:36 -04:00
rusefi 553969dc72 refactoring 2018-09-16 22:26:57 -04:00
rusefi 92df53aec9 error codes 2018-09-10 22:10:55 -04:00
rusefi 70b91d2295 names for error codes 2018-09-10 22:00:13 -04:00
rusefi b2ca20c0b4 separating data structure from global state 2018-08-31 22:19:19 -04:00
rusefi b43d5f42db docs 2018-08-29 07:43:21 -04:00
rusefi 4c2ecf25eb better method name 2018-07-29 16:30:23 -04:00
rusEfi 55d6e252c8 wider macro usage 2018-07-28 19:16:58 -04:00
rusefi c313cdc0b1 making error condition less fatal
#598
2018-07-28 15:36:47 -04:00
rusefi fee08b0199 #598 better state initialization 2018-07-28 14:28:52 -04:00
rusefi 529fe56c02 #598 2018-07-28 14:01:28 -04:00
rusefi e27becc8e4 #598 really strage error 2018-07-28 13:58:19 -04:00
rusefi 2f95cd1e0d step towards more unique codes 2018-07-25 23:30:00 -04:00
rusefi 60b3aa8e60 unique error codes #598 2018-07-25 23:03:04 -04:00
rusefi 1af16c58dd #598 2018-07-24 20:40:44 -04:00
rusefi 5b503b1cbe refactoring: reorder to remove forward reference 2018-07-24 20:15:38 -04:00
rusEfi 4ae468e7d3 per error code 2018-07-23 21:38:05 -04:00
rusefi f62f9563d3 error code into angle validation 2018-07-23 21:03:20 -04:00
rusefi 58d6363f3a more detailed warning 2018-06-12 05:45:11 -04:00
rusefi 3f850ea35b better field name 2018-05-08 13:33:49 -04:00
andreika-git 3f5cae14c9 Idle PID Coasting & Amplification Improvements (#589)
* PID Error Amplification Coef

* Add settings: useIacTableForCoasting,pidExtraForLowRpm,iacCoasting

* Modify interface for the new settings

* Run gen_config.bat and generate configs

* idlePositionSensitivityThreshold

* Remove cltCorrection from autoIdle() & more verbose debug

* Impl. idlePidRpmDeadZone and pidExtraForLowRpm; reset PID when deactivated

* Impl. useIacTableForCoasting+iacCoasting and idlePidRpmUpperLimit
2018-03-30 08:42:13 -04:00
rusEfi f5ce12204d chasing that funny issue on change engine 2018-03-20 23:12:32 -04:00
andreika-git eb27c6b6e4 Impl. faster engine spin-up mode (alpha-version) (#567)
* Impl. faster engine spin-up mode (alpha-version)

* A comment for RPM_LOW_THRESHOLD

* Faster engine stop detection

* Safety check for instant RPM on spinning-up

* rusefi.xml

* unit-tests & relevant fixes
2018-03-10 20:58:51 -05:00
rusefi e0d47ff3c9 progress 2018-03-03 09:11:49 -05:00
rusefi 349aca993d extracting macro 2018-02-03 10:48:35 -05:00
rusefi 0e05a4f707 tiny fix 2018-01-28 13:14:18 -05:00
rusEfi cc83f8bd2e why?... 2018-01-25 19:29:28 -05:00
rusefi adfe5e9274 #65
explicit precision control
2018-01-23 12:05:14 -05:00
rusefi f5a4376036 happy new year 2018-01-20 20:55:31 -05:00
rusEfi 9502576a97 better state validation 2018-01-13 21:47:34 -05:00
rusEfi 87f47b4a0e better method name 2018-01-07 11:17:49 -05:00
rusefi f025052f37 docs 2017-12-24 21:26:42 -05:00
andreika-git 106d1eb8d6 New PID with CIC integrator (#519) 2017-12-24 21:17:10 -05:00
rusefi 4f424c495f typo 2017-12-11 10:07:13 -05:00
rusEfi 9c8db36591 softer error handling 2017-12-03 18:17:59 -05:00
rusefi 8e95dce3ec better constraint validation 2017-12-02 22:29:50 -05:00
rusefi 66ce611bdb better state validation 2017-12-02 18:58:40 -05:00
rusefi 715df72beb better state validation 2017-12-02 18:58:27 -05:00
rusefi 3c410e14fe better error handling 2017-11-19 21:30:59 -05:00
rusefi d32e06865b better field name 2017-11-06 22:29:39 -05:00
rusefi 5bbf7fc1fa refactoring: better method name 2017-11-06 21:48:25 -05:00
rusefi 4c97892a4d fixing build 2017-11-06 21:37:21 -05:00
rusefi 070f67e13d refactoring - better variable name 2017-11-06 21:30:39 -05:00
rusefi 43f11c4425 #487 2017-11-06 19:00:30 -05:00
rusefi a0d5ed9529 better state validation 2017-10-29 16:42:36 -04:00
rusefi ad3b41d391 docs 2017-10-09 07:46:50 -04:00
rusEfi 1b7ffd040b minor etb 2017-09-17 22:05:03 -04:00
rusefi 6567c25779 PID auto tune 2017-09-14 22:07:26 -04:00
rusefi a24dba13f4 PID auto tune 2017-09-14 21:49:26 -04:00
rusefi ee273e07db PID auto-tune 2017-09-13 22:46:55 -04:00
rusefi e5bb803869 pid auto-tune 2017-09-13 22:08:59 -04:00
rusefi 8a7ad52f80 fixing build 2017-08-26 20:10:50 -04:00
rusefi 8bbd3fcc62 better state validation 2017-08-26 19:54:06 -04:00
rusefi 675a8edf70 P parameter multiplier for logs 2017-07-23 12:12:35 -04:00
rusefi e3384235b0 refactoring: OOP 2017-07-10 21:47:51 -04:00
rusefi 7d96b15696 RPM refactoring done 2017-07-08 07:19:26 -04:00
rusefi fccac7b1b3 RPM refactoring 2017-07-06 17:26:32 -04:00
rusefi 11265ca1d7 RPM refactoring 2017-07-06 11:19:02 -04:00
rusefi 18de018cda RPM refactoring 2017-07-06 11:15:29 -04:00
rusefi 3fdc29873b RPM refactoring 2017-07-06 08:49:55 -04:00
rusefi c0deef0a5e docs 2017-06-11 14:59:03 -04:00
rusefi 18a3d18781 refactoring 2017-06-11 14:40:29 -04:00
rusefi 5536f4bdd2 Lamborghini Diablo firing order 2017-06-08 20:35:42 -04:00
rusEfi a1201c5930 change of PID period to reset PID 2017-06-04 13:21:07 -04:00
rusEfi b467d70f85 good enough solution for now #435 2017-06-04 12:59:24 -04:00
rusefi cd028fd722 PID reset counter for all! 2017-06-03 10:37:26 -04:00
rusefi 6b61023b6d #435 2017-06-02 22:28:12 -04:00
rusefi a85db3c357 PID reset counter 2017-06-02 21:34:00 -04:00
rusEfi 543586c179 PID progress 2017-05-29 23:32:41 -04:00
rusEfi 013f30727f PID refactoring 2017-05-29 23:15:07 -04:00
rusEfi 4234900eaa refactoring & status fix 2017-05-29 22:51:14 -04:00
rusefi 10fd879363 better error code names 2017-05-29 19:23:15 -04:00
rusefi 9c32e85d86 better error handling 2017-05-29 11:31:07 -04:00
rusefi 3fb5167f7a PID storage refactoring - minor incompatible storage change 2017-05-28 22:32:32 -04:00
rusefi 38247d6fcf progress 2017-05-28 22:10:35 -04:00
rusefi 2eb9da8b0c docs 2017-05-25 12:09:07 -04:00
rusefi 51160112d3 refactoring 2017-05-25 08:56:36 -04:00
rusefi 7e2339296e refactoring 2017-05-25 08:49:04 -04:00
rusefi 7020c532c7 nothing to hide 2017-05-22 22:32:08 -04:00
rusefi 73c1f29cf9 better macro name 2017-05-15 23:33:22 -04:00
rusefi f8e592f454 better macro name 2017-05-15 23:28:49 -04:00
rusefi d05efd2820 refactoring - reducing complexity 2017-04-21 13:22:11 -04:00
rusEfi 7cdbf2bb03 refactoring: better code names 2017-04-19 22:03:14 -04:00