Andrey
e08cdf0fb6
trigger refactoring
...
only:mre_f4
2023-03-03 00:21:40 -05:00
Andrey
057b067db0
trigger refactoring
...
only:mre_f4
2023-03-03 00:02:26 -05:00
Andrey
9a5b2b1fd3
test
...
only:alphax-4chan
2023-02-21 18:48:24 -05:00
Andrey
247108def3
Feb20: 3rd ticket for 4g9x mess #5111
...
random shit at this point
only: alphax-4chan
2023-02-21 17:30:05 -05:00
Andrey
d8a8f78010
Revert "Feb20: 3rd ticket for 4g9x mess #5111"
...
This reverts commit a8141a5f68
.
2023-02-21 16:49:53 -05:00
Andrey
a8141a5f68
Feb20: 3rd ticket for 4g9x mess #5111
...
random shit at this point
only: alphax-4chan
2023-02-21 16:30:36 -05:00
rusefillc
8e268a3542
Feb20: 3rd ticket for 4g9x mess #5111
...
something is really weird
only: alphax-4chan
2023-02-21 15:04:29 -05:00
rusefillc
3c3a584607
Feb20: 3rd ticket for 4g9x mess #5111
...
minor mess reduction: only changing internal naming
2023-02-20 16:51:56 -05:00
rusefillc
aa30546479
Feb20: 3rd ticket for 4g9x mess #5111
2023-02-20 15:22:12 -05:00
rusefillc
0e52c3c9d4
NB1 welcomes 2023
2023-02-20 15:13:29 -05:00
Matthew Kennedy
325417caa7
fix 4g63 vs 9x naming, add cam-only test ( #5093 )
2023-02-16 23:22:34 -05:00
Matthew Kennedy
d044ee6607
k sync again ( #5090 )
...
* k sync again
* oops
2023-02-16 21:13:00 -05:00
rusefi
c4d7192f84
Revert "making enum less public API"
...
This reverts commit d4f02bbece
.
2023-02-15 09:08:52 -05:00
rusefillc
d4f02bbece
making enum less public API
2023-02-15 08:43:15 -05:00
Matthew Kennedy
8621f96d25
improved K sync params from real engine ( #5055 )
2023-02-11 19:34:39 -05:00
Matthew Kennedy
827dc22757
rewrite neon trigger ( #5003 )
...
* rewrite neon trigger
* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Matthew Kennedy
9630edfbf8
mitsu 4g63 ( #5001 )
...
* mitsu 4g63
* file header
2023-01-24 06:53:40 +05:30
Matthew Kennedy
d98e197f49
toyota 4-1 noise rejection ( #4980 )
2023-01-20 15:47:44 +05:30
rusefillc
00aef081ac
12 tooth crank issues fix #4943
2023-01-09 21:10:55 -05:00
rusefillc
1b080bcd09
12 tooth crank issues fix #4943
2023-01-09 15:48:49 -05:00
rusefillc
c72528e5c2
12 tooth crank issues #4943
...
refactoring
2023-01-08 22:30:57 -05:00
Andrey
0f1d46238f
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
Matthew Kennedy
cb97c89588
Toyota cam 4-1 can be a plain skipped tooth decoder ( #4863 )
...
* this should be RiseOnly
* use 4-1 skipped tooth for toyota
2022-12-02 07:37:18 -05:00
Andrey
ce550aaa3d
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 15:45:32 -05:00
Andrey
99edf9484a
docs
2022-11-16 15:23:42 -05:00
Andrey
6ca9b6eda7
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
Andrey
2fb23cf58b
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 12:18:46 -05:00
Andrey
f7d97e202e
docs
2022-11-16 12:18:34 -05:00
rusefillc
32d3669a35
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 11:35:00 -05:00
Matthew Kennedy
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
rusefi
ec77afeaa0
reducing ugly
2022-11-06 20:47:57 -05:00
rusefillc
87d6aa2ed9
minor trigger refactoring
2022-11-06 01:11:33 -04:00
rusefillc
43e3fce9b1
minor trigger refactoring
2022-11-05 22:42:33 -04:00
rusefillc
fd86dc2b0f
minor trigger refactoring
2022-11-05 22:30:08 -04:00
Andrey
c6e34be447
A gem of dead code
2022-11-05 21:53:38 -04:00
Andrey G
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
rusefillc
19b0f7e66e
triggerImage: todo: support symmetrical crank
2022-10-16 12:10:58 -04:00
Matthew Kennedy
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy
a773b3249a
remove 2jz trigger that's really 12 tooth crank ( #4637 )
...
* remove 2jz trigger that's really 12 tooth crank
* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy
6e021fb880
change triggers that need RiseOnly ( #4636 )
...
* triggers that need RiseOnly
* skipped tooth
* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Andrey
36113d6f66
nicer fatal message if that ever happens
2022-09-28 19:47:14 -04:00
GitHub gen-configs Action
1b56415c56
Auto-generated configs and docs
2022-09-25 22:54:41 +00:00
Matthew Kennedy
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
9e7f36a5ca
tear down Engine god object #4511
2022-09-15 21:28:27 -04:00
rusefillc
7cc41dfa75
human brain does need sleep
2022-09-11 12:40:24 -04:00
rusefillc
07727f5d0a
Revert "refactoring: type safety"
...
This reverts commit ed7908a69d
.
2022-09-11 11:14:20 -04:00
rusefillc
ed7908a69d
refactoring: type safety
2022-09-11 11:00:12 -04:00
rusefillc
2eca6ec3c7
refactoring: type safety
2022-09-11 05:41:01 -04:00
rusefillc
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
rusefillc
6e71b72acc
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
rusefillc
94762094a7
refactoring - reducing API between FW and Java
2022-09-11 01:59:44 -04:00
Andrey
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
Andrey
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Matthew Kennedy
ca4936d3fe
rename and fix skyactiv cam mode ( #4505 )
2022-08-31 22:12:45 -04:00
rusefillc
b444e400eb
docs
2022-08-29 10:51:32 -04:00
Andrey
219a190fbc
TT_VVT_MAZDA_MYSTERY
2022-08-28 22:43:03 -04:00
rusefillc
4b0c8c9ff2
TT_VVT_MAZDA_MYSTERY
2022-08-28 21:54:24 -04:00
Matthew Kennedy
b662e59707
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
rusefillc
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
Matthew Kennedy
aeb7c2e464
hard code vq cam gaps ( #4471 )
2022-08-22 19:40:24 -04:00
rusefillc
b0edd12752
docs
2022-08-22 18:44:44 -04:00
rusefillc
122db2de95
fix Subaru EZ30 trigger gaps fix #4344
2022-07-31 10:15:16 -04:00
rusefillc
0424dd6f0e
Extra gap ratios for custom trigger wheels fix #4375
...
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
Andrey
20a16bd53b
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
rusefillc
d92fa798ba
RoverK - wow that's odd, but whatever
2022-07-12 02:42:41 -04:00
rusefillc
5fe87f091b
looks dead
2022-07-12 01:38:25 -04:00
rusefillc
a4347668c5
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 11:41:33 -04:00
rusefillc
d639a42621
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 07:43:23 -04:00
Matthew Kennedy
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit d5e131b1d0
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy
90cc62a667
honda trigger sync ratio ( #4194 )
2022-05-24 17:12:36 -04:00
rusefillc
e8ceaeabaf
Pavel says 120
2022-05-24 14:40:54 -04:00
Matthew Kennedy
fe77f5127e
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy
907adc6583
remove 360 trigger ( #4165 )
...
* remove 360
* s
* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
Matthew Kennedy
b650bbe46c
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy
045cbcbff1
fix 36-2 trigger params ( #4138 )
...
* fix gap params
* changelog was wrong too
* typo
* binary log knock count and retard
* Revert "binary log knock count and retard"
This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
rusefillc
efccb2106d
Corolla 1ZZ 2003 trigger improvements fix #4132
2022-05-04 02:45:44 -04:00
Matthew Kennedy
bc6a87cadc
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
rusefillc
4b8b7b1d70
docs
2022-04-24 16:17:42 -04:00
rusefillc
e631988b22
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
Andrey
9d335c1261
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:38:52 -04:00
Andrey
c2a97343f2
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
rusefillc
96cc09d166
huh?
2022-04-02 21:01:29 -04:00
rusefillc
086739d20a
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
rusefillc
59f23e294b
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 18:32:40 -04:00
rusefillc
ea94fc05ae
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 21:11:32 -04:00
Andrey
89054c3a31
new VVT trigger shape? 4-1 Toyota #1847
2022-03-23 19:25:13 -04:00
Matthew Kennedy
7d657106d7
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
Andrey
b3fdd790b5
new VVT trigger shape? #1847
2022-03-22 06:34:22 -04:00