Commit Graph

63 Commits

Author SHA1 Message Date
Andrey Gusakov 6ab23ae715 Revert "GDI: HPFP: suspect?"
This reverts commit b1ac3f6cfc523e728414356499a53be49ad4b212.
2025-01-31 17:11:10 -05:00
Andrey Gusakov 2412ae21df Fix expected conversion to float with value_or() 2025-01-31 17:11:10 -05:00
Andrey Gusakov a2f578f063 GDI: HPFP: more accurate logging 2025-01-31 17:11:10 -05:00
Andrey Gusakov 8927cdf08e GDI: HPFP: todo for future me 2025-01-31 17:11:10 -05:00
Andrey Gusakov e6743fae70 GDI: HPFP: rename deadtime to deadangle to avoid confusion 2025-01-31 17:11:10 -05:00
Andrey Gusakov 3b2ecf5f54 GDI: HPFP: lobe to lobeAngle where it is actually an angle 2025-01-31 17:11:10 -05:00
Andrey Gusakov 2d64ae3ba6 GDI: HPFP: suspect? 2025-01-31 17:11:10 -05:00
Andrey Gusakov cd0f33c83f GDI: HPFP: lets debug actual activation and deactivation angles 2025-01-31 17:11:10 -05:00
Andrey Gusakov 188689985d HPFP: show valve state in log 2025-01-31 15:15:30 -05:00
Andrey Gusakov 9042416d16 HPFP: positive logic, isHpfpInactive -> isHpfpActive 2025-01-31 15:15:30 -05:00
Andrey Gusakov 289ae9009e HPFP: update nextLobe for livedata 2025-01-31 15:15:30 -05:00
Andrey Gusakov a49a71e571 HPFP: just code styling 2025-01-31 15:15:30 -05:00
Matthew Kennedy af2e425761 only:int rpm -> float rpm 2024-09-26 00:27:35 -04:00
Andrey 6eaf9b117d only: unique variable name so that nice IDE would not be needed 2024-05-10 23:09:52 -04:00
rusefi 71e1397a5a only:unit test time mess 2024-05-01 12:32:06 -04:00
Andrey d9a3bb4bd1 move a bunch of tables out of engine_configuration_s 2024-03-20 17:07:12 -04:00
Andrey 15a313aced HPFP control on cam with variable timing fix #6245 2024-03-17 22:30:50 -04:00
rusefi 7b9726a154 Seems that gdi pump angle changes at 2x the rate of cam movement, possible multiplication/division problem? #6245 2024-03-17 20:41:50 -04:00
rusefi 12b91c01cc refactoring: reducing code duplication around cam index math 2024-03-17 20:28:09 -04:00
Andrey a6103dca56 tooth-event angle cannot be negative 2023-10-06 12:21:55 -04:00
rusefillc d9b00d8124 Retarding exhaust VVT which drives DI pump causes issues #5596
only: placing angle position into proper range
2023-10-06 12:21:55 -04:00
rusefillc 51cdf50216 Retarding exhaust VVT which drives DI pump causes issues #5596
only: placing angle position into proper range
2023-10-06 12:21:55 -04:00
rusefillc 591dae80bd Retarding exhaust VVT which drives DI pump causes issues #5596
only: placing angle position into proper range
2023-10-05 23:49:53 -04:00
Andrey ba66fdcf82 reducing code duplication around assert 2023-09-05 21:28:39 -04:00
Andrey 55cb5cfcf1 Injector duty reading half of reality fix #5542 2023-08-29 16:42:30 -04:00
Andrey ae1eb88498 GDI4 overlap factor #5416 2023-07-21 00:53:13 -04:00
Andrey 13d4475986 GDI4 overlap factor #5416
only: extract method
2023-07-20 15:40:10 -04:00
Andrey 632912d265 extra checks 2023-06-22 14:45:55 -05:00
rusefillc 65dcdb86ec Too many bench test buttons are broken #5327 2023-06-15 11:46:39 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
Matthew Kennedy 2857e9527d remove specs_s struct, flatten config
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
rusefillc 23657b405c GDI: target pressure axis not always MAP fix #5155
bare minumum progress
only:proteus_f7
2023-03-05 23:32:04 -05:00
rusefillc e75a1bc1a1 guards 2022-12-17 18:26:38 -05:00
rusefillc 57ad9b7311 random getOrZero clean-up 2022-12-14 19:48:07 -05:00
Matthew Kennedy 769cdd32ca
TriggerScheduler cleanup (#4844)
* TriggerScheduler cleanup

* remove TRIGGER_EVENT_UNDEFINED

* remove dead overload of scheduleOrQueue

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey 3fe2c74730 docs 2022-08-25 19:58:15 -04:00
Matthew Kennedy 923d2c2e44
unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
rusefillc 8acbf9d8df logging of live data structs was: data points #3614 2022-06-29 03:13:35 -04:00
Andrey c7a62bcdb3 migrating to SensorType::Rpm API 2022-01-20 22:04:45 -05:00
rusefillc 729c9a1ff4 On m_event vs lobe vs scheduling #3804 2022-01-18 22:36:05 -05:00
rusefillc 0e17f9d6e8 On m_event vs lobe vs scheduling #3804 2022-01-18 21:01:49 -05:00
rusefillc f470d93cca On m_event vs lobe vs scheduling #3804 2022-01-18 20:57:24 -05:00
rusefillc c23c93a384 On m_event vs lobe vs scheduling #3804 2022-01-18 10:16:47 -05:00
rusefillc 5e2ad39d91 GDI Epic #1448 2022-01-18 00:27:20 -05:00
Scott Smith efd59d6cbc
GDI/HPFP: Don't take P term into account when clamping I. (#3732) 2022-01-02 18:45:31 -05:00
rusefillc 95136893de GDI Epic #1448 2022-01-01 17:18:11 -05:00
rusefillc f715210b39 GDI Epic #1448
live view
2021-12-31 15:28:24 -05:00
rusefillc 12d79c138b GDI Epic #1448 2021-12-30 19:14:49 -05:00
Scott Smith 5bc1949aef
Basic framework for high pressure fuel pump control (#3476)
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00