3096db5c72
confusing Map3D API fix #6139
2024-03-04 17:58:24 -05:00
12db01c948
first spark out of order coilIndex logic in prepareCylinderIgnitionSchedule fix #6094
2024-02-29 01:47:43 -05:00
d2b6ae4d11
only: last rename for now
2024-02-29 00:41:12 -05:00
a58ab9ebcf
only: renaming another variable
2024-02-29 00:34:26 -05:00
28cdf85ddc
only: renaming variable
2024-02-29 00:29:48 -05:00
50b2fccb3b
only: renaming method
2024-02-29 00:26:07 -05:00
002a2ce016
only: encapsulation/better name
2024-02-28 21:44:02 -05:00
17275e4f4b
maximumIgnitionTiming does not account timing_offset_cylinder #5894
...
only: renaming field so that we do not have two entities with same name and different meaning
2024-02-28 19:34:13 -05:00
2b80929ac6
only:reducing unit test logging
2024-02-21 17:31:02 -05:00
69bef3ab92
enum class-ify
2024-02-07 21:27:19 -05:00
cced55ade7
maximumIgnitionTiming does not account timing_offset_cylinder #5894
...
sad work-around to unblock Honda bike
2024-02-07 12:59:21 -05:00
64d6bc681a
encapsulation
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2024-01-14 18:57:05 -05:00
8f42f8ccc8
Staged injection support; use two sets of injectors on the same engine fix #5247
2024-01-07 23:14:18 -05:00
1302f780b2
unused parameters
2024-01-07 22:36:20 -05:00
1f64950e33
Staged injection support; use two sets of injectors on the same engine #5247
...
two injection models for two stages
2024-01-07 22:36:20 -05:00
37727d4278
Staged injection support; use two sets of injectors on the same engine #5247
...
wire up pins for second stage injectors
2024-01-07 22:36:19 -05:00
52a68b122f
only: encapsulation and ACR bugfix
2024-01-07 22:36:19 -05:00
0356485274
updating EFI_VEHICLE_SPEED guard
2024-01-07 22:36:18 -05:00
26b351ba40
Remove/make injector duty limit configurable fix #4798
2024-01-07 22:36:18 -05:00
ca18c5ba4e
only:towards https://github.com/rusefi/rusefi/pull/4841
2024-01-07 16:39:15 -05:00
fe0080c4c0
only:towards https://github.com/rusefi/rusefi/pull/4841
2024-01-07 16:31:41 -05:00
9d32148971
remove inaccurate comments - we have ignition overdwell protect
2024-01-07 14:04:28 -05:00
86b2e26506
minor housekeeping
2024-01-07 13:49:10 -05:00
0bfdada528
only:ID2INDEX
2024-01-07 13:23:51 -05:00
98092c306f
only: integration
2024-01-07 13:17:47 -05:00
0a301a08d5
only: refactoring: InjectionEvent knows it's index
2024-01-07 12:58:07 -05:00
c16581c316
only: refactoring: InjectionEvent knowns it's index
2024-01-07 12:50:51 -05:00
c7e1db94ec
only:docs
2024-01-07 12:22:06 -05:00
58f31fd2d9
Auto-generated configs and docs
2024-01-03 20:32:11 +00:00
7f89d0fb0a
don't spam simulator with warning
2023-11-13 09:05:36 -05:00
1287bbe3f0
only:typo
2023-11-12 16:22:29 -05:00
b3e97fdf2f
better EFI_ENGINE_CONTROL
2023-11-05 15:55:29 -05:00
0725151609
better guards
2023-11-04 09:09:10 -04:00
35e57475a4
only:variable shadowing should be avoided #5676
2023-11-01 12:12:50 -04:00
28fd3c59ac
remove wrapAngle2, wrapAngle does fine
2023-10-19 22:53:09 -04:00
883336ff30
fixAngle -> wrapAngle
2023-10-19 22:42:50 -04:00
5a1f53ce39
fix injection SOI log channel
2023-10-19 22:31:17 -04:00
12f4cea668
only:minor encapsulation
2023-10-13 00:23:29 -04:00
3db5c6e3f7
only:minor encapsulation
2023-10-12 23:15:54 -04:00
086fa81a3f
only:minor encapsulation
2023-10-12 22:49:55 -04:00
c831dff7eb
cleanup
2023-10-12 20:29:41 -04:00
c872239f51
lock injection timing at high duty cycle to avoid skipped injections
2023-10-12 09:49:24 -04:00
a6103dca56
tooth-event angle cannot be negative
2023-10-06 12:21:55 -04:00
d9b00d8124
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: placing angle position into proper range
2023-10-06 12:21:55 -04:00
51cdf50216
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: placing angle position into proper range
2023-10-06 12:21:55 -04:00
591dae80bd
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: placing angle position into proper range
2023-10-05 23:49:53 -04:00
c8ddbba529
trip odometer
2023-09-26 17:03:06 -04:00
e29fe83f17
only:docs&readability
2023-09-25 22:36:23 -04:00
d4a92ad604
Auto-generated configs and docs
2023-09-26 02:23:45 +00:00
f4e2ac32d5
only: part of knock logging
2023-09-25 22:19:35 -04:00
47637e2a48
Auto-generated configs and docs
2023-09-26 01:23:22 +00:00
85db1cf0dc
only: part of knock logging
2023-09-25 21:18:57 -04:00
708d92668e
36/2/2/2 is confusing #5566
...
only: code comments
2023-09-15 23:39:10 -04:00
4fac9c4960
faster knock logging
2023-09-15 08:08:42 -04:00
ba66fdcf82
reducing code duplication around assert
2023-09-05 21:28:39 -04:00
78e48d3718
only:timer.h goes to libfirmware!
2023-08-30 23:11:24 -04:00
55cb5cfcf1
Injector duty reading half of reality fix #5542
2023-08-29 16:42:30 -04:00
5f686c302d
"Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488
2023-08-05 23:49:32 -04:00
0e6a5037aa
simulator: sensor mocking UI is broken #5473
...
only: no reason to average MAP while in simulator
2023-07-31 18:10:06 -04:00
0099de49af
ignition timing clamping settings
2023-07-22 00:07:15 -04:00
4fbc9d7b06
ignition timing clamping settings
...
only:atomic change around timing range
2023-07-21 23:48:58 -04:00
ae1eb88498
GDI4 overlap factor #5416
2023-07-21 00:53:13 -04:00
13d4475986
GDI4 overlap factor #5416
...
only: extract method
2023-07-20 15:40:10 -04:00
bc2a2b9ab9
only:better method name
2023-06-25 02:08:53 -04:00
10c5c4ec94
#23 and fix https://github.com/rusefi/rusefi/issues/5353
...
(cherry picked from commit b0c3357cba5a3a08ab481dd9cb76f1ab95114ed4)
2023-06-25 00:25:07 -04:00
632912d265
extra checks
2023-06-22 14:45:55 -05:00
65dcdb86ec
Too many bench test buttons are broken #5327
2023-06-15 11:46:39 -04:00
f77f356e6d
reducing code duplication
2023-06-11 23:17:13 -04:00
731fd89ef7
reducing magic constant
2023-06-11 23:13:36 -04:00
1908896598
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
800752d389
per-cylinder logging fix: using better sign
2023-05-31 17:44:33 -04:00
ed18cb1a53
it's going to be...
2023-05-31 17:36:12 -04:00
c15ab187c5
it's going to be p
2023-05-31 17:23:46 -04:00
91d08f0465
it's going to be p
2023-05-31 17:15:43 -04:00
447b405718
it's going to be p
2023-05-31 17:04:31 -04:00
12a29232cc
tooth_logger.h -> pch
...
(cherry picked from commit ad3ea57276361b6da69eb920dd056a662f6f5c70)
2023-05-31 15:59:02 -04:00
902c61f9d8
setSparkSkipRatio limitation #5231
2023-05-25 13:26:17 -04:00
8c9b17485e
Revert "Allow scheduling_s to come from a pool ( #4841 )"
...
This reverts commit 5250b177
2023-05-25 10:10:17 -04:00
8be4b30c7f
better code guard?
2023-05-24 11:15:02 -04:00
f35cd62b7c
better code guard?
2023-05-24 11:12:00 -04:00
40673ffda2
add ignition/injection mode output channel #85
...
(cherry picked from commit 9621ff844eea704421dc6172d66a2f4053467277)
2023-05-04 18:58:50 -04:00
d897a96c05
is this just dead?
...
(cherry picked from commit cd6b770945aa56ae52e188476034a862cba47bb0)
2023-04-29 01:08:14 -04:00
51d0f6e347
it's going to be painful
2023-04-29 00:44:00 -04:00
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
f296e30fb5
it's going to be painful
2023-04-28 21:01:08 -04:00
2857e9527d
remove specs_s struct, flatten config
...
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
d488ed5858
function >>> macro
...
(cherry picked from commit 489d016682d1c3eb4eb707cd1686686e40175dcd)
2023-04-28 20:27:12 -04:00
b95353cc12
logging of live data structs was: data points, we are moving away from debug mode #3614
2023-04-12 17:31:00 -04:00
0470953cb8
We need to reshuffle timing calculation a bit, add one more gauge #5235
2023-04-12 17:22:28 -04:00
32b7b014c9
per-cylinder should not contain firingOrderOffset fix #5236
2023-04-12 15:18:29 -04:00
588bf77492
wow we have two separate per-cylinder trims?! fix #5237
...
refactoring: bringing two offsets much closer together, no change in overall logic
2023-04-12 15:04:14 -04:00
deaee9ceae
Ignition Knock response logging progress
2023-04-11 10:54:10 -04:00
883084ab9f
Auto-generated configs and docs
2023-04-11 14:45:16 +00:00
b629d5b064
Ignition Knock response logging progress
2023-04-11 10:43:34 -04:00
919ed2d934
RPM soft limit and hysteresis #5214 , #5224 ( #5228 )
...
* [DRAFT] RPM soft limit and hysteresis #5214 , #5224
* fix m_timingRetard
* fix rpmHardLimitHyst
* unit-tests for #5214 , #5224
2023-04-10 17:18:51 -04:00
23657b405c
GDI: target pressure axis not always MAP fix #5155
...
bare minumum progress
only:proteus_f7
2023-03-05 23:32:04 -05:00
c91b2344ce
Auto-generated configs and docs
2023-03-06 04:16:07 +00:00
3031c6abd8
Poor man categories for logs #5153
...
only:proteus_f7
2023-03-05 23:12:56 -05:00
1c7a800d7b
https://github.com/rusefi/rusefi/pull/5040
...
only:mre_f4
2023-02-24 22:48:33 -05:00
6588e813ae
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
9abdab795d
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
d5b00e1187
don't warn if we intentionally skipped this spark ( #4961 )
...
* don't warn if we intentionally skipped this spark
* header
* real nb2
2023-01-10 19:07:44 -05:00
a300043f5d
Feed mapAveragingAdcCallback() with volts not adc raw values ( #4940 )
2023-01-05 12:14:48 -05:00
0300376c84
CI is useful
2023-01-01 11:30:50 -05:00
6146b01a36
antilag and anti-lag #2403
...
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
e75a1bc1a1
guards
2022-12-17 18:26:38 -05:00
d63d8f869a
guards
2022-12-17 15:50:54 -05:00
85976ed63d
guards
2022-12-17 15:23:32 -05:00
57ad9b7311
random getOrZero clean-up
2022-12-14 19:48:07 -05:00
5250b177c2
Allow scheduling_s to come from a pool ( #4841 )
...
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
994ee2f22f
Combine angle based event ( #4884 )
...
* Remove AngleBasedEventOld/New, only AngleBasedEvent now
* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew ( #4882 )
...
* switch hpfp to AngleBasedEventNew
* aux valves too!
2022-12-10 16:15:11 -05:00
769cdd32ca
TriggerScheduler cleanup ( #4844 )
...
* TriggerScheduler cleanup
* remove TRIGGER_EVENT_UNDEFINED
* remove dead overload of scheduleOrQueue
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
8ea5969607
fix warnings ( #4840 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 10:11:14 -05:00
77a3f5d795
trigger refactoring: instance RPM #4740
2022-11-06 11:56:18 -05:00
d75bf59cdc
trigger refactoring: instance RPM #4740
2022-11-06 11:12:20 -05:00
b5796c121d
trigger refactoring: instance RPM #4740
2022-11-06 10:58:04 -05:00
54cea0119a
Auto-generated configs and docs
2022-11-01 21:35:56 +00:00
dd081e5d58
Too long field comment becomes log field name #4716
2022-11-01 17:31:47 -04:00
523a6b9592
Auto-generated configs and docs
2022-11-01 21:00:55 +00:00
53649f73f1
Too long field comment becomes log field name #4716
2022-11-01 16:51:51 -04:00
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
0283351d6c
send more of Engine Sniffer data #4560
2022-10-29 21:55:35 -04:00
de65a247d6
plumbing for dual MAP sensors ( #4704 )
...
* wiring for dual maps
* s
2022-10-27 21:15:04 -04:00
dfe2ead2e7
prep for multiple MAP sensors ( #4705 )
...
* prep for multiple MAP sensors
* move guard
* sensor info printing
* maybe kinetis memory
2022-10-27 13:59:36 -04:00
b01082640b
Revert "prep for multiple MAP sensors ( #4677 )"
...
This reverts commit b8c79b7881
2022-10-26 21:25:02 -04:00
b8c79b7881
prep for multiple MAP sensors ( #4677 )
...
* prep for multiple MAP sensors
* move guard
* sensor info printing
2022-10-26 18:06:20 -04:00
98076927b0
progress: rpm register based on trigger input being none or not ( #4691 )
...
* progress: rpm register based on trigger input being none or not
* use helper functions
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-22 09:27:41 -04:00
7a1e729cd8
ROLLBACK
2022-10-21 22:45:46 -04:00
3abed33988
progress: rpm register based on trigger input being none or not
2022-10-21 22:07:41 -04:00
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
baaec6a603
refactoring: encapsulation
2022-09-28 22:42:08 -04:00
264d33d30e
refactor prime ( #4627 )
2022-09-28 07:53:12 -04:00
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
a9cc3223dc
plumbing for 4513 ( #4599 )
...
* plumbing for 4513
* not static
2022-09-20 06:19:51 -04:00
af7e4f6fe5
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
3a57c41c1b
add fuel/spark cut codes to TS indicators ( #4592 )
...
* add fuel/spark cut codes to TS indicators
* fix list
* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
d9733199c1
"angle range findAngle#a6" critical error #4593
2022-09-19 18:33:19 -04:00
efb232223f
moving acceleration around
2022-09-16 00:06:57 -04:00
61134b452a
tear down Engine god object #4511
...
oh I hope this ends well
2022-09-15 23:41:06 -04:00
45d88f1d26
tear down Engine god object #4511
2022-09-15 22:21:07 -04:00
ec0e567989
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
2d21aacc08
CUSTOM_INSTANT_MAP_DECODING
2022-09-15 15:07:31 -04:00
888247eccd
mapFast into logs
2022-09-15 14:55:49 -04:00
0e91914266
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
2c0ce0ec7d
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
rusefillc
Matthew Kennedy
rusefillc
GitHub gen-configs Action
Andreika
Andrey G