Commit Graph

2160 Commits

Author SHA1 Message Date
rusefillc bc2a2b9ab9 only:better method name 2023-06-25 02:08:53 -04:00
rusefi cf7642b737 https://rusefi.com/forum/viewtopic.php?f=16&t=2572 2023-06-23 19:25:53 -04:00
AvatarSD 087a1c2ccd
Trigger: "Single 60deg tooth before TDC" for Saruman, Sovek ignition (#5347)
* Trigger: "Single 60deg tooth before TDC" for Saruman, Sovek ignition triggers has been added

* Cosmetic: added usefull notions from https://github.com/rusefi/rusefi/pull/5347

---------

Co-authored-by: Denys Sobchuk <d.sobchuk@perenio.com>
2023-06-22 21:10:29 -05:00
Andrey 632912d265 extra checks 2023-06-22 14:45:55 -05:00
rusefi f77f356e6d reducing code duplication 2023-06-11 23:17:13 -04:00
rusefi 731fd89ef7 reducing magic constant 2023-06-11 23:13:36 -04:00
Matthew Kennedy 81682d1a55 oop 2023-06-05 14:15:21 -04:00
Matthew Kennedy f7e6ccd9e2 de-pointerize outputMode #49 2023-06-05 10:25:00 -04:00
Matthew Kennedy 71799f3f3d better error message
(cherry picked from commit f9541aa1d160ca4be8d5da7f83593738d602f649)
2023-06-01 23:02:11 -04:00
Matthew Kennedy 0d1705599a multiple assignments in one line is confusing
(cherry picked from commit 22553992579adb93caea3b138d7660c7ee6145a9)
2023-06-01 23:01:36 -04:00
rusefi 4d0abac889 Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefi 1908896598 Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefillc ad52947775 it's going to be p 2023-05-31 16:20:54 -04:00
Matthew Kennedy f12cab93aa looks like initialState was dead #55
(cherry picked from commit daaf50c2e45de84b9a47716ff253d744caeb34b8)
2023-05-31 16:11:05 -04:00
Matthew Kennedy 12a29232cc tooth_logger.h -> pch
(cherry picked from commit ad3ea57276361b6da69eb920dd056a662f6f5c70)
2023-05-31 15:59:02 -04:00
Mingjie Shen 495f0ea8c4 Fix invoking virtual functions from constructors
Virtual functions should not be invoked from a constructor or destructor
of the same class. Confusingly, virtual functions are resolved
statically (not dynamically) in constructors and destructors for the
same class. The call should be made explicitly static by qualifying it
using the scope resolution operator.
2023-05-24 15:27:09 -04:00
rusefillc 80d88604ff fix https://github.com/rusefi/alphax-4chan/issues/135 2023-05-16 23:07:34 -04:00
rusefillc 86c1a9f8e0 fix https://github.com/rusefi/alphax-4chan/issues/135 2023-05-16 23:00:18 -04:00
Andrey 51def75f8d Ford Coyote VVT Decoder #5275
only:alphax-8chan
2023-05-13 16:08:23 -04:00
Andrey b69d846384 trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 15:43:53 -04:00
Andrey 5d8eef1782 trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 15:34:59 -04:00
Andrey 5e491306cf trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 15:20:40 -04:00
Andrey 56f4d89e33 trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 15:16:38 -04:00
Andrey 56a327c6be trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 14:59:17 -04:00
Andrey 8b84b83e1a trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 14:46:32 -04:00
Andrey d13610e1f1 trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 14:26:31 -04:00
Andrey da1f4f25c3 todo? 2023-05-13 13:51:22 -04:00
Andrey a0408549f5 todo? 2023-05-13 13:40:47 -04:00
rusefi 409bf4b2ce Ford Coyote VVT Decoder #5275
helping build?
2023-05-13 13:27:37 -04:00
rusefillc fd736254ae Ford Coyote VVT Decoder #5275
enum/header
2023-05-13 11:39:54 -04:00
Matthew Kennedy 71a032a61b rename triggerSimulatorFrequency -> triggerSimulatorRpm
(cherry picked from commit d1246174d283ae775444a0e183be9cace88219a9)
2023-04-30 00:44:53 -04:00
Matthew Kennedy 9ae8e18757 only: cherry picking: it's going to be painful 2023-04-29 15:14:58 -04:00
Andrey 51d0f6e347 it's going to be painful 2023-04-29 00:44:00 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
rusefillc fee6bd2ded vvtChannel2 #5207
only:proteus_f7
2023-04-22 08:32:30 -04:00
rusefi f3279c108e proteus F7 QC build is broken #5242 2023-04-19 22:09:57 -04:00
rusefi 3cf43bb0a2 proteus F7 QC build is broken #5242 2023-04-19 20:45:23 -04:00
rusefillc f7ec60d32d Clean-up all the 4g drama #5213 2023-04-01 16:52:48 -04:00
Andrey ad634a7ddc Clean-up all the 4g drama #5213 2023-04-01 16:01:48 -04:00
rusefillc 9f7199950e Clean-up all the 4g drama #5213 2023-04-01 15:19:59 -04:00
Andrey 6c1a8d501e 4g is symmetrical crank not just four stroke crank #5211
only:alphax-4chan
2023-03-30 23:31:47 -04:00
Andrey 080dfb034a 4g is symmetrical crank not just four stroke crank #5211
only:alphax-4chan
2023-03-30 23:11:15 -04:00
Andrey 3d31058cc5 4g is symmetrical crank not just four stroke crank #5211 2023-03-30 22:52:36 -04:00
GitHub gen-configs Action a7fcc72de2 Auto-generated configs and docs 2023-03-31 02:46:09 +00:00
rusefillc 79a15d8da5 nice prefix 2023-03-30 22:42:53 -04:00
Andrey f53937ae87 K
only:hellen-honda-k
2023-03-29 22:57:31 -04:00
GitHub gen-configs Action 157c6fd982 Auto-generated configs and docs 2023-03-29 00:39:11 +00:00
rusefi 7bd39719c4 Poor man categories for logs #5153?
only:hellen-honda-k
2023-03-28 20:35:42 -04:00
GitHub gen-configs Action 5af0aad5e7 Auto-generated configs and docs 2023-03-29 00:35:11 +00:00
rusefi 5ec6f523f3 Poor man categories for logs #5153
only:hellen-honda-k
2023-03-28 20:12:30 -04:00
rusefillc 3031818f3e weird: happy running car shows repetitive pattern of unrealistic vvtSyncGapRatio fix #5152 2023-03-21 19:39:39 -04:00
GitHub gen-configs Action aa088a1c43 Auto-generated configs and docs 2023-03-21 13:46:54 +00:00
Andreika 134d34385e
vvttoothDurations0 NT2US #5193 (#5194)
* vvttoothDurations0 NT2US #5193

* vvttoothDurations0 NT2US #5193
2023-03-21 09:45:08 -04:00
rusefi 033c2e2bb9 https://rusefi.com/forum/viewtopic.php?p=47378#p47378
Subaru EZ30 tdcPosition is now 240
2023-03-11 10:15:59 -05:00
GitHub gen-configs Action fca9f93fa2 Auto-generated configs and docs 2023-03-08 00:52:41 +00:00
rusefillc 929011bb0e Poor man categories for logs #5153 2023-03-07 19:49:06 -05:00
rusefillc 32e8de134f weird: happy running car shows unrealistic vvtSyncGapRatio #5152 2023-03-04 14:58:31 -05:00
GitHub gen-configs Action 3b669fd0d3 Auto-generated configs and docs 2023-03-04 19:08:02 +00:00
rusefillc 641780b2b5 weird: happy running car shows unrealistic vvtSyncGapRatio #5152 2023-03-04 14:06:07 -05:00
Andrey dfd3fde581 future home of quick&dirty VVT simulation
only:mre_f4
2023-03-03 00:36:17 -05:00
Andrey e08cdf0fb6 trigger refactoring
only:mre_f4
2023-03-03 00:21:40 -05:00
Andrey 057b067db0 trigger refactoring
only:mre_f4
2023-03-03 00:02:26 -05:00
Andrey 5949d92483 trigger emulator refactoring
only:mre_f4
2023-03-02 23:54:42 -05:00
Andrey 30a96f0b03 refactoring: better variable name
only:mre_f4
2023-03-02 23:24:59 -05:00
rusefillc 760eb889a6 Revert "Feb20: 3rd ticket for 4g9x mess #5111"
This reverts commit 61eefa205b.
2023-02-21 21:43:05 -05:00
Andrey 9a5b2b1fd3 test
only:alphax-4chan
2023-02-21 18:48:24 -05:00
Andrey 247108def3 Feb20: 3rd ticket for 4g9x mess #5111
random shit at this point

only: alphax-4chan
2023-02-21 17:30:05 -05:00
Andrey d8a8f78010 Revert "Feb20: 3rd ticket for 4g9x mess #5111"
This reverts commit a8141a5f68.
2023-02-21 16:49:53 -05:00
Andrey a8141a5f68 Feb20: 3rd ticket for 4g9x mess #5111
random shit at this point

only: alphax-4chan
2023-02-21 16:30:36 -05:00
rusefillc 8e268a3542 Feb20: 3rd ticket for 4g9x mess #5111
something is really weird

only: alphax-4chan
2023-02-21 15:04:29 -05:00
Andrey be69eecf8e yes, this thing works nicely 2023-02-21 00:08:22 -05:00
Andrey 9d41bc7d56 typo 2023-02-20 23:40:31 -05:00
rusefillc 76a0f6e682 poke 2023-02-20 19:17:38 -05:00
rusefillc 61eefa205b Feb20: 3rd ticket for 4g9x mess #5111
something is really weird
2023-02-20 19:05:45 -05:00
rusefillc 3c3a584607 Feb20: 3rd ticket for 4g9x mess #5111
minor mess reduction: only changing internal naming
2023-02-20 16:51:56 -05:00
rusefillc aa30546479 Feb20: 3rd ticket for 4g9x mess #5111 2023-02-20 15:22:12 -05:00
rusefillc 0e52c3c9d4 NB1 welcomes 2023 2023-02-20 15:13:29 -05:00
Matthew Kennedy 325417caa7
fix 4g63 vs 9x naming, add cam-only test (#5093) 2023-02-16 23:22:34 -05:00
Matthew Kennedy d044ee6607
k sync again (#5090)
* k sync again

* oops
2023-02-16 21:13:00 -05:00
rusefi c4d7192f84 Revert "making enum less public API"
This reverts commit d4f02bbece.
2023-02-15 09:08:52 -05:00
rusefillc d4f02bbece making enum less public API 2023-02-15 08:43:15 -05:00
Matthew Kennedy 8621f96d25
improved K sync params from real engine (#5055) 2023-02-11 19:34:39 -05:00
Matthew Kennedy 827dc22757
rewrite neon trigger (#5003)
* rewrite neon trigger

* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Matthew Kennedy 9630edfbf8
mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
Matthew Kennedy d98e197f49
toyota 4-1 noise rejection (#4980) 2023-01-20 15:47:44 +05:30
GitHub gen-configs Action 6bfda5cb23 Auto-generated configs and docs 2023-01-10 21:35:32 +00:00
Matthew Kennedy eb56c2897a
detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
rusefillc 00aef081ac 12 tooth crank issues fix #4943 2023-01-09 21:10:55 -05:00
rusefillc 1b080bcd09 12 tooth crank issues fix #4943 2023-01-09 15:48:49 -05:00
rusefillc c72528e5c2 12 tooth crank issues #4943
refactoring
2023-01-08 22:30:57 -05:00
Andrey 0f1d46238f Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
rusefillc b49e1569ba findTriggerZeroEventIndex() failed fix #4935 2023-01-04 13:15:45 -05:00
Andrey def809aa39 Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey d0f6fa8ea3 let's try again 2023-01-03 08:38:42 -05:00
GitHub gen-configs Action 0620164d14 Auto-generated configs and docs 2023-01-03 12:55:38 +00:00
Andrey 603f188b55 a bit of dead code 2023-01-03 07:49:17 -05:00
rusefillc 2b4d58005b guards 2022-12-17 14:43:51 -05:00
Matthew Kennedy cb97c89588
Toyota cam 4-1 can be a plain skipped tooth decoder (#4863)
* this should be RiseOnly

* use 4-1 skipped tooth for toyota
2022-12-02 07:37:18 -05:00
Andrey ce550aaa3d new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 15:45:32 -05:00
Andrey 99edf9484a docs 2022-11-16 15:23:42 -05:00
Andrey 6ca9b6eda7 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
Andrey 2fb23cf58b new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 12:18:46 -05:00
Andrey f7d97e202e docs 2022-11-16 12:18:34 -05:00
rusefillc 32d3669a35 new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 11:35:00 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy 7bd9dbf89e
fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 1475ecf273 trigger refactoring: instance RPM fix #4740 2022-11-06 12:03:55 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 83e736b06a trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
Andrey 7b10b32958 trigger refactoring: instance RPM #4740 2022-11-06 11:45:51 -05:00
Andrey 79afd2b6fa trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey d75bf59cdc trigger refactoring: instance RPM #4740 2022-11-06 11:12:20 -05:00
Andrey a5136a0eae trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
Andrey b5796c121d trigger refactoring: instance RPM #4740 2022-11-06 10:58:04 -05:00
rusefillc 53d3c4a529 minor trigger refactoring 2022-11-06 01:32:59 -04:00
rusefillc 87d6aa2ed9 minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc e3fd84ed08 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc a0c234c76d learning C++ 2022-11-06 00:17:24 -04:00
rusefillc d4bb6a3a5e more fancy 2022-11-06 00:10:50 -04:00
rusefillc cd77afe464 minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 2866ba54b8 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
rusefillc 43e3fce9b1 minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc fd86dc2b0f minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey c6e34be447 A gem of dead code 2022-11-05 21:53:38 -04:00
Andrey b57bf2903a minor trigger refactoring 2022-11-05 21:43:12 -04:00
rusefillc 6c3899f401 dead lines 2022-11-05 17:21:30 -04:00
rusefillc 500b3e8678 dead lines 2022-11-05 15:20:02 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 0283351d6c send more of Engine Sniffer data #4560 2022-10-29 21:55:35 -04:00
GitHub gen-configs Action cb77801ed3 Auto-generated configs and docs 2022-10-28 14:09:22 +00:00
rusefillc a4aa280e90 SD card log fields list should be auto-generated #3985 2022-10-28 10:04:33 -04:00
GitHub gen-configs Action 6b28fee5ce Auto-generated configs and docs 2022-10-28 13:11:34 +00:00
rusefillc 5df60fd084 SD card log fields list should be auto-generated #3985 2022-10-28 09:06:15 -04:00
rusefillc cf75202ab6 Automation coverage for RPM not reading #4709 2022-10-28 02:44:38 -04:00
rusefillc 2677da2105 refactoring 2022-10-28 02:41:20 -04:00
rusefillc 983f88709a progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc da0fa03f0a refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
rusefillc 905f59d561 progress: rpm register based on trigger input being none or not 2022-10-21 23:29:39 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc 19b0f7e66e triggerImage: todo: support symmetrical crank 2022-10-16 12:10:58 -04:00
Matthew Kennedy aa881efe89
fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc 6a99469c8a
// todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
GitHub gen-configs Action bd4ca6a805 Auto-generated configs and docs 2022-10-09 02:22:51 +00:00
rusefillc 86d3b16939
hold on, why "float autoscale" at all here? (#4647)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 22:11:34 -04:00
Matthew Kennedy a773b3249a
remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy 6e021fb880
change triggers that need RiseOnly (#4636)
* triggers that need RiseOnly

* skipped tooth

* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 57c804c6f5 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 36113d6f66 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
GitHub gen-configs Action 1b56415c56 Auto-generated configs and docs 2022-09-25 22:54:41 +00:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 26356adf92
also invert trigger stim if you have trigger input inverted (#4612) 2022-09-25 10:10:31 -04:00
Matthew Kennedy ae6c44634b
better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy b45f84fe20
#4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey 9d27780974 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 61cfff1e9e K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey cff779dd78 K progress 2022-09-24 23:18:57 -04:00
GitHub gen-configs Action 3b5ee8da51 Auto-generated configs and docs 2022-09-24 04:29:39 +00:00
Matthew Kennedy dd41cf0a05
log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc c4699efe91 honda K enum rename 2022-09-23 20:13:14 -04:00
Matthew Kennedy 6dd933ea86
terrible horrible typo (#4597) 2022-09-20 12:39:16 -04:00
rusefillc efb232223f moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 3104538022 just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc 50cef9a201 tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc fc9fb5724c tear down Engine god object #4511 2022-09-15 22:06:16 -04:00
rusefillc 13bd9ab641 tear down Engine god object #4511 2022-09-15 22:00:07 -04:00
rusefillc 52f52376de tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
rusefillc ec0e567989 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc 9e7f36a5ca tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
rusefillc 85b170f84e dead idea 2022-09-15 14:55:32 -04:00
Andrey 0c87bb7260 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 663c39afdc deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 12d857b99c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G e2addd1951
Supress tons of warning from triggers (#4565) 2022-09-11 15:25:58 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc 7cc41dfa75 human brain does need sleep 2022-09-11 12:40:24 -04:00
rusefillc 07727f5d0a Revert "refactoring: type safety"
This reverts commit ed7908a69d.
2022-09-11 11:14:20 -04:00
rusefillc ed7908a69d refactoring: type safety 2022-09-11 11:00:12 -04:00
rusefillc 2eca6ec3c7 refactoring: type safety 2022-09-11 05:41:01 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc 6e71b72acc refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 94762094a7 refactoring - reducing API between FW and Java 2022-09-11 01:59:44 -04:00
rusefillc cfb843b315 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc 7b4a5c9be6 vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 72299bd1ba
only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
rusefillc 9e9c0217b8
huh? dead code? how can we get NAN from eventAngles table? (#4549) 2022-09-07 23:45:33 -04:00
GitHub gen-configs Action 27c40e162b Auto-generated configs and docs 2022-09-08 02:41:09 +00:00
Andrey 8e49542600 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 00fea2cbe5 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 21:45:59 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Matthew Kennedy aeeef3dbd0
reset instant RPM in case of cam resync (#4544) 2022-09-06 21:38:35 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Matthew Kennedy 9407150544
more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey c28c876357 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
GitHub gen-configs Action 7dee4d33cb Auto-generated configs and docs 2022-09-01 14:11:17 +00:00
Andrey 5941ad8fb7 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 1d1fd2da43 Revert "smaller step forward"
This reverts commit f0e6bcc279.
2022-09-01 09:10:11 -04:00
Andrey e1b3c3380f Revert "smaller step forward"
This reverts commit f388163d2a.
2022-09-01 09:10:07 -04:00
Andrey f388163d2a smaller step forward 2022-09-01 08:51:13 -04:00
Andrey f0e6bcc279 smaller step forward 2022-09-01 08:44:46 -04:00
GitHub gen-configs Action b712732dff Auto-generated configs and docs 2022-09-01 05:33:56 +00:00
Andrey 2cfe2a41b3 smaller step forward 2022-09-01 01:11:03 -04:00
Andrey ce5e618e3f smaller step forward 2022-09-01 01:08:51 -04:00
GitHub gen-configs Action 5237235e48 Auto-generated configs and docs 2022-09-01 04:53:05 +00:00
Andrey 9e14073feb c63fb29aaf partial rollback 2022-09-01 00:46:54 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
GitHub gen-configs Action 4f6f985d4f Auto-generated configs and docs 2022-09-01 04:18:59 +00:00
Andrey c63fb29aaf refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 28d797d5c2 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
GitHub gen-configs Action 398003c65d Auto-generated configs and docs 2022-09-01 03:56:47 +00:00
Andrey dddec7cf06 currentEngineDecodedPhase as trigger central field 2022-08-31 23:31:35 -04:00
Andrey 6d3a6dc2f8 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
rusefillc b444e400eb docs 2022-08-29 10:51:32 -04:00
Andrey b7490590a2 TT_VVT_MAZDA_MYSTERY 2022-08-28 23:01:38 -04:00
Andrey 219a190fbc TT_VVT_MAZDA_MYSTERY 2022-08-28 22:43:03 -04:00
rusefillc 4b0c8c9ff2 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
Matthew Kennedy b662e59707
remove some uses of EFI_ERROR_CODE (#4496)
* lua hooks

* findAngleMatch

* s

* s
2022-08-28 09:43:21 -04:00
rusefillc 85490a497d
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 (#4495)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
GitHub gen-configs Action cf8d43f412 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy 73abcb044d
log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
rusefillc 5007084981 VQ trigger gaps improvement fix #4469
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
rusefillc 859a66bb3b poke 3 2022-08-23 09:02:38 -04:00
rusefillc 7e690b0899 poke 2 2022-08-22 23:43:06 -04:00
rusefillc c0923f6efe poke 1 2022-08-22 23:42:48 -04:00
rusefillc 841b40d8ac RE: reasons for verbose messages 2022-08-22 22:52:48 -04:00
Matthew Kennedy aeb7c2e464
hard code vq cam gaps (#4471) 2022-08-22 19:40:24 -04:00
rusefillc b0edd12752 docs 2022-08-22 18:44:44 -04:00
Andrey a4a9a2c182 Revert "Revert "Revert "small step forward? (#4450)"""
This reverts commit 3fb0cb2516.
2022-08-21 15:23:20 -04:00
Andrey 3fb0cb2516 Revert "Revert "small step forward? (#4450)""
This reverts commit c97f86e8a7.
2022-08-21 14:43:50 -04:00
GitHub gen-configs Action c1b4e4374f Auto-generated configs and docs 2022-08-21 16:43:08 +00:00
rusefi 25778f0890 trigger gap logging: it's a mess :( 2022-08-21 12:38:29 -04:00
GitHub build-firmware Action fba78abdd5 Auto-generated configs and docs 2022-08-16 23:48:31 +00:00
Andrey c97f86e8a7 Revert "small step forward? (#4450)"
This reverts commit 10c3d5080a.
2022-08-16 19:43:46 -04:00
GitHub build-firmware Action 8c5c987b55 Auto-generated configs and docs 2022-08-16 23:06:34 +00:00
rusefillc 10c3d5080a
small step forward? (#4450)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-16 18:57:40 -04:00
GitHub build-firmware Action 5c131387ee Auto-generated configs and docs 2022-08-15 21:22:59 +00:00
GitHub build-firmware Action 83f2e1e7a6 Auto-generated configs and docs 2022-08-15 19:03:46 +00:00
GitHub build-firmware Action 4199384983 Auto-generated configs and docs 2022-08-15 18:43:52 +00:00
GitHub build-firmware Action 1946218699 Auto-generated configs and docs 2022-08-14 21:08:27 +00:00
GitHub build-firmware Action 8ac3ac7702 Auto-generated configs and docs 2022-08-14 20:14:30 +00:00