Matthew Kennedy
6de8364895
maybe more working MAP sampling ( #3689 )
...
* what if we do this
* cleanup
* s
* test
2021-12-11 03:01:28 -04:00
rusefillc
17879ef7de
MAP phase sensing #3544
2021-12-09 22:16:42 -05:00
rusefillc
f44370a5b8
MAP phase sensing #3544
...
gauge name fix
2021-12-08 12:44:43 -05:00
Andrey
3a00fc4767
MAP phase sensing #3544
...
new implementation seems complete? 360 fix
2021-12-07 21:37:33 -05:00
Andrey
50038167d8
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
Andrey
e72d57438a
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
rusefillc
f826fe13aa
MAP phase sensing #3544
...
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
Matthew Kennedy
25beb610b0
log actual tooth angle ( #3646 )
2021-12-02 19:22:33 -05:00
rusefillc
fda7a3a775
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
rusefillc
e896afe2f6
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
rusefillc
168a899ba9
how many more spelling mistakes?!
2021-12-02 01:06:40 -05:00
Matthew Kennedy
890cbd8cf2
remove define_constructor ( #3640 )
...
* no define_constructor
* jar
* sim needs live doc
2021-11-30 19:31:54 -05:00
Matthew Kennedy
3334a6963c
oh my god we've had no asserts ( #3595 )
2021-11-22 17:52:03 -05:00
Scott Smith
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Andrey
655b77dc3f
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
Matthew Kennedy
cb032fb1ea
(void) -> () ( #3550 )
...
* static functions with (void)
* more
* Revert "more"
This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
rusefillc
a9bcce88d0
script settings need names!
2021-11-13 22:47:46 -05:00
rusefillc
6d0dfe4542
refactoring - magic constant bad
2021-11-07 00:09:17 -04:00
Matthew Kennedy
7590e4c679
log current engine phase on trigger teeth ( #3471 )
...
* log phase on trigger teeth
* ui
* guard
2021-11-05 20:02:15 -04:00
Matthew Kennedy
59e9d05fc7
extract engine phase function ( #3456 )
...
* extract getCurrentEnginePhase
* inject engine ref
* never invalid RPM, use 0 instead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
rusefillc
c62fedbe34
Override trigger gaps feature #2734
2021-10-30 10:45:32 -04:00
Andrey
a6a969390f
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
Andrey
fbd37ae0e7
dead magic macro
2021-10-28 19:18:50 -04:00
rusefi
f0f4513998
VVT to be reported after primary
2021-10-28 16:46:54 -04:00
Andrey
463515e282
Honda K cam wheels #3405
2021-10-28 13:49:54 -04:00
Andrey
de350131e6
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
Andrey
c96e52d6f3
Honda K cam wheels #3405
2021-10-28 10:36:41 -04:00
Andrey
b5ae711e2f
refactoring: extracting method to improve readability
2021-10-28 10:30:05 -04:00
rusefillc
8a3f93d6f6
progress
2021-10-24 15:30:17 -04:00
rusefi
274a6d8ba6
triggerinfo progress
2021-10-23 19:01:31 -04:00
rusefillc
1493973bea
very old very dead code
2021-10-20 10:38:36 -04:00
rusefillc
308a798eaa
Nick has RPM spikes and engine hiccups #3269
2021-10-03 01:48:34 -04:00
rusefillc
c1275af29c
reduce chance of invalid CAM setting fix #3105
2021-08-03 22:15:40 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Andrey
6fc693aea2
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
Matthew Kennedy
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Andrey
f87d1c425e
trigger signal debug pins - logic level output #2959
2021-07-16 17:18:03 -04:00
Andrey
ee91af5c73
trigger signal debug pins - logic level output #2959
2021-07-16 16:42:26 -04:00
rusefi
92dee23061
FATAL on NB2 tune jim stim input signal fix #2965
2021-07-14 21:18:05 -04:00
Andrey
2442d8f2d8
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:05:53 -04:00
Andrey
e1c41ff798
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:03:00 -04:00
Andrey
bb9835fe58
trigger signal debug pins - logic level output #2959
2021-07-13 20:33:27 -04:00
Andrey
994230be65
trigger signal debug pins - logic level output #2959
2021-07-13 20:15:55 -04:00
Andrey
f028c4d727
trigger signal debug pins - logic level output #2959
2021-07-13 18:16:32 -04:00
Matthew Kennedy
aef0732509
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
Andrey
8e30c513da
unit tests pass on Linux fail on Windows fix #2902
...
reducing code duplication
2021-07-05 23:51:13 -04:00
Andrey
70424ac7b5
Nissan VVT trigger decoder #2887
...
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
Andrey
1b174bd4b3
Nissan VVT trigger decoder #2887
...
that's all very strange
2021-07-05 22:17:26 -04:00
Andrey
064c1612e3
restore testQuadCam #2911
2021-07-05 21:04:09 -04:00
rusefi
de63a5cd17
Nissan progress!!!
2021-07-05 20:29:49 -04:00
Andrey
c2fafbb695
Nissan
2021-07-05 18:43:39 -04:00
rusefillc
f498524611
Nissan
2021-07-05 18:38:34 -04:00
Andrey
3853e7721a
Nissan VVT trigger decoder #2887
...
one step back
2021-07-03 12:42:07 -04:00
Andrey
2737045eab
Nissan VVT trigger decoder #2887
2021-07-03 12:26:31 -04:00
Andrey
0cf095a943
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
Andrey
23e7022e55
Nissan VVT trigger decoder #2887
2021-07-03 11:08:22 -04:00
Andrey
f5e937fe2b
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
Andrey
152eea43b1
Nissan VVT trigger decoder #2887
2021-07-03 10:15:41 -04:00
Andrey
36165bed44
Nissan VVT trigger decoder #2887
2021-07-03 09:43:27 -04:00
Andrey
e5a1b68eb2
Nissan VVT trigger decoder #2887
2021-07-02 20:28:15 -04:00
Andrey
0af1e8ee59
Nissan progress
2021-07-02 20:12:31 -04:00
Andrey
9cc82f5068
todo: vvt
2021-07-02 19:06:07 -04:00
Matthew Kennedy
5c60973dd8
Consolidate hwHandleShaftSignal ( #2875 )
...
* consolidate trigger input
* merge functions
* comment
* dead
* hw vs. not hw
* stray comma
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Andrey
21c06e1514
refactoring maybe making code reuse more possible in the future
2021-06-27 13:00:01 -04:00
Andrey
4463ca1fdb
depressing code comment
2021-06-26 23:01:47 -04:00
Andrey
5adb42f939
refactoring - crankDivider etc etc
2021-06-26 22:42:53 -04:00
Andrey
eaff083377
refactoring - explicit read method
2021-06-26 22:17:07 -04:00
Matthew Kennedy
ce4eb2b55d
fix trigger changed logic ( #2860 )
...
* reenable
* fix
* longer interval between updates
* only deinit hard trigger outputs if necessary
* init logic
* init order
* warning
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
Andrey
66b091a5a5
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 11:30:06 -04:00
Andrey
71fdfe6756
giving unit tests a chance to use tdcMarkCallback
2021-06-25 01:31:53 -04:00
rusefillc
157732d5aa
https://rusefi.com/forum/viewtopic.php?f=16&t=2027
2021-05-27 05:50:59 -04:00
Andrey
cd5653ff84
Override trigger gaps feature #2734
2021-05-23 20:52:18 -04:00
Andrey
cbb6ca0c7c
Override trigger gaps feature #2734
2021-05-23 19:58:03 -04:00
rusefillc
10858ae371
https://rusefi.com/forum/viewtopic.php?f=16&t=1996
2021-04-25 09:34:40 -04:00
rusefillc
02d4cde3c4
https://rusefi.com/forum/viewtopic.php?f=16&t=1996
2021-04-25 09:18:35 -04:00
rusefi
3c9f7174ba
improving QC process
2021-04-23 00:45:36 -04:00
rusefi
3e44135947
improving QC process
2021-04-22 21:23:20 -04:00
Matthew Kennedy
c26987b96b
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy
ad71016862
rip the bandaid: find-replace most of scheduleMsg ( #2572 )
...
* biiiig find replace
* more trivial find replace
* pwm
* almost all of them
* few more
* gpio
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefillc
6c89cdf637
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 14:39:26 -04:00
rusefillc
9753b6e020
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
rusefillc
f3c46f2720
refactoring
2021-04-04 23:03:51 -04:00
rusefillc
488f6fed47
todo?
2021-04-04 22:05:55 -04:00
Andrey G
bbe3291ccd
hip9011: get callback from spark on each cylinder ( #2499 )
...
* hip9011: get callback from spark on each cylinder
* hip9011: cleanup unused
2021-03-27 14:12:49 -04:00
Matthew Kennedy
1c473934b9
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
Matthew Kennedy
5e88376e2c
barra vvt cam pattern ( #2483 )
...
* barra vvt cam pattern
* two tooth sync
* I think this needs to be here too
2021-03-22 07:48:29 -04:00
Matthew Kennedy
3072d54717
dead code, warnings ( #2461 )
2021-03-15 10:23:19 -04:00
Matthew Kennedy
5a4c24f9a5
virtual zero timer ( #2426 )
...
* virtual zero timer
* it would help to call the correct function
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 15:32:41 -05:00
rusefillc
ce78123eb0
M62T vanos support #2243
2021-02-08 22:21:02 -05:00
rusefillc
2d99e77c95
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
rusefi
0d6dfbb501
M62T vanos support #2243
2021-02-08 21:28:57 -05:00
rusefi
6793b5d8fc
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
rusefi
6b10de5616
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
rusefillc
4bb9762e2e
extracting runtime state from trigger central
2021-01-31 22:41:17 -05:00
rusefillc
869e4cfc49
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00