Illia Bobyr
c449a15c30
metrics: datapoint macro: Allow trailing comma ( #30317 )
...
Rust grammar allows trailing commas in most places where a list of
elements are accepted. It simplifies cases when the list is generated
by a macro, allowing the macro to avoid special cases for a one element
list vs longer lists.
As such, it is a common practice to allow trailing commas in macros as
well.
2023-03-17 12:57:46 -07:00
Jeff Washington (jwash)
6dd5a22926
when writing to disk bucket index, tune towards packing tighter ( #30761 )
...
* when writing to disk bucket index, tune towards packing tighter
* switch to min
2023-03-17 12:34:56 -07:00
Illia Bobyr
1a71cd7fe2
measure: Measure::end_as{ns,us,ms,s,duration} ( #30762 )
...
In most cases, for a given `Measure` value, a `stop()` call must always be followed by a call to one of the `as_*()` methods. Combining them into a single function call makes the API a bit simpler.
2023-03-17 12:26:06 -07:00
Brooks
d4dd4360e7
Removes `base_slot` param from `calculate_incremental_accounts_hash()` ( #30774 )
2023-03-17 15:22:22 -04:00
Brooks
af367db6f0
Calculates accounts hash from storages in snapshot tests ( #30778 )
2023-03-17 15:22:02 -04:00
Ryo Onodera
05ee06814e
Fix wrongly swapped parent slot and block height ( #30744 )
2023-03-17 20:07:52 +09:00
Tyera
20223b2557
Revert ledger-tool changes, fix master ( #30763 )
...
Revert 10f49d4
for ledger-tool
2023-03-16 19:30:10 -06:00
steviez
f1cd64f4a1
ledger-tool: chore: Cleanup snapshot retention constants ( #30745 )
...
Declare constants at top of function with comment, and stringify the
constants when needed to be in line with how other defaults are done in
ledger-tool main function.
2023-03-17 09:25:58 +08:00
behzad nouri
93f696dac7
increases shred-fetch-stage deduper capacity and reset-cycle ( #30690 )
2023-03-17 00:05:29 +00:00
cavemanloverboy
10f49d4e26
Geyser Runtime Reload ( #30352 )
...
Support dynamic geyser plugin load, unload, and listing through admin RPC.
2023-03-16 17:03:00 -07:00
Tyera
9d792c1848
Ledger-tool: add param to deactivate features in snapshot creation ( #30755 )
...
* Add separate parameter for deactivating features on snapshot creation
* Add debug logs for account/feature removals
* Add the word gate
2023-03-16 15:54:05 -06:00
Jeff Washington (jwash)
d66d1f7a46
disk index handles empty slot list more correctly ( #30752 )
2023-03-16 12:34:45 -07:00
behzad nouri
7a7b020580
dedups packets using an atomic bloom filter ( #30726 )
...
Current Deduper implementation uses many bits per entry:
https://github.com/solana-labs/solana/blob/65cd55261/perf/src/deduper.rs#L70-L73
and may be saturated quickly. It also lacks api to specify desired false
positive rate.
The commit instead uses an atomic bloom filter with K hash functions.
The false positive rate is obtained by tracking popcount of bits.
2023-03-16 16:45:42 +00:00
Tao Zhu
17ba051e1f
Revert "add default_cost as mandatory field for Builtin ( #30639 )" ( #30749 )
...
This reverts commit 7b95c8e698
.
2023-03-16 11:21:06 -05:00
ryleung-solana
0ed9f62602
Quic server batching ( #30330 )
2023-03-16 21:50:57 +08:00
Brooks
8be99c1c7d
Verifies incremental accounts hash in verify_accounts_hash_and_lamports ( #30735 )
2023-03-16 09:48:06 -04:00
Brooks
6bdbd2dfec
Removes unnecessary AccountsHashVerifier from snapshot tests ( #30738 )
2023-03-16 09:17:42 -04:00
Ryo Onodera
aaaee556d8
ci: silence ci test output while recording in full ( #30654 )
...
* ci: silence ci test output while recording in full
* shellcheck
* Adjust --color handling place
* Dump to stderr...
* Reduce too spammy solana_metrics logs
* Clean up
* Tweak
* Stash actual command's exit_code, not echo's
2023-03-16 22:17:29 +09:00
Brooks
423fd6010e
Removes extraneous accounts hash calculations in snapshot tests ( #30737 )
2023-03-16 09:17:03 -04:00
Tyera
0cdb315b5b
Make redelegate signer more optional ( #30734 )
2023-03-15 22:59:56 -06:00
Yihau Chen
f8abc8df8d
ci: fix do-audit don't report error ( #30728 )
...
* ci: fix do-audit don't retport error
* Update ci/do-audit.sh
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* use the latest suggestion
* lint
* redirect stderr to stdout
* another solution
---------
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
2023-03-16 11:58:08 +08:00
Yueh-Hsuan Chiang
fce949009d
Add new_from_file() API to AccountsFile ( #30687 )
...
#### Problem
Accounts db currently use AppendVec::new_from_file() directly
to create a new AcountsFile instance from an existing file.
However, this method should be abstracted out to AccountsFile
so that an existing file can be opened correctly using the right format.
#### Summary of Changes
Add new_from_file() API to AccountsFile which will open an existing
file based on its accounts file format.
Currently, it only supports AppendVec.
2023-03-15 20:38:20 -07:00
Andrew Fitzgerald
b7e76c752f
Separate stats updates from decision_maker ( #30481 )
...
* Separate stats updates from decision_maker
* BufferedPacketsDecision::bank_start
* BufferedPacketsDecision: bank_start() doc-comment
* remove unnecessary clone
2023-03-15 19:39:48 -07:00
Ryo Onodera
74970a0b5d
Remove unused ProcessOptions::entry_callback ( #30600 )
...
* Confine entry_callback under cfg(test) for clarity
* Fix ci
* Actually remove entry_callback altogether
* fix clippy
2023-03-16 09:33:18 +09:00
behzad nouri
3cc74a6087
updates tempfile to 3.4.0 ( #30727 )
...
Patching below rustsec advisory:
Crate: remove_dir_all
Version: 0.5.3
Title: Race Condition Enabling Link Following and Time-of-check Time-of-use (TOCTOU)
Date: 2023-02-24
ID: RUSTSEC-2023-0018
URL: https://rustsec.org/advisories/RUSTSEC-2023-0018
Solution: Upgrade to >=0.8.0
2023-03-15 18:25:35 -06:00
Brooks
cbc0d01d0d
Refactors verify_accounts_hash_and_lamports() ( #30733 )
2023-03-15 18:37:27 -04:00
samkim-crypto
2d58bb287d
[zk-token-sdk] Add option to create proof context state in the proof verification program ( #29996 )
...
* extend verifiable trait
* add PodBool
* implement ZkProofData trait
* add proof context program to zk-token-proof program
* update tests for close account
* add close account instruction
* reorganize tests
* complete tests
* clean up and add docs
* clean up pod
* add proof program state
* update tests
* move proof program tests as separate module
* clippy
* cargo sort
* cargo fmt
* re-organize visibility
* add context state description
* update maintainer reference
* change `VerifyProofData` and `ProofContextState` to pod
* add tests for mixing proof types
* add tests for self owned context state accounts
* cargo fmt
* remove unnecessary scoping and add comments on scopes
* re-organize proof instructions
* clippy
* update zk-token-proof-test to 1.16.0
* upgrade spl-token-2022 to 0.6.1
* reoganize proof type
* cargo lock
* remove ZkProofContext trait
2023-03-16 07:35:20 +09:00
Tao Zhu
a4ad0c75fc
fix heap cost calculation rounding error ( #30673 )
...
* add test for refaction heap size, fix size truncating by div op
* add feature gate
* checked result of consume_checked() if feature is activated
2023-03-15 12:03:04 -05:00
Brooks
cefb00e3fb
Includes error in panic in initial accounts hash verification ( #30725 )
2023-03-15 12:24:55 -04:00
Brooks
a5f86a8212
Verifies accounts hash in snapshot tests ( #30724 )
2023-03-15 12:23:44 -04:00
Brooks
65cd55261a
Makes Bank::get_snapshot_hash() aware of incremental accounts hashes ( #30719 )
2023-03-14 18:03:38 -04:00
Jeff Washington (jwash)
62fe6ea7a0
validators always skip clean/shrink on startup ( #30710 )
...
* validators always skip clean/shrink on startup
* move arg to get_deprecated_arguments
2023-03-14 11:41:15 -07:00
Nick Frostbutter
f528335ac0
docs: prioritization fees ( #30138 )
...
* docs: updated prioritization fees docs
* fix: updated wording and removed outdated info
* docs: updated prioritization fees docs
* fix: merge fix
---------
Co-authored-by: nickfrosty <nick.frostbutter@solana.org>
2023-03-14 13:31:41 -05:00
Tyera
b389d509a8
Track max_complete_rewards_slot for use in rpc, bigtable ( #30698 )
...
* Add RewardsMessage enum
* Cache and update max_complete_rewards_slot
* Plumb max_complete_rewards_slot into JsonRpcRequestProcesseor
* Use max_complete_rewards_slot to check get_block requests
* Use max_complete_rewards_slot to limit Bigtable uploads
* Plumb max_complete_rewards_slot into RpcSubscriptions
* Use max_complete_rewards_slot to limit block subscriptions
* Nit: fix test
2023-03-14 12:08:48 -06:00
Brooks
93c43610ac
AccountsHashVerifier stores IncrementalAccountsHash in AccountsDb ( #30696 )
2023-03-14 12:41:44 -04:00
Brennan
9b587bf073
Create gossip vote iterator sorted by stake weight ( #30697 )
2023-03-14 08:43:01 -07:00
Brennan
11c942ab40
`test_verified_vote_packets_validator_gossip_votes_iterator_correct_fork` dynamic num validators ( #30695 )
...
Gossip vote test dynamic number of validators cleanup
2023-03-14 08:35:26 -07:00
Jeff Washington (jwash)
89d5efa0d8
mem idx tracks duplicates better ( #30701 )
2023-03-14 07:26:39 -07:00
Brooks
560ec08d5e
AccountsHashVerifier writes BankIncrementalSnapshotPersistence ( #30587 )
2023-03-13 17:44:34 -04:00
Brooks
346021a48c
Refactors common accounts hash calculation config in AccountsHashVerifier ( #30677 )
...
* Refactors common accounts hash calculation config in AccountsHashVerifier
* pr: config var
2023-03-13 19:39:28 +00:00
mvines
a791e1b541
rpc_service: Rename variable for consistency with the rest of the code base ( #30694 )
...
Rename variable for consistency with the rest of the code base
2023-03-13 19:37:06 +00:00
Brooks
6e5615e32d
Revert "AccountsHashVerifier remembers last full snapshot info ( #30582 )" ( #30660 )
2023-03-13 14:48:16 -04:00
Brooks
263342a686
Adds accounts hashes from full & incremental snapshots at startup ( #30656 )
2023-03-13 14:47:25 -04:00
Brooks
505e3ff5c7
AccountsHashVerifier updates AccountsDb after calculating accounts hash ( #30658 )
2023-03-13 16:41:24 +00:00
Madhav Goyal
9a8a0223ca
Link needs updating ( #30688 )
...
* Link needs updating
Link to monitor the solana cluster doesnt work
* Updated to solana grafna
users could fin the dashboard they are looking for
2023-03-13 17:33:22 +01:00
Trent Nelson
a15139ef15
tests: share `GenesisConfig` in `validator_parallel_exit` ( #30692 )
2023-03-13 10:12:35 -06:00
Brooks
a43f803604
AccountsHashVerifier purges old accounts hashes ( #30644 )
2023-03-13 11:12:11 -04:00
Brooks
5e5b7f00a2
Stores capitalization in account hashes map ( #30635 )
2023-03-13 10:50:45 -04:00
Ryo Onodera
7f58345dad
ci: test-checks.sh all sbf code & use nightly only ( #30602 )
2023-03-13 14:28:34 +09:00
behzad nouri
c4b2639a86
patches flaky test_retransmit_latest_unpropagated_leader_slot ( #30686 )
2023-03-12 22:46:05 +00:00