Jonathan Gimeno
49597b19ec
module: pass route by value ( #6404 )
...
* use instance
* add some comments
* Update types/router.go
* rename Nil to Empty
* run make mocks
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 15:37:23 +00:00
Federico Kunze
0215b5c6cd
client: fix signing algorithm ( #6405 )
...
* crypto/keyring: fix signing algorithm
* client: tests
* minor fixes
* changelog
* address @alexanderbez comments
* Update crypto/keyring/keyring.go
* Update crypto/keyring/signing_algorithms.go
* Update crypto/keyring/keyring.go
* Update crypto/keyring/signing_algorithms.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
* fix test
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 14:30:42 +00:00
atheeshp
4ecbd00436
missing cli tests for distr and mint ( #6349 )
...
Add cli tests for distribution and mint modules.
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 13:03:43 +02:00
Aditya
783e9959e0
Cleanup store.Query with CommitmentProof.Calculate() ( #6396 )
...
* cleanup using CommitmentProof.Calculate()
* get correct version of confio/ics23
* Update store/types/proof.go
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* revert review commit
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-11 08:49:05 +00:00
colin axner
affe7265cb
Update connection and channel to use types_test package name ( #6395 )
...
* convert connection types test pacakge name
* convert channel types test package name
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-11 00:31:54 +00:00
dauTT
82afd52981
x/upgrade: remove alias.go usage ( #6382 )
...
* x/upgrade: remove alias.go usage
* Simplify code
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 18:54:15 +00:00
Jonathan Gimeno
79c308ae4a
Concept PR simplify Module ( #6231 )
...
* add test of alternative impl
* simplify query route too
* change name querier
* simplify register routes
* revert change
* add route
* add router
* first step refactor
* refactor
* update documentation
* update
* add format
* simplify appmodule
* update changelog
* rename vars
* remove interface
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 18:48:16 +00:00
Aditya
e12fa58e14
Convert simple proof to ics23 proof ( #6390 )
...
* convert simple proof to ics23 proof
* add CHANGELOG entries
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 13:23:40 -04:00
Simon Warta
b9f39c94f8
Merge PR #6359 : Updates to ADR-020 (protobuf signing)
2020-06-10 10:48:25 -04:00
Federico Kunze
0d9faec1f3
07-tendermint: cherry-picks from #6272 ( #6387 )
2020-06-10 08:36:18 -04:00
Federico Kunze
55796fb3e7
x/ibc: client consensus_height event ( #6381 )
2020-06-10 05:34:18 -04:00
colin axner
6851c844b3
x/ibc: testing pkg ( #6356 )
...
* add ibc testing pkg with testchain
* add ibctestsuite
* add create connection and channel support
* lint fixes
* lint
* revert
* simplify code via lint
* change suite to coordinator
* Update x/ibc/testing/chain.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* make trust level var and remove get from channel test struct
* apply most suggestions from pr review
* split conn handshake into single step funcs
* split channel handshake into separate funcs
* apply @fedekunze suggestions
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 09:00:13 +00:00
colin axner
a8298976ac
update 07-tm err msg to utc time ( #6383 )
...
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 08:54:23 +00:00
Federico Kunze
744c1ce250
x/ibc: simulation store decoders ( #6247 )
...
* x/ibc: simulation store decoders
* x/ibc: missing decoders
* fixes
* 02-client: decoder test
* 03-connection: decoder test
* x/ibc: decoder test
* address comments from review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-10 08:09:51 +00:00
Alexander Bezobchuk
c0aff2e1f5
baseapp: Enhance Tx Message Data ( #6384 )
...
* Enhance tx message data
* Fix allocation
* cl++
* Fix lint
2020-06-10 04:02:01 -04:00
Aaron Craelius
6740d27b55
Add PublicKeyCodec ( #6372 )
...
* Add PublicKeyCodec
* Add tests
* Remove cache codec
* Remove cache codec
* Revert proto changes
* Revert proto changes
* refactor and move docs
* Lint
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-09 19:41:28 +00:00
Aaron Craelius
08b7557fe5
Add basic sign mode infrastructure ( #6371 )
...
* Add SignModeHandler and LegacyAminoJSONHandler
* Simplify, add tests
* Add godocs
* Add handler map
* Rename HandlerMap
* Don't use pointer
* Lint
* Lint
* Update x/auth/signing/amino/amino.go
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-06-09 15:19:18 +00:00
SaReN
0786e68296
Add proto compatible community spend cli tx ( #6215 )
...
* Add NewSubmitProposal for x/distribution
* Addressed comments
* Fix description for fund tx
* Remove old splitAndApply
* Update utils
* Add missing flag
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-09 10:18:44 +00:00
Miguel Dingli
ea12c3580e
Fixed typos. ( #6376 )
2020-06-09 12:11:13 +02:00
Aditya
d9e1497e89
Switch IAVL Store query to use ics proofs ( #6324 )
...
* switch iavl store to use ics proof
* fix proofs to return for correct height
* appease linter
* Register commitment op correctly
* Make CommitmentOp generic over all ics23 specs (#6331 )
* Make the CommitmentOp generic over all ics23 ProofSpecs, using Type to distinguish
* Register SimpleMerkle ics23 proof op as well
* Addressed linter issues
* move commitment proof to types
* Apply suggestions from code review
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
* address review comments:
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* allow proofs against empty store
* address review comments
* Update store/types/proof.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* add changelog
Co-authored-by: Ethan Frey <ethanfrey@users.noreply.github.com>
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-06-08 15:02:25 -04:00
Alessio Treglia
65ea305336
x/auth: add sign-batch command ( #6350 )
...
The command processes list of transactions from file
(one StdTx each line), generate signed transactions
or signatures and print their JSON encoding, delimited
by '\n'. As the signatures are generated, the command
increments the sequence number automatically.
Author: @jgimeno
Reviewed-by: @alessio
2020-06-08 17:19:29 +02:00
Marko
b618e0a827
add comments to why its nolint ( #6366 )
...
* add comments to why its nolint
* fix spelling
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-08 13:47:18 +00:00
Aaron Craelius
4e0a475751
Make client.Context implement gRPC ClientConn ( #6342 )
...
* Add QueryConn to client.Context
* Add integration test
* imports
* spelling
* Make client.Context implement grpc ClientConn
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-08 13:41:30 +00:00
Federico Kunze
c44813bcdf
x/ibc: commit timeout timestamp ( #6363 )
...
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
2020-06-08 08:03:18 -04:00
dependabot-preview[bot]
c26bbe6c9c
build(deps): bump github.com/stretchr/testify from 1.6.0 to 1.6.1 ( #6364 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.6.0...v1.6.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 06:48:29 -04:00
Segue
52d11acb45
R4R: Fix bug of unordered channel ( #6337 )
...
* fix unordered
* resolve conflicts
2020-06-08 06:19:59 +00:00
Michael FIG
cd94032c0e
docs: ADR 025 for passive channels ( #6250 )
...
* docs: new ADR 023 for passive channels
* docs: simplify application handshake just to OnChanOpenAccept
* chore: rename IBC Passive Channels to ADR 025
* docs: more details for passive channels
* docs: rework the callback for attempted ChanOpenTry
* docs: Attempted -> attempt
* docs: add code reference
* docs: replace OnChanOpenTry with OnAttemptChanOpenTry in ADR 025
2020-06-08 01:07:00 -04:00
Federico Kunze
fb2a95df49
readme: add sourcegraph badge ( #6362 )
2020-06-07 17:08:19 -04:00
Alexander Bezobchuk
8bc645a418
ADR 024 - Coin Metadata ( #6253 )
...
* Start draft
* Add context
* Updates
* Fix tabbing
* Fix title
* Update docs/architecture/adr-024-coin-metadata.md
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
* revise aliases
* Add section on total supply and gen state
* Add section on aliases
* Add section on gov
* Update docs/architecture/adr-024-coin-metadata.md
Co-authored-by: Aaron Craelius <aaron@regen.network>
* Add ext
* Remove extensions
* Add special treatment for base and display denomination (#6351 )
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
2020-06-07 01:05:22 +00:00
colin axner
b9b578d6de
x/ibc: querying support for unordered channels ( #6294 )
...
* pause
* add querying for packet commitments and unrelayed acks
* add get all packet commitments test
* add query channels test
* add query connection channels test
* add test for query packet commitments
* fix key path and add unrelayed acks test
* fix part of lint
* add unrelayed packetsends func
* fix godoc
* add nolint directive
* fix lint
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-06 19:25:45 -04:00
Jonathan Gimeno
626f9b62c5
add pagination ( #6163 )
...
* add pagination
* make test pass with validators
* add pagination option
* unbonding delegations test added
* test unbondedvalidators pagination
* clean test
* remove comment
* remove comment
* add page and limit to unbonding delegations
* add flag limit and page for delegations-to command
* refactor hardcoded string values
* udpate page and limit for validator
* update changelog
* add pagination option
* add defaults
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-06 17:32:15 +00:00
colin axner
71374d0eca
add contextual info to sigverify err msg ( #6355 )
...
* update sigverify error message
* whoops, use get sequence
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 08:05:30 +00:00
Aaron Craelius
43947ca2ef
Add RegisterQueryService to AppModule ( #6336 )
...
* Add RegisterQueryService to AppModule
* Update CHANGELOG.md
* Update CHANGELOG.md
* Wire up BaseApp, fix tests
* Add mock test
* add missing file
* Update types/module/module.go
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 07:59:57 +00:00
Aaron Craelius
7eeb086d3a
ADR 023 Protobuf Naming and Versioning ( #6083 )
...
* First work on ADR 023
* WIP on ADR 023
* Fill out descriptions
* Review test
* Updates
* Update docs/architecture/adr-023-protobuf-naming.md
Co-Authored-By: Marko <marbar3778@yahoo.com>
* Add ICS name suggestion
* cosmos.libs -> base, mention alias
* fix diff
* Update docs/architecture/adr-023-protobuf-naming.md
* Update docs/architecture/adr-023-protobuf-naming.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Update version suffixing
* Describe RPC req/res type names
* Retain Msg prefix
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-05 19:46:56 +00:00
Aaron Craelius
72925fa9ee
Add basic x/bank gRPC query service ( #6343 )
...
* Add basic x/bank gRPC query server
* proto lint
* Add pb.go file
* cleanup
* add separate grpc query tests
* Add request validation
* Use gRPC status errors
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-05 18:10:04 +00:00
dependabot-preview[bot]
6139c0466e
build(deps): [security] bump websocket-extensions in /docs ( #6352 )
...
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node ) from 0.1.3 to 0.1.4. **This update includes a security fix.**
- [Release notes](https://github.com/faye/websocket-extensions-node/releases )
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-05 13:16:53 -04:00
colin axner
246f06d1a8
reformat PR Template ( #6260 )
...
* adjust pr template
* moves #closes to above description
* move closes into description
* rm extra space
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-06-05 16:52:20 +00:00
Mikhail Kornilov
ced080af95
Baseapp recovery middleware ( #6053 )
...
* baseapp: custom panic handling withing app.runTx method
* baseapp: recovery middleware chain unit test added
* CHANGELOG.md update
* ADR-22 link added; godocs update
* CHANGELOG.md: ADR-022 url fix
* CoreDocs added for custom panic recovery middleware
2020-06-05 16:48:18 +00:00
Aaron Craelius
1e6953ccdf
Fix proto3 JSON ( #6345 )
...
* Fix jsonpb
* linting
* cleanup
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-05 14:20:41 +00:00
Alessio Treglia
e248693ac8
x/auth/client: remove duplicate flags ( #6348 )
2020-06-05 16:14:22 +02:00
Federico Kunze
1a5f2b7859
x/ibc-transfer: custom absolute packet timeout ( #6248 )
...
* x/ibc-transfer: custom timeout
* remove destHeight field
* cleanup
* fix test
* replace CLI arg for flag
* update CLI
* viper get flag
* address comments from review
* update cmd example:
* update spec
* address comments from review
2020-06-04 19:30:56 +00:00
Aaron Craelius
c1355d0b45
Integrate gRPC queries into BaseApp ( #6335 )
...
* Rename GRPCRouter to GRPCQueryRouter, add to BaseApp
* Rename field
* add comment
* Update baseapp/abci.go
* Update baseapp/abci.go
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* Address review feedback
* Improve code reuse
* Fix errors
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-04 18:48:06 +00:00
colin axner
b1f483fe24
move packet executed call to ibc handler ( #6312 )
...
* move packet executed to within ibc handler
* add spec updates
* godoc and nil check to lenght
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 11:24:21 +00:00
colin axner
50d748bffb
remove duplicate event emission ( #6328 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:59:13 +00:00
Aaron Craelius
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
dependabot-preview[bot]
dcbf152ae5
build(deps): bump google.golang.org/grpc from 1.28.1 to 1.29.1 ( #6339 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.28.1 to 1.29.1.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.28.1...v1.29.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-04 06:28:29 -04:00
Aaron Craelius
fed0c2317d
Change GetQueryCmd to take client.Context ( #6326 )
...
* Change GetQueryCmd to take a client.Context
* Update CHANGELOG
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 20:15:11 +00:00
Aaron Craelius
2e11c81668
Make sdk.Msg implement proto.Message ( #6327 )
...
* Make sdk.Msg implement proto.Message
* Cleaning up
* Cleaning up
* Update CHANGELOG.md
* Lint fixes
* Lint fixes
* fix tests
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-03 19:52:05 +00:00
Ethan Frey
cd272d525a
Merge PR #6323 : Use simple merkle proof for commit info
2020-06-03 14:50:22 -04:00
Alexander Bezobchuk
d17f5771c7
Revise Point Release Process ( #6333 )
...
* Update point release process
* Update CONTRIBUTING.md
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-03 15:16:40 +00:00