2cc63069c6
rename dummy to kvstore ( #1223 )
...
* remove accidental binary
* docs: s/Dummy&dummy/KVStore&kvstore/g
* glide update to abci
* update abci import paths
* dummy begone, hello kvstore
* RequestInitChain needs genesisBytes
* glide update
2018-02-27 18:01:10 +04:00
9293ae76bf
p2p: introduce peerConn to simplify peer creation ( #1226 )
...
* expose AuthEnc in the P2P config
if AuthEnc is true, dialed peers must have a node ID in the address and
it must match the persistent pubkey from the secret handshake.
Refs #1157
* fixes after my own review
* fix docs
* fix build failure
```
p2p/pex/pex_reactor_test.go:288:88: cannot use seed.NodeInfo().NetAddress() (type *p2p.NetAddress) as type string in array or slice literal
```
* p2p: introduce peerConn to simplify peer creation
* Introduce `peerConn` containing the known fields of `peer`
* `peer` only created in `sw.addPeer` once handshake is complete and NodeInfo is checked
* Eliminates some mutable variables and makes the code flow better
* Simplifies the `newXxxPeer` funcs
* Use ID instead of PubKey where possible.
* SetPubKeyFilter -> SetIDFilter
* nodeInfo.Validate takes ID
* remove peer.PubKey()
* persistent node ids
* fixes from review
* test: use ip_plus_id.sh more
* fix invalid memory panic during fast_sync test
```
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: panic: runtime error: invalid memory address or nil pointer dereference
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x98dd3e]
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]:
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: goroutine 3432 [running]:
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.newOutboundPeerConn(0xc423fd1380, 0xc420933e00, 0x1, 0x1239a60, 0
xc420128c40, 0x2, 0x42caf6, 0xc42001f300, 0xc422831d98, 0xc4227951c0, ...)
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/peer.go:123 +0x31e
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(*Switch).addOutboundPeerWithConfig(0xc4200ad040, 0xc423fd1380, 0
xc420933e00, 0xc423f48801, 0x28, 0x2)
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:455 +0x12b
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(*Switch).DialPeerWithAddress(0xc4200ad040, 0xc423fd1380, 0x1, 0x
0, 0x0)
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:371 +0xdc
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: github.com/tendermint/tendermint/p2p.(*Switch).reconnectToPeer(0xc4200ad040, 0x123e000, 0xc42007bb00)
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:290 +0x25f
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: created by github.com/tendermint/tendermint/p2p.(*Switch).StopPeerForError
2018-02-21T06:30:05Z box887.localdomain docker/local_testnet_4[14907]: #011/go/src/github.com/tendermint/tendermint/p2p/switch.go:256 +0x1b7
```
2018-02-27 15:54:40 +04:00
fc585bcdec
do not block when writing to pongTimeoutCh
...
Refs #1205
2018-02-12 17:04:07 +04:00
2a24ae90c1
fixes from Jae's review
...
1. remove pointer
2. add Quit() method to Service interface
2018-02-12 14:32:09 +04:00
22b038810a
do not block in recvRoutine
2018-02-09 23:03:26 +04:00
45750e1b29
fix race by sending signal instead of stopping pongTimer
2018-02-09 21:32:29 +04:00
26419fba28
refactor code plus add one more test
...
* extract stopPongTimer method
* TestMConnectionMultiplePings
2018-02-09 21:32:29 +04:00
ac0123d249
drain pongTimeoutCh and pongTimer's channel to prevent leaks
2018-02-09 21:32:29 +04:00
f4ff66de30
rewrite pong timer to use time.AfterFunc
2018-02-09 21:32:29 +04:00
747b73cb95
fix merge conflicts
2018-02-09 21:32:29 +04:00
161e100a24
close return channel when we're done
...
Benchmark results:
```
BenchmarkSwitchBroadcast-2 30000 71275 ns/op
--- BENCH: BenchmarkSwitchBroadcast-2
switch_test.go:339: success: 1, failure: 0
switch_test.go:339: success: 100, failure: 0
switch_test.go:339: success: 10000, failure: 0
switch_test.go:339: success: 30000, failure: 0
```
2018-02-09 21:32:29 +04:00
3ae738f453
increase timeouts
2018-02-09 21:32:29 +04:00
d14d4a2527
remove TryBroadcast
2018-02-09 21:32:29 +04:00
860da464df
remove weird concurrency testing
2018-02-09 21:32:28 +04:00
4e2000abfe
control order by sending msgs from one goroutine
2018-02-09 21:32:28 +04:00
5834a59816
read ping
2018-02-09 21:32:28 +04:00
b28b76ddf7
rename pingTimeout to pingInterval, pongTimer is now time.Timer
2018-02-09 21:32:28 +04:00
91e4f4b786
ping/pong timeout in config
2018-02-09 21:32:28 +04:00
9b554fb2c4
switch test modification
2018-02-09 21:32:28 +04:00
f97ead4f5f
prep for merge
2018-02-09 21:32:28 +04:00
5af22d6ee6
remove SwitchEventNewPeer, SwitchEventDonePeer
2018-02-09 21:32:28 +04:00
1d16df6a92
add test, TrySend in broadcast
2018-02-09 21:32:27 +04:00
199ea40980
Merge pull request #1196 from tendermint/1149-TestReactorValidatorSetChanges-fails-non-deterministically
...
WIP: TestReactorValidatorSetChanges fails non deterministically
2018-02-09 01:51:17 -05:00
3f9aa8d8fa
document that msgBytes in p2p/connection change
2018-02-08 13:25:26 +04:00
d6d1f8512d
do not reset pingTimer
...
don't bother with this "only ping when we havent heard from them". lets
just always ping every peer from the sendRoutine every 10s no matter
what. if they dont pong within pongTimeout, disconnect :)
2018-02-08 13:08:11 +04:00
2b2c233977
write docs for Reactor interface
2018-02-08 13:07:40 +04:00
7640e6a29f
add some p2p TODOs
2018-02-08 12:46:04 +04:00
11b68f1934
rewrite broadcastTxRoutine to use channels
...
https://play.golang.org/p/gN21yO9IRs3
```
func waitWithCancel(f func() *clist.CElement, ctx context.Context) *clist.CElement {
el := make(chan *clist.CElement, 1)
select {
case el <- f():
```
will just run f() blockingly, so this doesn't change much in terms of behavior.
2018-02-05 16:36:26 +04:00
426379dc47
remove use of wire/nowriter
2018-02-03 03:39:14 -05:00
baff4bd8cc
p2p/conn: better handling for some stop conditions
2018-01-25 02:11:16 -05:00
27ef3489a0
Merge pull request #1049 from tendermint/p2p-channels
...
p2p: add Channels to NodeInfo and don't send for unknown channels
2018-01-24 15:29:38 -05:00
b6eb275b22
p2p: fix break in double loop
2018-01-24 14:27:37 -05:00
99034904f8
p2p: fix tests for required channels
2018-01-23 23:45:51 -05:00
d7b1b8d3d5
Merge pull request #1129 from tendermint/addrbook
...
p2p: bust up into sub dirs
2018-01-23 23:10:50 -05:00
50129ad8ac
p2p: add Channels to NodeInfo and don't send for unknown channels
2018-01-23 22:43:56 -05:00
8f3bd3f209
p2p: addrBook.Save() on DialPeersAsync
2018-01-23 22:25:39 -05:00
85816877c6
config: fix addrbook path to go in config
2018-01-23 22:21:17 -05:00
775bb85efb
p2p/pex: wait to connect to all peers in reactor test
2018-01-23 21:30:53 -05:00
21ce5856b3
p2p: notes about ListenAddr
2018-01-23 21:26:19 -05:00
3090b05eb4
p2p: use conn.Close when peer is nil
2018-01-21 16:26:59 -05:00
44e967184a
p2p: tmconn->conn and types->p2p
2018-01-21 00:34:41 -05:00
0d7d16005a
fixes
2018-01-20 21:44:30 -05:00
5b5cbaa66a
p2p: use sub dirs
2018-01-20 21:35:37 -05:00
03550c7076
wip addrbook
2018-01-20 21:33:43 -05:00
930fde056a
p2p: add back lost func
2018-01-20 21:28:00 -05:00
8d758560d8
p2p/trustmetric: non-deterministic test
2018-01-20 21:24:22 -05:00
7b87cdaed8
p2p: seed disconnects after sending addrs
2018-01-20 21:24:22 -05:00
c2f97e6454
p2p: seed mode fixes from rebase and review
2018-01-20 21:24:22 -05:00
88eb3e7af0
some minor renames
2018-01-20 21:24:20 -05:00
949211a137
added a test for PEX reactor seed mode
2018-01-20 21:23:48 -05:00
8171628ee5
make tests run faster
2018-01-19 00:59:09 -05:00
bc19e7843c
Merge branch 'develop' into p2p-consolidate
2018-01-18 18:30:37 -05:00
fc7915ab4c
fixes from review
2018-01-14 13:03:57 -05:00
26aaa283a9
p2p: remove deprecated Dockerfile
2018-01-14 13:51:28 +00:00
a29c67563c
Update p2p README, closes #1102
2018-01-14 13:50:34 +00:00
17f7a9b510
improve seed dialing logic
2018-01-14 03:56:15 -05:00
3df5fd21cd
better abuse handling in pex
2018-01-14 03:22:01 -05:00
68237911ba
NetAddress.Same checks ID or DialString
2018-01-14 01:15:37 -05:00
f9e4f6eb6b
reorder peer.go methods
2018-01-14 01:15:37 -05:00
8b74a8d6ac
NodeInfo not a pointer
2018-01-14 01:15:33 -05:00
08f84cd712
a little more moving around
2018-01-13 23:56:57 -05:00
452d10f368
cleanup switch
2018-01-13 17:37:52 -05:00
7667e11973
remove RemoteAddr from NodeInfo
2018-01-13 17:36:03 -05:00
53a5498fc5
more fixes from review
2018-01-13 17:34:12 -05:00
e4d52401cf
some fixes from review
2018-01-13 16:06:51 -05:00
9670519a21
remove PoW from ID
2018-01-13 15:50:59 -05:00
b1485b181a
Merge branch 'p2p-consolidate' into p2p-id
2018-01-13 15:20:23 -05:00
c1e167e330
note in trust metric test
2018-01-13 15:11:13 -05:00
e2b3b5b58c
dial_persistent_peers -> dial_peers with persistent option
2018-01-13 14:50:58 -05:00
075ae1e301
minimal test for dialing seeds in pex reactor
2018-01-09 18:29:29 -06:00
705d51aa42
move dialSeedsIfAddrBookIsEmptyOrPEXFailedToConnect into PEX reactor
2018-01-09 17:54:29 -06:00
e4897b7bdd
rename manual peers to persistent peers
2018-01-09 16:18:05 -06:00
28fc15028a
distinguish between seeds and manual peers in the config/flags
...
- we only use seeds if we can’t connect to peers in the addrbook.
- we always connect to nodes given in config/flags
Refs #864
2018-01-09 16:03:24 -06:00
f602de437e
Move P2P docs into docs folder
2018-01-03 10:49:47 +01:00
488ae529ad
p2p: authenticate peer ID
2018-01-01 23:23:11 -05:00
6e823c6e87
p2p: support addr format ID@IP:PORT
2018-01-01 23:08:20 -05:00
7d35500e6b
p2p: add ID to NetAddress and use for AddrBook
2018-01-01 22:39:08 -05:00
a17105fd46
p2p: peer.Key -> peer.ID
2018-01-01 22:39:05 -05:00
b289d2baf4
persistent node key and ID
2018-01-01 21:21:42 -05:00
f2e0abf1dc
p2p: reorder some checks in addPeer; add comments to NodeInfo
2018-01-01 21:21:39 -05:00
528154f1a2
p2p: PrivKey need not be Ed25519
2018-01-01 19:44:01 -05:00
bc71840f06
more p2p docs
2018-01-01 16:30:36 -05:00
1acb12edf5
p2p docs
2017-12-31 17:11:09 -05:00
14c812a39c
tmlibs timer fix
2017-12-25 11:11:55 -05:00
652d1e3de8
Merge pull request #979 from tendermint/934-node-fails-to-parse-seeds
...
strip protocol if defined
2017-12-19 12:26:32 -05:00
cb3ac6987e
remove some debugs
2017-12-19 10:11:37 -05:00
5d04ccbe51
excessive logging. update tmlibs for timer fix
2017-12-16 19:16:08 -05:00
d7cb2f850d
more logs in p2p
2017-12-16 13:36:52 -05:00
bfe0a4a8ac
more logging
2017-12-16 13:36:52 -05:00
0ec7909ec3
more logging in p2p and consensus
2017-12-16 13:36:52 -05:00
c513649df4
strip protocol if defined
...
Fixes #934
2017-12-15 13:36:08 -06:00
a6911825b0
PanicCrisis is deprecated
2017-12-15 13:35:49 -06:00
068d83bce8
Merge pull request #677 from tendermint/blockchain-test-store
...
blockchain: add tests for BlockStore
2017-12-15 13:33:55 -05:00
78a682e4b6
blockchain: test fixes
2017-12-15 12:07:48 -05:00
462b755a60
activate PEX reactor by default
2017-12-13 12:25:48 -06:00
64f056b57d
Merge branch '916-remove-sleeps-from-tests' into develop
2017-12-12 16:43:36 -05:00
90df9fa1bf
p2p/trust: remove extra channels
2017-12-12 16:43:19 -05:00
eae6e6381e
trust metric is now a service and the test ticker has been added
2017-12-12 15:33:42 -05:00
8be708fe5b
fix spelling and makefile gometalinter.v2
2017-12-11 20:48:15 -08:00
5511bd8e85
p2p: exponential backoff on reconnect. closes #939
2017-12-11 13:41:09 -05:00
a37c1143ca
adr: update 007 trust metric usage
2017-12-10 19:00:44 -05:00
12c5a57415
determinisitic linter ( #902 )
...
* linter: address gosimple lints
* linter: make deterministic & a rebase fix
* lint/rpc: fix a gosimple lint
* run linter in CI
* fix rebase mistake
* fix makefile
* ugh
* revert Makefile
* add metalinter to CI
* try this
* linter: last little fix
* need glide
* better
* okayy circle, have it your way
* lints: gosimple
* pr comments
2017-12-10 17:44:22 +00:00
44f62e5e27
built the WaitForStop functionality into the Stop method
2017-12-09 13:25:28 -05:00
5d464364a8
fixed the racy test and removed all the calls to Sleep
2017-12-08 15:51:18 -05:00
c609b18698
tolerate unresolvable seeds (Refs #880 )
2017-12-07 13:17:09 -06:00
58b4a8395b
Merge pull request #917 from tendermint/trust-metric-cleanup
...
Trust metric cleanup
2017-12-06 02:11:38 -05:00
e101aa9fc8
fix for legacy gowire
2017-12-06 01:21:14 -05:00
cb9a1dbb4f
p2p/trust: lock on Copy()
2017-12-01 23:35:17 -05:00
814541f6d9
p2p/trust: split into multiple files and improve function order
2017-12-01 23:35:12 -05:00
691e266bef
ignore ErrAlreadyStarted when starting addrbook in PEXReactor
2017-11-29 10:53:30 -06:00
69b5da766c
service#Start, service#Stop signatures were changed
...
See https://github.com/tendermint/tmlibs/issues/45
2017-11-29 10:38:58 -06:00
9529f12c28
more linting
2017-11-27 22:39:12 +00:00
55b81cc1a1
address linting FIXMEs
2017-11-27 22:39:12 +00:00
478a10aa41
Write doesn't need error checked
2017-11-27 22:39:12 +00:00
d033470817
lil fixes
2017-11-27 22:39:12 +00:00
7ad8a8ab55
Tests almost passing
2017-11-27 22:39:12 +00:00
a15c7f221d
linting: moar fixes
2017-11-27 22:39:11 +00:00
d7cb291fb2
errcheck; sort some stuff out
2017-11-27 22:39:11 +00:00
15651a931e
linting errors: tackle p2p package
2017-11-27 22:39:11 +00:00
68e7983c70
linting errors: afew more
2017-11-27 22:39:11 +00:00
8f0237610e
linting errors: clean it all up
2017-11-27 22:39:11 +00:00
b75d4f73e7
errcheck: PR comment fixes
2017-11-27 22:39:11 +00:00
331857c9e6
linting: apply errcheck part2
2017-11-27 22:39:11 +00:00
57ea4987f7
linting: apply errcheck part1
2017-11-27 22:39:11 +00:00
1721543e5c
linting: apply misspell
2017-11-27 22:39:11 +00:00
46ccbcbff6
linting: apply 'gofmt -s -w' throughout
2017-11-27 22:39:11 +00:00
94e400a5d6
Merge pull request #896 from tendermint/normalize-priority-and-id
...
normalize priority and id and remove pointers in ChannelDescriptor
2017-11-27 17:05:38 +00:00
59b3dcb5cf
normalize priority and id and remove pointers in ChannelDescriptor
2017-11-25 22:01:23 -08:00
887cb6d0cd
added public methods to handle locking within the trust metric
2017-11-22 23:42:38 -05:00
aeaf2d0b20
Merge branch 'develop' of https://github.com/tendermint/tendermint into develop
2017-11-22 23:11:01 -05:00
e845987503
p2p: disable trustmetric test while being fixed
2017-11-22 20:20:53 +00:00
531b1197a7
Merge pull request #843 from tendermint/refactor-mconnection-with-go-wire-1
...
WIP: begin parallel refactoring: go-wire Write methods and MConnection
2017-11-22 19:34:22 +00:00
e997db7a23
Merge pull request #859 from tendermint/fix/addrbook
...
Fix/addrbook
2017-11-21 15:31:48 +00:00
c4b695f78d
minor fixes from review
2017-11-21 15:30:19 +00:00
75463b8331
Merge pull request #877 from tendermint/p2p-switch-DialSeeds-undeterministically
...
p2p: make Switch.DialSeeds use a new PRNG per call
2017-11-21 15:24:29 +00:00
9c8100043e
made changes to address suggestions from the PR comments
2017-11-20 19:15:11 -05:00
031e10133c
p2p: make Switch.DialSeeds use a new PRNG per call
...
Fixes https://github.com/tendermint/tendermint/issues/875
Ensure that every DialSeeds call uses a new PRNG seeded from
tendermint/tmlibs/common.RandInt which internally uses
crypto/rand to seed its source.
2017-11-20 15:28:42 -07:00
4087326f45
fixed race condition reported in issue #881
2017-11-20 16:47:05 -05:00
f9bc22ec6a
p2p: fix comment on addPeer (thanks @odeke-em)
2017-11-20 21:36:01 +00:00
26cd99c66e
p2p: fix non-routable addr in test
2017-11-20 19:56:44 +00:00
5c34d087d9
p2p: use bytes.Equal for key comparison
...
Updates https://github.com/tendermint/tendermint/issues/850
My security alarms falsely blarred when I skimmed and noticed
keys being compared with `==`, without the proper context
so I mistakenly filed an issue, yet the purpose of that
comparison was to check if the local ephemeral public key
was just the least, sorted lexicographically.
Anyways, let's use the proper bytes.Equal check, to save future labor.
2017-11-18 23:34:27 -07:00
53f15fde07
update changelog
2017-11-17 00:04:03 +00:00
af0db599b0
minor fixes
2017-11-16 23:57:00 +00:00
104368bd84
Merge pull request #787 from caffix/develop
...
Initial Trust Metric Implementation
2017-11-16 23:51:53 +00:00
99461a178e
Merge pull request #857 from gguoss/patch-1
...
Failed to compile comment code
2017-11-16 18:35:18 +00:00
feb3230160
some comments
2017-11-16 04:43:07 +00:00
be1a16a601
p2p/pex: simplify ensurePeers
2017-11-16 04:30:38 +00:00
8e044b0e6d
p2p/addrbook: some comments
2017-11-16 04:30:23 +00:00
40e93a5f9e
p2p/addrbook: fix addToOldBucket
2017-11-16 04:08:46 +00:00
435eb6e2b3
p2p/addrbook: add non-terminating test
2017-11-16 04:04:54 +00:00
Zach
Ethan Buchman
Anton Kaliaev
zbo14
caffix
Adrian Brink
Petabyte Storage
Emmanuel Odeke