Commit Graph

48 Commits

Author SHA1 Message Date
derpy-duck 6fee6ba1e4
Nice comments in the code (#111)
* resend doesn't take nonce as parameter

* Replace 'delivery failure' with 'receiver failure' in specs

* helper send method

* Fix interface to match not having nonce for resend

* Fix forge tests to not have nonce as a parameter

* fix redeliveryTest

* Split CoreRelayer into CoreRelayer and CoreRelayerDelivery

* fix build error

* forge fmt

* fix interface of getdefaultrelayprovider

* Nice comments for main functions in CoreRelayer.sol

* Nice comments for CoreRelayerMessages

* forge fmt

* merge

* Removes wormholeMessageFee from storage to avoid excessive gas costs.

---------

Co-authored-by: Sebastián Claudio Nale <sebinale@gmail.com>
2023-02-28 10:09:01 -05:00
derpy-duck 7416880825
Miscellaneous fixes (#104)
* resend doesn't take nonce as parameter

* Replace 'delivery failure' with 'receiver failure' in specs

* helper send method

* Fix interface to match not having nonce for resend

* Fix forge tests to not have nonce as a parameter

* fix redeliveryTest

* fix build error

* forge fmt

* fix interface of getdefaultrelayprovider
2023-02-27 18:49:38 -05:00
derpy-duck f7de3d649d
Code cleanup (#109)
* DRY: Remove duplicate structs

* Move encode/decode/convert-request-to-instruction related files to CoreRelayerMessages

* remove rolloverchain; now it is just the chain of the first request

* forge test fix to accomdoate for removing two getters

* DRY: Remove repeated error messages

* Remove miscellaneous comments

* DRY send and forward

* replace relayprovider interface with address to match the IWormholeRelayer interface

* forge fmt

* Remove byteslib from CoreRelayer

* Remove the encoding and decoding of the delivery request -> just store the struct itself!

* forge fmt

* Rewriting of checks in send/resend/forward

* test passes

* DRY - Emit only one event

* DRY

* forge fmt

* Fix typescript error

* using IWormholeRelayer

* Consistent naming

* call wormhole.messageFee() once

* Remove unnecessary line

* Compute the length once, not every iteration

* forge tests pass
2023-02-27 14:32:57 -05:00
Sebastián Claudio Nale 004e1b3059 `forge fmt` run. 2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale 01bd5540a1 Reuse `wormhole()` and `wormhole.messageFee()` expressions. 2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale 315f0909c7 Comment a couple of optimization opportunities. 2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale a2bdeaffea Optimize `convertToEncodedRedeliveryByTxHashInstruction`.
This reduces code size and gas used.
2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale a2bca1782c Optimize `appendDeliveryInstruction`.
This simplification allows the compiler to emit less code.
2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale 958d964ad5 Avoid call if the value sent is zero. 2023-02-21 12:56:07 -03:00
Sebastián Claudio Nale 9acc9fcbd6 Cleans up `validateRedeliverySingle`. 2023-02-21 12:56:07 -03:00
derpy-duck 45021b4691 forge fmt 2023-02-21 10:43:13 -05:00
derpy-duck a7bda1a057 Nice specs for IWormholeRelayer 2023-02-21 10:43:13 -05:00
Sebastián Claudio Nale 1cae1ba324 Fixes relayer reward to take into account forward publish fee. 2023-02-17 19:57:28 -03:00
Sebastián Claudio Nale 0b10f9e2a5 Puts enum type in the `Delivery` event. 2023-02-17 19:54:26 -03:00
Sebastián Claudio Nale f7174f2084 Adds named parameters to `Delivery` events. 2023-02-17 19:54:26 -03:00
Sebastián Claudio Nale a41490cc38 Uses `abi.encodeCall` to typecheck some encoded calls. 2023-02-17 19:54:26 -03:00
derpy-duck b803184a8d forge fmt 2023-02-14 14:08:21 -05:00
derpy-duck 46d276e37e Rebase completed! 2023-02-14 14:08:21 -05:00
derpy-duck ba8a09d6f7
save target address in state and use it to verify forwarding request (#75)
* save target address in state and use it to verify forwarding request

* Fix to Multideliveries/Multiforwards

* complete merge
2023-02-14 10:33:55 -05:00
derpy-duck e8637b2b01 Remove unused error messages 2023-02-13 17:13:42 -05:00
derpy-duck 346df2e017 Most forge tests pass 2023-02-13 17:13:42 -05:00
derpy-duck 1f69c238d7 forge builds! 2023-02-13 17:13:42 -05:00
chase-45 67ff0b3baa interface refinement 2023-02-13 17:13:42 -05:00
Sebastián Claudio Nale e1b57fb4df Avoids double read on the same storage slot. 2023-02-02 17:26:23 -07:00
derpy-duck fc06699266
subtract by the overhead from running gasleft() (#74)
* subtract by the overhead from running gasleft()

* Rename variable

* forge fmt

* Clamp to the upper gas limit

* Forge fmt

* Update ethereum/contracts/coreRelayer/CoreRelayer.sol

Co-authored-by: scnale <sebinale@gmail.com>

---------

Co-authored-by: scnale <sebinale@gmail.com>
2023-02-01 13:20:39 -05:00
derpy-duck 20bb4c7f8e
Think about upper limits (#68)
* Change arbitrary contraints

* higher limit asset conversion buffer

* Remove unnecessary constraints on tests, and impose lighter constraints

* Forge fmt

* change to power of 2, and remove fuzz=25 limit

* set deliver gas overhead nonzero (#71)

* Fix previous redelivery tests to test emitting of InvalidRedelivery r… (#69)

* Fix previous redelivery tests to test emitting of InvalidRedelivery rather than the old reverting

* remove extraneous comment

* forge fmt

* Actually fix contracts to work for 2^256
2023-01-31 16:23:58 -05:00
derpy-duck f96902d430
No forwards are allowed from addresses that aren't the targetAddress (#70) 2023-01-30 17:30:22 -05:00
derpy-duck 8b0a776946
Remove wormhole fee from delivery/redelivery quote (#63)
* merge

* Forge fmt
2023-01-26 17:08:42 -05:00
derpy-duck 673542854d
Redelivery fixes (#61)
* smart contract changes for redelivery

* Tests pass for new Redelivery interface

* remove console logs

* forge fmt

* forwarding interface fix

* Remove the rolloverChain parameter from requestForward

Co-authored-by: chase-45 <chasemoran45@gmail.com>
2023-01-26 15:10:44 -05:00
derpy-duck 5a3ff82c43
Application Budget Bugfixes (#60)
* Application Budget Fixes and Tests

* Adding application budget to redelivery test

* Application Budget Test with Redelivery Works

* remove console log import

* Remove console logs from tests

* Remove console logs from mockrelayerintegration

* Use uint32.max and fix outOfFund error in tests

* Removed unnecessary require
2023-01-26 14:27:57 -05:00
derpy-duck 546fc1969e
Save Gas: Remove Relay Protection on deliverSingle and redeliverSingle (#45)
* Remove replay protection on deliverSingle and redeliverSingle

* forge fmt

* redelivery fixes, events & relayer refund address

* Got tests passing again (still have to alter a few redelivery tests to validate the new emitted error)

* forge fmt

* Attempt at fixing typescript error

* Forge fmt

* Add indexed

* Fix tests to correctly obtain deliveryVaaHash due to new event structure

* forge fmt

Co-authored-by: chase-45 <chasemoran45@gmail.com>
2023-01-19 14:38:52 -05:00
agodnic 87cfc41bf5
Replace strings with typed errors (#37)
* Replace strings with typed errors

Replace strings with typed errors in `ethereum/contracts/relayProvider/*.sol`.

* Rename misleading identifier

* Update forge assertions to use typed errors

Update RelayProvider unit tests to use typed errors.

* Replace strings with typed errors

Replace strings with typed errors in `ethereum/contracts/coreRelayer/*.sol`.

* Update forge assertions to use typed errors

Update CoreRelayer unit tests to use typed errors.

* `forge fmt`
2023-01-19 09:59:35 -05:00
derpy-duck 9d51fd54ae
Fix bug related to refunding of application budget if delivery fails (#42)
* Fix bug related to refunding of application budget if delivery doesn't succeed

* forge fmt

* Fix some yul error

* forge fmt
2023-01-18 21:35:52 -05:00
derpy-duck 177862cd78
Allow governance to update asset conversion buffer, and also remove t… (#44)
* Allow governance to update asset conversion buffer, and also remove the dependency on source chain for asset conversion buffer

* forge fmt
2023-01-18 18:51:06 -05:00
derpy-duck 9e3453709f forge fmt 2023-01-18 13:05:33 -07:00
scnale 4a57a6c371
Replaces "bare" with named parameters in struct constructor calls. (#35) 2023-01-13 15:27:59 -05:00
derpy-duck f8a75595b8
Forward should be payable right? (#38)
* Forward should be payable right?

* fix spacing
2023-01-13 15:26:20 -05:00
derpy-duck 53d67259f8
Remove wormhole message fee from calculateTargetGasDeliveryAmount (#41) 2023-01-13 15:26:04 -05:00
derpy-duck 034a7dd831
Deliver single and request delivery forge tests (#36)
* Tests for 7 errors messages in deliverSingle and 3 error meessages n requestDelivery

* Update forge tests to use new CoreRelayer governance

* Remove console.sol import

* Remove console logs

* Changing limit from 2^62-1 to 2^63-1

* Testing changing wormhole fees for all current tests

* Run forge fmt, remove [fuzz] params

* remove whitespace
2023-01-11 14:11:43 -05:00
chase-45 5bd7ba46ab CoreRelayerLibrary for governance + ts scripts for vaa registrations 2023-01-09 14:50:44 -07:00
chase-45 cd26ace599 core relayer contracts upgrade via governance 2023-01-09 14:50:44 -07:00
scnale c4df1ecbab
Removes redundant abicoder pragmas. (#33)
See https://docs.soliditylang.org/en/latest/080-breaking-changes.html#silent-changes-of-the-semantics
2023-01-09 15:14:40 -05:00
derpy-duck db159946bb Redelivery Error Testing - Errors 1, 9-17 2023-01-06 22:27:03 +00:00
Joe Howarth d9f9dfb173 run forge fmt 2023-01-05 17:46:58 -07:00
Joe Howarth ab833b38cf
Move development branch to main (#23)
* refactoring for multidelivery

* partial ts-test fixes

* use typechain in integration tests, update prettier, fix remaining integration tests

* run formatter on solidity files

* gas refunding

* gas forwarding logic

* msg.send -> refundAmount

* minor test refactor & additions

* created relayer engine directory

* more testing & tilt environment config for relayer engine

* starting work on the xMint example contracts

* additions for relayer engine

* minor modifications & todos

* fixed some errors

* refactoring + cleaned up some TODOs

* updated ICoreRelayer interface

* adjusted tests for new interface

* Working testSend

* Merged refactoring + cleaned up some TODOs

* updated ICoreRelayer interface

* adjusted tests for new interface

* Working testSend with new interface'

* refactoring interfaces & files for single VAA design

* GasOracle implementation of new interface

* GasOracle compiles

* Gas oracle upgradable

* Fix compile errors in GasOracleGovernance

* minor core relayer cleanup

* Changes to getters, setters, state

* implement quoteEvmDeliveryPrice, quoteTargetEvmGas, assetConversionAmount for corerelayer

* Correcting interface inconsistencies between CoreRelayerStructs and ICoreRelayer

* Fix encodeDeliveryRequestsContainer

* added single vaa delivery entrypoint logic

* Encode and Decode delivery instructions

* Fixed many compile errors

* First attempt at removing stacktoodeep error

* Commenting out chunks of code to identify stack too deep error

* Continue stack too deep quest

* Revert "Commenting out chunks of code to identify stack too deep error"

This reverts commit 8cd55d26ce.

* Revert "Continue stack too deep quest"

This reverts commit f0cde6871e.

* Fix stack too deep error in CoreRelayerMessages

* tests compile, run, pass

* fixing up fee collection assertions

* GasOracle tests altering

* Rename encodeDeliveryIntructions to convertToEncodedDeliveryInstructions because we are going from delivery request to delivery instruction

* adding evm events to delivery execution

* forwarding refactor for single vaa

* relay provider name refactor

* Test file slight refactor to allow for multiple chains

* first impl of hub and spoke example

* Forward test progress

* Forwarding test passes!

* More general parameters for test

* Testing file more modular, calls 'generic relayer'

* redelivery implementation

* removing todos

* Tests can use arbitrary amount of chains

* Address various TODOs

* refactored RelayProvider to be upgradeable via proxy

* Add overhead inteface to RelayProvider & adjusted necessary fee calculations

* added TODOs related to rewardAddress payout

* provider price quoting changes

* provider payments made at source

* Fixed all compile errors

* testForward and testSend pass again!

* Switched quoteAssetConversion to quoteApplicationBudgetFee in CoreRelayer interface

* First round of changes to support individual vaas in offchain relayer

- Use new custom plugin event source api in relayer engine
- Supports mulit delivery
- Config for celo and fuji

* contracts deploy successfully to tilt

* bug fixes, contracts deploy to tilt

* Starting the redelivery test

* Tests pass again, with exception of the RelayProvider tests that tested reverts, and the new testRedelivery which isn't finished

* small plugin changes

* MockRelayerIntegration is used for sending

* prepare offchain relayer to run in both tilt and testnet

* update readme and npm scripts for offchain relayer

* nit: remove console.log(argv)

* solc version bump

* Tests changed to pass (commented out the tests with differing require statements and kept redelivery incomplete

* chain registration typescript scripts

* Redeliver works!

* Redelivery test works!

* testnet deploy + relayer engine test

* Testing two sends

* Friday changes to round trip on testnet

* Shortening current tests

* Funds are correct! Relayer gets paid!

* Remove extraneous comments

* ts scripts for deployment and config

* Wormhole Fee Test

Co-authored-by: chase-45 <chasemoran45@gmail.com>
Co-authored-by: derpy-duck <115193320+derpy-duck@users.noreply.github.com>
2023-01-05 17:26:27 -05:00
Reptile ddc421bb90
Update comments and interface (#9)
* Update comments and interface

* Remove casting to uint8 in struct definitions

Co-authored-by: gator-boi <gator-boi@users.noreply.github.com>
2022-10-31 14:57:07 -05:00
A5 Pickle 0b9e81ffc5
Clean up send (#2)
* Update README.md with trustlessness

* ethereum: rename AllowedEmitterSequence; remove arbitrary payloads

* ethereum: refactor integrator contract; add verifying payload

* ethereum: update IWormhole

* ethereum: add message verifying in mock integration

* Remove deliveryList from DeliveryInstructions and fix stack too deep

* Remove maximum batch size from relay parameters

* ethereum: fix observation loop; formatting

* sdk: fix eth-integration test

* offchain-relayer: add regenerate-abi.sh

* fix Makefile

* offchain-relayer: add relayer.tilt.yaml

Co-authored-by: Evan Gray <56235822+evan-gray@users.noreply.github.com>
Co-authored-by: A5 Pickle <a5-pickle@users.noreply.github.com>
Co-authored-by: gator-boi <gator-boi@users.noreply.github.com>
2022-10-06 12:16:57 -05:00
Reptile d3b6470936
Add tests for send and deliver functionality (#9)
* Complete send and deliver functionality

* Clean up

* Add tests for relayer send method

* ethereum: remove interfaces

* ethereum: fix test

* ethereum: rename directory

* ethereum: clean up; add ts tests

* Add tests and clean up

* ethereum: fix test

* ethereum: fix output

* Add reentrancy protection and reduce gas overhead for relayers

* Add tests for full batch delivery

* Update relayer contracts to reflect changes to batch VAA implementation

* add rewards payout

* implement redeliveries, replay protection

* Complete full batch test suite

* sdk: add sdk

* sdk: fix package.json

* Add partial batch unit test and add to integration test

* Fix comments in integration test

* sdk: fix tsconfig.json

* ethereum: fix build

* Add relayer registration to integration test

* Finish integration test suite

* ethereum: fix readAbi

* ethereum: fix merge conflict

* Complete full batch test suite

* Add partial batch unit test and add to integration test

* Finish integration test suite

* Fix local validator test

* Fix merge conflict

* Add Makefile

* Add documentation to relayer contracts

* Fix Makefile

* ethereum: clean up

* ethereum: fix interface

* ethereum: fix method names and tests

* Prepare integration test for off-chain relayer changes

* Refactor contracts

Co-authored-by: Drew <dsterioti@users.noreply.github.com>
Co-authored-by: Karl Kempe <karlkempe@users.noreply.github.com>
Co-authored-by: valentin <valentinvonalbrecht@yahoo.de>
Co-authored-by: justinschuldt <justinschuldt@gmail.com>
2022-09-30 11:18:49 -05:00