Commit Graph

3031 Commits

Author SHA1 Message Date
DeionSi b2a3fdd88d
Add Lambda options for EGO correction and Nitrous leanest AFR (#993)
* Added Lambda option for EGO correction. Same fields, just another way to view and set them.

* Added Lambda option for Nitrous Leanest AFR. Same field, just another way to view and set it.
2023-01-30 15:22:15 +11:00
DeionSi 41352d22bf
Add lambdaTable and memory map to afrTable (#988)
* Add and memory map lambdaTable to afrTable

* Remove extra lambdaTargetTables entry
2023-01-30 14:20:14 +11:00
DeionSi 9a03a91261
Use separate afrProtectDeviationLambda constant memory-mapped onto afrProtectDeviation (#989)
* Use separate afrProtectDeviationLambda constant memory-mapped onto afrProtectDeviation

* 3 decimal accuracy for Lambda

* Add default for afrProtectDeviationLambda
2023-01-30 14:18:52 +11:00
DeionSi 6df8162897
Scale AFR gauge warnings by stoichiometric ratio (#986) 2023-01-30 14:13:46 +11:00
wonder99 ee0818d982
Add Tacho Sweep function at startup (#935) 2023-01-11 14:27:16 +09:00
tx_haggis 3595634bd2
Table3D: MISRA fixes (#973) 2023-01-11 10:58:48 +09:00
Josh Stewart a311c37e31 Fix README badges
See https://github.com/badges/shields/issues/8671
2023-01-10 08:59:01 +09:00
Pasi Kemppainen 11313ba440
Fix decel in AE Add -mode (#971) 2023-01-10 08:46:34 +09:00
DeionSi fec50e9db7
Fix reset lock indicator for always on (#951) 2023-01-09 21:55:31 +09:00
DeionSi 3495877d0f
Tests failing due to out of memory and uninitialized variables (#979)
* Free up memory for tests_misc

* Tests failed by uninitialised variables
2023-01-09 06:53:45 +09:00
tx_haggis efccfed057
Install dos2unix (#974) 2023-01-05 00:28:21 +09:00
tx_haggis 8888e06e7f
MISRA check: add XML output (#967)
* MISRA check: add XML output

* Improve handling of cppcheck output

* Simplify - make cppcheck do more work
Now need for the script to gather source files
and run them one at a time, or flatten xml etc.

* Define the byte type - flushes out violations.

* Precaution: apply dos2unix before invoking shell script

* Restore force rename of libdivide folder
Scans on Windows Git Bash were taking way too long.

* Performance: run as many cppcheck jobs as possible
Logical CPU count - 1

* Set the build dir
Prevents temp files being left in the source tree
2023-01-01 10:25:59 +09:00
Josh Stewart b30fde5685 Fix unit tests following #939 2022-12-14 11:25:54 +00:00
Jon Billings 8e4b840325
stuck ego fix (#942)
Ego control gets stuck at 100% when ignitionCount wraps during an DFCO event because the test "if (ignitionCount < AFRnextCycle).." continues to fail until ignitionCount catches up with AFRnextCycle again - long time.
This fix also checks for ignitionCount < (AFRnextCycle - configPage6.egoCount)
2022-12-14 12:03:53 +11:00
Pasi Kemppainen f59d013714
Add deceleration enleanment feature (#939)
* Add decel enleanment feature

* Fix tps and map DOT scaling in TS.

* updates.ino

* Small bug fix.

* One more small bug fix.

* Update cancomms.ino

Cast tps/mapDOT as uint8 to cancomms to retain backwards compatibility

* Fix programmable outputs list.

* Fix programmable outputs in updates.ino

* Add abs around currentStatus.mapDOT
2022-12-14 11:17:47 +11:00
Pasi Kemppainen eb97b8458c
Add parameters to require power cycle (#940) 2022-11-30 15:19:01 +11:00
DeionSi 647681767e
Scale IAT and CLT calibration to ADC 1023 instead of 992 (#959) 2022-11-30 15:16:49 +11:00
Josh Stewart 03d09e91d3
Update README.md 2022-11-24 10:25:18 +11:00
Josh Stewart 22d2b4e38e Add delay to oil pressure engine protection 2022-11-23 16:15:01 +11:00
Josh Stewart 461e632db7 Allow use of RPM2 pin as VSS input with missing tooth 2022-11-22 16:46:32 +11:00
Josh Stewart 4693cb2013 Change to single decoder state variable. Small (12 byte) RAM free up 2022-11-22 15:53:35 +11:00
rafolg 86319f43ca
Update decoders.ino (#944)
Fix an issue where negative trigger angles cause erroneous crankAngles for ignition by tooth.
2022-11-14 10:52:21 +11:00
dependabot[bot] 1f03a7b25e
Bump actions/cache from 2 to 3 (#964)
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-14 10:46:19 +11:00
tx_haggis 56ab7c054d
Table 3d: change X-axis orientation to match Y-axis (#771)
* Change X axis in memory orientation to match Y

* X & Y axes can use the same type (Ie.e class)

* Table3D axis iterator: replace reverse() with rbegin()

* Use iterators as part of unit tests

* Doxygen fixes/corrections
2022-11-14 10:26:14 +11:00
Josh Stewart a71dcffe9f Small memory reduction in AE code 2022-11-07 14:49:49 +11:00
tx_haggis ad7d4f6ae9
Fix Miata 99-05 new ignition mode conditional (#918)
It was being applied when the trigger angle==0 regardless
of the perToothIgn ignition flag: replace || with &&.
2022-11-07 13:54:36 +11:00
Vitor Moreno B. Sales 8e2fb0b36e
Added possibility to configure Steper bounds (#930)
Previous bounding worked only for PWM
2022-11-07 13:52:04 +11:00
Josh Stewart be58be3b18 Add missing pin defaults for v0.3 board 2022-11-07 12:12:31 +11:00
Josh Stewart 2fc29ceef5 MISRA cleanup rule: misra-c2012-8.2 2022-11-06 09:43:29 +11:00
DeionSi a1d3c59af7
Lower max on IAT and CLT gauges for celsius (#958)
* Lower max on IAT and CLT gauges

* CLT, IAT and FuelTemp gauges to max 120c/248f
2022-11-04 12:36:10 +11:00
dependabot[bot] 7062f5381d
Bump actions/checkout from 2 to 3 (#947)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-04 12:03:15 +11:00
Piotr Rogowski 6b98ebbaaf
Add upload INI action (#962)
* Add upload INI action

* Run only when INI changes
2022-11-04 10:39:45 +11:00
Piotr Rogowski 9affde119e
Fix INI validation (#952) 2022-10-24 09:20:39 +11:00
dependabot[bot] 4da699bb39
Bump schneegans/dynamic-badges-action from 1.4.0 to 1.6.0 (#950)
Bumps [schneegans/dynamic-badges-action](https://github.com/schneegans/dynamic-badges-action) from 1.4.0 to 1.6.0.
- [Release notes](https://github.com/schneegans/dynamic-badges-action/releases)
- [Changelog](https://github.com/Schneegans/dynamic-badges-action/blob/master/changelog.md)
- [Commits](https://github.com/schneegans/dynamic-badges-action/compare/v1.4.0...v1.6.0)

---
updated-dependencies:
- dependency-name: schneegans/dynamic-badges-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-20 13:56:39 +11:00
Josh Stewart 2269e688f3 Lower SPI EEPROM write frequency 2022-10-19 12:19:52 +11:00
dependabot[bot] 2f77ce0303
Bump actions/setup-python from 2 to 4 (#949)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v2...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-19 10:42:56 +11:00
Piotr Rogowski 5b9f66a8d6
Add `dependabot` (#946) 2022-10-19 10:38:57 +11:00
Josh Stewart eb5ed8e460 Fix syntax error in ini 2022-10-18 11:25:27 +00:00
Piotr Rogowski b1a2277e79
Add `Validate INI` action (#945) 2022-10-18 22:18:39 +11:00
rafolg dd38d0d7fb
Update board_teensy41.ino (#937)
Auxiliary interrupts should be called after timer flag resets to avoid RPM drops at high engine speed
2022-10-09 13:48:53 +11:00
Josh Stewart c8d51d686b Nissan 360: make sure elapsedTime variable is set. Fixes #705 2022-10-03 15:43:43 +11:00
Josh Stewart 3997708997 Improvements to init unit tests 2022-09-29 09:47:37 +10:00
Josh Stewart 960d713889 Reduce spark duration when dwell limit is exceeded.
Potential fix for #932
2022-09-27 11:55:42 +10:00
Josh Stewart 114e9b2c7d Correct Teensy 4.1 PIT clock scaler 2022-09-16 17:52:59 +10:00
tx_haggis b8278e7ecb
Include CPP files in MISRA script (#925)
* Push libdivide #def into build flags

* Allow build without USE_LIBDIVIDE

* Rename libdivide folder before & after scan

It's the only way to really exclude it
2022-09-15 12:16:14 +10:00
Jon Billings f1a4ff014c
Jeep2000 fix (#912)
* Fix Jeep2000 decoder

getCrankAngle_Jeep2000() sets crankangle = 146 if toothcurrentcount = 0, because last tooth was cam tooth  which is 146 ATDC, however, all the timing and angle calculations are not done on the cam tooth read, so crankangle should be set to 118 for previous crank tooth.

* fix the fix

@jaredsellers4 pointed out that to be consistent with the rest of the crank tooth timings, it should be the leading edge, 114, rather than 118.

* Further improvement to Jeep 2000 decoder

1) filter out secondary signals when primary tooth is not 12 or 13 (because it's noise)
2) scale the trigger filter gap according to whether the next gap is bigger, smaller or the same as the previous/current gap.

* Revert "Further improvement to Jeep 2000 decoder"

This reverts commit 3510aa49c3.

* fix Jeep2000 to address #897

getCrankAngle_Jeep2000() sets crankangle = 146 + triggerAngle when toothCurrentCount = 0, because toothCurrentCount was set to 0 on seeing the Cam tooth, and the cam tooth angle is 146.
However, the tooth timings that are subsequently used in calculations are from the previous crank tooth, which was at 114. Therefore 114 is the correct crankangle to work with.

Co-authored-by: Jon Billings <jon.billings@bbc.co.uk>
2022-09-15 09:59:18 +10:00
rafolg a40971dde1
Configuration of PWM for idle, boost and vvt for Teensy4.1 (Take2) (#929)
* Fix VSS not resetting to zero

Reinstated car stop check to avoid  speed not going back to zero.

* Better logic for gear detection

Previous gear detection logic had gears constantly lagging 1 shift behind.

* Update sensors.h

* Update sensors.ino

* Update sensors.ino

* Update sensors.h

* Update board_teensy41.h

Pit timers implementation for idle, boost and vvt

* Update board_teensy41.ino

Pit timers implementation for idle, boost and vvt

* Update board_teensy41.h

Error in fuel5-8 timer disable now corrected

* Update auxiliaries.ino

Enable vvt PWM for Teensy 4.1

* Update idle.ino

* Update board_teensy41.h

For some reason the PIT_LDVAL compares were not showing on  the previous PR

* Update auxiliaries.ino
2022-09-15 09:58:37 +10:00
ric355 659eb8ec0f
Fix for uninitialised variable in OLCL and CL stepper idle control (#926)
* Fix problem of using an uninitialised variable when initialising the stepper
after power on.

* Fix faulty idle taper causing OLCL and CL stepper to get stuck in the cranking position.

Co-authored-by: Richard Metcalfe <richard@richmet.com>
2022-09-13 23:16:31 +10:00
Josh Stewart c8b7c18622 Flush serial rx buffer if a CRC error is found 2022-09-13 17:33:04 +10:00
Josh Stewart 3923ecf12f Tweaks to 2560 EEPROM burn during multi page writes 2022-09-12 11:53:18 +10:00