Commit Graph

1119 Commits

Author SHA1 Message Date
rusefillc e189d6517b random Frankenso clean-up 2022-12-14 19:29:01 -05:00
Matthew Kennedy 5250b177c2
Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
rusefillc 5e62595d69 reduce flash footprint by smarter code generation #4163 2022-12-03 00:51:41 -05:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey 32e502c569 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey 405b23d682 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 20:08:19 -05:00
Andrey e6993aa248 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
rusefi 5499938d52 x2 spelling 2022-11-30 17:14:16 -05:00
Andrey 4e74882c5e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Andrey 6ad3ce13d6 ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 98e886e00b mock invalid & current state of ETB error counter 2022-11-29 20:36:03 -05:00
Andrey 9a1c7b36ba refactoring: extracting method 2022-11-29 20:11:34 -05:00
Andrey 21b217f132 ETB duty cycle jitter #4833
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 368517780d ETB duty cycle jitter #4833 2022-11-29 14:02:44 -05:00
Andrey 607a5677d4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey 4dd9217327 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey 5b88c6b535 exp average is pretty cool 2022-11-28 19:22:45 -05:00
Andrey bb59bbbe51 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 55062b1ef6
refactoring: constexpr fuel computer (#4830)
* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc 23698be5f8
without ValueProvider3D interface how do we mock? (#4829)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey 3b7b8e3f33 nissan 2022-11-23 23:45:25 -05:00
rusefillc 8eaa901595
avoid ctime in GPS UART (#4824)
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte fd1115d01a
code style, GPS fixes (test, firmware) (#4822)
* tidy NMEA

* const in nmea

* correct gps test output

* fix GPS UART print statements

* cleanup feature toggles in settings

* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
Andrey 6ca9b6eda7 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
Andrey G 27166f4b23
SENT updates (#4774)
* SENT: simplify

* SENT: add crc6 routine, check crc for slow channels enhanced messages

* SENT: helper to get Slow Channel values

* SENT: getTickTime() report tick unit time

* unit_tests: SENT: update tests
2022-11-12 16:57:20 -05:00
Andrey 3def9396de Nissan 2022-11-12 13:06:55 -05:00
Andrey G 64be738874
SENT unit tests (#4769)
* unit_tests: sent: zero-init

* sent: SENT_SLOW_CHANNELS_MAX to header

* unit_tests: sent: clock, falling edges

* SENT: support and autodetect if device sends pause pulse

Also rework tick time calculation

* unit_tests: SENT: verbose debug on request

* unit_tests: SENT: actual checks

* unit_tests: SENT: extract common code for reuse

* unit_test: SENT: add test with fuel pressue captured data

* unit_test: SENT: add test with Ford ETB CLOSED captured data
2022-11-11 17:25:02 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy 7bd9dbf89e
fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
Andrey a25c9ab520 Ford SENT ETB bench test in NJ #4745
we shall unit test SENT
2022-11-07 00:06:42 -05:00
rusefillc 6d3e71fae3 Ford SENT ETB bench test in NJ #4745
we shall unit test SENT
2022-11-06 23:21:54 -05:00
rusefi 1f3ab0cf24 reducing ugly 2022-11-06 21:28:38 -05:00
rusefi 9ccb0ccb0c https://rusefi.com/forum/viewtopic.php?p=46603#p46603
calling 'setTimeout' on bad self (cpp class not export)
2022-11-06 20:09:01 -05:00
Andrey a5136a0eae trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc 36d5b1fbb6 minor trigger refactoring 2022-11-06 00:59:29 -04:00
Matthew Kennedy f4f5f69ee6
duplicate log field names (#4730)
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy 1269428044
remove idle timing deadzone (#4731)
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey ccca90cb55 Nissan defaults 2022-11-02 12:05:51 -04:00
rusefi 93f9e81e9e huh, we can pole larger method here 2022-10-26 12:08:27 -04:00
Matthew Kennedy 24650f6460
implement "ford mode" injector correction (#4686)
* implement "ford mode"

* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc d13a851c97 triggerImage: todo: support symmetrical crank 2022-10-16 10:33:38 -04:00
rusefillc 5fb9f7c2df triggerImage: todo: support symmetrical crank 2022-10-16 02:59:57 -04:00
rusefillc d91211106c triggerImage: todo: support symmetrical crank 2022-10-16 02:44:57 -04:00