Commit Graph

1136 Commits

Author SHA1 Message Date
Matthew Kennedy eb56c2897a
detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
Matthew Kennedy 1eca0ca1bd
Jammed ETB detection (#4873)
* jammed ETB detection

* autoscale

* comment

* cleanup

* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey 289171a85a symmetrical shapes are not rendered right #4956 2023-01-08 22:37:35 -05:00
rusefillc 2e882986f4 refactoring 2023-01-08 22:30:57 -05:00
rusefillc 68dcbd214e sweet 4g93 data 2023-01-07 17:31:13 -05:00
Andrey 0f1d46238f Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy e5d199272d
improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
Andrey 987e59f7cc Mitsubishi 4G93 Trigger issues #4918
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey def809aa39 Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey c9d88d2605 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey d0f6fa8ea3 let's try again 2023-01-03 08:38:42 -05:00
Andrey 603f188b55 a bit of dead code 2023-01-03 07:49:17 -05:00
Andrey c8b998a911 test coverage for antilag #4920
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey 1afa6fa99a test coverage for antilag #4920
bugfix?
2022-12-30 12:21:04 -05:00
Andrey 7138b9d1c1 test coverage for antilag #4920 2022-12-30 12:17:53 -05:00
Andrey 57d76d902f test coverage for antilag #4920 2022-12-30 12:11:57 -05:00
rusefillc 24cdca5515 refactoring: method name 2022-12-27 00:13:13 -05:00
rusefillc e189d6517b random Frankenso clean-up 2022-12-14 19:29:01 -05:00
Matthew Kennedy 5250b177c2
Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
rusefillc 5e62595d69 reduce flash footprint by smarter code generation #4163 2022-12-03 00:51:41 -05:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey 32e502c569 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey 405b23d682 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 20:08:19 -05:00
Andrey e6993aa248 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
rusefi 5499938d52 x2 spelling 2022-11-30 17:14:16 -05:00
Andrey 4e74882c5e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Andrey 6ad3ce13d6 ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 98e886e00b mock invalid & current state of ETB error counter 2022-11-29 20:36:03 -05:00
Andrey 9a1c7b36ba refactoring: extracting method 2022-11-29 20:11:34 -05:00
Andrey 21b217f132 ETB duty cycle jitter #4833
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 368517780d ETB duty cycle jitter #4833 2022-11-29 14:02:44 -05:00
Andrey 607a5677d4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey 4dd9217327 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey 5b88c6b535 exp average is pretty cool 2022-11-28 19:22:45 -05:00
Andrey bb59bbbe51 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 55062b1ef6
refactoring: constexpr fuel computer (#4830)
* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc 23698be5f8
without ValueProvider3D interface how do we mock? (#4829)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey 3b7b8e3f33 nissan 2022-11-23 23:45:25 -05:00
rusefillc 8eaa901595
avoid ctime in GPS UART (#4824)
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte fd1115d01a
code style, GPS fixes (test, firmware) (#4822)
* tidy NMEA

* const in nmea

* correct gps test output

* fix GPS UART print statements

* cleanup feature toggles in settings

* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
Andrey 6ca9b6eda7 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
Andrey G 27166f4b23
SENT updates (#4774)
* SENT: simplify

* SENT: add crc6 routine, check crc for slow channels enhanced messages

* SENT: helper to get Slow Channel values

* SENT: getTickTime() report tick unit time

* unit_tests: SENT: update tests
2022-11-12 16:57:20 -05:00
Andrey 3def9396de Nissan 2022-11-12 13:06:55 -05:00
Andrey G 64be738874
SENT unit tests (#4769)
* unit_tests: sent: zero-init

* sent: SENT_SLOW_CHANNELS_MAX to header

* unit_tests: sent: clock, falling edges

* SENT: support and autodetect if device sends pause pulse

Also rework tick time calculation

* unit_tests: SENT: verbose debug on request

* unit_tests: SENT: actual checks

* unit_tests: SENT: extract common code for reuse

* unit_test: SENT: add test with fuel pressue captured data

* unit_test: SENT: add test with Ford ETB CLOSED captured data
2022-11-11 17:25:02 -05:00