bf7ae2c76e
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 13:10:38 -04:00
b7601e063f
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 11:40:47 -04:00
383d8caad9
Lua CAN RX ( #3403 )
...
* wiring
* static
* implementation
* comment
* unit tests happy
* guard
* guard smarter, not harder
* guard smarter not harder
* guard even smarter, not even harder
* don't need that
2021-10-24 08:37:04 -04:00
8a841bb52c
lua can set sensors ( #3389 )
...
* add sensor unsubscribe
* sensor hook
* test it!
* virtual destructor makes us sad
* ensure deinit
2021-10-22 16:36:29 -04:00
b750755369
findSensorTypeByName
2021-10-21 14:33:59 -04:00
37594d5646
findSensorTypeByName
2021-10-20 22:21:42 -04:00
eb05f4594e
very old very dead code
2021-10-20 12:57:07 -04:00
1493973bea
very old very dead code
2021-10-20 10:38:36 -04:00
e4c34e016a
last packet optimization ( #3363 )
...
* last packet optimization
* comment
* test
* missed one
* set tcp mss
2021-10-18 19:59:08 -04:00
bc4a068c9c
[DRAFT] IAC H-Bridge Microstepping ( #3213 )
...
* fix for stepperHbridgeHardware
* new config fields for microstepping
* add stepper dir pin mode to the dialog
* refactor stepper hw dialog & add microstepping panel
* microstepper modes enum
* stepperDcInvertedPins needed by Hellen
* add sleep() for stepper and divisor for pause()
* microstepping impl.
* make unit-tests more happy
* small progress
* fix etb-stepper dlg conflict
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 13:57:04 -04:00
d917cc8cc2
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
9797d25b7c
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
db12cdbe19
put MAP in the sensor model ( #3292 )
...
* map averaging in sensor model
* deadly, deadly code!
* mpxh
* Revert "deadly, deadly code!"
This reverts commit 346fe25267966a313145a809792dced84be348cf.
* comments
* sensor types
* last sensor
* channel init
* correct spot
* deinit properly
* simplify
* fix
* mocks
* map init test
* showInfo
* comment
* singleton identity function
* sensor info print
* multiple cylinder averaging buffer
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-04 17:18:08 -04:00
77ebc71f9a
overdwell protection #3071 ( #3294 )
2021-10-02 01:17:53 -04:00
0a550a70b1
overdwell protection ( #3220 )
...
* cancel event
* looks like it works...
* some tests are happy
* add enable bit
* undo test changes
* Revert "add enable bit"
This reverts commit 000afadd3fc560867302557afe26f76cd9fc4ed6.
* enable bit in engine
* only turn off for one test
* Revert "undo test changes"
This reverts commit 106db49e291b5a531a94de6ac177c6584d5337f6.
2021-10-02 01:10:24 -04:00
13d21716db
reducing crazy in unit tests
2021-10-02 00:13:15 -04:00
097e871b19
reducing crazy in unit tests
2021-10-02 00:00:08 -04:00
3da054c6e7
reducing crazy in unit tests
2021-10-01 23:53:22 -04:00
d478c9c411
reducing crazy in unit tests
2021-10-01 22:33:06 -04:00
b71d3c6111
reducing crazy in unit tests
2021-10-01 22:29:44 -04:00
a6fbb98193
Complete fuel cut, maybe by wall wetting? Warning on decel (?) CUSTOM_OBD_SKIPPED_FUEL = 9010 fix #3225
2021-09-27 22:04:03 -04:00
f41a2715a3
system lua: load a script! ( #3231 )
...
* load script
* test
* needs more rams
* embiggen stack
* init system lua from lua thread
* de-embiggen stack
* system needs a little more
* memory
* om nom nom delicious memory
* how much more memory could it want
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-23 21:45:14 -04:00
b5bde5c307
Turbo sensor ( #3245 )
...
* outputs rpm
* no msg param necessary
* new sensor type
* happy test
2021-09-20 15:39:41 -04:00
bb341c4c07
Turbo speed sensor implementation #2935 ( #3209 )
...
* Add turbocharger speed converter class
* Add turbocharger speed converter tests
* Add turbocharger speed sensor initialization functions
* Add turbocharger speed sensor to initialization
Co-authored-by: alxrMironov <330OMcorporative>
Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-09-19 20:50:11 -04:00
6307ffd3a6
merc128: engine config defaults #3236
2021-09-18 22:12:22 -04:00
3e50319eb7
merc128: engine config defaults #3236
2021-09-18 21:27:17 -04:00
847fb75a23
TS channel names for nicer console messages
2021-09-18 15:33:14 -04:00
c72bd07179
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
427cce7596
Lua timer ( #3218 )
...
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* lua timer is happy (#3216 )
* hooks are happy
* don't need that any more
* format
* update lib
* module
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2021-09-03 20:21:39 -04:00
730b26d034
remove old vss implementation ( #3208 )
...
* dead vss
* remove
2021-08-28 01:39:55 -04:00
6407e74ae2
disable closed loop boost below MAP threshold ( #3206 )
...
* boost minimum map
* changelog
2021-08-27 17:54:08 -04:00
cf5d4cbe1c
add & test remove from linked list ( #3199 )
2021-08-26 23:03:09 +03:00
a18b86a09b
start allowing ADC change while running ( #3100 )
...
* allow re-register of the same sensor
* add api to unsubscribe
* do it for tps
* clear the pin
* happy test
* maybe make afr happy for now
* tests build
* happy simulator
* active configuration
* check valid
* we need vbatt now
* manage all pin init in init_sensors.cpp
* don't need that
* cleanup
* thermistors
* do two phase reinit in the right place
* config vs engine
* finally the tests are happy
2021-08-24 16:41:16 -04:00
f926d2ccba
Vehicle speed switching to frequency sensor #3106 ( #3148 )
...
* Add vehicle_speed_converter.h with realization.
* Add test_vehicle_speed_converter.cpp with realization.
* Add test_vehicle_speed_converter.cpp to Makefile
* Edit "VehicleSpeedSensor" from function pointer sensor to frequency sensor
* Fix "VehicleSpeedSensor" init function args
* Remove "VehicleSpeedConverter" empty constructor
* Edit vehicle_speed_converter.h code style
* Fix args and engine injection in "VehicleSpeedSensor" initialization procedure
* Remove old "Vehicle Speed" module initialization
* Revert "Remove old "Vehicle Speed" module initialization"
This reverts commit 100b7caa8c615c20eed3d0c23a49824b4e556148.
* Remove old "Vehicle Speed" module initialization pieces
* Revert "Revert "Remove old "Vehicle Speed" module initialization""
This reverts commit f559a726f1f7f5a7acacd1b6517e571743e84327.
* Debug changes
* Revert "Debug changes"
This reverts commit f7e2be1a8a46c6f3f93f14f002b2f2db539da8e2.
* Another debug changes
* More debug changes
* And more debug changes.
* Revert "Another debug changes"
This reverts commit 914fbb1df42c37e4b5ecbb119bb45e7cffdf4064.
* Revert "More debug changes"
This reverts commit 0b2d96d461c3cd9b0f1ae97ed110b8effe6b0cc6.
* Revert "And more debug changes."
This reverts commit 06ae8daded0e6e1c025e4e5058b47283f4adfe92.
* Add "Vehicle Speed" sensor reconfiguration
* Revert "Add "Vehicle Speed" sensor reconfiguration"
This reverts commit a089a6d563dd710004ce1a7da1744b0b4b90c3b1.
* Revert "Revert "Add "Vehicle Speed" sensor reconfiguration""
This reverts commit 7b2bb8af4b3caa547236ca59e4c4bdb3ac1200cc.
* Debug changes
* Another debug changes
* Fix another debug changes
* Another debug changes 2
* Revert "Another debug changes 2"
This reverts commit cfad55141eec125b2f1d35fb95d9f46b54f666b6.
* Revert "Fix another debug changes"
This reverts commit 9bc2c74a3be6fd896827ff48cf4580e7657529c0.
* Revert "Another debug changes"
This reverts commit 4337ed8cad8dff508d093944eb3f75e9a69e4a77.
* Edit class FrequencySensor, make it more RAII
* Debug changes
* Debug changes 2
* Debug changes 3
* Revert "Debug changes 3"
This reverts commit 52a7054c122b5157540fe45a055a84b57478d722.
* Revert "Debug changes 2"
This reverts commit dec79fb913344ccb4b8614910ad62e6c129a243e.
* Revert "Debug changes"
This reverts commit eb08d7a529b55ba397a7dd2c154b76eab42f212b.
* Revert "Edit class FrequencySensor, make it more RAII"
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Citroen Berlingo" engine config.
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Dodge Neon" engine config
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-24 00:55:41 -04:00
2ad4a9df1e
actually remove FSIO idle stuff ( #3150 )
...
* debug mode
* pid cleanup
* more dead
* more dead
* wow more dead
* much dead many death wow
2021-08-14 09:48:45 +03:00
86e4664b2d
dead idle FSIO
2021-08-12 18:28:55 -04:00
7ebebd6922
Begin "vehicleSpeed" refactoring. Module switched to "FunctionalPointerSensor" class. #3106 #3107 #3108 . ( #3132 )
...
* Add new sensor type "VehicleSpeed"
* Add "Vehicle speed" sensor to name list
* Add Vehicle speed sensor initialization with function pointer sensor.
* Add init_vehicle_speed_sensor.cpp to Makefile
* Replace dependencies from "getVehicleSpeed" to OOP-like "Sensor::get()"
* Add warning and TODO to "mock vehicle speed" call
* Replace get & mock "VehicleSpeed" methods in tests
* Remove #warning directive (cause error by current settings)
* Remove stray tab
* Remove explicitly type casting.
* Add "InitVehicleSpeedSensor" function declaration to init.h
* Add "VehicleSpeedSensor" initialization call into "InitNewSensors"
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-12 22:16:51 +03:00
90a0e47b04
skip etb init if no primary sensor ( #3136 )
...
* skip init if no primary sensor
* specific test
2021-08-12 00:45:44 +03:00
0df437e749
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 07:04:18 -04:00
d24f1462e2
even more pch ( #3112 )
...
* s
* more
* s
* f7
2021-08-04 19:30:52 -04:00
5ff7235040
don't "validate instant RPM" ( #3095 )
...
* don't "validate instant RPM"
* test actually tests the right thing
* test mode transition
2021-08-04 08:17:14 +03:00
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
75f27c6cbc
unit test for vehicle_speed.cpp fix #3081
2021-08-03 19:54:11 -04:00
6d12533120
Unit tests for vehicle speed.cpp #3081 ( #3103 )
...
* Add test_vehicle_speed.cpp
* Add test_vehicle_speed.cpp to makefile
* Add tests for vehicle_speed.cpp
* Enable vehicle_speed.cpp testing
* Edit make some constants explicit and format code style
* Revert "Enable vehicle_speed.cpp testing"
This reverts commit bcba5219a1d69fb3375e33c7fcb97abffc190a75.
* Remove verbose variables
* Remove dead code strings
* Fix tests coupling by setMockVehicleSpeed
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-03 19:49:16 -04:00
8fe2d99254
unit test for vehicle_speed.cpp #3081
2021-08-03 19:48:24 -04:00
a8eddbccf6
perform extra-step-prevention in the stepper driver itself ( #3038 )
...
* perform extra-step-prevention in the stepper driver itself
* isBusy flag
* I am unable to type
* the court of public opinion has decided that greater-equal is correct
* that sets target in steps, not percent
* correct var name
* mock stepper motor
* testable stepper
* build is happy
* helping build
2021-08-02 07:03:57 -04:00
f16173b4dd
call handleShaftSignal ( #3097 )
2021-08-02 07:02:45 -04:00
fcd6c3d520
fix the mess ( #3094 )
...
* test
* s
2021-08-01 23:21:53 -04:00
6f96887d74
Unit test for flex sensor.cpp #3091 ( #3093 )
...
* Add test_flex_sensor.cpp
* Add test_flex_sensor.cpp to makefile
* Edit test_flex_sensor.cpp code formatting
* Fix test case name in test_flex_sensor.cpp
* Remove explicitly defined constructor of "FlexSensorForTests" class
* Edit included headers replaced by single one in test_flex_sensor.cpp
* Edit format to make similar to other files.
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-01 22:14:01 -04:00
4aaee01a26
remove some noise from nb2 trigger log ( #3078 )
2021-07-30 08:19:16 -04:00
0d983855b9
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
bd599ab374
cleanup for pch ( #3062 )
...
* cleanup
* d
2021-07-25 20:43:02 -04:00
f6095b8339
fix nonlinear correction threshold ( #3060 )
...
* s
* macro
* test has to do the inverse
2021-07-25 20:42:26 -04:00
2495713af6
Clutch switch inverted options do not invert detected pedal position
...
#3545
2021-07-24 19:49:23 -04:00
617c2886d9
adjust taper behavior ( #3051 )
...
* adjust taper behavior
* check that taper works in running state too
2021-07-24 16:12:07 -04:00
23842bf143
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
6fc693aea2
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
7db8bc816e
Nissan VVT trigger decoder #2887
2021-07-21 23:26:40 -04:00
783fd70cce
Nissan VVT trigger decoder #2887
2021-07-21 23:24:23 -04:00
24cfbeba35
Nissan VVT trigger decoder #2887
2021-07-21 23:08:56 -04:00
07d32a9e80
Nissan VVT trigger decoder #2887
2021-07-21 22:41:37 -04:00
dba7a333f8
nissan logic cranking
2021-07-21 21:58:00 -04:00
d520d12490
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
4b95262a5d
simplify quad vvt test ( #3018 )
...
* use single tooth in quad cam test
* mod == remainder
* now the test works without changes
2021-07-21 18:48:05 -04:00
b9f141256a
test existing implementation ( #3017 )
2021-07-21 17:48:37 -04:00
0f0b84a6db
remove TS file read ( #3004 )
...
* remove
* more defines
* test
* lots of java
* s
2021-07-21 14:24:53 -04:00
5f3464b204
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
b161a26956
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 19:43:17 -04:00
9345e5d2e0
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
0d8fd6f271
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
a62d6743bc
lua hooks for CAN tx ( #2967 )
...
* CanTxMessage usable from unit test
* testLuaReturnsNil
* CAN hook and tests
* it helps if parameter names exist
* nameless params
* s
* redefinition of default argument
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 14:06:26 -04:00
03bb3e3ace
trigger signal debug pins - logic level output #2959
...
test driven development is still amazing
2021-07-15 09:29:14 -04:00
7486f5f040
trigger signal debug pins - logic level output #2959
2021-07-15 00:34:22 -04:00
e721c1768f
trigger signal debug pins - logic level output #2959
2021-07-14 22:51:08 -04:00
27350dbad8
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:47:55 -04:00
e1c41ff798
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:03:00 -04:00
4750aa2efa
cute example of a bug which only macoc unit test fails to compile
2021-07-13 18:15:22 -04:00
e1b6b405eb
NB2 hellen-72-rev-d something is off #2958
2021-07-13 15:04:30 -04:00
7fd2e8275f
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:39:21 -04:00
174e12b281
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:24:47 -04:00
1a72390d37
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 14:07:55 -04:00
acc4882f06
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 13:27:47 -04:00
774bcaa5ef
it's spelled 'resources' :(
2021-07-13 12:36:50 -04:00
f33862f537
it's spelled 'resources' :(
2021-07-13 12:35:43 -04:00
b3c076dae7
NB2 hellen-72-rev-d something is off #2958
2021-07-13 11:57:18 -04:00
aef0732509
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
86683afca2
trailing spark scheduling ( #2932 )
...
* enable bit
* implement trailing sparks
* test trailing spark
* it helps to call the correct function
* add pins
* gobblin ram
2021-07-09 08:37:46 -04:00
9dfc066bce
restore testQuadCam #2911
2021-07-08 00:11:54 -04:00
0aa8693f21
Matt has CUSTOM_ERR_VVT_OUT_OF_RANGE warning #2921
2021-07-07 23:55:49 -04:00
d10ba3ddfa
injector nonlinearity ( #2916 )
...
* nonlinear polynomial
* make existing tests work again
* test that nonlinearity is called
* s
* fix enum
* ui
* fix and test
* comment
* changeloggy
2021-07-07 23:46:44 -04:00
5e08907590
knock sensing peak detect ( #2910 )
...
* knock peak detect
* comments
* comment
* initialize
* test
* fix warnings while we're here
* those are functions, not values
* ram
2021-07-06 21:44:59 -04:00
5bd3ae3aaa
Disable closed loop idle during cranking->running taper ( #2900 )
...
* implement
* dead file?
* implement tests
* new phase
2021-07-06 08:47:06 -04:00
70424ac7b5
Nissan VVT trigger decoder #2887
...
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
2e9e5c2745
Nissan VVT trigger decoder #2887
...
that looks like one bug
2021-07-05 22:50:44 -04:00
1b174bd4b3
Nissan VVT trigger decoder #2887
...
that's all very strange
2021-07-05 22:17:26 -04:00
064c1612e3
restore testQuadCam #2911
2021-07-05 21:04:09 -04:00
7cd5ea855c
restore testQuadCam #2911
2021-07-05 20:56:24 -04:00
3574de1da3
shard unit tests ( #2906 )
...
* scripts
* it found problems!
* off by one
* call bash maybe?
2021-07-04 22:28:31 -04:00
992570f322
explicitly set mock vss to test ( #2905 )
2021-07-04 17:52:45 -04:00
007a390f2b
Gate closed loop idle on road speed ( #2901 )
...
* implement
* test
* b
* config
2021-07-04 09:35:12 -04:00
b67b1f424f
Nissan VVT trigger decoder fix #2887
...
TDD is amazing we are done here!
2021-07-03 12:43:01 -04:00
0cf095a943
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
23e7022e55
Nissan VVT trigger decoder #2887
2021-07-03 11:08:22 -04:00
f5e937fe2b
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
152eea43b1
Nissan VVT trigger decoder #2887
2021-07-03 10:15:41 -04:00
0d5098e0a9
Nissan VVT trigger decoder #2887
2021-07-03 09:43:54 -04:00
e5a1b68eb2
Nissan VVT trigger decoder #2887
2021-07-02 20:28:15 -04:00
1660a5b3fd
Nissan progress
2021-07-02 19:57:26 -04:00
e7d7d79f13
Nissan progress
2021-07-02 19:23:52 -04:00
0d7c0a7f50
Nissan progress
2021-07-02 18:33:32 -04:00
d18d4496d1
Nissan progress
2021-07-02 17:32:45 -04:00
bd5ff4b5a5
Nissan progress
2021-07-02 16:31:10 -04:00
a9e7166f74
Nissan progress
2021-07-02 14:56:12 -04:00
025c32de00
Stricter miata sync ( #2891 )
...
* strict mazda trigger shape
* this is an even better gap
* sync point moved so things are different now
* fix
* update instantrpm in test
* s
* s
* this is safer
* test
* tests
* instant rpm
* cleanup
2021-07-01 21:29:04 -04:00
8569f028d6
Fix pre sync timestamp copy ( #2892 )
...
* fix tests
* fix pre sync copy
* this fixes the issue
2021-07-01 18:58:28 -04:00
2a85bfc73f
test multiple starts ( #2888 )
...
* test
* pi
* typo
* private
* test short gap too
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 17:29:31 -04:00
1bca4843fe
test dc_motor.cpp ( #2890 )
...
* use ipwm where possible
* mock ipwm
* initialize
* test
2021-07-01 09:21:18 -04:00
35ad1b7d89
fix instant rpm ( #2886 )
...
* fix instant rpm
* this is what it should look like!
* warning
* comment issue link
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 09:19:16 -04:00
c171d5f1d3
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
942f23a6b3
aggressively test rpm calculator ( #2884 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 00:05:24 -04:00
32f5ce6fb4
no fan if stopped engine ( #2822 )
...
* no fan if stopped engine
* config
* use config
* more tests
* merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 08:52:54 -04:00
cd5eb6a77c
Move AC logic out of FSIO ( #2872 )
...
* new impl
* remove fsio
* inject "is ac active" to fan
* include the correct code
* include
* test
* more AC features
* AC switch vs. actual AC indicators
* include
* duh
2021-06-27 18:51:34 -04:00
fcc97fb9a6
VW warnings on cranking #2861
2021-06-27 13:01:56 -04:00
f6b003820c
more minimal version of fix trigger replay #2874
2021-06-27 11:38:42 -04:00
8696ea4890
crankDivider is asking for a new unit test
2021-06-27 00:51:14 -04:00
7c7766efcc
VW warnings on cranking #2861
2021-06-26 16:05:43 -04:00
c6d0d88465
VW warnings on cranking #2861
2021-06-26 01:37:55 -04:00
8a2564aaef
VW warnings on cranking #2861
2021-06-26 01:31:50 -04:00
6dbc40e990
VW warnings on cranking #2861
2021-06-26 00:51:09 -04:00
78dd28467d
progress
2021-06-26 00:33:28 -04:00
6a00036983
VW warnings on cranking #2861
2021-06-25 22:24:41 -04:00
0af5de0934
Minor change of Miata NA trigger shape #2855 #669 ( #2856 )
...
* Minor change of Miata NA trigger shape #2855 #669
* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
942eb46471
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
dbea1e23a0
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:02:37 -04:00
f04cb1ceac
Trigger: warning code on normal engine start up #669
2021-06-25 01:43:15 -04:00
71fdfe6756
giving unit tests a chance to use tdcMarkCallback
2021-06-25 01:31:53 -04:00
76840d07db
better test coverage
2021-06-24 23:38:16 -04:00
a39920b68e
refactoring - better entity names
2021-06-24 23:19:31 -04:00
8d17e0576c
docs
2021-06-24 23:12:16 -04:00
175eea0a96
raw files #669
2021-06-24 22:39:00 -04:00
3092164e48
Minor change of Miata NA trigger shape #2855 #669
2021-06-24 22:21:30 -04:00
461132d993
Trigger: warning code on normal engine start up #669
2021-06-24 21:58:40 -04:00
7eb3b9890d
misc threading/safety improvements ( #2854 )
...
* allow termination of thread controller
* no gpio if fatal
* stub for test
2021-06-24 20:18:23 -04:00
6ca965d246
Trigger: warning code on normal engine start up #669
2021-06-23 11:32:06 -04:00
1c48a61339
refactoring
2021-06-23 06:37:32 -04:00
a57d7c48fb
global static not good, there shall be only one god object /s
2021-06-23 06:10:27 -04:00
74c5a80cac
Trigger: warning code on normal engine start up #669
2021-06-23 05:22:08 -04:00
a222a3961a
one can dream about a well defined framework
2021-06-19 09:56:08 -04:00
2c66d74c7e
Trigger: warning code on normal engine start up #669
2021-06-18 22:52:01 -04:00
3a30f038ce
kill engine if no oil pressure ( #2800 )
...
* min oil pressure for crank
* do it time-based
* rename field
* include
* fix existing test
* tests
* fix logic
* more test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-16 17:20:28 -04:00
93adb8ea76
Etb rev limit ( #2820 )
...
* cfg
* impl
* a test
* don't break the ts channel
* text
2021-06-16 08:44:48 -04:00
a4973a6f3d
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
7d2057e74a
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
15d172ab08
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
c27549b2e8
hard coded fan logic ( #2805 )
...
* remove fsio
* hard code impl
* test it
* enable fan with AC
* make commented stuff match
2021-06-11 06:25:12 -04:00
a54a5e7f90
convert gpiochips to c++ ( #2761 )
...
* core
* basic header
* tests are happy
* tle6240
* tle8888
* 33972
* 33810
* tle8888_req_init
* unused warning
* warning
* unsigned
* 8888 debug
* fix
* don't qualify
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-10 04:11:01 -04:00
ab214f974c
Bandaid for 2735 ( #2788 )
...
* bandaid
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-02 12:02:52 +03:00
790ac08a2e
Cranking defaults ( #2787 )
...
* defaults
* more
* cranking fuel
* cranking timing
* cranking time digits
* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
f3c5ff6d54
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
39e4f70405
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
7d773bfb1d
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
a50f8e0077
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
33d296d4c7
my status
2021-05-31 05:27:51 -04:00
ec8e1eee69
require redundant pedal ( #2758 )
...
* require redundant pedal
* return false
* I don't typing good
* tests
* tests
2021-05-30 19:19:57 -04:00
c89a60845b
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 05:22:13 -04:00
0ad11168e8
Override trigger gaps feature #2734
2021-05-25 17:19:20 -04:00
a36b655e67
Trigger: warning code on normal engine start up #669
2021-05-24 06:03:58 -04:00
192fc18817
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:59:08 -04:00
7dd0565faa
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-21 11:07:59 -04:00
de7879b6e4
convert a table to scaled_channel ( #2724 )
...
* scaled VE table
* use setTable
* efi::clear
* ratio -> struct
2021-05-20 20:00:32 -04:00
dfd0d3229f
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-14 10:58:53 -04:00
1d10fbc7a8
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
9b0c7ff693
explicitly test PTC thermistors ( #2681 )
...
* test ptc
* allow hotter for air cooled people
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-10 18:15:09 -04:00
4474f9f1c2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
9032730700
Break out unit tests #2627
2021-05-07 22:14:22 -04:00
c4add59219
Break out unit tests #2627
2021-05-07 17:45:26 -04:00
8b30776016
remove stateChangeCallback from simplepwm ( #2644 )
...
* remove callback parameter from cj125
* remove from ext
* remove stateChangeCallback
* alt doesn't need that
* demorgan
* remove call
* bad cut/paste
* check the actual pin in the test
2021-05-07 09:38:41 -04:00
a25773a11b
more Lua hooks ( #2605 )
...
* more hooks
* zero index
* test table hook
* test works
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-29 22:22:04 -04:00
830575a306
lua 5.4 ( #2590 )
...
* thread priority
* build
* makefile prep
* call startup
* lua 5.1
* mk
* 5.3
* mk
* I guess lua does something?
* extract hooks, builds for tests
* a bit of error handling
* guard
* bootloader makefile
* remove lua
* submodule
* submodule update
* builds with submodule
* disabled by default
* h7 chconf
* tweaks
* add a useful hook
* move luaconf
* perf trace lua
* test helpers
* lua unit tests
* include to satiate clang
2021-04-28 22:41:25 -04:00
c26987b96b
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
bd1c84fa62
Logging remove 3 ( #2568 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
* vvt
* more
* idle
* missed one
* dynoview
* launch
* can
* console IO
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
5145ee4b62
logging cleanup 2: sensors, pid, etb, etc ( #2567 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 20:02:32 -04:00
6b64db7f9c
rewrite text logging system ( #2439 )
...
* minor cleanup
* enable mailboxes
* priority
* implement new logger
* more cleaning
* signature
* remove debug
* put the assertion back in
* remove debugging
* spelling
* doy
* tweaks & comments
* cleaning
* size_t
* guard more
* test build now
* needs more ram until we can remove LogginWithSTorage
* hunt for memory
* bootloader
* unused
* stub simulator
* it would help to get the signature right
* geez kinetis only has 64k ram
* more guarding because kinetis
* that's now very legal and very cool
* templatify
* s
* force null terminate
* probably fix
* const
* write a test
* disable sensor chart for now
* hide SC ui
* oh nope that breaks many things
This reverts commit c3c1bb324fb484c3d9cc44b7715c234bc0392e1e.
* missed one
* reset after scheduleLogging
* we can't print out the full message because it contains commas which break parsing
* force terminate long buffers
* let's see how much memory we have to play with
* a lot, is the answer
* real thread name
* shrink this for now before its deleted
* turn that back on
* biiig comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 18:46:47 -04:00
2b6345070f
WOW major scheduling drama on NB2 running with Proteus #2533
2021-04-15 19:12:09 -04:00
b49c5200b7
helping us trace CUSTOM_FSIO_STACK_SIZE
2021-04-08 15:15:12 -04:00
462e24354d
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 15:01:12 -04:00
e02f09495b
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
46e38447e5
Ford redundant ETB tps ( #2519 )
...
* ford tps
* configurable maximum
* initialization
* check consistency when in the low range
* print info
* default
* config field
* config parameter
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-05 15:57:03 -04:00
9753b6e020
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
f877d32be4
engine sniffer into unit tests
2021-04-04 22:48:48 -04:00
3d138958ce
Hip9011 ( #2512 )
...
* hip9011: coexistance with other spi devices
* hip9011: rework so SPI transfer is invoked from thread
also use polling spi exchange to avoid cache problems
* hip9011: move calculations from ADC callback to thread
* hip9011: big cleanup
* hip9011: simplify spi communication
* No need to set knockBandCustom if it is not custom
HIP9011 calculates knockBand from cylinderBore same way
* hip9011: make unit test happy
* hip9011: fix unit test
* hip9011: remove duplicated initialization, reorder
* hip9011: just renames and data type adjustments
* hip9011: rename BAND() to HIP9011_BAND()
* hip9011: move some code from lookup.cpp to logic.cpp
* hip9011: move initEngineNoiseTable to engine_configuration.cpp
* hip9011: move lookup tables to hip9011_logic.c
* hip9011: remove empty files
* hip9011: additional checks
2021-03-30 10:56:25 -04:00
f0cf4f38ff
fix multi-serial-port insanity ( #2476 )
...
* carve out UART specific
* implement channel
* config cleanup
* use new config
* bootloader
* dead code
* s
* h7 inherits f7
* oops
* ok now it's right
* tests
* cleanup
* call setup
* put that in its own file
* cleanup
* format
* guard
* not needed
* improve guarding
* portable
* allow override of uart mode
* fixes for bootloader
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
8b3aa6c40d
goodbye ignitionOffset ( #2503 )
...
* remove
* set the timing map to do what the offset used to do
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
4e3e95db2d
replace print/printMsg with scheduleMsg ( #2497 )
...
* start cleaning
* disabled feature means don't print that it's disabled
* cli
* usages
* printMsg -> scheduleMsg
* this is alllll dead now
* no crlf please
* all hope is lost if you manage to hit this line
* tests
* tests
* ok we did actually need that part
* sim
* d
* kinetis
* it did ifdef, not if
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
1c473934b9
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
95b08c433f
Implement nonlinear fuel level sender ( #2473 )
...
* table function
* config fields
* sensor type
* switch consumers
* init the sensor
* ui
* 1mv resolution
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-19 08:39:08 -04:00
1dd2180f76
VVT uses closed loop controller framework ( #2453 )
...
* vvt uses framework
* builds
* rename, update headers
* s
* testable
* write some basic tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-14 19:31:46 -04:00
2328c1be6b
Fuel pressure sensor checks ( #2449 )
...
* test for missing sensor
* test negative pressure delta checking logic
* test new hasSensor logic
2021-03-12 23:32:41 -05:00
490d3a6957
test_timer
2021-03-12 00:43:48 -05:00
16b8fb64ca
vBatt -> SensorType::vBatt fix #2260
2021-03-11 23:07:18 -05:00
053835a1c0
error accumulator ( #2434 )
...
* error accumulator
* makefile
2021-03-08 07:40:46 -05:00
5067b81fce
Compute injection duration later in the pipeline ( #2175 )
...
* injector model, test
* new math
* inject fuel based on new math
* tests
* fix
* it should work like this
* format
* update TPS AE even when we're cutting fuel
* comment
* conversion factor
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-03 07:30:56 -05:00
fbcff6f0c8
hip9011 compilation fix, cosmetic clean-ups ( #2414 )
...
* Board subaru eg33: has HIP9011 knock sensor
* hip9011: lastExecutionCount does not exist any more
* hip9011: extranc commands to header, use logic math for bitfields
2021-02-28 15:42:57 -05:00
b6de500059
cleanup ( #2386 )
2021-02-23 16:57:14 -05:00
a50d1d5ee3
start making tunerstudio more sane: part 2 ( #2381 )
...
* ts cleanup part 1
* move more stuff in to the class
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
102804db7d
rework FSIO LEelement ( #2374 )
...
* save
* firmware
* test parsing multiple things
* split tests
2021-02-17 23:32:44 -05:00
39884f8934
use DECLARE_ENGINE_PTR for Engine class ( #2365 )
...
* engine cleanup
* do the cleanup
* one last spot
* expand_engine noop for firmware
* simulator
2021-02-16 16:58:54 -05:00
bcc6c63046
second bank vvt decoder unit test
2021-02-09 10:16:49 -05:00
bc0fc267d8
M62T vanos support #2243
2021-02-08 22:41:31 -05:00
2d99e77c95
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
f68ede76bf
M62T vanos support #2243
2021-02-08 21:07:43 -05:00
6793b5d8fc
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
6b10de5616
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
c576f0a9d9
M62T vanos support #2243
2021-02-08 18:08:26 -05:00
a349bf1ca8
M62T vanos support #2243
2021-02-08 16:16:26 -05:00
a86481f3ba
refactoring: more structure
2021-02-08 15:59:40 -05:00
953990d10b
Trigger pattern request Škoda Favorit fix #2302
2021-02-06 20:53:30 -05:00
5ceeac93e9
put vbatt in sensor model ( #2261 )
...
* vbatt in sensor model
* sensor name
* vbatt
* s
* oy vei
* a little bit of cleanup
* memory apparently
* cj125 test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 07:55:40 -06:00
869e4cfc49
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
10e980e293
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
c7ca1b2ef4
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
748bc5275b
weird
2021-01-10 20:29:20 -05:00
571122d461
Start support for multi-bank closed loop fueling ( #2184 )
...
* cfg
* cell
* N banks
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-10 08:10:49 -05:00
7a90692187
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
f96ae7525f
Gpio cleanup #2 ( #1530 )
...
* pin repository: PIN_USED size in now equal to brain_pin_e enum size
expect special values...
* smart gpios: register gpio chip to given base (no auto-allocation)
* drivers: gpio: core: add gpiochip_unregister()
* drivers: gpio: MC33810 intergation
* smart_gpio.cpp: cleanup ifdef mess, minor cleanups
* gpio: core: additional check for gpio ranges overlaps
* unit test: gpio chip: fixed and extended
2021-01-06 18:29:47 -05:00
f4dcf0f397
generate triggers.txt from parametric test ( #2186 )
...
* add new test
* comment
* remove old
* main cleanup
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
eabb5c7366
flex fuel AFR interpolation ( #2190 )
...
* config
* implement flex
* secondary fuel default
* test
* test works
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
92ea09b0a6
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
46583b2a19
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit 9634a803
2020-12-31 12:22:54 -05:00
acdf6fdc85
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
9634a803f1
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
ba2c675ffa
progress to fsio type safety ( #2137 )
...
* rename
* packed type safe fsio value
* comment
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-27 17:22:11 -05:00
64d9b4b71a
limp manager can disable etb ( #2143 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* limp can disable etb
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 21:47:27 -05:00
b9e96322c5
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
ff4ce2fb1f
create limp manager ( #2142 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00
542cb6a420
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
17554539d1
rename ( #2136 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-25 08:40:54 -05:00
3727233e11
fix tach test 2130 ( #2134 )
...
* fix
* comment
2020-12-24 21:20:24 -05:00
7e201990d3
Restore testPulsePerRev #2130
2020-12-24 08:17:43 -05:00
3d13d03424
Purge e34 config ( #2127 )
...
* remove
* enums
* s
* func test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
8737ba62c2
Purge rover v8 config ( #2116 )
...
* bye
* goodbye, rover v8
* that snuck in
* use a different config for that test
2020-12-22 10:05:54 -05:00
690ab7e917
gpio unit tests ( #2099 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* move gpio mocking
* test gpios
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
* test deinit
2020-12-18 17:19:02 -05:00
55b4e82615
naming consistency
2020-12-18 09:01:18 -05:00
aeea50ada2
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
378d118118
test ( #2071 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-12 23:40:05 -05:00
f2426677db
start fuel pump as soon as trigger events happen ( #2038 )
...
* switch pump fsio logic
* value collision
* fuel pump in tests
* mock time since trigger
* test fp
* init pin in test
* fix gpio outputs in tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-10 01:23:24 -05:00
a08e79789d
second lambda (x-series CAN only, for now) ( #2048 )
...
* add sensor
* second sensor
* switch sensor name
* gobblin up your memory
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 20:26:23 -05:00
bad0e6b949
require redundant TPS for ETB ( #2041 )
...
* Require redundant tps for ETB (#2037 )
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
* add a test that fails but should not
* fix the bug
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 06:24:20 -05:00
5bae56a32a
not this line yet?
2020-12-07 01:40:26 -05:00
rusefillc
Matthew Kennedy
Andrey
Andreika
rusefillc
alxrMironov
Andrey G
rusefi