Commit Graph

12283 Commits

Author SHA1 Message Date
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
rusefillc b579b33082 Startup Pin State Error - maybe hardware damage of STM32 pin connected to a 12v-powered TC4427? #3558 2021-11-17 04:45:55 -05:00
rusefillc d688f72c3e proportional spark cut #3427 2021-11-17 04:06:22 -05:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 70ad9724c0
Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Scott Smith 8dbdeb7773
Remove a bunch of macros from engine_ptr.h (#3562) 2021-11-17 10:01:39 +03:00
GitHub set-date Action 5b1f6dd4b1 Update date 2021-11-17 01:00:29 +00:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc 17d4646dce spelling 2021-11-16 16:46:54 -05:00
rusefillc dad00adc28 helping launch enter simulator 2021-11-16 16:45:14 -05:00
rusefillc 678a756275 helping launch enter simulator 2021-11-16 16:31:35 -05:00
Andrey a61043e570 proportional spark cut #3427 2021-11-16 13:23:08 -05:00
Andrey 3748bf5ad0 proportional spark cut #3427 2021-11-16 05:56:15 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith 344c9073e2
Start the process of using a global engine ptr for unit tests. (#3551)
* Start the process of using a global engine ptr for unit tests.

Passing around the engine, config, and persistent state wasn't buying anything.  Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables.  Add a dummy check in
case some test tries to set them manually.

* Fix OSX build

* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Scott Smith 62daac73c7
Use Valgrind to detect unitialized variable references. (#3555)
* Use Valgrind to detect unitialized variable references.

Fix the edge cases that pop up

* Comment and disable Mac run
2021-11-15 23:42:23 -05:00
GitHub build-firmware Action 4ed25bff52 Auto-generated configs and docs 2021-11-16 02:53:15 +00:00
Andrey d48cab2136 Knock retard #3396 2021-11-15 21:21:45 -05:00
Andrey 0cc88ec6e2 Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 3b0825181c technical debt: enableOverdwellProtection #3553
only documentation
2021-11-15 20:32:25 -05:00
Andrey 655b77dc3f random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Andrey 928c673695 refactoring launch 2021-11-15 20:09:03 -05:00
Andrey 05fa6071dd refactoring launch 2021-11-15 19:55:04 -05:00
Andrey 0d5df34f36 refactoring launch 2021-11-15 19:55:04 -05:00
Andrey c18204325c refactoring launch 2021-11-15 19:34:42 -05:00
Andrey f510cb8b29 refactoring launch 2021-11-15 19:24:00 -05:00
Andrey 4002c92dcc refactoring launch 2021-11-15 18:57:12 -05:00
Andrey 34015eceee refactoring launch 2021-11-15 14:40:35 -05:00
Matthew Kennedy cb032fb1ea
(void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
GitHub build-firmware Action adbb32e9b6 Auto-generated configs and docs 2021-11-15 03:03:29 +00:00
rusefillc 6f3eea31c6 MAP phase sensing #3544 2021-11-14 21:58:01 -05:00
GitHub build-firmware Action f3f9cb3f6c Auto-generated configs and docs 2021-11-15 02:31:36 +00:00
rusefillc 0722d6280d MAP phase sensing #3544 2021-11-14 21:24:59 -05:00
GitHub set-date Action e07987a601 Update date 2021-11-15 01:00:10 +00:00
rusefillc 1471193da9 clarification 2021-11-14 18:36:59 -05:00
GitHub build-firmware Action e776e2b3fb Auto-generated configs and docs 2021-11-14 23:09:53 +00:00
rusefillc a99750a34a Epic: Remove FSIO #2928 2021-11-14 17:56:58 -05:00
rusefi d348ba07ef ## November 2021 Release - "Loosen Up Lighten Up Day" 2021-11-14 17:47:07 -05:00
rusefi c8d666c5a1 Lua: changing "table" API 2021-11-14 16:29:46 -05:00
Matthew Kennedy 36d75fa6db
enable nb1 serial pins (#3546)
* enable serial on nb1

* typo

* serial

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 16:07:56 -05:00
rusefi 377c9e2fda Something something Automatic Compression Release #3442 2021-11-14 16:04:44 -05:00
rusefillc 0813266ee1 trigger refactoring & docs 2021-11-14 15:35:11 -05:00
Matthew Kennedy a7ba539e70
math is fun (#3545)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
rusefi e8aebc313a Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
rusefi fcf0d68849 more API 2021-11-14 14:53:44 -05:00
rusefi cdeeb6f966 Epic: Remove FSIO #2928 2021-11-14 14:44:52 -05:00
GitHub build-firmware Action 1806c9876b Auto-generated configs and docs 2021-11-14 19:42:17 +00:00
rusefi ee4caf8288 bugfix: show both new and legacy field names were displayed 2021-11-14 14:19:09 -05:00
rusefi 89ab20c35c Epic: Remove FSIO #2928 2021-11-14 14:14:43 -05:00
rusefillc 14c0711011 script settings need names! 2021-11-14 13:18:11 -05:00
GitHub build-firmware Action d69b742bce Auto-generated configs and docs 2021-11-14 17:42:11 +00:00
rusefillc a7027975a5 Epic: Remove FSIO #2928 2021-11-14 12:15:53 -05:00
rusefillc f00f5c95be Epic: Remove FSIO #2928 2021-11-14 12:11:56 -05:00
GitHub build-firmware Action 391218b562 Auto-generated configs and docs 2021-11-14 16:51:07 +00:00
rusefillc e01aa6139b script settings need names! 2021-11-14 11:45:37 -05:00
rusefillc f279f3275d script settings need names! 2021-11-14 11:40:33 -05:00
rusefillc 074e85b523 Epic: Remove FSIO #2928 2021-11-14 11:40:19 -05:00
rusefillc 68ebb8045d Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 22c872d8d8 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
GitHub build-firmware Action 402f2a3f93 Auto-generated configs and docs 2021-11-14 15:53:06 +00:00
rusefillc 297f01444d Epic: Remove FSIO #2928 2021-11-14 10:47:40 -05:00
rusefillc c22215cea7 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
GitHub build-firmware Action aa3fc55c8e Auto-generated configs and docs 2021-11-14 15:07:50 +00:00
rusefi 800bbf38ad Lua progress 2021-11-14 10:02:28 -05:00
rusefi 0ea0d601a5 Epic: Remove FSIO #2928 2021-11-14 09:49:02 -05:00
GitHub build-firmware Action 98a4aa86d3 Auto-generated configs and docs 2021-11-14 14:40:23 +00:00
rusefillc 9ce65aa6cb Epic: Remove FSIO #2928 2021-11-14 09:34:45 -05:00
rusefillc f755bff2a1 Epic: Remove FSIO #2928 2021-11-14 09:34:19 -05:00
GitHub build-firmware Action 0a9674aa94 Auto-generated configs and docs 2021-11-14 14:27:16 +00:00
rusefillc 60841f4486 Epic: Remove FSIO #2928 2021-11-14 09:21:04 -05:00
rusefillc f0b1971908 Epic: Remove FSIO #2928 2021-11-14 08:38:11 -05:00
rusefillc eb1af46655 Epic: Remove FSIO #2928 2021-11-14 08:37:50 -05:00
rusefillc 991d0c5001 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
GitHub build-firmware Action d299cc9c9b Auto-generated configs and docs 2021-11-14 13:13:06 +00:00
rusefillc 287d765a62 Epic: Remove FSIO #2928 2021-11-14 08:00:58 -05:00
rusefillc a85d1bb064 Epic: Remove FSIO #2928 2021-11-14 07:30:26 -05:00
rusefillc 0a9682c553 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc 6210eaacf7 script settings need names! 2021-11-13 23:10:38 -05:00
rusefillc 1e8d8f9691 script settings need names! 2021-11-13 22:59:15 -05:00
GitHub build-firmware Action 13d19653e9 Auto-generated configs and docs 2021-11-14 03:54:30 +00:00
rusefillc a9bcce88d0 script settings need names! 2021-11-13 22:47:46 -05:00
GitHub build-firmware Action b295511600 Auto-generated configs and docs 2021-11-14 03:02:10 +00:00
Matthew Kennedy d591a5ad26
mercedes two lobe trigger testing (#3543)
* mercedes

* config

* break;

* I did the gap ratio math wrong

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
GitHub set-date Action 19a119e5fc Update date 2021-11-14 01:02:27 +00:00
rusefi 5e346e40a3 pid demo progress 2021-11-13 16:41:20 -05:00
rusefi 05820ec92d speed into caninfo 2021-11-13 10:41:23 -05:00
GitHub build-firmware Action e32673dfb6 Auto-generated configs and docs 2021-11-13 15:38:11 +00:00
rusefi b7dc5a4ac5 pid demo progress 2021-11-13 10:33:13 -05:00
rusefi 2b8b549edd cmd_test_debug_mode_can 2021-11-13 10:33:03 -05:00
rusefi 844a8418a8 pid demo progress 2021-11-13 10:02:45 -05:00
rusefi 676f2dfb93 findTableIndex 2021-11-13 10:02:01 -05:00
rusefillc 6be84c0de9 lua can 2021-11-13 08:23:44 -05:00
rusefillc 8fdf2521e5 lua can 2021-11-13 08:20:30 -05:00
rusefillc e662544919 lua can 2021-11-13 04:44:17 -05:00
GitHub build-firmware Action 8d7157ff3e Auto-generated configs and docs 2021-11-13 09:41:01 +00:00
rusefillc 23ecae0316 little mess 2021-11-13 04:35:45 -05:00
rusefillc 8333234737 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
rusefillc 23612b5873 UART pins validation and dynamic alternative function recognition #3536 2021-11-13 04:13:11 -05:00
Matthew Kennedy 73b05d2e20
lua pid class (#3411)
* lua pid

* no luaaa stl

* update luaaa

* finality

* luaaa

* luaaa

* = default

* bad merge

* gitmodules

* lua

* proteus demo script

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 03:18:16 -05:00