Commit Graph

1073 Commits

Author SHA1 Message Date
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc d13a851c97 triggerImage: todo: support symmetrical crank 2022-10-16 10:33:38 -04:00
rusefillc 5fb9f7c2df triggerImage: todo: support symmetrical crank 2022-10-16 02:59:57 -04:00
rusefillc d91211106c triggerImage: todo: support symmetrical crank 2022-10-16 02:44:57 -04:00
Matthew Kennedy aa881efe89
fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy d6647025cc
2jz test (#4638) 2022-10-05 20:48:28 -04:00
Andrey 83afa58baf Mark is asking for VIN number field #3967 2022-10-04 21:12:51 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy ec5d48fb5b
remove 898 (#4634)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy b089825a4a
schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy ae6c44634b
better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy b45f84fe20
#4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey 612d52645a Honda K cam wheels #3405 2022-09-25 00:26:42 -04:00
Andrey 9d27780974 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 111220d38c more inclusive configuration name 2022-09-24 23:49:41 -04:00
Andrey cff779dd78 K progress 2022-09-24 23:18:57 -04:00
Andrey a38d87b0e0 fancy default and reusing constant 2022-09-24 23:01:42 -04:00
Andrey 93e64a61a6 fancy 2022-09-24 22:54:58 -04:00
Andrey 33be12541b K 2022-09-24 15:37:51 -04:00
Andrey 0eef498b3e refactoring: extract constant 2022-09-24 15:33:01 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc c4699efe91 honda K enum rename 2022-09-23 20:13:14 -04:00
rusefillc 2f18168d47 K20 2022-09-23 20:13:14 -04:00
rusefillc ed72758a5d K20 2022-09-23 18:25:24 -04:00
Matthew Kennedy dfe1b47b4d
remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy af7e4f6fe5
two modes trigger scheduler (#4598)
* two modes trigger scheduler

* asOld

* hpfp
2022-09-20 05:28:23 -04:00
rusefillc 60e703e079 B6 2022-09-17 23:49:24 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey 6b0941b8ed inline method to reduce confusion 2022-09-14 01:24:19 -04:00
Andrey 954ddacd96 GM 2022-09-14 00:03:38 -04:00
Andrey 8ce57d5599 code formatting 2022-09-13 23:44:38 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
Andrey cbb42b68d1 E38 2022-09-09 14:04:22 -04:00
Andrey 2199bfd7f7 E38 2022-09-09 01:15:55 -04:00
Matthew Kennedy 72299bd1ba
only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey 8e49542600 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 07d895dfeb B6 2022-09-06 15:12:43 -04:00
Matthew Kennedy b305308ef6
add hysteresis to limp rpm, boost, injector duty (#4541)
* add hysteresis

* changelog
2022-09-05 20:56:32 -04:00
Andrey 4d65067345 wow Leiderman-Khlystov 2022-09-05 20:23:40 -04:00
Andrey 4c9df01b64 wow Leiderman-Khlystov 2022-09-05 20:02:33 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey 268a5c7964 tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey feb386a54b refactoring: moving field 2022-09-05 01:15:45 -04:00
Andrey 796e421857 wow Leiderman-Khlystov 2022-09-04 18:29:13 -04:00