Commit Graph

4478 Commits

Author SHA1 Message Date
Jack Grigg 81be26650e CI: Fix potential template injection issues 2025-01-09 16:50:45 +00:00
Jack Grigg df1aa4fe40 CI: Opt out of credential persistence
We don't need to run authenticated git commands.
2025-01-09 16:10:33 +00:00
Jack Grigg b2d77bc4cb CI: Add workflow that runs zizmor latest
Source: woodruffw/zizmor@c6fef48587
2025-01-09 15:06:56 +00:00
Jack Grigg 5651d80ca9
Merge pull request #1675 from nuttycom/feature/transparent_gap_limit_handling-prep
Preparatory refactoring for zcash/librustzcash#1673
2024-12-30 22:26:29 +00:00
Kris Nuttycombe e6b45f76f8 zcash_client_sqlite: Remove duplicative migration test.
This removes a `fix_bad_change_flagging` migration test duplicated from
`zcash_client_backend::data_api::testing::pool::shiled_transparent`. It
is impractical to maintain backwards compatibility to earlier database
states for the entire test harness, which is more or less what retaining
this test would require, and the desired outcome is already demonstrated
by the `shield_transparent` test; demonstrating the fix directly is
unnecessary.
2024-12-30 15:14:50 -07:00
Kris Nuttycombe c278405a63 zcash_keys: Add `Address::to_transparent_address` 2024-12-30 15:14:50 -07:00
Kris Nuttycombe e4dac19eb6 zcash_keys: Add `ReceiverRequirement` enum.
This permits `UnifiedAddressRequest` values an additional dimension of
flexibility, permitting generation of unified addresses having receivers
for all recever types for which a key item exists and a diversifier
index is valid.
2024-12-30 15:14:50 -07:00
Kris Nuttycombe f48f72b67b zcash_client_sqlite: Move ephemeral address management test out of migration.
This test is not specific to the migration; it's a more general test of
ephemeral address rotation behavior and should evolve with the evolution
of address rotation and gap limit handling, not be tied to the behavior
of methods at the time that this migration was created.
2024-12-30 15:14:50 -07:00
Kris Nuttycombe 29d8f10cdc zcash_client_backend: Improve type safety of `get_known_ephemeral_addresses` 2024-12-30 15:14:50 -07:00
Kris Nuttycombe 5290d13942 zcash_client_backend: Move `Recipient::EphemeralTransparent` behind the `transparent-inputs` feature flag.
This variant should not have been a part of the public API unless
`tranpsarent-inputs` was enabled, as it's necessary for the wallet to be
able to spend a transparent input in order for a ZIP 320 transaction to
be properly constructed and authorized.

In addition, this simplifies the `Recipient` API by removing its type
parameters in favor of concrete types, made possible by using a
separate type for the build process.
2024-12-30 15:14:50 -07:00
Kris Nuttycombe 736bfd555b Move-only: group account retrieval methods together. 2024-12-30 15:14:49 -07:00
Kris Nuttycombe da98f9f2b5 zcash_client_sqlite: factor out commonalities of account retrieval 2024-12-30 15:13:10 -07:00
Kris Nuttycombe 5d7a1857ee zcash_protocol: Add unified address/fvk/ivk HRPs retrieval methods to `NetworkConstants` trait. 2024-12-30 15:11:42 -07:00
Jack Grigg 6ead8f8074
Merge pull request #1677 from zcash/protobuf-updates
Updates to Protobuf generation dependencies
2024-12-30 19:48:50 +00:00
Kris Nuttycombe 535c2343f5
Merge pull request #1672 from nuttycom/deprecate_reexports
Deprecate reexports of types that have been moved to other crates.
2024-12-30 12:37:35 -07:00
Kris Nuttycombe 185538522c Apply suggestions from code review
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
2024-12-30 12:17:50 -07:00
Jack Grigg 919cb286d1 Migrate to `prost-build 0.13.4` 2024-12-30 18:29:04 +00:00
Jack Grigg 30f2e7a1fc zcash_client_backend: Migrate to `tonic-build 0.12.3` 2024-12-30 18:12:45 +00:00
Kris Nuttycombe 4bdf39cb8f Reintroduce public reexports as deprecated replacement modules & types.
Due to limitations described in
https://github.com/rust-lang/rust/issues/30827, we can't just deprecate
the `pub use` stanzas; instead, we have to replace reexports with
new (deprecated) modules and public types which then internally reexport
the module internals or alias the reexported types, respectively.
2024-12-30 10:37:17 -07:00
Kris Nuttycombe f6c05345f4 Remove internal use of reexports of types have been moved to other crates.
This commit temporarily removes the reexported types to simplify the
removal process; the reexports will be reintroduced with deprecation
annotations in the subsequent commit.
2024-12-20 10:35:10 -07:00
Jack Grigg 84fdb1f8eb
Merge pull request #1671 from zcash/dependabot/github_actions/codecov/codecov-action-5.1.2
build(deps): bump codecov/codecov-action from 5.1.1 to 5.1.2
2024-12-20 07:02:59 +13:00
Jack Grigg feb979aa40
Merge pull request #1669 from zcash/no_std_ci
Add CI workflow to check no_std builds for `pczt` and `zcash_keys`
2024-12-20 07:02:30 +13:00
Kris Nuttycombe 9c564df40c
Merge pull request #1670 from zcash/pczt-redactor
pczt: Add a Redactor role
2024-12-19 07:04:02 -07:00
dependabot[bot] ebbc51e970
build(deps): bump codecov/codecov-action from 5.1.1 to 5.1.2
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-19 05:58:21 +00:00
Kris Nuttycombe 18aa84b427 Add CI workflow for verifying `no_std` builds of `pczt` and `zcash_keys`. 2024-12-18 21:55:36 -07:00
Jack Grigg 9c6d1b958b pczt: Add a Redactor role 2024-12-19 01:01:35 +00:00
Jack Grigg eee19d90c3
Merge pull request #1668 from zcash/pczt-improvements
PCZT improvements
2024-12-19 13:59:50 +13:00
Jack Grigg 2bce3ceea7 transparent: Add `Bip32Derivation::extract_bip_44_fields` 2024-12-18 18:37:03 +00:00
Jack Grigg 285d4b8724 pczt: Document fields required by our Signer implementation 2024-12-18 01:12:39 +00:00
Jack Grigg 02d18ecd9a
Merge pull request #1661 from zcash/zcash_keys_no_std
zcash_keys: Enable `no_std` usage.
2024-12-18 07:49:16 +13:00
Kris Nuttycombe 75e4c147a9 Add supply-chain audit for `nonempty` 2024-12-17 11:25:15 -07:00
Kris Nuttycombe fad7f38b9a Migrate to `nonempty 0.11` 2024-12-17 09:05:11 -07:00
Jack Grigg 0255874a26
Merge pull request #1667 from zcash/transparent-key-deriv-bugfix
transparent: Fix bugs in `AccountPubKey::derive_pubkey_at_bip32_path`
2024-12-18 03:20:37 +13:00
Jack Grigg 06f3eb7288 transparent: Fix bugs in `AccountPubKey::derive_pubkey_at_bip32_path`
- A typo in a panic guard condition instead exposed the panic.
- The match logic wasn't correctly handling the first element of the
  path.
2024-12-17 13:20:49 +00:00
Jack Grigg aea61bcdef transparent: Add test for `AccountPubKey::derive_pubkey_at_bip32_path` 2024-12-17 13:20:49 +00:00
Jack Grigg 43c147cc25 transparent: Add test vectors and consistency check 2024-12-17 13:16:17 +00:00
Jack Grigg 556cc4297a transparent: Move existing test vectors to a separate module 2024-12-17 12:22:37 +00:00
Jack Grigg 05fb7cde34 transparent: Add missing dev-dependencies 2024-12-17 12:21:24 +00:00
Kris Nuttycombe b90f1463bc zcash_keys: Enable `no_std` usage via a default-enabled `std` feature. 2024-12-17 05:10:56 +00:00
Kris Nuttycombe a1e4e7a220
Merge pull request #1665 from zcash/release/zcash_primitives-0.21
Release/zcash primitives 0.21
2024-12-16 22:08:29 -07:00
Kris Nuttycombe 172ebc394d Update `cargo vet` metadata for released crates. 2024-12-16 22:07:12 -07:00
Kris Nuttycombe 04c331cb5d Release zcash_client_sqlite version 0.14.0 2024-12-16 21:55:14 -07:00
Kris Nuttycombe ebd2d3abec Release zcash_client_backend version 0.16.0 2024-12-16 21:55:14 -07:00
Kris Nuttycombe a59773faee Release pczt version 0.1.0 2024-12-16 21:55:14 -07:00
Kris Nuttycombe 8c42a69bb5 Release zcash_proofs version 0.21.0 2024-12-16 21:55:14 -07:00
Kris Nuttycombe 0f78b4f9c4 Release zcash_primitives version 0.21.0 2024-12-16 21:55:14 -07:00
Kris Nuttycombe f23e478b99 Release `zcash_keys` version `0.6.0` 2024-12-16 21:55:14 -07:00
Kris Nuttycombe 2f33e1e0d9 Release `zcash_transparent` version 0.1.0 2024-12-16 21:23:24 -07:00
Kris Nuttycombe a5690007df Update to orchard version 0.10.1 2024-12-16 21:23:24 -07:00
Kris Nuttycombe d83076dcfc Migrate to sapling-crypto version 0.4 2024-12-16 21:23:24 -07:00