2a00d65226
Merge pull request #672 from nuttycom/wallet/autodetect_utxo_account
...
Remove `received_by_account` field from WalletTransparentOutput
2022-10-13 13:08:01 -06:00
5864e71eec
Add comment to call out the storage details of diversifier indices.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-13 10:38:59 -06:00
306d37e706
Add a test verifying that update fails on missing associated address.
2022-10-13 09:13:14 -06:00
90f67ee23d
Merge pull request #673 from zcash/group-0.12.1
...
zcash_primitives: Require `group 0.12.1` for `wnaf-memuse` feature flag
2022-10-13 07:48:37 -06:00
24f7d1c9bc
zcash_primitives: Require `group 0.12.1` for `wnaf-memuse` feature flag
2022-10-13 06:19:34 +00:00
f1f9465f37
Remove `received_by_account` field from WalletTransparentOutput
...
Due to how the wallets retrieved unspent transparent outputs from the
light wallet server, the account associated with a particular UTXO may
not be known by the light wallet. Instead of requiring the caller to
perform a separate lookup and match the address of the received UTXO
with a known account, it's simpler to perform this lookup internally at
the time of insertion or update.
In order to make this operation more efficient, the `addresses_table`
migration is modified to add a column to cache the transparent receiver
so that it may be used in the joins in the UTXO insert and update
operations.
2022-10-12 23:11:39 -06:00
59a4dd6efc
Merge pull request #665 from nuttycom/wallet/transaction_views_add_account
...
Add more information to v_transactions, v_sent_tx, and v_received_tx
2022-10-13 00:38:37 +01:00
5a2f659594
Ensure that only purely wallet-internal tx are returned as internal.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2022-10-12 16:53:00 -06:00
e6f039d0f9
Allow multiple migrations to be specified for custom wallet init.
...
Since our migrations form a DAG, it doesn't make sense to only allow a
single migration to be specified for wallet initialization; instead,
allow multiple migrations so that one can hit all the desired leaves.
2022-10-12 12:35:27 -06:00
f7a3b9bda3
Merge pull request #661 from nuttycom/wallet/spend_with_usk
...
Use unified spending keys for spends & shielding.
2022-10-12 12:15:34 -06:00
c3b6ef28c9
Merge pull request #647 from nuttycom/update_ua_test_vectors
...
Update unified address test vectors
2022-10-12 10:56:26 -06:00
6893da3054
Update zcash_client_backend/src/keys.rs
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-12 09:19:44 -06:00
85390cb8ce
Add more information to v_transactions, v_sent_tx, and v_received_tx
...
This adds sent and received note count information, transaction fees,
account information, and makes the information returned about sent
notes and received notes consistent with one another.
2022-10-12 08:52:37 -06:00
f689018fcd
Merge pull request #659 from nuttycom/wallet/decrypt_with_internal_key
...
Track inputs sent to wallet-internal recipients
2022-10-11 16:57:54 -06:00
e1d4229a68
Merge pull request #671 from zcash/fix-git-deps
...
Fix git dependencies
2022-10-11 23:26:59 +01:00
e666e69230
Address comments from code review.
2022-10-11 16:21:17 -06:00
fdf5aa7b8e
Fix exclusive or in sent_notes recipient check.
2022-10-11 15:49:52 -06:00
f27d3bca7f
CI: Switch back to published cargo-tarpaulin releases
...
The llvm-profparser branch has been merged and deleted.
2022-10-11 20:42:52 +00:00
62e1f99eb0
Improve TransferType documentation.
2022-10-11 14:42:06 -06:00
1d8fca848e
Point to upstream schemer repository
...
We can do this now that https://github.com/aschampion/schemer/pull/15
has been merged.
2022-10-11 20:40:41 +00:00
fd1640c242
Update CHANGELOGs
2022-10-11 13:08:15 -06:00
3c837381db
Disallow invalid pool/address combinations with `Recipient`.
2022-10-11 12:52:44 -06:00
56b2edd498
Simplify sqlite backend storage for sent notes & utxos.
...
The currently deprecated implementations of `insert_sent_utxo`,
`insert_sent_note`, `put_sent_utxo` and `put_sent_note` all store to the
same `sent_notes` table internally. Since there's no immediate plan to
change this arrangement, it's better to have a single pair of internal
`insert_sent_output` and `put_sent_output` methods instead.
2022-10-11 08:57:44 -06:00
ee9869bbeb
Use declarative style for `decrypt_transaction`
2022-10-11 08:56:26 -06:00
06e43a572a
Track inputs sent to wallet-internal recipients.
...
Ensure that we're attempting trial-decryption with the internal IVK
and correctly track internal vs. external recipients in the wallet
database.
2022-10-11 08:56:22 -06:00
1dc3cfe724
Merge pull request #657 from nuttycom/wallet/upsert_utxos
...
Use upsert functionality for transparent UTXOs, rather than delete/repopulate.
2022-10-11 04:17:49 +01:00
709577cec7
Merge pull request #666 from upbqdn/temporarily-fix-params-download
...
zcash_proofs: Temporarily fix params download
2022-10-09 00:36:58 +01:00
bd8472535c
Add a test for unified address derivation.
2022-10-07 20:37:39 -06:00
34a7abd653
Update unified address test vectors
...
This updates unified address test vectors after
https://github.com/zcash-hackworks/zcash-test-vectors/pull/89
to check addresses across multiple diversifier indices, and also
removes the superfluous binary encoding of UA strings.
2022-10-07 19:50:32 -06:00
75b4036862
Avoid a needless range loop
2022-10-07 17:19:03 +02:00
daf02c4338
Merge pull request #667 from nuttycom/wallet/transaction_fee_allow_missing_utxo
...
Allow spent UTXOs to be absent in migrations when adding tx fee.
2022-10-06 17:56:17 -06:00
c7be8ef04a
Allow spent UTXOs to be absent in migrations when adding tx fee.
...
The previous approach to UTXO handling involved UTXO data being
deleted from the wallet after the relevant UTXOs had been spent.
However, this means that we can no longer accurately compute
transaction fees for the transactions spending those UTXOs.
The `net_value` of the resulting rows in v_transactions will be
null.
2022-10-06 17:13:27 -06:00
f04690bfc0
Merge pull request #664 from zcash/dependabot/github_actions/actions/cache-3.0.10
...
build(deps): bump actions/cache from 3.0.8 to 3.0.10
2022-10-06 20:44:13 +01:00
b6e263d259
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-05 20:33:14 -06:00
f0f348ed00
Use the provided buffer when reading the response
...
The implementation of `io:Read` for `ResponseLazyReader` used to return
only one byte regardless of the size of the provided `buf`, which
significantly degraded the performance of loading the response.
This change makes use of the provided `buf`. On my machine with Rust
1.64, the downloading speed went up from ~100 KiB/s to ~2 MiB/s.
However, as before this change, the process still uses 100% of a single
CPU thread when downloading the response. The most likely reason is that
we still manually read each byte of the response. I can download the
same data with ~ 50 MiB/s on my machine using a different HTTP client.
This fix seems to be sufficient for now.
2022-10-05 23:47:50 +02:00
c5b9219f00
Look up the account by the UFVK corresponding to the USK when spending.
2022-10-05 14:35:51 -06:00
b7cc038050
Use unified spending keys for spends & shielding.
2022-10-05 14:35:51 -06:00
e9406201d5
Merge pull request #663 from nuttycom/sapling_key_cleanup
...
Fix Sapling key organization.
2022-10-05 14:35:16 -06:00
01a3c64606
Use `ResponseLazyReader` locally
2022-10-05 22:22:27 +02:00
d6484da088
Minor documentation fixes.
...
Co-authored-by: ying tong <yingtong@z.cash>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2022-10-05 13:02:21 -06:00
6df6fec860
Add utxo received_by_account data to WalletTransparentOutput
...
Also, this removes wallet::delete_utxos_above.
2022-10-04 13:34:52 -06:00
14787f574f
Add a migration to add account ID to the utxos table.
2022-10-04 12:25:56 -06:00
4fe49fd931
build(deps): bump actions/cache from 3.0.8 to 3.0.10
...
Bumps [actions/cache](https://github.com/actions/cache ) from 3.0.8 to 3.0.10.
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](https://github.com/actions/cache/compare/v3.0.8...v3.0.10 )
---
updated-dependencies:
- dependency-name: actions/cache
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-10-04 05:13:45 +00:00
60785a1d7a
Fix Sapling key organization.
...
This change moves Sapling-specific key generation into a
submodule of `zip32`. Public reexports are used to keep the
existing API consistent.
2022-10-03 20:28:04 -06:00
ab6f7929b4
Merge pull request #660 from nuttycom/upgrade_rusqlite
...
Upgrade rusqlite to version 0.25
2022-10-03 18:27:18 -06:00
f7aa7b2c84
Upgrade rusqlite to version 0.25
2022-10-03 08:12:37 -06:00
81e0d482d0
Merge pull request #656 from nuttycom/sqlite/migration_organization
...
Move wallet migrations into individual modules.
2022-10-03 08:10:08 -06:00
3b283ca445
Merge pull request #662 from str4d/remove-direct-ff-dep
...
Remove direct `ff` dependency
2022-10-02 17:14:06 -06:00
e54e3f21e8
zcash_client_sqlite: Remove direct ff dependency
2022-10-02 23:16:44 +01:00
b3f13020ac
zcash_client_backend: Remove direct ff dependency
2022-10-02 23:15:51 +01:00
Kris Nuttycombe
Kris Nuttycombe
Jack Grigg
Daira Hopwood
Marek
dependabot[bot]