Commit Graph

74 Commits

Author SHA1 Message Date
Daira Hopwood 45e175512e ZIP 32: fix a type error in dk derivation for Orchard.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-03 22:48:38 +00:00
Daira Hopwood e40bb506ab ZIP 32 editorial updates.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-02 22:20:42 +00:00
Daira Hopwood e79401a10c Apply suggestions from ZIP review
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
2021-03-02 22:20:42 +00:00
Jack Grigg dd8b82f567 ZIP 32: Address Orchard review comments 2021-03-02 22:20:42 +00:00
Jack Grigg 95ea11de9d ZIP 32: Clarify the diversifier key capabilities of an Orchard fvk 2021-03-02 22:20:42 +00:00
Jack Grigg f2eb24ae6e ZIP 32: Specify Orchard key derivation 2021-03-02 22:20:42 +00:00
Daira Hopwood 947f0b6649 Regularize ZIP categories.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-11-14 22:17:27 +00:00
Daira Hopwood c762d1ca67 Regularize references, especially to RFCs and the Protocol Spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 15:59:51 +00:00
Daira Hopwood fb84bd8084 Ensure that URLs enclosed in <> in header fields are linked.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-09-14 14:12:49 +01:00
Daira Hopwood 408a0a744c ZIP 32: fix an off-by-one error pointed out by @bigbrain.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-31 17:27:27 +01:00
Daira Hopwood 9a6aa31d93 ZIP 32: correction for seeds longer than 32 bytes. refs https://github.com/zcash/zcash/issues/4641
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-29 20:07:07 +01:00
Daira Hopwood 60db5fe85d ZIP 32: fixes https://github.com/zcash/zcash/issues/4641
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-07-29 19:33:49 +01:00
Daira Hopwood a3f0295cb6 ZIP 32: formatting.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-05-01 10:16:18 +01:00
Daira Hopwood 69ef14ce8a ZIP 32: add more line break opportunities in math.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-22 14:37:07 +01:00
Daira Hopwood 6c6843154d ZIP 32: use :math: markup for better rendering.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-04-22 11:41:16 +01:00
Daira Hopwood 09b3f6955c Link to https://www.rfc-editor.org/rfc/rfcXXXX.html for RFCs.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-02-29 16:00:39 +00:00
Daira Hopwood feca6f4b26 ZIP 31: child ask_i and nsk_i keys are intended to be taken modulo r_J.
Technically the ZIP was already correct because I_{ask}, I_{nsk}, ask_{par}, and nsk_{par} are all F_{r_J} elements,
but that assumes a lot of familiarity with the spec notation.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-01-21 13:32:30 +00:00
Daira Hopwood 41ec7e7820 Remove email addresses from Credits fields.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-01-01 16:28:27 +00:00
Daira Hopwood 8827ef0815 ZIP 32: update spec references.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-11-10 16:47:16 +00:00
Daira Hopwood 65af4c7de4 Fix rst warnings.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-06 13:58:09 +01:00
Daira Hopwood 3ccf1c37d1 Various ZIPs: clean up header metadata.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-01 09:18:23 +01:00
Daira Hopwood 4a9eb35910 ZIP 32: fill in links to reference implementation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-02-22 22:54:16 +00:00
Jack Grigg 975a2aaa64
Formatting 2018-09-20 11:05:25 +01:00
Ariel cb1e663836
Improve explanation of diversifier sequence choice 2018-09-20 12:11:13 +03:00
Jack Grigg 888681c0b0
Update references to Sapling protocol spec 2018-09-18 11:42:29 +01:00
Jack Grigg 606abd14e2
Be explicit about supported range for the Sapling key path 2018-09-18 11:40:19 +01:00
Jack Grigg 44e9c03d45
dk_i -> dk in "Diversifier derivation" section 2018-09-18 11:39:52 +01:00
Jack Grigg 1f7b5120f1
Clarify that dk is not part of the standard Sapling derivation 2018-09-18 11:38:54 +01:00
Jack Grigg a414e4e7d3
Pull in definition of hardened notation 2018-09-18 11:37:55 +01:00
Jack Grigg 55e3cd177e
Clarify wording about default payment addresses 2018-09-18 11:25:12 +01:00
Daira Hopwood 2eec56d936 Add specification for seed fingerprints. 2018-09-01 18:39:41 +01:00
Daira Hopwood 08b8427e91 Don't use 'X' to abbreviate 'extended', since it is ambiguous with 'expanded'. 2018-09-01 18:39:08 +01:00
Daira Hopwood 2aee30ca10 Use the same notation for r_J as the spec. 2018-09-01 18:36:39 +01:00
Daira Hopwood 813a8891d1 Rename EncodeFVKParts to EncodeXFVKParts, since its input includes dk which is only part of an extended full viewing key.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 14:48:33 +01:00
Daira Hopwood 511c2eb1e0 Fix a link.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood eb60b41f20 Seeds for Sprout master keys must also be at least 32 bytes.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 5cdc69196a Factor out Sprout a_sk encoding/decoding into helper functions.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 3018efc0f3 Correct the encoding of a_sk,par for Sprout child derivation.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 777d82a26f Factor out the encoding of extended {spending key, full viewing key} parts and make it more precise.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 6f966489b8 Correct the derivation of a Sapling child full viewing key's nk, and define the bases G and H.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 1b04d74cde Remove unintended addition of a reference to the non-existant (yet) ZIP 173.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 6e9a79604c Cosmetics.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 42506f08bd Define DiversifyHash.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood ebecd8c1ff Clarify the encoding of a_sk in a Sprout extended spending key. Also exclude lead bytes, and swap ASK and c for consistency with Sapling formats and BIP 32.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 5881d3c211 Define depth, parent tag, and i for master keys.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 7002be59fa Clarify the interpretation of I_L in Sprout key derivation.
This also fixes a cut-and-paste error (a child chain code is c_i, not c_m).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood ba56f26b4d Explain that some diversifiers are invalid, and correct the definition of default diversifier.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 5788c120e7 Rename s_m to sk_m.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood 633436cff6 Specify that the seed MUST be at least 32 bytes.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00
Daira Hopwood d65629f7a1 Clarify the relation to existing use of BIPs 32 & 44.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2018-07-25 00:32:43 +01:00