zecfoundation
/
zebra
mirror of https://github.com/ZcashFoundation/zebra.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

change(dev): Add CHANGELOG checks to PR review template (#5202) 

* Ask PR reviewer to check name, labels, and CHANGELOG

* Re-phrase extra CHANGELOG info
This commit is contained in:
teor 2022-09-22 04:47:28 +10:00 committed by GitHub
parent 2b4f7ec6d5
commit 694390c50b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/pull_request_template.md vendored
View File

@ -37,9 +37,11 @@ If you want a specific reviewer for this PR, tag them here.
### Reviewer Checklist
- [ ] Code implements Specs and Designs
- [ ] Tests for Expected Behaviour
- [ ] Tests for Errors
- [ ] Will the PR name make sense to users?
- [ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
- [ ] Are the PR labels correct?
- [ ] Does the code do what the ticket and PR says?
- [ ] How do you know it works? Does it have tests?
## Follow Up Work