Francisco Paisana
c9a5180a09
sched,nr: integrate NR scheduler in nr_phy_test
...
The scheduler can be activated via a command line flag
2021-07-19 16:04:46 +02:00
Francisco Paisana
660b66dbe3
sched,nr: add option to run phy nr test with real NR scheduler
2021-07-19 16:04:46 +02:00
Xavier Arteaga
b264f8fa1e
Fix nr_phy_test TSAN warnings
2021-07-19 12:53:48 +02:00
Andre Puschmann
fc8fe032ff
rrc_nr,endc: add more fields to NR RRC Reconfig for EN-DC activation
...
adds a big chunk of new fields to the reconfig packing code,
tested with srsUE
2021-07-19 12:53:09 +02:00
Ismael Gomez
6fb9b6bf94
Fix sub-band CQI in UE. Refactor variable names
2021-07-19 12:27:54 +02:00
Francisco Paisana
e6683b7387
sched,nr: simplify scheduler threading architecture to reflect the new cc-based parallelism model
2021-07-16 22:57:55 +02:00
Francisco Paisana
74d0a8adb8
sched: add subband cqi info interface to LTE scheduler
2021-07-16 19:34:10 +02:00
Andre Puschmann
921a04ce65
enb,mac_nr: turn UE object into normal std::unique_ptr
2021-07-16 12:35:12 +02:00
Andre Puschmann
b3ab661261
rrc_mobility: change log to info when receiving non-EUTRA meas report
2021-07-16 12:35:12 +02:00
Andre Puschmann
48e42f13a3
mac_nr: only request first 2 SIBs from RRC
2021-07-16 12:35:12 +02:00
Andre Puschmann
8d2e81ad6f
enb,mac,nr: add basic UE object skeleton
...
refactor that also adds a basic UE object to the NR MAC
2021-07-16 12:35:12 +02:00
Francisco Paisana
09c7000201
sched,nr: update nr scheduler to use new mac nr interface types
2021-07-15 21:56:47 +02:00
Francisco Paisana
8a34a3c41a
sched,nr: fix compilation issues in centos7 and removed unused variables
2021-07-15 21:56:47 +02:00
Francisco Paisana
d9336bcd9e
sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY
2021-07-15 21:56:47 +02:00
Francisco Paisana
1535e6b205
sched,nr: extend sched nr testing suite. restrict paralllelization for correct DAI generation
2021-07-15 21:56:47 +02:00
Francisco Paisana
323703c2f3
sched,nr: measure latency of sched nr in test
2021-07-15 21:56:47 +02:00
Francisco Paisana
d63ea00a5d
sched,nr: use PRBs instead of RBGs as the basic unit for PRB grants in the NR scheduler
2021-07-15 21:56:47 +02:00
Francisco Paisana
b81cbd1334
sched,nr: redesign the order available search spaces/coresets are found in the scheduler
2021-07-15 21:56:47 +02:00
Francisco Paisana
dd3c9b4d7e
sched,nr: utilization of common bwp params structure across multiple sched objects
2021-07-15 21:56:47 +02:00
Francisco Paisana
2db8b8d876
sched,nr: add RAR scheduler inspired in LTE one
2021-07-15 21:56:47 +02:00
Francisco Paisana
4f0b954cde
sched,nr: changed scheduler nr api to not require slot_indication function
2021-07-15 21:56:47 +02:00
Francisco Paisana
23afc66a86
sched,nr: implementation of PUCCH HARQ allocation in NR
2021-07-15 21:56:47 +02:00
Francisco Paisana
bcc374c2cd
implement TDD DL vs UL slot activation
2021-07-15 21:56:47 +02:00
Francisco Paisana
f87f898641
sched,nr: extend coreset pdcch allocation to UL
2021-07-15 21:56:47 +02:00
Ismael Gomez
5d034b067e
Add option to rr.conf to select sub-band CQI K value ( #3071 )
2021-07-15 21:23:35 +02:00
Francisco
357bc10a17
feature - make minimum SNR, under which the RRC is notified with UL KO, configurable
2021-07-15 18:44:51 +02:00
faluco
8708043a5f
- Add date to log timestamps.
...
- Print once per second the current timestamp into stdout, feature guarded by a config expert option.
2021-07-15 18:44:51 +02:00
Francisco
67325ab5c1
add pdcch_cqi_offset parameter to enb.conf
2021-07-15 18:44:51 +02:00
Francisco
2a31daca4a
enb,configuration: allow to specify enb specific max nof RLC retxs
2021-07-15 15:59:33 +02:00
Pedro Alvarez
132f2aa605
Added assert to make sure SRB id makes sense in apply_rlc_rb_updates
2021-07-14 20:21:07 +02:00
Pedro Alvarez
e946cbd5de
Tweaked SRB parsing to remove unecessary parenthisis
2021-07-14 20:21:07 +02:00
Pedro Alvarez
8d41c0d476
Maded SRB configuration optional in rb.conf
2021-07-14 20:21:07 +02:00
Pedro Alvarez
f0a28ebc88
Rename drb.conf to rb.conf to reflect the now configurable SRBs.
2021-07-14 20:21:07 +02:00
Pedro Alvarez
17c09dfd75
Changed enb_cfg_parcer.cc to use SRSRAN_ERROR instead of -1 for error returning.
2021-07-14 20:21:07 +02:00
Pedro Alvarez
e19df2aedb
Make sure that SRB configuration goes in RR config dedicated message.
2021-07-14 20:21:07 +02:00
Pedro Alvarez
72cf3a1cec
Added RLC SRB1 and SRB2 configuration ability.
...
The configuration was added to drb.conf
2021-07-14 20:21:07 +02:00
Ismael Gomez
1fd9d4300c
Move pdu buffer mutex in mac::ue to each carrier buffer map
2021-07-14 18:59:04 +02:00
Xavier Arteaga
b25681f9de
gnb,prach: add PRACH to gNB
...
rebase of Xavier's feature_gnb_prach branch
2021-07-14 14:30:58 +02:00
Xavier Arteaga
47747e3148
SRSENB: RRC measurement report for NR are appended
2021-07-14 12:56:39 +02:00
David Rupprecht
59ca11db68
Added missing target_link_libs
2021-07-14 09:41:37 +02:00
Andre Puschmann
6c82d63aa6
remove legacy PNF/VNF code
...
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.
in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
2021-07-12 19:24:02 +02:00
Xavier Arteaga
96cb25b868
Add arguments to NR PHY test
2021-07-09 22:32:40 +02:00
Xavier Arteaga
ecc0b92142
Integrated PUSCH decoder in gNb
2021-07-08 16:47:07 +02:00
Andre Puschmann
068267992d
rnti_pool: add rrc_endc class and extra 1024B to UE memblock size
...
this should fix #3045
however, this hard-coded size seems pretty unflexible anyway so we might
have to increase/add to it, or find an alternative way to calculate the size?
2021-07-08 15:21:28 +02:00
Andre Puschmann
e460739152
rrc_ue: only create and call endc_handler if NR RRC is available
2021-07-06 21:57:44 +02:00
Andre Puschmann
3f81d3e969
enb,rrc_endc: add handler for measurements and UE capabilities
2021-07-06 21:57:44 +02:00
Andre Puschmann
8d443d79e5
enb,rrc: add skeleton code for new RRC internal interface for SgNB addition
2021-07-06 21:57:44 +02:00
Andre Puschmann
8dd7075d12
enb,stack: add NR components for NSA mode
...
adds the main NR components for RLC, PDCP, MAC and RRC
for NSA operation.
2021-07-06 21:57:44 +02:00
Andre Puschmann
ec3465bb98
s1ap: fix compilation of test on 32bit
2021-07-06 12:48:41 +02:00
Andre Puschmann
19996a4059
sched_nr: fix compilation
2021-07-06 10:11:50 +02:00
Xavier Arteaga
5307fec2f0
Added GNB MAC UL info initial interface and fix PHY implementation
2021-07-05 17:51:27 +02:00
Xavier Arteaga
e764a26136
Integrated PUCCH decoding in gNb
2021-07-05 17:51:27 +02:00
Xavier Arteaga
3fe9176750
Added PUCCH dedocder to slot worker
2021-07-05 17:51:27 +02:00
Xavier Arteaga
658b47d917
Added NR PUSCH and PUCCH decoder in gnb_ul
2021-07-05 17:51:27 +02:00
Xavier Arteaga
f6fc215541
Refactored enb_dl_nr to gnb_dl and initial gnb_ul
2021-07-05 17:51:27 +02:00
David Rupprecht
f90e359208
Moved cp to test common
2021-07-02 17:23:06 +02:00
Ismael Gomez
4e39982a19
Fix TSAN warnings in UE ( #3021 )
...
* Protect PHY SR signal management in a class
* Protect intra_freq_meas vector
* Protect cell and srate shared variables in thread-safe classes
* srsue,srsenb: include TSAN options header
* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes
* Protect access to state variable in sync_state
* Protect access to metrics configuration
* Protect access to is_pending_sr
* Protect access to UE prach worker
* Protect UE mux
* Avoid unlocking mutex twice
* Fix data races in RF/ZMQ
* Fix data races in intra_measure and PHY
* Fix minor data races in MAC
* Make TSAN default behaviour to not halt on error
* Fix blocking in intra cell measurement
* Address comments
Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
2021-07-01 17:39:54 +02:00
Ismael Gomez
c0fd64c4e6
Fix data races in srsENB MAC
2021-07-01 17:39:06 +02:00
Pedro Alvarez
1b676aa406
Moved lib GTPU to its own folder
2021-06-30 18:19:20 +01:00
Pedro Alvarez
865298f8d5
Moved lib PDCP to its own folder
2021-06-30 18:19:20 +01:00
Pedro Alvarez
171d5727be
Moved lib RLC into it's own folder
2021-06-30 18:19:20 +01:00
Francisco Paisana
30802777cf
fix,enb: fix enb.conf param description
2021-06-29 20:39:32 +02:00
Francisco Paisana
4d014e7ceb
s1ap,feature: make the ts1 reloc timers configurable via the enb.conf
2021-06-29 20:39:32 +02:00
Francisco
4c316aa9ea
sched,nr: integrate mac-phy interface types into the scheduler
2021-06-29 14:19:35 +02:00
Francisco
5b3c5ded63
sched,nr: implement NR PDCCH allocation algorithm
2021-06-29 14:19:35 +02:00
Xavier Arteaga
6f5614a0cc
Suggested modifications on gNb MAC/PHY interface
2021-06-28 00:27:36 +02:00
Xavier Arteaga
8378c85ec4
Refactored gNb PHY
2021-06-28 00:27:36 +02:00
Xavier Arteaga
c4e13f70a2
SRSENB: fix NR worker pointer check
2021-06-28 00:27:36 +02:00
Xavier Arteaga
aef3e5a40a
More NR PHY test and GNB PHY development
2021-06-28 00:27:36 +02:00
Xavier Arteaga
d49734b1bc
SRSENB: Refactor to accomodate 5G NR
2021-06-28 00:27:36 +02:00
Francisco
de05e1e549
sched,nr: fix invalid memory write
2021-06-24 16:22:42 +01:00
Francisco
75153c7c83
sched,nr: implementation of sched sim test class
2021-06-24 16:22:42 +01:00
Francisco
f1b3cfc764
sched,nr: implementation of sched NR harq retxs. Refactor of rb grid classes.
2021-06-24 16:22:42 +01:00
Francisco
d950433cbd
sched,nr: fix time-domain parallelization sched nr test. creation of util class to handle acquisition of boolean resources
2021-06-24 16:22:42 +01:00
Francisco
35a236b1b9
sched,nr: fix sched_nr_test. Resolve data race issues. Created new config structs used across the scheduler.
2021-06-24 16:22:42 +01:00
Francisco
407da794e1
sched,nr: implementation of slot grid class
2021-06-24 16:22:42 +01:00
Francisco
4fa27f3841
sched,nr: implementation of main classes for NR scheduler, and basic test for concurrency
2021-06-24 16:22:42 +01:00
Andre Puschmann
483a216bd5
ue,stack: refactor handling of radio bearears in UE stack
...
this is a rather large commit that is hard to split because
it touches quite a few components.
It's a preparation patch for adding NR split bearers in the next
step.
We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.
The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.
The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.
The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
2021-06-24 16:52:58 +02:00
Francisco
e70b8c2472
sched,bugfix: fix SI scheduler logging
2021-06-24 14:24:00 +01:00
Andre Puschmann
4b069d9b86
enb,mac: fix concurrent access to cell structs
...
this patch moves the rwlock that protects the UE database outside
to also protect the cell struct.
It also adds a missing write guard when setting the cell
2021-06-23 12:38:19 +02:00
Andre Puschmann
ff72c78745
enb,mac: fix indention
2021-06-23 12:38:19 +02:00
David Rupprecht
ec19919246
Fix NGAP valgrind test
2021-06-22 20:53:43 +02:00
Pedro Alvarez
aae266e848
Added configuration option for S1AP SCTP bind port
2021-06-22 11:11:54 +01:00
Francisco
78acf81cf0
bugfix,sched: avoid instability in TPCs around PHR~0
2021-06-21 17:35:24 +01:00
Xavier Arteaga
b1e4720721
SRSUE/SRSENB: added tx_enable flag in worker_end
2021-06-21 18:07:53 +02:00
Xavier Arteaga
027201d457
SRSUE/SRSENB: Refactor NR workers to generalise lower PHY
2021-06-21 18:07:53 +02:00
yagoda
ce30b7e1ce
fixing eMBMS after new ue_db architecture and scheduler changes
2021-06-21 11:20:03 +02:00
Pedro Alvarez
181b903117
Small log fix for RNTI in integrity failure notifications
2021-06-18 23:17:39 +02:00
Ismael Gomez
02ec4dd3d0
Remove unused variable
2021-06-18 23:17:14 +02:00
Ismael Gomez
dd9889e07c
Add carrier index to uplink PCAP captures
2021-06-18 23:17:14 +02:00
Bedran Karakoc
c280ac5ad6
Introducing extended NGAP functionality
...
Remove unused logger for now in ngap::ue to pass tests
2021-06-17 13:05:29 +02:00
Francisco
5a82a63bb5
bugfix,srsenb: fix intraenb handover softbuffer allocation during handover
2021-06-16 10:21:13 +01:00
Francisco
d5234b5f65
sched,bugfix: avoid using UL SNR average in tpc control loop
2021-06-15 19:12:24 +01:00
Francisco
c111b23255
config,enb: change the max sib coderate to 0.3
2021-06-14 18:55:51 +01:00
Francisco
2a009eb340
sched,feature: Enable configuring maximum coderate for SIB allocations
2021-06-14 18:55:51 +01:00
Francisco
6ababf401b
feature,sched: allow setting initial DL CQI in enb.conf
2021-06-14 15:55:23 +01:00
Francisco
4cf5a8b25a
fix: avoid configuring the phy mbsfn from the rrc, when phy is not fully initialized
2021-06-14 15:55:10 +01:00
Francisco
f55e1c5a73
fix,srsenb: start stack before the radio to avoid stack methods to be called when stack is not fully initialized
2021-06-14 15:55:10 +01:00
Francisco
e8983b88f0
refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue
2021-06-14 13:18:47 +01:00
Xavier Arteaga
63de691351
SRSENB: Added sleep command description
2021-06-14 09:21:29 +02:00
Xavier Arteaga
4bfe092a24
Added multi-command line in srsenb
2021-06-14 09:21:29 +02:00
Francisco
99960c72fa
bugfix,srsenb: extend rrc mobility unit test for intraenb handover
2021-06-10 09:46:01 +01:00
Francisco
69b7a7eb19
bugfix,srsenb: the lcids beloging to SRB1 and SRB2 were not being reactivated correctly during intra-eNB handover
2021-06-10 09:46:01 +01:00
Francisco
a0ba2d576d
remove unused return variable
2021-06-09 11:12:06 +01:00
Francisco
048d487921
bugfix,gtpu: send end marker via the forwarding tunnel, when the source enb receives ue ctxt release command. Improve GTPU unit testing
2021-06-09 11:12:06 +01:00
Francisco
8cbbebdea2
bugfix,scheduler: make sure UL harq pending data is cleared up when the last retx falls in a measurement gap
2021-06-09 10:52:43 +01:00
Francisco
51c9fc514d
refactor,sched: fix log lines related with meas gap collisions
2021-06-09 10:52:43 +01:00
Pedro Alvarez
163976f050
Fix releasing on on RRC and not on S1AP on integrity failure.
2021-06-08 18:52:22 +01:00
Pedro Alvarez
a53b321ab8
Release UE upon reception of integrity error.
2021-06-08 18:52:22 +01:00
Pedro Alvarez
299d2ee35d
Added interface to make the PDCP notify the RRC of integrity check
...
failures.
2021-06-08 18:52:22 +01:00
Francisco
5c7ea6f6df
bugfix,srsenb,rrc: remove redundant calls to setup PDCP/RLC bearer state during reestablishment
2021-06-08 16:21:57 +01:00
Francisco
fd3901e4a2
bugfix,srsenb,rrc: delete old context right away after sending Reestablishment msg.
...
Following ReestablishmentRequests should use the most recent rnti as old context.
2021-06-08 16:21:57 +01:00
Andre Puschmann
f65faba756
sched_harq: fix uninitialized values in HARQ
...
detected with Valgrind memcheck
2021-06-05 11:04:33 +02:00
Francisco
35cea3d104
enb,optimization: consider mac::ue object in rnti pool memory block size
2021-06-04 21:29:13 +01:00
Francisco
7e77da6a15
mac,optimization: use rnti memory pool to create mac::ue objects
2021-06-04 21:29:13 +01:00
Francisco
fd1d73666c
bugfix,srsenb,mac: avoid sanity check for UL PDU length if CRC=KO
2021-06-04 20:03:38 +01:00
Francisco
76004a3054
enb,mac,refactor: mac::ue now uses byte_buffer_pool for UL PDUs
2021-06-04 20:03:38 +01:00
Francisco
9e2a7d4592
bugfix,tpc: only cap PUSCH TPC when PHR is negative. I also extended TPC unit test
2021-06-04 17:39:51 +01:00
Francisco
bdc4362475
bugfix,tpc: place a cap on TPC due to PHR only when TPC is positive
2021-06-04 17:39:51 +01:00
Francisco
7badfb1c88
bugfix: avoid multiple TPC=0 for a single PHR<0
2021-06-04 17:39:51 +01:00
Francisco
e2c37ad513
bugfix: missing early return in TPC derivation
2021-06-04 17:39:51 +01:00
Francisco
75eebd6b5d
bugfix,gtpu: close forwarding tunnel during reestablishment due to handover failure
2021-06-04 14:59:12 +01:00
Francisco
597f993706
sched,improvement: filter out Msg3 UL SNR estimates from the TPC control loop
2021-06-04 13:45:10 +01:00
Andre Puschmann
c0be8187c8
rlc interface: convert entire read_pdu() interface to return uint32_t
...
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.
Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
2021-06-04 13:23:54 +02:00
Xavier Arteaga
090022568e
DCI NCCE find considers L and NCCE
2021-06-04 11:13:23 +02:00
Andre Puschmann
aaffdeb326
rrc,rlc: add method to signal protocol failure to RRC
...
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.
In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
2021-06-03 21:11:47 +02:00
Andre Puschmann
107f6334dd
compile: fix compilation on 32bit systems that require -latomic
2021-06-03 20:45:02 +02:00
Andre Puschmann
80a89ec4bf
enb,mac: protect concurrent access to ue_db from different threads
...
race condition between PHY worker(s) and Stack thread when
accessing ue_db member. RWlock needs to be hold.
partly fixes #2932
2021-06-03 20:43:37 +02:00
faluco
3df72cb6ab
Move out a free call in a RT thread when doing lots of rachs.
2021-06-03 20:41:04 +02:00
Francisco
ceaef3523f
sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing
2021-06-03 15:33:38 +01:00
Francisco
486823e5de
sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1
2021-06-03 15:33:38 +01:00
Francisco
f7aef3ffc1
sched,bugfix: fix nof_retx update when UL HARQs are resumed
2021-06-02 20:21:32 +01:00
Ismael Gomez
5cef780789
Radio-link KO notification. Measgap fix
2021-06-02 12:37:36 +02:00
Francisco
92e272ce3e
limit minimum UL grant size to accommodate both BSR and RLC headers
2021-06-02 12:37:36 +02:00
Francisco
3b61df4b64
test,sched: update TPC test to reflect changes in SNR estimatioN
2021-06-02 10:08:34 +01:00
Francisco
89406b07d6
make eNB UL SNR initial value an exponential average alpha configurable
2021-06-02 10:08:34 +01:00
Francisco
2a2c56391c
sched,refactor: Improve DL/UL grant log lines in the scheduler to print CFI as well
2021-06-02 10:08:34 +01:00
Francisco
dda52afe61
move rrc unit tests to rrc/ folder
2021-06-02 10:05:49 +01:00
Francisco
47494a668d
rrc,bugfix: fix reestablishment crash due to pointer invalidation
2021-06-02 10:05:30 +01:00
Francisco
3f75538660
rrc,feature: Use t301 to set time that the enb waits for the UE RRCConnectionSetupComplete or ReestablishmentComplete
2021-06-02 10:05:30 +01:00
Francisco
0349949cce
bugfix, handover: disable inactivity timer during s1 handover in target enb
2021-06-02 10:05:30 +01:00
Francisco
19af55b63d
bugfix, handover: Avoid sending UEContextReleaseRequest from Target eNB during S1 Handover due to UL KOs
2021-06-02 10:05:30 +01:00
Andre Puschmann
2c975732dc
metrics_stdout: fix race detected by TSAN
2021-06-01 22:44:12 +02:00
Pedro Alvarez
c23034e1a7
Make sure the S1AP state is reset after sending a successful/unsuccessful message
2021-06-01 19:16:16 +01:00
Pedro Alvarez
18e2149d68
Sending Initial Context Setup Response after RRC reconfiguration.
2021-06-01 19:16:16 +01:00
Xavier Arteaga
50b7d3937f
Added RNTI in SRSENB PDCCH log line
2021-06-01 15:04:24 +02:00
Xavier Arteaga
6de34524e2
Fix SRSENB PHY log line
2021-06-01 08:27:03 +02:00
Xavier Arteaga
ce3c808a16
Reviewed SRSENB PHY unused variables and log messages
2021-06-01 08:27:03 +02:00
Francisco
f80c591127
sched,bugfix: fix scheduler CA test
2021-05-31 23:59:46 +01:00
Francisco
2cdda3b6db
sched,enhancement: allow PUSCH allocations when PHICH falls in measurement Gap by resuming UL HARQ
2021-05-31 23:59:46 +01:00
Andre Puschmann
fcba67ca84
enb,rrc: fix logging text
2021-05-28 18:12:16 +02:00
Andre Puschmann
8322887135
enb,rrc: increase RRC PDU queue size to 128
2021-05-28 18:12:16 +02:00
Francisco
a8790abd7e
fix centos7 tuple compilation issue
2021-05-28 17:21:10 +02:00
Francisco
200006c4b7
bugfix,scheduler: avoid offset to increase decrease unboundedly when mcs is equal to 0 or max_mcs
2021-05-28 17:21:10 +02:00
Francisco
0dafe4dd58
fix coderate derivation in PDCCH based on aggregation level
2021-05-28 17:20:08 +02:00
Francisco
a587d20252
allow specification of subset of valid measurement gap offsets in rr.conf
2021-05-28 17:19:30 +02:00
Francisco
0996e50dce
bugfix, s1ap: allow source enb to release old UE ctxt in case a connectionRequest arrives with repeated m-TMSI
2021-05-28 17:18:41 +02:00
Francisco
52247a46e5
rrc,refactor - change log level for paging try lock
2021-05-28 12:29:36 +02:00
Francisco
692bd193d5
rrc,improvements - use single subframe-indexed struct to access pending PCCH. The scheduler now doesnt lock checking for pending paging
2021-05-28 12:29:36 +02:00
Francisco
957ca453e9
bugfix,rrc: change mechanism to delete old paging messages to avoid deleting messages not yet sent
2021-05-28 12:29:36 +02:00
Andre Puschmann
66770a57e3
enb_phy_test: fix concurrent access between PHY worker and Stack
...
PHY and Stack are using a normal std::queue to communicate with each
other. Concurrent access among the threads needs to be protected.
2021-05-26 14:25:38 +02:00
Francisco
fe0dc77c03
bugfix, s1ap: fix uninitialized variable access in s1ap_test
2021-05-26 11:35:32 +02:00
Francisco
297a2394b8
bugfix, s1ap: fix failing s1ap_test
2021-05-26 11:35:32 +02:00
Francisco
7076dbfef8
feature, scheduler: Add configuration parameter to set minimum TTI interval between TPCs
2021-05-25 21:51:10 +02:00
Francisco
4627ae9802
bugfix, scheduler: effectively disable adaptive mcs when target bler is unspecified
2021-05-25 21:51:10 +02:00
Francisco
c75777c618
bugfix, sched: avoid compilation issue due to uninitialized variable access
2021-05-25 21:50:56 +02:00
Francisco
329cf02cd0
bugfix, sched: ensure max_coderate is respected in scheduler
2021-05-25 21:50:56 +02:00
Francisco
a8cccd7a10
bugfix, sched: fix aggregation level derivation to avoid L > 3
2021-05-25 21:50:56 +02:00
Francisco
dedd9c09a7
feature, scheduler: Add abitility to set minimum aggregation level in PDCCH, and disable adaptive aggregation level based on target BLER
2021-05-25 21:50:56 +02:00
Francisco
fb4a363abd
fix formatting errors in scheduler
2021-05-24 19:33:27 +02:00
Francisco
1f1665bab7
improve adaptive offset adjustment log lines
2021-05-24 19:33:27 +02:00
Francisco
c5029fc266
feature - implement adaptive link adaptation in DL and UL
2021-05-24 19:33:27 +02:00
Francisco
8811b7c9a7
fix handling of CRNTI CE in the RRC. The scheduler should not allocate more grants for the new rnti after this point.
2021-05-24 19:33:16 +02:00
Francisco
59513c0eed
fix bearer reactivation in case the RRC session is recovered after max KO
2021-05-24 19:33:16 +02:00
Andre Puschmann
fbb151af2d
enb,rrc: fix bearer re-activation after max KO
...
this patch makes sure that if RBs have been deactivated after
max KO on either the DL or the UL, they are reactivated if either
of them is working again.
UL/DL are always activated together, even if just one of them
recovers. The KO counter (or timer), however, is not stopped implicitly.
2021-05-24 19:33:16 +02:00
Francisco
59db527481
fix reestablishment reject logging level
2021-05-24 19:33:16 +02:00
Francisco
a17e3b71e7
set minimum snr under which the UL SNR estimate is not updated
2021-05-24 17:25:07 +02:00
Francisco
8df6ed07c6
sched small fixes - use 0.930 instead of 0.932 for max coderate. Allow computing mcs/tbs based on max coderate directly. Other small fixes
2021-05-24 17:25:07 +02:00
Francisco
41bc7e4810
avoid letting repeated s1ap::user_release calls to deem the user as in zombie state. Use timer instead to auto-remove user from s1ap if no response from mme arrives
2021-05-24 17:24:31 +02:00
Francisco
e07ef0aa18
avoid releasing ues doing s1 handover before TS1relocoverall expiry
2021-05-24 17:24:31 +02:00
Francisco
b093576634
avoid sending UEContextReleaseRequest from Source eNB during S1 Handover.
2021-05-24 17:24:31 +02:00
Francisco
f2a56c9139
simplification of multiqueue design.
...
- the consumer does multi-staged waiting:
1. spins first across all queues in a RR fashion
2. each queue access is done with a try_lock.
3. if the try_lock fails, it increases the number of spins needed
2. if no queue had data, the consumer sleeps for 100 usec.
- no differentiation between queues, in terms of notification features
2021-05-24 17:24:12 +02:00
Francisco
2d6a878826
change interface to create multiqueue queues
2021-05-24 17:24:12 +02:00
Francisco
f705735093
optimization - only allow some multiqueue queues to notify the multiqueue consumer of the arrival of tasks
2021-05-24 17:24:12 +02:00
Ismael Gomez
8414b2c2c9
Define iszero in csv_stdout
2021-05-22 16:59:27 +02:00
Ismael Gomez
5a2a435710
Improve srsENB output metrics
2021-05-22 16:59:27 +02:00
yagoda
9501283c1c
fixing support for extended Cyclic Prefix
...
small cosmetic fixes of CP code
2021-05-20 18:16:15 +02:00
yagoda
f90f6f0c7e
adding MAC 0 padding support
2021-05-20 10:26:50 +02:00
Francisco
52ef23f40e
fix sched benchmark test
2021-05-19 13:11:39 +01:00
Francisco
a83c0ebe3b
increase starting CFI when subframe contains control allocations (e.g. SIB or RAR) when cell bandwidth <= 5 MHz
2021-05-19 13:11:39 +01:00
Francisco
0a1ae0e4ad
redesign and fix enb rrc message logs
2021-05-19 12:42:41 +01:00
Francisco
8d30c88330
bugfix - avoid calling rlf release timer handler concurrently
2021-05-19 12:17:40 +01:00
Francisco
f0f99c1e4f
update sched benchmark, created unit test to cover rbg search algorithms, improved algorithms to search for empty rbgs
2021-05-19 11:43:39 +01:00
Francisco
22f1f2d56c
move ngap files into their own folders
2021-05-17 15:32:57 +01:00
Francisco
1488606156
refactor - create s1ap dedicated folder
2021-05-17 15:32:57 +01:00
Francisco
0e0835a805
move scheduler rbg/prb/cce mask and interval types and associated helper functions to a separate file
2021-05-17 14:30:23 +01:00
Francisco
7c0649bc24
delete erab if gtpu tunnel creation failed
2021-05-17 15:17:27 +02:00
Francisco
c6d543efdf
fix conversions of drb id to erab id in srsenb
2021-05-17 15:17:27 +02:00
Andre Puschmann
167200f5cd
rrc_bearer_cfg: replace fixed E-RAB to DRB mapping
...
also make sure we don't assign LCIDs beyond the possible
number.
possible fix for https://github.com/srsran/srsRAN/issues/658
Co-authored-by: herlesupreeth <herlesupreeth@gmail.com>
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
2021-05-17 15:17:27 +02:00
Francisco
fa34aaa16e
ensure the DL mask count is reduced enough to fit required bytes
2021-05-14 19:58:03 +01:00
Francisco
4d3ff0d139
implementation of basic search for optimal rbgmask for subband CQI
2021-05-14 19:58:03 +01:00
Francisco
f8b6eae2bf
use of min DL cqi across all PRBS to compute required DL PRBs
2021-05-14 19:58:03 +01:00
Francisco
8564996eaf
fix sched_dl_cqi method to compute cqi-optimal rbgmask
2021-05-14 19:58:03 +01:00
Francisco
485c6ee129
subband CQI feature - add K parameter in sched_interface::ue_cfg_t and update it from RRC
2021-05-14 19:58:03 +01:00
Francisco
84ad6dd8ee
Integrated new sched_dl_cqi class in sched_ue_cell
...
- extend sched_dl_cqi interface to allow getting tti when cqi was last updated
- extend sched_dl_cqi to quickly get average cqi across the whole bandwidth
2021-05-14 19:58:03 +01:00
Francisco
16d05ff042
Remove time exponential averaging of DL cqi
...
- renaming: sched_cqi -> sched_dl_cqi
- testing: add unit test for sched_dl_cqi wideband cqi mode.
- feature: remove time exponential averaging of dl cqi
2021-05-14 19:58:03 +01:00
Francisco
28c24a89ef
sched subband cqi - create method to get cqi-optimal RBG mask
2021-05-14 19:58:03 +01:00
Francisco
eeb8ad6571
sched,feature - creation of sched_cqi class to manage the update of CQI in a subband CQI setting
2021-05-14 19:58:03 +01:00
Francisco
f25dbea4de
fix PCCH assembly in srsenb rrc
2021-05-14 19:57:52 +01:00
Xavier Arteaga
af2f37d8ca
SRSENB: CFI protection for all CC and fix test
2021-05-13 07:56:08 +02:00
Francisco
96ab16f1c7
s1ap fix - release old rnti (instead of new one) when a new rnti with the same tmsi is found. Furthermore, we now make sure to warn log if the enb is unable to release the old rnti
2021-05-12 18:55:10 +01:00
Francisco
6ed617f429
s1ap, bugfix - check if MME-UE-S1AP-ID has been yet assigned before sending UL NAS Transport. If it hasn't log error and abort.
2021-05-12 16:20:44 +01:00
Francisco
32228389a9
fix latest static analysis warnings in rrc paging
2021-05-11 21:14:47 +01:00
Francisco
bfdb0332db
remove undefined methods from rrc_ue
2021-05-11 16:54:14 +01:00
Francisco
46cfdaf9e5
Handle case when old rnti gets removed during RRC reestablishment
...
This is achieved via:
- keep restarting the inactivity timer whenever a ReestablishmentRequest is received
- in case the RRC ReestablishmentComplete is very late and the old rnti was removed anyway,
abort RRC reestablishment procedure and release new rnti
2021-05-11 16:54:14 +01:00
Andre Puschmann
b2825d1280
mac_controller: after maxRetx disable ALL UE bearers
...
the reasoning here is that the only way to recover
from the maxRetx event is the UE attempting a reestablishment.
No further traffic, neither control nor data is scheduled
until then.
2021-05-10 18:43:37 +02:00
Andre Puschmann
b61be7878a
enb,rrc: split RLF counter and timer handling for DL/UL/RLC
...
this patch splits the counter and timer handling for PHY DL, PHY UL,
and RLC errors and makes sure that, for example, a successful DL
does not cancel the UL RLF timer, and vice versa.
They all use the same timeout value which is user-configurable.
2021-05-10 18:43:37 +02:00
David Rupprecht
f9c0009d23
Remove setup erabs function
2021-05-10 17:54:38 +02:00
Francisco
0d800eb8f6
stack, multiqueue - bugfix for multiqueue destruction, and addition of unit test
2021-05-10 15:27:21 +01:00
Francisco
ef9d1b8c13
stack optimization - reduction of contention in multiqueue class
...
With the new design, each queue created in the multiqueue object has its own mutex.
Pushing tasks to separate queues will, therefore, not cause contention.
There will be, however, still contention between the popping thread and the pushing threads.
2021-05-10 15:27:21 +01:00
Francisco
b54bb35343
use rnti_map_t in scheduler
2021-05-07 10:58:04 +01:00
Francisco
6b84754ede
fix rrc and gtpu bearer rnti update during reestablishment. The rnti of UE's rrc_bearer_handler was not being updated
2021-05-07 10:58:04 +01:00
Francisco
1677abce8d
create typedef for circular map of rntis. check return of gtpu ue creation
2021-05-07 10:58:04 +01:00
Francisco
9464f36714
make eNB UE release timer after RLF detection configurable
2021-05-07 09:51:59 +01:00
Ismael Gomez
0b91598e36
Move mlockall() to main() in srsUE and srsENB
2021-05-06 23:03:57 +02:00
Francisco
46bd8845ba
fix gtpu bearer removal during handover
2021-05-06 18:10:31 +01:00
Francisco
7c2e841eb4
gtpu bugfix - call gtpu rem bearer when erab is removed
2021-05-06 18:10:31 +01:00
Francisco
c5396155ad
set default gtpu tunnel close timeout to infinity
2021-05-06 18:07:20 +01:00
Francisco
15484e9472
rrc - make t304 configurable via rr.conf
2021-05-06 18:07:20 +01:00
Francisco
c6b9c12ba2
gtpu, feature - added the ability to configure gtpu indirect tunnel timeout value. This parameter is useful in the case that the end marker is not received
2021-05-06 18:07:20 +01:00
Francisco
b619a2b649
application of new cache allocator to deques in scheduler
2021-05-06 18:06:10 +01:00
David Rupprecht
c117b563c9
Initial commit for ngap in enb
2021-05-05 13:54:57 +02:00
David Rupprecht
3284143b39
Capture false encoded messages before sending
2021-05-04 21:38:06 +02:00
Francisco
7bee75e126
update description of srsenb --expert.nof_prealloc_ues config parameter, and added a comment in header file explaining the use of such parameter.
2021-05-04 17:52:47 +01:00
Francisco
5818488b27
change enb max_nof_ues config parameter to nof_prealloc_ues
2021-05-04 17:52:47 +01:00
Francisco
9739a9de5f
add missing srsenb expert parameter to enb.conf.example
2021-05-04 17:52:47 +01:00
Francisco
04ded030ea
srsenb,bugfix - avoid logging error message when UE sends CRNTI MAC CE for old rnti whose context has already been erased.
2021-05-03 21:43:48 +01:00
Francisco
d175bb281b
avoid error logging during handover if EIA0 has been chosen
2021-05-03 17:58:24 +01:00
Francisco
051530177e
feature - support eia0 during S1 Handover
2021-05-03 17:58:24 +01:00
Francisco
a43dd68d57
update comment, explaining the reasoning behind setting a lower bound for allocated UL grants
2021-05-03 17:43:41 +01:00
Francisco
f7016633d2
sched, fix - avoid tpc commands when target pusch and pucch snr are not specified
2021-05-03 17:43:41 +01:00
Francisco
c69631462b
sched, fix - limit UL cqi update to PUSCH SNR reports
2021-05-03 17:43:41 +01:00
Francisco
d3c51fdad4
limit minimum UL grant size to accommodate both BSR and RLC headers
2021-05-03 17:43:41 +01:00
Francisco
cde61a5796
rrc paging - reduce the space taken by paging manager class
...
Paging messages can only be transmitted in a subset of subframes - {0, 4, 5, 9}
I avoid now creating objects for the subframes that are not part of this subset
2021-05-03 15:58:21 +01:00
Francisco
b014cbfe0f
rrc paging - removal of redundant mutexes in paging manager class. Now mutexes are indexed by subframe index instead of paging buffer index
2021-05-03 15:58:21 +01:00
Francisco
8487c10956
removal of unused variables
2021-05-03 15:58:21 +01:00
Francisco
01eace2631
rrc paging mechanism improvements
...
- moved paging record handling to separate class
- parallel access to pending pcch messages by phy workers based on TTI and without common lock
- asn1 pcch message packing now takes place in stack thread, to avoid real-time issues
2021-05-03 15:58:21 +01:00
Andre Puschmann
598594c51a
all: bunch of pass by const& changes suggested by LGTM
2021-04-29 10:00:09 +02:00
Francisco
70d6e4d9b3
mac, fix - Verify that mac::ue also exists in the scheduler before attempting to retrieve its metrics
2021-04-28 00:02:06 +01:00
Francisco
6e7d992552
remove UE on S1AP Release Request if MME S1AP UE ID hasn't been assigned yet
2021-04-27 19:14:25 +01:00
Xavier Arteaga
6045998909
enb_phy_test uses default rr configuration
2021-04-27 16:55:51 +02:00
Francisco Paisana
d39183419c
Separate TPC PUSCH and PUCCH target SINR ( #2740 )
...
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
2021-04-27 10:12:40 +01:00
Francisco
86dac9c823
several coverity high and medium impact fixes
2021-04-27 10:11:03 +01:00
Andre Puschmann
20575d3eec
phy,enb: only initialize NR workers if needed
...
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
2021-04-26 09:43:58 +02:00
Andre Puschmann
ff53d2b8b8
all: set of trivial changes reported by LGTM
...
mainly fixmes, unused/empty code, etc.
2021-04-25 21:03:53 +02:00
AlaiaL
d88760f099
Fixes coverity 366620
2021-04-23 21:22:06 +02:00
AlaiaL
beaa1b3e24
Fixes coverity 369569
2021-04-23 21:22:06 +02:00
AlaiaL
82788ca094
Fixed issues from coverity:
...
- 370233
- 370234
- 370239
- 370240
- 370241
- 370242
- 370243
- 370295
2021-04-23 21:22:06 +02:00
herlesupreeth
0f06ec0d9c
Add feature to provide custom GTP-U (S1) address to be advertised inside S1AP messages
...
This feature is useful in scenarios where eNB is behind a NAT and EPC on public cloud
Since eNB's GTP-U can only bind to IP address visible in it's host (usually a private IP beind a NAT), it advertises the same to UE in S1AP message
resulting in traffic from EPC to eNB (DL traffic) not able to reach eNB. This commit solves this issue by providing a means to advertise a different IP address than the one GTP-U UDP socket is bound to.
This IP is usually advertised in InitialContextSetupResponse and E-RABSetupResponse.
In order to make use of this feature, use the following parameter in enb.conf
Example:
gtp_advertise_addr = 213.61.141.82
2021-04-23 20:31:36 +02:00
faluco
cd1c6732f7
Remove the creation of strings when preparing the contents of a log entry in sched_helpers.
2021-04-22 12:38:14 +02:00
Francisco
ff3fc0826b
asn1 fixes and improvements
...
- use const char* instead of std::string in enumerated<>::to_string() to avoid mallocs.
- Remove the use of "typedef", and use "using" keyword instead.
- Fix rrc_nr::setup_release_c<>::to_string() broken linkage.
2021-04-22 10:21:08 +01:00
Francisco
42e7fc656b
s1ap fix - send S1AP UEContextRelease when the UE does a new RRC connection setup with the same TMSI
2021-04-21 16:49:36 +01:00
faluco
69726bc939
Remove two allocs in the prio queues in sched_time_pf.
2021-04-21 15:05:48 +02:00
faluco
7df308c756
Remove two mallocs in the stack:
...
1) Extend the small buffer to 64bytes for the move_callback class.
2) Replace a std::map for a fixed size circular map in sched_time_pf.
2021-04-21 15:05:48 +02:00
Xavier Arteaga
407903e0d6
SRSUE: refactor carrier setting for accepting a dynamic carrier configuration
2021-04-20 21:50:10 +02:00
Xavier Arteaga
1a4de831e9
Ammended eNb PHY tests
2021-04-20 19:12:46 +01:00
Francisco
d1b336101f
revert enb phy tests. Check that when nof_carriers==6 the phy fails to start and reports an error.
2021-04-20 19:12:46 +01:00
Francisco
6137e4569b
fix srsran_assert definition when asserts are disabled
2021-04-20 14:01:05 +01:00
Francisco
3b78bf3730
bugfix - fix memcheck warnings. move instructions with side effects outside of asserts
2021-04-20 14:01:05 +01:00
David Rupprecht
a064e85c54
rename common lte header
2021-04-19 22:23:59 +02:00
David Rupprecht
81ad72b0ff
Refactor srb and drb handling
2021-04-19 22:23:59 +02:00
David Rupprecht
6b41ae7e8b
Updated PDCP config struct for rat type
2021-04-19 22:23:59 +02:00
Francisco
8ed8b94ca5
in search for contiguous prb interval, skip already scanned prbs
2021-04-19 13:31:20 +01:00
Francisco
22024ac35d
implemented bounded_bitset::find_lowest(...) for both reverse and non-reverse bit ordering. Applied this method to UL scheduling search for PRB intervals
2021-04-19 13:31:20 +01:00
David Rupprecht
f42d4dbc28
Refactored carrier config
2021-04-19 12:13:37 +02:00
Francisco
52bf973981
s1ap - set cause to transport when gtpu fails to allocate TEID
2021-04-17 13:06:19 +01:00
Francisco
791b8d24ce
fix regression in scell activation during intraenb handover
2021-04-16 12:17:41 +01:00
Ismael Gomez
77b11b82ac
Release UE if no activity in DRB ( #2658 )
...
* Count user activity with DRB only and SRBs for initial procedures. Add counter to release user after max KO in UL.
2021-04-15 19:13:01 +02:00
Francisco
4838cd2f5e
implement cell measurement bandwidth feature
2021-04-15 17:48:18 +01:00
Francisco
14d32db92f
implement Handover direct forwarding path availability configuration feature
2021-04-15 17:48:18 +01:00
Francisco
4b9e59e8cf
fix some s1ap msg causes
2021-04-15 17:48:18 +01:00
Francisco
b8fa1d1b61
fix rrc mobility test
2021-04-15 09:45:31 +01:00
Francisco
66988ffd32
s1ap - simplified erab setup procedure. Handle correctly the failure to setup causes
2021-04-15 09:45:31 +01:00
Francisco
f401683960
s1ap - simplified erab modify procedure
2021-04-15 09:45:31 +01:00
Francisco
76978f0d14
s1ap - simplified erab release procedure
2021-04-15 09:45:31 +01:00
Francisco
c5fc543516
s1ap - handling of ts1 reloc overall timer.
2021-04-15 09:45:31 +01:00
Xavier Arteaga
7823bfc28c
Fix append NR to loggers for NR components
2021-04-14 08:16:44 +02:00
Francisco
c2a99a8112
handover - support for handover cancellation causes, check for E-RAB QoS requirements, cancellation of handover if E-RABs are not supported in the target eNB
2021-04-13 21:23:13 +01:00
Francisco
f79e0fade8
handover - set handover required cause to handover desirable for radio reason
2021-04-13 21:23:13 +01:00
Francisco
6d401bc79f
handover - check if UE integrity and encryption algorithms are supported in the target eNB, and report handover failure if not.
2021-04-13 21:23:13 +01:00
faluco
9b634218be
Pre allocate some vectors members in the scheduler.
2021-04-13 21:22:44 +01:00
Francisco
77bd500312
handover - implement and test S1 Handover fail path for the case of invalid QoS config in HO Request message
2021-04-13 09:30:40 +01:00
Francisco
d2c404b166
handover - setup s1ap cause in case of handover failure at the target enb
2021-04-13 09:30:40 +01:00
Francisco
49bd895e29
s1ap - handle invalid or repeated erab ids in s1ap erab release command
2021-04-12 22:07:26 +01:00
Francisco
7842e3bff3
s1ap - add unit test to check correct handling of invalid E-RAB ids in modification request. Fix s1ap in order for the test to pass
2021-04-12 22:07:26 +01:00
Francisco
985846e3bd
s1ap - set multiple erab ids cause in replay when s1ap erab modify request has repeated ids.
2021-04-12 22:07:26 +01:00
Francisco
bc16c46ffc
detect and handle repeated ERAB IDs in S1AP ERAB Modify Request message
2021-04-12 22:07:26 +01:00
Andre Puschmann
c9da21c9bb
mac_nr: add error handling when unpacking SCH MAC PDU
...
* only handle PDU if unpacking was successfull
* add TC unpacking with malformed PDU
2021-04-12 18:26:31 +02:00
Francisco
685c971dc2
fix recursive call to get rb name
2021-04-12 13:21:43 +01:00
Francisco
f7a8b8bf94
separate drb srb ids into separate enum types
2021-04-12 13:21:43 +01:00
Francisco
3a23546c56
fix pdcp_nr.cc compilation
2021-04-12 13:21:43 +01:00
Francisco
21718af3b6
avoid allocating std::string to get lcid radio bearer name. Refactored the lte radio bearer enum type
2021-04-12 13:21:43 +01:00
Francisco
99b4595b69
fix enb phy test by limiting the number of carriers to 5
2021-04-09 15:38:07 +01:00
Francisco
d142d7b6a5
update test helpers for enb, so that the rrc tests pass
2021-04-09 12:54:22 +01:00
Francisco
ac7cc3c42d
change enb ue softbuffer initial allocation size
2021-04-09 12:54:22 +01:00
Francisco
75e9700de0
rlc - usage of memory pool to allocate RLC bearers
2021-04-09 12:54:22 +01:00
Francisco
8fe27a72d0
enb - decreased default enb.conf mac.max_nof_ues to 8 to avoid large memory pool preallocations
2021-04-09 12:54:22 +01:00
Francisco
71f1f1b556
enb - log warning when rnti-specific memory block is full
2021-04-09 12:54:22 +01:00
Francisco
a890a22ccd
enb - rnti memory pool now fallbacks to new/delete if rnti-specific memory block is full
2021-04-09 12:54:22 +01:00
Francisco
344bdf3165
allocation of UE rlc and pdcp classes in the ue dedicated memory pool
2021-04-09 12:54:22 +01:00
Francisco
60d5c6df7b
implementation of memory pool with individual memory blocks per UE that get accessed via their rnti
2021-04-09 12:54:22 +01:00
Francisco
9b7060a098
check ptr value before dereferencing
2021-04-08 21:44:42 +01:00
Ismael Gomez
c4069b58af
Call HARQ new tti only for the current PID
2021-04-08 20:24:21 +02:00
Andre Puschmann
cbe7980d7d
enb,mac_controller: apply new MAC config with disabled DRB
...
fix regression in RRC that updated the local MAC config to
disable DRB scheduling after maxRetx, but didn't actually apply the config
2021-04-08 18:19:55 +02:00
Francisco
bb9601c13b
gtpu - fix gptu manager members destruction order
2021-04-07 22:26:42 +01:00
Francisco
b7d4a72ea1
adt - fix circular map clear() and erase(it) functions
2021-04-07 22:26:42 +01:00
Francisco
643c73acee
gtpu - fix removal of gtpu tunnels when rnti is released
2021-04-07 22:26:42 +01:00
Andre Puschmann
7459a65a8e
enb,rrc_ue: remove unused variable
2021-04-07 22:19:08 +02:00
Francisco
d02cc51e33
use mutex or atomic in running flag to signal the interruption of a thread
2021-04-07 16:11:31 +01:00
Xavier Arteaga
49731ab5a1
Initial NR-DCI refactor
...
Added NR DCI 1_1 size
Several DCI NR fixes
2021-04-07 16:57:12 +02:00
Francisco
cdf72248f3
Reimplement batch-based background object/memory pool
...
Main changes:
- addition of pool utilities
- The node size/alignment and batch allocation threshold are now runtime arguments
- object pool and memory pool are not anymore based on the same class.
The object pool cannot use intrusive free list because it would overwrite the object
memory
2021-04-07 12:02:22 +01:00
Francisco
fbeb87c53e
remove unused parameters from mac::ue
2021-04-07 12:02:22 +01:00
Francisco
b004c2024d
integration of object pool in mac::ue for allocation of softbuffers. Definition of common object pool interface class
2021-04-07 12:02:22 +01:00
Francisco
460d7a8f4f
fix memory pool test - placed the pool state into a shared_ptr so that the callbacks still have a valid handle when the pool is destroyed
2021-04-07 12:02:22 +01:00
Francisco
ec3cd9ffea
adt - added background object pool test, and fix existing bugs related to the creation of pools with objects that are too small to be used in free lists
2021-04-07 12:02:22 +01:00
Francisco
d1c5b000dc
adt - creation of pre-initialized object pool, that leverages the background memory pool allocator
2021-04-07 12:02:22 +01:00
Francisco
eb9814837a
fix gtpu test valgrind warning
2021-04-02 17:40:50 +01:00
Francisco
a79ca92020
refactor type storage and pool tests
2021-04-02 17:40:50 +01:00
Francisco
046633674a
refactor - removal of stack-gtpu interface, and use of socket manager interface instead
2021-04-02 11:42:50 +01:00
Francisco
c24e382c19
Refactor of socket manager class
...
- use of inheritance to simplify testing
- removal of global network manager
- pass of custon socket manager to s1ap and gtpu ctors
- overhauled the registration of socket fd,callback in socket manager
2021-04-02 11:42:50 +01:00
Francisco
4aac7ac238
use global rx multisocket handler, and remove stack-s1ap interface
2021-04-02 11:42:50 +01:00
Francisco
39de2efa69
multisocket handler - use blocking socket remove method
2021-04-02 11:42:50 +01:00
Francisco
bf96d897ee
network utils refactor - renaming of socket handle to unique socket and cleanup of its methods
2021-04-02 11:42:50 +01:00
Francisco
aed5c51010
fix bug in cc_used_buffers_map in request_pdu(...)
2021-04-02 11:41:08 +01:00
Francisco
8fda69a3dd
refactor mac::ue cc_used_buffers_map class to use new circular_map container
2021-04-02 11:41:08 +01:00
Pedro Alvarez
696de22a28
Change default maximum number of KOs to 100
2021-04-01 13:21:43 +01:00
Pedro Alvarez
b2b7d8f617
Set rlf_timer timeout once. Make activity timer expiry also stops rlf_timer
2021-04-01 13:21:43 +01:00
Pedro Alvarez
e1a852d4b8
Split split RLF timer and Inactivity timer
2021-04-01 13:21:43 +01:00
Pedro Alvarez
47135cb75b
Changed counting of KOs to RRC
2021-04-01 13:21:43 +01:00
Pedro Alvarez
8194b5ec73
Added check for consequetive KOs in MAC. Change set_activity_user to pass activity and max KOs to RRC and trigger RLF timeout.
2021-04-01 13:21:43 +01:00
Francisco
ec72b310d7
fix mme ue s1ap id initialization
2021-04-01 10:24:34 +01:00
Francisco
23ae9967cf
replaced present+value for optional field in s1ap mme_ue_s1ap_id context field
2021-04-01 10:24:34 +01:00
Francisco
b8f220258d
s1ap - extend s1ap unit test to verify result of passing an invalid mme s1ap ue id
2021-04-01 10:24:34 +01:00
Francisco
c3482b45e1
s1ap - handle erroneous enb/mme s1ap ue id in received s1ap messages from the MME
2021-04-01 10:24:34 +01:00
Francisco
cc369aca1f
sched - handle the case when the CRC is missing and max retx is reached
2021-03-31 20:52:02 +01:00
faluco
67530687e9
Restore RRC release result variable after logging the event.
2021-03-31 19:37:49 +02:00
faluco
54fab314c0
Enhance RRC eNB events:
...
- Implement a common event "log_rrc" for all RRC events and discriminate by procedure using an enum.
- Log events for connection, reestablishment, reconfig, reject and release.
- Log the corresponding ASN1 message used by each procedure.
- Redefine the JSON object for this event to match the new structure.
Fixed a compilation error detected by the static analyzer in gcc9.3 where bounded_vector::data() was using taking the address of the internal buffer which confused it, prefer to use the data method of std::array.
2021-03-31 19:37:49 +02:00
Francisco
d4a223b5b1
s1ap unit test - add correct cause to erab modify response when erab-id is not recognized
2021-03-31 13:31:07 +01:00
Francisco
a68c50a282
s1ap - extend s1ap unit test to setup a full ue connection and modify bearer
2021-03-31 13:31:07 +01:00
Francisco
90bba3b85e
s1ap - set s1 handover cause as s1 intra system handover triggered
2021-03-31 13:31:07 +01:00
Pedro Alvarez
8c7aed1f81
Added handling of MSG3 timout exipiry in activity_timer_expired(). Avoid notifying S1AP in that case.
2021-03-31 11:51:26 +01:00
Pedro Alvarez
37699f2215
Send radio connection with UE lost if max retx are reached
2021-03-31 11:51:26 +01:00
Francisco
d571d26b0a
disable blocking queue in enb::mac when mac::stop() is called. Ignore PRACHs after stop() is called
2021-03-30 18:09:41 +01:00
Francisco
d04a19f8bc
refactor - increase code reuse in adt files
2021-03-29 22:11:25 +01:00
Francisco
5eccfad05b
gtpu - added comments, updated expected construct, handled in rrc the case a gtpu teid fails to allocate
2021-03-29 10:20:55 +01:00
Francisco
82b34f3b3f
gtpu refactor - fix gtpu logging formatting
2021-03-29 10:20:55 +01:00
Francisco
44440cf562
gtpu refactor - use of raii to automatic path switch and teid removal in forwarding. Clean up of gtpu_tunnel_manager methods.
2021-03-29 10:20:55 +01:00
Francisco
ab2bd9a2d2
gtpu refactor - handle dl path state activation internally in gtpu tunnel manager class
2021-03-29 10:20:55 +01:00
Francisco
cfd24f6a0e
gtpu - leverage byte_buffer_pool to store buffered sdus in gtpu
2021-03-29 10:20:55 +01:00
Francisco
bdc5094e17
gtpu - added unit test for gtpu_tunnel_manager class
2021-03-29 10:20:55 +01:00
Francisco
c201eb7708
use of more space efficient sorted vector structure for lcid tunnels of a rnti
2021-03-29 10:20:55 +01:00
Francisco
eba0edea4a
creation of static id obj pool class. Application of this class to gtpu tunnels container to avoid allocations
2021-03-29 10:20:55 +01:00
Francisco
3cf5e85b20
create separate class to handle gtpu tunnel creation/deletion/search
2021-03-29 10:20:55 +01:00
Francisco
099a533573
bugfix - verify that TEID exists before trying to access it
2021-03-29 10:20:55 +01:00
Francisco
e1523692c2
implementation of concurrent fixed size pool that leverages thread local caches to avoid mutexing
2021-03-27 12:21:08 +00:00
Pedro Alvarez
a5229a02d1
Make sure RRC identity is set when NAS reads UE context from file.
2021-03-26 16:36:12 +00:00
Pedro Alvarez
ca7a38a2ba
Remove old context in eNB's RRC if new connection request arrives with the same TMSI
2021-03-26 16:36:12 +00:00
Pedro Alvarez
8e48467a30
Make sure that meas_report_desc is present if ho_active == true in rr.conf
2021-03-26 10:06:38 +00:00
Francisco
1b47bee4c0
handover - avoid halting ho preparation just due to the presence of a handover restriction list or handover request extension field
2021-03-26 00:18:23 +00:00
Francisco
609366afce
change sched buffer state update log level to info for SRBs
2021-03-24 11:21:51 +00:00
AlaiaL
bbaebd1274
Added a warning in the log when the cpu metrics are not registered due
...
to the number cpu cores is greater than supported.
2021-03-24 12:01:12 +01:00
AlaiaL
c9d1c77e8c
- Deleted the magic number of maximum supported cores, now it is a
...
constexpr.
- When the system has more cores that the maximum supported, the cpu
metrics will not be registered.
2021-03-24 12:01:12 +01:00
AlaiaL
6cd9bba641
Added the cpu metrics to the system metrics.
2021-03-24 12:01:12 +01:00
Ismael Gomez
14bfd55fb9
Restore removed function from ue_db
2021-03-24 09:30:28 +01:00
Xavier Arteaga
5bdf2c93b3
Initial NR PDSCH CSI-RS RE skip and other changes
2021-03-24 09:06:26 +01:00
Pedro Alvarez
ea3c3b1d4f
Added some checks for the byte buffer allocation in the GTP-U
2021-03-23 16:40:29 +00:00
Xavier Arteaga
cade7c8104
Removed redundant error traces
2021-03-23 15:11:46 +01:00
Xavier Arteaga
c5bb522f11
SRSENB: Add PHY UE DB return codes
2021-03-23 15:11:46 +01:00
Andre Puschmann
1a0891df51
all: check return value of make_byte_buffer() and handle them safely
2021-03-23 14:31:15 +01:00
Francisco
dd336c53ea
changed srsran_warning to srsran_expect. Applied new macro to rlc am
2021-03-23 10:49:28 +00:00
Francisco
b5692037a2
created macros for assertions and warnings. The assert macro prints the whole callstack on crash. The warning macro can just log a warning or call an assertion fail depending on the cmake flag STOP_ON_WARNING
2021-03-23 10:49:28 +00:00
Francisco
7595dbaa02
avoid blocking call for pop from UE pool in mac ue. change log lines
2021-03-22 14:58:25 +00:00
Francisco
4869b14de3
application of new circular map to mac::ue_db
2021-03-22 14:58:25 +00:00
Codebot
4523ee6087
rename srsLTE to srsRAN
2021-03-21 21:47:01 +01:00
Francisco
df8ec4ddd5
reduce max coderate for SIB allocations
2021-03-19 20:44:08 +00:00
Francisco
638989ec4d
sched - limit max coderate (via an assumed low cqi) for sib and rar allocations
2021-03-19 20:44:08 +00:00
Ismael Gomez
430b7b7b34
Remove unnecessary info
2021-03-19 20:31:34 +00:00
Ismael Gomez
8d2197e751
Increase MAC UE circular buffer
2021-03-19 20:31:34 +00:00
Francisco
2054ad3f3c
eliminate old BFS-based PDCCH allocator. Improvement the scheduler speed by ~2x
2021-03-19 16:31:06 +00:00
Francisco
6bec92fbc9
using new DFS-based PDCCH allocator as a default
2021-03-19 16:31:06 +00:00
Francisco
8347cabe4f
implemented a DFS-based PDCCH allocator
2021-03-19 16:31:06 +00:00
Francisco
a2e2501424
avoid disabling SRBs in the eNB when the max retx reached signal is sent from the RLC to the RRC
2021-03-19 13:44:28 +00:00
Francisco
a540c56552
gtpu bugfix - avoid erasing indirect tunnel and causing iterator invalidation while iterating list of tunnels
2021-03-19 13:43:21 +00:00
Francisco
977c194cbc
gtpu,bugfix - handle the case when gtpu fails to allocate buffer for end marker. Also, added a timer that when expired, it autoremoves the GTPU handover tunnel
2021-03-19 13:43:21 +00:00
Pedro Alvarez
dde8157bf1
Make sure that S1 Setup request is restarted regardless of which error made the procedure fail.
2021-03-19 10:48:45 +00:00
Francisco
d646111aa9
refactor sched dci unit test
2021-03-18 17:04:45 +00:00
Francisco
d6bae76698
extend cch allocation unit tests to verify optimal cfi and DCI position selection for 6 PRBs
2021-03-18 17:04:45 +00:00
Francisco
d5750f6fe6
refactor - update of clang-tidy project file. automatic clang-tidy refactors
2021-03-18 17:04:45 +00:00
Francisco
fb48f4484c
sched refactor - removal or cleanup of unused sched methods
2021-03-18 17:04:45 +00:00
Francisco
137a21d6b2
sched refactor - use simple enum to represent allocation result. Refactored logging messages when allocation fails.
2021-03-18 17:04:45 +00:00
Francisco
0d91802495
sched optimization - swap c-arrays for bounded_vector in sched_interface to reduce time performing bzero/memcpy in the scheduler
2021-03-17 19:54:44 +00:00
Francisco
c0a90c5aa8
refactored sf result resetting to avoid realloc of memory
2021-03-17 19:54:44 +00:00
faluco
875773556e
Fixed a formatting error in a sched entry.
2021-03-17 16:22:19 +01:00
Francisco
1d4e83473e
remove check that verifies that SRB0 is always activated in the scheduler.
2021-03-17 14:55:14 +01:00
Francisco
c3a4cb37f4
extension of sched benchmark test to allow different testing modes - test rates, benchmark, test different combinations of sched parameters
2021-03-17 12:12:36 +00:00
Francisco
ac4d058fbf
correct verification of sched rates in sched benchmark test
2021-03-17 12:12:36 +00:00
Francisco
d334907afe
sched - wrote benchmark to detect regressions in DL/UL data rates, and to analyse the total latency of the scheduler
2021-03-17 12:12:36 +00:00
Francisco
248f05bf08
sched,bugfix - fix optimal cfi computation for sib/rar allocations
2021-03-16 19:27:25 +00:00
Francisco
19a043683c
bugfix - fix compilation issue in gcc10. The interfaces don't have virtual dtors
2021-03-16 19:27:25 +00:00
Francisco
544fe03db3
sched,optimization - considering that cfi is static for sib/rar allocations, pick from the start of the tti, the optimal CFI in terms of largest number of CCE positions available
2021-03-16 19:27:25 +00:00
Francisco
d0672d03fb
bugfix - mac logger was being fetched before a sink was assigned, leading to it printing to the console
2021-03-16 19:27:25 +00:00
Francisco
884c1b04d2
sched,test - add test to verify cch allocator ability to undo last allocation
2021-03-16 19:27:25 +00:00
Francisco
377831da90
bugfix,minor - remove reset of ue cfg during handover
2021-03-16 19:27:25 +00:00
Francisco
1f35c4dc8b
sched, feature enhancement, bugfix - allow RAR DL grants with variable PRB size
...
Some bug fixes had to be solved:
- the cfi cannot be dynamic once we set a SIB/paging/RAR allocation. This is too avoid effective coderate to exceed its maximum
- the previous bugfix required adding the feature to cancel the last PDCCH+PDSCH allocation
2021-03-16 19:27:25 +00:00
Francisco
47f1175502
[sched, feature enhancement] - allow variable nof prbs allocated per SIB / Paging message
2021-03-16 19:27:25 +00:00
Francisco
76103065f7
collapse the 2-stage DCI generation process of SIB/Paging/RAR into one single stage in the scheduler.
2021-03-16 19:27:25 +00:00
Francisco
3a4ae3d69d
extended broadcast+RAR DCI encoding scheduler tests
2021-03-16 19:27:25 +00:00
Francisco
9601770196
rrc,bugfix - stop scheduling when RLC AM max_retx is achieved
2021-03-15 21:42:47 +01:00
Francisco
16b5e1fd4d
fix collision detection of n1pucch for the ACK and SR in the scheduler
2021-03-12 20:07:32 +00:00
Francisco
64e8a17ea8
mac,bugfix - fix incorrect deallocation of PDU
2021-03-12 19:10:15 +00:00
Francisco
6feb311e17
remove instantiations of move-constructors and move assignment operators from cc_buffer_handler
2021-03-12 19:10:15 +00:00
Francisco
ca7fe1349e
remove unnecessary sfinae from bounded_vector. Use bounded_vector for UE cc buffers. Set ue cc used buffers remove_pdu method to private
2021-03-12 19:10:15 +00:00
Francisco
196bf710c0
fix compilation issue in mac::ue
2021-03-12 19:10:15 +00:00
Francisco
d27e0be609
created special class to manage mac::ue currently allocated rx UL buffers. This class avoids mallocs
2021-03-12 19:10:15 +00:00
Ismael Gomez
7b33c48fe7
Use static queue in pdu_queue
2021-03-12 19:10:15 +00:00
Pedro Alvarez
611c5e9814
Fix RRC tx in eNB to only send messages with NAS on SRB2
2021-03-12 15:42:28 +00:00
Francisco
6159cb3817
add assert to ensure a valid ptr is passed to memory pool deallocator
2021-03-12 01:33:44 +00:00
Francisco
20928651c7
created batch allocator that leverages background worker pool
2021-03-12 01:33:44 +00:00
Francisco
d41b6187c1
bugfix - remove extra \n from logging calls
2021-03-11 20:10:54 +00:00
Francisco
31b03fdd8a
fix scheduler UL harq reset for msg3 case
2021-03-11 20:10:54 +00:00
Francisco
3e9f93eb8a
refactor - remove old log_filter and logmap libraries from the codebase
2021-03-11 20:10:54 +00:00
Francisco
770021e364
remove uneeded formatting and std::string creation/allocation in scheduler
2021-03-11 15:18:16 +00:00
Francisco
fbbbf7886c
sched,bugfix - reset harq used for msg3 correctly
2021-03-10 22:42:39 +00:00
Francisco
d1483dc0f8
sched,bugfix - fix bitmask formatting. fix msg3 adaptive retx pdcch allocation
2021-03-10 22:42:39 +00:00
yagoda
62b3615268
fixing sched config parameters
2021-03-10 19:03:39 +00:00
Francisco
837c5bdce5
clang tidy update. applied small fixes to warnings from clang-tidy
2021-03-10 16:18:55 +00:00
faluco
173dcdd421
- Import latest srslog version.
...
- Remove string allocs in some log lines in radio.cc.
Add new tracing buffer capcity options into srsenb and srsue.
Add missing file.
2021-03-10 16:27:33 +01:00
faluco
60cd649b8f
Add a short description of the tracing options inside the config files.
2021-03-10 11:59:09 +01:00
faluco
c7542daf43
Remove rlc traces and add new ones into tti run functions both in the enb and ue.
2021-03-10 11:59:09 +01:00
faluco
2b990e195c
Allow specifying a custom filename for event tracing.
2021-03-10 11:59:09 +01:00
faluco
d805ce01a6
- Add a flag in the enb confi file to control tracing.
2021-03-10 11:59:09 +01:00
faluco
82db6544fb
Add instrumentation points to rlc_am_lte::rlc_am_lte_tx::handle_control_pdu using srslog.
2021-03-10 11:59:09 +01:00
Andre Puschmann
20cbc48f90
rlc_am_lte: refactor PDCP/RLC interface to use fix sized data structure
...
this patch replaces the std::vector type used in the interface between
PDCP and RLC to signal delivery status between both layers. The new
data type is a configurable but fixed-size vector.
The RLC AM doesn't need to dynamically allocate the vector for every SN but
uses the tx_window for storage.
2021-03-09 21:56:33 +01:00
Pedro Alvarez
bea78512e5
Make sure the eNB exits with error when some invalid configs are provided
2021-03-09 19:45:30 +00:00
Francisco
4969c98665
gtpu,bugfix - fixed formatting of addresses in GTPU
2021-03-09 16:23:08 +00:00
Francisco
20e341d0a1
mac,bugfix - fixed formatting of MAC and scheduler user-defined types
2021-03-09 16:23:08 +00:00
Francisco
5a1bf28fe1
optimization - minimization of number of std::string allocations for logging
2021-03-09 16:23:08 +00:00
Francisco
d77b6e1d9c
sched,optimization,refactor - use of custom formatter that avoids mallocs for getting bitmasks strings in hex and binary formats
2021-03-09 16:23:08 +00:00
Francisco
f0ed1e06a8
documentation,bugfix - added documentation to new blocking queues, changed class names, and removed blocking pushes from the critical path
2021-03-08 14:49:14 +01:00
Francisco
d1236fd62f
stack,optimization - replaced previous block_queue design for new bounded queue in several places in the enb
2021-03-08 14:49:14 +01:00
Francisco
b869b0d8e2
sched,bugfix&refactor: set dci_format before generating the remaining dci parameters in sched_ue::generate_dl_dci_format(...)
2021-03-06 21:27:52 +01:00
Francisco
77ac69796d
sched,bug: change tbs/mcs derivation functions to forbid the use of alt cqi table for DCI format1A
2021-03-06 21:27:52 +01:00
Francisco
b79d09e83f
remove commented code from sched dci test
2021-03-06 20:49:05 +01:00
Francisco
fb04fdbe69
sched,bugfix - fix mcs/tbs computation for 256-QAM.
2021-03-06 20:49:05 +01:00
Francisco
f79f3ca56f
change default sib and rr conf PUCCH-specific default values to decrease the size of PUCCH
2021-03-05 14:59:44 +01:00
Francisco
c53778134f
config mac pucch parameters from RRC
2021-03-05 14:59:44 +01:00
Francisco
9eeddcec5f
disabled prach vs pucch collision detection temporarily until enb cfg files are updated in the rfci
2021-03-05 14:59:44 +01:00
Francisco
cf7661e10f
perform small pusch allocation in case no space can be found in the PUCCH for ACK
2021-03-05 14:59:44 +01:00
Francisco
102cb196e1
Addition of enb cfg option to choose between PUCCH with multiplexing and without. Change default prach offset to 4.
...
- The new prach offset of 4 accounts for the size of the PUCCH-ACK region with 100 prbs
2021-03-05 14:59:44 +01:00
Francisco
34e39a9835
Implementation of scheduler algorithm to avoid PUCCH collisions
...
- The cch_allocator considers the existence of a fixed PUCCH region dedicated to CQI, SR, and HARQ ACKs
- At the moment PUCCH multiplexing is not considered
- The PUCCH width was increased to accommodate possible PUCCH-ACK positions
2021-03-05 14:59:44 +01:00
Francisco
8ae8b31ba2
Allow collisions between PUCCH and Msg3 for 6 PRBs
...
- The UL Harq now stores the type of UL alloc (msg3 or data)
2021-03-05 14:59:44 +01:00
Francisco
39aea96c69
fix sched tests UL HARQs. Set common pucch cfg in the sched tests
2021-03-05 14:59:44 +01:00
Francisco
7dcfe7bf0e
sched: updated tbs calculation test. Fix edge cases that failed the test.
2021-03-04 23:40:35 +01:00
Francisco
ed8ab3871c
re-designed algorithm to compute lowest mcs that meets cqi,req_bytes,nof_prbs requirements in the scheduler
2021-03-04 23:40:35 +01:00
Francisco
3dd7877199
wrote unit test to check tbs,mcs derivation based on cqi,nof_prb in scheduler
2021-03-04 23:40:35 +01:00
Francisco
9748c0be84
simplified tbs/mcs computation in scheduler
2021-03-04 23:40:35 +01:00
David Rupprecht
5285550880
Fixes write SIB pcap define flag back to normal
2021-03-03 22:59:23 +01:00
Francisco
d54cef63b2
avoid reallocating CC in mac::ue when an SCell Activation CE is sent
2021-03-03 16:49:15 +01:00
David Rupprecht
aef6805d03
Added pcap net feature to eNodeB
2021-03-03 09:50:15 +01:00
David Rupprecht
5a95cbdfae
Disable rat assignment in pcap class
2021-03-03 09:50:15 +01:00
Pedro Alvarez
3f4cf0a91f
Fix setting last_submitted_rx_sn in HO
2021-03-02 22:44:59 +01:00
AlaiaL
13fdbd9e0f
[metrics] Fixed csv header for srsenb
2021-03-02 22:17:13 +01:00
AlaiaL
b1483802a2
[metrics] restoring metrics_stdout for enb and ue
2021-03-02 22:17:13 +01:00
AlaiaL
d518a625cc
[metrics] Added the system metrics to the csv
2021-03-02 22:17:13 +01:00
AlaiaL
0ba7cd7df9
[metrics] Added system metrics to the enb's stdout
2021-03-02 22:17:13 +01:00
Francisco
c03dbc6742
fix RRC Connection Reestablishment procedure - correctly save old rnti bearer configuration in new rnti
2021-03-02 17:51:36 +01:00
Francisco
290f39d805
fix crnti mac ce handling in the rrc in normal (no handover) case
2021-03-02 17:14:17 +01:00
Francisco
a72a659fdf
fix timers interface to avoid accessing to a timer after its release. fix gtpu tunnel activation during s1 handover
2021-03-01 23:20:07 +01:00
Francisco
023cb0fdde
log on allocation failure in mac::ue class
2021-03-01 20:10:57 +01:00
Francisco
beed2ddbaa
simplified tx softbuffer acquisition interface in mac::ue
2021-03-01 20:10:57 +01:00
Francisco
e0da736a5f
fix memory management of softbuffers in mac::ue class
2021-03-01 20:10:57 +01:00
Francisco
02539344fb
move rx used buffers of mac::ue to separate cc buffer handler class
2021-03-01 20:10:57 +01:00
Francisco
cc6c9ffc51
move tx/rx softbuffers of mac::ue to separate cc buffer handler class
2021-03-01 20:10:57 +01:00
Francisco
2f95862932
move tx payload buffers of mac::ue to separate cc buffer handler class
2021-03-01 20:10:57 +01:00
Francisco
9eb46cc134
fixed clang tidy warnings in mac::ue.cc
2021-03-01 20:10:57 +01:00
Ismael Gomez
4bcb7564c1
Incorrect return value in scheduler call cases user activity to not terminate
2021-03-01 18:03:14 +01:00
Xavier Arteaga
1e55d68b55
Removed set RNTI from API
2021-03-01 15:30:33 +01:00
Francisco
4b09507c19
remove srslte.h includes from upper layers
2021-02-26 16:44:57 +01:00
Francisco
b329e25bbb
move ue phy interfaces to separate interfaces header file
2021-02-26 16:44:57 +01:00
Francisco
13d805ef56
move ue rrc interfaces to separate interfaces header file
2021-02-26 16:44:57 +01:00
Francisco
b8bd869d0f
move ue rlc interfaces to separate interfaces header file
2021-02-26 16:44:57 +01:00
Francisco
a988351f46
move ue pdcp interfaces to separate interfaces header file
2021-02-26 16:44:57 +01:00
Francisco
ea04104e8e
move ue gw interfaces to separate interfaces header file
2021-02-26 16:44:57 +01:00
faluco
2328011732
- Remove old loggers in ttcn3 and in NR.
2021-02-26 13:59:39 +01:00
faluco
3ce7454105
- Remove old loggers from ue_stack_lte, ue gw.
...
- Remove old loggers setting up for these classes.
2021-02-26 13:59:39 +01:00
Andre Puschmann
46d8ed8742
enb,rrc: delay UE release after RLC maxRetx
...
this fixes the eNB behaviour when RLC signals maxRetx reached.
By directly releasing the UE, we ignore the fact that the UE
could still have the reestablishment counters running, so
could attempt a reestablishment, which would result in a reject
because we would have destroyed the UE context too early.
this patch delays the removal of the UE to wait at least
until the reestablishment timers are expired.
2021-02-25 21:31:04 +01:00
Francisco
f610a7b83d
Change background worker pool to become a global variable
...
Allocate rrc::ue objects in batches in the background worker pool
2021-02-25 15:56:40 +01:00
Pedro Alvarez
976b5c12c1
Releasing the UE when max retransmissions are reached in the RLC. ( #2385 )
2021-02-24 16:45:40 +00:00
David Rupprecht
f6f6ee406b
SRSUE NR: use correct rnti in rar and make NR proc ra
2021-02-23 17:02:23 +01:00
David Rupprecht
0f1586dd2d
Deleted all HAVE_5GNR in CC and h files
...
CMakeList and travis yaml
2021-02-22 21:16:04 +01:00
Pedro Alvarez
d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms ( #2368 )
...
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU
* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.
* Fix bug in early exit of notify_delivery and notify_failure
* fix compilation issue in rlc-pdcp notification
Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
2021-02-22 10:36:14 +00:00
Francisco
6404722b4b
convert qci_cfg in srsenb to std::map to allow qci values above 10
2021-02-20 23:00:05 +01:00
Francisco
9a9ed01dda
rename pdcch_sched to sf_cch_allocator
2021-02-19 17:34:55 +01:00
Pedro Alvarez
6ecd6e273c
Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover
2021-02-19 13:30:48 +00:00
faluco
5f325b4029
- Calculate the metric time stamp for JSON at the end of the function.
...
- Add a range check when traversing the metric structs.
2021-02-19 09:54:41 +01:00
faluco
613d397d0a
- Dump the PDCP metrics into the JSON file.
...
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
2021-02-19 09:54:41 +01:00
faluco
a940e169a3
Add the enb_cc_idx value to S1 events.
2021-02-19 09:54:41 +01:00
faluco
b750647cd8
- Remove the cause field in the rrc disconnect event.
...
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
2021-02-19 09:54:41 +01:00
faluco
a4605883f0
Implement second revision of the events and metrics document.
2021-02-19 09:54:41 +01:00
Pedro Alvarez
ba5367bc56
Change order which reestablish is called in eNB
...
Make sure that RLC info queue is reset when reestablish happens
2021-02-18 14:51:29 +00:00
Pedro Alvarez
cfd94441a5
Added metrics to srsenb PDCP
2021-02-17 18:40:12 +00:00
Pedro Alvarez
3eab97340b
Fix issue in getting PDCP discard timer from configs
2021-02-17 17:53:03 +00:00
Francisco
9546634b37
use unique_ptr for sched_ue database in scheduler. This will minimize the time spent locking while adding new users
2021-02-17 11:04:07 +01:00
Francisco
faf2adde90
set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn
2021-02-17 11:03:52 +01:00
Pedro Alvarez
c0eb088958
Revert "Sending LastSubmittedRxSN instead of Next_PDCP_RX_SN in status trasnfer."
...
This reverts commit 91a94b546ac6c452508c73812c30cf0cf1384c6f.
2021-02-17 11:03:52 +01:00
Pedro Alvarez
7259f1280a
Sending LastSubmittedRxSN instead of Next_PDCP_RX_SN in status trasnfer.
2021-02-17 11:03:52 +01:00
Francisco
c1adaec038
refactored cce position table structs
2021-02-16 21:22:40 +01:00
Francisco
823da24a8e
removed uneeded sched method to set sched algorithm, and made configured flag atomic
2021-02-16 21:22:40 +01:00
Francisco
6b3cf6c597
moved pdcch sched to separate file
2021-02-16 21:22:40 +01:00
Pedro Alvarez
e0542a4651
Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC.
2021-02-16 13:21:50 +00:00
Pedro Alvarez
b0fe302f8e
Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment.
2021-02-16 13:21:50 +00:00
Pedro Alvarez
89a23cec7e
Added statusReportRequired to the PDCP entity config.
2021-02-16 13:21:50 +00:00
Francisco
a4423ff690
sched: fix compilation issue for gcc4.8
2021-02-16 10:48:58 +01:00
Francisco
a7f4dfab2c
sched: added checks for localized RBG assignment in case of DCI format1A
2021-02-16 10:48:58 +01:00
Francisco Paisana
34d4dc3974
set DCI format 1A while RRC setup/reestablishment/reconfiguration is on-going
2021-02-16 10:48:58 +01:00
Francisco Paisana
929b8650a3
handle byte buffer allocation error in s1ap
2021-02-15 10:49:54 +01:00
Francisco Paisana
c40ad81a90
cleanup s1ap methods. remove hard coded erab list in s1ap handover required message.
2021-02-15 10:49:54 +01:00
Francisco
dc4283c572
added cmake functions as helpers to set labels in ctests
2021-02-12 20:27:31 +01:00
Francisco
23459dee28
Created enb_{rlc/pdcp/gtpu/phy_interfaces.h files.
2021-02-12 16:36:50 +01:00
Francisco
43e57df00b
breaking enb_interfaces.h into multiple files on a layer basis. Created enb_rrc_interfaces.h, enb_mac_interfaces.h and enb_s1ap_interfaces.h
2021-02-12 16:36:50 +01:00
Pedro Alvarez
dd6d6f731d
Passing SN provided by upper layers to PDCP entity. Using it to calculate TX_COUNT if passed.
2021-02-12 11:57:36 +00:00
Pedro Alvarez
fcaaf72187
Starting to add discard functionality to PDCP LTE entity.
...
This includes:
- Adding a queue (implemented with std::map) for undelivered PDUs.
This queue uses the SN used for TX as the key.
- Added discard timer that is started upon reception of the SDU. Upon
expiry of the timeout a discard callback removes undelivered PDUs
from the queue.
- Added the mechanisms to the notify_delivery to remove PDUs from the
undelivered queue when the PDU is ACK'ed.
- Added test case for both timer expiry and acknowledgment.
- Fix up the getter for buffered SDUs to return the undelivered SDUs
- Changed default PDCP discard timer, so AM has a discard timer by
default.
2021-02-11 15:49:00 +00:00
faluco
5c8923123a
Misc compilation fixes from the fapi repo.
2021-02-11 15:38:50 +01:00
faluco
6359a2d948
- Upgrade the gtpu class in lib dir to srslog.
...
- Propagate old log elimination through all the dependencies of gtpu.
2021-02-11 14:37:27 +01:00
faluco
62fcf04083
Ported the all radio classes to use srslog.
2021-02-11 14:23:14 +01:00
Francisco
ddd1f28820
fix uninit memory access in rrc_nr_test
2021-02-11 13:09:06 +00:00
Francisco
4188b5146e
fix uninitialized memory access in gtpu_test and liblte_mme unpacking
2021-02-11 13:09:06 +00:00
Ismael Gomez
77f905dc64
Move TTI to PID mapping to MAC
2021-02-10 21:25:25 +01:00
faluco
9d15a44c73
Port lib/phy to srslog ( #2298 )
...
* - Ported the channel class to srslog.
- Removed all newlines of log messages in lib/phy.
* Remove more newlines that use the C debug macros.
2021-02-10 13:46:25 +01:00
Francisco
3265d940ec
remove byte buffer pool cached member variables as they are unnecessary now.
2021-02-07 18:48:21 +00:00
Francisco
04ab4eefcd
use new make_byte_buffer() helper method to create unique_byte_buffers
2021-02-07 18:48:21 +00:00
Xavier Arteaga
a19671802e
Added SRSUE NR-PUSCH initial procedures
2021-02-05 15:55:03 +01:00
Pedro Alvarez
de90b4753f
Added the ability of the RLC AM to notify the PDCP of the acknowledged
...
PDCP PDUs. This includes:
- Modifying the byte_buffer_t to include PDCP SN meta-data. This way,
the RLC can keep track of the ack'ed bytes for a specific PDCP PDU.
- Added in the RLC an `undelivered_sdu_info queue`, to keep track of the
amount of ack'ed bytes and the total size of the PDCP PDU,
so the RLC can know when delivery is finished.
- Added an interface between the PDCP and the RLC so that the RLC can
notify the PDCP when it receives an ack from the status PDUs. The RLC
passes to the PDCP a vector of all the ack'ed pdus in a rx'ed status PDU.
- Added some tests to the notify functionality. This includes some tests
where the PDUs are acked imediatly, and one test where the PDU is
retx'ed.
2021-02-05 12:24:50 +00:00
David Rupprecht
3dab82c42f
Added interface that allows to update the lcid in case of a nr reconfiguration
...
nr rrc updates gw lcid if reconf was received
2021-02-05 11:08:08 +01:00
faluco
821925a273
- Upgrade to srslog the loggers in lib/mac.
...
- Adapted users of these classes and tests.
2021-02-04 18:37:00 +01:00
AlaiaL
9c764c299d
- Removed the try/catch. Checking the allocation with std::nothrow
...
- Adjusting the code with the coding style.
2021-02-04 15:18:27 +00:00
AlaiaL
f1cd4b1f0d
- fixes crash on initialization. Now the program exits cleanly
2021-02-04 15:18:27 +00:00
Xavier Arteaga
77f0a53abd
Added DCI Format 0_0 unpacking and more NR-PUSCH procedures
2021-02-04 10:51:47 +01:00
Xavier Arteaga
b150e45129
Renamed NR-PHY state and fix license headers
2021-02-04 10:51:47 +01:00
Francisco
c4a50b7de0
avoid loss of pdcp sdus' SNs buffered in gtpu during handover
2021-02-03 17:20:07 +00:00
Francisco
9e25e95545
fix S1AP UE Capability Indication message. Created helper to log received S1AP messages
2021-02-03 17:20:07 +00:00
Francisco
78d1b8083a
fix GTPU tunneling. Avoid forwarding packets to PDCP while the PDCP bearer is not yet created
2021-02-03 17:20:07 +00:00
Andre Puschmann
8e13f04684
mac_pcap: refactor MAC PCAP and include NR RAT into same object
...
after adding the thread-safe PCAP writer functionality to the EUTRA
MAC object it became clear that we don't wont to replicate the
same for the NR object.
This patch therefore refactors the class that now supports both EUTRA and
NR rats. The old mac_nr_pcap.[h/cc] has been deleted. All test-cases
and usages now use the new object that needs to pass the RAT type in
the ctor.
this patch addresses the last open point of #2160
2021-02-03 17:21:57 +01:00
faluco
199f1c953e
Remove unneeded logmap headers.
2021-02-03 14:15:27 +01:00
faluco
b30845fae4
Remove unused variable in enb vnf_phy_nr.
2021-02-03 14:15:27 +01:00
faluco
1a5799a6ca
- Replace loggers is network utils.
...
- Adapt tests that use network utils and callers.
2021-02-03 14:15:27 +01:00
faluco
79eca0980d
- Ported fsm.h to srslog.
...
- Adapted and removed old loggers in tests and code that used fsm.h
2021-02-03 14:15:27 +01:00
faluco
d37a07a47f
Replaced loggers in buffer_pool.h
2021-02-03 14:15:27 +01:00
faluco
f8485fb799
Replaced loggers to srslog in PNF and VNF classes.
2021-02-03 14:15:27 +01:00
faluco
96c07a69c0
Report the RLF event to the JSON event file in the enb.
2021-02-03 13:13:36 +01:00
Francisco
ec14a6e50b
verify correctness of input to gtpu::write_pdu
2021-02-02 21:37:18 +00:00
Francisco
411946c752
Improvements on GTPU message logging
...
- Avoid multiple lines per each SDU Rx or Tx
- log info relative to source and destination of each SDU
- log info relative to whether the Rx SDU has been forwarded into a tunnel
- log info relative to whether the Rx SDUs are being buffered.
2021-02-02 21:37:18 +00:00
Xavier Arteaga
92c4a38fc2
Fix logger for NR PHY
2021-02-02 15:23:14 +01:00
Xavier Arteaga
2421f2cd99
Multiple PHY fixes and NR-PHY configuration refactor
2021-02-02 15:23:14 +01:00
Francisco
cd68e604b0
fix s1ap UE find method
2021-02-01 22:27:49 +00:00
Francisco
2bde28252c
send UE capability indication through S1AP
2021-02-01 22:27:49 +00:00
Francisco
d64ce7df77
implementation of S1 E-RAB Release Indication and Error Indication messages
2021-02-01 22:27:49 +00:00
faluco
ac62e3c398
Fix the priority of logging levels in places where we before logging we check if a certain log level is enabled.
2021-02-01 20:18:55 +01:00
herlesupreeth
47fff7226a
Send NAS PDU in E-RAB Release Command and issue RRCConnectionReconfiguration to UE
...
This commit addresses the following points
- If a NAS-PDU IE is contained in the E-RAB RELEASE COMMAND message, the eNB shall pass it to the UE.
- Issue RRCConnectionReconfiguration for the DRB to be removed
- Cleaning of DRB in RLC and GTP-U
- Fix for Malformed E-RAB Setup Response upon reaching max. DRBs
2021-02-01 14:31:24 +01:00
Andre Puschmann
da9e3363f1
mac_pdu_nr: rename MAC PDU class for NR to adhere naming conventions
...
* mainly to have _nr as trailing name for filename and class
* also add "sch" to class and filename (RAR PDU will have extra class)
2021-01-30 11:58:25 +01:00
Francisco
2befbd1825
setup of forwarding tunnels during enb s1 handover
2021-01-29 18:46:11 +00:00
Francisco
ee3d8a5c77
fix gtpu_test memcpy param overlap bug
2021-01-29 17:22:58 +00:00
Francisco
b9271f26da
change naming from mme to sgw in gtpu_test
2021-01-29 17:22:58 +00:00
Francisco
e8f6a436af
update gtpu test to account for scenario of buffered PDCP SNs, and buffering of direct path until indirect tunnel is closed
2021-01-29 17:22:58 +00:00
Francisco
a55c4cdca5
avoid gtpu extension header pdcp number magic number
2021-01-29 17:22:58 +00:00
Francisco
56ec2c286e
add gtpu test for tunneling
2021-01-29 17:22:58 +00:00
Francisco
13649e4e19
Implement new GTPU functionality:
...
- multiple tunnels per E-RAB
- data forwarding between connected GTPU tunnels
- forwarding GTPU End Marker between connected tunnels
- TeNB GTPU handles in-sequence delivery when multiple tunnels for the same ERAB exist.
2021-01-29 17:22:58 +00:00
faluco
711438f756
Port enb specific classes to use srslog ( #2155 )
...
* - Started porting the enb PHY layer to use srslog loggers.
- Updated srslog to manage the none level.
* Finished porting enb phy layer including the NR part.
* Ported MAC, GTPU, PDCP, RLC and S1AP enb classes to use srslog.
* Use new stack logger.
* Ported the enb RRC clases to use srslog.
* Remove unused log macros.
* Replace loggers in sched, sched_carrier, sched_helpers.
* Replaced loggers in sched grid.
* Replaced loggers in sched harq.
* Replaced loggers in sched ue.
* Replaced loggers in sched ue ctrl.
* Replace loggers in sched ue ctrl TPC.
* Replaced loggers in sched subclasses.
* Replaced loggers in rrc_meascfg_test
* Configure loggers in rrc_mobility_test.
* Fix compilation errors left out after the rebase.
* - Implement a custom log sink that will serve as a test spy to intercept and count the number of error and warning log entries.
- Adapt the erab_test_setup and rrc_mobility tests to use this new class and make them pass again.
* - Remove trailing new lines introduced in the rebase.
- Ported the sched_ue_cell class to srslog.
* Remove unused log member.
* Ported mac tests to srslog.
* - Removed remaining trailing newlines from log entries.
* Fix compiler errors detected in CI.
* Fix another static variable without definition passed to log lines.
* Fixed a bug in srslog::flush that would never end when the backend queue is full.
* Fetch the RRC logger instead of injecting it in the constructor.
2021-01-28 12:17:18 +01:00
yagoda
1420c23863
adding RAR buffers for multiple carriers, previously RARs into different carriers in the same TTI would overwrite each other
2021-01-26 21:19:06 +01:00
Xavier Arteaga
2baccc8b13
Set NR-PDSCH default table to 256QAM
2021-01-25 22:04:55 +01:00
Francisco
26086252ba
fix resetting of harqs in the scheduler during intra-enb handover
2021-01-25 18:09:21 +00:00
Ismael Gomez
fed4e0ad82
Protect access to ul buffers ( #2227 )
...
* Protect access to ul buffers
* Fix interval calculation when removing old buffers
2021-01-21 21:33:30 +01:00
Francisco
e0937d1dd1
add lcid check and increase limit to 10
2021-01-21 17:04:38 +00:00
Francisco
a24091edf8
fix handover regression. The new pcell was not being correctly reactivated
2021-01-21 17:04:25 +00:00
Francisco
9b20e35b8f
add comment regarding implementation of false position method in the scheduler
2021-01-21 17:04:25 +00:00
Francisco
927938c7be
fix sched_ue configuration process when a carrier is set to 'not configured'
2021-01-21 17:04:25 +00:00
Francisco
4ed87babff
extend sched_ue_cell interface
2021-01-21 17:04:25 +00:00
Francisco
3d7a83cb6e
delete cc_sched_ue class
2021-01-21 17:04:25 +00:00
Francisco Paisana
c1ff03bd1a
moved uci feedback and state variables from cc_sched_ue to sched_ue_cell class
2021-01-21 17:04:25 +00:00
Francisco Paisana
dadee757a1
moved harq entity and tpc to sched_ue_cell
2021-01-21 17:04:25 +00:00
Francisco Paisana
3892194d98
sched refactor, use enb_cc_idx rather than ue_cc_idx primarily to avoid uneeded conversions
2021-01-21 17:04:25 +00:00
Francisco
30439c12e0
fix 'maybe be used uninitialized' error
2021-01-21 11:33:59 +01:00
Ismael Gomez
47dbd6ed70
Merge pull request #2214 from softwareradiosystems/pr_mac_buffers
...
Limit the number of UL buffers in MAC and deallocate old ones
2021-01-20 21:12:39 +01:00
Francisco
e27ded9e55
add comment explaining the need to warn in case of failed allocate a TB in the scheduler when there are still pending bytes
2021-01-20 20:37:52 +01:00
Francisco
9ab7373251
Encode correctly DCI format2A when one of the TBs is empty
2021-01-20 20:37:52 +01:00
Ismael Gomez
8c85ddea0f
Fix ue_cc_idx naming convention
2021-01-20 18:10:49 +01:00
Ismael Gomez
44e411be2b
Track UL buffers per TTI instead of per PID and remove old ones periodically
2021-01-20 17:47:36 +01:00
Francisco
7f6f3f7912
fix sched test check for ConRes DCI format.
2021-01-20 17:11:04 +01:00
Francisco
8330793da9
use DCI format1A in edge case where the enb has more than one cell and the nof_prbs=15
2021-01-20 17:11:04 +01:00
Ismael Gomez
a6423442c2
Refactor NR RA files and fix header includes all over library ( #2162 )
...
* Refactor NR resource allocation classes. Use DCI instead of grant for dummy PDSCH UE/eNB test
* Minor refactors in NR workers and ue_dl
* Fix include issues
* fix compilation issues
2021-01-20 15:46:46 +01:00