Commit Graph

2762 Commits

Author SHA1 Message Date
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4
see #3530 for detailed discussion. This change saves some CPU cycles it seems
2021-10-25 21:52:03 +02:00
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976)
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
2021-10-25 10:54:17 +02:00
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527)
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
2021-10-25 10:51:02 +02:00
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 2021-10-23 21:26:00 +02:00
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 2021-10-23 21:26:00 +02:00
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4
this significantly reduces data copies when providing the PHY
with scheduler results.
2021-10-23 21:09:26 +02:00
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 2021-10-23 17:23:08 +02:00
Pedro Alvarez fbcffb84bd Check if RLC is suspended before transmiting PDCP SDU.
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.

As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
2021-10-22 17:27:32 +01:00
Xavier Arteaga d9bdc3f83e Add CSI resource information and fix segmentation fault 2021-10-22 12:46:44 +02:00
Carlo Galiotto 284207dad6 WIP: fixing collision in the the users_map
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-21 23:26:46 +02:00
Ismael Gomez 7920e084b8 Revert "Do not abort tsan"
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
2021-10-21 21:31:21 +02:00
Ismael Gomez 80c48a8b01 rlc: protect access to tx_enabled 2021-10-21 21:31:21 +02:00
Ismael Gomez bf566fbd29 radio: protect concurrent access from tx_end and tx 2021-10-21 21:31:21 +02:00
Ismael Gomez 4239222909 Do not abort tsan 2021-10-21 21:31:21 +02:00
Francisco c6226b0d94 lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE 2021-10-21 16:16:01 +01:00
Pedro Alvarez e721504f8e Removed the sctp_init_server for consistency. Added listen method to unique_socket class. 2021-10-21 14:50:44 +01:00
Pedro Alvarez e9a7e6dbae Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function. 2021-10-21 14:50:44 +01:00
Francisco 7aa5f731ce lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection 2021-10-21 09:31:03 +01:00
Francisco 4a58c10f30 lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer 2021-10-21 09:31:03 +01:00
Xavier Arteaga 8e5fe9018b Corrected LBRM functionality 2021-10-20 10:27:45 +02:00
Xavier Arteaga 9ecea014bd Added PUSCH DMRS minimum SNR 2021-10-19 23:05:16 +02:00
Francisco 0b51848dda nr,gnb,rrc: use multiqueue to forward x2 tasks to NR stack 2021-10-19 22:50:57 +02:00
Fabian Eckermann 59df04547e Increase buffer size for NR. 2021-10-19 10:18:44 +02:00
Andre Puschmann 3bf09021f9 enb: remove unused parameter 2021-10-18 14:17:53 +02:00
Francisco 7a16be9692 rrc,nr: ensure coresets and search spaces are passed to scheduler cell_cfg and ue_cfg 2021-10-16 22:43:23 +01:00
Andre Puschmann af69551c8d mac_sch_pdu_nr: add LBSR unpacking
* add LBSR unpacking
* add pretty printer
* also simplify and unify general unpacking code
2021-10-16 21:50:07 +02:00
Francisco 81174bda64 nr,ue,rrc: release NR logical channels during RRC release 2021-10-15 18:28:09 +01:00
Xavier Arteaga 3c40cd2840 Improved NR PHY logging info 2021-10-15 18:19:04 +02:00
Xavier Arteaga a5f6aa9f31 Added CSI string in PDSCH and PUSCH decode 2021-10-15 18:19:04 +02:00
Xavier Arteaga 003c6e524c Added short NR CSI information 2021-10-15 18:19:04 +02:00
faluco dacf40f63e Delete move constructor and move assignment operator explictly for mac_pcap_base and s1ap_pcap classes.
Move emergency handlers header file into the support folder.

Refactored signal handling:
- Remove the dependency with the running static variable in the header file.
- Move implementations down to cc files.
- Allow specifying a new signal handler that will be used to stop the applications.
- Move signal handling files to support.
2021-10-15 15:05:37 +02:00
faluco 9075251627 Move the cleanup code from the signal handlers down to the new emergency handlers for the ue, epc and enb. 2021-10-15 15:05:37 +02:00
faluco 2c1e9c0c55 Implement an emergency cleanup handler registration mechanism to allow modules to clean themselves before application gets killed.
Flush PCAP contents just before killing the application.
2021-10-15 15:05:37 +02:00
Francisco f427a25a30 nr,gnb,mac: account for header space larger than 2 when packing PDSCH 2021-10-15 11:03:02 +02:00
Francisco ed2e88524f asn1,rrc_nr: implement to_json in setup_release_c 2021-10-14 21:38:48 +01:00
Francisco 9df6c6b936 sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay 2021-10-14 21:38:12 +01:00
Andre Puschmann 255ddb1329 enb,gnb: add basic support for sgnb release procedure
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
2021-10-14 21:30:14 +02:00
Francisco ea324e8cbe nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI 2021-10-14 19:27:52 +01:00
faluco 28bbaa7816 Blacklist TSAN issues from libusb and libuhd. 2021-10-14 08:55:06 +02:00
Alejandro Leal Conejos 1a64c6adad Enum fixes so clang 12 can build the repo 2021-10-14 08:48:04 +02:00
Carlo Galiotto f53e01cfa3 mac: apply changes by PR reviewers
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-13 11:12:03 +02:00
Carlo Galiotto dc3e3a89f8 mac: update CQI in MAC with CSI reports from PHY
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-13 11:12:03 +02:00
Francisco 11ee4ab9dd nr,gnb,rrc: fix scheduler FDD configuration 2021-10-12 17:49:12 +01:00
Francisco 1b595b6eff nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC 2021-10-11 18:21:51 +01:00
Francisco 43b12b9ffb rrc,nr: transfer SSB config to both UE and NR scheduler 2021-10-09 16:53:14 +01:00
Carlo Galiotto 43a7d822fa stack,rrc: fix double removal of EPS bearer
The EPS bearer was removed twice, causing an error in the logs.

Fix issue #3380

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-08 11:19:12 +02:00
Xavier Arteaga 25bd0d6219 Added SSB pattern to/from string functions 2021-10-08 09:49:07 +02:00
Francisco 47e5e85449 refactor: clean unnecessary includes of the asn1/rrc_nr.h 2021-10-07 23:08:07 +01:00
Xavier Arteaga 1bdb1bb62d Store PUSCH CSI from PUSCH DMRS 2021-10-07 16:31:26 +02:00
Bedran Karakoc 850606f20b Added deregistration (UE terminating) 2021-10-06 20:01:00 +02:00
Xavier Arteaga d5b34696b4 Sepparate CSI report configuration from quantification and integrate in nr_phy_test with assertions 2021-10-06 16:33:51 +02:00
faluco 388b1e5d92 Fix data race in radio::is_start_of_burst. 2021-10-06 12:49:34 +02:00
faluco 7b0b76d58e Whitelist two lock order inversion TSAN issues that acquire a readlock. 2021-10-06 12:49:34 +02:00
Francisco Paisana b7f40b2baf rrc,nr: reenable CSI reporting in gNB 2021-10-06 10:58:29 +01:00
Fabian Eckermann cb721aa292 fix calculation of ssb frequency. 2021-10-05 18:21:58 +02:00
Francisco Paisana b58915d7ed rrc,nr: make gnb cell CSI NZP configuration consistent with UE NSA configuration. 2021-10-05 10:28:36 +02:00
Francisco Paisana 23bf542ae7 stack,nr: isolate calls between LTE and NR stacks via the task multiqueue 2021-10-05 10:12:28 +02:00
Andre Puschmann 8bb06ff2c0 Added SSB in gNb PHY 2021-10-04 19:26:07 +02:00
Xavier Arteaga 3763d04578 implement helper function to calculate FFT size for a given sampling rate 2021-10-04 19:26:07 +02:00
Andre Puschmann 7496b7c14f Add SSB to configuration factory 2021-10-04 19:26:07 +02:00
Andre Puschmann 5b0767772b Added SSB center frequency to band helper 2021-10-04 19:26:07 +02:00
Andre Puschmann 91e17337db Added SSB scaling configuration option 2021-10-04 19:26:07 +02:00
Andre Puschmann 3e5b40fd36 enb,rrc: fix compilation after freq point a has been removed from nr_carrier_t
since absolute freq point a members have been removed from the srslte_nr_carrier_t
struct (they are now actual frequencies) the abs_point_a values are now in
the RRC cell structs
2021-10-04 17:52:14 +02:00
Fabian Eckermann 95abfbfec8 Calculate ssb frequency from freqency point a. 2021-10-04 15:59:05 +02:00
Francisco Paisana f22483ce72 sched,nr: use formatting %d to represent slot index 2021-10-04 13:43:56 +02:00
Xavier Arteaga c9d7db7314 Minor changes 2021-10-04 10:28:34 +02:00
Xavier Arteaga e3bd92d87c Fix SSB pattern in UE 2021-10-04 10:28:34 +02:00
Xavier Arteaga 8f90ee847a Refactor carrier frequency from PHY and fix OFDM phase compensation 2021-10-04 10:28:34 +02:00
Xavier Arteaga fda35bf6a1 Initial OFDM carrier phase compensation 2021-10-04 10:28:34 +02:00
Ismael Gomez 6b506ec357
phy_common: clear tx_hold flag before releasing the semaphore (#3342) 2021-10-03 20:05:38 +02:00
yagoda 82bda02b36 adding nr metrics 2021-10-03 13:06:59 +02:00
Xavier Arteaga 1aa65bd10c HOTFIX: force DFT wisdom save at exit 2021-10-01 18:06:37 +02:00
Ismael Gomez c09f09b7be Move rrc_common from srsue to lib 2021-09-29 21:39:56 +02:00
Fabian Eckermann 8830c2796f Add support for NSA FDD on band n3, n5 and n7. 2021-09-29 16:03:44 +02:00
Fabian Eckermann 2d0be77660 Add helper functions for abs freq point a. 2021-09-29 16:03:44 +02:00
Andre Puschmann 315057d11c enb: signal user activity to EUTRA RRC when doing NR DL traffic
to avoid releasing the UE when only NR DL traffic is done.
similar to the EUTRA solution.
2021-09-28 16:55:54 +02:00
Xavier Arteaga 8b2514ded3 Added NZP-CSI-RS signals in gNb 2021-09-28 16:54:37 +02:00
Francisco Paisana cbb709d4e3 sched,nr: function to log UEs buffer status before scheduling decision, fix const_iterator of circular_map 2021-09-27 15:43:16 +02:00
Ismael Gomez 1c77998df5 Stop PDCP for data bearers before initiating HO 2021-09-27 13:54:51 +02:00
faluco fa351cd285 Rename functions that contain the unsafe word to nolock.
The term "unsafe" does not clearly state that the function is not locking the shared date and it sounds "dangerous", so use a more explicit term.
2021-09-27 13:26:21 +02:00
Andre Puschmann 59e1bca3f5 rlc_am_lte: fix potential crash when attempting to resize tx queue
under some circumstances it could happen that the RLC is configured
when SDUs are already being written to the queue. The resize
operation of the underlying container would fail in this case.

Make sure to empty the queue before doing the resize.
2021-09-27 11:35:42 +02:00
Francisco Paisana bdf18856d1 sched,nr: fix handling of DL BSR in NR scheduler and computation of UCI 2021-09-24 17:35:15 +02:00
faluco 7b079fe289 Fix a data race in rlc TM metrics. 2021-09-24 14:27:37 +02:00
faluco edb7342aef Fix data race in rlc UM metrics. 2021-09-24 14:27:37 +02:00
faluco 6c91a824e2 Whitelist the TSAN lock order inversion issue in srsenb::mac::rlc_buffer_state. 2021-09-24 14:27:37 +02:00
Andre Puschmann 426e876047 enb,nr: fix GTPU handler to forward UL PDUs 2021-09-23 19:07:31 +02:00
yagoda bc4388a78c -adding temp crnti removal for NR carrier attach 2021-09-23 18:27:13 +02:00
Andre Puschmann 802b22ac91 enb,nsa: refactor NR RRC/cell config parsing
this allows to access all cell-related params from within RRC
2021-09-22 16:41:18 +02:00
David Rupprecht 611255aa5f Added GTPU bind address as output parameter 2021-09-22 15:15:47 +02:00
David Rupprecht bd0e641633 Added GTPU PDU Session header parsing 2021-09-22 15:15:47 +02:00
Bedran Karakoc 43915550cc NGAP GTP Bearer Establishment 2021-09-22 15:15:47 +02:00
David Rupprecht 3712983308 Added PDU Session est request 2021-09-22 15:15:47 +02:00
David Rupprecht c670383ae9 Added NAS 5G functions incoming msg and reg proc 2021-09-22 15:15:47 +02:00
David Rupprecht bbe54fb248 Fix uninitialized issue in NAS 5G pack/unpacking 2021-09-22 15:15:47 +02:00
Xavier Arteaga cdfbe28b69 Initial NR-MIB packing/unpacking 2021-09-22 11:17:27 +02:00
Xavier Arteaga 0324806d6c Packed NR TDD config in duplex configuration and created test case for FDD 2021-09-21 18:11:16 +02:00
Xavier Arteaga ffba972fb7 Fix gnb amplitude 2021-09-20 20:48:08 +02:00
Xavier Arteaga de00b80228 Review NR NSA CFO estimation and compensation 2021-09-20 20:48:08 +02:00
Xavier Arteaga 63bb86bce1 Added SS type conversion to string 2021-09-20 20:48:08 +02:00
Xavier Arteaga 7ba5099bee Implement CSI-RS resource mapping validation 2021-09-20 20:48:08 +02:00
Andre Puschmann 3fd47d2af4 enb: refactor L2/L3 and (re)move all NR components to gNB stack
* decouple EUTRA and NR stack classes
* implement dummy X2 interface with control and data plane methods
* implement eNB time source interface that PHY calls
2021-09-17 14:57:33 +02:00
faluco d2f09a8d3c Fix a nasty data race in the ue_bearer_manager class. The underlying std::map member was being accessed concurrently potentially corrupting memory. 2021-09-17 11:34:28 +02:00
faluco d009160ba6 Fix data race in the metrics of the rlc. 2021-09-17 11:34:28 +02:00
Andre Puschmann b127327684 enb,s1ap: print filename when writing S1AP PCAP 2021-09-16 15:25:46 +02:00
David Rupprecht e8a464228d Cleaned string helpers 2021-09-16 15:24:32 +02:00
Andre Puschmann cc2d71183e ue,phy,nr: fix race condition when setting UL grant for Msg3
the Msg3 UL grant requires the TTI in which the RAR has been received
to calcualte the correct timing. There was a race between PHY and Stack
thread.

This patch circumvents the issue by removing a PHY state member that only holds
the RAR Rx timing. In the new interface the RA proc passes the Rx TTI
to the PHY again when setting the UL grant so the PHY can calculate the
correct timing without any state.
2021-09-16 15:22:59 +02:00
Andre Puschmann ed92f2bd34 enb,mac_nr: remove EUTRA cell param for MAC-NR cell config calls
* the old srsran_cell_cfg_t is only carried for SIB params
* the SIB scheduling, etc needs to be ported and integrated into NR data structures
* disbable SIB test for the moment
2021-09-15 14:49:28 +02:00
faluco cf20b143c0 Fix the default constructor of the optional class to avoid a spurious uninitialized value warning in older GCC versions (seen for ARM32 and GCC 8.3).
Use a union of a byte and the real storage, and init the char by default.
2021-09-14 11:22:40 +02:00
faluco 485ec2edab Implement a new option to flush the file sink contents on every write. 2021-09-14 10:22:37 +02:00
Andre Puschmann 07019a5bd6 nr: refactor DL/UL frequency deriviation
* add separate DL/UL freq point a in NR carrier struct
* use freqInfoDL/freqInfoUL to get freq point a
* simplify carrier tuning logic
2021-09-13 10:27:16 +02:00
Andre Puschmann d26a7e0350 band_helper: add helper to derive DL/UL freq from abs_freq_point
calculate DL and UL freq in carrier struct based on given values
2021-09-13 10:27:16 +02:00
Andre Puschmann 69619d725a band_helper: add helper to derive UL ARFCN from DL ARFCN 2021-09-13 10:27:16 +02:00
Andre Puschmann f382a7c7db Revert "ue,proc_ra_nr: add temporary flag to skip RAR reception"
This reverts commit 28668aac34.
2021-09-09 14:29:04 +02:00
Andre Puschmann c1892eb2ec enb,nsa: refactor of SgNB addition interface
* update of FSM
* better integration of parameter for X2 calls
2021-09-09 14:29:04 +02:00
Andre Puschmann 54ab64327a ue,mac_nr: move BSR levels lookup table into lib header
prepare for shared use with gNB
2021-09-09 14:29:04 +02:00
faluco ec272061a0 Fix a dangling SDU pointer in mac_sch_subpdu_nr when adding subpdus into a mac_sch_pdu_nr. 2021-09-08 14:45:23 +02:00
faluco 934802d23c Report the SIB9 home enb name in the enb sector start/sector stop events. 2021-09-07 16:36:56 +02:00
faluco d168536bc4 Add a new program option to control how ASN1 messages get printed into the enb JSON report file. 2021-09-07 16:36:56 +02:00
faluco df6ae7b0e0 - Implement new enb events:
* ho_command
* connection_resume
* rlf_detected
- Rename rlf_report event to "rlf_report".
2021-09-07 16:36:56 +02:00
faluco 8a3586dfbf Include a ASN1 json representation for RRC enb events. 2021-09-07 16:36:56 +02:00
David Rupprecht a9a23214b0 Added more 5G security kdfs
Added new 5G SIM functions

Added const parameters for security functions
2021-09-07 11:06:56 +02:00
David Rupprecht a645d74eaf USIM functions for res star
Added gen_res_star in security.h

Added USIM interfaces for res star

Added RES star test case
2021-09-07 11:06:56 +02:00
David Rupprecht bce6b5cc0f Added kdf common
Use kdf functions in 5G KDF

Moved EPS KDF function to new KDF structure
2021-09-07 11:06:56 +02:00
David Rupprecht 15eaef21e2 Update test f12345 function
Moved XOR functions to lib

Added testcase for KDF

Minor liblte_security updates
2021-09-07 11:06:56 +02:00
David Rupprecht 0ef8976d53 Remove length from class and pass by reference 2021-09-07 11:05:59 +02:00
Andre Puschmann 88bb92dc0d mac_nr,sched: handle C-RNTI CE 2021-09-06 10:35:59 +02:00
Andre Puschmann ede81be5e4 mac_rar_pdu_nr: add packing routines
* add packing for RAR PDUs
* rewrite to_string() to use fmt lib
* add test case for packer
2021-09-03 12:09:41 +02:00
Andre Puschmann 20c0e0bc41 mac_sch_pdu_nr: add to_string() helper to format MAC PDUs in logs 2021-09-03 12:09:41 +02:00
Francisco Paisana 227ae97bcb workaround gcc4.8 issue with inability to derive move ctor noexcept specifier 2021-09-03 12:06:17 +02:00
Francisco Paisana f4df55c245 stack lte: separate bearer manager into two classes, one for the ue and one for the enb 2021-09-03 12:06:17 +02:00
Francisco Paisana 2ade4628ca stack lte: create an gtpu-pdcp adapter class that correctly converts lcids to eps bearers and vice-versa 2021-09-02 17:12:04 +02:00
Francisco Paisana 4b2f079581 gtpu: renamed lcid to eps_bearer_id as parte of the refactor of gtpu to use eps_bearer_ids 2021-09-02 17:12:04 +02:00
Andre Puschmann 3949a727a7 enb_interface: add stack interface for RRC
RRC uses the interface to register/deregister EPS bearer
2021-09-02 17:12:04 +02:00
Andre Puschmann db8b710442 bearer_manager: move to lib folder and extend for multiple users
prepare bearer manager to be used by eNB which requires
to support multiple RNTIs
2021-09-02 17:12:04 +02:00
Francisco Paisana 020bec025e sched: created class common to LTE and NR for ue buffer status management 2021-09-01 20:08:11 +02:00
Xavier Arteaga 01390a7340 Better NR softbuffer size adjustment 2021-08-31 18:56:41 +02:00
Andre Puschmann 9bf74843f6 mac_pdu_nr: add error handling to init_tx() method
check provided byte_buffer and return error if it's not valid
2021-08-31 17:20:13 +02:00
Francisco Paisana 04e5c81edf sched,nr: nr_phy_test now uses the whole mac class rather than just the scheduler 2021-08-27 15:50:23 +02:00
Francisco Paisana da4b7e4f80 sched,nr: fix sched RAR NR test; update test assert macros 2021-08-26 12:09:11 +02:00
Xavier Arteaga 83b9b2d1ff Implemented UE open loop CFO compensation for NR 2021-08-26 09:34:43 +02:00
Xavier Arteaga 7da2d20447 Added UE UL NR frequency offset option 2021-08-26 09:34:43 +02:00
Xavier Arteaga cfe2b305a1 Fix CORESET0 related PDSCH resource allocation procedure 2021-08-26 09:34:43 +02:00
Xavier Arteaga 36207db615 Added CORESET start_rb helper function 2021-08-26 09:34:43 +02:00
Xavier Arteaga f5f18054eb Added PDCCH NR interleaved mapping 2021-08-26 09:34:43 +02:00
Xavier Arteaga e07263ee26 Added band helper for getting band from ARFCN 2021-08-26 09:34:43 +02:00
Xavier Arteaga 7377496417 Added SCS to string and corrected coreset0 2021-08-26 09:34:43 +02:00
Xavier Arteaga 62ba7d386d Initial CORESET Zero constructor 2021-08-26 09:34:43 +02:00
Xavier Arteaga 5d149a4b78 Moved NR time/frequency allocation SLIV to new component 2021-08-26 09:34:43 +02:00
Francisco Paisana 2668a8f68b sched,nr: fix Msg3 decoding in PHY to not expect any UCI 2021-08-24 20:15:22 +02:00
Xavier Arteaga 2cd5e98132 Fix NULL check in DCI NR for RAR type 2021-08-24 14:45:40 +02:00
Xavier Arteaga b846116c5c Added NR RAR UL DCI packing 2021-08-24 14:45:40 +02:00
Francisco Paisana 55d83a1279 fix compilation issue due to wrong include path for srsran_assert.h file 2021-08-24 12:06:24 +02:00
Francisco Paisana f518861ebc fix location of support/ folder. Created macros for ASSERT_EQ and ASSERT_NEQ 2021-08-23 16:47:54 +02:00
Francisco Paisana 599fc978a5 improvement of srsran_assert design, with specializations to enable/disable assertions based on compile flags other than ASSERTS_ENABLED. Creation of the support/ folder 2021-08-23 16:47:54 +02:00
Francisco Paisana e896ac49e8 adt: create split optional span view to be used for C-array types 2021-08-20 14:30:19 +02:00
Francisco Paisana d616e46936 adt: allow choice between static and dynamic optional vector types 2021-08-20 14:30:19 +02:00
Francisco Paisana 1596fcf349 adt: rename optional table to optional array 2021-08-20 14:30:19 +02:00
Francisco Paisana 8c24cfebd3 adt: create data structure type to represent an array of optional fields 2021-08-20 14:30:19 +02:00
Francisco Paisana eb4999a18e lte,pdcp: silence error message when a reconfiguration of a PDCP entity is no-op 2021-08-20 13:30:19 +02:00
Andre Puschmann 1c3a03cb2b rlc: fix memleak in queue_rx_pdu
* alternative to #3141
* use byte_buffer as queue element
2021-08-07 12:31:49 +02:00
Andre Puschmann c365c16531 gnb_interfaces: inherit from EUTRA interfaces when they are identical 2021-08-05 10:28:29 +02:00
Andre Puschmann c03623863b enb,nsa: fix UL PDU processing
* remove const from pusch_info() MAC/PHY interface to allow moving unique byte buffer
2021-08-05 10:28:29 +02:00
Andre Puschmann fc35c0ee51 enb,nsa: fix packing of DL MAC PDUs
* use byte_buffer_t as interface type for DL PHY-MAC interface
* fix missing clear() for new DL tx
2021-08-05 10:28:29 +02:00
Xavier Arteaga de89e829e7 Added NR PUCCH Resource ASN1 helper 2021-08-03 17:30:08 +02:00
Xavier Arteaga 3ae131b336 gNb creates PUSCH decode PDU 2021-08-03 17:30:08 +02:00
Xavier Arteaga 98f29961bc Fix old GCC compilation 2021-08-03 10:46:13 +02:00
Xavier Arteaga 54e1fe172c Minor NR PHY aesthetical modifications 2021-08-03 10:46:13 +02:00
Xavier Arteaga 956c4f8266 Added PHY NR test TDD FR1.15-1 pattern 2021-08-03 10:46:13 +02:00
Xavier Arteaga dfa323df6b Added 20MHz default configuration 2021-08-03 10:46:13 +02:00
Xavier Arteaga 1b50758bd5 Initial NZP-CSI default configuration from TS38.101-4 2021-08-03 10:46:13 +02:00
Andre Puschmann 28668aac34 ue,proc_ra_nr: add temporary flag to skip RAR reception
this will be removed again as soon as the eNB supports full RAR
transmission.
2021-08-02 15:18:47 +02:00
Andre Puschmann 3b5344b0f7 thread_pool: add optional ID to thread pool
this allows to prepend an ID to each thread pool to
better differentiate workers from different pools
2021-08-02 15:18:47 +02:00
Andre Puschmann 38f1e158a5 enb,nr: fix NR PHY PRACH init and MAC-PHY interaction 2021-08-02 15:18:47 +02:00
Xavier Arteaga a300a47673 Fix value selector for NEON 2021-08-02 11:10:25 +02:00
Xavier Arteaga 42b052112f Added TS reference and use SRSRAN_CEI_LOG2 macro 2021-07-30 20:23:09 +02:00
Xavier Arteaga 1f495cb008 Added generic SRSRAN_CEIL_LOG2 2021-07-30 20:23:09 +02:00
David Rupprecht 11f9ac75db Added PLMN to serving network string name 2021-07-29 17:50:04 +02:00
Xavier Arteaga dbb10dd6a2 Hold worker thread until baseband is transmitted 2021-07-28 12:14:37 +02:00
Xavier Arteaga 0c7239e5df SRSUE: add RF channel offset 2021-07-28 12:14:37 +02:00
Xavier Arteaga b57df4db10 Refactored worker_end mechanism for concurrent workers 2021-07-28 12:14:37 +02:00
Andre Puschmann 4915dc9642 test_pcap: add function description 2021-07-28 10:26:09 +02:00
Andre Puschmann 45c1971249 mac,phy,interface: clean up and add NR interface to LTE stack
* remove obsolte rx_data_ind
* add mac_phy_interface_nr to LTE stack
2021-07-27 18:26:20 +02:00
David Rupprecht 04ef6e120d Added new SIM functions to get MCC, MNC and MSIN 2021-07-27 09:26:52 +02:00
Bedran Karakoc a6226379b4 Introducing NGAP UE context procedures 2021-07-26 19:12:01 +02:00
Ismael Gomez a896e32cf4 Refactor sub-band CQI processing 2021-07-26 12:02:14 +02:00
Ismael Gomez 9b10e1c45d Fix sub-band CQI in UE. Refactor variable names 2021-07-26 12:02:14 +02:00
Francisco Paisana 12e33483e1 sched,nr: add slot_point to sched nr 2021-07-26 11:52:07 +02:00
Francisco Paisana a0a1af9d0f nr: slot value that handles wrapping around 2021-07-26 11:52:07 +02:00
Xavier Arteaga b59c330858 Fix filesource include 2021-07-23 14:31:32 +02:00
Francisco Paisana bc5a548fe8 sched: scheduler now accounts for prachs with different durations 2021-07-21 13:37:16 +02:00
Xavier Arteaga bb4f469794 Integrated SR decoder in gNb 2021-07-21 10:40:40 +02:00
Xavier Arteaga d783fbf3a0 Reviewed NR procedure for PUCCH resource sselection and reviewed gNb PUCCH interface 2021-07-21 10:40:40 +02:00
Andre Puschmann 60a795acc0 asn1,rrc_nr,test: extend RRC reconf test, add PCAP output
test now can write the NR reconfig into a PCAP for easy
debugging with Wireshark

patch also adds a new test helper to write a RRC PDU
into a PCAP file (helper packs PDCP and RLC AM first)
2021-07-19 12:53:09 +02:00
Ismael Gomez 6fb9b6bf94 Fix sub-band CQI in UE. Refactor variable names 2021-07-19 12:27:54 +02:00
Francisco Paisana 74d0a8adb8 sched: add subband cqi info interface to LTE scheduler 2021-07-16 19:34:10 +02:00
Ismael Gomez 2e1127f385 Add sub-band CQI periodicity and configuration to lib 2021-07-16 16:44:39 +02:00
Ismael Gomez 3f5094f30e Remove confusing subband_size variable and replace with subband_wideband_ratio 2021-07-16 16:44:39 +02:00
Andre Puschmann a142192d4e test_common: handle return value from make_byte_buffer() 2021-07-16 12:35:12 +02:00
Andre Puschmann 8d2e81ad6f enb,mac,nr: add basic UE object skeleton
refactor that also adds a basic UE object to the NR MAC
2021-07-16 12:35:12 +02:00
Francisco Paisana 09c7000201 sched,nr: update nr scheduler to use new mac nr interface types 2021-07-15 21:56:47 +02:00
Francisco Paisana d9336bcd9e sched,nr: creation of pool of softbuffers for NR. Now the sched NR harq manages the lifetime of the softbuffer and its forwarding to the PHY 2021-07-15 21:56:47 +02:00
Francisco 357bc10a17 feature - make minimum SNR, under which the RRC is notified with UL KO, configurable 2021-07-15 18:44:51 +02:00
Francisco 67325ab5c1 add pdcch_cqi_offset parameter to enb.conf 2021-07-15 18:44:51 +02:00
Francisco 2a31daca4a enb,configuration: allow to specify enb specific max nof RLC retxs 2021-07-15 15:59:33 +02:00
Andre Puschmann b5b2f8190e signal_handler: use std::atomic for running var 2021-07-14 23:03:51 +02:00
Andre Puschmann ff5fe5df14 rf_uhd_imp: fix race in RF metrics 2021-07-14 23:03:51 +02:00
David Rupprecht d990db66f6 Added syslog logger 2021-07-14 18:57:28 +02:00
faluco 7b7ecb7983 Add a new configuration option that controls PDSCH baseband sample dump to a file on KO. 2021-07-14 16:17:23 +02:00
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
2021-07-14 14:30:58 +02:00
David Rupprecht fb92118bb7 Add 5G NAS infrastructure 2021-07-14 13:38:08 +02:00
David Rupprecht 709b706d07 Fix 5G NAS extended protocol discriminator 2021-07-14 10:28:20 +02:00
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
2021-07-12 19:24:02 +02:00
Xavier Arteaga 54a12870ec SRSUE: avoid negative SR transmission in NR 2021-07-09 22:32:40 +02:00
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 2021-07-08 16:47:07 +02:00
Xavier Arteaga f07d925be1 Initial NR PHY test scheduling for PUSCH 2021-07-08 16:47:07 +02:00
David Rupprecht 724af2b060 Added nas 5g msg packing and unpacking 2021-07-08 09:34:57 +02:00
Andre Puschmann fd7b9a0575 enb,nsa: add basic RRC EUTRA<>RRC NR interface for SgNB addition 2021-07-06 21:57:44 +02:00
Andre Puschmann c9e87b2cf3 config_file: print message when config file couldn't be read
this prints an message on stdout so config files are not
simply skipped and the default one is read instead.
2021-07-06 21:57:44 +02:00
Andre Puschmann fa461f0129 rrc_nr: fix linker error in setup_release_c
move implementation to cc file to avoid

[build] /bin/ld: CMakeFiles/rrc_nr_asn1_test.dir/rrc_nr_test.cc.o: in function `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set_setup()':
[build] /home/anpu/src/srsLTE/lib/include/srsran/asn1/rrc_nr.h:2276: undefined reference to `asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::set(asn1::rrc_nr::setup_release_c<asn1::rrc_nr::pdcch_serving_cell_cfg_s>::types_opts::options)'
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)
2021-07-06 21:57:44 +02:00
Andre Puschmann 4379c20eb9 rlc_am_lte: avoid locking of Rx mutex twice when generating status PDU
call reset_status(), which now is an private method directly when
building a status PDU. No need for the Tx side to call Rx again.
2021-07-06 12:50:48 +02:00
Andre Puschmann 53a7dc78ee rlc_am_lte: replace do_status boolean with atomic
the do_status is queried from the Tx code frequently. To reduce
chances to delay the execution because the RLC Rx side is currently
holding the mutex we can use an atomic.
2021-07-06 12:50:48 +02:00
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 2021-07-05 17:51:27 +02:00
Xavier Arteaga cf496e75eb Fix default PHY NR configuration 2021-07-05 17:51:27 +02:00
Xavier Arteaga 2fbd172888 Initial PHY NR configuration generator 2021-07-05 17:51:27 +02:00
Xavier Arteaga 320aabec13 Initial PHY NR configuration 2021-07-05 17:51:27 +02:00
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 2021-07-05 17:51:27 +02:00
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 2021-07-05 17:51:27 +02:00
Xavier Arteaga e3afd945bc Refactored NR HARQ ACK feedback 2021-07-05 17:51:27 +02:00
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 2021-07-05 17:51:27 +02:00
Xavier Arteaga 89994cd5a8 change ERROR macro format to be parsed by IDE 2021-07-05 17:51:27 +02:00
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 2021-07-05 17:51:27 +02:00
Xavier Arteaga eecaccb541 Added NR PHY helpers 2021-07-05 17:51:27 +02:00
David Rupprecht f90e359208 Moved cp to test common 2021-07-02 17:23:06 +02:00
Andre Puschmann bbcaa49429 network_utils: fix TSAN detected race 2021-07-02 17:22:49 +02:00
Andre Puschmann a9ad408f51 task_scheduler: use block_queue for internal tasks
TSAN detected wrong use of the old deque-based internal queue. To avoid
unwanted/undetected mis-use the patch uses the thread-safe block_queue
data structure instead.
2021-07-02 17:22:49 +02:00
Andre Puschmann 626f24c9f9 block_queue: use class mutex to protect size() getter
detected with TSAN
2021-07-02 17:22:49 +02:00
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
2021-07-01 17:39:54 +02:00
Pedro Alvarez 05fbca43d1 Fix GCC 11 warning in dyn_array 2021-07-01 10:55:11 +01:00
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 2021-06-30 18:19:20 +01:00
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 2021-06-29 20:39:32 +02:00
Andre Puschmann 4d11e5552a rrc,ue: for RRC conn release, delay transition to RRC idle by 60ms as per TS 36.331
when receiving RRC connection release all actions shall be delayed by 60ms as
per the standard
2021-06-28 17:35:02 +02:00
Andre Puschmann 368c7b9e4f ue,stack: clear all EPS bearers when going RRC idle
the EPS bearer manager was only informed when a single DRB
was removed but not when entering idle which requires to
remove all bearers.

This cause the service request to fail.
2021-06-28 17:35:02 +02:00
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 2021-06-28 00:27:36 +02:00
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 2021-06-28 00:27:36 +02:00
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 2021-06-28 00:27:36 +02:00
Xavier Arteaga 9126ad3b8b Added NR type1 RIV function helper 2021-06-28 00:27:36 +02:00
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 2021-06-28 00:27:36 +02:00
Xavier Arteaga e98a6f9eea Make ACK M constant i UEDLNR 2021-06-28 00:27:36 +02:00
Xavier Arteaga 567c7c9c77 Create TTI semaphpore default constructor 2021-06-28 00:27:36 +02:00
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
2021-06-24 16:52:58 +02:00
Andre Puschmann 7113e55d53 rlc: refactor RLC entity to use smart pointers for holding bearers
this patch mainly modernizes the bearer creation to use smart pointers.
that allows to simplify the error handling.

ue_stack is changed to match new interface. This commit compiles
but doesn't work.
2021-06-24 16:52:58 +02:00
David Rupprecht 6d5391756c Refactor build of RLC NR config 2021-06-24 16:52:58 +02:00
David Rupprecht d1d8500ce5 Add testcase for reconfiguration 2021-06-24 16:52:58 +02:00
David Rupprecht ec19919246 Fix NGAP valgrind test 2021-06-22 20:53:43 +02:00
Xavier Arteaga eb7980f2b3 Initial UE synchronization for NR 2021-06-22 16:36:24 +02:00
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 2021-06-22 11:11:54 +01:00
David Rupprecht 85d7a851fb Added 5G NAS PCAP support 2021-06-22 09:02:07 +02:00
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 2021-06-21 17:35:24 +01:00
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 2021-06-21 18:07:53 +02:00
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 2021-06-21 18:07:53 +02:00
Ismael Gomez 5aa5a8e997 Revert UE changes 2021-06-18 23:17:14 +02:00
Ismael Gomez e35a0d72fa Revert UE changes 2021-06-18 23:17:14 +02:00
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 2021-06-18 23:17:14 +02:00
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality
Remove unused logger for now in ngap::ue to pass tests
2021-06-17 13:05:29 +02:00
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 2021-06-16 10:21:13 +01:00
Xavier Arteaga cf09044453 Optimised random bit (unpacked) and byte (packed) generator 2021-06-15 12:44:21 +02:00
Francisco 2a009eb340 sched,feature: Enable configuring maximum coderate for SIB allocations 2021-06-14 18:55:51 +01:00
Francisco 6ababf401b feature,sched: allow setting initial DL CQI in enb.conf 2021-06-14 15:55:23 +01:00
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 2021-06-14 13:18:47 +01:00
Xavier Arteaga 8743713bb1 Fix compilation 2021-06-14 09:21:29 +02:00
Xavier Arteaga 676080d6af Added macro SRSRAN_VEC_SAFE_CMA 2021-06-14 09:21:29 +02:00
Andre Puschmann 878142843e rlc_am_lte: add further sanity check when creating status PDU
the test verifies that the ACK_SN of a status PDU falls inside the
rx_window of the receiver. If not, than the RLC state has been
corrupted and the status PDU is likely invalid.
2021-06-10 10:44:18 +02:00
Alejandro Leal Conejos a51f2a1de4 Fills the value of the number of cpus for the system_metrics_t and
initiliaze its value to 0 when executing 2 measures in less than 100 ms.
2021-06-09 09:34:46 +02:00
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
2021-06-08 18:52:22 +01:00
Xavier Arteaga 939dd1b977 Change struct sync_raster_t to class 2021-06-08 14:55:12 +02:00
Xavier Arteaga 5181a9d64c Implemented PBCH blind decode 2021-06-08 14:55:12 +02:00
Xavier Arteaga 9621cf57c2 Implemented NR SS raster object 2021-06-08 14:55:12 +02:00
Xavier Arteaga 22b1673b36 Added CRC match function and simplify CRC check 2021-06-08 10:19:24 +02:00
Xavier Arteaga 7846bfccb1 Implemented softbuffer RX CRC reset 2021-06-08 10:19:24 +02:00
David Rupprecht ff3e7c321d Added bref function for calc distance til end 2021-06-08 10:14:43 +02:00
Xavier Arteaga 7c78fd2050 Implemented PDCCH DCI message correlation and updated test 2021-06-05 11:08:27 +02:00
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 2021-06-04 21:29:13 +01:00
Andre Puschmann 295b5fe8fb rlc_tm: fix stopping of entity detected with TSAN 2021-06-04 13:23:54 +02:00
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
2021-06-04 13:23:54 +02:00
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 2021-06-04 11:13:23 +02:00
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
2021-06-03 21:11:47 +02:00
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 2021-06-03 15:33:38 +01:00
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 2021-06-03 15:33:38 +01:00
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 2021-06-02 20:21:32 +01:00
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 2021-06-02 10:08:34 +01:00
Andre Puschmann 1ef3cb7e5d threads: fix race in stopping periodic thread 2021-06-01 22:44:12 +02:00
Andre Puschmann 312b5a241c mac_pcap_base: fix race detected with TSAN 2021-06-01 22:44:12 +02:00
Andre Puschmann 1d34aa280f byte_buffer_queue: make class thread-safe by using atomics 2021-06-01 22:44:12 +02:00
Pedro Alvarez 18e2149d68 Sending Initial Context Setup Response after RRC reconfiguration. 2021-06-01 19:16:16 +01:00
Francisco f36f5271d3 timers,feature: make timers thread-safe by using atomic to store timers state. 2021-05-31 23:26:36 +01:00
Xavier Arteaga 3c93d5ba43 Fix carrier mapping concurrency issue 2021-05-31 10:48:17 +02:00
Xavier Arteaga 235a664120 SRSUE: Removed PUSCH-DMRS/SRS pregeneration methods 2021-05-31 10:48:17 +02:00
Andre Puschmann 3102861ee3 rlc_am_lte: make func param const& 2021-05-31 09:40:37 +02:00
Francisco a587d20252 allow specification of subset of valid measurement gap offsets in rr.conf 2021-05-28 17:19:30 +02:00
Andre Puschmann bb6a5ebe80 tsan: add TSAN options file to set some default flags and exclude some libs from checks 2021-05-27 17:26:39 +02:00