Commit Graph

4184 Commits

Author SHA1 Message Date
GitHub gen-configs Action c73b6ff562 Auto-generated configs and docs 2023-02-06 13:15:53 +00:00
Matthew Kennedy 6e89e71d0a
more flexible GPPWM (#5032)
* gppwm improvements!

* test

* ui

* autoscale
2023-02-06 08:53:31 -04:00
GitHub gen-configs Action 61403d77c6 Auto-generated configs and docs 2023-01-24 01:30:38 +00:00
Matthew Kennedy 9630edfbf8
mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
rusefillc 92a4895b13 refactoring: inside the boost controller instead of depending on the engine god object 2023-01-22 07:40:42 -05:00
rusefillc 4ea8e73459 K 2023-01-21 08:56:21 -05:00
Matthew Kennedy 71d35343d9
renumber airmass mode enum to start at 0 (#4986)
* #1690

* hw ci tests
2023-01-21 08:12:27 +05:30
Matthew Kennedy ab7640493c
dead (#4985) 2023-01-21 06:49:05 +05:30
rusefillc 067a94414b h-bridge wastegate not alive on bench #4965
in my dreams that would be part of CI
2023-01-17 11:50:10 -05:00
GitHub gen-configs Action 625de5e662 Auto-generated configs and docs 2023-01-17 09:30:33 +00:00
rusefillc 71c4653cf8 h-bridge wastegate not alive on bench #4965
in my dreams that would be part of CI
2023-01-17 04:14:44 -05:00
rusefillc a4e18d087f h-bridge wastegate not alive on bench #4965
in my dreams that would be part of CI
2023-01-17 04:13:47 -05:00
GitHub gen-configs Action e2cbdffc99 Auto-generated configs and docs 2023-01-16 20:23:11 +00:00
Andrey af29d0c034 TS gauges section should be auto-generated #4972 2023-01-16 15:16:35 -05:00
Andrey 01ada5cbc8 TS gauges section should be auto-generated #4972 2023-01-16 15:12:24 -05:00
GitHub gen-configs Action 8691f6df31 Auto-generated configs and docs 2023-01-16 13:47:18 +00:00
Andrey 35f0af7240 TS gauges section should be auto-generated #4972 2023-01-16 08:39:58 -05:00
GitHub gen-configs Action d0e1b6e5e4 Auto-generated configs and docs 2023-01-16 05:45:06 +00:00
rusefillc 78e477765f TS gauges section should be auto-generated #4972 2023-01-16 00:38:40 -05:00
Andrey b6dbb5479e TS gauges section should be auto-generated #4972 2023-01-16 00:24:42 -05:00
Andrey b14bcb571f TS gauges section should be auto-generated #4972 2023-01-15 21:46:21 -05:00
Andrey 5a441a534b totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 11:10:17 -05:00
GitHub gen-configs Action da5d63ff08 Auto-generated configs and docs 2023-01-15 13:37:56 +00:00
Andrey 6588e813ae totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
GitHub gen-configs Action 7851c7e32f Auto-generated configs and docs 2023-01-15 04:28:54 +00:00
Andrey 9abdab795d totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
GitHub gen-configs Action a649063e05 Auto-generated configs and docs 2023-01-14 21:08:25 +00:00
Andrey 7de2ce370a Merge branch 'master' of https://github.com/rusefi/rusefi 2023-01-14 15:50:06 -05:00
Andrey 30d329ce58 totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:49:08 -05:00
Andrey 0c1859b77e totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:33:17 -05:00
rusefillc 9130997887 docs 2023-01-14 12:49:11 -05:00
GitHub gen-configs Action e64f90728d Auto-generated configs and docs 2023-01-14 10:42:09 +00:00
Andrey 12282635ef totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 05:36:25 -05:00
Matthew Kennedy d5b00e1187
don't warn if we intentionally skipped this spark (#4961)
* don't warn if we intentionally skipped this spark

* header

* real nb2
2023-01-10 19:07:44 -05:00
Matthew Kennedy eb56c2897a
detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
rusefillc ba31d11a99 docs 2023-01-08 22:30:57 -05:00
GitHub gen-configs Action c5e3035f0a Auto-generated configs and docs 2023-01-07 21:34:08 +00:00
Andrey 0f1d46238f Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy e5d199272d
improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
GitHub gen-configs Action 834ed681d9 Auto-generated configs and docs 2023-01-06 02:30:20 +00:00
rusefillc a4eea87440 external muxes for internal ADC #3350 2023-01-05 21:23:00 -05:00
rusefillc b49e1569ba findTriggerZeroEventIndex() failed fix #4935 2023-01-04 13:15:45 -05:00
GitHub gen-configs Action 93d20f33ec Auto-generated configs and docs 2023-01-02 22:53:56 +00:00
rusefillc f94aa7a7cd https://rusefi.com/forum/viewtopic.php?f=2&t=2484 luaIgnCut 2023-01-02 17:46:56 -05:00
GitHub gen-configs Action f395d4dde4 Auto-generated configs and docs 2023-01-02 19:58:30 +00:00
rusefillc f1aa1d5220 TS Config comments trim at first new-line fix #4927 2023-01-02 14:53:33 -05:00
GitHub gen-configs Action 70000839e2 Auto-generated configs and docs 2023-01-02 17:58:18 +00:00
rusefillc 3b195635db logs progress 2023-01-02 12:22:45 -05:00
Nathan Schulte 96b2195497
misc tidy (#4926)
* FrequencySensor: code-style

* smart_gpio: fix indent, tidy BOARD_EXT_GPIOCHIPS

tidy _GPIOCHIPS for #pragma message(STRING(BOARD_EXT_GPIOCHIPS output

* obd_error_codes: fix indent
2023-01-01 15:51:31 -05:00
Andrey c8b998a911 test coverage for antilag #4920
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey db09833774 test coverage for antilag #4920
better default
2022-12-31 14:48:25 -05:00
rusefillc b279eeeab9 ALS fuel fix OOOPS 2022-12-31 14:21:05 -05:00
rusefillc ee6e958873 ALS fuel fix 2022-12-31 14:12:17 -05:00
rusefillc a9b2514480 ALS better defaults 2022-12-31 13:48:37 -05:00
Andrey 1afa6fa99a test coverage for antilag #4920
bugfix?
2022-12-30 12:21:04 -05:00
GitHub gen-configs Action 46d59eee2e Auto-generated configs and docs 2022-12-28 00:48:57 +00:00
rusefillc f685713a19 antilag: TPS vs APS/PPS vs driver intent #4917 2022-12-27 19:41:45 -05:00
rusefillc bbd7038c83 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-22 14:38:40 -05:00
rusefillc c61c3a7aa1 typo 2022-12-22 07:59:19 -05:00
rusefillc d671cee3a8 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-21 21:29:01 -05:00
rusefillc c6da63eb66 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-21 20:24:39 -05:00
rusefillc 6146b01a36 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
rusefillc 318aa6d8c9 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-21 19:46:31 -05:00
GitHub gen-configs Action 11074f389e Auto-generated configs and docs 2022-12-22 00:29:40 +00:00
rusefillc c01149c01d TurboMarian is the ALS boss 2022-12-21 19:11:52 -05:00
GitHub gen-configs Action b89ab81469 Auto-generated configs and docs 2022-12-21 23:52:17 +00:00
rusefillc fccbb8fd5e TurboMarian is the ALS boss 2022-12-21 18:47:30 -05:00
rusefillc c691787dd2 TurboMarian is the ALS boss 2022-12-21 18:47:20 -05:00
rusefillc f82f604a3f ohhh we already have FO_1_2_3_4_5_6_7_8 2022-12-20 21:23:25 -05:00
rusefillc 4e61d92099 FO_1_2_3_4_5_6_7_8 2022-12-20 21:13:33 -05:00
rusefillc 59d6ff9c99 print CAN into default script 2022-12-20 14:48:39 -05:00
rusefillc c7eb57d48e docs 2022-12-20 08:49:09 -05:00
rusefillc 60a63b1726 docs 2022-12-20 08:49:09 -05:00
rusefillc 0359af0ba3 docs 2022-12-20 08:39:55 -05:00
Andrey 748f97afeb kinetis asking for guard, also I've must have messed up something 2022-12-17 18:04:54 -05:00
rusefillc 2b4d58005b guards 2022-12-17 14:43:51 -05:00
rusefillc 18165e4b02 guards 2022-12-17 14:36:27 -05:00
rusefillc 12d79d09de TurboMarian is the ALS boss 2022-12-16 23:51:50 -05:00
rusefillc 37c35e08bb TurboMarian is the ALS boss 2022-12-16 23:31:51 -05:00
GitHub gen-configs Action 50f2e74a71 Auto-generated configs and docs 2022-12-17 01:29:31 +00:00
rusefillc d696ad52b3 TurboMarian is the ALS boss 2022-12-16 20:22:48 -05:00
rusefillc b3954122d6 TurboMarian is the ALS boss 2022-12-16 20:22:48 -05:00
TurboMarian 276713d24f LUA FuelAdd update
(cherry picked from commit a54cdbb0771b1a48aa8e24bffbaf554e10d55f3a)
2022-12-16 20:22:48 -05:00
rusefillc d0584d344f antilag and anti-lag #2403 2022-12-14 22:25:06 -05:00
Andrey a0c2689aa9 RPM correction/multiplier for Accel Enrich fix #4760 2022-12-14 21:51:41 -05:00
rusefillc 743bdad7e0 RPM correction/multiplier for Accel Enrich fix #4760 2022-12-14 19:57:07 -05:00
rusefillc 57ad9b7311 random getOrZero clean-up 2022-12-14 19:48:07 -05:00
rusefillc 911523ffbc random Frankenso clean-up 2022-12-14 19:11:16 -05:00
rusefillc bf6aac9f3b random Frankenso clean-up 2022-12-14 19:01:26 -05:00
rusefillc 40738fad12 smarter template 2022-12-13 16:47:35 -05:00
rusefillc 7b3423a7b5 RPM correction/multiplier for Accel Enrich #4760 2022-12-13 16:36:38 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Matthew Kennedy 769cdd32ca
TriggerScheduler cleanup (#4844)
* TriggerScheduler cleanup

* remove TRIGGER_EVENT_UNDEFINED

* remove dead overload of scheduleOrQueue

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
Matthew Kennedy ef53ff0104
period -> frequency (#4837)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 08:10:05 -05:00
rusefi dfa70d0d9e safer defaults 2022-11-26 14:13:14 -05:00
rusefillc 55062b1ef6
refactoring: constexpr fuel computer (#4830)
* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc 23698be5f8
without ValueProvider3D interface how do we mock? (#4829)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
rusefillc 8eaa901595
avoid ctime in GPS UART (#4824)
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte 5da7619577 add efidatetime_t type 2022-11-23 12:38:00 -05:00
Nathan Schulte fd1115d01a
code style, GPS fixes (test, firmware) (#4822)
* tidy NMEA

* const in nmea

* correct gps test output

* fix GPS UART print statements

* cleanup feature toggles in settings

* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
rusefillc a331cfa2c9 simpler SENT for now 2022-11-19 09:38:39 -05:00
Nathan Schulte 8eabbdf248 firmware: controllers: tidy #endif comments 2022-11-18 23:15:47 -05:00
Nathan Schulte 6b9b65543c firmware: kill -9 dead hipLastExecutionCount 2022-11-18 23:15:36 -05:00
Andrey ce550aaa3d new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 15:45:32 -05:00
GitHub gen-configs Action 17e7b4261f Auto-generated configs and docs 2022-11-16 16:43:31 +00:00
rusefillc 32d3669a35 new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 11:35:00 -05:00
GitHub gen-configs Action 7c47bdf0a6 Auto-generated configs and docs 2022-11-15 14:34:13 +00:00
rusefillc 9882d726db would need to stop the buzzing at PRI. 2022-11-15 09:29:13 -05:00
rusefi a17e12747e Add fuel adder to launch fix #4777 2022-11-13 20:23:19 -05:00
rusefi d8559be6bd it has been almost two years we cannot be compatible forever 2022-11-13 20:05:04 -05:00
rusefi 37194dfe56 Ford SENT ETB bench test in NJ #4745 2022-11-13 11:23:54 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
rusefi 7cc6d9c07c removing dead code 2022-11-06 20:39:40 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 83e736b06a trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
rusefillc 87d6aa2ed9 minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc e3fd84ed08 minor trigger refactoring 2022-11-06 00:32:38 -04:00
GitHub gen-configs Action f5f1fbfe2f Auto-generated configs and docs 2022-11-06 00:28:03 +00:00
Matthew Kennedy f4f5f69ee6
duplicate log field names (#4730)
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
rusefi bf3357cc61 nicer defaults API 2022-11-04 13:27:40 -04:00
rusefi 954e4650ba nicer defaults API 2022-11-04 12:37:28 -04:00
rusefillc 70e734127d target lambda & afr log fields broken #4727 2022-11-02 22:25:16 -04:00
GitHub gen-configs Action 0a703fec8c Auto-generated configs and docs 2022-11-03 02:21:44 +00:00
rusefillc 95d360f7b1 target lambda & afr log fields broken #4727 2022-11-02 22:17:00 -04:00
GitHub gen-configs Action 523a6b9592 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 53649f73f1 Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 959c738c24 refactoring: helper method 2022-10-30 00:17:42 -04:00
rusefillc 2715cc1b8b refactoring: helper method 2022-10-29 23:55:14 -04:00
rusefillc 13c9de1c80 refactoring: helper method 2022-10-29 23:04:24 -04:00
GitHub gen-configs Action 1695cdeb7b Auto-generated configs and docs 2022-10-28 08:36:50 +00:00
rusefillc cee2d4882f SD card log fields list should be auto-generated #3985 2022-10-28 04:20:35 -04:00
rusefillc 9218dcf116 PROTEUS_GM_LS_4 2022-10-27 20:49:06 -04:00
rusefillc 318d7ed933 PROTEUS_GM_LS_4 2022-10-27 19:59:52 -04:00
GitHub gen-configs Action 517b23c65a Auto-generated configs and docs 2022-10-27 18:47:49 +00:00
rusefillc 1b44a73565 PROTEUS_GM_LS_4 2022-10-27 14:30:00 -04:00
rusefi a74fc3c3c2 refactoring: extracting useful method 2022-10-25 21:55:54 -04:00
Matthew Kennedy f8a4d35d25
dual MAF sensors (#4697)
* add second MAF

* output channesl

* move them around

* ok let's try at the very end

* is the logic wrong, or something else?

* ooh it's the sensor order
2022-10-24 12:41:05 -04:00
GitHub gen-configs Action b6901f594c Auto-generated configs and docs 2022-10-21 02:31:12 +00:00
Matthew Kennedy 24650f6460
implement "ford mode" injector correction (#4686)
* implement "ford mode"

* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy 2bc8fbce7d
VE blend tables (#4640)
* blendy ve too

* ui

* small optimizations

* save kinetis memory

* changelog
2022-10-19 06:42:22 -04:00
GitHub gen-configs Action 2ebd4dfcac Auto-generated configs and docs 2022-10-18 01:27:31 +00:00
rusefillc e16c8f9120 Lua aux gauge #4672 2022-10-17 21:21:23 -04:00
Matthew Kennedy 1ae642e7a7
build tweaks for size (#4661)
* don't align on non-cached mcu

* lua decimal point

* no snprintf

* sort sections by alignment

* unit tests
2022-10-13 20:30:30 -04:00
rusefillc ba73aff1fa startStopStateToggleCounter to live data 2022-10-06 22:21:02 -04:00
GitHub gen-configs Action 2789005e56 Auto-generated configs and docs 2022-10-06 23:24:19 +00:00
rusefillc 3948d9650c startStopState to live data 2022-10-06 19:17:59 -04:00
GitHub gen-configs Action 584e0da7db Auto-generated configs and docs 2022-10-06 02:05:46 +00:00
Matthew Kennedy a773b3249a
remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
GitHub gen-configs Action 3bfc5c04a9 Auto-generated configs and docs 2022-10-05 00:19:38 +00:00
Matthew Kennedy ec5d48fb5b
remove 898 (#4634)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
rusefi 1804b40485 need Proteus QC 2022-10-01 22:34:08 -04:00
rusefi 0a8cdf3f47 need Proteus QC 2022-10-01 22:07:44 -04:00
rusefi 529fb35c66 need Proteus QC 2022-10-01 22:00:25 -04:00
rusefillc f703c58622 CAN side of automated testing #4630 2022-09-29 23:46:08 -04:00
rusefillc 234862b2b7 CAN side of automated testing #4630 2022-09-29 23:01:06 -04:00
rusefillc 672a7a2e7f CAN side of automated testing #4630 2022-09-29 20:55:38 -04:00
Andrey baaec6a603 refactoring: encapsulation 2022-09-28 22:42:08 -04:00
rusefillc 700a656756 engineSyncCam to be a drop-down not a number value #4611 2022-09-26 05:34:05 -04:00
Matthew Kennedy b089825a4a
schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Andrey 9d27780974 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 111220d38c more inclusive configuration name 2022-09-24 23:49:41 -04:00
Andrey 2ec9cca5e2 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 61cfff1e9e K progress - just a rename 2022-09-24 23:25:36 -04:00
GitHub gen-configs Action db50ff3178 Auto-generated configs and docs 2022-09-24 00:19:42 +00:00
rusefillc c4699efe91 honda K enum rename 2022-09-23 20:13:14 -04:00
Matthew Kennedy dfe1b47b4d
remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
rusefillc 9fde1f8b61 docs: private firmware enums vs public to code generated 2022-09-23 09:41:13 -04:00
Matthew Kennedy af7e4f6fe5
two modes trigger scheduler (#4598)
* two modes trigger scheduler

* asOld

* hpfp
2022-09-20 05:28:23 -04:00
rusefillc 83dc351435 documenting biquad or else concerns 2022-09-19 12:06:00 -04:00
GitHub gen-configs Action c622efc881 Auto-generated configs and docs 2022-09-18 01:44:04 +00:00
Matthew Kennedy 57a22fd713
gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 8ea31909a3
add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
GitHub gen-configs Action 0d43c2b9c1 Auto-generated configs and docs 2022-09-16 20:10:48 +00:00
Matthew Kennedy 87649b9f72
more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefillc 61134b452a tear down Engine god object #4511
oh I hope this ends well
2022-09-15 23:41:06 -04:00
rusefillc ec0e567989 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc 2d21aacc08 CUSTOM_INSTANT_MAP_DECODING 2022-09-15 15:07:31 -04:00
Andrey 0c87bb7260 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 663c39afdc deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 12d857b99c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey 6b0941b8ed inline method to reduce confusion 2022-09-14 01:24:19 -04:00
rusefillc e733782920 i suspect that no one cares about these 2022-09-14 00:34:04 -04:00
Matthew Kennedy 86562332c4
resurrect EFI_CLOCK_LOCKS (#4572)
* resurrect EFI_CLOCK_LOCKS

* missing extern

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-09-13 14:07:25 -04:00
Andrey G 69d9716fa6
tle8888 dead code (#4568) 2022-09-12 18:54:29 -04:00
rusefillc 5c8d44eec7 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:31:42 -04:00
rusefi 88011024d9 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:15:25 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey G 19226cb656
efiWatchdog: avoid converting time to float (#4562)
https://stackoverflow.com/questions/68690961/why-does-converting-int-to-float-lose-precision-in-c-programming-language
2022-09-11 05:46:55 -04:00
GitHub gen-configs Action d8169b5643 Auto-generated configs and docs 2022-09-11 07:53:45 +00:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 565b8dfc2d dead value 2022-09-11 02:34:02 -04:00
rusefillc 6e71b72acc refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 6bcd29c727 send more of Engine Sniffer data #4560
new API & first usage
2022-09-10 23:42:59 -04:00
rusefillc 541cd5caee Proteus with SD card outside of vehicle looses a second #4557
message correction
2022-09-10 11:43:25 -04:00
rusefillc 37e65e159a Mark is asking for VIN number field #3967
GM says Hi
2022-09-10 01:05:31 -04:00
rusefillc 3f6d05dce0 Proteus with SD card outside of vehicle looses a second #4557 2022-09-09 20:17:02 -04:00
rusefillc 8d770daca8 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 19:21:29 -04:00
rusefillc a3d86c61f2 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 18:27:16 -04:00
rusefillc 45eaa0546c refactoring: better method name 2022-09-09 18:02:38 -04:00
rusefillc 6b03f4ba68 How does rusEFI handle 23 (or 46?) days of continues operation #4554 2022-09-09 17:21:58 -04:00
Andrey 52869d63bb tear down Engine god object #4511
just trying different things
2022-09-07 20:25:49 -04:00
Andrey 6e8d248408 brutal encapsulation 2022-09-07 19:37:11 -04:00
Andrey 2d9dbbd6b8 extracting prime_injection 2022-09-07 16:25:50 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey f1f447df45 tear down Engine god object #4511
just trying different things
2022-09-05 03:38:44 -04:00
Andrey 9a19eaa320 tear down Engine god object #4511
just trying different things
2022-09-05 03:18:32 -04:00
Andrey 99d8801dc6 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 268a5c7964 tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 6d72805a56 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey d51511a15e refactoring: moving field 2022-09-05 00:53:05 -04:00
Andrey ccfe2a5d58 refactoring: splitting header where cpp was already split 2022-09-05 00:48:38 -04:00
Andrey a0b52eeb2f different file names for different entities 2022-09-04 23:11:19 -04:00
GitHub gen-configs Action aed7b77535 Auto-generated configs and docs 2022-09-05 02:44:56 +00:00
Andrey 71e5fbcb55 refactoring: reducing outputChannels copy 2022-09-04 22:38:05 -04:00
GitHub gen-configs Action bc332bf879 Auto-generated configs and docs 2022-09-04 13:57:19 +00:00
Matthew Kennedy b0cbe01673
use defs instead of magic numbers (#4523)
* use defs instead of magic numbers

* consecutive
2022-09-04 09:52:14 -04:00
Matthew Kennedy 9407150544
more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
GitHub gen-configs Action fa3b2fe009 Auto-generated configs and docs 2022-09-03 21:35:26 +00:00
rusefi 2a08cd5c2b refactoring: reducing outputChannels copy 2022-09-03 17:29:35 -04:00
Andrey 632bf967bb refactoring: reducing outputChannels copy 2022-09-03 17:12:47 -04:00
Andrey 6b4e6c8169 tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey bd7b6e6736 tear down Engine god object #4511
just trying different things
2022-09-03 11:05:27 -04:00
Andrey d329f8ae10 tear down Engine god object #4511
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc aef1f19af9 typo 2022-09-03 07:26:49 -04:00
Andrey 759a15c763 dead 2022-09-03 06:59:00 -04:00
GitHub gen-configs Action 244ef7630d Auto-generated configs and docs 2022-09-02 18:42:52 +00:00
rusefillc 25f4ebbc01
moving state into specific class (#4520)
* moving state into specific class

* moving state into specific class
2022-09-02 14:38:03 -04:00
rusefillc f6ae78e72c
another huh (#4517)
* another huh

* why does this not compile
2022-09-02 13:10:21 -04:00
rusefillc 8e46e9e61f
I am sure that's not magic (#4516)
* I am sure that's not magic

* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey f84f69a4d4 another dead line 2022-09-01 21:13:03 -04:00
Andrey 93d28555f6 Revert "tear down Engine god object #4511"
This reverts commit 8d6a87ae21.
2022-09-01 20:44:51 -04:00
Andrey 48f960b581 Revert "tear down Engine god object #4511"
This reverts commit dc60837e4c.
2022-09-01 20:44:51 -04:00
Andrey 532f6dd202 what a mess :( 2022-09-01 20:16:57 -04:00
Andrey dc60837e4c tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 8d6a87ae21 tear down Engine god object #4511
just trying different things
2022-09-01 20:15:46 -04:00
Andrey e6ae70dee6 tear down Engine god object #4511
just trying different things
2022-09-01 19:24:19 -04:00
GitHub gen-configs Action 059b06292b Auto-generated configs and docs 2022-09-01 23:18:26 +00:00
Andrey db9d4c8201 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Andrey fcd0636a01 tear down Engine god object #4511
just trying different things
2022-09-01 19:00:16 -04:00
Matthew Kennedy c4080e7c80
extract updateInjectionAngle (#4512) 2022-09-01 18:48:03 -04:00
Andrey e617722fb1 tear down Engine god object #4511
smallest step maybe forward
2022-09-01 13:55:03 -04:00
Andrey 9d8afea152 a bit of dead code 2022-09-01 11:47:56 -04:00
GitHub gen-configs Action 3d6d710379 Auto-generated configs and docs 2022-09-01 15:03:34 +00:00
Andrey 7e340cceb3 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
GitHub gen-configs Action ea1d2b848f Auto-generated configs and docs 2022-09-01 14:39:52 +00:00
Andrey 56f6c10042 refactoring: reducing outputChannels copy 2022-09-01 10:30:07 -04:00
Andrey e240ac84d3 refactoring: reducing outputChannels copy 2022-09-01 01:06:49 -04:00
Andrey 705dda095e dead code 2022-09-01 00:23:33 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey 4cbaddcc60 less code is better 2022-08-31 23:14:20 -04:00
Andrey fef406a5a6 english do you speak it 2022-08-31 22:56:38 -04:00
GitHub gen-configs Action d848d3e1be Auto-generated configs and docs 2022-09-01 02:17:58 +00:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Matthew Kennedy b6bb5f148d
set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy cbe70f8dec
idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 553b549b95
idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
GitHub gen-configs Action 6e5a2f61da Auto-generated configs and docs 2022-08-29 03:13:09 +00:00
rusefillc deba48e13a TT_VVT_MAZDA_MYSTERY 2022-08-28 22:57:44 -04:00
GitHub gen-configs Action 9484b751b9 Auto-generated configs and docs 2022-08-29 02:18:23 +00:00
rusefillc 4b0c8c9ff2 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
rusefillc 0613b2627e more proper fix for part of https://github.com/rusefi/rusefi/pull/4493 2022-08-27 22:28:29 -04:00
rusefillc 172f054d25
separate atomic change (#4494)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:09:54 -04:00
rusefillc 60cf2cdbcf Default GPPWM note 2022-08-27 15:19:35 -04:00
rusefillc 84ff4e98c0 docs 2022-08-25 23:50:00 -04:00
rusefillc 50a1794851 saving 4 bytes of RAM? 2022-08-25 22:34:16 -04:00
rusefillc 67055c69bf progress or maybe even a fix of logging? 2022-08-25 22:24:35 -04:00
rusefillc 733f9b4659 this code is too dead 2022-08-25 22:09:22 -04:00
Matthew Kennedy 4d66dff87c
dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Andrey cecc5a9d6e https://github.com/rusefi/hellen154hyundai/issues/60
extra logging
2022-08-25 19:58:10 -04:00
GitHub gen-configs Action d048d6522e Auto-generated configs and docs 2022-08-25 22:51:12 +00:00
rusefi ee61bb3c1c https://github.com/rusefi/hellen154hyundai/issues/60 2022-08-25 18:44:23 -04:00
GitHub gen-configs Action cf8d43f412 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy 73abcb044d
log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
GitHub gen-configs Action 37d1073336 Auto-generated configs and docs 2022-08-24 16:16:12 +00:00
rusefi 349e07d554 refactoring 2022-08-24 12:11:11 -04:00
rusefi 35120e07da refactoring 2022-08-24 12:02:39 -04:00
rusefillc 27ce2d569b docs 2022-08-23 22:54:48 -04:00
GitHub gen-configs Action b167dab9cd Auto-generated configs and docs 2022-08-24 02:19:34 +00:00
rusefillc 9fd1b251ec log the state of hasSynchronizedPhase() for future diagnostic help. 2022-08-23 22:14:32 -04:00
GitHub gen-configs Action 237bf1d611 Auto-generated configs and docs 2022-08-22 22:32:47 +00:00
rusefillc fa34b8ab46 // todo: migrate to engineState->desiredRpmLimit to get this variable logged 2022-08-22 18:23:48 -04:00
GitHub gen-configs Action dc86c76c9a Auto-generated configs and docs 2022-08-22 15:19:58 +00:00
rusefillc 299162e413 Pavel Xenon is asking for EGT limping mode #3172 2022-08-22 11:12:34 -04:00
rusefillc 09ec99f192 Idle air add via Lua fix #4465
AddressSanitizer being useful?
2022-08-21 00:58:59 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
Matthew Kennedy 423f69a842
allow logging multiple warnings at once (#4414)
* allow logging multiple warnings at once

* comment

* .Code

* Revert ".Code"

This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.

* add a better comparison operator instead of conversion

* dot code

* Revert "dot code"

This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.

* force gcc-10 maybe?

* Revert "force gcc-10 maybe?"

This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.

* vq

* dot code

* dead

* dot code

* return may be null

* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?

* move static vector

* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
GitHub gen-configs Action 8449099f72 Auto-generated configs and docs 2022-08-17 05:08:02 +00:00
rusefillc db8a965288 unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
rusefillc 5105bc57e3 ISO-TP does not work on real car #4427 2022-08-09 13:12:51 -04:00
Matthew Kennedy 165e5bb869
misc fixes (#4411)
* fix warnings

* break to debugger in case of panic

* move the check

* s
2022-08-02 12:19:50 -04:00
Matthew Kennedy 2096a22319
report injector, ignition faults (#4408)
* report injector, ignition faults

* guard
2022-08-01 15:41:47 -04:00
Matthew Kennedy b6f1779781
implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc c81ede01de [SECURITY] Cheap password protection against tune modification fix #4243
helping build
2022-07-30 14:33:11 -04:00
rusefillc 26ae6f7490 [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
Matthew Kennedy 923d2c2e44
unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
GitHub build-firmware Action 04462839f5 Auto-generated configs and docs 2022-07-27 09:38:56 +00:00
Matthew Kennedy d4b8a036af
Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 9b83ee7d6e cherry pick https://github.com/rusefi/rusefi/pull/4365 2022-07-21 15:26:41 -04:00
rusefillc 4987a0b93c Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
rusefillc 991ec1c8ef Launch control bug? "range" thing is confusing #4348 2022-07-20 18:39:17 -04:00
rusefillc a03d927638 Launch control bug? "range" thing is confusing #4348
bug or dead code? at least making it a bit more obvious
2022-07-20 18:30:20 -04:00
rusefillc 99ad5045df Launch control bug? "range" thing is confusing #4348
refactoring: reducing confusion
2022-07-20 18:24:36 -04:00
rusefillc 0e2907328b code formatting #4348 2022-07-20 18:16:54 -04:00
Matthew Kennedy a0d8ae3f4f
use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
rusefillc 975329fcc7 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 14:04:21 -04:00
rusefillc 39df02fe35 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
rusefillc cad14d6541 #4308 progress 2022-07-14 12:36:55 -04:00
rusefillc 67ec949eb6 Lua A/C Input #4333 2022-07-08 00:51:53 -04:00
GitHub build-firmware Action e45990462c Auto-generated configs and docs 2022-07-08 04:45:52 +00:00
rusefillc 71b118e858 Lua A/C Input #4333 2022-07-08 00:25:29 -04:00
Matthew Kennedy 5d844b1ebe
Error handling cleanup (#4332)
* dead code in stm32

* rusefi.cpp can have some noreturn

* handle lua panic

* unused error codes

* simplifications of error_handling.cpp

* comment

* put that back

* guard
2022-07-07 23:49:02 -04:00
GitHub build-firmware Action 0de824883f Auto-generated configs and docs 2022-07-08 03:21:52 +00:00
Matthew Kennedy 3c062e02bc
Lua hooks for gear detection (#4328)
* implement

* sim has vss

* write a test

* guard
2022-07-07 23:16:56 -04:00
rusefillc 9e26fe007e debug is set to idle mode, but none of the debug fields show anything #4335
reducing confusion
2022-07-07 23:04:19 -04:00
Matthew Kennedy e9d092f975
big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy 0b10f7dca8
hellen board ID detect improvements (#4307)
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
rusefillc 82131e5572 Uniform reset pattern for all Lua adjustments #4308
no progress only preparation
2022-06-30 20:07:27 -04:00
GitHub build-firmware Action 3a3dbc9023 Auto-generated configs and docs 2022-06-30 17:53:57 +00:00
rusefillc 924e25fe96 https://github.com/rusefi/rusefi_documentation/issues/226 2022-06-30 13:38:15 -04:00
rusefillc 483395fa2e
https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
Matthew Kennedy 3284282be7
rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
GitHub build-firmware Action b33f32d20c Auto-generated configs and docs 2022-06-29 22:16:13 +00:00
Matthew Kennedy 29e5a0babb
use detected hellen board type on h72 (#4305)
* use detected hellen board type

* s

* s

* name
2022-06-29 18:10:29 -04:00
Andrey 5cf0265968 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc c0960270a8 logging of live data structs was: data points #3614 2022-06-29 03:03:02 -04:00
rusefillc aab466094c logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc f7ecebaa64 logging of live data structs was: data points #3614 2022-06-29 02:37:24 -04:00
GitHub build-firmware Action a8c3769906 Auto-generated configs and docs 2022-06-29 06:21:31 +00:00
rusefillc aec1900278 logging of live data structs was: data points #3614 2022-06-29 02:16:15 -04:00
rusefillc a6e7d35461 logging of live data structs was: data points #3614 2022-06-29 02:09:37 -04:00
GitHub build-firmware Action 171bc28d38 Auto-generated configs and docs 2022-06-29 06:06:27 +00:00
rusefillc 241f2765e9 logging of live data structs was: data points #3614 2022-06-29 01:49:59 -04:00
rusefillc ef6bef1b82 logging of live data structs was: data points #3614 2022-06-29 01:38:43 -04:00
rusefillc bdb9eaa2f5 logging of live data structs was: data points #3614 2022-06-29 01:27:42 -04:00
GitHub build-firmware Action 9798e6e22a Auto-generated configs and docs 2022-06-29 05:23:15 +00:00
rusefillc e26a4085a0 https://github.com/rusefi/hellen-NB2-issues/issues/36 2022-06-29 01:15:11 -04:00
GitHub build-firmware Action df70173ad1 Auto-generated configs and docs 2022-06-27 00:12:14 +00:00
rusefillc eabffc9ef8 stealing from David 2022-06-26 19:40:54 -04:00
Matthew Kennedy c0f290b922
Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
GitHub build-firmware Action 55b9e384cf Auto-generated configs and docs 2022-06-24 00:20:41 +00:00
Matthew Kennedy 29420c76aa
wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy b92c0149d6
get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 9d62aeb81f
force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
rusefi 983682d11f miata 96 defaults 2022-06-23 14:30:41 -04:00
Matthew Kennedy 4d7fe35c5c
clean up sd overrides (#4272) 2022-06-23 09:15:51 -04:00
GitHub build-firmware Action eab2328dea Auto-generated configs and docs 2022-06-20 15:49:50 +00:00
rusefillc a4347668c5 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
GitHub build-firmware Action 7d8bf4be8b Auto-generated configs and docs 2022-06-20 11:50:51 +00:00
rusefillc d639a42621 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
Matthew Kennedy 7e8ae7c8a3
Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi a552d58d42 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 172479e2af
fix (#4254) 2022-06-17 21:20:47 -04:00
Matthew Kennedy 932f5e1f30
cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit 32d46d1f09.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit d5e131b1d0.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-firmware Action 0c17b9c781 Auto-generated configs and docs 2022-06-02 01:31:50 +00:00
Matthew Kennedy 4ada633206
Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy c0d8cbfef4
Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy f945e6efc9
trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
rusefillc a2af7895bb TS injector bench test pulse is too short fix #4192 2022-05-22 09:43:09 -04:00
rusefillc 4a9789e6c4 B6 test mule 2022-05-21 02:25:43 -04:00
GitHub build-firmware Action b4de5f2155 Auto-generated configs and docs 2022-05-21 05:58:46 +00:00
rusefillc 8c6dee61a5 B6 test mule 2022-05-21 01:45:09 -04:00
GitHub build-firmware Action 884ea922af Auto-generated configs and docs 2022-05-18 04:16:08 +00:00
Matthew Kennedy c6f46128d6
prototype overcurrent protected driver (#4029)
* stub passthrough protected driver

* plumbing

* include the thing

* signature

* dead

* tdg pdm build task

* s

* pdm pins

* tdg

* init properly

* remove gaps

* board doesn't fatal on start
2022-05-17 23:49:18 -04:00
GitHub build-firmware Action d12e7efb53 Auto-generated configs and docs 2022-05-18 03:21:00 +00:00
Matthew Kennedy fe77f5127e
12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
rusefillc a90f806073 PDM dreams 2022-05-17 21:18:43 -04:00
rusefillc df7a6d1367 default VR curve is needed not just by hellen, we have Proteus adapters with it now! 2022-05-17 17:54:11 -04:00
rusefillc e54fb367a0 dead code 2022-05-15 10:13:47 -04:00
Matthew Kennedy 1b311ee3c7
no enum to string for obd (#4168) 2022-05-13 06:41:06 +03:00
rusefillc 4fece64237 docs 2022-05-12 04:56:23 -04:00
GitHub build-firmware Action 01e09cab69 Auto-generated configs and docs 2022-05-11 10:51:10 +00:00
Matthew Kennedy 907adc6583
remove 360 trigger (#4165)
* remove 360

* s

* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy 170d574a5d
move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy d4509cab8a
TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 76ccb19453
clarify doesTriggerImplyOperationMode (#4153) 2022-05-09 15:28:30 -04:00
rusefillc 2132cec3fc Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
rusefillc bfc5076a87 User was unable to find Ford Mustang firing order 1-5-4-2-6-3-7-8 in the list #4150 2022-05-08 07:11:53 -04:00
rusefillc 7df4f36f88 Revert "Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150"
This reverts commit 76243afa9c.
2022-05-08 07:10:54 -04:00
rusefillc 76243afa9c Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150 2022-05-08 07:07:34 -04:00
GitHub build-firmware Action 74ffc6f81c Auto-generated configs and docs 2022-05-06 12:32:54 +00:00
Matthew Kennedy b650bbe46c
Trigger gm 3 vs 5 (#4140)
* add parameter

* two modes

* add new mode to list

* format

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
rusefillc 3b3f62b24f Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
GitHub build-firmware Action bfa5a558a9 Auto-generated configs and docs 2022-05-02 09:02:46 +00:00
Andrey beee828b6f Technical debt: ENUM_32_BITS #3874
one step back
2022-05-02 04:38:04 -04:00
GitHub build-firmware Action 063cc702f2 Auto-generated configs and docs 2022-05-02 08:21:38 +00:00
rusefillc 7db9361487
Next steps 4 (#4130)
* Technical debt: ENUM_32_BITS #3874

* Make ETB low limit configurable #4119

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-02 04:13:59 -04:00
Andrey e62877964a Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
GitHub build-firmware Action e6d79e1124 Auto-generated configs and docs 2022-05-02 03:14:48 +00:00
rusefillc e98f331cda Technical debt: ENUM_32_BITS #3874 2022-05-01 23:07:12 -04:00
GitHub build-firmware Action 6c974c550f Auto-generated configs and docs 2022-05-01 19:20:46 +00:00
rusefillc 34cc49769d Technical debt: ENUM_32_BITS #3874
hmm one step back
2022-05-01 15:13:01 -04:00
GitHub build-firmware Action 09b762f1bb Auto-generated configs and docs 2022-05-01 18:18:04 +00:00
rusefillc a04da5c19d Technical debt: ENUM_32_BITS #3874 2022-05-01 13:51:36 -04:00
GitHub build-firmware Action 3a5e3b4d66 Auto-generated configs and docs 2022-05-01 12:09:38 +00:00
rusefillc 05f8d4600b
Next steps (#4120)
* Technical debt: ENUM_32_BITS #3874

* Technical debt: ENUM_32_BITS #3874

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-01 08:02:51 -04:00
GitHub build-firmware Action dec0542703 Auto-generated configs and docs 2022-04-30 18:29:47 +00:00
rusefillc 107685f069 this seems mostly dead? 2022-04-30 13:43:09 -04:00
rusefillc 2cfcba4a94 oh not all dead 2022-04-30 13:35:25 -04:00
rusefillc 57e61a1cc0 Technical debt: ENUM_32_BITS #3874 2022-04-30 13:16:34 -04:00
rusefillc 2785bff950 wow dead code 2022-04-30 13:09:03 -04:00
GitHub build-firmware Action 1c18b167d8 Auto-generated configs and docs 2022-04-30 17:07:03 +00:00
rusefillc 6798a74f3d Technical debt: ENUM_32_BITS #3874 2022-04-30 12:54:12 -04:00
GitHub build-firmware Action 8408efe6d2 Auto-generated configs and docs 2022-04-30 02:32:30 +00:00
Andrey c1e46a3c1c CAN GPIO #4096 2022-04-29 22:15:54 -04:00
GitHub build-firmware Action 3968a76e6e Auto-generated configs and docs 2022-04-30 00:36:25 +00:00
rusefillc 349a1f27ee CAN GPIO #4096 2022-04-29 20:29:50 -04:00
rusefillc 571211501e
2 byte pin index #4097 (#4102)
* 2 byte pin index #4097

* 2 byte pin index #4097

good time to defragment configuration

* 2 byte pin index #4097

new fancy way

* 2 byte pin index #4097

smart comment

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-04-29 19:35:31 -04:00
GitHub build-firmware Action 0e10e79613 Auto-generated configs and docs 2022-04-28 22:06:22 +00:00
Matthew Kennedy e4a0979dc2
Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy 38213bbc00
more missing autoscale (#4112)
* autoscale m_config->timeConstant

* min/max afr

* more

* dwell voltage

* closed loop fuel

* knock

* map estimate

* applyNonlinearBelowPulse

* fix

* add a test while we're at it for un-covered code

* test fallback MAP since we touched that

* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
Matthew Kennedy bc6a87cadc
allow enum_class in rusefi_hw_enums.h (#4104)
* make things c++ friendly

* install various canaries in coal mines

* using is much clearer than typedef

* fixing builds

* lps25

* trigger includes were a mess

* c -> c++ cleanup

* os util

* why did so many include os_util.h?

* fwd declare

* cypress/kinetis

* s

* eg33 happy

* happy sim

* cypress usb

* pch

* cypress

* doesn't need to include all that

* h7
2022-04-25 20:38:16 -04:00
rusefillc 442d829f8a [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:42:19 -04:00
rusefillc 3ea21ba4bf [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:20:56 -04:00
rusefillc 14e37e3cf4 FasterEngineSpinUp should be enabled by default fix #4094 2022-04-23 09:51:47 -04:00
David Holdeman 49f8daae14
More untested transmission features (#4093)
* use ISS for gearbox ratio, add gauge for TC ratio

* measure shift time

* add shift time gauge, todo notes for pc

* do conversion in the right direction

* switch to Timer and seconds

* try fixing build

* try fixing build again

* try defines, remove include

* use shift pcs

* add 3-2 pct curve

* control 3-2 solenoid

* move 3-2 to persistent config

* fix param
2022-04-23 07:34:39 -04:00
rusefillc edb65b660e https://github.com/rusefi/alphax-2chan/issues/50 2022-04-19 20:43:41 -04:00
GitHub build-firmware Action f8974c8f26 Auto-generated configs and docs 2022-04-18 21:53:02 +00:00
rusefillc 3b483986c0 life is better without special characters 2022-04-18 17:36:28 -04:00
rusefillc e715bcc01f actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc e59ae35196 unique field names 2022-04-18 11:11:57 -04:00
Matthew Kennedy 16de438ab8
knock threshold table fix (#4077)
* fix knock threshold table

* defaults

* knock controller is engine module

* testable

* test builds

* knock tests work

* s

* format

* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc 5a73ef1ae6 minor fix 2022-04-17 22:48:57 -04:00
GitHub build-firmware Action a2cff4ee12 Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 82f608d558 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 08c50cc1dd logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
GitHub build-firmware Action bde3acaefe Auto-generated configs and docs 2022-04-16 23:33:47 +00:00
rusefillc 080d8a3f5e logging of live data structs was: data points #3614 2022-04-16 19:18:03 -04:00
rusefillc 06e899e1bb very random progress 2022-04-16 17:07:57 -04:00
GitHub build-firmware Action 3c6c71854c Auto-generated configs and docs 2022-04-15 14:34:37 +00:00
Matthew Kennedy 497e7ffe77
allow setting injection phase by start or center of injection (#4068)
* allow SOI/COI

* other change

* renames and simplify

* clean up ownIndex

* double check in spark logic
2022-04-15 10:22:36 -04:00
rusefillc 4834683dc6 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 413e636d4c typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc 3c7eb93fe1 steps towards ignition live data 2022-04-13 16:48:25 -04:00
rusefillc 98b9c7c89a Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:51:11 -04:00
rusefillc b889470cd3 Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:43:05 -04:00
rusefillc ec108e7029 Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:34:44 -04:00
rusefillc d2205a7fd6 Set sensible default for dwell by voltage multiplier table fix #4067 2022-04-13 15:21:44 -04:00
rusefillc a90ca2b200 Hellen NB2 default tune #4038 2022-04-10 19:11:34 -04:00
Matthew Kennedy 92eab7f3ba
check voltage instead of temperature (#4062) 2022-04-10 17:41:41 -04:00
rusefillc 19007ade64 MRE QC build broken #4059 2022-04-10 15:48:35 -04:00
rusefi 155b3ec8bb MRE QC build broken fix #4059
nasty work-around
2022-04-09 19:13:55 -04:00
Matthew Kennedy bd2b5a3dba
gear detection validation (#4053)
* gear detection validation

* test validation because why not
2022-04-09 08:59:07 -04:00
rusefillc e1235c4f2e Air Conditioning Improvements #4054 2022-04-09 00:26:52 -04:00
Matthew Kennedy f0b810a81c
Gear detection implementation (#4052)
* gear detect improvements

* ui

* ui for gear ratios

* ui

* output channel

* output channels etc

* implement gear detection

* name

* s

* status loop

* missing function

* ui tweaking

* s
2022-04-07 09:21:11 -04:00
GitHub build-firmware Action 65922c2bd0 Auto-generated configs and docs 2022-04-06 21:44:03 +00:00
David Holdeman f305db2575
Add interface for selecting GearController and TransmissionController classes (#4048)
* save changes

* save changes

* save changes

* fix mistakes

* try adding empty method

* copy simpleTransmissionController to GM 4L6X controller

* Import 4l6x header

* add to makefile

* fix whitespace

* try enum class

* change field name

* change field name in rusefi.input

* check for gear controller mode

* add mode fields to catch if mode was changed
2022-04-06 17:37:30 -04:00
Matthew Kennedy ad368b2031
Gear detection improvements (#4047)
* gear detect improvements

* ui

* ui for gear ratios

* ui
2022-04-06 16:15:58 -04:00
GitHub build-firmware Action f436a6c0ea Auto-generated configs and docs 2022-04-04 21:49:00 +00:00
Matthew Kennedy dfe6bfb8a9
Flex fuel cranking improvements (#4043)
* improve flex cranking

* call it e85

* don't re-warn

* warning name

* ui
2022-04-04 17:41:36 -04:00
Andrey 4f7793649d MAP value thresholds #4030 2022-04-03 18:48:34 -04:00
rusefillc e631988b22 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
rusefillc 291d90ff48 Proper cam speed labels in triggers #4021
i cannot explain this since line so let's remove it
2022-04-03 12:15:19 -04:00
Matthew Kennedy 289122c0b7
fix 4032 (#4034)
* fix 4032

* board defaults should not set these things
2022-04-03 06:58:25 -04:00
Andrey 204ac3961b Trigger setup in TS is highly confusing: hide operation mode from users? #4031
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey cc9a1136c4 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 02:21:37 -04:00
Andrey 9d335c1261 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
Andrey 6aa948a666 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:43:28 -04:00
Andrey 95d36b37e3 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:34:18 -04:00
Andrey a43aec4e60 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-02 23:50:39 -04:00
rusefillc 6b5747d4c8 refactoring: method rename 2022-04-02 21:01:29 -04:00
GitHub build-firmware Action 84054ff11b Auto-generated configs and docs 2022-03-22 10:41:38 +00:00
Andrey b3fdd790b5 new VVT trigger shape? #1847 2022-03-22 06:34:22 -04:00
Matthew Kennedy f742ae8b7e
limp mangaer handles more stuff (#3983) 2022-03-20 09:28:17 -04:00
GitHub build-firmware Action 9849062ed5 Auto-generated configs and docs 2022-03-20 02:18:41 +00:00
Andrey 625af513fb Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:11:51 -04:00
Andrey 402f36aad6 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:06:19 -04:00
GitHub build-firmware Action 5b77405c32 Auto-generated configs and docs 2022-03-19 21:01:59 +00:00
rusefillc 9bc4094e48 Mitsubishi 6G75 Support #4014 2022-03-19 16:28:06 -04:00
GitHub build-firmware Action 418eba526d Auto-generated configs and docs 2022-03-19 20:10:50 +00:00
rusefillc b0772612cd Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 15:54:43 -04:00
rusefillc 9571f1fe67 Mitsubishi 4B11 support #4013 2022-03-19 15:52:42 -04:00
rusefillc 3bfe7f1725
TPS AE engages during crank fix #3996 (#3997)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-03-19 13:05:44 -04:00
GitHub build-firmware Action 645ebe2f20 Auto-generated configs and docs 2022-03-19 16:32:09 +00:00
rusefillc aa7624950a Mitsubishi 3A92 Support (Issue #4011) 2022-03-19 12:01:57 -04:00
rusefillc ed16f3180f JNI for test coverage #3965 and code style 2022-03-15 10:32:32 -04:00
Matthew Kennedy 0937de1b84
flash storage uses 32 bit CRC (#3984)
* better flash logic and warning message

* comment

* s

* ssssss

* simplify logic

* use 32 bit crc

* s

* don't test things that don't exist
2022-03-08 23:17:35 -05:00
Andrey G 067055095f
cli registry: rework this hell, add FFF and FFFFF (#3964)
* cli registry: rework this hell, add FFF and FFFFF

* kinetis: no nodefaultlib

* revert back token helpers

* cli_registery: argument parser: do not eat qoutes

* Unit test for FFF

* cli_registry: remove debug
2022-02-26 16:58:10 -05:00
Matthew Kennedy 307b33837d
core 8 overrides and stepper-as-brain-pin (#3962)
* core 8 overrides and stepper-as-brain-pin

* oops, change the pin not the mode

* a little bit of #3963 makes everyone happy
2022-02-26 09:14:37 -05:00
rusefillc 2ab8a3df4e Feature request: odometer for engine break #3857 2022-02-25 00:46:45 -05:00
Matthew Kennedy 1af68ff30b
fix gap override logic (#3946) 2022-02-18 17:13:45 -08:00
rusefillc c945d48e2b better default 2022-02-10 00:53:44 -05:00
rusefillc 78675bf57b better default DEFAULT_ENGINE_TYPE 2022-02-09 19:49:41 -05:00
rusefillc 4df1467a3a N73 2022-02-09 17:29:09 -05:00
Matthew Kennedy f1897ba7aa
less dependence on that logger (#3884)
* less dependence on that logger

* comma

* refactor a bit, make it clear what this thing actually *does*

* static

* shrink the buffer a bit and make names useful

* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
GitHub build-firmware Action c5a71ed66b Auto-generated configs and docs 2022-02-08 21:21:12 +00:00
Andrey G 2ac26d2433
IMU: add imu type for Mercedes pn A 006 542 26 18 (#3901) 2022-02-08 16:00:16 -05:00
rusefillc d6b4ad9725 Feature request: odometer for engine break #3857 2022-02-06 22:03:47 -05:00
rusefi 998cba5521 EFI_LAUNCH_CONTROL clean-up 2022-02-06 18:46:09 -05:00
rusefi c50bf8666b helping build 2022-02-06 18:13:35 -05:00
GitHub build-firmware Action 7f87cf17b3 Auto-generated configs and docs 2022-02-06 19:04:42 +00:00
rusefi d45b8361c2 I2C EEPROM support #3860 2022-02-06 13:59:08 -05:00
rusefi 7e96c3ee05 L9779WD driver L9779 #3768 2022-02-06 13:56:50 -05:00
GitHub build-firmware Action e747b3b681 Auto-generated configs and docs 2022-02-06 17:57:16 +00:00
rusefillc 51e9b1a50a I2C EEPROM support #3860 2022-02-06 12:39:41 -05:00
Matthew Kennedy d8073e8b27
remove mock adc (#3888)
* remove mock adc

* do these do /anything/?
2022-02-03 20:43:34 -05:00
Matthew Kennedy 06437f304f
dead StartupFuelPumping (#3883)
* dead

* test

* dead config too
2022-02-03 08:01:21 -05:00
GitHub build-firmware Action e98ab8433e Auto-generated configs and docs 2022-02-02 07:19:22 +00:00
Matthew Kennedy 10be2d5f40
Remove FSIO, byeeeeeeeee (#3865)
* vestigial config

* replace last functionality

* engine/board configs include

* files that didn't need to include this

* remove FSIO implementation

* stragglers

* random little bits

* s

* s

* ConfigDefinition

* jar

* s
2022-02-02 02:03:31 -05:00
Matthew Kennedy 40d16291b0
Remove fsio part 2 (#3876)
* dead config stuff

* fsio state

* remove tests

* getEngineValue

* put part back
2022-02-02 00:49:44 -05:00
rusefillc 1e91573219 packing unused 2022-02-01 22:19:24 -05:00
rusefillc b26ef2dcfa packing unused 2022-02-01 22:07:42 -05:00
rusefillc b35bc94b32 packing unused 2022-02-01 22:05:13 -05:00
rusefillc ba830089c8 packing unused 2022-02-01 22:02:35 -05:00
rusefillc a41afb5eac packing unused 2022-02-01 21:50:44 -05:00
Matthew Kennedy d2d73b6fcf
remove me7pnp (#3878)
* remove

* s

* HW_MICRO_RUSEFI
2022-02-01 21:46:06 -05:00
Matthew Kennedy c2eab94534
flex cranking math (#3791)
* flex cranking math

* simplify

* s

* simplify
2022-02-01 20:53:14 -05:00
rusefillc 751355a04b
Limp shutdown rebase (#3879)
* limp manager handles engine stop

* use timer

* dead relevant fsio

* this stuff needs its own ticket

* if we can comment out 'business logic' and tests do not fail it's not a great sign :(

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-01 20:47:17 -05:00
GitHub build-firmware Action be547d3717 Auto-generated configs and docs 2022-02-01 22:42:35 +00:00
Andrey G bbe9eb6c5c
enum: add pins for L9779WD-SPI and L9779WD (#3872) 2022-02-01 16:41:45 -05:00
rusefillc 5b63faafa0 Technical debt: ENUM_32_BITS #3874 2022-02-01 16:41:23 -05:00
Matthew Kennedy a718f3a30a
Remove fsio part 1 (#3871)
* dead includes

* move last logic out of fsio

* dead functions
2022-02-01 15:42:04 -05:00
rusefillc ca98e270e1
safer file name (#3861)
* safer file name

* safer file name

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-01-31 21:51:32 -05:00
Matthew Kennedy c6f45c5022
warnings fixes (#3851)
* unused things

* !!! actual bug !!!

* dead

* unused

* unused

* multi-bus lua RX was just broken

* make the compiler angry about it

* dead config

* alphax 2

* just call, no store

* compiler too angry
2022-01-31 18:37:42 -05:00
GitHub build-firmware Action 10b18f086a Auto-generated configs and docs 2022-01-31 23:26:47 +00:00
rusefillc 1d64929f33 Remove Miata MX5 NB1 trigger fix #3488 2022-01-31 18:20:43 -05:00
GitHub build-firmware Action 2cd4dede4f Auto-generated configs and docs 2022-01-30 14:01:11 +00:00
Matthew Kennedy 40e96a03d5
table for tcharge interpolation (#3855)
* extract getTChargeCoefficient

* new table
2022-01-30 08:45:11 -05:00
Matthew Kennedy 28950acf3e
disable fuel trim shortly after DFCO (#3847)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* disable closed loop fuel after dfco1

* I can't type

* correct comparison helps

* poke
2022-01-28 21:35:23 -05:00
rusefillc acc6bb6e0b this stuff is dead 2022-01-28 19:52:12 -05:00
Matthew Kennedy 62794ba105
complex wall wetting model (#3849)
* extract logic

* extract interface

* explicitly test wall fuel

* complex wall model tables

* fix unused chunk

* defaults

* doesn't like constexpr scaled_channel
2022-01-28 00:32:36 -05:00
GitHub build-firmware Action de947d2c64 Auto-generated configs and docs 2022-01-27 23:44:58 +00:00
rusefillc d567f2f852 reducing magic constants & pedal calibration 2022-01-27 18:28:42 -05:00
GitHub build-firmware Action 1f664d8b5b Auto-generated configs and docs 2022-01-27 22:59:57 +00:00
rusefillc 1cf898e6e2 reducing magic constants 2022-01-27 17:39:46 -05:00
Matthew Kennedy 2444090933
vss based dfco (#3845)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* even better than comments are tooltips
2022-01-27 14:05:18 -05:00
Matthew Kennedy 966e51cbc6
more tps accel data (#3844) 2022-01-27 07:46:13 -05:00
Matthew Kennedy eb14d74846
extract logic from wall wetting AE (#3848)
* extract logic

* extract interface

* explicitly test wall fuel
2022-01-27 07:45:50 -05:00
GitHub build-firmware Action c59cde8be1 Auto-generated configs and docs 2022-01-25 02:04:47 +00:00
rusefillc 32c1cd09da https://www.rusefi.com/forum/viewtopic.php?p=44166#p44166
launch control live data
2022-01-24 20:58:21 -05:00
Matthew Kennedy df1635b5a0
dfco checks driver throttle intent (#3832) 2022-01-24 14:26:39 -05:00
GitHub build-firmware Action e584ef198c Auto-generated configs and docs 2022-01-24 02:55:57 +00:00
Matthew Kennedy 717d931e78
refactor decel fuel cut (#3830)
* refactor dfco

* s

* output channel logs dfco

* slightly cheeky comment
2022-01-23 19:44:41 -05:00
rusefillc 304b45e039 https://www.rusefi.com/forum/viewtopic.php?p=44166#p44166 2022-01-23 19:44:14 -05:00
Matthew Kennedy b5232ab5e6
decouple TPS accel enrichment from trigger (#3825)
* move call site

* move thresholding out of fast path

* adjust config

* test
2022-01-23 15:31:39 -05:00
rusefi bb54fb346d but we need valid default 2022-01-21 15:22:11 -05:00
Andrey 1bd71e4b2e migrating to SensorType::Rpm API 2022-01-20 23:54:52 -05:00
Andrey 4ebb3c94d3 migrating to SensorType::Rpm API 2022-01-20 23:43:18 -05:00
Andrey cda2b711cf migrating to SensorType::Rpm API 2022-01-20 23:32:59 -05:00
Andrey e55eb28086 migrating to SensorType::Rpm API 2022-01-20 22:42:13 -05:00
Andrey 3bc59bfbb6 migrating to SensorType::Rpm API 2022-01-20 22:27:48 -05:00
Andrey 3183a123cd migrating to SensorType::Rpm API 2022-01-20 22:26:05 -05:00
Andrey 9f08db256b migrating to SensorType::Rpm API 2022-01-20 22:12:04 -05:00
Matthew Kennedy 76fdb4063e
XY Idle VE Table (#3781)
* config & ui

* implement

* test idle VE switching behavior

* use the interface where we can

* s

* re-bump flash version
2022-01-20 14:08:54 -05:00
rusefillc bc66096574 Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
rusefillc 1c5ad3d153 AlphaX 2022-01-17 20:22:51 -05:00
rusefillc 5a9a563e63 https://github.com/rusefi/alphax-2chan/issues/16 2022-01-15 10:36:49 -05:00
rusefillc 71b2dc762a https://en.wikipedia.org/wiki/Pi 2022-01-14 21:23:27 -05:00
Matthew Kennedy c9350fc3cb
Revert "forced 4 byte thing is actually no longer needed so much" (#3785)
* Revert "forced 4 byte thing is actually no longer needed so much"

This reverts commit 364783f658.

* bump flash version to force a re-write
2022-01-12 21:59:21 -05:00
Matthew Kennedy 7d341cfc9d
improve maf output channels and logging (#3743)
* maf channels

* s

* binary log

* if only I could type

* can

* instant RPM too

* s

* test

* graceful zero rpm

* test works

* float near
2022-01-12 15:41:35 -05:00
rusefillc 240c6fe8b6 GDI red FATAL led on cranking fix #3766 2022-01-12 01:01:33 -05:00
rusefillc dcc7080ce1 logging of live data structs #3614 2022-01-11 22:54:57 -05:00
rusefillc 963c168788 Code style for methods with zero arguments #3535 2022-01-11 22:26:24 -05:00
rusefillc 6ee0a55eaf RE usability: live data for idle controller 2022-01-10 19:48:58 -05:00
rusefillc 0d8e4d5222 AlphaX few bytes of progress 2022-01-10 01:47:06 -05:00
Andreika 1b9037314a
Hellen mcu module detector (experimental) (#3756)
* Hellen mcu module detector (experimental)

* make unit-tests happy

* make unit-tests even more happy

* move Hellen-specific stuff to hellen_common.cpp

* fix other hellen config builds

* helping non-Hellen builds too

* helping alpha2ch build

* helping build

* cleanup

* help unit-tests

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2022-01-09 17:40:08 -05:00
rusefillc 212687dd10 extracting common hellen to it's own file 2022-01-08 20:16:01 -05:00
rusefillc a13a0a2cc9 mk files refactoring 2022-01-06 20:32:39 -05:00
rusefillc 25ca48c408 Live Data progress 2022-01-06 17:58:59 -05:00
GitHub build-firmware Action 2208947bb3 Auto-generated configs and docs 2022-01-05 06:49:51 +00:00
rusefillc 364783f658 forced 4 byte thing is actually no longer needed so much 2022-01-05 00:24:17 -05:00
GitHub build-firmware Action 38b17f5859 Auto-generated configs and docs 2022-01-05 05:09:04 +00:00
GitHub build-firmware Action 7b131dc5c7 Auto-generated configs and docs 2022-01-04 03:39:23 +00:00
rusefillc c7ea8c6e03 helping build: sharing same brain_pin_diag_e 2022-01-03 22:33:38 -05:00
rusefillc 914deedb0f TLE8888 diag says OK on disconnected pins and bench test #3737 2022-01-03 20:33:51 -05:00
rusefillc 21f3f26506 benchTest flexibility 2022-01-03 03:35:26 -05:00
rusefillc e9498f64db GDI/HPFP: Set HPFP current/timing params on MC33816 #3736 follow-up 2022-01-03 02:13:47 -05:00
rusefillc d8de52d325 live data progress 2022-01-02 13:57:58 -05:00
rusefillc 6eb438acd6 why so many channels are hidden in debug ? #3614 2022-01-02 02:04:25 -05:00
Matthew Kennedy 338c14c3a8
cylinder ignition trim (#3709)
* cylinder ignition trim

* changelog

* changelog

* test

* move UI
2022-01-01 15:47:47 -05:00
rusefillc 9dc4efe993 reducing potential confusion with "NO PIN" in engine sniffer
https://rusefi.com/forum/viewtopic.php?p=43812#p43812
2022-01-01 12:10:55 -05:00
Matthew Kennedy ab3e3ac83f
hook up fuel trims (#3715)
* hook up fuel trims

* pass all the params

* store per-cylinder fuel mass directly

* main trigger callback only touches per-cylinder, no banks!

* test test test test

* move UI to happy land

* changelog
2022-01-01 02:19:59 -05:00
Matthew Kennedy d5c4b79b1a
Nb2 crank sync special case (#3727)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
rusefillc f715210b39 GDI Epic #1448
live view
2021-12-31 15:28:24 -05:00
GitHub build-firmware Action 35655b2186 Auto-generated configs and docs 2021-12-30 02:53:30 +00:00
rusefillc d83b7f19af HellenNA8_96 config folder #3724 2021-12-29 21:23:47 -05:00
rusefillc 1856ff7ac0 reviving Passat 2021-12-29 20:24:04 -05:00
GitHub build-firmware Action 7118f8d5b7 Auto-generated configs and docs 2021-12-27 17:15:43 +00:00
Matthew Kennedy 95ad75318d
improved noFiringUntilVvtSync logic (#3696)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc 8f68e8e646 refactoring - enum has more usages now 2021-12-26 14:53:27 -05:00
rusefillc 6665c4fb34 docs 2021-12-26 13:41:10 -05:00
rusefillc b337fed520 live data 2021-12-26 13:00:17 -05:00
rusefillc 7cb3eb4c9a live data 2021-12-26 13:00:17 -05:00
rusefillc 9f8ccececd docs & refactoring 2021-12-26 12:35:41 -05:00
rusefillc 63c6621dd0 E65 2021-12-23 16:59:30 -05:00
GitHub build-firmware Action 2c645bd130 Auto-generated configs and docs 2021-12-23 21:46:59 +00:00
rusefillc 713e9133b5 E65 2021-12-23 16:41:06 -05:00
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
Matthew Kennedy 3a4a0ba18d
simplify some table lookups (#3692)
* simplify

* expand interpolation test
2021-12-20 08:14:30 -05:00
Matthew Kennedy 0810198185
clean up timing table defaults (#3705)
* less crazy configs

* cleanup

* make that test happy
2021-12-20 08:02:38 -05:00
rusefillc 66f82a0cdb 2 byte table axis #3045 2021-12-19 22:43:10 -05:00
rusefillc 8bc542b40b https://github.com/rusefi/hellen154hyundai/issues/49 2021-12-17 16:39:12 -05:00
rusefillc 4292c2fb1d MAP phase sensing fix #3544
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc 06ccf524dd MAP phase sensing #3544
removing dead implementation
2021-12-16 21:13:55 -05:00
rusefillc f27b4dbd95 dead code? 2021-12-16 21:06:23 -05:00
GitHub build-firmware Action 1de1809074 Auto-generated configs and docs 2021-12-16 21:24:43 +00:00
rusefillc f685bab9eb live data for wastegate and launch control #3588 2021-12-16 16:19:33 -05:00
rusefillc 6542533946 live data for wastegate and launch control #3588 2021-12-16 15:17:35 -05:00
rusefillc 81759802d0 live data for wastegate and launch control #3588 2021-12-16 14:47:00 -05:00
rusefillc 655f12b45d live data for wastegate and launch control #3588 2021-12-16 14:29:39 -05:00
rusefillc 804d396fd6 live data for wastegate and launch control #3588 2021-12-16 14:28:01 -05:00
rusefillc 31ed18fe84 clutch input via CAN #3605 2021-12-15 19:20:07 -05:00
rusefillc b3a240f893 clutch input via CAN #3605 2021-12-15 17:48:21 -05:00
Matthew Kennedy 4148ee76bf
smarter priming logic (#3674)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
2021-12-08 16:20:19 -05:00
Matthew Kennedy 2050580a16
prime upon ignition voltage, not on power on (#3662)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* test

* dead adjacent line of code
2021-12-08 07:26:49 -05:00
GitHub build-firmware Action 161d75197d Auto-generated configs and docs 2021-12-08 12:10:47 +00:00
Matthew Kennedy c83e8ae5a5
AiM dash (#3673)
* aim dash

* enum
2021-12-08 07:04:59 -05:00
Matthew Kennedy 91ec135cf8
ignition controller detects rising edge on voltage (#3636)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test
2021-12-07 21:28:04 -05:00
Andrey 50038167d8 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey 940b04ab24 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
Andrey e9d16bfa13 MAP phase sensing #3544
new implementation
2021-12-07 20:00:50 -05:00
Matthew Kennedy 2d05d51cf8
consolidate tps accel (#3671) 2021-12-07 18:49:21 -05:00
rusefillc b778aa7173 Pause CAN broadcast on engine stop #3665 2021-12-07 10:35:52 -05:00
rusefillc b4c07798b5 MAP phase sensing #3544 2021-12-07 08:57:23 -05:00
rusefillc 1dd3370b56 https://rusefi.com/forum/viewtopic.php?f=18&t=2236 2021-12-06 21:31:49 -05:00
Matthew Kennedy 3a95e86112
calculate per-cylinder ignition timing (#3652)
* simplify cylinder phasing

* per cylinder timing

* s

* s

* s

* why was there a divide by 2?
2021-12-06 21:19:37 -05:00
rusefillc f826fe13aa MAP phase sensing #3544
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
rusefillc dbb3de3618 tune via CAN #3361
pauseCANdueToSerial
2021-12-05 21:21:36 -05:00
Matthew Kennedy 7dc20b368a
Alternator controller is engine module (#3663)
* alternator is engine module

* user can't set pid period
2021-12-05 18:33:50 -05:00
Matthew Kennedy 555a8d5f43
simplify cylinder phasing (#3650) 2021-12-05 10:46:35 -05:00
Andrei 99daecb7c7 better ignition_voltage_detected message 2021-12-04 01:41:25 -05:00
rusefillc 168a899ba9 how many more spelling mistakes?! 2021-12-02 01:06:40 -05:00
rusefillc f4ab23eb2b Requesting LUA Torque intervention #3638 2021-12-02 01:02:56 -05:00
GitHub build-firmware Action 4392161ac9 Auto-generated configs and docs 2021-12-02 05:04:17 +00:00
rusefillc 0ce025b1f5 fix vBatt false-detection 2021-12-01 11:22:13 -05:00
Matthew Kennedy a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
rusefillc e75590fd45 why so many channels are hidden in debug ? #3614 2021-11-29 14:11:19 -05:00
rusefillc 89f92e1694 why so many channels are hidden in debug ? #3614 2021-11-29 11:54:55 -05:00
rusefillc 11e81cfb57 why so many channels are hidden in debug ? #3614 2021-11-29 10:44:41 -05:00
rusefillc 818d12f68e why so many channels are hidden in debug ? #3614 2021-11-29 10:16:45 -05:00
rusefillc 26997ab9e3 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
Matthew Kennedy d5363b814a
better VSS configuration (#3542)
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
rusefillc bdde177e04 skipspark script kills ECU fix #3611 2021-11-25 22:40:19 -05:00
GitHub build-firmware Action c0d3de4128 Auto-generated configs and docs 2021-11-26 02:06:11 +00:00
Andrey 0ec8b8d46c reliable 32/2 trigger shape 2021-11-25 20:45:58 -05:00
Matthew Kennedy f8403543d6
wall fuel tweaks (#3617) 2021-11-25 18:45:44 -05:00
Matthew Kennedy 0badb6b2ff
AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
Andrey 12d5106614 isCylinderCleanupEnabled would be nice by default 2021-11-24 23:32:55 -05:00
Andrey e2fa1af527 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey f1b8acb1fd MAP phase sensing #3544 2021-11-24 22:35:56 -05:00
Matthew Kennedy 992689ced5
bye (#3609) 2021-11-24 22:03:17 -05:00
rusefillc 3077f795c4 live data for wastegate #3588 2021-11-24 12:59:57 -05:00
Matthew Kennedy 81fffe87b7
main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
rusefillc 794ec5e2b8 well Lua wants to be BIG 2021-11-23 16:40:04 -05:00
GitHub build-firmware Action 174b03e8be Auto-generated configs and docs 2021-11-22 23:12:52 +00:00
Matthew Kennedy 3334a6963c
oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc a369e7e3d3 unusedLogFormat 2021-11-22 13:37:06 -05:00
Matthew Kennedy a342bee57e
rpm calculator refactoring, gm 24x test (#3585)
* data

* stub test

* use getTimeSinceSyncPoint

* s

* s

* no

* test

* stray ;

* those were 1/10 what they were supposed to be

* actually check something

* dead log line?
2021-11-20 14:59:02 +03:00
Scott Smith cbc7c61b3e
Fix potential buffer overrun in cyclic_buffer. (#3583)
This exposed a buffer overrun, so double the size of the buffer (to account for 720 degree engine
cycle vs 360 degree crank events).

Also use proper numeric limits when computing min/max.
Finally, add a lock around the call to cyclic_buffer that actually caused the contention.
2021-11-20 03:01:11 -05:00
Matthew Kennedy bb57a4b084
detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
Scott Smith 5bc1949aef
Basic framework for high pressure fuel pump control (#3476)
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00
Matthew Kennedy d40ca0f581
fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
rusefillc 684622e476 debug mode for skipped count for 4 cylinders #3570 2021-11-19 07:02:21 -05:00
Matthew Kennedy caee2a5439
delimeter is not comma (#3533)
* delimeter is not comma

* do it in config txt

* use txt

* s

* string

* compat

* also, spelling is hard

* use new name

* use new name

* generate enough for happy console

* use an even less common character

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-19 12:01:45 +03:00
Scott Smith 18c27a6e9c
Separate out scheduleOrQueue into it's own standalone scheduler. (#3573)
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
rusefillc 877535b8ff proportional spark cut #3427 2021-11-17 23:35:26 -05:00
Scott Smith 98040ad9af
Make the module API more concise. (#3571)
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 70ad9724c0
Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc 17d4646dce spelling 2021-11-16 16:46:54 -05:00
rusefillc dad00adc28 helping launch enter simulator 2021-11-16 16:45:14 -05:00
rusefillc 678a756275 helping launch enter simulator 2021-11-16 16:31:35 -05:00
Andrey a61043e570 proportional spark cut #3427 2021-11-16 13:23:08 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith 344c9073e2
Start the process of using a global engine ptr for unit tests. (#3551)
* Start the process of using a global engine ptr for unit tests.

Passing around the engine, config, and persistent state wasn't buying anything.  Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables.  Add a dummy check in
case some test tries to set them manually.

* Fix OSX build

* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Andrey 0cc88ec6e2 Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 3b0825181c technical debt: enableOverdwellProtection #3553
only documentation
2021-11-15 20:32:25 -05:00
Andrey 655b77dc3f random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Andrey 928c673695 refactoring launch 2021-11-15 20:09:03 -05:00
Andrey 05fa6071dd refactoring launch 2021-11-15 19:55:04 -05:00
Andrey 0d5df34f36 refactoring launch 2021-11-15 19:55:04 -05:00
Andrey c18204325c refactoring launch 2021-11-15 19:34:42 -05:00
Andrey f510cb8b29 refactoring launch 2021-11-15 19:24:00 -05:00
Andrey 4002c92dcc refactoring launch 2021-11-15 18:57:12 -05:00
Andrey 34015eceee refactoring launch 2021-11-15 14:40:35 -05:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
GitHub build-firmware Action adbb32e9b6 Auto-generated configs and docs 2021-11-15 03:03:29 +00:00
rusefillc 6f3eea31c6 MAP phase sensing #3544 2021-11-14 21:58:01 -05:00
rusefi e8aebc313a Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
rusefi 89ab20c35c Epic: Remove FSIO #2928 2021-11-14 14:14:43 -05:00
rusefillc 68ebb8045d Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 22c872d8d8 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
rusefillc c22215cea7 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
rusefillc 991d0c5001 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
rusefillc 0a9682c553 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc a9bcce88d0 script settings need names! 2021-11-13 22:47:46 -05:00
GitHub build-firmware Action b295511600 Auto-generated configs and docs 2021-11-14 03:02:10 +00:00
Matthew Kennedy d591a5ad26
mercedes two lobe trigger testing (#3543)
* mercedes

* config

* break;

* I did the gap ratio math wrong

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
rusefillc 8333234737 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
GitHub build-firmware Action dffab7abff Auto-generated configs and docs 2021-11-13 03:01:55 +00:00
rusefillc 6d58518fb2 Proteus Harley 2021-11-12 21:56:07 -05:00
GitHub build-firmware Action 2765d386b9 Auto-generated configs and docs 2021-11-12 01:54:56 +00:00
Andrey 562ab174d7 Bench Test IAC Valve fails #3534
that's not even funny
2021-11-11 20:39:01 -05:00
Andrey 8d154b94df Bench Test IAC Valve fails #3534 2021-11-11 20:31:46 -05:00
Andrey df98eb69d4 Bench Test IAC Valve fails #3534 2021-11-11 20:28:01 -05:00
Andrey cd57e1fdb6 Something something Automatic Compression Release #3442 2021-11-11 20:16:46 -05:00
Andrey aff7664c21 refactoring: less hacky implementation 2021-11-11 20:16:46 -05:00
rusefillc 2794a85ff8 Idle valve outputs not available in TS #3523 2021-11-10 20:40:42 -05:00
rusefi 8aaecb568e pid demo progress 2021-11-08 17:31:33 -05:00
Andrey 9d2f9f0d35 docs 2021-11-08 12:23:00 -05:00
rusefillc 656b8c3429 refactoring - magic constant bad 2021-11-07 00:03:16 -04:00
GitHub build-firmware Action ed44ee9b11 Auto-generated configs and docs 2021-11-07 03:59:47 +00:00
rusefillc ce45a907a7 a bit of dead code 2021-11-06 23:39:56 -04:00
rusefillc b244c59cd8 a bit of dead code 2021-11-06 21:19:56 -04:00
GitHub build-firmware Action e065a6ca4c Auto-generated configs and docs 2021-11-07 01:05:29 +00:00
rusefillc 4f738b366e a bit of dead code 2021-11-06 21:01:01 -04:00
Andrey 6111355e6c Remove Miata MX5 NB1 trigger #3488 2021-11-06 20:24:41 -04:00
GitHub build-firmware Action 05b494a726 Auto-generated configs and docs 2021-11-06 23:15:42 +00:00
rusefillc 7b8821955b a bit of dead code 2021-11-06 18:43:19 -04:00
GitHub build-firmware Action b1c27c95d5 Auto-generated configs and docs 2021-11-06 22:37:34 +00:00
rusefillc 1cbe2f7bef PROTEUS_LUA_DEMO 2021-11-06 18:24:59 -04:00
GitHub build-firmware Action ab668c5bed Auto-generated configs and docs 2021-11-06 03:28:22 +00:00
Scott Smith f9e36f5ea4
Configuration for HPFP control algorithm. (#3475) 2021-11-05 23:15:35 -04:00
Scott Smith 675460fafb
Move fuel density to a header file so it can be accessed by other components. (#3474) 2021-11-05 22:29:56 -04:00
Scott Smith 16378dcf59
Convert existing tables to use the simpler 3d table definition style in rusefi_config.txt (#3473)
This fixes #3465.
2021-11-05 21:55:33 -04:00
Scott Smith 6d38fe1eb3
Allow scaled_channel to have both multiplier and divisor (#3468)
Disallow scaled_channel for float.  I can't think of a reason to allow it, and it gets in the way
of rounding.

Add separate template param to setTable; let the compiler sort out whether assignment can happen
between TElement and VElement without forcing them to be the same at function call time.
2021-11-05 17:34:22 -04:00
GitHub build-firmware Action 9e8d55177a Auto-generated configs and docs 2021-11-05 19:42:05 +00:00
Matthew Kennedy 2b9696442e
nissan MR18DE VVT cam pattern (#3466)
* refactoring nissan trigger

* comments

* plumbing

* b

* enums

* image

* image

* implement decoder

* reshuffle

* don't case unused

* dead trigger enums
2021-11-05 15:33:22 -04:00
rusefillc b7feea1aa5 minor todo 2021-11-05 10:01:58 -04:00
GitHub build-firmware Action 618e7edc2c Auto-generated configs and docs 2021-11-05 11:19:56 +00:00
Matthew Kennedy 365691cb37
nissan 4yl crank pattern (#3462)
* refactoring nissan trigger

* comments

* plumbing

* b
2021-11-05 07:15:03 -04:00
rusefillc 1ead914f93 more curves! also names for curves 2021-11-04 23:59:04 -04:00
rusefillc 85984928ca more curves! also names for curves 2021-11-04 23:19:44 -04:00
rusefi 1d9aa8bd12 turboSpeedSensorMultiplier 2021-11-04 19:35:58 -04:00
racer-coder 2612db570f
Fix the types in various fuel functions that actually refer to grams, not ms. (#3458) 2021-11-04 11:50:19 -04:00
rusefillc db310a4bd0 most dead miata config 2021-11-04 09:56:05 -04:00
Matthew Kennedy 59e9d05fc7
extract engine phase function (#3456)
* extract getCurrentEnginePhase

* inject engine ref

* never invalid RPM, use 0 instead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
Matthew Kennedy 24224729a3
support autoscale on table axes (#3452)
* scale map Y axis

* allow different row/col types

* scaled channel detector

* interpolation

* looks like this actually works

* tests, no manual scaling

* comment
2021-11-03 19:53:26 -04:00
Matthew Kennedy 980a7cc833
autoscale fields in generated structs (#3444)
* add to grammar

* parser

* parser

* example consumer

* build config tool

* commit the right jar
2021-11-02 18:59:19 -04:00
rusefi e1a78cce41 docs 2021-11-02 17:11:44 -04:00
Matthew Kennedy 75a2b5ef02
Knock retard (#3396)
* output gauge

* knock controller

* don't need that

* inject engine ref

* test knock

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
rusefillc 7e4ade6b0f better VVT default? 2021-10-31 15:25:43 -04:00
rusefillc ada747baef Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
fail faster!
2021-10-31 12:09:11 -04:00
rusefillc e1402818bc live data stuff goes up 2021-10-31 12:07:44 -04:00
GitHub build-firmware Action 4d62ed9a09 Auto-generated configs and docs 2021-10-31 02:31:01 +00:00
Andrey 2de0409061 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:24:43 -04:00
Andrey d0b2ce5654 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:21:36 -04:00
GitHub build-firmware Action 38c67baed7 Auto-generated configs and docs 2021-10-31 02:08:31 +00:00
Andrey 97e34ad0d1 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:03:19 -04:00
Andrey 432bad64ed Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:52 -04:00
Andrey b6fad6ec81 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:37 -04:00
rusefillc c62fedbe34 Override trigger gaps feature #2734 2021-10-30 10:45:32 -04:00
Andrey 747bbd9c6a warning(CUSTOM_PID_DTERM, "PID: unexpected dTime") 2021-10-29 18:31:43 -04:00
rusefillc 4c164aaf5c Honda K & default VVT pid 2021-10-29 12:16:19 -04:00
rusefi 5ca1db80bc Honda K cam wheels #3405 2021-10-28 15:57:23 -04:00
Andrey c57f9c325f https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 13:49:44 -04:00
GitHub build-firmware Action 83aa4c625a Auto-generated configs and docs 2021-10-28 16:45:50 +00:00
Andrey 30c91040a2 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:29:56 -04:00
GitHub build-firmware Action b0bcdaefd6 Auto-generated configs and docs 2021-10-28 16:17:08 +00:00
Andrey aae1e5d5c5 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:12:45 -04:00
Andrey c96e52d6f3 Honda K cam wheels #3405 2021-10-28 10:36:41 -04:00
rusefi 75d8d334b7 secondary MRE 2021-10-27 19:54:45 -04:00
Andrey e6faf2fa15 UNUSED 2021-10-26 21:24:16 -04:00
GitHub build-firmware Action 49575edb9a Auto-generated configs and docs 2021-10-27 01:17:33 +00:00
Andrey 45280d7435 MRE_SECONDARY_CAN 2021-10-26 21:05:38 -04:00
rusefillc 4ef959a60e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 11:05:45 -04:00
rusefillc 8c95c5adf2 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:59:24 -04:00
rusefillc 76726aad7e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:57:02 -04:00
rusefi bedfc8517f generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 20:06:57 -04:00
Andrey b9dfc32722 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 19:19:16 -04:00
Andrey 229419d04b Honda K cam wheels #3405 2021-10-24 17:12:19 -04:00
Andrey d683a06e20 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 17:06:59 -04:00
Andrey 785c4db197 docs 2021-10-24 17:05:37 -04:00
GitHub build-firmware Action 9d5db767d2 Auto-generated configs and docs 2021-10-24 19:28:08 +00:00
rusefillc 08bda5e1e4 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:18:23 -04:00
rusefillc 87b3df1cf5 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:17:37 -04:00
rusefillc 5f0a9b5363 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:08:21 -04:00
rusefillc c255e630ca generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:58:04 -04:00
GitHub build-firmware Action a10ea5f4c2 Auto-generated configs and docs 2021-10-24 17:18:25 +00:00
rusefillc bf7ae2c76e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:10:38 -04:00
rusefillc 8f8bb444c1 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:01:40 -04:00
rusefillc 4192aee6de generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 12:49:51 -04:00
Andrey 4b4314e86d generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 12:15:53 -04:00
rusefillc eead8fa1f6 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:31:32 -04:00
rusefillc c6d47c1a8a generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:16:11 -04:00
rusefillc add98ca5ed generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 00:00:31 -04:00
rusefillc 4132fe9591 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:46:08 -04:00
rusefillc 923f5d1a6c generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:42:22 -04:00
rusefillc 29faddf338 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:40:14 -04:00
GitHub build-firmware Action 2b1ad1cfe0 Auto-generated configs and docs 2021-10-24 03:19:18 +00:00
rusefillc 0749d0d180 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:14:46 -04:00
rusefillc c45003060c generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:00:04 -04:00
rusefillc 5fdc884e71 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 22:07:44 -04:00
GitHub build-firmware Action 5329c73206 Auto-generated configs and docs 2021-10-24 02:01:12 +00:00
rusefillc 3f3a17e366 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 21:47:03 -04:00
rusefillc cd86102042 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 20:24:21 -04:00