da1f4f25c3
todo?
2023-05-13 13:51:22 -04:00
a0408549f5
todo?
2023-05-13 13:40:47 -04:00
fd736254ae
Ford Coyote VVT Decoder #5275
...
enum/header
2023-05-13 11:39:54 -04:00
51d0f6e347
it's going to be painful
2023-04-29 00:44:00 -04:00
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
f7ec60d32d
Clean-up all the 4g drama #5213
2023-04-01 16:52:48 -04:00
9f7199950e
Clean-up all the 4g drama #5213
2023-04-01 15:19:59 -04:00
6c1a8d501e
4g is symmetrical crank not just four stroke crank #5211
...
only:alphax-4chan
2023-03-30 23:31:47 -04:00
080dfb034a
4g is symmetrical crank not just four stroke crank #5211
...
only:alphax-4chan
2023-03-30 23:11:15 -04:00
3d31058cc5
4g is symmetrical crank not just four stroke crank #5211
2023-03-30 22:52:36 -04:00
033c2e2bb9
https://rusefi.com/forum/viewtopic.php?p=47378#p47378
...
Subaru EZ30 tdcPosition is now 240
2023-03-11 10:15:59 -05:00
e08cdf0fb6
trigger refactoring
...
only:mre_f4
2023-03-03 00:21:40 -05:00
057b067db0
trigger refactoring
...
only:mre_f4
2023-03-03 00:02:26 -05:00
9a5b2b1fd3
test
...
only:alphax-4chan
2023-02-21 18:48:24 -05:00
247108def3
Feb20: 3rd ticket for 4g9x mess #5111
...
random shit at this point
only: alphax-4chan
2023-02-21 17:30:05 -05:00
d8a8f78010
Revert "Feb20: 3rd ticket for 4g9x mess #5111"
...
This reverts commit a8141a5f68
2023-02-21 16:49:53 -05:00
a8141a5f68
Feb20: 3rd ticket for 4g9x mess #5111
...
random shit at this point
only: alphax-4chan
2023-02-21 16:30:36 -05:00
8e268a3542
Feb20: 3rd ticket for 4g9x mess #5111
...
something is really weird
only: alphax-4chan
2023-02-21 15:04:29 -05:00
3c3a584607
Feb20: 3rd ticket for 4g9x mess #5111
...
minor mess reduction: only changing internal naming
2023-02-20 16:51:56 -05:00
aa30546479
Feb20: 3rd ticket for 4g9x mess #5111
2023-02-20 15:22:12 -05:00
0e52c3c9d4
NB1 welcomes 2023
2023-02-20 15:13:29 -05:00
325417caa7
fix 4g63 vs 9x naming, add cam-only test ( #5093 )
2023-02-16 23:22:34 -05:00
d044ee6607
k sync again ( #5090 )
...
* k sync again
* oops
2023-02-16 21:13:00 -05:00
c4d7192f84
Revert "making enum less public API"
...
This reverts commit d4f02bbece
2023-02-15 09:08:52 -05:00
d4f02bbece
making enum less public API
2023-02-15 08:43:15 -05:00
8621f96d25
improved K sync params from real engine ( #5055 )
2023-02-11 19:34:39 -05:00
827dc22757
rewrite neon trigger ( #5003 )
...
* rewrite neon trigger
* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
9630edfbf8
mitsu 4g63 ( #5001 )
...
* mitsu 4g63
* file header
2023-01-24 06:53:40 +05:30
d98e197f49
toyota 4-1 noise rejection ( #4980 )
2023-01-20 15:47:44 +05:30
00aef081ac
12 tooth crank issues fix #4943
2023-01-09 21:10:55 -05:00
1b080bcd09
12 tooth crank issues fix #4943
2023-01-09 15:48:49 -05:00
c72528e5c2
12 tooth crank issues #4943
...
refactoring
2023-01-08 22:30:57 -05:00
0f1d46238f
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
cb97c89588
Toyota cam 4-1 can be a plain skipped tooth decoder ( #4863 )
...
* this should be RiseOnly
* use 4-1 skipped tooth for toyota
2022-12-02 07:37:18 -05:00
ce550aaa3d
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 15:45:32 -05:00
99edf9484a
docs
2022-11-16 15:23:42 -05:00
6ca9b6eda7
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
2fb23cf58b
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 12:18:46 -05:00
f7d97e202e
docs
2022-11-16 12:18:34 -05:00
32d3669a35
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 11:35:00 -05:00
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
ec77afeaa0
reducing ugly
2022-11-06 20:47:57 -05:00
87d6aa2ed9
minor trigger refactoring
2022-11-06 01:11:33 -04:00
43e3fce9b1
minor trigger refactoring
2022-11-05 22:42:33 -04:00
fd86dc2b0f
minor trigger refactoring
2022-11-05 22:30:08 -04:00
c6e34be447
A gem of dead code
2022-11-05 21:53:38 -04:00
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
19b0f7e66e
triggerImage: todo: support symmetrical crank
2022-10-16 12:10:58 -04:00
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
a773b3249a
remove 2jz trigger that's really 12 tooth crank ( #4637 )
...
* remove 2jz trigger that's really 12 tooth crank
* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
6e021fb880
change triggers that need RiseOnly ( #4636 )
...
* triggers that need RiseOnly
* skipped tooth
* s
2022-10-05 20:10:27 -04:00
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
36113d6f66
nicer fatal message if that ever happens
2022-09-28 19:47:14 -04:00
1b56415c56
Auto-generated configs and docs
2022-09-25 22:54:41 +00:00
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
9e7f36a5ca
tear down Engine god object #4511
2022-09-15 21:28:27 -04:00
7cc41dfa75
human brain does need sleep
2022-09-11 12:40:24 -04:00
07727f5d0a
Revert "refactoring: type safety"
...
This reverts commit ed7908a69d
2022-09-11 11:14:20 -04:00
ed7908a69d
refactoring: type safety
2022-09-11 11:00:12 -04:00
2eca6ec3c7
refactoring: type safety
2022-09-11 05:41:01 -04:00
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
6e71b72acc
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
94762094a7
refactoring - reducing API between FW and Java
2022-09-11 01:59:44 -04:00
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
ca4936d3fe
rename and fix skyactiv cam mode ( #4505 )
2022-08-31 22:12:45 -04:00
b444e400eb
docs
2022-08-29 10:51:32 -04:00
219a190fbc
TT_VVT_MAZDA_MYSTERY
2022-08-28 22:43:03 -04:00
4b0c8c9ff2
TT_VVT_MAZDA_MYSTERY
2022-08-28 21:54:24 -04:00
b662e59707
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
aeb7c2e464
hard code vq cam gaps ( #4471 )
2022-08-22 19:40:24 -04:00
b0edd12752
docs
2022-08-22 18:44:44 -04:00
122db2de95
fix Subaru EZ30 trigger gaps fix #4344
2022-07-31 10:15:16 -04:00
0424dd6f0e
Extra gap ratios for custom trigger wheels fix #4375
...
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
20a16bd53b
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
d92fa798ba
RoverK - wow that's odd, but whatever
2022-07-12 02:42:41 -04:00
5fe87f091b
looks dead
2022-07-12 01:38:25 -04:00
a4347668c5
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 11:41:33 -04:00
d639a42621
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 07:43:23 -04:00
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09d5e131b1d0
2022-06-09 17:21:22 -04:00
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
90cc62a667
honda trigger sync ratio ( #4194 )
2022-05-24 17:12:36 -04:00
e8ceaeabaf
Pavel says 120
2022-05-24 14:40:54 -04:00
fe77f5127e
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
907adc6583
remove 360 trigger ( #4165 )
...
* remove 360
* s
* simplify that mess
2022-05-11 06:15:06 -04:00
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
b650bbe46c
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
045cbcbff1
fix 36-2 trigger params ( #4138 )
...
* fix gap params
* changelog was wrong too
* typo
* binary log knock count and retard
* Revert "binary log knock count and retard"
This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
efccb2106d
Corolla 1ZZ 2003 trigger improvements fix #4132
2022-05-04 02:45:44 -04:00
bc6a87cadc
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
4b8b7b1d70
docs
2022-04-24 16:17:42 -04:00
e631988b22
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
9d335c1261
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:38:52 -04:00
c2a97343f2
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
96cc09d166
huh?
2022-04-02 21:01:29 -04:00
086739d20a
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
59f23e294b
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 18:32:40 -04:00
ea94fc05ae
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 21:11:32 -04:00
89054c3a31
new VVT trigger shape? 4-1 Toyota #1847
2022-03-23 19:25:13 -04:00
7d657106d7
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
b3fdd790b5
new VVT trigger shape? #1847
2022-03-22 06:34:22 -04:00
c7590305c4
tweak sync parameters for mitsubishi ( #4017 )
2022-03-21 19:23:48 -04:00
f16088f20d
Mitsubishi 4B11 support #4013
2022-03-20 11:24:08 -04:00
402f36aad6
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:06:19 -04:00
921aed3afe
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 21:34:25 -04:00
21ab6a1a7b
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 20:34:51 -04:00
d72c60452a
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 17:57:35 -04:00
6fa0ce2a3a
Mitsubishi 6G75 Support #4014
2022-03-19 16:34:40 -04:00
9bc4094e48
Mitsubishi 6G75 Support #4014
2022-03-19 16:28:06 -04:00
b0772612cd
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 15:54:43 -04:00
9571f1fe67
Mitsubishi 4B11 support #4013
2022-03-19 15:52:42 -04:00
aa7624950a
Mitsubishi 3A92 Support (Issue #4011 )
2022-03-19 12:01:57 -04:00
1d64929f33
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
e464dd4a52
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 20:55:50 -05:00
3898f0ce7d
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
890d7769a0
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
0932fcf94c
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
95ad75318d
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
4292c2fb1d
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
256df56fa7
Honda K 12+1 decoder adjustment ( #3694 )
...
* adjust trigger
* real cranking
* mk
2021-12-14 21:10:01 -05:00
7e3765650f
adjust mr18 vvt trigger ( #3691 )
...
* adjust mr18 trigger
* second gap, why not
2021-12-13 16:33:34 -04:00
fda7a3a775
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
0ec8b8d46c
reliable 32/2 trigger shape
2021-11-25 20:45:58 -05:00
48ed80ffb9
MAP phase sensing #3544
2021-11-24 23:06:52 -05:00
228d5ee810
MAP phase sensing #3544
2021-11-24 22:41:49 -05:00
ba4a00d3bb
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData ( #3519 )
...
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData
Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp. It could be better but this is simple
and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays. Makes the interface simpler
and more rigid. Also saves 4 bytes per Multi*. Downside is access is now via -> and *,
not . and (nothing).
Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA
* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?
* No magical templated StaticAlloc thingy. Just virtual functions.
2021-11-21 04:56:07 -05:00
bb57a4b084
detect more overflows with asan ( #3582 )
...
* overflow detector
* type list dynamic allocate
* fix the buffer length
* comment
* pr fb
* sanitize sim
* fix sim sanitizer bug
* didn't mean to turn off optimization for sim
* asan can do that, if you turn it on!
* cleaning
2021-11-20 01:38:39 -05:00
ecac07f938
brave refactoring
2021-11-19 23:56:52 -05:00
692e3d7e9f
adjust miata sync conditions ( #3577 )
2021-11-19 02:30:05 -05:00
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
0813266ee1
trigger refactoring & docs
2021-11-14 15:35:11 -05:00
a7ba539e70
math is fun ( #3545 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
d591a5ad26
mercedes two lobe trigger testing ( #3543 )
...
* mercedes
* config
* break;
* I did the gap ratio math wrong
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
713083baa5
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
2f4d123052
Change users of MultiChannelStateSequence to use the API ( #3524 )
...
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
d4c4db9a12
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
dac67235c4
Don't keep a separate MultiChannelStateSequence for the trigger emulator, version 2. ( #3517 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-10 07:01:20 -05:00
Andrey
rusefillc
Matthew Kennedy
Andrey G
GitHub gen-configs Action
Scott Smith