Commit Graph

1856 Commits

Author SHA1 Message Date
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy e801ffc979 fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi 4bc9b25214 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 77caa77b4b trigger refactoring: instance RPM fix #4740 2022-11-06 12:03:55 -05:00
Andrey 65f5c00616 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 153a454472 trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
Andrey 9edfda7f72 trigger refactoring: instance RPM #4740 2022-11-06 11:45:51 -05:00
Andrey f7daa5df72 trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey ba17b83bea trigger refactoring: instance RPM #4740 2022-11-06 11:12:20 -05:00
Andrey 25d292c462 trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
Andrey f8cce72779 trigger refactoring: instance RPM #4740 2022-11-06 10:58:04 -05:00
rusefillc d23b0b063f minor trigger refactoring 2022-11-06 01:32:59 -04:00
rusefillc d5c2c0294b minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc 2d96fb3ef6 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc 8bcbb2b9b1 learning C++ 2022-11-06 00:17:24 -04:00
rusefillc 6c8325c0c2 more fancy 2022-11-06 00:10:50 -04:00
rusefillc ce55171d8d minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 45deb75979 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
rusefillc 4c3c34518a minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc 6402e61484 minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey b0acc6d141 A gem of dead code 2022-11-05 21:53:38 -04:00
Andrey 72ed388948 minor trigger refactoring 2022-11-05 21:43:12 -04:00
rusefillc cb9e33d501 dead lines 2022-11-05 17:21:30 -04:00
rusefillc bcafeb471b dead lines 2022-11-05 15:20:02 -04:00
Andrey G cc9b1517ac compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc ec184423f2 send more of Engine Sniffer data #4560 2022-10-29 21:55:35 -04:00
GitHub gen-configs Action 7b978dcf57 Auto-generated configs and docs 2022-10-28 14:09:22 +00:00
rusefillc 14e8a4c2c4 SD card log fields list should be auto-generated #3985 2022-10-28 10:04:33 -04:00
GitHub gen-configs Action 38f0871550 Auto-generated configs and docs 2022-10-28 13:11:34 +00:00
rusefillc 2c392fd77a SD card log fields list should be auto-generated #3985 2022-10-28 09:06:15 -04:00
rusefillc d24e84ebbc Automation coverage for RPM not reading #4709 2022-10-28 02:44:38 -04:00
rusefillc a744023c6e refactoring 2022-10-28 02:41:20 -04:00
rusefillc 07c5c2a91e progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc 8b1a1a984c refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
rusefillc 93892bd4d9 progress: rpm register based on trigger input being none or not 2022-10-21 23:29:39 -04:00
Matthew Kennedy 1cc46a1b83 simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc 7a3cedfa22 triggerImage: todo: support symmetrical crank 2022-10-16 12:10:58 -04:00
Matthew Kennedy 14b92612e2 fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc a9cf096272 // todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
GitHub gen-configs Action aea99ddbe6 Auto-generated configs and docs 2022-10-09 02:22:51 +00:00
rusefillc 978fd853ea hold on, why "float autoscale" at all here? (#4647)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 22:11:34 -04:00
Matthew Kennedy a65190b008 remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy 33c8e937e6 change triggers that need RiseOnly (#4636)
* triggers that need RiseOnly

* skipped tooth

* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 93b5758736 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy f2c8a0192c fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 1c9b07e355 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
GitHub gen-configs Action 915ce72a17 Auto-generated configs and docs 2022-09-25 22:54:41 +00:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 7ba4f8c5fd also invert trigger stim if you have trigger input inverted (#4612) 2022-09-25 10:10:31 -04:00