cfd6828d42
Extra gap ratios for custom trigger wheels fix #4375
...
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
43bc08bc24
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
250d8c4213
RoverK - wow that's odd, but whatever
2022-07-12 02:42:41 -04:00
b2cbd889f9
looks dead
2022-07-12 01:38:25 -04:00
6267b8621a
big delete ICU ( #4270 )
...
* big delete
* icu vestiges
* changelog
2022-07-07 15:27:59 -04:00
88ff234c91
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
d5f1235a43
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
60b8aa71de
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 11:41:33 -04:00
22e3ab8220
https://rusefi.com/forum/viewtopic.php?f=5&t=2353
2022-06-20 07:43:23 -04:00
214d38f286
verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259
2022-06-18 15:18:45 -04:00
dcde5cea9e
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
docs
2022-06-18 14:44:21 -04:00
514531bc5c
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
9d942a1c4a
more info verbose trigger/vvt
2022-06-17 22:11:09 -04:00
f3a5b027d9
more into "triggerinfo"
2022-06-17 22:10:48 -04:00
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb5454b8f509
2022-06-09 17:21:22 -04:00
c2f61dc95f
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
54c339c0a4
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
5f1801f9d6
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
b5d212dcd8
remove dead useOnlyFirstChannel ( #4211 )
...
* This field was ignored.
* move pad out
* gone
2022-05-30 07:03:40 -04:00
cf51533f45
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
6ea78efbe7
bail from trigger_central ( #4210 )
2022-05-29 10:42:08 -04:00
d85ed5f3c0
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
4a0c7cb8d5
honda trigger sync ratio ( #4194 )
2022-05-24 17:12:36 -04:00
7a52251375
Pavel says 120
2022-05-24 14:40:54 -04:00
65db5aacaa
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
eb257b2335
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
76a15dd711
don't rely on triggerStateListener to detect trigger errors ( #4164 )
...
* Write proper TriggerDecoder tests
* Improve logic around sync loss
* these tests I understand
* these I sort of understand....
* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
fa835950a0
remove 360 trigger ( #4165 )
...
* remove 360
* s
* simplify that mess
2022-05-11 06:15:06 -04:00
cf89b42716
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
b243d3fca0
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
05dd33ddb3
switch back to flag ( #4155 )
2022-05-10 07:52:29 +03:00
dede3f8215
phase resolution rpm limit ( #4156 )
2022-05-10 07:22:50 +03:00
55fdd3f3c7
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
e64c8cfccb
synchronized Phase handling improvements fix #4099
2022-05-09 04:36:03 -04:00
5454b8f509
m_hasSynchronizedSymmetrical handling improvements #4099
...
API progress
2022-05-09 04:04:38 -04:00
23c16280f6
helping build
2022-05-08 09:14:50 -04:00
35901087cd
Merge branch 'master' of https://github.com/rusefi/rusefi
2022-05-08 09:11:16 -04:00
5bbb401f85
Auto-generated configs and docs
2022-05-08 13:06:44 +00:00
394d1fe961
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
b2771f9b44
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
a4b7845279
Auto-generated configs and docs
2022-05-08 12:05:34 +00:00
ad4591945e
Remove value copy from controller into outputChannels #4095
2022-05-08 07:58:19 -04:00
997565ac22
Trigger gm 3 vs 5 ( #4140 )
...
* add parameter
* two modes
* add new mode to list
* format
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
72e5604f9b
fix 36-2 trigger params ( #4138 )
...
* fix gap params
* changelog was wrong too
* typo
* binary log knock count and retard
* Revert "binary log knock count and retard"
This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
fdeeaac1c8
Corolla 1ZZ 2003 trigger improvements fix #4132
2022-05-04 02:45:44 -04:00
83caf1ea1b
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
a2e1a079b8
allow enum_class in rusefi_hw_enums.h ( #4104 )
...
* make things c++ friendly
* install various canaries in coal mines
* using is much clearer than typedef
* fixing builds
* lps25
* trigger includes were a mess
* c -> c++ cleanup
* os util
* why did so many include os_util.h?
* fwd declare
* cypress/kinetis
* s
* eg33 happy
* happy sim
* cypress usb
* pch
* cypress
* doesn't need to include all that
* h7
2022-04-25 20:38:16 -04:00
8145bd6bc0
Auto-generated configs and docs
2022-04-25 04:01:07 +00:00
ba35602702
Auto-generated configs and docs
2022-04-25 03:46:16 +00:00
f836dedef7
docs
2022-04-24 16:17:42 -04:00
d1173219b6
Remove value copy from controller into outputChannels #4095
2022-04-23 19:53:05 -04:00
1ce5be5629
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
192ce371ec
Auto-generated configs and docs
2022-04-23 22:02:47 +00:00
c6599a57b2
Remove value copy from controller into outputChannels #4095
2022-04-23 17:50:20 -04:00
6fe855a3bd
Auto-generated configs and docs
2022-04-19 19:11:17 +00:00
6006697351
https://github.com/rusefi/web_backend/issues/166
2022-04-19 14:49:57 -04:00
5f9c9d1732
humans need humane warning messages
2022-04-18 11:35:19 -04:00
783aa1451c
Auto-generated configs and docs
2022-04-17 20:30:07 +00:00
30e619fe95
random progress & method rename
2022-04-16 17:40:05 -04:00
8f1fb5dc0f
i will confess: i need to fit a debug build into discovery
2022-04-16 17:24:31 -04:00
cb4979e068
very random progress
2022-04-16 17:07:57 -04:00
e16117f6ce
very random progress
2022-04-16 17:04:35 -04:00
d9fccb4383
logging of live data structs was: data points #3614
...
unification with outputs
2022-04-14 21:01:26 -04:00
06f2006626
logging of live data structs was: data points #3614
...
unification with outputs
2022-04-14 15:46:01 -04:00
bc08418280
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
20dbc1ff82
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
49fab25b14
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:38:52 -04:00
6c69e55ea0
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
2f66b6fe04
huh?
2022-04-02 21:01:29 -04:00
9ae96ea7e5
refactoring: method rename
2022-04-02 21:01:29 -04:00
3dbee88f53
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
6dd790d7ac
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 18:32:40 -04:00
310a2044bd
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 21:11:32 -04:00
d97b2646ed
new VVT trigger shape? 4-1 Toyota #1847
2022-03-23 19:25:13 -04:00
5cf2b1bba5
warning cleanup ( #4020 )
2022-03-22 16:53:24 -04:00
63adb09089
new VVT trigger shape? #1847
2022-03-22 06:34:22 -04:00
b555d9e82b
toothed previous time #4019
2022-03-21 20:41:09 -04:00
f67f65d31d
tweak sync parameters for mitsubishi ( #4017 )
2022-03-21 19:23:48 -04:00
ce45951f7a
Mitsubishi 4B11 support #4013
2022-03-20 11:24:08 -04:00
fe790bee93
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:24:50 -04:00
8b5fdfa852
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:11:51 -04:00
ef3248c245
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:06:19 -04:00
394deca94a
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 21:34:25 -04:00
65fe21cf84
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 20:34:51 -04:00
d8ac904a28
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 17:57:35 -04:00
416f9a974d
Mitsubishi 6G75 Support #4014
2022-03-19 16:34:40 -04:00
faf84286f5
Mitsubishi 6G75 Support #4014
2022-03-19 16:28:06 -04:00
7548fe13f2
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 15:54:43 -04:00
c7cc88ccd0
Mitsubishi 4B11 support #4013
2022-03-19 15:52:42 -04:00
d6b1c9faf2
Mitsubishi 3A92 Support (Issue #4011 )
2022-03-19 12:01:57 -04:00
9d8c316aff
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
a80b2dabd7
sporadic HighRevTest testV12 #3806
...
let's attempt to guess his intentions
2022-01-25 17:24:38 -05:00
22332a4dad
sporadic HighRevTest testV12 #3806
...
is this bug here?
2022-01-25 10:28:35 -05:00
0dc5ff1941
fix ( #3833 )
2022-01-24 18:15:18 -05:00
e0258c4c8e
migrating to SensorType::Rpm API
2022-01-20 23:36:09 -05:00
5f3324cd6b
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
7b9816d137
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 20:55:50 -05:00
b40c898097
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
accc0542b8
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
22f679870a
Bosch Quick Start on B6 Passat is confused about phase #3812
...
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
2022-01-19 01:30:16 -05:00
a4479259cf
Bosch Quick Start on B6 Passat is confused about phase #3812
...
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
2022-01-19 00:48:39 -05:00
a2c71f07c6
refactoring: reusing existing flag instead of switch which refers to same thing
2022-01-19 00:48:39 -05:00
385f0cc991
Better handling of RPM during stop of cranking #3803
2022-01-17 21:27:10 -05:00
19ff671aaf
Better handling of RPM during stop of cranking #3803
...
reuse existing magic constant
2022-01-17 21:18:43 -05:00
2da6593305
Better handling of RPM during stop of cranking #3803
...
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
ea534a9be1
mk files refactoring
2022-01-06 21:40:48 -05:00
e4f828c0a1
Auto-generated configs and docs
2022-01-05 06:49:51 +00:00
fd23938b2a
Auto-generated configs and docs
2022-01-05 05:09:04 +00:00
4627bace31
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
c058698859
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
d90d6705cf
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00
041a3e12a3
extract isSyncPoint function ( #3726 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* clean up noise from test case
* clarify and comment
2021-12-30 11:39:04 -05:00
107eae67e0
docs
2021-12-29 16:18:21 -05:00
513187decc
remove vvtSyncTimeNt ( #3722 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* check synchronized bit
* now we don't need it at all?!
* and *NOT* synced
* start VVT sync earlier
2021-12-28 00:00:26 -05:00
b392a7120e
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
b0c1a8fb2e
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
02e31e1555
MAP phase sensing #3544
...
removing dead implementation
2021-12-16 21:13:55 -05:00
8afee6c233
Honda K 12+1 decoder adjustment ( #3694 )
...
* adjust trigger
* real cranking
* mk
2021-12-14 21:10:01 -05:00
71514cb633
adjust mr18 vvt trigger ( #3691 )
...
* adjust mr18 trigger
* second gap, why not
2021-12-13 16:33:34 -04:00
f5ead049c3
MAP phase sensing #3544
...
limiting to below cranking RPM limit
2021-12-11 02:56:19 -05:00
d6a0154f79
maybe more working MAP sampling ( #3689 )
...
* what if we do this
* cleanup
* s
* test
2021-12-11 03:01:28 -04:00
e7dec2a4b9
MAP phase sensing #3544
2021-12-09 22:16:42 -05:00
71542ea6b9
live data this
2021-12-09 22:02:47 -05:00
80c62ce888
MAP phase sensing #3544
...
gauge name fix
2021-12-08 12:44:43 -05:00
b8a197d0f0
MAP phase sensing #3544
...
new implementation seems complete? 360 fix
2021-12-07 21:37:33 -05:00
d3afd617d2
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
d2c46b3310
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
0f6c9e15c3
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
c793b19538
MAP phase sensing #3544
...
look new unit test!
2021-12-07 16:58:10 -05:00
ddbe875d98
MAP phase sensing #3544
...
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
e0d5a5afac
trigger sync better gauges/logging
2021-12-06 13:08:41 -05:00
2b465be253
MAP phase sensing #3544
...
option to look for high and low peaks
2021-12-05 14:25:26 -05:00
52d770c2bf
MAP phase sensing #3544
2021-12-04 18:47:14 -05:00
e0559a8548
MAP phase sensing #3544
...
taking a step back to happy place
2021-12-04 18:21:10 -05:00
f3a3d96fa9
MAP phase sensing #3544
...
trying longer average
2021-12-04 17:06:59 -05:00
99367c8348
log actual tooth angle ( #3646 )
2021-12-02 19:22:33 -05:00
9ce37314c0
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
2476fae92a
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
37ed110750
how many more spelling mistakes?!
2021-12-02 01:06:40 -05:00
f6d6fab004
Auto-generated configs and docs
2021-12-01 00:36:32 +00:00
faf4801175
remove define_constructor ( #3640 )
...
* no define_constructor
* jar
* sim needs live doc
2021-11-30 19:31:54 -05:00
631d71cea7
random note
2021-11-26 15:48:42 -05:00
e3920a3159
reliable 32/2 trigger shape
2021-11-25 20:45:58 -05:00
7fa2fa5707
MAP phase sensing #3544
2021-11-24 23:06:52 -05:00
670bd74376
MAP phase sensing #3544
2021-11-24 22:41:49 -05:00
695557f709
MAP phase sensing #3544
2021-11-24 22:36:36 -05:00
4e45297145
minor progress
2021-11-24 22:35:56 -05:00
9bd8a19564
oh my god we've had no asserts ( #3595 )
2021-11-22 17:52:03 -05:00
9d61fb4cfd
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData ( #3519 )
...
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData
Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp. It could be better but this is simple
and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays. Makes the interface simpler
and more rigid. Also saves 4 bytes per Multi*. Downside is access is now via -> and *,
not . and (nothing).
Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA
* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?
* No magical templated StaticAlloc thingy. Just virtual functions.
2021-11-21 04:56:07 -05:00
b9f8409f59
correctly compute engine revolution number ( #3586 )
...
* add param
* first revolution is revolution 0, not revolution 1
* would you look at that, we sync one rev quicker!
* changelog
* rpm value
2021-11-21 09:01:27 +03:00
569415930c
detect more overflows with asan ( #3582 )
...
* overflow detector
* type list dynamic allocate
* fix the buffer length
* comment
* pr fb
* sanitize sim
* fix sim sanitizer bug
* didn't mean to turn off optimization for sim
* asan can do that, if you turn it on!
* cleaning
2021-11-20 01:38:39 -05:00
a3fc6d3e80
brave refactoring
2021-11-19 23:56:52 -05:00
7dee1e42eb
adjust miata sync conditions ( #3577 )
2021-11-19 02:30:05 -05:00
659cc68be1
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
7b790d36f6
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
c1941f3a49
(void) -> () ( #3550 )
...
* static functions with (void)
* more
* Revert "more"
This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
bd04dc8352
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
8cb1f2545c
trigger refactoring & docs
2021-11-14 15:35:11 -05:00
af78ab76cb
math is fun ( #3545 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
291f815b2d
Something something Automatic Compression Release #3442
2021-11-14 15:04:10 -05:00
29670184e2
script settings need names!
2021-11-13 22:47:46 -05:00
8edc91f657
mercedes two lobe trigger testing ( #3543 )
...
* mercedes
* config
* break;
* I did the gap ratio math wrong
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
93d31c6c9b
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
aec887efc8
Change users of MultiChannelStateSequence to use the API ( #3524 )
...
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
1a299a3221
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
5bd7d8e372
Don't keep a separate MultiChannelStateSequence for the trigger emulator, version 2. ( #3517 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-10 07:01:20 -05:00
38ea0d1835
Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )"
...
This reverts commit 4e220dc163
2021-11-09 20:42:23 -05:00
4e220dc163
Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
9b40e68155
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
94faa375e1
reducing complexity
2021-11-07 01:57:32 -05:00
d0a8bbc974
typo
2021-11-07 01:51:05 -05:00
4f6dc57d31
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
73fe152db2
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
5ddd516860
refactoring - magic constant bad
2021-11-07 00:09:17 -04:00
fd28e82f73
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
f45d365f24
log current engine phase on trigger teeth ( #3471 )
...
* log phase on trigger teeth
* ui
* guard
2021-11-05 20:02:15 -04:00
2c47f603fc
make master happy ( #3467 )
2021-11-05 16:01:13 -04:00
b41dbe2ed1
nissan MR18DE VVT cam pattern ( #3466 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
* enums
* image
* image
* implement decoder
* reshuffle
* don't case unused
* dead trigger enums
2021-11-05 15:33:22 -04:00
6b85313b04
nissan 4yl crank pattern ( #3462 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
2021-11-05 07:15:03 -04:00
cadaf2a801
extract engine phase function ( #3456 )
...
* extract getCurrentEnginePhase
* inject engine ref
* never invalid RPM, use 0 instead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
cc0a93080f
Honda K cam wheels #3405
2021-10-30 21:09:58 -04:00
a2f1cd2467
Override trigger gaps feature #2734
2021-10-30 10:45:32 -04:00
1685ec95cf
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
965333e410
dead magic macro
2021-10-28 19:18:50 -04:00
74d302ad50
VVT to be reported after primary
2021-10-28 16:46:54 -04:00
68c1995044
Honda K cam wheels #3405
2021-10-28 13:49:54 -04:00
94b5b3a089
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
5527f77589
Honda K cam wheels #3405
2021-10-28 10:36:41 -04:00
5fcb2f75a5
refactoring: extracting method to improve readability
2021-10-28 10:30:05 -04:00
df67d76968
Honda K cam wheels #3405
2021-10-26 22:47:19 -04:00
6c554e09f8
Honda K cam wheels #3405
2021-10-26 17:29:26 -04:00
996a39ba6e
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-25 11:05:45 -04:00
98fe894ce1
Honda K cam wheels #3405
2021-10-24 17:12:19 -04:00
61af92bb25
progress
2021-10-24 15:30:17 -04:00
fbcacc4cc9
Auto-generated configs and docs
2021-10-23 23:05:27 +00:00
4dd1ae7035
triggerinfo progress
2021-10-23 19:01:31 -04:00
rusefillc
Andrey
Matthew Kennedy
GitHub build-firmware Action
rusefillc
Scott Smith