Commit Graph

1856 Commits

Author SHA1 Message Date
Matthew Kennedy 6f5bed28d9 better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy dbf8a1ea2a #4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 5935c18beb K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey 4653cde601 K progress 2022-09-24 23:18:57 -04:00
GitHub gen-configs Action 3690b79b18 Auto-generated configs and docs 2022-09-24 04:29:39 +00:00
Matthew Kennedy 2410b11a66 log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc c6a2f2657b honda K enum rename 2022-09-23 20:13:14 -04:00
Matthew Kennedy 556769b181 terrible horrible typo (#4597) 2022-09-20 12:39:16 -04:00
rusefillc d423c077a0 moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 1c9cb5b6ba just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc cf53f8b65c tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc b4bc5551db tear down Engine god object #4511 2022-09-15 22:06:16 -04:00
rusefillc 918112d588 tear down Engine god object #4511 2022-09-15 22:00:07 -04:00
rusefillc 03d176ca61 tear down Engine god object #4511 2022-09-15 21:55:15 -04:00
rusefillc 1c28ca0582 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc e582a83ecb tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
rusefillc 6e3bbd2ca2 dead idea 2022-09-15 14:55:32 -04:00
Andrey dc9504f33c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey d9accf1772 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey aa0cffcfdb deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey G 2b4012b279 dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 5274cffff3

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G bbb71c4e7d Supress tons of warning from triggers (#4565) 2022-09-11 15:25:58 -04:00
Andrey G 1ca5988877 time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc 0780a3f719 human brain does need sleep 2022-09-11 12:40:24 -04:00
rusefillc 787dc0700e Revert "refactoring: type safety"
This reverts commit 0ff7af9db5.
2022-09-11 11:14:20 -04:00
rusefillc 0ff7af9db5 refactoring: type safety 2022-09-11 11:00:12 -04:00
rusefillc 2e85a7a09d refactoring: type safety 2022-09-11 05:41:01 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc f9b849dd8f refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc efcd8ea084 refactoring - reducing API between FW and Java 2022-09-11 01:59:44 -04:00
rusefillc 4836c78644 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc b2ad515b0f vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
rusefillc 3c647c6442 huh? dead code? how can we get NAN from eventAngles table? (#4549) 2022-09-07 23:45:33 -04:00
GitHub gen-configs Action 8849518ff7 Auto-generated configs and docs 2022-09-08 02:41:09 +00:00
Andrey 3c1cc0b857 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 8253156233 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 21:45:59 -04:00
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
Matthew Kennedy 670c2e4afe reset instant RPM in case of cam resync (#4544) 2022-09-06 21:38:35 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Matthew Kennedy fba0906942 more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey fdee7db991 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
GitHub gen-configs Action 8abba1b2fd Auto-generated configs and docs 2022-09-01 14:11:17 +00:00
Andrey 5cb41535d5 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 89b32418a1 Revert "smaller step forward"
This reverts commit 3e105b1599.
2022-09-01 09:10:11 -04:00
Andrey 22f31397b0 Revert "smaller step forward"
This reverts commit deff630653.
2022-09-01 09:10:07 -04:00
Andrey deff630653 smaller step forward 2022-09-01 08:51:13 -04:00
Andrey 3e105b1599 smaller step forward 2022-09-01 08:44:46 -04:00
GitHub gen-configs Action 6c670332db Auto-generated configs and docs 2022-09-01 05:33:56 +00:00
Andrey 453d2a0942 smaller step forward 2022-09-01 01:11:03 -04:00
Andrey 7b50f32b3d smaller step forward 2022-09-01 01:08:51 -04:00
GitHub gen-configs Action 9744fa0920 Auto-generated configs and docs 2022-09-01 04:53:05 +00:00
Andrey bc407d7749 54ac7279b1 partial rollback 2022-09-01 00:46:54 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
GitHub gen-configs Action 9c2bb7e7e6 Auto-generated configs and docs 2022-09-01 04:18:59 +00:00
Andrey 54ac7279b1 refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 9d497846d3 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
GitHub gen-configs Action a20d19856b Auto-generated configs and docs 2022-09-01 03:56:47 +00:00
Andrey 6a5e3bc078 currentEngineDecodedPhase as trigger central field 2022-08-31 23:31:35 -04:00
Andrey 0a9c1d7581 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
rusefillc 4c8e28dfab docs 2022-08-29 10:51:32 -04:00
Andrey 9042cd80db TT_VVT_MAZDA_MYSTERY 2022-08-28 23:01:38 -04:00
Andrey 691306f12a TT_VVT_MAZDA_MYSTERY 2022-08-28 22:43:03 -04:00
rusefillc 35f17f38b3 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
Matthew Kennedy 234909a91f remove some uses of EFI_ERROR_CODE (#4496)
* lua hooks

* findAngleMatch

* s

* s
2022-08-28 09:43:21 -04:00
rusefillc 715b799b6c separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 (#4495)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
GitHub gen-configs Action 2629924a06 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy dfd340e8c3 log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
rusefillc f5576b05d9 VQ trigger gaps improvement fix #4469
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
rusefillc 4e6d129f27 poke 3 2022-08-23 09:02:38 -04:00
rusefillc 016cd3bc7c poke 2 2022-08-22 23:43:06 -04:00
rusefillc 341b43e7e3 poke 1 2022-08-22 23:42:48 -04:00
rusefillc 637dc37e95 RE: reasons for verbose messages 2022-08-22 22:52:48 -04:00
Matthew Kennedy e959f7e71e hard code vq cam gaps (#4471) 2022-08-22 19:40:24 -04:00
rusefillc db0ff659c7 docs 2022-08-22 18:44:44 -04:00
Andrey 90130b3311 Revert "Revert "Revert "small step forward? (#4450)"""
This reverts commit 30297da80c.
2022-08-21 15:23:20 -04:00
Andrey 30297da80c Revert "Revert "small step forward? (#4450)""
This reverts commit d2365c5c7f.
2022-08-21 14:43:50 -04:00
GitHub gen-configs Action 1c01d5608f Auto-generated configs and docs 2022-08-21 16:43:08 +00:00
rusefi ea7597e0d6 trigger gap logging: it's a mess :( 2022-08-21 12:38:29 -04:00
GitHub build-firmware Action 11e754ed21 Auto-generated configs and docs 2022-08-16 23:48:31 +00:00
Andrey d2365c5c7f Revert "small step forward? (#4450)"
This reverts commit badbc1a46e.
2022-08-16 19:43:46 -04:00
GitHub build-firmware Action 1b7171db0f Auto-generated configs and docs 2022-08-16 23:06:34 +00:00
rusefillc badbc1a46e small step forward? (#4450)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-16 18:57:40 -04:00
GitHub build-firmware Action 72ead5be96 Auto-generated configs and docs 2022-08-15 21:22:59 +00:00
GitHub build-firmware Action 006190aa15 Auto-generated configs and docs 2022-08-15 19:03:46 +00:00
GitHub build-firmware Action 9a5808c53e Auto-generated configs and docs 2022-08-15 18:43:52 +00:00
GitHub build-firmware Action cc76b9ee88 Auto-generated configs and docs 2022-08-14 21:08:27 +00:00
GitHub build-firmware Action ff8ad6ba6e Auto-generated configs and docs 2022-08-14 20:14:30 +00:00
Matthew Kennedy fcb9897443 resolve VVT phase using every tooth, not just sync point (#4434)
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
2022-08-12 08:08:23 -04:00
rusefillc f11480597d todo: huh? dead code? how can we get NAN from eventAngles table? 2022-08-11 20:05:29 -04:00
rusefillc d97bcec161 refactoring: better field name 2022-08-09 20:32:39 -04:00
rusefillc 64c76bf59c fix Subaru EZ30 trigger gaps fix #4344 2022-07-31 10:15:16 -04:00