Commit Graph

1856 Commits

Author SHA1 Message Date
Andrey 5cb41535d5 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 89b32418a1 Revert "smaller step forward"
This reverts commit 3e105b1599.
2022-09-01 09:10:11 -04:00
Andrey 22f31397b0 Revert "smaller step forward"
This reverts commit deff630653.
2022-09-01 09:10:07 -04:00
Andrey deff630653 smaller step forward 2022-09-01 08:51:13 -04:00
Andrey 3e105b1599 smaller step forward 2022-09-01 08:44:46 -04:00
GitHub gen-configs Action 6c670332db Auto-generated configs and docs 2022-09-01 05:33:56 +00:00
Andrey 453d2a0942 smaller step forward 2022-09-01 01:11:03 -04:00
Andrey 7b50f32b3d smaller step forward 2022-09-01 01:08:51 -04:00
GitHub gen-configs Action 9744fa0920 Auto-generated configs and docs 2022-09-01 04:53:05 +00:00
Andrey bc407d7749 54ac7279b1 partial rollback 2022-09-01 00:46:54 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
GitHub gen-configs Action 9c2bb7e7e6 Auto-generated configs and docs 2022-09-01 04:18:59 +00:00
Andrey 54ac7279b1 refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 9d497846d3 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
GitHub gen-configs Action a20d19856b Auto-generated configs and docs 2022-09-01 03:56:47 +00:00
Andrey 6a5e3bc078 currentEngineDecodedPhase as trigger central field 2022-08-31 23:31:35 -04:00
Andrey 0a9c1d7581 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
rusefillc 4c8e28dfab docs 2022-08-29 10:51:32 -04:00
Andrey 9042cd80db TT_VVT_MAZDA_MYSTERY 2022-08-28 23:01:38 -04:00
Andrey 691306f12a TT_VVT_MAZDA_MYSTERY 2022-08-28 22:43:03 -04:00
rusefillc 35f17f38b3 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
Matthew Kennedy 234909a91f remove some uses of EFI_ERROR_CODE (#4496)
* lua hooks

* findAngleMatch

* s

* s
2022-08-28 09:43:21 -04:00
rusefillc 715b799b6c separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 (#4495)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
GitHub gen-configs Action 2629924a06 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy dfd340e8c3 log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
rusefillc f5576b05d9 VQ trigger gaps improvement fix #4469
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
rusefillc 4e6d129f27 poke 3 2022-08-23 09:02:38 -04:00
rusefillc 016cd3bc7c poke 2 2022-08-22 23:43:06 -04:00
rusefillc 341b43e7e3 poke 1 2022-08-22 23:42:48 -04:00
rusefillc 637dc37e95 RE: reasons for verbose messages 2022-08-22 22:52:48 -04:00
Matthew Kennedy e959f7e71e hard code vq cam gaps (#4471) 2022-08-22 19:40:24 -04:00
rusefillc db0ff659c7 docs 2022-08-22 18:44:44 -04:00
Andrey 90130b3311 Revert "Revert "Revert "small step forward? (#4450)"""
This reverts commit 30297da80c.
2022-08-21 15:23:20 -04:00
Andrey 30297da80c Revert "Revert "small step forward? (#4450)""
This reverts commit d2365c5c7f.
2022-08-21 14:43:50 -04:00
GitHub gen-configs Action 1c01d5608f Auto-generated configs and docs 2022-08-21 16:43:08 +00:00
rusefi ea7597e0d6 trigger gap logging: it's a mess :( 2022-08-21 12:38:29 -04:00
GitHub build-firmware Action 11e754ed21 Auto-generated configs and docs 2022-08-16 23:48:31 +00:00
Andrey d2365c5c7f Revert "small step forward? (#4450)"
This reverts commit badbc1a46e.
2022-08-16 19:43:46 -04:00
GitHub build-firmware Action 1b7171db0f Auto-generated configs and docs 2022-08-16 23:06:34 +00:00
rusefillc badbc1a46e small step forward? (#4450)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-16 18:57:40 -04:00
GitHub build-firmware Action 72ead5be96 Auto-generated configs and docs 2022-08-15 21:22:59 +00:00
GitHub build-firmware Action 006190aa15 Auto-generated configs and docs 2022-08-15 19:03:46 +00:00
GitHub build-firmware Action 9a5808c53e Auto-generated configs and docs 2022-08-15 18:43:52 +00:00
GitHub build-firmware Action cc76b9ee88 Auto-generated configs and docs 2022-08-14 21:08:27 +00:00
GitHub build-firmware Action ff8ad6ba6e Auto-generated configs and docs 2022-08-14 20:14:30 +00:00
Matthew Kennedy fcb9897443 resolve VVT phase using every tooth, not just sync point (#4434)
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
2022-08-12 08:08:23 -04:00
rusefillc f11480597d todo: huh? dead code? how can we get NAN from eventAngles table? 2022-08-11 20:05:29 -04:00
rusefillc d97bcec161 refactoring: better field name 2022-08-09 20:32:39 -04:00
rusefillc 64c76bf59c fix Subaru EZ30 trigger gaps fix #4344 2022-07-31 10:15:16 -04:00
rusefillc cfd6828d42 Extra gap ratios for custom trigger wheels fix #4375
these lines are now part of shared method
2022-07-23 10:00:55 -04:00
Andrey 43bc08bc24 Extra gap ratios for custom trigger wheels fix #4375 2022-07-23 03:16:11 -04:00
rusefillc 250d8c4213 RoverK - wow that's odd, but whatever 2022-07-12 02:42:41 -04:00
rusefillc b2cbd889f9 looks dead 2022-07-12 01:38:25 -04:00
Matthew Kennedy 6267b8621a big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy 88ff234c91 Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy d5f1235a43 trigger tweaks cleanup (#4278)
* simplify some math

* we say yes to the todo

* and put back that test

* test
2022-06-23 23:11:29 -04:00
rusefillc 60b8aa71de https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
rusefillc 22e3ab8220 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
rusefi 214d38f286 verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259 2022-06-18 15:18:45 -04:00
rusefi dcde5cea9e verbose trigger sync should reuse engineSnifferRpmThreshold #4259
docs
2022-06-18 14:44:21 -04:00
rusefi 514531bc5c verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
rusefillc 9d942a1c4a more info verbose trigger/vvt 2022-06-17 22:11:09 -04:00
rusefillc f3a5b027d9 more into "triggerinfo" 2022-06-17 22:10:48 -04:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 54c339c0a4 remove trigger duty cycle calculation (#4213)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy 5f1801f9d6 trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy b5d212dcd8 remove dead useOnlyFirstChannel (#4211)
* This field was ignored.

* move pad out

* gone
2022-05-30 07:03:40 -04:00
Matthew Kennedy cf51533f45 More trigger encapsulation (#4207)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy 6ea78efbe7 bail from trigger_central (#4210) 2022-05-29 10:42:08 -04:00
Matthew Kennedy d85ed5f3c0 trigger decoder returns a result (#4206) 2022-05-28 09:01:45 -04:00
Matthew Kennedy 4a0c7cb8d5 honda trigger sync ratio (#4194) 2022-05-24 17:12:36 -04:00
rusefillc 7a52251375 Pavel says 120 2022-05-24 14:40:54 -04:00
Matthew Kennedy 65db5aacaa Fix trigger error indicator (#4185)
* test and fix

* more shards!
2022-05-19 09:43:42 -04:00
Matthew Kennedy eb257b2335 12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy 76a15dd711 don't rely on triggerStateListener to detect trigger errors (#4164)
* Write proper TriggerDecoder tests

* Improve logic around sync loss

* these tests I understand

* these I sort of understand....

* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
Matthew Kennedy fa835950a0 remove 360 trigger (#4165)
* remove 360

* s

* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy cf89b42716 move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 05dd33ddb3 switch back to flag (#4155) 2022-05-10 07:52:29 +03:00
Matthew Kennedy dede3f8215 phase resolution rpm limit (#4156) 2022-05-10 07:22:50 +03:00
Matthew Kennedy 55fdd3f3c7 encapsulate stuff properly (#4154) 2022-05-09 15:46:36 -04:00
rusefillc e64c8cfccb synchronized Phase handling improvements fix #4099 2022-05-09 04:36:03 -04:00
rusefillc 5454b8f509 m_hasSynchronizedSymmetrical handling improvements #4099
API progress
2022-05-09 04:04:38 -04:00
rusefillc 23c16280f6 helping build 2022-05-08 09:14:50 -04:00
rusefillc 35901087cd Merge branch 'master' of https://github.com/rusefi/rusefi 2022-05-08 09:11:16 -04:00
GitHub build-firmware Action 5bbb401f85 Auto-generated configs and docs 2022-05-08 13:06:44 +00:00
rusefillc 394d1fe961 refactoring: bringing method names up to date 2022-05-08 09:04:27 -04:00
rusefillc b2771f9b44 Remove value copy from controller into outputChannels #4095 2022-05-08 08:50:27 -04:00
GitHub build-firmware Action a4b7845279 Auto-generated configs and docs 2022-05-08 12:05:34 +00:00
rusefillc ad4591945e Remove value copy from controller into outputChannels #4095 2022-05-08 07:58:19 -04:00
Matthew Kennedy 997565ac22 Trigger gm 3 vs 5 (#4140)
* add parameter

* two modes

* add new mode to list

* format

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy 72e5604f9b fix 36-2 trigger params (#4138)
* fix gap params

* changelog was wrong too

* typo

* binary log knock count and retard

* Revert "binary log knock count and retard"

This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
rusefillc fdeeaac1c8 Corolla 1ZZ 2003 trigger improvements fix #4132 2022-05-04 02:45:44 -04:00
Matthew Kennedy 83caf1ea1b Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy a2e1a079b8 allow enum_class in rusefi_hw_enums.h (#4104)
* make things c++ friendly

* install various canaries in coal mines

* using is much clearer than typedef

* fixing builds

* lps25

* trigger includes were a mess

* c -> c++ cleanup

* os util

* why did so many include os_util.h?

* fwd declare

* cypress/kinetis

* s

* eg33 happy

* happy sim

* cypress usb

* pch

* cypress

* doesn't need to include all that

* h7
2022-04-25 20:38:16 -04:00
GitHub build-firmware Action 8145bd6bc0 Auto-generated configs and docs 2022-04-25 04:01:07 +00:00
GitHub build-firmware Action ba35602702 Auto-generated configs and docs 2022-04-25 03:46:16 +00:00
rusefillc f836dedef7 docs 2022-04-24 16:17:42 -04:00
rusefillc d1173219b6 Remove value copy from controller into outputChannels #4095 2022-04-23 19:53:05 -04:00
rusefillc 1ce5be5629 m_hasSynchronizedSymmetrical handling improvements #4099 (#4101) 2022-04-23 19:45:29 -04:00
GitHub build-firmware Action 192ce371ec Auto-generated configs and docs 2022-04-23 22:02:47 +00:00
rusefi c6599a57b2 Remove value copy from controller into outputChannels #4095 2022-04-23 17:50:20 -04:00
GitHub build-firmware Action 6fe855a3bd Auto-generated configs and docs 2022-04-19 19:11:17 +00:00
rusefillc 6006697351 https://github.com/rusefi/web_backend/issues/166 2022-04-19 14:49:57 -04:00
rusefillc 5f9c9d1732 humans need humane warning messages 2022-04-18 11:35:19 -04:00
GitHub build-firmware Action 783aa1451c Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 30e619fe95 random progress & method rename 2022-04-16 17:40:05 -04:00
rusefillc 8f1fb5dc0f i will confess: i need to fit a debug build into discovery 2022-04-16 17:24:31 -04:00
rusefillc cb4979e068 very random progress 2022-04-16 17:07:57 -04:00
rusefillc e16117f6ce very random progress 2022-04-16 17:04:35 -04:00
rusefillc d9fccb4383 logging of live data structs was: data points #3614
unification with outputs
2022-04-14 21:01:26 -04:00
rusefillc 06f2006626 logging of live data structs was: data points #3614
unification with outputs
2022-04-14 15:46:01 -04:00
rusefillc bc08418280 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
Andrey 20dbc1ff82 Trigger setup in TS is highly confusing: hide operation mode from users? #4031
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey 49fab25b14 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
Andrey 6c69e55ea0 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:11:53 -04:00
rusefillc 2f66b6fe04 huh? 2022-04-02 21:01:29 -04:00
rusefillc 9ae96ea7e5 refactoring: method rename 2022-04-02 21:01:29 -04:00
rusefillc 3dbee88f53 Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 19:08:22 -04:00
rusefillc 6dd790d7ac Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 18:32:40 -04:00
rusefillc 310a2044bd Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-01 21:11:32 -04:00
Andrey d97b2646ed new VVT trigger shape? 4-1 Toyota #1847 2022-03-23 19:25:13 -04:00
Matthew Kennedy 5cf2b1bba5 warning cleanup (#4020) 2022-03-22 16:53:24 -04:00
Andrey 63adb09089 new VVT trigger shape? #1847 2022-03-22 06:34:22 -04:00
rusefillc b555d9e82b toothed previous time #4019 2022-03-21 20:41:09 -04:00
Matthew Kennedy f67f65d31d tweak sync parameters for mitsubishi (#4017) 2022-03-21 19:23:48 -04:00
Andrey ce45951f7a Mitsubishi 4B11 support #4013 2022-03-20 11:24:08 -04:00
Andrey fe790bee93 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:24:50 -04:00
Andrey 8b5fdfa852 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:11:51 -04:00
Andrey ef3248c245 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:06:19 -04:00
Andrey 394deca94a Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 21:34:25 -04:00
Andrey 65fe21cf84 Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-03-19 20:34:51 -04:00
Andrey d8ac904a28 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 17:57:35 -04:00
rusefillc 416f9a974d Mitsubishi 6G75 Support #4014 2022-03-19 16:34:40 -04:00
rusefillc faf84286f5 Mitsubishi 6G75 Support #4014 2022-03-19 16:28:06 -04:00
rusefillc 7548fe13f2 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 15:54:43 -04:00
rusefillc c7cc88ccd0 Mitsubishi 4B11 support #4013 2022-03-19 15:52:42 -04:00
rusefillc d6b1c9faf2 Mitsubishi 3A92 Support (Issue #4011) 2022-03-19 12:01:57 -04:00
rusefillc 9d8c316aff Remove Miata MX5 NB1 trigger fix #3488 2022-01-31 18:20:43 -05:00
rusefillc a80b2dabd7 sporadic HighRevTest testV12 #3806
let's attempt to guess his intentions
2022-01-25 17:24:38 -05:00
rusefillc 22332a4dad sporadic HighRevTest testV12 #3806
is this bug here?
2022-01-25 10:28:35 -05:00
Matthew Kennedy 0dc5ff1941 fix (#3833) 2022-01-24 18:15:18 -05:00
Andrey e0258c4c8e migrating to SensorType::Rpm API 2022-01-20 23:36:09 -05:00
Andrey 5f3324cd6b migrating to SensorType::Rpm API 2022-01-20 23:32:59 -05:00
rusefillc 7b9816d137 Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 20:55:50 -05:00
rusefillc b40c898097 Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 16:42:05 -05:00
rusefillc accc0542b8 Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 16:42:05 -05:00