Commit Graph

1045 Commits

Author SHA1 Message Date
rusefi af4f20551b getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
Matthew Kennedy 00840d99ec copyArray helper (#1048)
* add functions

* uses

* use for proteus

* do it for warmup mult

* do it for cranking settings

* cleanup
2019-12-10 18:04:50 -05:00
rusefi 8760ef2874 v12 2019-12-01 23:45:45 -05:00
rusefi 2d86668a70 v12 2019-12-01 22:37:26 -05:00
rusefi da42d0dd3d v12 2019-11-30 20:24:31 -05:00
rusefi 3ed889486e making things nicer with dual ETB settings 2019-11-30 17:38:33 -05:00
rusefi b04166d173 that's how we can move all fields one by one from boardConfiguration to engineConfiguration
my approach is to move fields from the bottom of BC struct
2019-11-30 10:24:37 -05:00
rusEfi 799027c2e9 all ETBs to run in same HW mode 2019-11-29 16:51:51 -05:00
rusefi 7aa5d3321e v12 2019-11-29 14:51:20 -05:00
rusEfi fb53d2e921 v12 2019-11-29 01:35:45 -05:00
rusEfi 19e828acda v12 2019-11-28 00:40:25 -05:00
rusefi 04f6913d56 MapAveragingCallback schedules all cylinders at once #974
saving pennies
2019-11-24 20:48:25 -05:00
rusefi 7ee657d238 aux valves unit test 2019-11-23 22:55:21 -05:00
rusefi 56ff75004b consistency 2019-11-23 15:53:22 -05:00
Matthew Kennedy 9ee8616cb0 Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusEfi 547d9749df v12 and minor ETB 2019-11-22 23:27:03 -05:00
rusEfi f9ccaf5f01 steps towards dual ETB 2019-11-21 00:49:38 -05:00
rusEfi c6be861de2 v12 2019-11-21 00:19:35 -05:00
rusEfi f249a12163 v12 2019-11-19 00:04:44 -05:00
rusefi 67b434e43a v12 2019-11-18 23:45:35 -05:00
rusefi fc41aaf655 v12 2019-11-17 22:32:27 -05:00
rusefi ebe6a4b981 v12 done right 2019-11-17 09:32:12 -05:00
rusefi fb7cba96b6 code formatting 2019-11-17 09:03:20 -05:00
rusefi 6456374eb8 v12 2019-11-16 16:00:50 -05:00
rusefi efe4d63084 v12 2019-11-15 23:49:28 -05:00
rusEfi c3b793fc55 prometheus cleanup 2019-11-15 00:01:03 -05:00
rusEfi 3530c68a18 M73 2019-11-14 23:58:04 -05:00
rusEfi 54ba4e5407 #pragma once 2019-11-14 22:50:59 -05:00
rusefi 924c4f4fd3 v12 2019-11-09 18:40:06 -05:00
rusefi 99947b3983 v12 2019-11-08 20:53:51 -05:00
rusefi 43aece817b pinout 2019-11-07 20:47:12 -05:00
rusefi 8f5895321c refactoring 2019-11-05 23:17:44 -05:00
rusefi d1afb9b183 moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 21:29:12 -05:00
rusefi f1055f80ae v12 2019-11-03 21:27:37 -05:00
rusefi a2bee7f46b moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 19:36:56 -05:00
rusefi 06b7524c1d moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 17:25:34 -05:00
rusefi 9c94dd503e moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 17:17:43 -05:00
rusefi 5f01a3fb04
skeleton & docs (#995)
* Documentation additions and clarifications.

Added config/boards/skeleton/ as an example and starting point for
board-specific support.

* Describe where the generated files came from.

* Minor rewording

* Delete mistakenly added emacs backups

* Added an overall description and build notes
2019-11-03 08:41:14 -05:00
rusefi 5fd03a9f92 v12 M73 fun begins! 2019-11-01 22:56:58 -04:00
andreika-git ee5ee1942c Kinetis & TLE8888 compatibility & fixes... (#991)
* TLE8888: More compatibility & postTunerStudioState

* activeConfiguration & EFI_ACTIVE_CONFIGURATION_IN_FLASH fix

* Kinetis: jump_to_bootloader() impl.

* Kinetis: UART baudrate safety check

* Kinetis: OMG!..
2019-10-31 16:06:34 -04:00
rusEfi dfef5748b9 pin conflict in MRE test config 2019-10-10 13:32:07 -04:00
rusefi fdfd2244ce One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
just a unit test for now
2019-10-07 23:12:29 -04:00
rusefi 5e48109780 docs & refactoring 2019-10-07 21:23:38 -04:00
Matthew Kennedy d1da567b85 fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
Matthew Kennedy faa2a481ea Simplify thermistor config (#962)
* simplify thermistor config

* fix test
2019-10-02 21:00:10 -04:00
rusefi 7f9e912ea4 pid limits / etb limits 2019-09-29 14:56:18 -04:00
rusefi 0aec02ffb1 docs 2019-09-28 18:49:39 -04:00
rusefi 8c5be72106 idle&ETB progress 2019-09-26 00:02:47 -04:00
rusefi 0a70bdf6f8 docs 2019-09-24 22:28:33 -04:00
rusefi 567bd7dd58 absolute fuel pressure flow calculation #954 2019-09-24 18:39:26 -04:00
rusefi e6aca92ad4 docs 2019-09-23 22:56:06 -04:00
rusefi fdd3e2ef56 docs 2019-09-23 19:08:15 -04:00
rusEfi f843968636 ETB target is using integer values #945
first we will write a unit test
2019-09-22 00:16:46 -04:00
rusefi a221fe6d45 NB2 progress 2019-09-21 21:36:53 -04:00
rusefi f588224559 NB2 miata on Frankenso with ETB 2019-09-21 01:21:53 -04:00
rusefi b80710e7a7 refactoring "date" command and flex dead code 2019-09-20 18:12:56 -04:00
rusefi a7f893c41f extracting hunchback stuff to a separate file 2019-09-20 17:46:54 -04:00
rusefi ec9c8faa6d docs 2019-09-20 00:24:22 -04:00
rusEfi 08c751bd9c NA8 2019-09-15 10:04:24 -04:00
rusefi d90f0481b0 one step back :) instant RPM does not look right 2019-09-10 21:35:10 -04:00
rusefi e79287f537 Delayed A/C compressor switch #922 2019-09-08 21:05:03 -04:00
rusefi 9417adcbd6 fixing unit tests 2019-09-08 19:29:30 -04:00
rusefi 0b8ebdbf96 A/C NA6 compressor progress 2019-09-08 16:45:02 -04:00
rusefi 8d48e2eef5 MRE NA6 2019-09-08 11:17:27 -04:00
rusefi ea05118bb6 MRE NB2 2019-09-06 17:38:05 -04:00
rusEfi 3a9a314689 MRE NB2 2019-09-05 23:14:28 -04:00
rusefi 2e881ecad5 MRE NB2 2019-09-04 21:36:34 -04:00
rusEfi 9f9ba6593d MRE NB2 2019-09-04 20:38:09 -04:00
rusefi eb55f6ffc7 MRE NB2 2019-09-04 00:30:20 -04:00
rusefi 612a4ab3b3 MRE NB2 2019-09-03 23:35:49 -04:00
rusEfi ba02a1a4fc MRE NB2 2019-09-02 21:55:38 -04:00
rusEfi a027f827e7 MRE NB2 2019-09-02 17:16:36 -04:00
rusefi ce8d376812 MRE NB2 2019-09-02 12:34:17 -04:00
rusEfi 5b3c30831c MRE NB2 2019-09-02 11:07:34 -04:00
rusEfi 8126b700de NB2 progress, ETB Live Docs progress 2019-09-01 19:37:58 -04:00
rusEfi 9f9fc48e84 NB2 settings 2019-08-31 20:17:47 -04:00
rusEfi 47bbd6ebe4 ETB progress 2019-08-31 20:17:17 -04:00
rusEfi 3851b37be6 NB2 MRE 2019-08-31 18:36:44 -04:00
rusefi 3fe8ee7bbf NA6 2019-08-31 17:07:29 -04:00
rusEfi 71472af1c4 NA6 2019-08-31 16:25:43 -04:00
rusefi e6e43d248c NA6 2019-08-25 00:31:46 -04:00
rusEfi f5452a922f MRE NA6 2019-08-18 14:43:38 -04:00
rusEfi 59daae8f5c MRE & Miata 2019-08-17 22:42:22 -04:00
rusefi b09ab8a57f TLE8888 should be re-initialized every time we get +12 volts fix #901
fuel pump test passed, also longer start-up timeout is needed for reliable start
2019-08-16 23:21:03 -04:00
rusEfi 1a1fe77ff8 MRE ETB 2019-08-15 01:59:15 -04:00
rusefi 23377516a9 making LCD great again 2019-08-13 00:03:31 -04:00
rusefi 7fa780b9e5 making LCD great again 2019-08-12 23:48:58 -04:00
rusefi f8315fa5c2 TS refresh & better MRE test configuration 2019-08-10 16:25:42 -04:00
rusefi 074c99fab7 low side channels on MRE #900
this should NOT work but it works?

2019-08-10_15_19_19_770: EngineState: injection #1 @ ext:TLE8888.OUT22 led1
2019-08-10_15_19_19_771: EngineState: injection #2 @ PE10 led10
2019-08-10_15_19_19_773: EngineState: injection #3 @ PE12 led5
2019-08-10_15_19_19_774: EngineState: injection #4 @ PE14 led4
2019-08-10_15_19_19_775: EngineState: injection #5 @ ext:TLE8888.OUT24 led7
2019-08-10_15_19_19_775: EngineState: injection #6 @ PE11 led6
2019-08-10_15_19_19_777: EngineState: injection #7 @ PE9 led9
2019-08-10_15_19_19_777: EngineState: injection #8 @ PE8 led8
2019-08-10_15_19_19_779: EngineState: injection #9 @ PE13 led3
2019-08-10_15_19_19_780: EngineState: injection #10 @ ext:TLE8888.OUT23
 led2
2019-08-10 15:23:41 -04:00
rusefi 4ddf0ba5a2 low side channels on MRE #900
getting closer but still issues
2019-08-10 14:53:57 -04:00
rusefi ef79fb15ba low side channels on MRE #900
progress - now all 10 BLINK, but two are blinking together
2019-08-10 13:45:00 -04:00
rusefi 961d6d8c5b low side channels on MRE #900 2019-08-09 23:45:35 -04:00
rusEfi 41bde00ed4 MRE test setup 2019-08-09 21:16:27 -04:00
rusEfi 4da57da755 MRE test 2019-08-09 19:11:15 -04:00
rusefi f0c318aafd WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898 2019-08-08 23:11:56 -04:00
rusefi 2438b3a27a NA6 2019-08-08 00:15:24 -04:00
rusEfi d5451a7b4f NA6 & trigger 2019-08-06 22:17:18 -04:00
rusEfi bde25114d5 NA6 MRE details 2019-08-06 17:59:02 -04:00
rusefi d6979c8671 NA6 MRE 2019-08-06 17:26:16 -04:00
rusefi 8d14561fb9 better method name 2019-08-06 17:12:15 -04:00
rusEfi 070ebd65c6 MRE test setup 2019-08-05 23:00:35 -04:00
andreika-git 11b718adf7 Use BOARD_TLE8888_COUNT for more compatibility (#889) 2019-07-27 09:37:45 -04:00
rusefi a56c8320b7 removing least useful engine configurations 2019-07-25 00:31:37 -04:00
rusefi 35a075142f fixing build? 2019-07-24 23:39:41 -04:00
rusefi 3ac83dc34e setDefaultBoardConfiguration shouldn't have Frankenso pinout #852 2019-07-24 22:00:48 -04:00
rusefi fc241ce665 setDefaultBoardConfiguration shouldn't have Frankenso pinout #852
merging methods since always invoked together
2019-07-24 21:24:39 -04:00
rusEfi 335a154a5a miata NA6 progress 2019-07-21 20:11:12 -04:00
rusefi 84955cdedb throttle pedal up switch for Miata NA6 2019-07-21 17:06:16 -04:00
Matthew Kennedy 21d1b25c5e Remove warmup afr pid (#879)
* config changes

* actually remove from config

* rip out implementation
2019-07-18 18:26:18 -04:00
rusefi 04bc1128df support multiple VVT sensors #885
new fields & packing configuration. bumping configuration version
2019-07-12 14:24:45 -04:00
andreika-git e1b00468f0 Small fix for simulator + bootloader (#877)
* fix simulator

* fix bootloader
2019-07-09 06:06:07 -04:00
andreika-git 00cf9fafe1 More portability (GPIO_F/G + auto_generated_enums) (#876)
* GPIO ports F and G are not everywhere

* auto_generated_enums path flexibility
2019-07-09 05:29:03 -04:00
rusefi b24064d231 NB2 magic clarification 2019-07-01 12:48:08 -04:00
rusefi b2dece5269 undoing wrong fix & better fix for #805
also generator logging improvements
This reverts commit f07f96599b.
2019-06-30 14:28:47 -04:00
rusefi a82c7e30db verbose trigger sync: better field name & check box to engine sniffer 2019-06-25 02:25:26 -04:00
rusefi f07f96599b "Calibrate TPS" broken in TS fix #805 2019-06-17 22:00:34 -04:00
rusefi 09a29be80e input has sizes hard-coded #836 2019-06-10 15:45:18 -04:00
rusefi 30847db935 adding support for smaller table axis 2019-06-10 12:38:32 -04:00
rusefi 7dff7a08c9 reviving tle8888 configuration 2019-06-05 22:32:30 -04:00
rusefi e731060952 docs 2019-06-03 18:15:41 -04:00
rusefi 89aa64739f docs 2019-05-31 18:45:11 -04:00
rusefi 0ba7a916ba docs 2019-05-31 18:27:46 -04:00
rusefi 58f92ae30d the future is now :) 2019-05-05 16:43:07 -04:00
rusefi a59ac4ad0e 8888 usability 2019-05-05 12:48:04 -04:00
rusefi d09bcad3e7 dreams of two ETBs 2019-05-05 12:02:42 -04:00
rusefi c47fdc1bb8 helping build 2019-05-04 22:45:08 -04:00
rusefi a91ca3f9f0 helping build 2019-05-04 22:38:48 -04:00
960 c0ff11a9df Initial engine config, and cleanup. (#786)
* Add files via upload

Initial Engine Config

* Add files via upload

Cleanup

* Added Can coolant message for newer cars
2019-05-04 22:11:05 -04:00
rusEfi f5b247bb8f tiny ETB progress 2019-05-04 11:01:05 -04:00
rusefi d2e2f817db ETB monte carlo keeps track of best result 2019-05-04 09:57:57 -04:00
rusefi d8747359af step towards me7pnp 2019-05-03 18:44:59 -04:00
rusefi ac2a81d381 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
maybe probably pointless refactoring? reducing parameters visibility
2019-05-03 18:41:43 -04:00
rusefi ff641d81e2 fixing build & refactoring 2019-04-28 23:42:49 -04:00
rusEfi 7ee1090ef2 LEDs to test configs 2019-04-28 23:18:51 -04:00
rusefi 7a857ae298 ETB progress 2019-04-24 23:46:49 -04:00
rusefi 2540aebf6e Merge branch 'master' of https://github.com/rusefi/rusefi 2019-04-21 14:22:05 -04:00
rusefi c096680ce6 tiny progress 2019-04-21 14:21:47 -04:00
rusefi b19370505d :( 2019-04-21 14:16:56 -04:00
rusefi c802e46be0 docs 2019-04-21 14:11:39 -04:00
rusefi 5b522dc8fd this change is probably breaking stuff, but some stuff is already broken. something is not right in too many places :( 2019-04-21 14:00:19 -04:00
rusefi 3d5338c1de docs 2019-04-21 12:24:31 -04:00
rusefi 14f3c6ad0c USB and TLE8888 not working for F4 or F767 #764 2019-04-21 10:13:34 -04:00
rusefi f3a6ce0769 USB and TLE8888 not working for F4 or F767 #764 2019-04-20 23:49:26 -04:00
rusefi 73bc740967 USB and TLE8888 not working for F4 or F767 #764
ready to try anything
2019-04-20 18:15:05 -04:00
rusefi 0677d61f1f USB and TLE8888 not working for F4 or F767 #764 2019-04-19 18:17:04 -04:00
andreika-git 370b0dd003 Default config refactor (#762)
* Refactor config

* Fix FSIO_ANALOG_INPUT_COUNT
2019-04-16 10:27:34 -04:00
andreika-git ffd44bf0fe More config portability: TLE6240, Trigger_input, UART/Serial (#759)
* Add fields to UART/Serial configs

* trigger_input: can be both HAL_USE_PAL and HAL_USE_COMP

* tle6240 config: local temporary solution

* Fix for custom_engine::setFsio

* EFI_ACTIVE_CONFIGURATION_IN_FLASH
2019-04-15 08:40:12 -04:00
rusefi 2f34edb0d4 we need TLE8888 driver #714 2019-04-14 16:08:39 -04:00
rusefi 75ea5cd812 we need TLE8888 driver #714 2019-04-13 12:43:19 -04:00
rusefi fb0bbc075c steps towards smarter gpio 2019-04-13 12:02:34 -04:00
rusefi 16cf6388b6 ETB using tle7209 fix #746 2019-04-13 01:03:12 -04:00
rusefi d8281626df defined(__DOXYGEN__) ? fix #748 2019-04-12 22:10:57 -04:00
dron0gus b7f69a0e08 Subaru EJ20G ECU: initial support (#751) 2019-04-13 01:23:48 +02:00
rusefi 379c912b0c ETB using tle7209 #746 2019-04-11 23:21:16 -04:00
rusefi 8ae8d3d58f we need TLE8888 driver #714 2019-04-06 12:26:37 -04:00
rusefi 17f073a439 we need TLE8888 driver #714 2019-04-06 07:38:02 -04:00
rusefi 0aac3c8f41 we need TLE8888 driver #714 2019-04-04 23:03:32 -04:00
rusefi 21283f5b8c we need TLE8888 driver #714 2019-04-04 21:34:33 -04:00
rusefi cd7cc596bc cranking base_fuel reform 2019-04-04 08:26:57 -04:00
andreika-git 001fbb2526 More portability & bootloader fix (#720)
* fix bootloader

* EFI_FSIO

* EFI_EMULATE_POSITION_SENSORS, EFI_BOARD_TEST, EFI_AUX_PID, EFI_JOYSTICK
2019-03-29 15:46:15 +01:00
andreika-git b80806182f More portability & small fixes (#719)
* Use hw_stm32.mk

* Fix bootloader

* Use more common hw_ports.mk filename instead of hw_stm32.mk

* More CPU compatibility for Makefile

* TS_UART_MODE & rename TS_SERIAL_UART_DEVICE->TS_SERIAL_DEVICE

* Move lockAnyContext()/unlockAnyContext() to rfiutil.c

* USE_FATFS

* EFI_LCD

* Less compilation errors

* STATUS_LOGGING_BUFFER_SIZE & SETTINGS_LOGGING_BUFFER_SIZE

* EFI_ALTERNATOR_CONTROL, EFI_SERVO, EFI_DISABLE_CONSOLE_ACTIONS

* #ifndef PWM_PHASE_MAX_COUNT & more flexible GPIO inside portname()

* merge

* EFI_ALTERNATOR_CONTROL, EFI_ELECTRONIC_THROTTLE_BODY
2019-03-29 15:29:01 +01:00
rusefi b3ad684bd6 NA6 idle settings 2019-03-22 21:39:38 -04:00
rusefi 26c1c3b6b9 this tune started 20C cold engine 2019-03-21 21:57:49 -04:00
rusEfi 9a87b9e51b better Electronic Throttle body control #493 2019-03-11 00:31:06 -04:00
rusefi 60a5b2c5ea better Electronic Throttle body control #493
two ETBs
2019-03-10 12:02:25 -04:00
rusefi 38c28f28b7 dead code 2019-03-10 01:06:32 -05:00
rusEfi 9a11d26cc3 better Electronic Throttle body control #493 2019-03-09 23:31:47 -05:00
dron0gus c9edbf4225 Cleanup fixes (#700)
* Kill some more warnings

* pin_repository: add markUnused, allow use from plain C

* ehiGpio.cpp: add forgotten GPIOG port
2019-03-08 07:01:15 -05:00
rusEfi e9a88c18f6 ETB progress 2019-03-03 15:27:49 -05:00
rusefi 61a2a33d8f ETB_BENCH_ENGINE 2019-03-02 22:42:11 -05:00
rusEfi 333ce71923 ETB iTerm limits 2019-03-02 14:00:32 -05:00
rusEfi c01734b8a4 TPS commands & compacting 2019-03-02 13:21:12 -05:00
rusEfi e452b6802b ETB 2019-03-01 23:09:33 -05:00
rusEfi d1da63ecac ETB 2019-02-27 17:54:25 -05:00
rusEfi fb3d06aebf ETB 2019-02-27 09:57:03 -05:00
rusefi 635bbcc960 ETB_BENCH_ENGINE 2019-02-27 08:55:56 -05:00
rusEfi 6dcbe26e56 NA6 base tune 2019-02-26 21:59:19 -05:00
rusefi bdbecb8c42 NA6 base tune 2019-02-26 21:50:58 -05:00
rusefi 9325cd6d23 better (?) variable names 2019-02-10 22:47:49 -05:00
rusefi 7c5e485acb F7 2019-02-06 18:53:43 -05:00
rusefi 4c7fdc8365 Festiva defaults fix 2019-02-02 20:20:30 -05:00
rusefi d46ebf97de NA6 2019-02-03 17:49:04 -05:00
rusefi f7c8fafdd7 Refactor Trigger System #635 2019-02-03 01:11:50 -05:00
rusefi 259dd91a8a docs 2019-02-02 15:29:40 -05:00
rusefi ee4ac9b240 NA6 progress
A/C toggle switch indicator in TS
renaming "pedalPosition" to "throttlePedalPosition"
2019-01-27 00:02:58 -05:00
rusefi 8594a29c6a minimal pin configuration & EFI_COMMUNICATION_PIN fix 2019-01-26 11:38:14 -05:00
rusefi a50ead0ed6 fix #678 2019-01-20 22:50:00 -05:00
rusefi add6517a74 stage 0 configuration 2019-01-19 20:27:14 -05:00
rusefi 2c859361aa minor standard miata progress 2019-01-13 19:42:08 -05:00
rusefi b4d9de3312 refactoring: better method name 2019-01-11 00:03:42 -05:00
rusefi 3921d36540 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-10 21:10:46 -05:00
rusefi dd8e2d9326 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-10 19:25:07 -05:00
rusefi 1e4bdbb255 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-10 17:07:29 -05:00
rusefi fd14010809 Revert "The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657"
This reverts commit 61440c5
2019-01-10 00:56:08 -05:00
rusefi 61440c5e73 The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657 2019-01-09 23:38:59 -05:00
rusefi 970d120a41 The Big Refactoring of 2019: scheduler should not be global #655 2019-01-09 08:50:51 -05:00
Matthew Kennedy 45d4243636 Improve wall wetting AE to use time constant (#650)
* impruv

* c++17

* add tests, docs
2019-01-06 20:45:51 -05:00
Matthew Kennedy 799923ac5d const (#648) 2019-01-05 08:06:18 -05:00
rusEfi 9edbf8218a #35 2019-01-04 17:18:43 -05:00
rusefi 79bd41b7ba what do I do wrong here? 2019-01-02 22:15:51 -05:00