Commit Graph

3875 Commits

Author SHA1 Message Date
rusefillc 587c448688 CAN side of automated testing #4630 2022-09-29 23:01:06 -04:00
rusefillc a177e01a5f CAN side of automated testing #4630 2022-09-29 20:55:38 -04:00
Andrey e6b8b08853 refactoring: encapsulation 2022-09-28 22:42:08 -04:00
rusefillc 1b95521866 engineSyncCam to be a drop-down not a number value #4611 2022-09-26 05:34:05 -04:00
Matthew Kennedy 90489edb96 schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 178fe15760 more inclusive configuration name 2022-09-24 23:49:41 -04:00
Andrey 3350ad6fbe Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 5935c18beb K progress - just a rename 2022-09-24 23:25:36 -04:00
GitHub gen-configs Action e5c1268b94 Auto-generated configs and docs 2022-09-24 00:19:42 +00:00
rusefillc c6a2f2657b honda K enum rename 2022-09-23 20:13:14 -04:00
Matthew Kennedy 0dfba2a655 remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
rusefillc 55c5fd331c docs: private firmware enums vs public to code generated 2022-09-23 09:41:13 -04:00
Matthew Kennedy 4e78c4c922 two modes trigger scheduler (#4598)
* two modes trigger scheduler

* asOld

* hpfp
2022-09-20 05:28:23 -04:00
rusefillc a1143779f2 documenting biquad or else concerns 2022-09-19 12:06:00 -04:00
GitHub gen-configs Action faa0f46a87 Auto-generated configs and docs 2022-09-18 01:44:04 +00:00
Matthew Kennedy d84a290eca gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 4106704385 add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
GitHub gen-configs Action 3b3707b8bd Auto-generated configs and docs 2022-09-16 20:10:48 +00:00
Matthew Kennedy 14068656ad more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefillc f919845c9c tear down Engine god object #4511
oh I hope this ends well
2022-09-15 23:41:06 -04:00
rusefillc 1c28ca0582 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc ac03dc55d8 CUSTOM_INSTANT_MAP_DECODING 2022-09-15 15:07:31 -04:00
Andrey dc9504f33c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey f5a5764429 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey d9accf1772 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 1d0f13fc41 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey aa0cffcfdb deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey 34f87a3683 inline method to reduce confusion 2022-09-14 01:24:19 -04:00
rusefillc f97c5ed8fd i suspect that no one cares about these 2022-09-14 00:34:04 -04:00
Matthew Kennedy 3358cdab11 resurrect EFI_CLOCK_LOCKS (#4572)
* resurrect EFI_CLOCK_LOCKS

* missing extern

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-09-13 14:07:25 -04:00
Andrey G c1c9d5222a tle8888 dead code (#4568) 2022-09-12 18:54:29 -04:00
rusefillc 21a1914bc8 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:31:42 -04:00
rusefi 95e7358fce at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:15:25 -04:00
Andrey G 2b4012b279 dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 5274cffff3

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G 1ca5988877 time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey G c73a8c2f46 efiWatchdog: avoid converting time to float (#4562)
https://stackoverflow.com/questions/68690961/why-does-converting-int-to-float-lose-precision-in-c-programming-language
2022-09-11 05:46:55 -04:00
GitHub gen-configs Action 97f1ee67d6 Auto-generated configs and docs 2022-09-11 07:53:45 +00:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 8a2975cc1e dead value 2022-09-11 02:34:02 -04:00
rusefillc f9b849dd8f refactoring - reducing API between FW and Java 2022-09-11 02:16:47 -04:00
rusefillc 202c6ba366 send more of Engine Sniffer data #4560
new API & first usage
2022-09-10 23:42:59 -04:00
rusefillc d569f49874 Proteus with SD card outside of vehicle looses a second #4557
message correction
2022-09-10 11:43:25 -04:00
rusefillc 05fa36e744 Mark is asking for VIN number field #3967
GM says Hi
2022-09-10 01:05:31 -04:00
rusefillc 1964f2e893 Proteus with SD card outside of vehicle looses a second #4557 2022-09-09 20:17:02 -04:00
rusefillc f5231ebb85 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 19:21:29 -04:00
rusefillc 64ab64d7de "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 18:27:16 -04:00
rusefillc b9140636b4 refactoring: better method name 2022-09-09 18:02:38 -04:00
rusefillc 9bb35a3d97 How does rusEFI handle 23 (or 46?) days of continues operation #4554 2022-09-09 17:21:58 -04:00
Andrey f8d275f64b tear down Engine god object #4511
just trying different things
2022-09-07 20:25:49 -04:00
Andrey a7c8ce61f4 brutal encapsulation 2022-09-07 19:37:11 -04:00
Andrey 8f14c44097 extracting prime_injection 2022-09-07 16:25:50 -04:00
Andrey 25b6d39802 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey ab3d92b995 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey b6eddaee59 tear down Engine god object #4511
just trying different things
2022-09-05 03:38:44 -04:00
Andrey f8febab683 tear down Engine god object #4511
just trying different things
2022-09-05 03:18:32 -04:00
Andrey da7a4b6641 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 76b74a85ba tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 1983a07078 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey 841cd4f962 refactoring: moving field 2022-09-05 00:53:05 -04:00
Andrey 9a9b33401c refactoring: splitting header where cpp was already split 2022-09-05 00:48:38 -04:00
Andrey e9e040895b different file names for different entities 2022-09-04 23:11:19 -04:00
GitHub gen-configs Action 0a37c6d963 Auto-generated configs and docs 2022-09-05 02:44:56 +00:00
Andrey 8fd5e46472 refactoring: reducing outputChannels copy 2022-09-04 22:38:05 -04:00
GitHub gen-configs Action 19addcb2ff Auto-generated configs and docs 2022-09-04 13:57:19 +00:00
Matthew Kennedy 99161cc523 use defs instead of magic numbers (#4523)
* use defs instead of magic numbers

* consecutive
2022-09-04 09:52:14 -04:00
Matthew Kennedy fba0906942 more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
GitHub gen-configs Action 4857561a0d Auto-generated configs and docs 2022-09-03 21:35:26 +00:00
rusefi 42e95a0b34 refactoring: reducing outputChannels copy 2022-09-03 17:29:35 -04:00
Andrey f008a98b94 refactoring: reducing outputChannels copy 2022-09-03 17:12:47 -04:00
Andrey 93032c7c1f tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey 73423a612a tear down Engine god object #4511
just trying different things
2022-09-03 11:05:27 -04:00
Andrey e56924310b tear down Engine god object #4511
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc 78b28c8f90 typo 2022-09-03 07:26:49 -04:00
Andrey 51396deefa dead 2022-09-03 06:59:00 -04:00
GitHub gen-configs Action 59543fa221 Auto-generated configs and docs 2022-09-02 18:42:52 +00:00
rusefillc 54e05ba0fc moving state into specific class (#4520)
* moving state into specific class

* moving state into specific class
2022-09-02 14:38:03 -04:00
rusefillc 0e27ec6633 another huh (#4517)
* another huh

* why does this not compile
2022-09-02 13:10:21 -04:00
rusefillc f8e37e6af7 I am sure that's not magic (#4516)
* I am sure that's not magic

* forward declaration acts funny
2022-09-01 22:33:45 -04:00
Andrey 254385feb2 another dead line 2022-09-01 21:13:03 -04:00
Andrey 074e5c840b Revert "tear down Engine god object #4511"
This reverts commit 3094cc6be7.
2022-09-01 20:44:51 -04:00
Andrey b017ef8031 Revert "tear down Engine god object #4511"
This reverts commit 2d689f5a5a.
2022-09-01 20:44:51 -04:00
Andrey 22c9b6896d what a mess :( 2022-09-01 20:16:57 -04:00
Andrey 2d689f5a5a tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 3094cc6be7 tear down Engine god object #4511
just trying different things
2022-09-01 20:15:46 -04:00
Andrey 05e851c138 tear down Engine god object #4511
just trying different things
2022-09-01 19:24:19 -04:00
GitHub gen-configs Action 8785db9762 Auto-generated configs and docs 2022-09-01 23:18:26 +00:00
Andrey c9008214f5 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Andrey d1917a2a62 tear down Engine god object #4511
just trying different things
2022-09-01 19:00:16 -04:00
Matthew Kennedy 716b0c1f60 extract updateInjectionAngle (#4512) 2022-09-01 18:48:03 -04:00
Andrey 80fa25488a tear down Engine god object #4511
smallest step maybe forward
2022-09-01 13:55:03 -04:00
Andrey 1ffa98ba89 a bit of dead code 2022-09-01 11:47:56 -04:00
GitHub gen-configs Action f19c219587 Auto-generated configs and docs 2022-09-01 15:03:34 +00:00
Andrey 436c294770 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
GitHub gen-configs Action bac4f9800f Auto-generated configs and docs 2022-09-01 14:39:52 +00:00
Andrey 09f0a540b6 refactoring: reducing outputChannels copy 2022-09-01 10:30:07 -04:00
Andrey b64e553d5d refactoring: reducing outputChannels copy 2022-09-01 01:06:49 -04:00
Andrey 2a949f6cd2 dead code 2022-09-01 00:23:33 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey be790e2c44 less code is better 2022-08-31 23:14:20 -04:00
Andrey 3eaaf5e293 english do you speak it 2022-08-31 22:56:38 -04:00
GitHub gen-configs Action 0c4945eacf Auto-generated configs and docs 2022-09-01 02:17:58 +00:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Matthew Kennedy d9ca1fb578 set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 2926570747 idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
GitHub gen-configs Action e89eff7370 Auto-generated configs and docs 2022-08-29 03:13:09 +00:00
rusefillc 6be7438cf0 TT_VVT_MAZDA_MYSTERY 2022-08-28 22:57:44 -04:00
GitHub gen-configs Action 9a91c80632 Auto-generated configs and docs 2022-08-29 02:18:23 +00:00
rusefillc 35f17f38b3 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
rusefillc b3dfbd5a1d more proper fix for part of https://github.com/rusefi/rusefi/pull/4493 2022-08-27 22:28:29 -04:00
rusefillc 6968d74b3c separate atomic change (#4494)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:09:54 -04:00
rusefillc da9639ff5d Default GPPWM note 2022-08-27 15:19:35 -04:00
rusefillc c0391b16e4 docs 2022-08-25 23:50:00 -04:00
rusefillc 7e6bb54e7a saving 4 bytes of RAM? 2022-08-25 22:34:16 -04:00
rusefillc 72c4637512 progress or maybe even a fix of logging? 2022-08-25 22:24:35 -04:00
rusefillc fb3343dff5 this code is too dead 2022-08-25 22:09:22 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Andrey 5392f8d13e https://github.com/rusefi/hellen154hyundai/issues/60
extra logging
2022-08-25 19:58:10 -04:00
GitHub gen-configs Action 1117be38e3 Auto-generated configs and docs 2022-08-25 22:51:12 +00:00
rusefi 10d77f92b3 https://github.com/rusefi/hellen154hyundai/issues/60 2022-08-25 18:44:23 -04:00
GitHub gen-configs Action 2629924a06 Auto-generated configs and docs 2022-08-24 22:15:50 +00:00
Matthew Kennedy dfd340e8c3 log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
GitHub gen-configs Action 8577e7b882 Auto-generated configs and docs 2022-08-24 16:16:12 +00:00
rusefi 7340700b74 refactoring 2022-08-24 12:11:11 -04:00
rusefi 31df3da2cf refactoring 2022-08-24 12:02:39 -04:00
rusefillc ecdde2cf6d docs 2022-08-23 22:54:48 -04:00
GitHub gen-configs Action 3bbb26ed24 Auto-generated configs and docs 2022-08-24 02:19:34 +00:00
rusefillc 13f9e6d76a log the state of hasSynchronizedPhase() for future diagnostic help. 2022-08-23 22:14:32 -04:00
GitHub gen-configs Action 9ce8250a90 Auto-generated configs and docs 2022-08-22 22:32:47 +00:00
rusefillc 101d597d9a // todo: migrate to engineState->desiredRpmLimit to get this variable logged 2022-08-22 18:23:48 -04:00
GitHub gen-configs Action 525509a260 Auto-generated configs and docs 2022-08-22 15:19:58 +00:00
rusefillc 27b5db8789 Pavel Xenon is asking for EGT limping mode #3172 2022-08-22 11:12:34 -04:00
rusefillc 06018ada5b Idle air add via Lua fix #4465
AddressSanitizer being useful?
2022-08-21 00:58:59 -04:00
rusefillc 38e3a84ec9 Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
Matthew Kennedy 6218edd040 allow logging multiple warnings at once (#4414)
* allow logging multiple warnings at once

* comment

* .Code

* Revert ".Code"

This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.

* add a better comparison operator instead of conversion

* dot code

* Revert "dot code"

This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.

* force gcc-10 maybe?

* Revert "force gcc-10 maybe?"

This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.

* vq

* dot code

* dead

* dot code

* return may be null

* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?

* move static vector

* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
GitHub gen-configs Action 1343699a2f Auto-generated configs and docs 2022-08-17 05:08:02 +00:00
rusefillc dfd4953f0d unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
rusefillc bf15c5bc8a ISO-TP does not work on real car #4427 2022-08-09 13:12:51 -04:00
Matthew Kennedy eb442998dc misc fixes (#4411)
* fix warnings

* break to debugger in case of panic

* move the check

* s
2022-08-02 12:19:50 -04:00
Matthew Kennedy f49f6494fb report injector, ignition faults (#4408)
* report injector, ignition faults

* guard
2022-08-01 15:41:47 -04:00
Matthew Kennedy d4721bee89 implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc ee455d23f8 [SECURITY] Cheap password protection against tune modification fix #4243
helping build
2022-07-30 14:33:11 -04:00
rusefillc e19b61aa5b [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
Matthew Kennedy 14b39b7b0a unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
GitHub build-firmware Action dcc43ee4b4 Auto-generated configs and docs 2022-07-27 09:38:56 +00:00
Matthew Kennedy 4865213537 Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 58b0aaeda1 cherry pick https://github.com/rusefi/rusefi/pull/4365 2022-07-21 15:26:41 -04:00
rusefillc 2bc4fd909d Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
rusefillc 116207e9aa Launch control bug? "range" thing is confusing #4348 2022-07-20 18:39:17 -04:00
rusefillc 2ba07e975e Launch control bug? "range" thing is confusing #4348
bug or dead code? at least making it a bit more obvious
2022-07-20 18:30:20 -04:00
rusefillc f9ba8bf82c Launch control bug? "range" thing is confusing #4348
refactoring: reducing confusion
2022-07-20 18:24:36 -04:00
rusefillc 8213252f45 code formatting #4348 2022-07-20 18:16:54 -04:00
Matthew Kennedy cd98ad35c2 use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
rusefillc 4ba73d1679 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 14:04:21 -04:00
rusefillc 456d52e1fe Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
rusefillc 9e8bfe92d8 #4308 progress 2022-07-14 12:36:55 -04:00
rusefillc db3f92edf4 Lua A/C Input #4333 2022-07-08 00:51:53 -04:00
GitHub build-firmware Action 1d148c57df Auto-generated configs and docs 2022-07-08 04:45:52 +00:00
rusefillc c23fe0fe9a Lua A/C Input #4333 2022-07-08 00:25:29 -04:00
Matthew Kennedy 16a39badff Error handling cleanup (#4332)
* dead code in stm32

* rusefi.cpp can have some noreturn

* handle lua panic

* unused error codes

* simplifications of error_handling.cpp

* comment

* put that back

* guard
2022-07-07 23:49:02 -04:00
GitHub build-firmware Action bba4a89f3e Auto-generated configs and docs 2022-07-08 03:21:52 +00:00
Matthew Kennedy 68fb838641 Lua hooks for gear detection (#4328)
* implement

* sim has vss

* write a test

* guard
2022-07-07 23:16:56 -04:00
rusefillc c51881a80d debug is set to idle mode, but none of the debug fields show anything #4335
reducing confusion
2022-07-07 23:04:19 -04:00
Matthew Kennedy 6267b8621a big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy b5d85334c3 hellen board ID detect improvements (#4307)
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
rusefillc 129e4df5bf Uniform reset pattern for all Lua adjustments #4308
no progress only preparation
2022-06-30 20:07:27 -04:00
GitHub build-firmware Action 784309ca86 Auto-generated configs and docs 2022-06-30 17:53:57 +00:00
rusefillc 970c1b3422 https://github.com/rusefi/rusefi_documentation/issues/226 2022-06-30 13:38:15 -04:00
rusefillc f24c42c605 https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
Matthew Kennedy 67439afb96 rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
GitHub build-firmware Action 7d5f4cac7c Auto-generated configs and docs 2022-06-29 22:16:13 +00:00
Matthew Kennedy baa7d17799 use detected hellen board type on h72 (#4305)
* use detected hellen board type

* s

* s

* name
2022-06-29 18:10:29 -04:00
Andrey 65ffcc4f37 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc a363be35bb logging of live data structs was: data points #3614 2022-06-29 03:03:02 -04:00
rusefillc fb84241a48 logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc 92119af801 logging of live data structs was: data points #3614 2022-06-29 02:37:24 -04:00
GitHub build-firmware Action 58c34d398e Auto-generated configs and docs 2022-06-29 06:21:31 +00:00
rusefillc 3283ce7348 logging of live data structs was: data points #3614 2022-06-29 02:16:15 -04:00
rusefillc 61f6423a42 logging of live data structs was: data points #3614 2022-06-29 02:09:37 -04:00
GitHub build-firmware Action 5247d1f717 Auto-generated configs and docs 2022-06-29 06:06:27 +00:00
rusefillc 2e28537776 logging of live data structs was: data points #3614 2022-06-29 01:49:59 -04:00
rusefillc 0072f3559c logging of live data structs was: data points #3614 2022-06-29 01:38:43 -04:00
rusefillc 2ab71f88e5 logging of live data structs was: data points #3614 2022-06-29 01:27:42 -04:00
GitHub build-firmware Action 09e89f54dc Auto-generated configs and docs 2022-06-29 05:23:15 +00:00
rusefillc 69be42ea33 https://github.com/rusefi/hellen-NB2-issues/issues/36 2022-06-29 01:15:11 -04:00
GitHub build-firmware Action 81f1df25e4 Auto-generated configs and docs 2022-06-27 00:12:14 +00:00
rusefillc 4cbc267c4b stealing from David 2022-06-26 19:40:54 -04:00
Matthew Kennedy 88ff234c91 Injector scheduled by angle, not tooth index (#4208)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
2022-06-24 17:43:23 -04:00
GitHub build-firmware Action fbdebdc20e Auto-generated configs and docs 2022-06-24 00:20:41 +00:00
Matthew Kennedy 840bf6fb27 wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy 478549ccdf get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 98e0297987 force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
rusefi aae5b9fab6 miata 96 defaults 2022-06-23 14:30:41 -04:00
Matthew Kennedy be3e64fd2a clean up sd overrides (#4272) 2022-06-23 09:15:51 -04:00
GitHub build-firmware Action f6f0e2fcde Auto-generated configs and docs 2022-06-20 15:49:50 +00:00
rusefillc 60b8aa71de https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 11:41:33 -04:00
GitHub build-firmware Action d8d7ab66f7 Auto-generated configs and docs 2022-06-20 11:50:51 +00:00
rusefillc 22e3ab8220 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
Matthew Kennedy 40106224f0 Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi 514531bc5c verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 808287dc71 fix (#4254) 2022-06-17 21:20:47 -04:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
GitHub build-firmware Action db929ea937 Auto-generated configs and docs 2022-06-02 01:31:50 +00:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 5f1801f9d6 trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
rusefillc 3cc4e3143c TS injector bench test pulse is too short fix #4192 2022-05-22 09:43:09 -04:00
rusefillc 5902a55739 B6 test mule 2022-05-21 02:25:43 -04:00
GitHub build-firmware Action ba5910652d Auto-generated configs and docs 2022-05-21 05:58:46 +00:00
rusefillc fb3b1120b1 B6 test mule 2022-05-21 01:45:09 -04:00
GitHub build-firmware Action 80a44ad098 Auto-generated configs and docs 2022-05-18 04:16:08 +00:00
Matthew Kennedy a0d9a584db prototype overcurrent protected driver (#4029)
* stub passthrough protected driver

* plumbing

* include the thing

* signature

* dead

* tdg pdm build task

* s

* pdm pins

* tdg

* init properly

* remove gaps

* board doesn't fatal on start
2022-05-17 23:49:18 -04:00
GitHub build-firmware Action 19522865a5 Auto-generated configs and docs 2022-05-18 03:21:00 +00:00
Matthew Kennedy eb257b2335 12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
rusefillc 62698dbe99 PDM dreams 2022-05-17 21:18:43 -04:00
rusefillc c03ee706bf default VR curve is needed not just by hellen, we have Proteus adapters with it now! 2022-05-17 17:54:11 -04:00
rusefillc ab711cddc5 dead code 2022-05-15 10:13:47 -04:00
Matthew Kennedy 0c9a45a2ac no enum to string for obd (#4168) 2022-05-13 06:41:06 +03:00
rusefillc 7ecab834ac docs 2022-05-12 04:56:23 -04:00
GitHub build-firmware Action c097309234 Auto-generated configs and docs 2022-05-11 10:51:10 +00:00
Matthew Kennedy fa835950a0 remove 360 trigger (#4165)
* remove 360

* s

* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy cf89b42716 move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy b243d3fca0 TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 2161751187 clarify doesTriggerImplyOperationMode (#4153) 2022-05-09 15:28:30 -04:00
rusefillc 178721c809 Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
rusefillc b6525e8acc User was unable to find Ford Mustang firing order 1-5-4-2-6-3-7-8 in the list #4150 2022-05-08 07:11:53 -04:00
rusefillc c557b4ec30 Revert "Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150"
This reverts commit 086b4885c9.
2022-05-08 07:10:54 -04:00
rusefillc 086b4885c9 Ford Mustang firing order 1-5-4-2-6-3-7-8 fix #4150 2022-05-08 07:07:34 -04:00
GitHub build-firmware Action 37b0211bc7 Auto-generated configs and docs 2022-05-06 12:32:54 +00:00
Matthew Kennedy 997565ac22 Trigger gm 3 vs 5 (#4140)
* add parameter

* two modes

* add new mode to list

* format

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
rusefillc 0ed0702536 Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
GitHub build-firmware Action 7db1d3d0d2 Auto-generated configs and docs 2022-05-02 09:02:46 +00:00
Andrey 1f6e09de84 Technical debt: ENUM_32_BITS #3874
one step back
2022-05-02 04:38:04 -04:00
GitHub build-firmware Action a2366d187e Auto-generated configs and docs 2022-05-02 08:21:38 +00:00
rusefillc c84a32f194 Next steps 4 (#4130)
* Technical debt: ENUM_32_BITS #3874

* Make ETB low limit configurable #4119

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-02 04:13:59 -04:00
Andrey 03662e48c4 Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
GitHub build-firmware Action 75166b15d1 Auto-generated configs and docs 2022-05-02 03:14:48 +00:00
rusefillc 78ca563cc4 Technical debt: ENUM_32_BITS #3874 2022-05-01 23:07:12 -04:00
GitHub build-firmware Action 9a2302eb40 Auto-generated configs and docs 2022-05-01 19:20:46 +00:00
rusefillc d8fc872fba Technical debt: ENUM_32_BITS #3874
hmm one step back
2022-05-01 15:13:01 -04:00
GitHub build-firmware Action 0c4e27e557 Auto-generated configs and docs 2022-05-01 18:18:04 +00:00
rusefillc 6aa2c54768 Technical debt: ENUM_32_BITS #3874 2022-05-01 13:51:36 -04:00
GitHub build-firmware Action 0d0a42a61d Auto-generated configs and docs 2022-05-01 12:09:38 +00:00
rusefillc 2b11b54003 Next steps (#4120)
* Technical debt: ENUM_32_BITS #3874

* Technical debt: ENUM_32_BITS #3874

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-05-01 08:02:51 -04:00
GitHub build-firmware Action 6418d7b11b Auto-generated configs and docs 2022-04-30 18:29:47 +00:00
rusefillc a0da677a1e this seems mostly dead? 2022-04-30 13:43:09 -04:00
rusefillc e78b93ee07 oh not all dead 2022-04-30 13:35:25 -04:00
rusefillc a1d89cb093 Technical debt: ENUM_32_BITS #3874 2022-04-30 13:16:34 -04:00
rusefillc 1f590637ab wow dead code 2022-04-30 13:09:03 -04:00
GitHub build-firmware Action 4a4ebb4505 Auto-generated configs and docs 2022-04-30 17:07:03 +00:00
rusefillc 1ae5625801 Technical debt: ENUM_32_BITS #3874 2022-04-30 12:54:12 -04:00
GitHub build-firmware Action d2d07e40ff Auto-generated configs and docs 2022-04-30 02:32:30 +00:00
Andrey 33b4f8f86d CAN GPIO #4096 2022-04-29 22:15:54 -04:00
GitHub build-firmware Action 94b9e4a5b1 Auto-generated configs and docs 2022-04-30 00:36:25 +00:00
rusefillc 4af8a13a31 CAN GPIO #4096 2022-04-29 20:29:50 -04:00
rusefillc f341ce561e 2 byte pin index #4097 (#4102)
* 2 byte pin index #4097

* 2 byte pin index #4097

good time to defragment configuration

* 2 byte pin index #4097

new fancy way

* 2 byte pin index #4097

smart comment

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-04-29 19:35:31 -04:00
GitHub build-firmware Action b84cb0d83a Auto-generated configs and docs 2022-04-28 22:06:22 +00:00
Matthew Kennedy 83caf1ea1b Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy 2d033df11b more missing autoscale (#4112)
* autoscale m_config->timeConstant

* min/max afr

* more

* dwell voltage

* closed loop fuel

* knock

* map estimate

* applyNonlinearBelowPulse

* fix

* add a test while we're at it for un-covered code

* test fallback MAP since we touched that

* always compute fallback MAP even if sensor is OK
2022-04-28 08:16:02 -04:00
Matthew Kennedy a2e1a079b8 allow enum_class in rusefi_hw_enums.h (#4104)
* make things c++ friendly

* install various canaries in coal mines

* using is much clearer than typedef

* fixing builds

* lps25

* trigger includes were a mess

* c -> c++ cleanup

* os util

* why did so many include os_util.h?

* fwd declare

* cypress/kinetis

* s

* eg33 happy

* happy sim

* cypress usb

* pch

* cypress

* doesn't need to include all that

* h7
2022-04-25 20:38:16 -04:00
rusefillc d5fb1113d3 [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:42:19 -04:00
rusefillc 7d2d6c4a01 [EPIC] [Feature Request] Transmission Control #1454 2022-04-25 17:20:56 -04:00
rusefillc e0e61f7f44 FasterEngineSpinUp should be enabled by default fix #4094 2022-04-23 09:51:47 -04:00
David Holdeman b4e8dfb05a More untested transmission features (#4093)
* use ISS for gearbox ratio, add gauge for TC ratio

* measure shift time

* add shift time gauge, todo notes for pc

* do conversion in the right direction

* switch to Timer and seconds

* try fixing build

* try fixing build again

* try defines, remove include

* use shift pcs

* add 3-2 pct curve

* control 3-2 solenoid

* move 3-2 to persistent config

* fix param
2022-04-23 07:34:39 -04:00
rusefillc 57f04b6aed https://github.com/rusefi/alphax-2chan/issues/50 2022-04-19 20:43:41 -04:00
GitHub build-firmware Action a54a535443 Auto-generated configs and docs 2022-04-18 21:53:02 +00:00
rusefillc 001b5cb07e life is better without special characters 2022-04-18 17:36:28 -04:00
rusefillc b252533889 actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc a6108bafbf unique field names 2022-04-18 11:11:57 -04:00
Matthew Kennedy 8650686ab7 knock threshold table fix (#4077)
* fix knock threshold table

* defaults

* knock controller is engine module

* testable

* test builds

* knock tests work

* s

* format

* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc e4d9664c09 minor fix 2022-04-17 22:48:57 -04:00
GitHub build-firmware Action 783aa1451c Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 16a6112002 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 0ba512c925 logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
GitHub build-firmware Action 4f35c31c44 Auto-generated configs and docs 2022-04-16 23:33:47 +00:00
rusefillc fc128e1954 logging of live data structs was: data points #3614 2022-04-16 19:18:03 -04:00
rusefillc cb4979e068 very random progress 2022-04-16 17:07:57 -04:00
GitHub build-firmware Action 959840bc03 Auto-generated configs and docs 2022-04-15 14:34:37 +00:00
Matthew Kennedy 735b4899e2 allow setting injection phase by start or center of injection (#4068)
* allow SOI/COI

* other change

* renames and simplify

* clean up ownIndex

* double check in spark logic
2022-04-15 10:22:36 -04:00
rusefillc 57be5a2147 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 5c5d258b5f typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc 089d7f5cd1 steps towards ignition live data 2022-04-13 16:48:25 -04:00
rusefillc c2e53eaac2 Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:51:11 -04:00
rusefillc 02599a439d Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:43:05 -04:00
rusefillc 095fdbf5a4 Set sensible default for dwell by voltage multiplier table #4067 2022-04-13 15:34:44 -04:00
rusefillc 53f323ca0c Set sensible default for dwell by voltage multiplier table fix #4067 2022-04-13 15:21:44 -04:00
rusefillc 7213011353 Hellen NB2 default tune #4038 2022-04-10 19:11:34 -04:00
Matthew Kennedy d52c3f93d8 check voltage instead of temperature (#4062) 2022-04-10 17:41:41 -04:00
rusefillc d7d6cbab02 MRE QC build broken #4059 2022-04-10 15:48:35 -04:00
rusefi 5d8819d564 MRE QC build broken fix #4059
nasty work-around
2022-04-09 19:13:55 -04:00
Matthew Kennedy 7aedc7d029 gear detection validation (#4053)
* gear detection validation

* test validation because why not
2022-04-09 08:59:07 -04:00
rusefillc 905fbd851e Air Conditioning Improvements #4054 2022-04-09 00:26:52 -04:00
Matthew Kennedy 88ff526764 Gear detection implementation (#4052)
* gear detect improvements

* ui

* ui for gear ratios

* ui

* output channel

* output channels etc

* implement gear detection

* name

* s

* status loop

* missing function

* ui tweaking

* s
2022-04-07 09:21:11 -04:00
GitHub build-firmware Action bf61d2e784 Auto-generated configs and docs 2022-04-06 21:44:03 +00:00
David Holdeman 410a9ffbef Add interface for selecting GearController and TransmissionController classes (#4048)
* save changes

* save changes

* save changes

* fix mistakes

* try adding empty method

* copy simpleTransmissionController to GM 4L6X controller

* Import 4l6x header

* add to makefile

* fix whitespace

* try enum class

* change field name

* change field name in rusefi.input

* check for gear controller mode

* add mode fields to catch if mode was changed
2022-04-06 17:37:30 -04:00
Matthew Kennedy 405f7f3b43 Gear detection improvements (#4047)
* gear detect improvements

* ui

* ui for gear ratios

* ui
2022-04-06 16:15:58 -04:00
GitHub build-firmware Action ce4206ca1b Auto-generated configs and docs 2022-04-04 21:49:00 +00:00
Matthew Kennedy 72dabf4057 Flex fuel cranking improvements (#4043)
* improve flex cranking

* call it e85

* don't re-warn

* warning name

* ui
2022-04-04 17:41:36 -04:00
Andrey 3e6d0f64be MAP value thresholds #4030 2022-04-03 18:48:34 -04:00
rusefillc bc08418280 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
rusefillc 98dc6c465a Proper cam speed labels in triggers #4021
i cannot explain this since line so let's remove it
2022-04-03 12:15:19 -04:00
Matthew Kennedy fc4e6cbdb3 fix 4032 (#4034)
* fix 4032

* board defaults should not set these things
2022-04-03 06:58:25 -04:00
Andrey 20dbc1ff82 Trigger setup in TS is highly confusing: hide operation mode from users? #4031
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey 298ea5f8c0 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 02:21:37 -04:00
Andrey 49fab25b14 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
Andrey 08fff0816b Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:43:28 -04:00
Andrey b96c51874c Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:34:18 -04:00
Andrey 08523c50cf Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-02 23:50:39 -04:00
rusefillc 9ae96ea7e5 refactoring: method rename 2022-04-02 21:01:29 -04:00
GitHub build-firmware Action 4bd71ef6c9 Auto-generated configs and docs 2022-03-22 10:41:38 +00:00
Andrey 63adb09089 new VVT trigger shape? #1847 2022-03-22 06:34:22 -04:00
Matthew Kennedy f0013f71b5 limp mangaer handles more stuff (#3983) 2022-03-20 09:28:17 -04:00
GitHub build-firmware Action e30ee1e2bd Auto-generated configs and docs 2022-03-20 02:18:41 +00:00
Andrey 8b5fdfa852 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:11:51 -04:00
Andrey ef3248c245 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:06:19 -04:00
GitHub build-firmware Action 31559a8c6a Auto-generated configs and docs 2022-03-19 21:01:59 +00:00
rusefillc faf84286f5 Mitsubishi 6G75 Support #4014 2022-03-19 16:28:06 -04:00
GitHub build-firmware Action cc581cdcf2 Auto-generated configs and docs 2022-03-19 20:10:50 +00:00
rusefillc 7548fe13f2 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 15:54:43 -04:00
rusefillc c7cc88ccd0 Mitsubishi 4B11 support #4013 2022-03-19 15:52:42 -04:00
rusefillc f1f5507580 TPS AE engages during crank fix #3996 (#3997)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-03-19 13:05:44 -04:00
GitHub build-firmware Action b03a9bc2a7 Auto-generated configs and docs 2022-03-19 16:32:09 +00:00
rusefillc d6b1c9faf2 Mitsubishi 3A92 Support (Issue #4011) 2022-03-19 12:01:57 -04:00
rusefillc 0b1c1f73a0 JNI for test coverage #3965 and code style 2022-03-15 10:32:32 -04:00
Matthew Kennedy 0c6a369777 flash storage uses 32 bit CRC (#3984)
* better flash logic and warning message

* comment

* s

* ssssss

* simplify logic

* use 32 bit crc

* s

* don't test things that don't exist
2022-03-08 23:17:35 -05:00
Andrey G b160134b31 cli registry: rework this hell, add FFF and FFFFF (#3964)
* cli registry: rework this hell, add FFF and FFFFF

* kinetis: no nodefaultlib

* revert back token helpers

* cli_registery: argument parser: do not eat qoutes

* Unit test for FFF

* cli_registry: remove debug
2022-02-26 16:58:10 -05:00
Matthew Kennedy a48809b6be core 8 overrides and stepper-as-brain-pin (#3962)
* core 8 overrides and stepper-as-brain-pin

* oops, change the pin not the mode

* a little bit of #3963 makes everyone happy
2022-02-26 09:14:37 -05:00
rusefillc f37943e56c Feature request: odometer for engine break #3857 2022-02-25 00:46:45 -05:00
Matthew Kennedy e1e40dc367 fix gap override logic (#3946) 2022-02-18 17:13:45 -08:00
rusefillc a9d9586e56 better default 2022-02-10 00:53:44 -05:00
rusefillc 905b7f587c better default DEFAULT_ENGINE_TYPE 2022-02-09 19:49:41 -05:00
rusefillc 165d32f209 N73 2022-02-09 17:29:09 -05:00
Matthew Kennedy 47b4ace4cb less dependence on that logger (#3884)
* less dependence on that logger

* comma

* refactor a bit, make it clear what this thing actually *does*

* static

* shrink the buffer a bit and make names useful

* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
GitHub build-firmware Action 476ce1c29c Auto-generated configs and docs 2022-02-08 21:21:12 +00:00
Andrey G a52f6434f9 IMU: add imu type for Mercedes pn A 006 542 26 18 (#3901) 2022-02-08 16:00:16 -05:00
rusefillc 5d687e272c Feature request: odometer for engine break #3857 2022-02-06 22:03:47 -05:00
rusefi 0832b694d2 EFI_LAUNCH_CONTROL clean-up 2022-02-06 18:46:09 -05:00
rusefi 4e0f897c2a helping build 2022-02-06 18:13:35 -05:00
GitHub build-firmware Action 0e95d2fef3 Auto-generated configs and docs 2022-02-06 19:04:42 +00:00
rusefi b66687c971 I2C EEPROM support #3860 2022-02-06 13:59:08 -05:00
rusefi 7364524f25 L9779WD driver L9779 #3768 2022-02-06 13:56:50 -05:00
GitHub build-firmware Action 24caf18d46 Auto-generated configs and docs 2022-02-06 17:57:16 +00:00
rusefillc 0afe3e92b1 I2C EEPROM support #3860 2022-02-06 12:39:41 -05:00
Matthew Kennedy 31c0afc79f remove mock adc (#3888)
* remove mock adc

* do these do /anything/?
2022-02-03 20:43:34 -05:00
Matthew Kennedy e95d8469c0 dead StartupFuelPumping (#3883)
* dead

* test

* dead config too
2022-02-03 08:01:21 -05:00
GitHub build-firmware Action 2488645654 Auto-generated configs and docs 2022-02-02 07:19:22 +00:00
Matthew Kennedy 57525283ac Remove FSIO, byeeeeeeeee (#3865)
* vestigial config

* replace last functionality

* engine/board configs include

* files that didn't need to include this

* remove FSIO implementation

* stragglers

* random little bits

* s

* s

* ConfigDefinition

* jar

* s
2022-02-02 02:03:31 -05:00
Matthew Kennedy f82f4d08d6 Remove fsio part 2 (#3876)
* dead config stuff

* fsio state

* remove tests

* getEngineValue

* put part back
2022-02-02 00:49:44 -05:00
rusefillc 0e1d1ffb3f packing unused 2022-02-01 22:19:24 -05:00
rusefillc 58ffb5382f packing unused 2022-02-01 22:07:42 -05:00
rusefillc 53b96f99a8 packing unused 2022-02-01 22:05:13 -05:00
rusefillc b91c8eff84 packing unused 2022-02-01 22:02:35 -05:00
rusefillc a84b291790 packing unused 2022-02-01 21:50:44 -05:00
Matthew Kennedy 73a0816f8c remove me7pnp (#3878)
* remove

* s

* HW_MICRO_RUSEFI
2022-02-01 21:46:06 -05:00
Matthew Kennedy c9e1b9a79a flex cranking math (#3791)
* flex cranking math

* simplify

* s

* simplify
2022-02-01 20:53:14 -05:00
rusefillc 3be2fcaa80 Limp shutdown rebase (#3879)
* limp manager handles engine stop

* use timer

* dead relevant fsio

* this stuff needs its own ticket

* if we can comment out 'business logic' and tests do not fail it's not a great sign :(

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-01 20:47:17 -05:00
GitHub build-firmware Action ed43b7266a Auto-generated configs and docs 2022-02-01 22:42:35 +00:00
Andrey G f9812fb295 enum: add pins for L9779WD-SPI and L9779WD (#3872) 2022-02-01 16:41:45 -05:00
rusefillc 3e55c0c57b Technical debt: ENUM_32_BITS #3874 2022-02-01 16:41:23 -05:00
Matthew Kennedy 28b6cce9d9 Remove fsio part 1 (#3871)
* dead includes

* move last logic out of fsio

* dead functions
2022-02-01 15:42:04 -05:00
rusefillc 5c16186919 safer file name (#3861)
* safer file name

* safer file name

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-01-31 21:51:32 -05:00
Matthew Kennedy fe6cdf60e3 warnings fixes (#3851)
* unused things

* !!! actual bug !!!

* dead

* unused

* unused

* multi-bus lua RX was just broken

* make the compiler angry about it

* dead config

* alphax 2

* just call, no store

* compiler too angry
2022-01-31 18:37:42 -05:00
GitHub build-firmware Action 484f997d8f Auto-generated configs and docs 2022-01-31 23:26:47 +00:00
rusefillc 9d8c316aff Remove Miata MX5 NB1 trigger fix #3488 2022-01-31 18:20:43 -05:00
GitHub build-firmware Action b00564cb97 Auto-generated configs and docs 2022-01-30 14:01:11 +00:00
Matthew Kennedy eab4c50f77 table for tcharge interpolation (#3855)
* extract getTChargeCoefficient

* new table
2022-01-30 08:45:11 -05:00
Matthew Kennedy 6a46c60d75 disable fuel trim shortly after DFCO (#3847)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* disable closed loop fuel after dfco1

* I can't type

* correct comparison helps

* poke
2022-01-28 21:35:23 -05:00
rusefillc 4ba8c966d8 this stuff is dead 2022-01-28 19:52:12 -05:00
Matthew Kennedy 15d30ad22c complex wall wetting model (#3849)
* extract logic

* extract interface

* explicitly test wall fuel

* complex wall model tables

* fix unused chunk

* defaults

* doesn't like constexpr scaled_channel
2022-01-28 00:32:36 -05:00
GitHub build-firmware Action df4c873a86 Auto-generated configs and docs 2022-01-27 23:44:58 +00:00
rusefillc 5ddb981c3e reducing magic constants & pedal calibration 2022-01-27 18:28:42 -05:00
GitHub build-firmware Action 89b36469fb Auto-generated configs and docs 2022-01-27 22:59:57 +00:00
rusefillc 3950c3b6a2 reducing magic constants 2022-01-27 17:39:46 -05:00
Matthew Kennedy 60b9ddeb1e vss based dfco (#3845)
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* even better than comments are tooltips
2022-01-27 14:05:18 -05:00
Matthew Kennedy 4e210c3124 more tps accel data (#3844) 2022-01-27 07:46:13 -05:00
Matthew Kennedy 50c31b78ae extract logic from wall wetting AE (#3848)
* extract logic

* extract interface

* explicitly test wall fuel
2022-01-27 07:45:50 -05:00
GitHub build-firmware Action d5ffecc2cd Auto-generated configs and docs 2022-01-25 02:04:47 +00:00
rusefillc 383d6f87ab https://www.rusefi.com/forum/viewtopic.php?p=44166#p44166
launch control live data
2022-01-24 20:58:21 -05:00
Matthew Kennedy 1a0682aa0e dfco checks driver throttle intent (#3832) 2022-01-24 14:26:39 -05:00
GitHub build-firmware Action 6d8a104525 Auto-generated configs and docs 2022-01-24 02:55:57 +00:00
Matthew Kennedy 5978df2855 refactor decel fuel cut (#3830)
* refactor dfco

* s

* output channel logs dfco

* slightly cheeky comment
2022-01-23 19:44:41 -05:00
rusefillc 573a5262c4 https://www.rusefi.com/forum/viewtopic.php?p=44166#p44166 2022-01-23 19:44:14 -05:00
Matthew Kennedy b07127614b decouple TPS accel enrichment from trigger (#3825)
* move call site

* move thresholding out of fast path

* adjust config

* test
2022-01-23 15:31:39 -05:00
rusefi a8d96a78b2 but we need valid default 2022-01-21 15:22:11 -05:00
Andrey 014ea2b78a migrating to SensorType::Rpm API 2022-01-20 23:54:52 -05:00
Andrey 970f81c5b3 migrating to SensorType::Rpm API 2022-01-20 23:43:18 -05:00
Andrey 5f3324cd6b migrating to SensorType::Rpm API 2022-01-20 23:32:59 -05:00
Andrey 92cbba3256 migrating to SensorType::Rpm API 2022-01-20 22:42:13 -05:00
Andrey a8e016f162 migrating to SensorType::Rpm API 2022-01-20 22:27:48 -05:00
Andrey a168a94628 migrating to SensorType::Rpm API 2022-01-20 22:26:05 -05:00
Andrey 5d6985f085 migrating to SensorType::Rpm API 2022-01-20 22:12:04 -05:00
Matthew Kennedy 6fc4503ee2 XY Idle VE Table (#3781)
* config & ui

* implement

* test idle VE switching behavior

* use the interface where we can

* s

* re-bump flash version
2022-01-20 14:08:54 -05:00
rusefillc 2da6593305 Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
rusefillc 8fb50ddcd1 AlphaX 2022-01-17 20:22:51 -05:00
rusefillc 286703f659 https://github.com/rusefi/alphax-2chan/issues/16 2022-01-15 10:36:49 -05:00
rusefillc 597a3430d9 https://en.wikipedia.org/wiki/Pi 2022-01-14 21:23:27 -05:00
Matthew Kennedy e240905df6 Revert "forced 4 byte thing is actually no longer needed so much" (#3785)
* Revert "forced 4 byte thing is actually no longer needed so much"

This reverts commit 6b280043c7.

* bump flash version to force a re-write
2022-01-12 21:59:21 -05:00
Matthew Kennedy 78119b7df4 improve maf output channels and logging (#3743)
* maf channels

* s

* binary log

* if only I could type

* can

* instant RPM too

* s

* test

* graceful zero rpm

* test works

* float near
2022-01-12 15:41:35 -05:00
rusefillc f34d968a20 GDI red FATAL led on cranking fix #3766 2022-01-12 01:01:33 -05:00
rusefillc bb77e30f0c logging of live data structs #3614 2022-01-11 22:54:57 -05:00
rusefillc fc996ad339 Code style for methods with zero arguments #3535 2022-01-11 22:26:24 -05:00
rusefillc 6fd0ae24d9 RE usability: live data for idle controller 2022-01-10 19:48:58 -05:00
rusefillc 4537561214 AlphaX few bytes of progress 2022-01-10 01:47:06 -05:00
Andreika e7fb21c346 Hellen mcu module detector (experimental) (#3756)
* Hellen mcu module detector (experimental)

* make unit-tests happy

* make unit-tests even more happy

* move Hellen-specific stuff to hellen_common.cpp

* fix other hellen config builds

* helping non-Hellen builds too

* helping alpha2ch build

* helping build

* cleanup

* help unit-tests

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2022-01-09 17:40:08 -05:00
rusefillc 8a88b42f43 extracting common hellen to it's own file 2022-01-08 20:16:01 -05:00
rusefillc 47f0423b73 mk files refactoring 2022-01-06 20:32:39 -05:00
rusefillc ca6b7bba23 Live Data progress 2022-01-06 17:58:59 -05:00
GitHub build-firmware Action e4f828c0a1 Auto-generated configs and docs 2022-01-05 06:49:51 +00:00
rusefillc 6b280043c7 forced 4 byte thing is actually no longer needed so much 2022-01-05 00:24:17 -05:00
GitHub build-firmware Action fd23938b2a Auto-generated configs and docs 2022-01-05 05:09:04 +00:00
GitHub build-firmware Action 95639ccb77 Auto-generated configs and docs 2022-01-04 03:39:23 +00:00
rusefillc 7acd36c198 helping build: sharing same brain_pin_diag_e 2022-01-03 22:33:38 -05:00
rusefillc f52c6ba41e TLE8888 diag says OK on disconnected pins and bench test #3737 2022-01-03 20:33:51 -05:00
rusefillc 226ab063f9 benchTest flexibility 2022-01-03 03:35:26 -05:00
rusefillc c2b5c7ce52 GDI/HPFP: Set HPFP current/timing params on MC33816 #3736 follow-up 2022-01-03 02:13:47 -05:00
rusefillc d0c5188a39 live data progress 2022-01-02 13:57:58 -05:00
rusefillc 7271331d2e why so many channels are hidden in debug ? #3614 2022-01-02 02:04:25 -05:00
Matthew Kennedy c2cc5c8cc7 cylinder ignition trim (#3709)
* cylinder ignition trim

* changelog

* changelog

* test

* move UI
2022-01-01 15:47:47 -05:00
rusefillc 1707805dbf reducing potential confusion with "NO PIN" in engine sniffer
https://rusefi.com/forum/viewtopic.php?p=43812#p43812
2022-01-01 12:10:55 -05:00
Matthew Kennedy 265f005239 hook up fuel trims (#3715)
* hook up fuel trims

* pass all the params

* store per-cylinder fuel mass directly

* main trigger callback only touches per-cylinder, no banks!

* test test test test

* move UI to happy land

* changelog
2022-01-01 02:19:59 -05:00
Matthew Kennedy c058698859 Nb2 crank sync special case (#3727)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
rusefillc 213c22fde3 GDI Epic #1448
live view
2021-12-31 15:28:24 -05:00
GitHub build-firmware Action d1b7db5015 Auto-generated configs and docs 2021-12-30 02:53:30 +00:00
rusefillc 196d21deae HellenNA8_96 config folder #3724 2021-12-29 21:23:47 -05:00
rusefillc 99e4ec3471 reviving Passat 2021-12-29 20:24:04 -05:00
GitHub build-firmware Action 3ce0b4002c Auto-generated configs and docs 2021-12-27 17:15:43 +00:00
Matthew Kennedy b392a7120e improved noFiringUntilVvtSync logic (#3696)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc 2219e55a22 refactoring - enum has more usages now 2021-12-26 14:53:27 -05:00
rusefillc 917c13ef50 docs 2021-12-26 13:41:10 -05:00
rusefillc 98423f2046 live data 2021-12-26 13:00:17 -05:00
rusefillc 4deb96fca6 live data 2021-12-26 13:00:17 -05:00
rusefillc c647dde007 docs & refactoring 2021-12-26 12:35:41 -05:00
rusefillc 8070da116b E65 2021-12-23 16:59:30 -05:00
GitHub build-firmware Action 251cfa8393 Auto-generated configs and docs 2021-12-23 21:46:59 +00:00
rusefillc 219cc92047 E65 2021-12-23 16:41:06 -05:00
Matthew Kennedy 5642ef07be Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
Matthew Kennedy 2ba4c7844d simplify some table lookups (#3692)
* simplify

* expand interpolation test
2021-12-20 08:14:30 -05:00
Matthew Kennedy fae8b9ec06 clean up timing table defaults (#3705)
* less crazy configs

* cleanup

* make that test happy
2021-12-20 08:02:38 -05:00
rusefillc 7eca4d663b 2 byte table axis #3045 2021-12-19 22:43:10 -05:00
rusefillc c48c65cad1 https://github.com/rusefi/hellen154hyundai/issues/49 2021-12-17 16:39:12 -05:00
rusefillc b0c1a8fb2e MAP phase sensing fix #3544
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc 02e31e1555 MAP phase sensing #3544
removing dead implementation
2021-12-16 21:13:55 -05:00
rusefillc 3e154d8549 dead code? 2021-12-16 21:06:23 -05:00
GitHub build-firmware Action 2ebaee92f8 Auto-generated configs and docs 2021-12-16 21:24:43 +00:00
rusefillc 5f3de0d69c live data for wastegate and launch control #3588 2021-12-16 16:19:33 -05:00
rusefillc 7684b66972 live data for wastegate and launch control #3588 2021-12-16 15:17:35 -05:00
rusefillc d84030ac0d live data for wastegate and launch control #3588 2021-12-16 14:47:00 -05:00
rusefillc 5afd6f070d live data for wastegate and launch control #3588 2021-12-16 14:29:39 -05:00
rusefillc f30d0950fd live data for wastegate and launch control #3588 2021-12-16 14:28:01 -05:00
rusefillc 15196828a4 clutch input via CAN #3605 2021-12-15 19:20:07 -05:00
rusefillc 1a3f8d8b32 clutch input via CAN #3605 2021-12-15 17:48:21 -05:00
Matthew Kennedy bdf6583306 smarter priming logic (#3674)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
2021-12-08 16:20:19 -05:00
Matthew Kennedy e80654511d prime upon ignition voltage, not on power on (#3662)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* test

* dead adjacent line of code
2021-12-08 07:26:49 -05:00
GitHub build-firmware Action d0a8d9c17a Auto-generated configs and docs 2021-12-08 12:10:47 +00:00
Matthew Kennedy ba8ac5f595 AiM dash (#3673)
* aim dash

* enum
2021-12-08 07:04:59 -05:00
Matthew Kennedy 3d3bf5ea4b ignition controller detects rising edge on voltage (#3636)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test
2021-12-07 21:28:04 -05:00
Andrey d3afd617d2 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey d2c46b3310 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
Andrey c28a24c3d2 MAP phase sensing #3544
new implementation
2021-12-07 20:00:50 -05:00
Matthew Kennedy 3efb9443c3 consolidate tps accel (#3671) 2021-12-07 18:49:21 -05:00
rusefillc 359420e93d Pause CAN broadcast on engine stop #3665 2021-12-07 10:35:52 -05:00
rusefillc c38ae9f148 MAP phase sensing #3544 2021-12-07 08:57:23 -05:00
rusefillc ebc24cd71b https://rusefi.com/forum/viewtopic.php?f=18&t=2236 2021-12-06 21:31:49 -05:00
Matthew Kennedy aa8584d89a calculate per-cylinder ignition timing (#3652)
* simplify cylinder phasing

* per cylinder timing

* s

* s

* s

* why was there a divide by 2?
2021-12-06 21:19:37 -05:00
rusefillc ddbe875d98 MAP phase sensing #3544
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
rusefillc 7c5940fcc2 tune via CAN #3361
pauseCANdueToSerial
2021-12-05 21:21:36 -05:00
Matthew Kennedy ba6eec22c8 Alternator controller is engine module (#3663)
* alternator is engine module

* user can't set pid period
2021-12-05 18:33:50 -05:00
Matthew Kennedy b2af3637a2 simplify cylinder phasing (#3650) 2021-12-05 10:46:35 -05:00
Andrei 22785078ef better ignition_voltage_detected message 2021-12-04 01:41:25 -05:00
rusefillc 37ed110750 how many more spelling mistakes?! 2021-12-02 01:06:40 -05:00
rusefillc 01153934f9 Requesting LUA Torque intervention #3638 2021-12-02 01:02:56 -05:00
GitHub build-firmware Action a9de68a552 Auto-generated configs and docs 2021-12-02 05:04:17 +00:00
rusefillc f6c5ac8ebb fix vBatt false-detection 2021-12-01 11:22:13 -05:00
Matthew Kennedy 565a94ea34 Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
rusefillc 3cf4be3aa9 why so many channels are hidden in debug ? #3614 2021-11-29 14:11:19 -05:00
rusefillc 9cfd30a2b4 why so many channels are hidden in debug ? #3614 2021-11-29 11:54:55 -05:00
rusefillc 194cd8ea11 why so many channels are hidden in debug ? #3614 2021-11-29 10:44:41 -05:00
rusefillc ffb35aeff7 why so many channels are hidden in debug ? #3614 2021-11-29 10:16:45 -05:00
rusefillc c64fb3f595 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
Matthew Kennedy aed334f9ac better VSS configuration (#3542)
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
rusefillc d791ef5581 skipspark script kills ECU fix #3611 2021-11-25 22:40:19 -05:00
GitHub build-firmware Action ca5ba2f8e8 Auto-generated configs and docs 2021-11-26 02:06:11 +00:00
Andrey e3920a3159 reliable 32/2 trigger shape 2021-11-25 20:45:58 -05:00
Matthew Kennedy dad52dd75a wall fuel tweaks (#3617) 2021-11-25 18:45:44 -05:00
Matthew Kennedy 6e4759389a AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
Andrey 374b7223cd isCylinderCleanupEnabled would be nice by default 2021-11-24 23:32:55 -05:00
Andrey 695557f709 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey a42a52bb2e MAP phase sensing #3544 2021-11-24 22:35:56 -05:00
Matthew Kennedy 5752b4ba92 bye (#3609) 2021-11-24 22:03:17 -05:00
rusefillc 28c9d7555b live data for wastegate #3588 2021-11-24 12:59:57 -05:00
Matthew Kennedy 5274cffff3 main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
rusefillc 09ed871dad well Lua wants to be BIG 2021-11-23 16:40:04 -05:00
GitHub build-firmware Action 191b76f4dd Auto-generated configs and docs 2021-11-22 23:12:52 +00:00
Matthew Kennedy 9bd8a19564 oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc 5d55b8538f unusedLogFormat 2021-11-22 13:37:06 -05:00
Matthew Kennedy e2a4504728 rpm calculator refactoring, gm 24x test (#3585)
* data

* stub test

* use getTimeSinceSyncPoint

* s

* s

* no

* test

* stray ;

* those were 1/10 what they were supposed to be

* actually check something

* dead log line?
2021-11-20 14:59:02 +03:00
Scott Smith 04fa1fd410 Fix potential buffer overrun in cyclic_buffer. (#3583)
This exposed a buffer overrun, so double the size of the buffer (to account for 720 degree engine
cycle vs 360 degree crank events).

Also use proper numeric limits when computing min/max.
Finally, add a lock around the call to cyclic_buffer that actually caused the contention.
2021-11-20 03:01:11 -05:00
Matthew Kennedy 569415930c detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
Scott Smith 07d30285fc Basic framework for high pressure fuel pump control (#3476)
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00
Matthew Kennedy e7956a53f6 fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
rusefillc c441d7dd89 debug mode for skipped count for 4 cylinders #3570 2021-11-19 07:02:21 -05:00
Matthew Kennedy a0a1b5e6a0 delimeter is not comma (#3533)
* delimeter is not comma

* do it in config txt

* use txt

* s

* string

* compat

* also, spelling is hard

* use new name

* use new name

* generate enough for happy console

* use an even less common character

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-19 12:01:45 +03:00
Scott Smith aba4e5167e Separate out scheduleOrQueue into it's own standalone scheduler. (#3573)
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
rusefillc 82ffcad01f proportional spark cut #3427 2021-11-17 23:35:26 -05:00
Scott Smith b3e0b28c75 Make the module API more concise. (#3571)
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith 659cc68be1 Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith f9f13f0bad Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 19f7fa8f89 Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc 774d96493e spelling 2021-11-16 16:46:54 -05:00
rusefillc 6fdb98e84f helping launch enter simulator 2021-11-16 16:45:14 -05:00
rusefillc ed1d24dbbe helping launch enter simulator 2021-11-16 16:31:35 -05:00
Andrey 1be12392c0 proportional spark cut #3427 2021-11-16 13:23:08 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith 2cfc4af998 Start the process of using a global engine ptr for unit tests. (#3551)
* Start the process of using a global engine ptr for unit tests.

Passing around the engine, config, and persistent state wasn't buying anything.  Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables.  Add a dummy check in
case some test tries to set them manually.

* Fix OSX build

* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Andrey b545743f7d Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 349d224b5f technical debt: enableOverdwellProtection #3553
only documentation
2021-11-15 20:32:25 -05:00
Andrey 7b790d36f6 random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Andrey 4bc9343d0b refactoring launch 2021-11-15 20:09:03 -05:00
Andrey 837cdf2cfb refactoring launch 2021-11-15 19:55:04 -05:00
Andrey 0a956d96b4 refactoring launch 2021-11-15 19:55:04 -05:00
Andrey c8b733ea6e refactoring launch 2021-11-15 19:34:42 -05:00
Andrey c41dccb5ff refactoring launch 2021-11-15 19:24:00 -05:00
Andrey bc3befd0ac refactoring launch 2021-11-15 18:57:12 -05:00
Andrey bafd5e0e17 refactoring launch 2021-11-15 14:40:35 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
GitHub build-firmware Action a29aa50cb0 Auto-generated configs and docs 2021-11-15 03:03:29 +00:00
rusefillc 8448b04078 MAP phase sensing #3544 2021-11-14 21:58:01 -05:00
rusefi 291f815b2d Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
rusefi df4f122c0b Epic: Remove FSIO #2928 2021-11-14 14:14:43 -05:00
rusefillc 1a3fb4a0db Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 3327b0d4e7 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
rusefillc 5f1aadf638 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
rusefillc 0fc4096213 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
rusefillc eab7f670a2 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc 29670184e2 script settings need names! 2021-11-13 22:47:46 -05:00
GitHub build-firmware Action 2762268d58 Auto-generated configs and docs 2021-11-14 03:02:10 +00:00
Matthew Kennedy 8edc91f657 mercedes two lobe trigger testing (#3543)
* mercedes

* config

* break;

* I did the gap ratio math wrong

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
rusefillc 4803a6def5 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
GitHub build-firmware Action 015a07576d Auto-generated configs and docs 2021-11-13 03:01:55 +00:00
rusefillc d96755ec15 Proteus Harley 2021-11-12 21:56:07 -05:00
GitHub build-firmware Action cf7231a8a0 Auto-generated configs and docs 2021-11-12 01:54:56 +00:00
Andrey 37adc7e713 Bench Test IAC Valve fails #3534
that's not even funny
2021-11-11 20:39:01 -05:00
Andrey 06f7098cae Bench Test IAC Valve fails #3534 2021-11-11 20:31:46 -05:00
Andrey 5136d0b994 Bench Test IAC Valve fails #3534 2021-11-11 20:28:01 -05:00
Andrey 1aca049c47 Something something Automatic Compression Release #3442 2021-11-11 20:16:46 -05:00
Andrey 9aa98cd523 refactoring: less hacky implementation 2021-11-11 20:16:46 -05:00
rusefillc 371f0ca72c Idle valve outputs not available in TS #3523 2021-11-10 20:40:42 -05:00
rusefi 69a53c565f pid demo progress 2021-11-08 17:31:33 -05:00
Andrey 757cd10c1f docs 2021-11-08 12:23:00 -05:00
rusefillc fd28e82f73 refactoring - magic constant bad 2021-11-07 00:03:16 -04:00
GitHub build-firmware Action 2ee8ecb287 Auto-generated configs and docs 2021-11-07 03:59:47 +00:00
rusefillc eb4ef563dd a bit of dead code 2021-11-06 23:39:56 -04:00
rusefillc 3f278e989b a bit of dead code 2021-11-06 21:19:56 -04:00
GitHub build-firmware Action 4dca92f21e Auto-generated configs and docs 2021-11-07 01:05:29 +00:00
rusefillc 31347d66be a bit of dead code 2021-11-06 21:01:01 -04:00
Andrey e3355ab2d3 Remove Miata MX5 NB1 trigger #3488 2021-11-06 20:24:41 -04:00
GitHub build-firmware Action cab19aeba0 Auto-generated configs and docs 2021-11-06 23:15:42 +00:00
rusefillc faa8abf673 a bit of dead code 2021-11-06 18:43:19 -04:00
GitHub build-firmware Action beb2083509 Auto-generated configs and docs 2021-11-06 22:37:34 +00:00
rusefillc 4045893437 PROTEUS_LUA_DEMO 2021-11-06 18:24:59 -04:00
GitHub build-firmware Action b117f260c1 Auto-generated configs and docs 2021-11-06 03:28:22 +00:00
Scott Smith e350b0b6b4 Configuration for HPFP control algorithm. (#3475) 2021-11-05 23:15:35 -04:00
Scott Smith e8633a8cb4 Move fuel density to a header file so it can be accessed by other components. (#3474) 2021-11-05 22:29:56 -04:00
Scott Smith 61fd669add Convert existing tables to use the simpler 3d table definition style in rusefi_config.txt (#3473)
This fixes #3465.
2021-11-05 21:55:33 -04:00
Scott Smith fcac26c032 Allow scaled_channel to have both multiplier and divisor (#3468)
Disallow scaled_channel for float.  I can't think of a reason to allow it, and it gets in the way
of rounding.

Add separate template param to setTable; let the compiler sort out whether assignment can happen
between TElement and VElement without forcing them to be the same at function call time.
2021-11-05 17:34:22 -04:00
GitHub build-firmware Action f3e6b44f89 Auto-generated configs and docs 2021-11-05 19:42:05 +00:00
Matthew Kennedy b41dbe2ed1 nissan MR18DE VVT cam pattern (#3466)
* refactoring nissan trigger

* comments

* plumbing

* b

* enums

* image

* image

* implement decoder

* reshuffle

* don't case unused

* dead trigger enums
2021-11-05 15:33:22 -04:00
rusefillc 2bd0633ecb minor todo 2021-11-05 10:01:58 -04:00
GitHub build-firmware Action 6f2744a5c9 Auto-generated configs and docs 2021-11-05 11:19:56 +00:00
Matthew Kennedy 6b85313b04 nissan 4yl crank pattern (#3462)
* refactoring nissan trigger

* comments

* plumbing

* b
2021-11-05 07:15:03 -04:00
rusefillc 31a2218339 more curves! also names for curves 2021-11-04 23:59:04 -04:00
rusefillc b9861159a1 more curves! also names for curves 2021-11-04 23:19:44 -04:00
rusefi 365a1e13a8 turboSpeedSensorMultiplier 2021-11-04 19:35:58 -04:00
racer-coder 55ac8d56b8 Fix the types in various fuel functions that actually refer to grams, not ms. (#3458) 2021-11-04 11:50:19 -04:00
rusefillc 88d7046382 most dead miata config 2021-11-04 09:56:05 -04:00
Matthew Kennedy cadaf2a801 extract engine phase function (#3456)
* extract getCurrentEnginePhase

* inject engine ref

* never invalid RPM, use 0 instead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
Matthew Kennedy a2766e5d9b support autoscale on table axes (#3452)
* scale map Y axis

* allow different row/col types

* scaled channel detector

* interpolation

* looks like this actually works

* tests, no manual scaling

* comment
2021-11-03 19:53:26 -04:00
Matthew Kennedy 4717210859 autoscale fields in generated structs (#3444)
* add to grammar

* parser

* parser

* example consumer

* build config tool

* commit the right jar
2021-11-02 18:59:19 -04:00
rusefi 356a73e7a5 docs 2021-11-02 17:11:44 -04:00
Matthew Kennedy 1cee83a56c Knock retard (#3396)
* output gauge

* knock controller

* don't need that

* inject engine ref

* test knock

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
rusefillc de0736492d better VVT default? 2021-10-31 15:25:43 -04:00
rusefillc 178f6fe9e8 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
fail faster!
2021-10-31 12:09:11 -04:00
rusefillc 960b68424b live data stuff goes up 2021-10-31 12:07:44 -04:00
GitHub build-firmware Action b632832407 Auto-generated configs and docs 2021-10-31 02:31:01 +00:00
Andrey fd34b2adee Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:24:43 -04:00
Andrey ef413188ee Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:21:36 -04:00
GitHub build-firmware Action 1a13dd7463 Auto-generated configs and docs 2021-10-31 02:08:31 +00:00
Andrey ac64f215f3 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:03:19 -04:00
Andrey f01c6fa6ae Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:52 -04:00
Andrey 12dfc7e869 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 21:45:37 -04:00
rusefillc a2f1cd2467 Override trigger gaps feature #2734 2021-10-30 10:45:32 -04:00
Andrey 14aac56c41 warning(CUSTOM_PID_DTERM, "PID: unexpected dTime") 2021-10-29 18:31:43 -04:00
rusefillc 558c639f82 Honda K & default VVT pid 2021-10-29 12:16:19 -04:00
rusefi 2d99e7b4b5 Honda K cam wheels #3405 2021-10-28 15:57:23 -04:00
Andrey 346e617d6a https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 13:49:44 -04:00
GitHub build-firmware Action 1e8feb2d1f Auto-generated configs and docs 2021-10-28 16:45:50 +00:00
Andrey 695ff0d391 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:29:56 -04:00
GitHub build-firmware Action 642403db21 Auto-generated configs and docs 2021-10-28 16:17:08 +00:00
Andrey 3bf9a982d9 https://rusefi.com/forum/viewtopic.php?f=19&t=2177 2021-10-28 12:12:45 -04:00
Andrey 5527f77589 Honda K cam wheels #3405 2021-10-28 10:36:41 -04:00
rusefi 032d6108ba secondary MRE 2021-10-27 19:54:45 -04:00
Andrey f526383aff UNUSED 2021-10-26 21:24:16 -04:00
GitHub build-firmware Action c53fc6823c Auto-generated configs and docs 2021-10-27 01:17:33 +00:00
Andrey 12ee912854 MRE_SECONDARY_CAN 2021-10-26 21:05:38 -04:00
rusefillc 996a39ba6e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 11:05:45 -04:00
rusefillc e7084a78cb generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:59:24 -04:00
rusefillc 0301abaca3 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 10:57:02 -04:00
rusefi 1c0919d2a0 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 20:06:57 -04:00
Andrey 63472eb4d4 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 19:19:16 -04:00
Andrey 98fe894ce1 Honda K cam wheels #3405 2021-10-24 17:12:19 -04:00
Andrey 8431db7d34 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 17:06:59 -04:00
Andrey a67a4ced0d docs 2021-10-24 17:05:37 -04:00
GitHub build-firmware Action 27e6c5d682 Auto-generated configs and docs 2021-10-24 19:28:08 +00:00
rusefillc baca6a2289 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:18:23 -04:00
rusefillc bb16d4e081 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:17:37 -04:00
rusefillc 4d2796a82b generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:08:21 -04:00
rusefillc 9741b037f5 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:58:04 -04:00
GitHub build-firmware Action ad366764f1 Auto-generated configs and docs 2021-10-24 17:18:25 +00:00
rusefillc 23012085c9 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:10:38 -04:00
rusefillc ec609264f3 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:01:40 -04:00
rusefillc 6878445be4 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 12:49:51 -04:00
Andrey 10aea43c1b generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 12:15:53 -04:00
rusefillc 201c67bc7c generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:31:32 -04:00
rusefillc 3158cb011d generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:16:11 -04:00
rusefillc b5b10be494 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 00:00:31 -04:00
rusefillc 18cccce097 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:46:08 -04:00
rusefillc b42f690dc7 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:42:22 -04:00
rusefillc 1916d4af46 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:40:14 -04:00
GitHub build-firmware Action ba5412ec92 Auto-generated configs and docs 2021-10-24 03:19:18 +00:00
rusefillc c1202ff717 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:14:46 -04:00
rusefillc ee0db90107 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:00:04 -04:00
rusefillc a6097a4c35 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 22:07:44 -04:00
GitHub build-firmware Action 66b3f414d0 Auto-generated configs and docs 2021-10-24 02:01:12 +00:00
rusefillc 4b8d841299 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 21:47:03 -04:00
rusefillc 9cf62643dc generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 20:24:21 -04:00
Matthew Kennedy fa9ca3c796 static (#3381) 2021-10-20 15:19:48 -04:00
GitHub build-firmware Action cea293cac7 Auto-generated configs and docs 2021-10-20 17:09:44 +00:00
rusefillc 45e0a0403f very old very dead code 2021-10-20 12:57:07 -04:00
rusefillc 9395517ae1 very old very dead code 2021-10-20 10:45:43 -04:00
rusefillc d60e6eb9af refactoring - extracting idle state 2021-10-17 00:30:26 -04:00
GitHub build-firmware Action 9388adc683 Auto-generated configs and docs 2021-10-17 03:59:20 +00:00
rusefillc d4e9c1597a refactoring - extracting idle state 2021-10-16 23:55:29 -04:00
rusefillc a16819ae10 refactoring 2021-10-16 23:18:09 -04:00
rusefillc 1fe037192e refactoring 2021-10-16 22:08:47 -04:00