Commit Graph

336 Commits

Author SHA1 Message Date
rusefillc f0b6dfa745 We really should decouple DC from ETB 2023-01-16 16:02:29 -05:00
rusefillc fe61c4cdd3 docs 2023-01-16 15:53:06 -05:00
Matthew Kennedy 1eca0ca1bd
Jammed ETB detection (#4873)
* jammed ETB detection

* autoscale

* comment

* cleanup

* implement test, cleanup
2023-01-10 15:31:04 -05:00
TurboMarian 64026b3d90 ALS UPDATE (ETB is working)
(cherry picked from commit decbf6d1615f1c15cc3e278932667a390d2539c9)
2022-12-26 19:21:18 -05:00
rusefillc 18165e4b02 guards 2022-12-17 14:36:27 -05:00
rusefillc 5be4f3e38e Better ETB duty ROC length default #4859 2022-12-02 14:51:48 -05:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey e6993aa248 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
Matthew Kennedy 65b459d461
live data objects evaluated at runtime (#4857)
* live data objects evaluated at runtime

* guard

* s
2022-11-30 19:29:22 -05:00
rusefi 4a68c321d3 ETB duty cycle jitter #4833
defaults
2022-11-30 17:09:28 -05:00
Andrey 4e74882c5e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
rusefi 1e7baa1089 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:39:55 -05:00
Andrey 31a8a91f3b ETB duty cycle jitter #4833 2022-11-29 21:03:21 -05:00
Andrey 3e6003f0ca refactoring: extracting method 2022-11-29 20:11:29 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 51ea23db68 ETB duty cycle jitter #4833 2022-11-29 12:39:47 -05:00
Andrey 607a5677d4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey cf63cea45f ETB JNI test progress 2022-11-29 02:21:36 -05:00
Andrey 4dd9217327 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey e6146d6ee5 unit test compile more of ETB code 2022-11-28 23:26:09 -05:00
Andrey aa46a00bfb unit test compile more of ETB code 2022-11-28 23:24:11 -05:00
Andrey c203685022 unit test compile more of ETB code 2022-11-28 23:22:08 -05:00
rusefillc 5596087481 ETB duty cycle jitter #4833 2022-11-28 20:33:04 -05:00
rusefillc c596445477 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-28 14:38:39 -05:00
rusefillc b214f19701 6379d894fd (r91274056) 2022-11-28 13:53:51 -05:00
rusefillc 5ed7a7bf00 9e3b7fabfe (r91273278) 2022-11-28 11:34:42 -05:00
rusefillc 9e3b7fabfe ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 23:29:08 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 6379d894fd ETB duty cycle jitter #4833 2022-11-27 18:45:10 -05:00
rusefillc 9321aae600 ETB duty cycle jitter #4833 2022-11-27 18:13:10 -05:00
rusefillc e4372f1262 docs 2022-11-27 00:08:45 -05:00
rusefi 596fe6b64a minor clean-up 2022-11-26 21:53:31 -05:00
rusefi 3375648612 usability progress: conditional ETB button enable. TODO: make logic consistent with other instances of same buttons 2022-11-26 14:26:29 -05:00
rusefi 7af86c0d48 code reuse 2022-11-26 14:08:59 -05:00
rusefillc 2c18e7745b
etbStatus_error does the job (#4820)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:08:26 -05:00
rusefillc 7e64b56690 trying to improve ETB logging 2022-11-22 20:20:45 -05:00
rusefillc 4beea9dc58 even if directly commanded ETB PWM should be logged it should be logged somewhere else 2022-11-22 20:16:54 -05:00
rusefillc 9f88281566 would need to stop the buzzing at PRI. 2022-11-15 11:01:56 -05:00
rusefillc 4cdc729d5c reducing confusion just a bit 2022-11-12 12:00:27 -05:00
Andrey Gusakov f341385138 ETB: do not restart ETH thread on each doInitElectronicThrottle() 2022-11-06 09:26:40 -05:00
Andrey Gusakov 6305606319 ETB: dead variable 2022-11-03 19:38:47 -04:00
Andrey Gusakov 1c4f437fad typo 2022-11-03 19:38:35 -04:00
Andrey Gusakov 8bb471c8a7 ETB: typo? 2022-11-03 19:38:14 -04:00
rusefi 7e95c2c672 removing dead code - function never returns nullptr 2022-11-03 09:40:44 -04:00
rusefillc 13c9de1c80 refactoring: helper method 2022-10-29 23:04:24 -04:00
rusefi f5abf3059a GM SENT ETB bench test in NJ #4688 2022-10-26 17:33:10 -04:00
rusefi d1d81de060 adding simplicity 2022-10-26 12:10:54 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy ca60dc17bb
trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
Matthew Kennedy 65d7abc162
etb rev limit indicator (#4483) 2022-08-25 20:49:21 -04:00
Matthew Kennedy b6f1779781
implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
Matthew Kennedy b99d90b006
Start -> start (#4366) 2022-07-21 15:17:32 -04:00
Matthew Kennedy 8bc01472b7
Add a timeout for Lua ETB adjustment (#4331)
* lua etb timeout

* mocks

* test
2022-07-10 05:46:28 +03:00
rusefillc 6c76a6468c logging of live data structs was: data points #3614
would this be more correct in terms of multi-threaded reads?
2022-06-29 03:33:06 -04:00
Andrey 5cf0265968 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc aab466094c logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc 10d3afab9c well that was cute 2022-06-27 23:10:58 -04:00
rusefi b6544cccf0 less invalid default config 2022-06-26 23:47:42 -04:00
rusefi 1f7051db48 proteus pinout minor mess 2022-06-02 23:28:39 -04:00
rusefillc bcc50f0de3 proteus meta 2022-05-04 17:05:08 -04:00
Matthew Kennedy 1bbc9472b4 proteus meta 2022-05-04 17:00:38 -04:00
rusefillc 3b3f62b24f Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
Andrey f3b7e1ae25 Move curves out of engineConfiguration in order to reduce RAM usage fix #4127 2022-05-02 05:04:58 -04:00
rusefillc e715bcc01f actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc e59ae35196 unique field names 2022-04-18 11:11:57 -04:00
rusefillc 82f608d558 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 08c50cc1dd logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
rusefillc 084685c747 logging of live data structs was: data points #3614
ETB
2022-04-14 15:25:01 -04:00
Matthew Kennedy f1742c44ff
output channel tweaks (#4023)
* shuffle around output channels

* postState should take a ref

* s

* s

* patch input file

* limits

* accel bad bounds check

* units

* units

* Revert "accel bad bounds check"

This reverts commit b2bb493be331d5d2cf40b9ed01363a53182c883e.

* missed an autoscale
2022-03-24 08:58:55 -04:00
Matthew Kennedy 929ff28c0c
Etb2 trim (#4004)
* wire up different logic for etb2

* clamp and actually works

* s

* happy compiler
2022-03-15 20:04:49 -04:00
rusefillc 9ba10b19d4 JNI for test coverage #3965 2022-03-15 11:47:47 -04:00
Andrey c4339e2148 JNI for test coverage #3965 2022-03-15 11:23:06 -04:00
Andrey df5cb34fb8 migrating to SensorType::Rpm API 2022-01-20 22:40:15 -05:00
rusefillc b9a792a07c Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 20:53:10 -05:00
rusefillc 71b2dc762a https://en.wikipedia.org/wiki/Pi 2022-01-14 21:23:27 -05:00
rusefillc 9f8ccececd docs & refactoring 2021-12-26 12:35:41 -05:00
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
Matthew Kennedy 479ae44cd7
remove etb status option (#3695)
* remove

* ui

* settings cpp
2021-12-15 08:20:14 -05:00
Andrey 940b04ab24 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
rusefillc f4ab23eb2b Requesting LUA Torque intervention #3638 2021-12-02 01:02:56 -05:00
rusefillc 67af7470d7 why so many channels are hidden in debug ? #3614 2021-11-29 01:13:04 -05:00
rusefillc 26997ab9e3 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
rusefillc 6ff42cc031 automation around outputs section #197 2021-11-26 20:46:42 -05:00
rusefi 8ed3020c07 live data for wastegate #3588 2021-11-24 15:07:48 -05:00
rusefillc 284fea286b live data for wastegate #3588 2021-11-24 13:20:47 -05:00
rusefillc c75291f415 live data for wastegate #3588
i want to persist state so no 'const' sorry
2021-11-23 15:52:43 -05:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy cb032fb1ea
(void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Andrey 2c715be4b7 ETB: do not touch HW pins if function not selected, this way Lua can use DC motor hardware pins directly 2021-11-08 12:44:37 -05:00
Matthew Kennedy 3348c0404b
configurable etb maximum (#3469)
* etb maximum

* update tests and test new behavior
2021-11-05 18:16:19 -04:00
Andrey 75ab0040a1 looks like value is never assigned 2021-10-30 21:28:55 -04:00
rusefillc 4533ce4764 refactoring - extracting idle state 2021-10-16 23:55:29 -04:00
rusefillc ea87d9c9be Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
dead code
2021-10-14 15:17:09 -04:00
rusefi 7c378c7c6c VAG ETB calibration is a mess? 2021-10-10 22:23:33 -04:00
rusefi 9b140e57a1 etb_test_hw 2021-10-10 17:10:04 -04:00
rusefi fe69616859 etb_test_hw 2021-10-10 16:29:45 -04:00