Commit Graph

1009 Commits

Author SHA1 Message Date
rusefillc d1876f67c3 Add setWgDutyAdd function to control only boost duty #4900 2022-12-19 11:43:44 -05:00
rusefillc 4e0eaf7e03 TurboMarian is the ALS boss 2022-12-17 19:39:36 -05:00
Andrey 748f97afeb kinetis asking for guard, also I've must have messed up something 2022-12-17 18:04:54 -05:00
rusefillc 2b4d58005b guards 2022-12-17 14:43:51 -05:00
rusefillc 18165e4b02 guards 2022-12-17 14:36:27 -05:00
rusefillc b3954122d6 TurboMarian is the ALS boss 2022-12-16 20:22:48 -05:00
Andrey ca10cf61d7 antilag and anti-lag #2403 2022-12-14 22:52:05 -05:00
GitHub gen-configs Action 42efd2c0fd Auto-generated configs and docs 2022-12-15 03:43:04 +00:00
Andrey 0b260b3e9f antilag and anti-lag #2403 2022-12-14 22:38:14 -05:00
rusefillc 5be4f3e38e Better ETB duty ROC length default #4859 2022-12-02 14:51:48 -05:00
GitHub gen-configs Action 5441e60c6b Auto-generated configs and docs 2022-12-01 03:35:46 +00:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey 32e502c569 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey e6993aa248 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
Matthew Kennedy 65b459d461
live data objects evaluated at runtime (#4857)
* live data objects evaluated at runtime

* guard

* s
2022-11-30 19:29:22 -05:00
rusefi 4a68c321d3 ETB duty cycle jitter #4833
defaults
2022-11-30 17:09:28 -05:00
Andrey 4e74882c5e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
rusefi 1e7baa1089 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:39:55 -05:00
GitHub gen-configs Action 4a35b55634 Auto-generated configs and docs 2022-11-30 03:25:45 +00:00
rusefi b5049c8284 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:13:59 -05:00
Andrey 31a8a91f3b ETB duty cycle jitter #4833 2022-11-29 21:03:21 -05:00
Andrey 6ad3ce13d6 ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 3e6003f0ca refactoring: extracting method 2022-11-29 20:11:29 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 51ea23db68 ETB duty cycle jitter #4833 2022-11-29 12:39:47 -05:00
Andrey 607a5677d4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey cf63cea45f ETB JNI test progress 2022-11-29 02:21:36 -05:00
Andrey 4dd9217327 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey e6146d6ee5 unit test compile more of ETB code 2022-11-28 23:26:09 -05:00
Andrey aa46a00bfb unit test compile more of ETB code 2022-11-28 23:24:11 -05:00
Andrey c203685022 unit test compile more of ETB code 2022-11-28 23:22:08 -05:00
rusefillc 5596087481 ETB duty cycle jitter #4833 2022-11-28 20:33:04 -05:00
GitHub gen-configs Action 53b1cfff95 Auto-generated configs and docs 2022-11-29 01:18:34 +00:00
rusefillc 59c5587368 ETB duty cycle jitter #4833 2022-11-28 20:13:16 -05:00
rusefillc c596445477 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-28 14:38:39 -05:00
rusefillc b214f19701 6379d894fd (r91274056) 2022-11-28 13:53:51 -05:00
rusefillc 5ed7a7bf00 9e3b7fabfe (r91273278) 2022-11-28 11:34:42 -05:00
rusefillc 9e3b7fabfe ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 23:29:08 -05:00
GitHub gen-configs Action 740425611f Auto-generated configs and docs 2022-11-28 03:49:25 +00:00
rusefillc 2b9164b7a4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 22:34:27 -05:00
Andrey 768f776d4d ETB duty cycle jitter #4833 2022-11-27 21:50:09 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 6379d894fd ETB duty cycle jitter #4833 2022-11-27 18:45:10 -05:00
GitHub gen-configs Action 74ea14b29e Auto-generated configs and docs 2022-11-27 23:28:40 +00:00
rusefillc 9321aae600 ETB duty cycle jitter #4833 2022-11-27 18:13:10 -05:00
rusefillc 8f0163273b docs 2022-11-27 00:27:29 -05:00
rusefillc e4372f1262 docs 2022-11-27 00:08:45 -05:00
rusefi 596fe6b64a minor clean-up 2022-11-26 21:53:31 -05:00
rusefi 3375648612 usability progress: conditional ETB button enable. TODO: make logic consistent with other instances of same buttons 2022-11-26 14:26:29 -05:00
rusefi 7af86c0d48 code reuse 2022-11-26 14:08:59 -05:00
rusefillc 2c18e7745b
etbStatus_error does the job (#4820)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:08:26 -05:00
GitHub gen-configs Action d64aaaf707 Auto-generated configs and docs 2022-11-23 01:42:21 +00:00
rusefillc 7e64b56690 trying to improve ETB logging 2022-11-22 20:20:45 -05:00
rusefillc 4beea9dc58 even if directly commanded ETB PWM should be logged it should be logged somewhere else 2022-11-22 20:16:54 -05:00
rusefillc a32531ee60 What is "Aux PID"? #4807 2022-11-21 00:10:35 -05:00
rusefillc 17fd8e53c3 What is "Aux PID"? fix #4807 2022-11-20 18:27:51 -05:00
rusefillc 4133fc2634 https://github.com/rusefi/alphax-4chan/issues/77 2022-11-20 16:42:44 -05:00
rusefillc 9f88281566 would need to stop the buzzing at PRI. 2022-11-15 11:01:56 -05:00
rusefillc 4cdc729d5c reducing confusion just a bit 2022-11-12 12:00:27 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey Gusakov f341385138 ETB: do not restart ETH thread on each doInitElectronicThrottle() 2022-11-06 09:26:40 -05:00
Matthew Kennedy 1269428044
remove idle timing deadzone (#4731)
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey Gusakov 6305606319 ETB: dead variable 2022-11-03 19:38:47 -04:00
Andrey Gusakov 1c4f437fad typo 2022-11-03 19:38:35 -04:00
Andrey Gusakov 8bb471c8a7 ETB: typo? 2022-11-03 19:38:14 -04:00
rusefi d6f8590cbf https://github.com/rusefi/rusefi/issues/4688#issuecomment-1301886167 2022-11-03 09:45:57 -04:00
rusefi 7e95c2c672 removing dead code - function never returns nullptr 2022-11-03 09:40:44 -04:00
GitHub gen-configs Action 523a6b9592 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 53649f73f1 Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
GitHub gen-configs Action c7ce2c2565 Auto-generated configs and docs 2022-10-30 21:55:22 +00:00
Andrey G cb7f592848
idle_state: rename useIacTableForCoasting -> isIacTableForCoasting (#4721) 2022-10-30 17:41:18 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 13c9de1c80 refactoring: helper method 2022-10-29 23:04:24 -04:00
rusefi f5abf3059a GM SENT ETB bench test in NJ #4688 2022-10-26 17:33:10 -04:00
rusefi d1d81de060 adding simplicity 2022-10-26 12:10:54 -04:00
rusefillc e16c8f9120 Lua aux gauge #4672 2022-10-17 21:21:23 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 974f6f540d VVT minimum RPM fix #4545 2022-09-27 22:41:26 -04:00
rusefillc 1bfc6adac3 refactoring: renaming method 2022-09-27 22:21:18 -04:00
Matthew Kennedy 57a22fd713
gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 8ea31909a3
add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
Matthew Kennedy 87649b9f72
more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefi 2042d9b0b6 You would not believe how you invert TLE9201 #4579 2022-09-13 21:03:47 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey 0cf66762ad dead 2022-09-08 00:20:56 -04:00
Andrey 73a7b24871 remove alternator on/off mode fix #4548 2022-09-07 23:06:34 -04:00
Andrey dab9e04b25 remove alternator on/off mode fix #4548 2022-09-07 22:46:42 -04:00
Andrey b756456450 tear down Engine god object #4511
just trying different things
2022-09-05 04:00:24 -04:00
Andrey 48f960b581 Revert "tear down Engine god object #4511"
This reverts commit dc60837e4c.
2022-09-01 20:44:51 -04:00
Andrey dc60837e4c tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 5766b1eca6 tear down Engine god object #4511
just trying different things
2022-09-01 19:46:47 -04:00
GitHub gen-configs Action 81a73508b7 Auto-generated configs and docs 2022-08-31 23:10:02 +00:00
Matthew Kennedy bf85db1c9b
AC delay (#4502)
* AC delay

* changelog
2022-08-31 19:01:42 -04:00
GitHub gen-configs Action 886f62da3d Auto-generated configs and docs 2022-08-30 02:29:24 +00:00
Matthew Kennedy cbe70f8dec
idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 553b549b95
idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
Matthew Kennedy ca60dc17bb
trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
GitHub gen-configs Action 8b8ce329b3 Auto-generated configs and docs 2022-08-27 18:44:44 +00:00
Andrey G 9997bf95e0
output channels: isFuelPumpOn vs isPumpOn, remove second one (#4490) 2022-08-27 14:28:33 -04:00
Andreika c24712bed7
[DRAFT] Air by rpm taper (#4486)
* add rpm to getOpenLoop() and getRunningOpenLoop()

* implement airByRpmTaper

* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
GitHub gen-configs Action 06cc54057a Auto-generated configs and docs 2022-08-26 01:09:10 +00:00
Matthew Kennedy 65d7abc162
etb rev limit indicator (#4483) 2022-08-25 20:49:21 -04:00
GitHub gen-configs Action dd41e87877 Auto-generated configs and docs 2022-08-26 00:41:14 +00:00
Matthew Kennedy 016c9ecd4b
fix typo, move bit to idle state (#4484) 2022-08-25 20:26:12 -04:00
Andrey 3fe2c74730 docs 2022-08-25 19:58:15 -04:00
rusefillc 4f916edb27 yeah, not really refactoring 2022-08-21 01:11:09 -04:00
rusefillc 217e6218bf AddressSanitizer does not like "yeah, not really refactoring"? 2022-08-21 00:45:39 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
rusefillc ab11a57e33 yeah, not really refactoring 2022-08-21 00:32:10 -04:00
GitHub gen-configs Action 47e13297f6 Auto-generated configs and docs 2022-08-21 04:25:05 +00:00
rusefillc 21ab47ed04 Idle air add via Lua #4465 2022-08-21 00:18:32 -04:00
Matthew Kennedy 3e4965ea27
fix inverted vvt (#4464)
* fix inverted mode

* unit tests are great
2022-08-20 20:12:32 -04:00
GitHub gen-configs Action 2d9f734a8f Auto-generated configs and docs 2022-08-19 03:08:33 +00:00
rusefillc 602bf97c00 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 23:03:33 -04:00
rusefillc 2da7ed51f0 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 21:10:19 -04:00
rusefillc db8a965288 unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
GitHub build-firmware Action 2d7ab9f712 Auto-generated configs and docs 2022-08-10 05:44:46 +00:00
rusefillc c96b6b53f6 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-10 01:39:24 -04:00
Matthew Kennedy e9e6df6d7f
add option to invert vvt control (#4425)
* add option to invert vvt control

* s

* s

* s

* one bit per cam type

* move the space

* I don't spelling good

* changelog
2022-08-09 16:22:55 -04:00
rusefillc 97601f9292 VVT target to allow negative values fix #4424 2022-08-08 22:51:51 -04:00
Matthew Kennedy b6f1779781
implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
Matthew Kennedy 923d2c2e44
unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
Matthew Kennedy 6b83ec8c08
boost control thresholds (#4392) 2022-07-28 09:45:16 +03:00
Matthew Kennedy d4b8a036af
Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
Matthew Kennedy b99d90b006
Start -> start (#4366) 2022-07-21 15:17:32 -04:00
Matthew Kennedy e1254f84b9
remove idle offset (#4355)
* remove offset

* remove more completely

* changelog
2022-07-18 15:49:43 -04:00
rusefillc 39df02fe35 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
GitHub build-firmware Action 7cada13589 Auto-generated configs and docs 2022-07-14 13:57:47 +00:00
rusefillc 7709b0f2a5 Detail on how to set up iDrive or equivalent CAN button control #226
was I drunk or something?
2022-07-14 09:41:36 -04:00
Matthew Kennedy 8bc01472b7
Add a timeout for Lua ETB adjustment (#4331)
* lua etb timeout

* mocks

* test
2022-07-10 05:46:28 +03:00
GitHub build-firmware Action 7764bf729a Auto-generated configs and docs 2022-07-08 05:14:15 +00:00
rusefillc a3c7e59b2a debug is set to idle mode, but none of the debug fields show anything #4335
better log names?
2022-07-08 01:05:48 -04:00
GitHub build-firmware Action 92eeceb5ed Auto-generated configs and docs 2022-07-08 04:29:21 +00:00
rusefillc eb3f93a730 debug is set to idle mode, but none of the debug fields show anything #4335
better names where user did not really ask for better names
2022-07-07 23:48:17 -04:00
GitHub build-firmware Action a145548ceb Auto-generated configs and docs 2022-07-02 08:21:19 +00:00
rusefillc 147724c984 https://github.com/rusefi/hellen154hyundai/issues/54 2022-07-02 04:06:09 -04:00
GitHub build-firmware Action 54a140d0df Auto-generated configs and docs 2022-07-02 07:55:19 +00:00
rusefillc 3858b1d720 https://github.com/rusefi/hellen154hyundai/issues/54 2022-07-02 03:49:49 -04:00
rusefillc 483395fa2e
https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
rusefillc 6c76a6468c logging of live data structs was: data points #3614
would this be more correct in terms of multi-threaded reads?
2022-06-29 03:33:06 -04:00
Andrey 5cf0265968 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc f262929226 logging of live data structs was: data points #3614 2022-06-29 03:14:39 -04:00
rusefillc 8acbf9d8df logging of live data structs was: data points #3614 2022-06-29 03:13:35 -04:00
rusefillc aab466094c logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc 10d3afab9c well that was cute 2022-06-27 23:10:58 -04:00
rusefi b6544cccf0 less invalid default config 2022-06-26 23:47:42 -04:00
Matthew Kennedy 7e8ae7c8a3
Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi 1f7051db48 proteus pinout minor mess 2022-06-02 23:28:39 -04:00
rusefillc 2132cec3fc Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
GitHub build-firmware Action 4e213fbc1e Auto-generated configs and docs 2022-05-09 09:42:49 +00:00
rusefillc 66f35b0b40 Remove value copy from controller into outputChannels #4095 2022-05-09 05:30:04 -04:00
rusefillc bcc50f0de3 proteus meta 2022-05-04 17:05:08 -04:00
Matthew Kennedy 1bbc9472b4 proteus meta 2022-05-04 17:00:38 -04:00
rusefillc 3b3f62b24f Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
Andrey f3b7e1ae25 Move curves out of engineConfiguration in order to reduce RAM usage fix #4127 2022-05-02 05:04:58 -04:00
Andrey e62877964a Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
Matthew Kennedy e4a0979dc2
Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
rusefillc 451b4a766c Three names of the same thing fix #4085 2022-04-19 19:47:43 -04:00
rusefillc bae4911838 https://github.com/rusefi/alphax-2chan/issues/50
more progress
2022-04-19 15:03:38 -04:00
rusefillc 7534d2a963 https://github.com/rusefi/alphax-2chan/issues/50
we have great CI
2022-04-19 13:57:39 -04:00
rusefillc 98eba617c2 https://github.com/rusefi/alphax-2chan/issues/50
sweet-sweet copy-pasta
2022-04-19 12:42:30 -04:00
rusefillc ae98105fdc https://github.com/rusefi/alphax-2chan/issues/50
refactoring: extract method
2022-04-19 12:40:02 -04:00
rusefillc e715bcc01f actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc e59ae35196 unique field names 2022-04-18 11:11:57 -04:00
GitHub build-firmware Action a2cff4ee12 Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 82f608d558 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 08c50cc1dd logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
rusefillc 70e4d118ef very random progress 2022-04-16 17:04:35 -04:00
rusefillc c023056d2d very random progress 2022-04-16 16:49:59 -04:00
rusefillc 0b21ddce9c random progress 2022-04-16 16:39:52 -04:00
rusefillc 084685c747 logging of live data structs was: data points #3614
ETB
2022-04-14 15:25:01 -04:00
rusefillc 16878487d5 logging of live data structs was: data points #3614
ETB
2022-04-14 14:38:32 -04:00
rusefillc 4834683dc6 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 413e636d4c typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc b776003989 do not control VVT during cranking fix #3443 2022-04-10 19:22:39 -04:00
rusefillc a90ca2b200 Hellen NB2 default tune #4038 2022-04-10 19:11:34 -04:00
rusefillc e1235c4f2e Air Conditioning Improvements #4054 2022-04-09 00:26:52 -04:00
GitHub build-firmware Action 6a403abf1f Auto-generated configs and docs 2022-04-09 01:37:21 +00:00
rusefillc ed6ed0d93e Air Conditioning Improvements #4054 2022-04-08 21:28:50 -04:00
GitHub build-firmware Action 3681d008e8 Auto-generated configs and docs 2022-04-08 16:21:15 +00:00
rusefillc 59a58dd910 Air Conditioning Improvements #4054 2022-04-08 12:12:24 -04:00
Andrey 8053aeb9cf Extra Idle Air if Throttle is Pressed behavior #3940
only live data
2022-04-03 20:30:09 -04:00
Matthew Kennedy f1742c44ff
output channel tweaks (#4023)
* shuffle around output channels

* postState should take a ref

* s

* s

* patch input file

* limits

* accel bad bounds check

* units

* units

* Revert "accel bad bounds check"

This reverts commit b2bb493be331d5d2cf40b9ed01363a53182c883e.

* missed an autoscale
2022-03-24 08:58:55 -04:00
Matthew Kennedy 929ff28c0c
Etb2 trim (#4004)
* wire up different logic for etb2

* clamp and actually works

* s

* happy compiler
2022-03-15 20:04:49 -04:00
rusefillc 6c8f130ff9 JNI for test coverage #3965 2022-03-15 13:05:24 -04:00
rusefillc 9ba10b19d4 JNI for test coverage #3965 2022-03-15 11:47:47 -04:00
Andrey c4339e2148 JNI for test coverage #3965 2022-03-15 11:23:06 -04:00
rusefillc 5f73d9bf7b JNI for test coverage #3965 2022-03-15 10:33:17 -04:00
Matthew Kennedy 2595decb58
delayedShutoffRequested (#3881) 2022-02-02 14:57:19 -05:00
Matthew Kennedy 40d16291b0
Remove fsio part 2 (#3876)
* dead config stuff

* fsio state

* remove tests

* getEngineValue

* put part back
2022-02-02 00:49:44 -05:00
rusefillc 42deca0fd0
Main relay shutdown rebase (#3880)
* aggregate

* main relay controller handles delayed shutoff

* main relay controller handles delayed shutdown

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-02 00:45:11 -05:00
GitHub build-firmware Action 9b8de47b72 Auto-generated configs and docs 2022-02-02 04:22:53 +00:00
rusefillc e11e701d5c main relay controller handles delayed shutdown 2022-02-01 23:12:50 -05:00
Matthew Kennedy a718f3a30a
Remove fsio part 1 (#3871)
* dead includes

* move last logic out of fsio

* dead functions
2022-02-01 15:42:04 -05:00
rusefillc ca98e270e1
safer file name (#3861)
* safer file name

* safer file name

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-01-31 21:51:32 -05:00
Andrey 1bd71e4b2e migrating to SensorType::Rpm API 2022-01-20 23:54:52 -05:00
Andrey e945bc4bc9 migrating to SensorType::Rpm API 2022-01-20 22:51:20 -05:00
Andrey df5cb34fb8 migrating to SensorType::Rpm API 2022-01-20 22:40:15 -05:00
Andrey 16b3e95865 migrating to SensorType::Rpm API 2022-01-20 22:31:07 -05:00
Andrey 8361b6d1f6 migrating to SensorType::Rpm API 2022-01-20 22:22:52 -05:00
Matthew Kennedy 76fdb4063e
XY Idle VE Table (#3781)
* config & ui

* implement

* test idle VE switching behavior

* use the interface where we can

* s

* re-bump flash version
2022-01-20 14:08:54 -05:00
rusefillc b9a792a07c Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 20:53:10 -05:00
rusefillc 71b2dc762a https://en.wikipedia.org/wiki/Pi 2022-01-14 21:23:27 -05:00
Matthew Kennedy 3e56bacef9
don't start boost pwm unnecessarily (#3767)
* don't start boost pwm unnecessarily

* test
2022-01-11 20:47:50 -05:00
rusefillc 3528befe13 live view is confused by conditional compilation #3773
ops
2022-01-11 14:24:53 -05:00
rusefillc 1bcb3e8033 live view is confused by conditional compilation fix #3773 2022-01-11 14:10:30 -05:00
rusefillc 699a5ef302 RE usability: live data for idle controller 2022-01-10 21:55:52 -05:00
GitHub build-firmware Action 68fda494cb Auto-generated configs and docs 2022-01-11 01:57:47 +00:00
rusefillc 264933c0f9 RE usability: live data for idle controller 2022-01-10 20:51:49 -05:00
rusefillc 9f97695f4c RE usability: live data for idle controller 2022-01-10 20:32:20 -05:00
rusefillc 339b906aa9 RE usability: live data for idle controller
static bad, class fields better
2022-01-10 20:12:11 -05:00
rusefillc 6ee0a55eaf RE usability: live data for idle controller 2022-01-10 19:48:58 -05:00
Andrey G 77fa9929d0
Stepper direct push pull driver (#3751)
* Init DC motor through two brain_pin_e only

* idle: stepper: allow driving stepper through 4 output_pin_e
2022-01-07 11:38:48 -05:00
Andrey G 5bc9289d74
Move out of CMM (#3750)
This needs additional investigation. But allocating these structs
in CMM cause HardFault
2022-01-07 10:09:48 -05:00
GitHub build-firmware Action 2208947bb3 Auto-generated configs and docs 2022-01-05 06:49:51 +00:00
GitHub build-firmware Action 38b17f5859 Auto-generated configs and docs 2022-01-05 05:09:04 +00:00
rusefillc 2016ecbe98 live data progress 2022-01-02 01:17:22 -05:00
rusefillc 9f8ccececd docs & refactoring 2021-12-26 12:35:41 -05:00
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
Matthew Kennedy c176bbebc1
ui & config for fuel/ign trim tables (#3704)
* ui & config

* bump flash version

* compaction

* s

* make things happy

* fsio too

* OK, well those defaults were insane

* b

* why are these defaults insane

* adjust cylinder offset ui

* s

* cleanup
2021-12-20 21:58:53 -05:00
Matthew Kennedy 3a4a0ba18d
simplify some table lookups (#3692)
* simplify

* expand interpolation test
2021-12-20 08:14:30 -05:00
Matthew Kennedy 479ae44cd7
remove etb status option (#3695)
* remove

* ui

* settings cpp
2021-12-15 08:20:14 -05:00
Matthew Kennedy 91ec135cf8
ignition controller detects rising edge on voltage (#3636)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test
2021-12-07 21:28:04 -05:00
Andrey 940b04ab24 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
Matthew Kennedy 7dc20b368a
Alternator controller is engine module (#3663)
* alternator is engine module

* user can't set pid period
2021-12-05 18:33:50 -05:00
rusefillc f4ab23eb2b Requesting LUA Torque intervention #3638 2021-12-02 01:02:56 -05:00
GitHub build-firmware Action 4392161ac9 Auto-generated configs and docs 2021-12-02 05:04:17 +00:00
rusefillc 6d4b1e6020 proteus to have enlarged Lua
one step back
2021-11-30 22:35:29 -05:00
rusefillc de0680209b why so many channels are hidden in debug ? #3614 2021-11-29 10:15:28 -05:00
rusefillc 67af7470d7 why so many channels are hidden in debug ? #3614 2021-11-29 01:13:04 -05:00
rusefillc 26997ab9e3 why so many channels are hidden in debug ? #3614 2021-11-29 01:02:40 -05:00
GitHub build-firmware Action 2e97642dae Auto-generated configs and docs 2021-11-28 05:54:31 +00:00
Matthew Kennedy b8660db35e
make fan control live-data-friendly (#3626)
* make fan live-data-friendly

* script

* generated for happy simulator
2021-11-28 00:40:12 -05:00
Matthew Kennedy 71aff73081
not industrial (#3627) 2021-11-27 19:27:57 -05:00
rusefillc 6ff42cc031 automation around outputs section #197 2021-11-26 20:46:42 -05:00
Matthew Kennedy 0badb6b2ff
AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
rusefi 8ed3020c07 live data for wastegate #3588 2021-11-24 15:07:48 -05:00
GitHub build-firmware Action c46cf51dc5 Auto-generated configs and docs 2021-11-24 19:10:22 +00:00
rusefillc 284fea286b live data for wastegate #3588 2021-11-24 13:20:47 -05:00
rusefillc 3ac46c98f2 live data for wastegate #3588 2021-11-24 13:18:07 -05:00
rusefillc 3077f795c4 live data for wastegate #3588 2021-11-24 12:59:57 -05:00
GitHub build-firmware Action bfdbf70c07 Auto-generated configs and docs 2021-11-24 13:02:01 +00:00
Matthew Kennedy 81fffe87b7
main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
GitHub build-firmware Action 7287d41467 Auto-generated configs and docs 2021-11-23 21:00:29 +00:00
rusefillc c75291f415 live data for wastegate #3588
i want to persist state so no 'const' sorry
2021-11-23 15:52:43 -05:00
rusefillc ca1e420073 live data for wastegate #3588 2021-11-23 15:51:30 -05:00
GitHub build-firmware Action a4557c969f Auto-generated configs and docs 2021-11-23 20:06:24 +00:00
rusefillc d21541934d live data for wastegate #3588 2021-11-23 15:02:03 -05:00
rusefillc ead3853f9a live data for wastegate #3588 2021-11-23 15:00:47 -05:00
GitHub build-firmware Action f8f52c4c1f Auto-generated configs and docs 2021-11-20 03:34:23 +00:00
Matthew Kennedy d40ca0f581
fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
Scott Smith 98040ad9af
Make the module API more concise. (#3571)
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith 62daac73c7
Use Valgrind to detect unitialized variable references. (#3555)
* Use Valgrind to detect unitialized variable references.

Fix the edge cases that pop up

* Comment and disable Mac run
2021-11-15 23:42:23 -05:00
Matthew Kennedy cb032fb1ea
(void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Andrey 2c715be4b7 ETB: do not touch HW pins if function not selected, this way Lua can use DC motor hardware pins directly 2021-11-08 12:44:37 -05:00
Matthew Kennedy 3348c0404b
configurable etb maximum (#3469)
* etb maximum

* update tests and test new behavior
2021-11-05 18:16:19 -04:00
Matthew Kennedy 5b35aa8f21
log vvt targets (#3417)
* log vvt target

* java

* make java happy probably

* sensorlogger
2021-11-02 15:03:57 -04:00
GitHub build-firmware Action 8ac4341cfa Auto-generated configs and docs 2021-10-31 01:38:27 +00:00
Andrey 75ab0040a1 looks like value is never assigned 2021-10-30 21:28:55 -04:00
rusefillc 5f4fa50682 VVT is no longer aux pid 2021-10-28 23:51:46 -04:00
Matthew Kennedy 558a6d01fc
etb pwm limit (#3408)
* etb pwm limit

* missed an arg

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-25 15:35:23 -04:00
GitHub build-firmware Action 679239c7f8 Auto-generated configs and docs 2021-10-17 04:35:27 +00:00
rusefillc 2431fa79b3 refactoring - extracting idle state 2021-10-17 00:30:26 -04:00
GitHub build-firmware Action 25ff3fe2d7 Auto-generated configs and docs 2021-10-17 03:59:20 +00:00
rusefillc 4533ce4764 refactoring - extracting idle state 2021-10-16 23:55:29 -04:00
rusefillc 5f7ffd32a1 refactoring 2021-10-16 23:40:02 -04:00
GitHub build-firmware Action 981fc58297 Auto-generated configs and docs 2021-10-17 01:13:47 +00:00
rusefillc 4cc1c352c2 better file locations 2021-10-16 20:17:01 -04:00
rusefillc 3162d9cc56 let's see if CI would fail, i.e. let's see if this logic was covered 2021-10-16 19:03:36 -04:00
rusefillc 01d4b7ef7a Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
progress
2021-10-14 15:18:13 -04:00
rusefillc ea87d9c9be Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
dead code
2021-10-14 15:17:09 -04:00
rusefillc ff864ec0bf Whatever we call it, how ever we implement it - we need live data / remote view into rusEFI actual state #3353 2021-10-14 00:47:26 -04:00
rusefi 7c378c7c6c VAG ETB calibration is a mess? 2021-10-10 22:23:33 -04:00
rusefi 9b140e57a1 etb_test_hw 2021-10-10 17:10:04 -04:00
rusefi fe69616859 etb_test_hw 2021-10-10 16:29:45 -04:00
Andreika bc4a068c9c
[DRAFT] IAC H-Bridge Microstepping (#3213)
* fix for stepperHbridgeHardware

* new config fields for microstepping

* add stepper dir pin mode to the dialog

* refactor stepper hw dialog & add microstepping panel

* microstepper modes enum

* stepperDcInvertedPins needed by Hellen

* add sleep() for stepper and divisor for pause()

* microstepping impl.

* make unit-tests more happy

* small progress

* fix etb-stepper dlg conflict

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 13:57:04 -04:00
Andreika d917cc8cc2
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables (#3168)
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper

* Change isIdling() to isIdlingOrTaper()

* test_idle_controller.cpp

* useSeparateIdleTablesForCrankingTaper setting

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
Matthew Kennedy 9797d25b7c
getOrZero (#3319) 2021-10-05 19:59:07 -04:00
rusefillc 16049a07e8 https://rusefi.com/forum/viewtopic.php?p=42468#p42468 2021-10-04 19:10:31 -04:00
rusefillc 4901a69d17 https://rusefi.com/forum/viewtopic.php?p=42468#p42468 2021-10-04 18:43:37 -04:00
rusefillc 8fabcd15ab wow that was a bad setting name 2021-09-26 18:07:49 -04:00
rusefi 235c932c71 Revert "Hellen Nissan defaults are no longer valid fix #3143"
This reverts commit 6ac7fc39
2021-09-14 15:51:58 -04:00
rusefi 6ac7fc3940 Hellen Nissan defaults are no longer valid fix #3143 2021-09-14 15:46:21 -04:00
Matthew Kennedy 884532cb6f
boost debug fields (#3228) 2021-09-07 14:07:47 -04:00
rusefillc 8c9ff949fe thank you Nik - dealing with false positive CUSTOM_OBD_LOW_FREQUENCY 2021-09-06 08:09:14 -04:00
rusefillc 0bdf334a8a hysteresis for GPPWM #3222 2021-09-06 07:58:17 -04:00
rusefillc 43bdabeb0c hysteresis for GPPWM #3222 2021-09-06 07:21:17 -04:00
rusefillc 36792f55b5 hysteresis for GPPWM #3222 2021-09-05 20:18:14 -04:00
rusefillc 58c2bf8930 hysteresis for GPPWM #3222 2021-09-05 20:16:57 -04:00
Andrey 3ed50dbea7 SD-card log fields improvement (warning counter & last code) #3162 2021-09-05 14:43:35 -04:00
Matthew Kennedy 730b26d034
remove old vss implementation (#3208)
* dead vss

* remove
2021-08-28 01:39:55 -04:00
Matthew Kennedy 6407e74ae2
disable closed loop boost below MAP threshold (#3206)
* boost minimum map

* changelog
2021-08-27 17:54:08 -04:00
rusefillc 48a009fc33 Revert "Revert "memory savings (#3195)""
This reverts commit 0b3ef5f5
2021-08-27 06:18:05 -04:00
rusefillc 0b3ef5f553 Revert "memory savings (#3195)"
This reverts commit 52a24ee7
2021-08-27 02:32:31 -04:00
Matthew Kennedy 52a24ee773
memory savings (#3195)
* d

* dead code

* all your ram are belong to me

* turn off gpiochips we don't need

* save

* save by using the same file handle

* smaller stack ok

* these can be on the stack

* this is closer

* what about ccm?

* probing available

* now probe ccm

* ccm

* put stuff in ccm

* fsio

* memory usage

* memory
2021-08-26 23:05:31 +03:00
Matthew Kennedy 50889671c0
fix ETB PWM (#2870)
* iwpm

* dc motor has configure

* consume

* format

* use fake PWM to save one SimplePwm instance

* comments

* not sure why I changed that

* init the pins otherwise

* typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-19 08:33:33 +03:00
Matthew Kennedy 68e2b93dff
don't print the wrong number (#3158)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-15 02:10:28 -04:00
Matthew Kennedy 2ad4a9df1e
actually remove FSIO idle stuff (#3150)
* debug mode

* pid cleanup

* more dead

* more dead

* wow more dead

* much dead many death wow
2021-08-14 09:48:45 +03:00
rusefillc e445d9724e dead idle FSIO 2021-08-14 01:48:03 -04:00
alxrMironov 7ebebd6922
Begin "vehicleSpeed" refactoring. Module switched to "FunctionalPointerSensor" class. #3106 #3107 #3108. (#3132)
* Add new sensor type "VehicleSpeed"

* Add "Vehicle speed" sensor to name list

* Add Vehicle speed sensor initialization with function pointer sensor.

* Add init_vehicle_speed_sensor.cpp to Makefile

* Replace dependencies from "getVehicleSpeed" to OOP-like "Sensor::get()"

* Add warning and TODO to "mock vehicle speed" call

* Replace get & mock "VehicleSpeed" methods in tests

* Remove #warning directive (cause error by current settings)

* Remove stray tab

* Remove explicitly type casting.

* Add "InitVehicleSpeedSensor" function declaration to init.h

* Add "VehicleSpeedSensor" initialization call into "InitNewSensors"

Co-authored-by: alxrMironov <330OMcorporative>
2021-08-12 22:16:51 +03:00
Matthew Kennedy 90a0e47b04
skip etb init if no primary sensor (#3136)
* skip init if no primary sensor

* specific test
2021-08-12 00:45:44 +03:00
Matthew Kennedy d24f1462e2
even more pch (#3112)
* s

* more

* s

* f7
2021-08-04 19:30:52 -04:00
Matthew Kennedy 25414ebdad
yet more pch (#3068)
* big pch energy

* put back ramdisk stub

* tests are happy

* h743 nucleo

* kinetis

* I love deleting code!

* make stepper happy

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy a8eddbccf6
perform extra-step-prevention in the stepper driver itself (#3038)
* perform extra-step-prevention in the stepper driver itself

* isBusy flag

* I am unable to type

* the court of public opinion has decided that greater-equal is correct

* that sets target in steps, not percent

* correct var name

* mock stepper motor

* testable stepper

* build is happy

* helping build
2021-08-02 07:03:57 -04:00
Andrey 511b5c22dd unit test for vehicle_speed.cpp #3081 2021-08-01 12:09:53 -04:00
Matthew Kennedy ab49f61a83
gppwm vbatt axis (#3088) 2021-07-31 21:20:19 -04:00
rusefillc c6dbd9caf7 121 vag defaults have fatal error fix #3059 2021-07-26 16:40:11 -04:00
Matthew Kennedy b52d50bbf2
Use pch in lots of files (#3066)
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
2021-07-26 01:05:17 -04:00
Andrey eaeade5305 Clutch switch inverted options do not invert detected pedal position
#3044
2021-07-24 18:59:00 -04:00
Andrey 37247db383 Clutch switch inverted options do not invert detected pedal position
#3044
2021-07-24 18:44:13 -04:00
Matthew Kennedy 617c2886d9
adjust taper behavior (#3051)
* adjust taper behavior

* check that taper works in running state too
2021-07-24 16:12:07 -04:00
rusefillc ca34562d5d Clutch switch inverted options do not invert detected pedal position #3044 2021-07-24 15:54:51 -04:00
rusefillc 9c166d86fe Clutch switch inverted options do not invert detected pedal position #3044 2021-07-24 15:36:03 -04:00
rusefillc 4ae72f43f6 "prettyClose": some strange code inside idle controller? #3030 2021-07-22 15:30:32 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey a926357a01 making code more testable 2021-07-14 22:37:05 -04:00
Matthew Kennedy 5e08907590
knock sensing peak detect (#2910)
* knock peak detect

* comments

* comment

* initialize

* test

* fix warnings while we're here

* those are functions, not values

* ram
2021-07-06 21:44:59 -04:00
Andrey aabdea4140 Option to log VVT target #2913 2021-07-06 20:00:53 -04:00
Matthew Kennedy 5bd3ae3aaa
Disable closed loop idle during cranking->running taper (#2900)
* implement

* dead file?

* implement tests

* new phase
2021-07-06 08:47:06 -04:00
Matthew Kennedy 007a390f2b
Gate closed loop idle on road speed (#2901)
* implement

* test

* b

* config
2021-07-04 09:35:12 -04:00
Matthew Kennedy 1bca4843fe
test dc_motor.cpp (#2890)
* use ipwm where possible

* mock ipwm

* initialize

* test
2021-07-01 09:21:18 -04:00
Matthew Kennedy 32f5ce6fb4
no fan if stopped engine (#2822)
* no fan if stopped engine

* config

* use config

* more tests

* merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 08:52:54 -04:00
Matthew Kennedy cd5eb6a77c
Move AC logic out of FSIO (#2872)
* new impl

* remove fsio

* inject "is ac active" to fan

* include the correct code

* include

* test

* more AC features

* AC switch vs. actual AC indicators

* include

* duh
2021-06-27 18:51:34 -04:00
Matthew Kennedy cd055a687d
dc motor api (#2869)
* iwpm

* dc motor has configure

* consume

* format

* spelling
2021-06-26 21:42:40 -04:00
Matthew Kennedy 2475cb283b
warnings (#2862)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 20:58:38 -04:00
Matthew Kennedy 93adb8ea76
Etb rev limit (#2820)
* cfg

* impl

* a test

* don't break the ts channel

* text
2021-06-16 08:44:48 -04:00
Matthew Kennedy a4973a6f3d
fan/AC idle improvements (#2818)
* fan 2 open loop bump

* we had an AC target bump all this time?!

* format

* enable test

* I can't type
2021-06-15 17:30:35 -04:00
Matthew Kennedy 097bf85faf
dual fans (#2806)
* remove fsio

* hard code impl

* test it

* enable fan with AC

* make commented stuff match

* second fan config

* second fan ui

* defaults

* impl
2021-06-13 08:06:45 -04:00
Matthew Kennedy 15d172ab08
apply open loop idle when in automatic mode (#2745)
* always apply open loop in closed loop

* simplify flags

* comment

* move

* comment

* missed one

* config for fan bump

* adjust miata defaults

* test fan/ac open loop

* idle CL tests

* test coasting

* test integration case

* fix merge

* put back reset logic for now

* s

* don't need that part

* I guess use OL as baseIdlePosition

* reset condition
2021-06-12 14:21:11 -04:00
Matthew Kennedy c27549b2e8
hard coded fan logic (#2805)
* remove fsio

* hard code impl

* test it

* enable fan with AC

* make commented stuff match
2021-06-11 06:25:12 -04:00
Andrey 24131cdc0e s/controlPin1/controlPin/ 2021-06-05 16:19:01 -04:00
Matthew Kennedy 3ef969d743
warnings & assorted cleanup (#2793)
* lua hook

* validateBuffer

* tables

* simplify fsio table

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
Matthew Kennedy 981e8f5047
defaults cleanup: base engine & fuel (#2790)
* build

* fuel and base

* fix build

* cleanup

* extern

* tps/tps

* alternator

* tps

* iat timing

* cranking RPM

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 00:50:07 +03:00
Matthew Kennedy f3c5ff6d54
idle fan/AC open loop bump (#2785)
* idle open loop ui section

* idle bump logic

* test fan/ac bump
2021-06-01 00:45:04 +03:00
Matthew Kennedy 39e4f70405
iac coast table (#2784) 2021-06-01 00:43:58 +03:00
Matthew Kennedy 7d773bfb1d
make the implementation match what the UI claims (#2779) 2021-05-31 07:37:02 -04:00
Matthew Kennedy a50f8e0077
Idle test that fails (#2781)
* make member func

* failing test
2021-05-31 06:18:15 -04:00
Matthew Kennedy d2f7e96747
code style (#2780) 2021-05-31 06:01:57 -04:00
Matthew Kennedy ec8e1eee69
require redundant pedal (#2758)
* require redundant pedal

* return false

* I don't typing good

* tests

* tests
2021-05-30 19:19:57 -04:00
Matthew Kennedy 58b274c80c
safe boost duty (#2764) 2021-05-30 14:04:04 +03:00
Matthew Kennedy 2667810942
add pedal to gppwm (#2748)
* add pedal to gppwm

* string
2021-05-28 03:38:45 -04:00
Matthew Kennedy 13d2ee03bc
idle indicators (#2692)
* add coasting bit

* remove useless bit
2021-05-13 17:35:00 -04:00
Matthew Kennedy dd6105cfa3
shrink canned tables (#2651)
* helper

* use it miata

* do type safe copy

* miata vvt

* etb

* default iat correction

* magic is afoot here

* hunchback

* misc

* neon

* neon

* aspire

* citroen

* neon

* missed one

* dead

* festiva

* remove andreyism

* very dead

* no need for copy of that function

* cleanup
2021-05-09 14:37:16 -04:00