Commit Graph

778 Commits

Author SHA1 Message Date
rusefillc 5596087481 ETB duty cycle jitter #4833 2022-11-28 20:33:04 -05:00
GitHub gen-configs Action 53b1cfff95 Auto-generated configs and docs 2022-11-29 01:18:34 +00:00
rusefillc 59c5587368 ETB duty cycle jitter #4833 2022-11-28 20:13:16 -05:00
rusefillc c596445477 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-28 14:38:39 -05:00
rusefillc b214f19701 6379d894fd (r91274056) 2022-11-28 13:53:51 -05:00
rusefillc 5ed7a7bf00 9e3b7fabfe (r91273278) 2022-11-28 11:34:42 -05:00
rusefillc 9e3b7fabfe ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 23:29:08 -05:00
GitHub gen-configs Action 740425611f Auto-generated configs and docs 2022-11-28 03:49:25 +00:00
rusefillc 2b9164b7a4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 22:34:27 -05:00
Andrey 768f776d4d ETB duty cycle jitter #4833 2022-11-27 21:50:09 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 6379d894fd ETB duty cycle jitter #4833 2022-11-27 18:45:10 -05:00
GitHub gen-configs Action 74ea14b29e Auto-generated configs and docs 2022-11-27 23:28:40 +00:00
rusefillc 9321aae600 ETB duty cycle jitter #4833 2022-11-27 18:13:10 -05:00
rusefillc 8f0163273b docs 2022-11-27 00:27:29 -05:00
rusefillc e4372f1262 docs 2022-11-27 00:08:45 -05:00
rusefi 596fe6b64a minor clean-up 2022-11-26 21:53:31 -05:00
rusefi 3375648612 usability progress: conditional ETB button enable. TODO: make logic consistent with other instances of same buttons 2022-11-26 14:26:29 -05:00
rusefi 7af86c0d48 code reuse 2022-11-26 14:08:59 -05:00
rusefillc 2c18e7745b
etbStatus_error does the job (#4820)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:08:26 -05:00
GitHub gen-configs Action d64aaaf707 Auto-generated configs and docs 2022-11-23 01:42:21 +00:00
rusefillc 7e64b56690 trying to improve ETB logging 2022-11-22 20:20:45 -05:00
rusefillc 4beea9dc58 even if directly commanded ETB PWM should be logged it should be logged somewhere else 2022-11-22 20:16:54 -05:00
rusefillc a32531ee60 What is "Aux PID"? #4807 2022-11-21 00:10:35 -05:00
rusefillc 17fd8e53c3 What is "Aux PID"? fix #4807 2022-11-20 18:27:51 -05:00
rusefillc 4133fc2634 https://github.com/rusefi/alphax-4chan/issues/77 2022-11-20 16:42:44 -05:00
rusefillc 9f88281566 would need to stop the buzzing at PRI. 2022-11-15 11:01:56 -05:00
rusefillc 4cdc729d5c reducing confusion just a bit 2022-11-12 12:00:27 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey Gusakov f341385138 ETB: do not restart ETH thread on each doInitElectronicThrottle() 2022-11-06 09:26:40 -05:00
Matthew Kennedy 1269428044
remove idle timing deadzone (#4731)
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey Gusakov 6305606319 ETB: dead variable 2022-11-03 19:38:47 -04:00
Andrey Gusakov 1c4f437fad typo 2022-11-03 19:38:35 -04:00
Andrey Gusakov 8bb471c8a7 ETB: typo? 2022-11-03 19:38:14 -04:00
rusefi d6f8590cbf https://github.com/rusefi/rusefi/issues/4688#issuecomment-1301886167 2022-11-03 09:45:57 -04:00
rusefi 7e95c2c672 removing dead code - function never returns nullptr 2022-11-03 09:40:44 -04:00
GitHub gen-configs Action 523a6b9592 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 53649f73f1 Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
GitHub gen-configs Action c7ce2c2565 Auto-generated configs and docs 2022-10-30 21:55:22 +00:00
Andrey G cb7f592848
idle_state: rename useIacTableForCoasting -> isIacTableForCoasting (#4721) 2022-10-30 17:41:18 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 13c9de1c80 refactoring: helper method 2022-10-29 23:04:24 -04:00
rusefi f5abf3059a GM SENT ETB bench test in NJ #4688 2022-10-26 17:33:10 -04:00
rusefi d1d81de060 adding simplicity 2022-10-26 12:10:54 -04:00
rusefillc e16c8f9120 Lua aux gauge #4672 2022-10-17 21:21:23 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 974f6f540d VVT minimum RPM fix #4545 2022-09-27 22:41:26 -04:00
rusefillc 1bfc6adac3 refactoring: renaming method 2022-09-27 22:21:18 -04:00
Matthew Kennedy 57a22fd713
gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 8ea31909a3
add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
Matthew Kennedy 87649b9f72
more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefi 2042d9b0b6 You would not believe how you invert TLE9201 #4579 2022-09-13 21:03:47 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey 0cf66762ad dead 2022-09-08 00:20:56 -04:00
Andrey 73a7b24871 remove alternator on/off mode fix #4548 2022-09-07 23:06:34 -04:00
Andrey dab9e04b25 remove alternator on/off mode fix #4548 2022-09-07 22:46:42 -04:00
Andrey b756456450 tear down Engine god object #4511
just trying different things
2022-09-05 04:00:24 -04:00
Andrey 48f960b581 Revert "tear down Engine god object #4511"
This reverts commit dc60837e4c.
2022-09-01 20:44:51 -04:00
Andrey dc60837e4c tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 5766b1eca6 tear down Engine god object #4511
just trying different things
2022-09-01 19:46:47 -04:00
GitHub gen-configs Action 81a73508b7 Auto-generated configs and docs 2022-08-31 23:10:02 +00:00
Matthew Kennedy bf85db1c9b
AC delay (#4502)
* AC delay

* changelog
2022-08-31 19:01:42 -04:00
GitHub gen-configs Action 886f62da3d Auto-generated configs and docs 2022-08-30 02:29:24 +00:00
Matthew Kennedy cbe70f8dec
idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 553b549b95
idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
Matthew Kennedy ca60dc17bb
trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
GitHub gen-configs Action 8b8ce329b3 Auto-generated configs and docs 2022-08-27 18:44:44 +00:00
Andrey G 9997bf95e0
output channels: isFuelPumpOn vs isPumpOn, remove second one (#4490) 2022-08-27 14:28:33 -04:00
Andreika c24712bed7
[DRAFT] Air by rpm taper (#4486)
* add rpm to getOpenLoop() and getRunningOpenLoop()

* implement airByRpmTaper

* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
GitHub gen-configs Action 06cc54057a Auto-generated configs and docs 2022-08-26 01:09:10 +00:00
Matthew Kennedy 65d7abc162
etb rev limit indicator (#4483) 2022-08-25 20:49:21 -04:00
GitHub gen-configs Action dd41e87877 Auto-generated configs and docs 2022-08-26 00:41:14 +00:00
Matthew Kennedy 016c9ecd4b
fix typo, move bit to idle state (#4484) 2022-08-25 20:26:12 -04:00
Andrey 3fe2c74730 docs 2022-08-25 19:58:15 -04:00
rusefillc 4f916edb27 yeah, not really refactoring 2022-08-21 01:11:09 -04:00
rusefillc 217e6218bf AddressSanitizer does not like "yeah, not really refactoring"? 2022-08-21 00:45:39 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
rusefillc ab11a57e33 yeah, not really refactoring 2022-08-21 00:32:10 -04:00
GitHub gen-configs Action 47e13297f6 Auto-generated configs and docs 2022-08-21 04:25:05 +00:00
rusefillc 21ab47ed04 Idle air add via Lua #4465 2022-08-21 00:18:32 -04:00
Matthew Kennedy 3e4965ea27
fix inverted vvt (#4464)
* fix inverted mode

* unit tests are great
2022-08-20 20:12:32 -04:00
GitHub gen-configs Action 2d9f734a8f Auto-generated configs and docs 2022-08-19 03:08:33 +00:00
rusefillc 602bf97c00 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 23:03:33 -04:00
rusefillc 2da7ed51f0 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 21:10:19 -04:00
rusefillc db8a965288 unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
GitHub build-firmware Action 2d7ab9f712 Auto-generated configs and docs 2022-08-10 05:44:46 +00:00
rusefillc c96b6b53f6 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-10 01:39:24 -04:00
Matthew Kennedy e9e6df6d7f
add option to invert vvt control (#4425)
* add option to invert vvt control

* s

* s

* s

* one bit per cam type

* move the space

* I don't spelling good

* changelog
2022-08-09 16:22:55 -04:00
rusefillc 97601f9292 VVT target to allow negative values fix #4424 2022-08-08 22:51:51 -04:00
Matthew Kennedy b6f1779781
implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
Matthew Kennedy 923d2c2e44
unexpected contains information about why it failed (#4393)
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
2022-07-28 10:04:28 +03:00
Matthew Kennedy 6b83ec8c08
boost control thresholds (#4392) 2022-07-28 09:45:16 +03:00
Matthew Kennedy d4b8a036af
Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
Matthew Kennedy b99d90b006
Start -> start (#4366) 2022-07-21 15:17:32 -04:00
Matthew Kennedy e1254f84b9
remove idle offset (#4355)
* remove offset

* remove more completely

* changelog
2022-07-18 15:49:43 -04:00
rusefillc 39df02fe35 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
GitHub build-firmware Action 7cada13589 Auto-generated configs and docs 2022-07-14 13:57:47 +00:00
rusefillc 7709b0f2a5 Detail on how to set up iDrive or equivalent CAN button control #226
was I drunk or something?
2022-07-14 09:41:36 -04:00
Matthew Kennedy 8bc01472b7
Add a timeout for Lua ETB adjustment (#4331)
* lua etb timeout

* mocks

* test
2022-07-10 05:46:28 +03:00
GitHub build-firmware Action 7764bf729a Auto-generated configs and docs 2022-07-08 05:14:15 +00:00
rusefillc a3c7e59b2a debug is set to idle mode, but none of the debug fields show anything #4335
better log names?
2022-07-08 01:05:48 -04:00
GitHub build-firmware Action 92eeceb5ed Auto-generated configs and docs 2022-07-08 04:29:21 +00:00
rusefillc eb3f93a730 debug is set to idle mode, but none of the debug fields show anything #4335
better names where user did not really ask for better names
2022-07-07 23:48:17 -04:00
GitHub build-firmware Action a145548ceb Auto-generated configs and docs 2022-07-02 08:21:19 +00:00
rusefillc 147724c984 https://github.com/rusefi/hellen154hyundai/issues/54 2022-07-02 04:06:09 -04:00
GitHub build-firmware Action 54a140d0df Auto-generated configs and docs 2022-07-02 07:55:19 +00:00
rusefillc 3858b1d720 https://github.com/rusefi/hellen154hyundai/issues/54 2022-07-02 03:49:49 -04:00
rusefillc 483395fa2e
https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
rusefillc 6c76a6468c logging of live data structs was: data points #3614
would this be more correct in terms of multi-threaded reads?
2022-06-29 03:33:06 -04:00
Andrey 5cf0265968 logging of live data structs was: data points #3614 2022-06-29 03:27:51 -04:00
rusefillc f262929226 logging of live data structs was: data points #3614 2022-06-29 03:14:39 -04:00
rusefillc 8acbf9d8df logging of live data structs was: data points #3614 2022-06-29 03:13:35 -04:00
rusefillc aab466094c logging of live data structs was: data points #3614 2022-06-29 03:01:13 -04:00
rusefillc 10d3afab9c well that was cute 2022-06-27 23:10:58 -04:00
rusefi b6544cccf0 less invalid default config 2022-06-26 23:47:42 -04:00
Matthew Kennedy 7e8ae7c8a3
Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
rusefi 1f7051db48 proteus pinout minor mess 2022-06-02 23:28:39 -04:00
rusefillc 2132cec3fc Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00
GitHub build-firmware Action 4e213fbc1e Auto-generated configs and docs 2022-05-09 09:42:49 +00:00
rusefillc 66f35b0b40 Remove value copy from controller into outputChannels #4095 2022-05-09 05:30:04 -04:00
rusefillc bcc50f0de3 proteus meta 2022-05-04 17:05:08 -04:00
Matthew Kennedy 1bbc9472b4 proteus meta 2022-05-04 17:00:38 -04:00
rusefillc 3b3f62b24f Make ETB low limit configurable fix #4119 2022-05-02 05:24:50 -04:00
Andrey f3b7e1ae25 Move curves out of engineConfiguration in order to reduce RAM usage fix #4127 2022-05-02 05:04:58 -04:00
Andrey e62877964a Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
Matthew Kennedy e4a0979dc2
Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
rusefillc 451b4a766c Three names of the same thing fix #4085 2022-04-19 19:47:43 -04:00
rusefillc bae4911838 https://github.com/rusefi/alphax-2chan/issues/50
more progress
2022-04-19 15:03:38 -04:00
rusefillc 7534d2a963 https://github.com/rusefi/alphax-2chan/issues/50
we have great CI
2022-04-19 13:57:39 -04:00
rusefillc 98eba617c2 https://github.com/rusefi/alphax-2chan/issues/50
sweet-sweet copy-pasta
2022-04-19 12:42:30 -04:00
rusefillc ae98105fdc https://github.com/rusefi/alphax-2chan/issues/50
refactoring: extract method
2022-04-19 12:40:02 -04:00
rusefillc e715bcc01f actually let's remove the duplicates 2022-04-18 11:43:49 -04:00
rusefillc e59ae35196 unique field names 2022-04-18 11:11:57 -04:00
GitHub build-firmware Action a2cff4ee12 Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc 82f608d558 one step sideways to fix build 2022-04-16 21:24:02 -04:00
rusefillc 08c50cc1dd logging of live data structs was: data points #3614
progress
2022-04-16 21:04:02 -04:00
rusefillc 70e4d118ef very random progress 2022-04-16 17:04:35 -04:00
rusefillc c023056d2d very random progress 2022-04-16 16:49:59 -04:00
rusefillc 0b21ddce9c random progress 2022-04-16 16:39:52 -04:00
rusefillc 084685c747 logging of live data structs was: data points #3614
ETB
2022-04-14 15:25:01 -04:00
rusefillc 16878487d5 logging of live data structs was: data points #3614
ETB
2022-04-14 14:38:32 -04:00
rusefillc 4834683dc6 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 413e636d4c typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc b776003989 do not control VVT during cranking fix #3443 2022-04-10 19:22:39 -04:00
rusefillc a90ca2b200 Hellen NB2 default tune #4038 2022-04-10 19:11:34 -04:00
rusefillc e1235c4f2e Air Conditioning Improvements #4054 2022-04-09 00:26:52 -04:00
GitHub build-firmware Action 6a403abf1f Auto-generated configs and docs 2022-04-09 01:37:21 +00:00
rusefillc ed6ed0d93e Air Conditioning Improvements #4054 2022-04-08 21:28:50 -04:00
GitHub build-firmware Action 3681d008e8 Auto-generated configs and docs 2022-04-08 16:21:15 +00:00