Commit Graph

847 Commits

Author SHA1 Message Date
rusefi 07beba9128 ETB auto-calibrate usability: both buttons should not be enabled at the same time #5061
random note
2023-02-13 00:56:54 -05:00
rusefi aca505e9e7 dead 2023-02-12 21:20:05 -05:00
rusefi e567b36f77 ETB gauges automation and progress 2023-02-12 21:15:45 -05:00
rusefi 0581ca2359 https://github.com/rusefi/rusefi/issues/5056 2023-02-12 20:12:26 -05:00
Matthew Kennedy 632cf9dd2d
remove useETBforIdleControl (#5054)
* remove useETBforIdleControl

* etb integrated

* jni weirdness
2023-02-12 16:49:12 -05:00
rusefi b32bda8275 reducing code duplication 2023-02-11 22:44:42 -05:00
rusefillc 5903b4526a fuck blind fix :( 2023-02-11 17:31:24 -05:00
rusefillc a262df4dc2 Antilag switch pin mode was ignored fix #5036 2023-02-07 10:05:17 -05:00
Matthew Kennedy 6e89e71d0a
more flexible GPPWM (#5032)
* gppwm improvements!

* test

* ui

* autoscale
2023-02-06 08:53:31 -04:00
rusefillc d1eb6d897f docs 2023-01-26 02:02:26 -05:00
rusefillc 728db11c56 Alternator Duty Cycle Adder for AC Fan fix #4973 2023-01-24 10:29:08 -05:00
rusefillc 92a4895b13 refactoring: inside the boost controller instead of depending on the engine god object 2023-01-22 07:40:42 -05:00
rusefillc 194caf1d9d h-bridge wastegate not alive on bench #4965
mmmmaybe fix?! overall total spaghetti :(
2023-01-17 14:22:56 -05:00
rusefillc 1be06f8d08 h-bridge wastegate not alive on bench #4965
life is sad when debugger is broken
2023-01-17 13:46:54 -05:00
rusefillc 64ecfd26ca h-bridge wastegate not alive on bench #4965
bugfix: not any DC is ETB :(
2023-01-17 13:13:46 -05:00
rusefillc 3702770292 h-bridge wastegate not alive on bench #4965
bugfix: not any DC is ETB :(
2023-01-17 04:14:30 -05:00
rusefillc 272014553e dead code 2023-01-17 03:38:45 -05:00
GitHub gen-configs Action 0456afa70a Auto-generated configs and docs 2023-01-17 04:04:05 +00:00
rusefillc e5d3831d8c h-bridge wastegate not alive on bench #4965
more live data
2023-01-16 22:57:36 -05:00
rusefillc e589ba629f h-bridge wastegate not alive on bench #4965
more live data
2023-01-16 22:46:51 -05:00
rusefillc 3738e8b3b9 h-bridge wastegate not alive on bench #4965
more live data
2023-01-16 21:13:54 -05:00
GitHub gen-configs Action 6fc0bbef4e Auto-generated configs and docs 2023-01-17 01:57:05 +00:00
rusefillc 3e81c82ff5 h-bridge wastegate not alive on bench #4965
more live data
2023-01-16 20:50:45 -05:00
GitHub gen-configs Action 41167a2c9e Auto-generated configs and docs 2023-01-16 21:31:45 +00:00
rusefillc 08e1874f00 h-bridge wastegate not alive on bench #4965
DC controller needs to be alive even if it's not serving ETB
2023-01-16 16:15:00 -05:00
rusefillc 69cfd619d0 docs 2023-01-16 16:14:01 -05:00
rusefillc 806b644b73 progress on boost logging and gauges 2023-01-16 16:10:14 -05:00
rusefillc f0b6dfa745 We really should decouple DC from ETB 2023-01-16 16:02:29 -05:00
rusefillc d649a8100f global variable bad 2023-01-16 16:01:48 -05:00
rusefillc fe61c4cdd3 docs 2023-01-16 15:53:06 -05:00
GitHub gen-configs Action abf83c1b05 Auto-generated configs and docs 2023-01-16 20:37:55 +00:00
rusefillc 0edd7c15fa h-bridge wastegate not alive on bench (Issue #4965) 2023-01-16 15:32:12 -05:00
GitHub gen-configs Action 6bfda5cb23 Auto-generated configs and docs 2023-01-10 21:35:32 +00:00
Matthew Kennedy 1eca0ca1bd
Jammed ETB detection (#4873)
* jammed ETB detection

* autoscale

* comment

* cleanup

* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey 93a3a07ed9 refactoring: already have the check inside 2023-01-03 21:17:32 -05:00
TurboMarian 64026b3d90 ALS UPDATE (ETB is working)
(cherry picked from commit decbf6d1615f1c15cc3e278932667a390d2539c9)
2022-12-26 19:21:18 -05:00
rusefillc 74e8291327 Add setBoostDutyAdd function to control only boost duty #4900 2022-12-19 12:05:06 -05:00
GitHub gen-configs Action dca3b46896 Auto-generated configs and docs 2022-12-19 16:58:49 +00:00
rusefillc d1876f67c3 Add setWgDutyAdd function to control only boost duty #4900 2022-12-19 11:43:44 -05:00
rusefillc 4e0eaf7e03 TurboMarian is the ALS boss 2022-12-17 19:39:36 -05:00
Andrey 748f97afeb kinetis asking for guard, also I've must have messed up something 2022-12-17 18:04:54 -05:00
rusefillc 2b4d58005b guards 2022-12-17 14:43:51 -05:00
rusefillc 18165e4b02 guards 2022-12-17 14:36:27 -05:00
rusefillc b3954122d6 TurboMarian is the ALS boss 2022-12-16 20:22:48 -05:00
Andrey ca10cf61d7 antilag and anti-lag #2403 2022-12-14 22:52:05 -05:00
GitHub gen-configs Action 42efd2c0fd Auto-generated configs and docs 2022-12-15 03:43:04 +00:00
Andrey 0b260b3e9f antilag and anti-lag #2403 2022-12-14 22:38:14 -05:00
rusefillc 5be4f3e38e Better ETB duty ROC length default #4859 2022-12-02 14:51:48 -05:00
GitHub gen-configs Action 5441e60c6b Auto-generated configs and docs 2022-12-01 03:35:46 +00:00
Matthew Kennedy 466833d95a
ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey 32e502c569 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey e6993aa248 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
Matthew Kennedy 65b459d461
live data objects evaluated at runtime (#4857)
* live data objects evaluated at runtime

* guard

* s
2022-11-30 19:29:22 -05:00
rusefi 4a68c321d3 ETB duty cycle jitter #4833
defaults
2022-11-30 17:09:28 -05:00
Andrey 4e74882c5e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
rusefi 1e7baa1089 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:39:55 -05:00
GitHub gen-configs Action 4a35b55634 Auto-generated configs and docs 2022-11-30 03:25:45 +00:00
rusefi b5049c8284 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-29 22:13:59 -05:00
Andrey 31a8a91f3b ETB duty cycle jitter #4833 2022-11-29 21:03:21 -05:00
Andrey 6ad3ce13d6 ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 3e6003f0ca refactoring: extracting method 2022-11-29 20:11:29 -05:00
Andrey 3070e1b3c8 ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 51ea23db68 ETB duty cycle jitter #4833 2022-11-29 12:39:47 -05:00
Andrey 607a5677d4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey cf63cea45f ETB JNI test progress 2022-11-29 02:21:36 -05:00
Andrey 4dd9217327 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey e6146d6ee5 unit test compile more of ETB code 2022-11-28 23:26:09 -05:00
Andrey aa46a00bfb unit test compile more of ETB code 2022-11-28 23:24:11 -05:00
Andrey c203685022 unit test compile more of ETB code 2022-11-28 23:22:08 -05:00
rusefillc 5596087481 ETB duty cycle jitter #4833 2022-11-28 20:33:04 -05:00
GitHub gen-configs Action 53b1cfff95 Auto-generated configs and docs 2022-11-29 01:18:34 +00:00
rusefillc 59c5587368 ETB duty cycle jitter #4833 2022-11-28 20:13:16 -05:00
rusefillc c596445477 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-28 14:38:39 -05:00
rusefillc b214f19701 6379d894fd (r91274056) 2022-11-28 13:53:51 -05:00
rusefillc 5ed7a7bf00 9e3b7fabfe (r91273278) 2022-11-28 11:34:42 -05:00
rusefillc 9e3b7fabfe ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 23:29:08 -05:00
GitHub gen-configs Action 740425611f Auto-generated configs and docs 2022-11-28 03:49:25 +00:00
rusefillc 2b9164b7a4 ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-27 22:34:27 -05:00
Andrey 768f776d4d ETB duty cycle jitter #4833 2022-11-27 21:50:09 -05:00
Andrey 61de170d06 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey b00a7e506b ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc 6379d894fd ETB duty cycle jitter #4833 2022-11-27 18:45:10 -05:00
GitHub gen-configs Action 74ea14b29e Auto-generated configs and docs 2022-11-27 23:28:40 +00:00
rusefillc 9321aae600 ETB duty cycle jitter #4833 2022-11-27 18:13:10 -05:00
rusefillc 8f0163273b docs 2022-11-27 00:27:29 -05:00
rusefillc e4372f1262 docs 2022-11-27 00:08:45 -05:00
rusefi 596fe6b64a minor clean-up 2022-11-26 21:53:31 -05:00
rusefi 3375648612 usability progress: conditional ETB button enable. TODO: make logic consistent with other instances of same buttons 2022-11-26 14:26:29 -05:00
rusefi 7af86c0d48 code reuse 2022-11-26 14:08:59 -05:00
rusefillc 2c18e7745b
etbStatus_error does the job (#4820)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:08:26 -05:00
GitHub gen-configs Action d64aaaf707 Auto-generated configs and docs 2022-11-23 01:42:21 +00:00
rusefillc 7e64b56690 trying to improve ETB logging 2022-11-22 20:20:45 -05:00
rusefillc 4beea9dc58 even if directly commanded ETB PWM should be logged it should be logged somewhere else 2022-11-22 20:16:54 -05:00
rusefillc a32531ee60 What is "Aux PID"? #4807 2022-11-21 00:10:35 -05:00
rusefillc 17fd8e53c3 What is "Aux PID"? fix #4807 2022-11-20 18:27:51 -05:00
rusefillc 4133fc2634 https://github.com/rusefi/alphax-4chan/issues/77 2022-11-20 16:42:44 -05:00
rusefillc 9f88281566 would need to stop the buzzing at PRI. 2022-11-15 11:01:56 -05:00
rusefillc 4cdc729d5c reducing confusion just a bit 2022-11-12 12:00:27 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey Gusakov f341385138 ETB: do not restart ETH thread on each doInitElectronicThrottle() 2022-11-06 09:26:40 -05:00
Matthew Kennedy 1269428044
remove idle timing deadzone (#4731)
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey Gusakov 6305606319 ETB: dead variable 2022-11-03 19:38:47 -04:00
Andrey Gusakov 1c4f437fad typo 2022-11-03 19:38:35 -04:00
Andrey Gusakov 8bb471c8a7 ETB: typo? 2022-11-03 19:38:14 -04:00
rusefi d6f8590cbf https://github.com/rusefi/rusefi/issues/4688#issuecomment-1301886167 2022-11-03 09:45:57 -04:00
rusefi 7e95c2c672 removing dead code - function never returns nullptr 2022-11-03 09:40:44 -04:00
GitHub gen-configs Action 523a6b9592 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 53649f73f1 Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
GitHub gen-configs Action c7ce2c2565 Auto-generated configs and docs 2022-10-30 21:55:22 +00:00
Andrey G cb7f592848
idle_state: rename useIacTableForCoasting -> isIacTableForCoasting (#4721) 2022-10-30 17:41:18 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 13c9de1c80 refactoring: helper method 2022-10-29 23:04:24 -04:00
rusefi f5abf3059a GM SENT ETB bench test in NJ #4688 2022-10-26 17:33:10 -04:00
rusefi d1d81de060 adding simplicity 2022-10-26 12:10:54 -04:00
rusefillc e16c8f9120 Lua aux gauge #4672 2022-10-17 21:21:23 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 974f6f540d VVT minimum RPM fix #4545 2022-09-27 22:41:26 -04:00
rusefillc 1bfc6adac3 refactoring: renaming method 2022-09-27 22:21:18 -04:00
Matthew Kennedy 57a22fd713
gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 8ea31909a3
add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
Matthew Kennedy 87649b9f72
more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefi 2042d9b0b6 You would not believe how you invert TLE9201 #4579 2022-09-13 21:03:47 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey 0cf66762ad dead 2022-09-08 00:20:56 -04:00
Andrey 73a7b24871 remove alternator on/off mode fix #4548 2022-09-07 23:06:34 -04:00
Andrey dab9e04b25 remove alternator on/off mode fix #4548 2022-09-07 22:46:42 -04:00
Andrey b756456450 tear down Engine god object #4511
just trying different things
2022-09-05 04:00:24 -04:00
Andrey 48f960b581 Revert "tear down Engine god object #4511"
This reverts commit dc60837e4c.
2022-09-01 20:44:51 -04:00
Andrey dc60837e4c tear down Engine god object #4511
just trying different things
2022-09-01 20:16:41 -04:00
Andrey 5766b1eca6 tear down Engine god object #4511
just trying different things
2022-09-01 19:46:47 -04:00
GitHub gen-configs Action 81a73508b7 Auto-generated configs and docs 2022-08-31 23:10:02 +00:00
Matthew Kennedy bf85db1c9b
AC delay (#4502)
* AC delay

* changelog
2022-08-31 19:01:42 -04:00
GitHub gen-configs Action 886f62da3d Auto-generated configs and docs 2022-08-30 02:29:24 +00:00
Matthew Kennedy cbe70f8dec
idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy 553b549b95
idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
Matthew Kennedy ca60dc17bb
trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
GitHub gen-configs Action 8b8ce329b3 Auto-generated configs and docs 2022-08-27 18:44:44 +00:00
Andrey G 9997bf95e0
output channels: isFuelPumpOn vs isPumpOn, remove second one (#4490) 2022-08-27 14:28:33 -04:00
Andreika c24712bed7
[DRAFT] Air by rpm taper (#4486)
* add rpm to getOpenLoop() and getRunningOpenLoop()

* implement airByRpmTaper

* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
GitHub gen-configs Action 06cc54057a Auto-generated configs and docs 2022-08-26 01:09:10 +00:00
Matthew Kennedy 65d7abc162
etb rev limit indicator (#4483) 2022-08-25 20:49:21 -04:00
GitHub gen-configs Action dd41e87877 Auto-generated configs and docs 2022-08-26 00:41:14 +00:00
Matthew Kennedy 016c9ecd4b
fix typo, move bit to idle state (#4484) 2022-08-25 20:26:12 -04:00
Andrey 3fe2c74730 docs 2022-08-25 19:58:15 -04:00
rusefillc 4f916edb27 yeah, not really refactoring 2022-08-21 01:11:09 -04:00
rusefillc 217e6218bf AddressSanitizer does not like "yeah, not really refactoring"? 2022-08-21 00:45:39 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
rusefillc ab11a57e33 yeah, not really refactoring 2022-08-21 00:32:10 -04:00
GitHub gen-configs Action 47e13297f6 Auto-generated configs and docs 2022-08-21 04:25:05 +00:00
rusefillc 21ab47ed04 Idle air add via Lua #4465 2022-08-21 00:18:32 -04:00