Daira Hopwood
14081efe9b
note-commit.md: formatting fix.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-09-01 15:57:10 +01:00
therealyingtong
4082ee615f
[book] sinsemilla.md: Correct constraint degrees.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-08-17 00:07:30 +08:00
therealyingtong
a72d4d3a7f
[book] note-commit.md: Update field element regions.
2021-08-13 12:22:51 +08:00
therealyingtong
8d7bf509f2
[book] note-commit.md: Update message piece decomposition gates.
2021-08-13 01:19:30 +08:00
parazyd
1b0a22096b
book: Fix rendering of cost-model output.
...
This should stop html tags appearing inside the <code> tags.
2021-07-31 15:24:50 +02:00
Daira Hopwood
b2e25b5ac3
[book] decomposition.md: avoid introducing `m` when we already have `range`.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 17:06:36 +01:00
ying tong
ee878ddc57
Merge pull request #162 from zcash/book-merge-lookups
...
[book] Merge lookup arguments for normal and short variants
2021-07-27 23:34:28 +08:00
ying tong
0bb4a7fd71
[book] decomposition.md: Formatting and phrasing fixes.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-27 23:29:11 +08:00
therealyingtong
ac5404a943
[book] note-commit.md: Update NoteCommit gate region layout.
...
By rearranging the pieces in the gate, we remove a prev() query and
preserve proximity between pieces involved in the same constraint.
2021-07-27 13:56:10 +08:00
therealyingtong
920fe64399
[book] note-commit.md: Document substitution of k_1 with z1_j.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-27 12:53:41 +08:00
Jack Grigg
9ef46ae4ee
book: Fixes to NoteCommit page
...
Noticed during review.
2021-07-27 05:34:36 +01:00
therealyingtong
65ff84da0a
[book] decomposition.md: Merge lookup arguments for normal and short variants.
2021-07-27 11:56:18 +08:00
Daira Hopwood
a6badba32f
[book] src/design/circuit/gadgets/ecc/var-base-scalar-mul.md: we always do addition (possibly of the zero point) at the end of variable-base scalar mul.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 02:01:21 +01:00
Daira Hopwood
7895a2a082
[book] src/design/circuit/gadgets/ecc/var-base-scalar-mul.md: more formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 02:01:05 +01:00
Daira Hopwood
3dfefe0e85
[book] src/design/circuit/gadgets/ecc/addition.md: correctness and clarity.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:51:37 +01:00
Daira Hopwood
3ed388e6bb
[book] src/design/circuit/gadgets/ecc/addition.md: formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:51:28 +01:00
therealyingtong
f1ccc58d9a
[book] note-commit.md: y-coordinate canonicity constraints.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-27 01:56:17 +08:00
ying tong
3833d665de
[book] Clarify upper bounds in canonicity shift constraints.
2021-07-26 12:05:25 +08:00
ying tong
14b8d9b048
[book] note-commit.md: 2^140 -> 2^130 in psi check.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-26 11:12:42 +08:00
ying tong
453681f309
[book] commit-ivk.md: Update region layout to use 9 advice columns.
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-26 11:09:47 +08:00
Jack Grigg
0375c64801
[book] Update NoteCommit page to match Commit^ivk style
...
Constraint tables have been added along with the region layout. I also
fixed numerous bugs in the constraints (most of which appeared to be
copy-pasta bugs).
2021-07-26 02:05:35 +01:00
Jack Grigg
5aa05713e7
[book] Use \CommitIvk macro in page heading
...
We can't use KaTeX on the SUMMARY page that generates the sidebar, so
that continues to use a CamelCase approximation.
2021-07-26 02:05:35 +01:00
Jack Grigg
f376a61bb8
[book] Add macros, constraint tables, and region layout to Commit^ivk
...
I also merged in content from a page I wrote independently while
reviewing the Action circuit PR, and made various cleanups to the
Markdown source.
2021-07-26 02:05:35 +01:00
Daira Hopwood
4a5a4cc437
[book] merkle-crh.md: formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-26 02:05:35 +01:00
Daira Hopwood
ed20d539b2
[book] merkle-crh.md: corrections.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-26 02:05:35 +01:00
Daira Hopwood
47a29f10aa
[book] Document NoteCommit message decomposition & canonicity checks
2021-07-26 02:05:35 +01:00
Daira Hopwood
2846593937
[book] Document CommitIvk message decomposition & canonicity checks
2021-07-26 02:05:35 +01:00
Daira Hopwood
9708e296c8
[book] Document Merkle chip layout and message decomposition.
2021-07-26 02:05:35 +01:00
therealyingtong
5dc5e6479a
[book] Recombine Sinsemilla q_S1, q_S2, q_S3 selectors.
...
Since q_S1, q_S2, q_S3 are not simple selectors, they cannot be
automatically combined. We manually combine them here.
2021-07-25 20:28:05 +08:00
ying tong
a2ed3f1b52
Merge pull request #155 from zcash/book-selector-optimisations
...
[Book] Undo selector optimisations
2021-07-25 00:57:35 +08:00
ying tong
3d56fb0716
Merge pull request #146 from zcash/book-short-scalar-mul
...
[book] Update constraints for short signed fixed-base mul.
2021-07-25 00:54:32 +08:00
therealyingtong
782a70a786
[book] Minor fixes.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-25 00:52:38 +08:00
ying tong
ce881bc4fe
[book] Formatting fix.
2021-07-25 00:40:44 +08:00
therealyingtong
78b0ec4e7b
[book] Sinsemilla: reintroduce fixed_y_q column.
...
Loading fixed_y_q into an advice column introduces an additional
row. Instead, we load it into a fixed column.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-24 23:15:17 +08:00
ying tong
6c55e1a7e3
[book] Fix updates to Sinsemilla writeup.
2021-07-23 20:34:16 +08:00
therealyingtong
7866623a1b
[book] Undo selector optimisation in variable-base scalar mul
...
Previously, we were using a non-binary selector q_mul = {1, 2, 3}
to switch between three cases. Now, we replace this with three
binary selectors.
2021-07-22 22:39:17 +08:00
therealyingtong
c5cda9481d
[book] Undo selector optimisations in Sinsemilla
...
- Instead of defining a synthetic q_S3 based on a combination of
of q_S1, q_S2, we simply create another selector q_S3.
- Instead of using fixed_y_q as a nonbinary selector, replace it
with q_S4 and copy the fixed value into a row above.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-22 22:19:01 +08:00
ying tong
c23897ea8d
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-19 19:01:06 +08:00
Daira Hopwood
20c347b269
Merge pull request #320 from daira/book-zk-changes
...
[Book] Zero knowledge changes (and misc cleanups)
2021-07-12 20:35:20 +01:00
Daira Hopwood
43ffa37740
[book] Nullifiers: the scalar is (...) mod p, not ... (mod p).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 20:24:18 +01:00
Daira Hopwood
c76358769c
book/src/design/nullifiers.md: cosmetics (make the table fit).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 20:20:00 +01:00
Daira Hopwood
103c93391d
Clarify the statement about the δ^i being distinct quadratic non-residues.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 17:24:21 +01:00
therealyingtong
2dd23f47b8
[book] Update constraints for short signed fixed-base mul.
...
Previously, we witnessed the magnitude of a short signed scalar
directly as three-bit windows. Now, we decompose and range-constrain
it using a running sum.
2021-07-12 11:58:32 +08:00
Daira Hopwood
8ac20608e4
Merge branch 'kw-halo-book' into book-zk-changes
...
Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:32:36 +01:00
Daira Hopwood
06ff90ba95
Rename UPA to PLONKish.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:12:58 +01:00
Daira Hopwood
6a11c2b97e
Update the circuit commitments section for the changes to the permutation argument.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood
1b3241d757
Clarify product argument and add a diagram.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:03:41 +01:00
Daira Hopwood
fedcc1960d
Permutation argument cosmetics.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
69ca38d2b1
Update permutation argument for zero knowledge changes in #316 .
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
25b42a531d
Follow https://github.com/zcash/halo2/pull/316 and https://github.com/zcash/orchard/issues/143
...
in using 1 - Z(X) instead of Z(X) - 1.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
0dbf7cf4af
Match the order of q_last and q_blind in the implementation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
5deb3fcd72
Lookup argument cosmetics.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Daira Hopwood
55c48007c9
Update lookup argument for zero knowledge changes in #316 .
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-07-12 02:01:39 +01:00
Jack Grigg
5fe6323a8d
book: Add note about efficient FFTs for Pallas and Vesta
2021-07-09 19:53:41 +01:00
Jack Grigg
fe4996af35
book: Add a note about the multiplicative subgroups we use for Halo 2
2021-07-09 17:48:43 +01:00
Jack Grigg
9f77c93d4e
book: Fix definition of the nth roots of unity
2021-07-09 17:48:03 +01:00
therealyingtong
d9f134ac4b
[book] Details and formatting changes.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-09 10:09:10 +08:00
ying tong
2febafbdfe
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-08 16:40:44 +08:00
therealyingtong
afc8d9a142
[book] Eliminate alpha_0 lookup decomposition when checking canonicity of base field element used in fixed-base mul.
2021-07-08 11:12:13 +08:00
therealyingtong
091592e110
[book] Document canonicity check for fixed-base scalar mul when base field element is used as the scalar.
2021-07-07 17:10:18 +08:00
therealyingtong
32f9622c23
[book] Document lookup range check and its use in overflow check.
2021-07-03 19:30:27 +08:00
ying tong
6479598b27
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-07-03 18:37:35 +08:00
therealyingtong
2b4d9fda49
[book] Correct q_mul = 3 case.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-02 22:44:01 +08:00
therealyingtong
1a531cf619
[book] Correct hi and lo ranges in constraint table
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-02 21:41:31 +08:00
therealyingtong
802334892d
[book] Constrain first and last rows in incomplete addition secton of variable-base scalar mul.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-02 17:28:33 +08:00
therealyingtong
902dbbb700
[book] Fix window table sum expression in fixed-base scalar mul.
...
Co-authored-by: Jack Grigg <jack@electriccoin.co>
2021-07-02 16:43:29 +08:00
therealyingtong
68acc33cae
[book] Document overflow check for variable-base scalar mul.
2021-07-02 00:18:27 +08:00
str4d
d5f3256785
Merge branch 'main' into book-ecc-gadget
2021-07-01 13:47:30 +01:00
str4d
6c34956c18
book: Remove superfluous checkmarks
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-07-01 13:46:48 +01:00
therealyingtong
69e7fb8221
[book] Fix Sarkar square root explanation
2021-06-30 19:31:23 +08:00
Daira Hopwood
3543bab39d
Merge pull request #82 from zcash/book-sinsemilla-gadget
...
[book] Add Sinsemilla gadget description
2021-06-20 01:07:58 +01:00
Daira Hopwood
9adeead975
[book] Make the order of advice columns for Sinsemilla the same as in the code.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-19 15:35:34 +01:00
Daira Hopwood
9dc909e842
[book] Formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-19 13:37:07 +01:00
Daira Hopwood
2a8fe30fa8
[book] Clarify that x_Q, z_0, z'_0, etc. are copied in using equality constraints.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-19 13:32:11 +01:00
Daira Hopwood
48573705dc
[book] Adjust the definition of m_{i+1} so that the last z_n does not need to be constrained to 0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-19 08:53:41 +01:00
Daira Hopwood
22036e9f41
[book] More formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-18 22:49:46 +01:00
Daira Hopwood
aac10b816f
[book] Formatting.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-18 22:45:50 +01:00
Daira Hopwood
dc021a2ef1
[book] Merge two similar paragraphs.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-18 22:20:09 +01:00
Daira Hopwood
82316b607b
[book] Update the Sinsemilla constraints to handle the gap between field elements correctly.
...
This also changes i to be zero-based, which is more consistent with the spec.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-06-18 22:12:48 +01:00
Daira Hopwood
4cd0082294
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-06-18 21:27:55 +01:00
therealyingtong
beaf4490f1
sinsemilla.md: Correct y_{A,i} and y_{P,i} formulas in gate specification
2021-06-14 21:30:51 +08:00
therealyingtong
ab454f4fb2
[book] commitment-tree.md: Update Uncommitted^Orchard from 0 -> 2.
2021-06-11 18:45:25 +08:00
therealyingtong
1ea8397a7c
variable-base-scalar-mul.md: Disable book tests.
2021-06-09 18:44:57 +08:00
ying tong
f46a2a4c40
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-06-09 18:31:06 +08:00
therealyingtong
02a732b921
fixed-base-scalar-mul.md: Include G^{Orchard} fixed base
2021-06-09 18:27:34 +08:00
therealyingtong
ab96225f0f
ecc::addition.md: Update complete addition constraints.
...
Add constraint analysis and proofs of completeness and soundness.
2021-06-09 18:23:02 +08:00
therealyingtong
6edfa579be
sinsemilla.md: Update comments about lookup degree.
2021-06-09 15:14:44 +08:00
ying tong
a40030750c
Add references to protocol spec.
2021-06-09 14:59:16 +08:00
ying tong
191a3c6304
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-06-09 14:48:12 +08:00
Jack Grigg
7379e96a70
book: Use M for number-of-circuit-instances in proof encoding
2021-06-01 17:26:00 +01:00
Jack Grigg
9a7f331f1b
book: Document k constant in proof encodings
2021-06-01 14:05:33 +01:00
Jack Grigg
4b362669e4
book: Document encoding of proofs
...
Closes zcash/halo2#144 .
2021-05-28 02:21:58 +01:00
Jack Grigg
081e353681
book: Move implementation notes about proofs into a subsection
2021-05-28 01:13:20 +01:00
str4d
e4072e78ce
Merge pull request #234 from zcash/book-point-addition
...
[book] Point addition and compression background
2021-05-27 22:37:06 +01:00
str4d
36cd8633e2
book: Adjustments to point addition and compression sections
2021-05-27 18:43:24 +01:00
str4d
15c79bcd89
Merge pull request #260 from zcash/book-chip-refactor
...
[book] Remove core/chip abstraction
2021-05-27 18:23:25 +01:00
therealyingtong
79b0307b87
Formatting fixes
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-05-27 13:59:15 +08:00
therealyingtong
e2ac3715f1
Explain (k+2) offset in fixed-base window formulae
2021-05-27 13:33:06 +08:00
therealyingtong
12feacf417
Fix complete addition constraints
2021-05-25 14:07:36 +08:00
therealyingtong
2699703b02
Update fixed-base window formulae
2021-05-25 00:20:18 +08:00
therealyingtong
58e3da88c2
Document point doubling constraints
2021-05-23 10:26:55 +08:00
ying tong
cdea8b1f67
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-05-22 22:55:14 +08:00
str4d
9585c67ed2
book: Refine types on Commitments page
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-05-21 21:23:08 +01:00
therealyingtong
1a08d6e078
[book] Add Sinsemilla gadget description
2021-05-21 21:13:45 +08:00
ying tong
0903ae23e7
Use correct symbol in incomplete addition section
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-05-21 17:43:08 +08:00
Jack Grigg
7cb2e6a954
book: Fix CI failure
2021-05-18 20:19:31 +01:00
Jack Grigg
a1c067e555
book: Add page describing developer tools
2021-05-18 14:51:54 +01:00
Jack Grigg
d0c16910d6
book: Document why ivk != 0
2021-05-11 19:14:52 +12:00
therealyingtong
dd32a962b8
Remove core/chip abstraction
...
We now directly compose chips in a hierarchy.
2021-05-06 20:21:16 +08:00
therealyingtong
1e0c644a81
Detail optimised variable-base scalar mul
2021-05-06 20:02:19 +08:00
ying tong
e881b19b6a
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-04-23 22:03:04 +08:00
therealyingtong
b4c3805e22
Address further review comments.
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2021-04-22 17:39:27 +08:00
ying tong
33b4192c0d
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <jack@electriccoin.co>
2021-04-22 17:10:33 +08:00
str4d
632fa8dcf2
Merge pull request #68 from daira/daira-nullifiers
...
[Book] Update nullifier explanation to include Extract_P
2021-04-22 05:50:01 +01:00
Daira Hopwood
18bc70afa2
[Book] Explain the decision to exclude zero points and scalars for KA.Orchard. fixes #62
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-21 18:38:25 +01:00
Daira Hopwood
f5bab61f81
Update nullifier explanation to include Extract_P.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-04-21 18:25:31 +01:00
therealyingtong
96d60b3f13
Move addition sections into ecc.rs
2021-04-17 12:53:10 +08:00
ying tong
cd809c57dc
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-04-09 16:53:35 +08:00
ying tong
137066e056
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-04-09 16:51:14 +08:00
therealyingtong
d7b88addd9
[book] Point compression background section
2021-03-30 04:29:35 +08:00
therealyingtong
c3c80cd0a1
[book] Point addition background section
2021-03-29 23:08:56 +08:00
therealyingtong
c074990bb9
[book] Document ECC gadget in circuit
2021-03-29 14:01:05 +08:00
Daira Hopwood
0191fa0a47
Orchard book: minimal description of unified addresses.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-27 17:08:39 +00:00
Daira Hopwood
532e5eb11c
Fixed columns are not necessarily selector columns.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:38 +00:00
Daira Hopwood
25616616e3
"Copy constraints" -> "equality constraints". (There were no other uses of this terminology.)
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:14:12 +00:00
Daira Hopwood
2f34318510
Fix mistaken use of "extended domain" in the permutation argument section, and improve wording.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:13:11 +00:00
Daira Hopwood
8fbf20beae
The algorithm for constructing the permutation needs to update the sizes array when merging cycles.
...
Thanks to @porcuquine for spotting this. (The implementation is correct.)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-03-24 20:06:09 +00:00
Jack Grigg
2f21135e68
book: Note that none of the documented gadgets have been reviewed
2021-02-25 20:05:19 +00:00
Jack Grigg
668bd8e89a
book: Tidy up Sarkar explanation and make adjustments for clarity
2021-02-23 14:01:47 +00:00
Jack Grigg
b2d91140e7
book: Move Sarkar explanation into implementation section
2021-02-23 14:01:47 +00:00
ebfull
2e8af8f0ca
Merge pull request #198 from zcash/book-sarkar
...
[book] Add Sarkar sqrt explanation to Fields section
2021-02-22 16:39:23 -07:00
Jack Grigg
6717594c46
book: Render gtab and invtab as matrices
2021-02-19 01:13:16 +00:00
therealyingtong
b148c34c10
[book] Add Sarkar sqrt explanation to Fields section
2021-02-19 00:21:05 +00:00
Daira Hopwood
e2f20770bb
Edits from pairing with @str4d. This fixes an error in Z_P for the equality constraint argument,
...
and also errors in the circuit commitments section.
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-18 23:27:42 +00:00
Daira Hopwood
ad771f89cb
Book: improve the section explaining the permutation argument.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 21:26:39 +00:00
Daira Hopwood
a73560c842
Book: cosmetics and minor corrections / wording improvements.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:10:11 +00:00
Daira Hopwood
07af9ea3e7
Book: generalize input columns to expressions in lookup argument.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-17 17:09:10 +00:00
str4d
c10b84ce13
Merge pull request #187 from zcash/book-fixes
...
Book fixes
2021-02-17 06:53:10 +13:00
str4d
e1a3cc5e9e
book: Evaluation points are elements of fields, not groups
...
Polynomials require both addition and multiplication, which fields have, whereas a group only specifies a single operation.
2021-02-17 06:46:28 +13:00
Daira Hopwood
c769dd0fa6
Address @str4d's review comment about advice and instance columns being treated almost identically.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-15 15:08:29 +00:00
Jack Grigg
ba9917e35c
book: Linkify URLs in references
2021-02-15 14:38:46 +00:00
Jack Grigg
cf68b5ba05
book: Clarify meaning of "evaluation point" in our context
...
Polynomial evaluation points and elliptic curve points are both things
we rely on, but never in the same context (we either use elliptic curve
points inside circuits, or implement proving systems on top of them).
2021-02-15 14:30:12 +00:00
Daira Hopwood
760d69bd2c
Rename "auxiliary column" to "instance column" in the book and in code. fixes #181
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2021-02-14 21:09:49 +00:00
Jack Grigg
4739aaae5c
book: Clarify IPA inputs in tl;dr section
2021-02-12 16:05:44 +00:00
Jack Grigg
126abd151c
book: Clarify why fixed columns are shown separately in commitments
2021-02-12 15:30:48 +00:00
Jack Grigg
67b6d197aa
book: Tweak wording for proving system stage 1 commitments
2021-02-12 15:18:12 +00:00
Jack Grigg
576796037a
book: Move lookup argument design page to have consistent URI
2021-02-12 15:15:05 +00:00
Jack Grigg
7820083c0d
book: Reword paragraph about degree of relation polynomials
2021-02-12 15:13:16 +00:00
Jack Grigg
3181a21cba
book: Add beta and gamma requirements for lookup permutation product
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-02-12 15:08:00 +00:00
Jack Grigg
2c647009fc
book: Fix notation for committing to lookup permutation product columns
2021-02-12 15:06:33 +00:00