Commit Graph

3964 Commits

Author SHA1 Message Date
rusefi 36ec3fd38e docs 2019-12-13 18:05:08 -05:00
rusefi 9403b2a8fc fixing build is my most favourite time! 2019-12-13 18:02:24 -05:00
Matthew Kennedy 003c1c17f0 Make stacks smaller (#1055)
* remove factually incorrect comment

* shrinky stacky

* shuffle comments
2019-12-13 16:47:26 -05:00
rusefi 236d952335 progress towards ETB controller mocking 2019-12-13 13:52:34 -05:00
rusefi e9e7a66cf8 etbActualCount logic to handle the scenario where only one ETB is present 2019-12-13 12:50:34 -05:00
rusefi af4f20551b getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi 97b1c1ff33 straightening enum reuse 2019-12-10 21:18:35 -05:00
Matthew Kennedy 0e674f7eca ETB Encapsulation & C++ Conventions (#1049)
* encapsulate etb stuff, c++ conventions

* remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE

* reduce include dependencies

* Revert "reduce include dependencies"

This reverts commit c529bbbf757cd9070f6e00616f84b1229eeb768e.

* Revert "remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE"

This reverts commit ca98b18cd4dae24b993d1263a18daf509dcd54b9.
2019-12-10 19:37:04 -05:00
Matthew Kennedy 00840d99ec copyArray helper (#1048)
* add functions

* uses

* use for proteus

* do it for warmup mult

* do it for cranking settings

* cleanup
2019-12-10 18:04:50 -05:00
rusEfi 1cc71ef8ec dual-ETB progress 2019-12-10 00:07:46 -05:00
rusefi 62481d7fe8 The Big Refactoring of 2019: folder structure #723 2019-12-08 13:21:35 -05:00
rusefi cf8c6e7eca The Big Refactoring of 2019: folder structure #723 2019-12-08 13:09:51 -05:00
rusefi c5cfd21a70 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi 0555d2170d TPS#2 calibration & fixing ETB in TS 2019-12-08 00:37:33 -05:00
rusefi 23c0d8646f Making UART/TTL pins configurable 2019-12-07 21:22:09 -05:00
rusefi d6471a84bc Refactor Trigger System #635
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
rusefi 717abd6b67 Refactor Trigger System #635
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
rusefi 28a12d9d04 typo 2019-12-06 00:07:27 -05:00
rusefi c0450ebd9b following the pattern 2019-12-04 07:33:56 -05:00
rusefi 5055797f6b The Big Refactoring of 2019: folder structure #723 2019-12-04 01:15:52 -05:00
rusefi 813b6aa6ce The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
rusefi d81c783391 The Big Refactoring of 2019: folder structure #723 2019-12-04 00:57:54 -05:00
rusefi 0428ff4347 gen_config run 2019-12-04 00:38:40 -05:00
rusefi 302b336186 Merge branch 'master' of https://github.com/rusefi/rusefi 2019-12-04 00:37:53 -05:00
andreika-git 2a39c69f51 iacPidMultTbl + EFI_IDLE_PID_CIC + kinetis_hysteresis (#1043)
* rename EFI_IDLE_INCREMENTAL_PID_CIC -> EFI_IDLE_PID_CIC

* Impl. IacPidMultTable

* Kinetis: Trigger Comparator Hysteresis settings (+adaptive mode)
2019-12-04 00:37:32 -05:00
rusefi f6a50b7375 The Big Refactoring of 2019: folder structure #723 2019-12-04 00:35:05 -05:00
rusefi de36f76882 The Big Refactoring of 2019: folder structure #723 2019-12-03 23:52:44 -05:00
rusefi 500315b042 refactoring - updating name according to new reality 2019-12-03 14:39:11 -05:00
rusefi c4027a29f0 codes fix, thank you AndreiKA 2019-12-03 09:05:57 -05:00
rusefi eb305f0265 #490 2019-12-03 00:29:12 -05:00
rusefi bec88bf8c8 EngineTestHelper progress 2019-12-03 00:20:47 -05:00
Matthew Kennedy 9fdf74bc18 Base configuration for Proteus (#1040)
* cfg

* add enum value

* add ci

* actually build the board config

* this is pretty close

* proteus case
2019-12-02 23:54:40 -05:00
Matthew Kennedy 3008e19110 missing override (#1039) 2019-12-02 23:52:35 -05:00
rusefi 1c96d9541e refactoring 2019-12-02 23:08:18 -05:00
rusefi d007a7f902 making new scheduling API avalable 2019-12-02 22:28:32 -05:00
rusefi 6555e4b305 "sensor chart" for aux fast analog input 2019-12-02 20:31:49 -05:00
rusefi 12a828b391 codes clean-up 2019-12-02 20:16:41 -05:00
rusefi 2eab39d3ff auxFastSensor 2019-12-02 17:49:01 -05:00
rusefi 0583fd0b6c misc clean-up 2019-12-02 10:03:50 -05:00
rusefi 1d817e9768 dual throttle re-init bugfix thank you andreika! 2019-12-01 09:39:34 -05:00
rusefi 3ed889486e making things nicer with dual ETB settings 2019-11-30 17:38:33 -05:00
rusefi b961edc654 refactoring 2019-11-30 16:49:40 -05:00
rusefi b04166d173 that's how we can move all fields one by one from boardConfiguration to engineConfiguration
my approach is to move fields from the bottom of BC struct
2019-11-30 10:24:37 -05:00
rusefi f80fe51092 all ETBs to run in same HW mode 2019-11-30 01:00:54 -05:00
rusefi 5fa7e082c8 all ETBs to run in same HW mode
taking a step back and going to bed :(
2019-11-30 00:39:00 -05:00
rusefi 2952cd923e all ETBs to run in same HW mode 2019-11-30 00:25:33 -05:00
rusefi a78dc22bf1 better state validation, better error codes 2019-11-29 23:41:26 -05:00
rusefi ff3fbffd80 extracing constant & more information for HW CI 2019-11-29 21:57:59 -05:00
rusefi 73e3edc3d8 dual ETB seems to work! 2019-11-29 20:15:29 -05:00
rusEfi e2074388ff dual ETB seems to work! 2019-11-29 19:06:50 -05:00
rusefi 76ca1aacb7 all ETBs to run in same HW mode 2019-11-29 19:02:12 -05:00
rusEfi 799027c2e9 all ETBs to run in same HW mode 2019-11-29 16:51:51 -05:00
rusefi 1ab40aec35 one step backwards :) 2019-11-29 01:39:02 -05:00
rusEfi fb53d2e921 v12 2019-11-29 01:35:45 -05:00
rusefi 316d7ab63b steps towards dual ETB 2019-11-29 00:26:17 -05:00
rusefi 784610c5c3 steps towards dual ETB 2019-11-29 00:23:15 -05:00
rusefi 07f71c8dfa steps towards dual ETB 2019-11-28 15:24:30 -05:00
rusefi 067aa0aeee steps towards dual ETB 2019-11-27 22:07:36 -05:00
andreika-git 1808642af1 Starter relay + Hardcoded 'FSIO' + simulator fix (#1032)
* Starter Relay: gui + built-in FSIO impl.

* Hardcoded 'FSIO' replacement for RAM-limited boards

* fix simulator
2019-11-25 20:08:01 -05:00
rusefi 8a8a398c70 starterRelayPinMode 2019-11-25 01:01:00 -05:00
rusefi 9df259fbfb starterRelay & debugMapAveraging 2019-11-25 00:59:05 -05:00
andreika-git 9a0b66791b unregisterOutput() + isPinOrModeChanged() + Stepper::stepPin+enablePin + Kinetis fix (#1029)
* Fix isConfigurationChanged() for EFI_ACTIVE_CONFIGURATION_IN_FLASH

* unregisterOutput() -> unregisterOutputIfPinOrModeChanged()

* clutchUpPinMode for unregisterPin()

* Fix Kinetis: EFI_ACTIVE_CONFIGURATION_IN_FLASH & EFI_MAIN_RELAY_CONTROL

* Stepper: enablePin & stepPin with modes support
2019-11-25 00:02:53 -05:00
rusefi 4411efbb72 firing order tool integration 2019-11-24 23:49:05 -05:00
rusefi 366805a1ab MapAveragingCallback schedules all cylinders at once #974 2019-11-24 23:20:24 -05:00
rusefi cfcfc851f5 Sporadic error: FATAL error: handleCycleStart #1030
more details
2019-11-24 21:45:32 -05:00
rusefi 04f6913d56 MapAveragingCallback schedules all cylinders at once #974
saving pennies
2019-11-24 20:48:25 -05:00
rusefi 730df561df pausing aux work for now 2019-11-24 12:45:38 -05:00
rusefi 6f50cae286 improving API? 2019-11-24 00:15:44 -05:00
rusefi 1cb2f92142 more correct variable names 2019-11-23 23:49:39 -05:00
rusefi 8b34fbee38 docs 2019-11-23 23:42:00 -05:00
rusefi 7ee657d238 aux valves unit test 2019-11-23 22:55:21 -05:00
Matthew Kennedy 2460a309ae Make sure #798 is good and dead (#1028)
* Revert "CI instability: FATAL error: warn stream not initialized for 6039 - maybe buffer overrun? #798"

This reverts commit ee674dc979.

* Revert "CI instability: FATAL error: warn stream not initialized for 6039 #798"

This reverts commit 3bf29b6963.

* fix correctly

* use correct function
2019-11-23 21:25:29 -05:00
rusefi af60a46229 making progres on angle-based scheduling 2019-11-23 20:36:40 -05:00
rusefi 1bb3f2698c making progres on angle-based scheduling 2019-11-23 19:47:53 -05:00
rusefi 7b7b46a2a2 refactoring 2019-11-23 18:38:16 -05:00
rusefi 4305b4ce2f not needed since included in common_headers.h 2019-11-23 18:16:41 -05:00
rusefi f0c4817e1b 'triggerEventAngle' not really needed 2019-11-23 17:44:44 -05:00
rusefi 3bf29b6963 CI instability: FATAL error: warn stream not initialized for 6039 #798 2019-11-23 17:07:13 -05:00
rusefi aa4967383a explicit list field to simplify code navigation 2019-11-23 17:04:51 -05:00
rusefi ee674dc979 CI instability: FATAL error: warn stream not initialized for 6039 - maybe buffer overrun? #798 2019-11-23 16:41:59 -05:00
rusefi 56ff75004b consistency 2019-11-23 15:53:22 -05:00
rusefi e706c999f1 docs 2019-11-23 14:14:17 -05:00
rusefi 91a5bd5ce3 refactoring: extracting constant 2019-11-23 12:52:57 -05:00
rusefi 8edf6c8d38 bug: aux valve actions can overlap 2019-11-23 10:34:43 -05:00
Matthew Kennedy 9ee8616cb0 Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusEfi 547d9749df v12 and minor ETB 2019-11-22 23:27:03 -05:00
Matthew Kennedy 579219e8cc inject interfaces to ETB, renaming (#1026)
* inject interfaces, renaming

* format

* null check

* that was a dumb typo

* fix indent
2019-11-22 20:53:54 -05:00
rusefi c606bb27ac aux overlap debugging 2019-11-22 18:50:46 -05:00
Matthew Kennedy bb22296f61 DC motor improvements (#1025)
* extract interface, comments, conform names

* fwd declare
2019-11-22 16:30:44 -05:00
rusefi 4faca85fdd following the pattern 2019-11-21 13:35:57 -05:00
rusEfi f9ccaf5f01 steps towards dual ETB 2019-11-21 00:49:38 -05:00
rusefi a5db4819ae making more code testable 2019-11-20 08:46:54 -05:00
rusefi a7b7fd1005 making more code testable 2019-11-20 02:18:17 -05:00
rusefi b8ce0daf85 more code into unit tests 2019-11-20 01:42:03 -05:00
rusefi ad7e36c228 refactoring 2019-11-20 01:35:08 -05:00
rusefi d3da33517f making F4 and else happier with perf_trace, also maybe missing 'break'? 2019-11-19 20:36:47 -05:00
rusefi 3af49796a5 Merge remote-tracking branch 'remotes/mck1117/perf-tracing'
# Conflicts:
#	firmware/development/development.mk
2019-11-19 20:26:56 -05:00
rusEfi 1991437f77 development into unit tests, makefile cleanup 2019-11-19 20:05:12 -05:00
Matthew Kennedy 93d24dfc0b Merge remote-tracking branch 'origin/master' into perf-tracing 2019-11-19 16:28:58 -08:00
rusefi 7dfdfc6378 docs & code formatting 2019-11-19 18:17:03 -05:00
rusefi 1d328c17e8 simulation docs 2019-11-19 09:23:25 -05:00
rusefi 67b434e43a v12 2019-11-18 23:45:35 -05:00
rusEfi 36dba6274a ETB docs 2019-11-18 22:25:07 -05:00
rusEfi a55e0e1460 launch control #203 2019-11-18 19:22:29 -05:00
rusefi fc41aaf655 v12 2019-11-17 22:32:27 -05:00
rusefi ebe6a4b981 v12 done right 2019-11-17 09:32:12 -05:00
rusefi 1f1f7e86ae typo 2019-11-17 09:18:43 -05:00
rusefi 6b3b090eea refactoring: reducing complexity? 2019-11-17 09:02:49 -05:00
rusefi 6456374eb8 v12 2019-11-16 16:00:50 -05:00
rusEfi c3b793fc55 prometheus cleanup 2019-11-15 00:01:03 -05:00
rusEfi 81167d9945 #pragma once 2019-11-15 00:00:13 -05:00
rusEfi 3530c68a18 M73 2019-11-14 23:58:04 -05:00
rusefi b8007d8cd5 poke 2019-11-14 10:23:11 -05:00
rusefi 11838a7558 docs 2019-11-13 22:47:49 -05:00
rusefi 3dbecfc2f0 todo 2019-11-13 22:02:13 -05:00
rusefi 9fd45aea19 micro-optimization: replacing by-referece access with direct static access for real firmware 2019-11-13 21:43:24 -05:00
rusefi d318b46d33 unused code 2019-11-13 20:15:02 -05:00
Matthew Kennedy 8969efaffe fix (#1005) 2019-11-13 08:42:16 -05:00
rusefi c9b994ba0d Revert "restoring #1003"
This reverts commit 08940cc6
2019-11-12 23:18:48 -05:00
rusefi 08940cc6c0 restoring #1003 2019-11-12 22:17:29 -05:00
rusefi 4b1c1e72ab time to panic and revert more 2019-11-12 21:42:44 -05:00
rusefi 0af0190468 what's the probability of efi::size breaking build? 2019-11-12 19:40:33 -05:00
rusefi e6abba09a9 refactoring: time to unify digital pin API
trying to fix build
2019-11-12 19:04:33 -05:00
Matthew Kennedy 0570ef4c42 Fix (#1004)
* Revert "fixing build"

This reverts commit 22da8a7dfe.

* undo overzealous ifdef cplusplus
2019-11-12 01:13:13 -05:00
rusefi 22da8a7dfe fixing build 2019-11-12 00:50:30 -05:00
Matthew Kennedy 9ce18d11fe use static asserts (#1003) 2019-11-12 00:39:38 -05:00
rusefi 3c57c3d216 refactoring: time to unify digital pin API 2019-11-11 23:32:09 -05:00
rusefi f082ac48b1 refactoring: time to unify digital pin API 2019-11-11 23:04:27 -05:00
rusefi 15a571fb3e this is not great :(
#639
#971
2019-11-11 22:19:35 -05:00
rusefi b9f0f2c592 need better higher-level API :( 2019-11-11 22:14:45 -05:00
rusefi 410391598e Strange INJ1 signal behavior (when the frequency of scheduler's timer is less than 1MHz) fix #996 2019-11-10 23:54:08 -05:00
rusefi 669c75d44f trying to fix integration tests
[java] 2019-11-10_13_31_42_194<EOT>: msg,FATAL error: PID::isSame invalid,
     [java] 2019-11-10_13_31_42_194<EOT>: postMessage EngineState: FATAL error: PID::isSame invalid
     [java] 2019-11-10_13_31_42_289<EOT>: Sending packet 4F 00 00 64 01
     [java] 2019-11-10_13_31_42_289<EOT>: output channels header: waiting for 2 byte(s)
     [java] 2019-11-10_13_31_42_290<EOT>: IncomingDataBuffer: 256 byte(s) arrived
     [java] 2019-11-10_13_31_42_290<EOT>: output channels body: waiting for 361 byte(s)
     [java] 2019-11-10_13_31_42_291<EOT>: IncomingDataBuffer: 107 byte(s) arrived
2019-11-10 16:07:13 -05:00
andreika-git b996190707 Industrial PID Controller (#1002)
* Implement Industrial PID controller

* Test-Use PidIndustrial in alternator

* Meaningful unit-tests for PidIndustrial
2019-11-10 13:04:27 -05:00
rusefi 79e049a5f8 Strange INJ1 signal behavior (when the frequency of scheduler's timer is less than 1MHz) #996
new advanced debugging: hardware pins
2019-11-10 12:39:47 -05:00
rusefi 42cd78fbd5 Trying latest gcc 9 #1001 2019-11-07 11:28:49 -05:00
rusefi d2e24cf2e5 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-06 20:33:40 -05:00
rusefi ae0456e5fb fine, taking care of more warnings 2019-11-06 19:53:09 -05:00
rusefi 8525c48036 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-06 18:26:50 -05:00
andreika-git 4e19c96cb6 Kinetis timer freq. fix & config update (#999)
* Kinetis: fix timer frequency

* More silentTriggerError - it really helps a lot!

* Kinetis: gen_config.bat update
2019-11-06 14:45:55 -05:00
rusefi df291f4421 Missing dwell altogether in some corner cases fix #796 2019-11-06 00:31:24 -05:00
rusefi 5106ada9ce Missing dwell altogether in some corner cases #796
flirting with the fix but not yet the fix
2019-11-06 00:10:44 -05:00
rusefi 487acd62de Missing dwell altogether in some corner cases #796
only additional live data here
2019-11-05 23:36:33 -05:00
rusefi 8f5895321c refactoring 2019-11-05 23:17:44 -05:00
rusefi eb4ceda52b refactoring: removing unused parameter 2019-11-05 22:49:11 -05:00
rusefi d4574a3cab evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 22:40:33 -05:00
rusefi 7015a5c250 generating fresh 2019-11-05 21:05:19 -05:00
rusefi cc6381fe96 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 20:07:55 -05:00
rusefi 801b2eb70e progress towards #961 2019-11-04 22:52:37 -05:00
rusefi bab1744d1d progress towards #961 2019-11-04 22:44:52 -05:00
rusefi 79fd7fc8ce kind of todo 2019-11-04 22:29:22 -05:00
rusefi 2e3e53c613 custom codes cleanup 2019-11-04 09:20:00 -05:00
rusefi e7a2a77dd5 happy November 2019-11-03 23:38:00 -05:00
rusefi 058e264e0c CI instability: FATAL error: warn stream not initialized fix #798 2019-11-03 22:15:49 -05:00
rusefi 9cbdbb794e pieces of #971 2019-11-03 22:02:52 -05:00
rusefi d1afb9b183 moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 21:29:12 -05:00
rusefi 22453f8392 nicer enum name 2019-11-03 21:19:13 -05:00
rusefi a2bee7f46b moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 19:36:56 -05:00
rusefi 06b7524c1d moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 17:25:34 -05:00
rusefi 9c94dd503e moving setDefaultFrankensoConfiguration down is the way of righteousness 2019-11-03 17:17:43 -05:00
rusefi 5c46ad25a7 review feedback 2019-11-03 10:36:35 -05:00
rusefi 5f01a3fb04
skeleton & docs (#995)
* Documentation additions and clarifications.

Added config/boards/skeleton/ as an example and starting point for
board-specific support.

* Describe where the generated files came from.

* Minor rewording

* Delete mistakenly added emacs backups

* Added an overall description and build notes
2019-11-03 08:41:14 -05:00
andreika-git ee5ee1942c Kinetis & TLE8888 compatibility & fixes... (#991)
* TLE8888: More compatibility & postTunerStudioState

* activeConfiguration & EFI_ACTIVE_CONFIGURATION_IN_FLASH fix

* Kinetis: jump_to_bootloader() impl.

* Kinetis: UART baudrate safety check

* Kinetis: OMG!..
2019-10-31 16:06:34 -04:00
rusefi 47eaea3da3 scramblr reports sync issues on NB1 fix #990 2019-10-30 21:01:23 -04:00
rusefi 4d095d4844 60/2 VW trigger has running issue on 19/10/19 snapshot fix #986 2019-10-30 20:51:20 -04:00
rusefi 7a3369795f smarter IAC PID 2019-10-30 09:27:12 -04:00
rusefi 74e0c20235 flipping NB1 trigger definition 2019-10-29 21:19:00 -04:00
rusefi 8cf19d3d12 refactoring & verbose trigger to simulator 2019-10-29 21:12:44 -04:00
rusefi fe77766b2b bugfix around verboseTriggerSynchDetails - 64 bits on stack was causing broken messages 2019-10-29 18:20:55 -04:00
rusefi 469a2f1fd9 reducing code duplication with prod code & fixing simulator 2019-10-29 16:57:55 -04:00
rusefi f55c2df681 IM_TWO_COILS 2019-10-27 16:19:59 -04:00
rusefi 0a8a0d0b81 docs 2019-10-26 21:53:22 -04:00
rusefi 3e8b46b6ca preparation for industrial-PID 2019-10-23 21:41:30 -04:00
rusefi 88348ebd09 refactoring: reducing code duplication 2019-10-21 23:47:40 -04:00
rusefi 627f73502b steps towards #975 2019-10-18 19:45:32 -04:00
rusefi d9401fbdbc steps towards #975 2019-10-18 19:39:06 -04:00
rusefi 0e01355c15 steps towards #975 2019-10-18 18:54:32 -04:00
rusefi 1c140cbd80 date 2019-10-17 00:09:13 -04:00
Matthew Kennedy 10a6d6eb8b fix wwae (#980) 2019-10-17 00:06:54 -04:00
rusefi 5f9fdfe9a6 Revert "Revert "Performance improvement: call GetBaseFuel less (#979)""
This reverts commit 7eb9947fd4.
2019-10-16 23:02:24 -04:00
rusefi 7eb9947fd4 Revert "Performance improvement: call GetBaseFuel less (#979)"
This reverts commit 95e51f13
2019-10-16 22:29:19 -04:00
Matthew Kennedy 95e51f1399 Performance improvement: call GetBaseFuel less (#979)
* Remove extra calls to getInjectionDuration

* increase callback frequency
2019-10-16 22:13:10 -04:00
rusefi 344136eea9 preparing for #973 2019-10-16 22:10:38 -04:00
Matthew Kennedy 4db3fa46cd fix #977 (#978) 2019-10-15 05:24:33 -04:00
Matthew Kennedy d6e065f99e Merge remote-tracking branch 'upstream/master' into perf-tracing 2019-10-14 23:45:39 -07:00
Matthew Kennedy d76670d946 trace all the things 2019-10-14 23:34:12 -07:00
rusefi d0596388e6 preparing for #961
better code style
2019-10-15 02:06:15 -04:00
rusefi dda7f4d343 preparing for #974
code comments & refactoring
2019-10-15 01:27:19 -04:00
rusefi 6629b90a7f preparing for #974
code comments & refactoring
2019-10-14 18:32:16 -04:00
rusefi 5a4c7b38cd preparing for #974
code comments & refactoring
2019-10-14 16:04:28 -04:00
rusefi 7bb8bb7f14 preparing for #974
code comments & refactoring
2019-10-14 09:09:08 -04:00
rusefi 12137fc7cd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
Matthew Kennedy f52bdecb80 profile all the things 2019-10-13 13:14:08 -07:00
rusefi 6a1604815d Merge branch 'master' of https://github.com/rusefi/rusefi 2019-10-13 09:59:19 -04:00
rusefi 5cb90d0e1b preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
Matthew Kennedy 763b17fb50 experiment 2019-10-11 17:43:21 -07:00
rusEfi dfef5748b9 pin conflict in MRE test config 2019-10-10 13:32:07 -04:00
rusefi 62577c47da preparation for #961
more unified access to pre-calculated value
2019-10-10 08:25:58 -04:00
rusefi 71e904e421 preparation for #961
more unified access to pre-calculated value
2019-10-10 08:16:21 -04:00
rusefi 9a26b2eca2 preparation for #961
macro as a syntax sugar for method invocation
2019-10-10 07:37:37 -04:00
rusefi ca6e49dcbc preparation for #961
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
rusefi f17fc56aa5 better handling of corner case 2019-10-10 07:07:59 -04:00
Matthew Kennedy 29804cbc8a move tsOutputChannels to header (#970) 2019-10-08 21:02:51 -04:00
rusefi 4574aaccce I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 2acdbf308b something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi a65c8c9295 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi fbbf8995e4 wow, dead field 2019-10-08 02:17:32 -04:00
rusefi 2b59940161 really not clear what is the best place for these classes 2019-10-08 02:13:52 -04:00
rusefi 4e26bd2fd2 refactoring 2019-10-08 02:01:41 -04:00
rusefi cd1e87ff41 docs & refactoring 2019-10-08 01:49:42 -04:00
rusefi 5bf399e280 fancier C++ initialization 2019-10-08 01:36:35 -04:00
rusefi ade7ad158a typo & better field name 2019-10-08 01:36:03 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 1ab488e4b4 refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi ca67249522 refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi 8424723024 refactoring: better variable names 2019-10-08 00:42:47 -04:00
rusefi 0d31cdddea refactoring: better parameter name 2019-10-08 00:30:20 -04:00
rusefi 53231f7b49 refactoring: smarter C++ initialization 2019-10-08 00:27:49 -04:00
rusefi d381bce748 date 2019-10-06 00:39:50 -04:00
Matthew Kennedy d1da567b85 fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
Matthew Kennedy faa2a481ea Simplify thermistor config (#962)
* simplify thermistor config

* fix test
2019-10-02 21:00:10 -04:00
rusefi 62bbdbb33b docs 2019-09-29 15:14:08 -04:00
rusefi df7fe0ec3b fixing build 2019-09-29 14:22:51 -04:00
rusefi 7d2aaab1aa Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-29 14:16:51 -04:00
rusEfi fc3b7ec1bd etbCalibrationOnStart 2019-09-29 14:00:04 -04:00
rusefi c935903162 do not let "Use fixed baro corr from MAP" kill VE fix #960 2019-09-29 09:58:29 -04:00
rusefi 8e3912e6b1 firing order 1-2-7-8-4-5-6-3 2019-09-28 10:25:57 -04:00
rusefi d520e0734f docs 2019-09-28 09:59:40 -04:00
rusEfi 44b2c2f89e new command 'etb_freq X' 2019-09-27 23:37:40 -04:00
rusEfi 17dc0908f2 it's a cruel world 2019-09-27 23:01:47 -04:00
Matthew Kennedy 4db887361c Fix sensor mock spill, again (#957)
* actually reset

* add test

* doh
2019-09-27 21:40:36 -04:00
rusEfi dfd5b11c8f Revert "Fix sensor mocking bug (#956)"
This reverts commit 217081c1
2019-09-27 20:33:45 -04:00
Matthew Kennedy 217081c174 Fix sensor mocking bug (#956)
* actually reset

* add test
2019-09-27 20:21:50 -04:00
rusefi 8c5be72106 idle&ETB progress 2019-09-26 00:02:47 -04:00
rusefi ff8a3f2988 fixing build 2019-09-25 08:46:26 -04:00
rusefi 3da60a406a Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-25 08:40:56 -04:00
rusefi bc572bef51 reducing hell in unit tests 2019-09-25 08:40:33 -04:00
Matthew Kennedy ee5643f1bf Hmm, that didn't quite work right (#955)
* maybe that wasn't a good idea

* we don't need a copy because you can't clear the func after setting it

* no longer a template - move logic to cpp

* fix tests

* rename to avoid object collision
2019-09-25 07:26:56 -04:00
Matthew Kennedy 3bd1ddcc1f Sensors: composition >> inheritance (#953)
* functional sensors

* format

* tests

* sim makefile

* eol

* format tests
2019-09-24 21:11:41 -04:00
rusefi 567bd7dd58 absolute fuel pressure flow calculation #954 2019-09-24 18:39:26 -04:00
rusefi fc8db12323 absolute fuel pressure flow calculation #954 2019-09-24 17:57:49 -04:00
rusefi 2bacf53c0d HardFault related to auto r = convertFromInputValue(inputValue); #948
wow, it's a miracle anything ever worked!
2019-09-23 01:55:23 -04:00
rusefi b66f3a8229 ETB is sticky around zero and does not want to close all the way #943
fixing build
2019-09-23 00:41:35 -04:00
rusEfi 89ed15838f ETB is sticky around zero and does not want to close all the way #943 2019-09-22 23:28:11 -04:00
rusefi 4f33dff0a1 ETB target is using integer values fix #945 2019-09-22 18:15:00 -04:00
rusefi e7b658547b ETB target is using integer values #945
now we have a unit test! now we can fix the issue :)
2019-09-22 17:58:27 -04:00
rusefi e99955fce5 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 17:43:00 -04:00
rusefi 7d65f1931e ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 17:39:13 -04:00
rusefi 5a43153541 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 17:19:08 -04:00
rusefi f600bbc6d7 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 10:02:07 -04:00
rusefi 533087f475 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
rusefi d09e096874 ETB target is using integer values #945
refactoring
2019-09-22 08:51:02 -04:00
rusefi 03b6a6ec58 Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-22 08:45:03 -04:00
rusefi 1b604359a9 ETB target is using integer values #945
refactoring
2019-09-22 08:44:51 -04:00
rusEfi d5ef749761 s/NULL/nullptr/ 2019-09-22 08:22:35 -04:00
rusEfi 9b98446846 ETB target is using integer values #945
first we will write a unit test
2019-09-22 07:58:03 -04:00
rusEfi e29318b939 ETB target is using integer values #945
first we will write a unit test
2019-09-22 00:36:13 -04:00
rusEfi f843968636 ETB target is using integer values #945
first we will write a unit test
2019-09-22 00:16:46 -04:00
rusefi 4ba441fd49 "set_etb" is now "set_etb_duty" 2019-09-21 22:15:34 -04:00
rusefi 59598e5abf fixing build 2019-09-21 15:43:18 -04:00
rusefi 9ad82b03b5 fixing build 2019-09-21 15:33:13 -04:00
Matthew Kennedy f629ec038b add sensor framework, tests (#929)
* add framework, tests

* move oil pressure to new way

* add init logic

* brackets on the same line

* spaces -> tabs

* spaces -> tabs for tests

* bracket on same line

* hook up sensor mocking

* add nan check

* fix nan check

* I wrote an essay

* casing

* only init if we have a sensor to init

* style, actually call init

* format

* fix casing

* typo

* implement linear sensor

* wire up producer

* smarter limiting

* setup comments

* add reporting

* doxyfile

* oops

* add adc subscription

* clarity

* fix logic

* multiply voltage

* test styling

* test guards

* remove dependencies

* linear sensor test

* remove unused

* fix merge

* format, implicit convert op

* explicit

* format tests

* fix merge
2019-09-21 14:33:38 -04:00
rusefi f3c82eec0c progress 2019-09-21 14:18:59 -04:00
rusefi 2ce6e900a3 fixing bug from yesterday 2019-09-21 11:09:03 -04:00
rusefi 3646ef4406 ETB idle bugfix: do not use once turned off 2019-09-21 01:22:21 -04:00
rusefi f588224559 NB2 miata on Frankenso with ETB 2019-09-21 01:21:53 -04:00
rusefi 2bbbc1c787 ETB pinEnableMode 2019-09-20 22:16:54 -04:00
rusefi b9f649a93c ETB to SD logs 2019-09-20 20:41:45 -04:00
rusefi 3ac801f9c5 configurable SD card logging speed 2019-09-20 20:18:22 -04:00
rusefi ef85a6ceed more fields to SD card logs 2019-09-20 19:38:19 -04:00
rusefi 73d0c2f2d9 Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-20 18:35:56 -04:00
rusefi b80710e7a7 refactoring "date" command and flex dead code 2019-09-20 18:12:56 -04:00
rusefi ecae02ff27 thank you @andreika! 2019-09-20 08:44:20 -04:00
rusefi 0829d70012 reducing complexity 2019-09-20 01:06:15 -04:00
rusefi a72d2834fb unit tests progress 2019-09-20 00:46:35 -04:00
rusefi 87875d8825 unit tests progress 2019-09-20 00:34:42 -04:00
rusefi 36fad3a21e unit tests progress 2019-09-20 00:25:43 -04:00
rusefi 78b9e5a438 refactoring 2019-09-20 00:17:00 -04:00
rusefi 154092bbf5 unit tests progress 2019-09-19 22:56:54 -04:00
rusefi 221ef7d9bb unit tests progress 2019-09-19 22:10:39 -04:00
rusefi c59d8164c6 unit tests progress 2019-09-19 21:41:52 -04:00
rusefi bda089011c unit tests progress 2019-09-19 08:05:23 -04:00
rusefi 8dcb2d9690 BUG: FSIO logic requires a pin to calculate fix #933 2019-09-18 23:22:15 -04:00
rusefi ddbd96ba72 BUG: FSIO logic requires a pin to calculate fix #933 2019-09-18 22:07:02 -04:00
rusefi f48f60bb36 unit tests progress 2019-09-18 21:48:46 -04:00
rusefi c4339e17d8 unit tests progress 2019-09-18 21:38:45 -04:00
Matthew Kennedy a20f353506 Kill Dead Code 2: Electric Boogaloo (#940)
* remove dead

* remove dead

* deflex
2019-09-18 20:23:14 -04:00
rusEfi 67c25a6f12 A/C relay cleanup 2019-09-15 11:32:38 -04:00
rusEfi 6504f6ccaf Merge branch 'master' of https://github.com/rusefi/rusefi 2019-09-15 10:05:22 -04:00
rusEfi 08c751bd9c NA8 2019-09-15 10:04:24 -04:00
Matthew Kennedy cce6646cdf kill (#935) 2019-09-14 21:20:36 -04:00
rusEfi 66b3ae000d acRelayBench 2019-09-14 17:56:17 -04:00
rusefi 664777587b Most important feature: VAG W12 firing order 2019-09-14 14:47:22 -04:00
rusefi 4f4f4ddfd9 FSIO progress 2019-09-13 21:07:34 -04:00
rusefi cffe318d1b pedal ADC should be faster #931 2019-09-13 19:55:20 -04:00
rusEfi 3bbce46660 mock voltage bugfix, thank you AndreiKA! 2019-09-12 08:27:25 -04:00
rusefi dfc0743e9a Delayed A/C compressor switch #922
unit tests skeleton
2019-09-12 07:31:13 -04:00
rusefi 8e67952fb8 idle timing tooltips for tunerstudio 2019-09-11 20:59:05 -04:00
rusefi a6fbc5036a Delayed A/C compressor switch #922 2019-09-11 20:46:50 -04:00
rusefi 2349ea237a Delayed A/C compressor switch #922 2019-09-11 19:30:36 -04:00
Matthew Kennedy 33d13a78fc remove sensor_types.h (#928) 2019-09-11 18:10:49 -04:00
rusefi 448d99a2c8 Delayed A/C compressor switch #922 2019-09-10 23:49:21 -04:00
rusefi cc011ee081 instant RPM for idle control #925 2019-09-10 23:03:55 -04:00
rusefi 47d8cdf0ac Delayed A/C compressor switch #922 2019-09-10 22:55:58 -04:00
rusefi d90f0481b0 one step back :) instant RPM does not look right 2019-09-10 21:35:10 -04:00
rusefi 86e421e0ee fatalErrorPin setting is not used #926
reducing configuration fragility
2019-09-09 21:44:48 -04:00
rusefi 2818c803b5 fatalErrorPin setting is not used #926 2019-09-09 21:34:15 -04:00
rusefi 917676b2da simulator crashes on any TS setting change fix #924 2019-09-09 20:49:16 -04:00
rusefi 7676261ec6 instant RPM for idle control #925 2019-09-09 19:41:41 -04:00
rusefi db018723f7 refactoring: better field name 2019-09-09 19:39:13 -04:00
rusefi 8d1d88bf73 instant RPM for idle control #925
refactoring
2019-09-09 14:41:26 -04:00
rusefi 47f97d1246 has been a while so safe to assume everyone has default value 2019-09-08 22:17:51 -04:00
rusefi eb58ebda87 Delayed A/C compressor switch #922 2019-09-08 21:09:45 -04:00
rusefi e79287f537 Delayed A/C compressor switch #922 2019-09-08 21:05:03 -04:00
rusefi 0b8ebdbf96 A/C NA6 compressor progress 2019-09-08 16:45:02 -04:00
rusefi a585835add docs 2019-09-07 22:16:56 -04:00
rusefi 270565e593 docs 2019-09-07 21:35:55 -04:00
rusefi e77b703beb Reinitialize TLE8888 if it resets #904
nasty "solution"
2019-09-06 20:30:27 -04:00
rusefi 5d8e1f6c73 tle8888 reinit command 2019-09-05 10:30:27 -04:00
rusefi e4566ba6aa TLE8888: NB2 solution + reset counter 2019-09-05 10:01:59 -04:00
rusefi c1c1e59006 Hall mode for TLE88888 - VRSConfig1 VRSM #915
TS settings typo
2019-09-04 00:19:44 -04:00
rusEfi 8a35983bfe Hall mode for TLE88888 - VRSConfig1 VRSM #915
TS setting only
2019-09-03 23:56:28 -04:00
rusefi 612a4ab3b3 MRE NB2 2019-09-03 23:35:49 -04:00
rusefi 2e27a94ee7 BUGFIX: ETB idle should care about pedal position, not TPS position 2019-09-03 21:45:42 -04:00
rusefi f32b29f318 Live Data: trigger current gap 2019-09-03 19:30:51 -04:00
rusefi 98a391011a better field name 2019-09-03 19:12:04 -04:00
rusefi f73d18fd38 Merge branch 'master' of https://github.com/rusefi/rusefi
# Conflicts:
#	java_console/models/src/com/rusefi/config/generated/Fields.java
2019-09-03 18:54:54 -04:00
rusefi 9f50f9a4f7 EFI_CJ125_DIRECTLY_CONNECTED_UR should be a runtime parameter fix #914 2019-09-03 18:44:05 -04:00
rusefi 7922d79cde pedal calibration into status message 2019-09-02 22:58:36 -04:00
rusefi b51e79357e refactoring: extracting magic command constant 2019-09-02 22:57:40 -04:00
rusEfi 1b8219432c Live Data for hw VVT signals 2019-09-02 21:02:08 -04:00
rusEfi c2980a36a9 Live Data VVT counter 2019-09-02 14:47:05 -04:00
rusefi 2343cd6b12 make iTerm limits visible for idle RPM pid #913 2019-09-02 00:24:10 -04:00
rusefi be1b32abf0 make iTerm limits visible for idle RPM pid #913 2019-09-02 00:19:06 -04:00
rusEfi 8126b700de NB2 progress, ETB Live Docs progress 2019-09-01 19:37:58 -04:00
rusEfi b8fa0dec72 typo 2019-09-01 18:56:57 -04:00
rusEfi daec071b6b mock PPS voltage command in addition to mock PPS position
ETB pane progress
2019-09-01 17:35:43 -04:00
rusEfi 3e852bfb1e showing 'before' values while changing TPS settings 2019-09-01 16:11:35 -04:00
rusefi ebcb0cdf4c Live Data: more Idle & ETB data points! 2019-09-01 15:46:40 -04:00
rusefi 33cc21225c Live Data progress: using field's context 2019-09-01 15:01:57 -04:00
rusefi 1ffaa8eea2 Live Data progress 2019-09-01 13:56:46 -04:00
rusefi 1bd4fb8f09 docs & naming consistency 2019-09-01 11:59:39 -04:00
rusefi 4141c7b4c2 typo 2019-09-01 11:39:09 -04:00
rusefi 7842c7305f Live Data progress 2019-09-01 00:45:36 -04:00
rusefi 7ce9b2890e live data: consistent naming 2019-08-31 23:39:30 -04:00
rusefi fa51007994 typo 2019-08-31 23:32:33 -04:00
rusefi 4858124edb unified names for generated headers 2019-08-31 23:12:39 -04:00
rusEfi 47bbd6ebe4 ETB progress 2019-08-31 20:17:17 -04:00
rusEfi 3851b37be6 NB2 MRE 2019-08-31 18:36:44 -04:00
rusEfi 7efe5cdd5c reducing dead code 2019-08-31 17:59:18 -04:00
rusefi 4ddb0aeace LiveData progress: isChanking & hasEtbPedalPositionSensor 2019-08-31 17:07:21 -04:00
andreika-git 27fccf0a7f mightResetPid docs (#912) 2019-08-31 15:38:01 -04:00
rusefi 840b165f12 NA6 pnp: automatic idle VS TPS #800 2019-08-30 18:17:10 -04:00
rusefi ad2714c2b8 PID errorAmplificationCoef to LiveData 2019-08-30 17:11:12 -04:00
rusefi 162264fe08 progress towards idle unit test 2019-08-29 23:50:20 -04:00
rusefi 375d64417d progress towards idle unit test 2019-08-29 00:10:47 -04:00
rusefi b090be14b0 cranking fuel live data fix #911 2019-08-28 00:29:55 -04:00
rusefi 2804b31e7e cranking fuel live data #911 2019-08-26 23:41:04 -04:00
rusefi bde4e88468 refactoring towards idle unit test 2019-08-26 00:19:13 -04:00
rusefi c1fb75689d unit tests code coverage #653
one day I will migrate rusEfi to java
2019-08-25 13:42:07 -04:00
rusefi 8ab2c6ae69 unit tests code coverage #653
reducing technical debt just a little
2019-08-25 10:19:01 -04:00
rusefi 9161703598 reducing unit test noise 2019-08-25 02:01:09 -04:00
rusefi e5e0ce0b94 minor test code fix & refactoring 2019-08-25 01:35:36 -04:00
rusefi 8a4d3f9896 reducing unit test noise 2019-08-25 01:15:18 -04:00
rusEfi 1c0d38abef new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
rusEfi c29f038b83 bugfix: pin names were not shown in engine sniffer 2019-08-18 15:27:10 -04:00
rusEfi 7a7dbb8c30 refactoring: engine sniffer magic constants 2019-08-18 15:04:02 -04:00
rusEfi f5452a922f MRE NA6 2019-08-18 14:43:38 -04:00
rusefi bfc4392dcd refactoring: extracting common magic constant 2019-08-18 12:30:59 -04:00
rusefi db724568db refactoring: extracting common magic constants 2019-08-18 12:14:33 -04:00
rusEfi 59daae8f5c MRE & Miata 2019-08-17 22:42:22 -04:00
rusefi 70c74bec0d WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
actually ignoring setting for well known triggers
2019-08-17 22:00:01 -04:00
rusEfi 6c9d684dfd MRE etb 2019-08-17 17:33:44 -04:00
rusefi 0821e46606 poke 2019-08-16 23:37:16 -04:00
rusefi f858b26a50 TLE8888 should be re-initialized every time we get +12 volts #901
extremely ugly solution but it it works at least with LED blinking test
2019-08-16 23:00:28 -04:00
rusefi efeb6eeadc ETB live docs 2019-08-15 21:01:04 -04:00
rusefi 7eb05c90e4 steps towards ETB live documentation 2019-08-15 20:24:17 -04:00
rusefi 0102f07d77 new 4 cylinder firing order! 2019-08-15 19:36:16 -04:00
rusEfi 1a1fe77ff8 MRE ETB 2019-08-15 01:59:15 -04:00
rusEfi 48a15dcc0c MRE_MIATA_NB2 2019-08-13 19:15:24 -04:00
rusefi 9d32f2c40a refactoring: ChibiOS now offers native 'lockAnyContext' pattern 2019-08-11 15:23:15 -04:00
rusefi 56236754c3 random typo 2019-08-10 14:40:51 -04:00
rusefi 7768134a46 poke 2019-08-10 00:54:26 -04:00
rusefi f0c318aafd WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898 2019-08-08 23:11:56 -04:00
rusefi e0acec2a63 WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
fatal error is the best I can come up with quickly
2019-08-08 22:57:22 -04:00
rusefi 539cd8b1c7 current toolchain does not work great with current rusEfi code, two methods with same name are hard for full text search :( 2019-08-08 22:33:52 -04:00
rusefi 121ad9b786 fixing build & taking a safer route 2019-08-08 22:12:51 -04:00
rusefi 7d73c6a8a9 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
fancy smansy unit test with some C++11
2019-08-08 21:27:57 -04:00
rusefi 3ff8c92d38 poke 2019-08-08 20:32:00 -04:00
rusefi dbac03f981 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:51:15 -04:00
rusefi 643cc24931 WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:32:31 -04:00
rusefi f25b1e5f2f WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
more refactoring
2019-08-08 00:30:32 -04:00
rusefi 51110b33ad WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
refactoring to begin with, zero logic change
2019-08-08 00:19:09 -04:00
rusefi 71951041b1 refactoring: better enum name 2019-08-07 22:20:16 -04:00
rusefi 676035f950 refactoring: extracting method to facilitate debugging 2019-08-07 22:02:08 -04:00
rusefi 7a00ccd2ce better trigger state debug field logging 2019-08-07 20:13:30 -04:00
rusEfi ba56a79ad5 proper HW type message logic 2019-08-06 23:56:35 -04:00
rusEfi d5451a7b4f NA6 & trigger 2019-08-06 22:17:18 -04:00
rusEfi bde25114d5 NA6 MRE details 2019-08-06 17:59:02 -04:00
rusefi 8d14561fb9 better method name 2019-08-06 17:12:15 -04:00
rusefi 2a3d067821 fixing unit tests build 2019-08-05 23:36:18 -04:00