Commit Graph

1009 Commits

Author SHA1 Message Date
rusefillc 649059c6fa Lua: setBoostDutyAdd can target values under 0 fix #6339 2024-04-06 09:04:42 -04:00
rusefillc f0fc8ad2c8 only:refactoring, reusing existing clampPercentValue macro 2024-04-06 09:02:03 -04:00
rusefillc 9c5e4273d1 only:doc 2024-04-06 09:02:03 -04:00
Andrey f60bd6c683 better file name to actually reflect what the content is about 2024-03-25 23:31:49 -04:00
rusefillc 2a114b4f95 PUBLIC_API_WEAK 2024-03-24 22:06:58 -04:00
rusefillc a690fc3ab5 only: fansDisabledByBoardStatus 2024-03-24 14:31:02 -04:00
rusefillc f40cd512c9 Base map values for Open Loop Boost Duty should be 0% fix #6188 2024-03-09 15:44:17 -05:00
Andrey cdaeb2fa2b so much random technical debt all over :( 2024-03-04 21:25:07 -05:00
Andrey 4b6786b6ff ETB traction control drop is affected by not-highlighted cell fix #5952 2024-03-04 18:23:48 -05:00
Andrey 3096db5c72 confusing Map3D API fix #6139 2024-03-04 17:58:24 -05:00
rusefillc fb5fe93260 only:docs & typo 2024-02-16 15:21:33 -05:00
Andrey 0df1a9caa5 only:Disable fans after VSS > x fix #5875 2024-01-23 11:04:49 -05:00
GitHub gen-configs Action 16e7584ee0 Auto-generated configs and docs 2024-01-23 15:55:11 +00:00
Andrey ea8c338f18 only:Disable fans after VSS > x #5875 2024-01-23 10:51:50 -05:00
Matthew Kennedy a8356ae578 baro pressure -> gppwm channel option 2024-01-17 10:30:53 -05:00
GitHub gen-configs Action 62081b5a4b Auto-generated configs and docs 2024-01-05 01:21:51 +00:00
rusefillc 1abd93fa21 usability issue: Boost blend logic does not happen while not controlling boost #5864 2024-01-04 20:16:00 -05:00
GitHub gen-configs Action 58f31fd2d9 Auto-generated configs and docs 2024-01-03 20:32:11 +00:00
rusefillc 16211bb4e7 is this ever null? 2024-01-02 23:04:13 -05:00
rusefillc 31711cc71e adding-etb-lightness: is it even nullptr? 2024-01-02 21:10:13 -05:00
rusefi 59b766141c traction control: wheel-slip based close ETB #5843 2023-12-31 18:08:21 -05:00
GitHub gen-configs Action 48ee563b6c Auto-generated configs and docs 2023-12-31 20:19:26 +00:00
rusefi cc90a0ecd2 traction control: wheel-slip based close ETB #5843
only:proteus_f4
2023-12-31 15:15:23 -05:00
rusefillc 26514f8b92 ETB calibration compatibility notes from 2022
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-12-26 13:01:03 -05:00
rusefillc daad14b907 ETB minor clean-up 2023-12-18 19:01:55 -05:00
rusefillc 191b17e0d5 ETB minor clean-up 2023-12-18 16:48:54 -05:00
rusefillc c7b155d97f small-can FW is not well #5787
seems to be about EFI_ENGINE_CONTROL guarding too much of default settings
only:small-can-board
2023-12-13 00:15:43 -05:00
rusefillc 699d588849 https://github.com/rusefi/alphax-4chan/issues/166
only:alphax_4chan
2023-12-12 14:10:57 -05:00
rusefillc 3b88f847e0 https://github.com/rusefi/alphax-4chan/issues/166 2023-12-10 12:00:34 -05:00
rusefillc 28a273cae7 refactoring: better method name 2023-12-10 11:48:48 -05:00
rusefillc 699ccb1262 https://github.com/rusefi/alphax-4chan/issues/166 2023-12-10 11:35:34 -05:00
andreika-git a830a94a3b More safe AlternatorController PWM init 2023-12-05 14:23:04 -05:00
rusefillc 1f990e8fef only:better method name 2023-11-22 23:58:30 -05:00
rusefillc 02f1295688 removing 'isVerboseAlternator' 2023-11-15 00:12:19 -05:00
rusefillc 0800335320 reducing code duplication 2023-11-13 18:30:30 -05:00
rusefillc e2c2980335 making ACR quicker
only:proteus_f7
2023-11-13 17:25:07 -05:00
rusefillc 20e9f6178a ACR
only:proteus_f7
2023-11-12 22:43:34 -05:00
rusefillc 0444a652a9 vvt: safer syntax 2023-11-11 21:51:12 -06:00
andreika-git 7957c24552 better rpm=0 behavior for VvtController 2023-11-11 21:51:12 -06:00
rusefillc 094a2b6c79 only:hd 2023-11-11 17:36:42 -05:00
andreika-git 06414cc595 fix 2023-11-10 17:13:50 -05:00
andreika-git 3e9b2d0e1f Refactor AlternatorController to use ClosedLoopController<> 2023-11-10 17:13:50 -05:00
andreika-git bb841a061b refactor onConfigurationChangeAlternatorCallback() 2023-11-10 17:13:50 -05:00
Andrey 3d3671e6d4 better EFI_ENGINE_CONTROL 2023-11-05 12:07:24 -05:00
Andrey 021609f468 only:unused methods 2023-11-04 22:34:28 -04:00
Andrey 4eefedcec2 unused-variable is a nice error message to have #5683 2023-11-02 20:48:57 -04:00
Andrey 16d6ddd373 clean-up 2023-11-02 10:32:04 -04:00
Matthew Kennedy 93e3e75a36 avoid vexing parse 2023-11-01 19:25:13 -04:00
Matthew Kennedy 02621224a7 dc motor 2023-11-01 19:25:13 -04:00
Matthew Kennedy 2c049d206a dead pid auto tune 2023-11-01 17:01:07 -04:00
rusefillc e384914c95 only:variable shadowing should be avoided #5676 2023-11-01 13:02:20 -04:00
Matthew Kennedy f5f3a48768 dead include 2023-10-31 10:55:52 -04:00
rusefi b77a7c4111 hd 2023-10-31 10:29:14 -04:00
rusefillc 0b1b7a86d9 Make TPS/PPS split configurable #5620 2023-10-30 22:25:29 -04:00
rusefi 88b08a9156 https://github.com/rusefi/rusefi-hardware/issues/253 2023-10-30 08:46:14 -04:00
rusefi 2051a41c4d docs 2023-10-29 17:24:56 -04:00
rusefillc c98963a991 only: dead commands 2023-10-27 11:35:15 -04:00
Matthew Kennedy 9d271b42d4 console commands cleanup 2023-10-26 23:14:30 -04:00
rusefillc 2507d4e467
tiny refactoring (#5646)
Co-authored-by: andreika-git <andrei.home@gmail.com>
2023-10-26 13:04:30 -04:00
Patryk Chmura 41ac8a921c
Fixes confirmed on the real car (#5638)
Co-authored-by: pchmura4 <>
2023-10-25 14:02:41 -04:00
Andreika 0097fe292c
Bench test: main relay and other pins fix (#5637)
* use standard pin bench test for the main relay

* fix pin bench test

* enable some pin bench test

* fix
2023-10-25 10:22:45 -04:00
Patryk Chmura 0a7cd2b08c
Closed Loop Idle Ignition Timing small improvements (#5635)
* After-start enrichment handling more similar to OEM and other Standalone EFI systems

* Corrections and tidying-up

* Corrected small mistake in TunerStudio definition

* Compatibility fixes

* Readability fix

* Changed to more appropriate cycles instead of seconds, bugfix for TS

* Typo fix...

* Idle Ignition Timing improvements

* Uninitialized variable for Unit Tests?

* Zero value should disable new feature

---------

Co-authored-by: pchmura4 <>
2023-10-24 17:43:29 -04:00
GitHub gen-configs Action 24ec1dae55 Auto-generated configs and docs 2023-10-22 22:38:22 +00:00
pchmura4 4849f7bdfa Corrections for the build to succeed 2023-10-22 18:16:19 -04:00
pchmura4 beebe4c233 Renamed "bump" to "target", changed CHANGELOG 2023-10-22 18:16:19 -04:00
pchmura4 0b852e4a81 Changed the way AC idle RPM bump is handled 2023-10-22 18:16:19 -04:00
Andrey f2453ce251 open loop boost does not really require Map sensor
only:small-can-board
2023-10-19 21:22:59 -04:00
Andrey 300e08d4c4 only:making boost constraints more obvious, also running boost in simulator 2023-10-19 21:06:09 -04:00
GitHub gen-configs Action 1c6791ed65 Auto-generated configs and docs 2023-10-20 00:47:00 +00:00
rusefillc d5bb7bd060 only:making boost a bit more obvious 2023-10-19 20:34:58 -04:00
rusefillc ff40d113ab same gear count for everyone, also honda
only:small-can-board
2023-10-19 12:54:30 -04:00
Andrey 4c1958588c only: removing 'void' 2023-10-14 15:53:30 -04:00
rusefillc 2721d6ea52 small likes harley acr 2023-10-09 18:51:47 -04:00
Matthew Kennedy 6b13f95b3c dual ACR pins #47 2023-10-09 18:51:47 -04:00
Matthew Kennedy 02f4a09d56 basic harley acr (#48)
* acr

* cleanup

* handle m_hasPinMode

* output channel

* ui

* wrap phase

* don't inject during ACR

* skip extra calculation

---------

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2023-10-09 18:51:47 -04:00
Andrey 680d18e433 VVT control is broken on second bank fix #5599 2023-10-07 12:54:45 -04:00
Andrey 3b1fe9da7f only: VVT refactoring reducing magic index math 2023-10-07 12:34:32 -04:00
rusefillc a39f1ff4ca logging of idle 2023-09-28 10:49:59 -04:00
GitHub gen-configs Action 34f5b029a2 Auto-generated configs and docs 2023-09-28 13:46:29 +00:00
rusefillc 7c4c48201a logging of idle 2023-09-28 09:42:45 -04:00
Matthew Kennedy 6be4d6073f use onConfigurationChange instead of version holder 2023-09-26 21:47:32 -04:00
GitHub gen-configs Action dff215461f Auto-generated configs and docs 2023-09-27 01:14:21 +00:00
rusefillc 7c1ec7843e
Idle (#5588)
* only:moving isIdleClosedLoop into idle live data

* only:moving isIdleClosedLoop into idle live data

---------

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-09-26 21:10:47 -04:00
rusefillc e19204dd2e
Boost (#5586)
* boost is engine module

* only:idle leaves outputs

---------

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2023-09-26 13:39:43 -04:00
Andrey e0b191f972 only:idle leaves outputs 2023-09-26 12:51:52 -04:00
Matthew Kennedy a519fd13ad vvt is engine module
* vvt refactoring

* vvt constexpr livedata

* format

* fix null deref
2023-09-26 09:07:59 -04:00
rusefillc be35a5eb23
fan control is engine module (#5585)
* fan is engine module

* mockable AC

* mockable AC

* mock AC controller in fan test

* constexpr fan livedata

* isPtr

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2023-09-26 07:12:11 -04:00
Andrey 6f6755aac0 only: better field name 2023-09-25 21:49:58 -04:00
GitHub gen-configs Action 2e81c448bf Auto-generated configs and docs 2023-09-25 12:43:29 +00:00
Matthew Kennedy e0db4ba5bf verbose idle is redundant, it's all in the log now 2023-09-25 08:37:06 -04:00
Matthew Kennedy ee513cf452 boost control runs in fast callback 2023-09-10 23:31:45 -04:00
Andrey 704db4dd89 only:small can board 2023-09-06 16:59:06 -04:00
Andrey 2dde4e4e81 bench test VVT outputs #5549 2023-09-06 10:11:19 -04:00
Andrey fc148a81bd bench test VVT outputs #5549 2023-09-06 08:11:39 -04:00
rusefi 78e48d3718 only:timer.h goes to libfirmware! 2023-08-30 23:11:24 -04:00
GitHub gen-configs Action 03e0ada1a9 Auto-generated configs and docs 2023-08-22 18:21:31 +00:00
rusefillc 7bbf972c83 broadcast button toggle counter #5514 2023-08-22 14:16:30 -04:00
rusefi e8c45a2e7d refactoring: reducing code duplication. Also, do we even care for critical error codes?! 2023-08-20 22:23:44 -04:00
rusefillc cb30e54b2b
reducing complexity (#5428) 2023-07-21 21:55:57 -04:00
GitHub gen-configs Action 9584b83016 Auto-generated configs and docs 2023-07-03 17:41:15 +00:00
Matthew Kennedy 24bf593d6c little bit of real vvt data 2023-07-03 13:38:11 -04:00
Andrey b05462cc58 stub vvt live data 2023-07-03 13:25:48 -04:00
GitHub gen-configs Action 75d9e87de3 Auto-generated configs and docs 2023-07-03 16:39:36 +00:00
rusefillc 5b5678835e stub vvt live data 2023-07-03 12:12:03 -04:00
rusefillc c1ac523031 only:dead ETB code 2023-07-02 12:14:54 -04:00
rusefillc edab0d1e88 Better defaults based on some real tunes #5344 2023-06-18 23:02:51 -04:00
rusefi 7b2985c1c3 Too many bench test buttons are broken #5327 2023-06-15 22:28:15 -04:00
rusefi 308bbbe6c5 Too many bench test buttons are broken #5327 2023-06-15 22:23:35 -04:00
rusefillc 65dcdb86ec Too many bench test buttons are broken #5327 2023-06-15 11:46:39 -04:00
rusefi 1a8cacf7c1 Dashpot for return-to-idle from coasting 2023-06-12 15:39:49 -04:00
Andrey 77c55b9f88 Dashpot for return-to-idle from coasting #5303
third step towards unit test
2023-06-11 18:42:58 -04:00
Andrey 926d113725 Dashpot for return-to-idle from coasting #5303
second step towards unit test
2023-06-11 18:09:36 -04:00
Andrey 2ae85de636 Dashpot for return-to-idle from coasting #5303
small step towards test
2023-06-11 18:04:23 -04:00
Matthew Kennedy 83f8b168f6 indent formatting
(cherry picked from commit 8b5825adc46f5b626e0c8df1e00e468716c3daef)
2023-06-02 00:37:45 -04:00
Matthew Kennedy 361ae48f23 disable coasting state during the crank-to-run taper
(cherry picked from commit 5373d79d9231cc4c7523b6213ad0a004fba66ec1)
2023-05-29 19:50:51 -04:00
andreika-git b7a73219cb Boost control by gear first step: open loop MVP 1x8 table #5276 2023-05-20 21:05:01 -04:00
andreika-git ddffc51c99 Boost control by gear first step: open loop MVP 1x8 table #5276 2023-05-20 21:05:01 -04:00
Matthew Kennedy 73ed1afd06 mockable throttle model
(cherry picked from commit 57263be2fe2886d7a3d4116764396b4b5c24dc49)
2023-05-12 16:16:00 -04:00
Matthew Kennedy a3afc7bfe0 cleanup for #102
(cherry picked from commit be43ac80b64838450884f61dfc9bca315d2ec756)
2023-05-08 00:18:33 -04:00
Matthew Kennedy feaeb795a8 txt formatting
(cherry picked from commit d2f697c8a180932e6c5cfa10ac715be888c51576)
2023-05-05 17:15:09 -04:00
Matthew Kennedy effdbce4ca apparently we duplicated idle position, field renaming #98
(cherry picked from commit 304458961315f3f2dbf4cb93c15e6e73d0017d0e)
2023-05-04 21:26:40 -04:00
GitHub gen-configs Action d07aa72d5c Auto-generated configs and docs 2023-05-05 00:38:45 +00:00
Matthew Kennedy 0729605edf field naming #98
(cherry picked from commit 37ee6af0ce2b06963fbf7c50c3a7b5ed94860f69)
2023-05-04 20:37:08 -04:00
GitHub gen-configs Action a9142efa85 Auto-generated configs and docs 2023-05-04 22:44:35 +00:00
Matthew Kennedy a01faf807c Channel names #98
(cherry picked from commit 129f6f8d103b0546ef37c595450c8e0afbfe0e1d)
2023-05-04 18:26:51 -04:00
Matthew Kennedy b047d942f0 boost control gets blend tables (#73)
* boost control gets blend tables

* most of boost blend UI

* boost blends use ECU-calculated axis value

* oop

* disable UI when no boost control (or open only)

* changelog

(cherry picked from commit b5761532970b2035857f283a4a82995833f086f9)
2023-05-03 16:00:24 -04:00
Matthew Kennedy 4e7e25585e gear detection in to the sensor model
(cherry picked from commit 82794403f86023d36a211e349ca2ff530eb2eb3c)
2023-04-30 10:54:38 -04:00
rusefillc 67883f228f kinetis help 2023-04-30 10:18:24 -04:00
Andrey 6656c2ae88 guard to help kinetis 2023-04-30 01:49:21 -04:00
Matthew Kennedy 12381ed0af detected gear available as gppwm channel
(cherry picked from commit f29b51d490e44c73288df50d63f24b23c8cd3545)
2023-04-30 01:27:05 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
rusefillc db0a0553a7 only:alphax-8chan 2023-03-27 11:37:31 -04:00
rusefillc a61f39fa5f only:alphax-8chan 2023-03-27 11:00:01 -04:00
rusefillc 6116b01642 8chan Official well known idle stepper configuration #5197 2023-03-26 07:28:35 -04:00
rusefillc 1a0c35b244 8chan Official well known idle stepper configuration #5197 2023-03-26 07:23:42 -04:00
rusefi cfae5c2766 "ETB duty rate of change" better scale 2023-03-16 16:20:36 -04:00
Andrey 1f6899be54 Antilag input causes fatal on consecutive calibration changes fix #5180 2023-03-14 10:29:15 -04:00
Matthew Kennedy dc6f53bda5
extract newton's method implementation (#5157)
* move expected, update libfirmware

* hellen ID solver uses shared Newton's method

* comment shouldn't have been moved
2023-03-07 08:45:17 -05:00
Andrey 6b4c4a5833 refactoring: vvt is not aux
only:hellen-honda-k
2023-03-05 02:07:47 -05:00
Andrey 0136c5211f dead-ish code
only:hellen-honda-k
2023-03-05 02:01:11 -05:00
Andrey 83aabb4746 more realistic default
only:mre_f4
2023-02-25 11:43:32 -05:00
Andrey 5a735c9059 Native SENT TPS input #5079
only:alphax-4chan
2023-02-22 13:41:43 -05:00
Matthew Kennedy fa9fe1754b
single character typo (#5107) 2023-02-20 04:04:34 -05:00
rusefi fbb59e6b75 Nick wonders if DC wastegate is still FUBAR #5075 2023-02-19 00:36:03 -05:00
Andrey 816d2b01c0 refactoring: better method name 2023-02-19 00:15:12 -05:00
Andrey f99f0e1dcf minor bugfix 2023-02-18 23:58:06 -05:00
Andrey a818d1916f virtual isEtbMode 2023-02-18 23:57:53 -05:00
rusefi 096be69c20 DC is not ETB 2023-02-18 22:39:45 -05:00
rusefi 7d83c7374f wastegateDcStatus 2023-02-18 22:33:44 -05:00
Andrey 331cfbbc8c typo 2023-02-17 22:25:02 -05:00