Commit Graph

2089 Commits

Author SHA1 Message Date
rusefillc 06ccf524dd MAP phase sensing #3544
removing dead implementation
2021-12-16 21:13:55 -05:00
Matthew Kennedy 256df56fa7
Honda K 12+1 decoder adjustment (#3694)
* adjust trigger

* real cranking

* mk
2021-12-14 21:10:01 -05:00
Matthew Kennedy 7e3765650f
adjust mr18 vvt trigger (#3691)
* adjust mr18 trigger

* second gap, why not
2021-12-13 16:33:34 -04:00
Andrey 099f7d5a86 MAP phase sensing #3544
limiting to below cranking RPM limit
2021-12-11 02:56:19 -05:00
Matthew Kennedy 6de8364895
maybe more working MAP sampling (#3689)
* what if we do this

* cleanup

* s

* test
2021-12-11 03:01:28 -04:00
rusefillc 17879ef7de MAP phase sensing #3544 2021-12-09 22:16:42 -05:00
rusefillc 25134644e6 live data this 2021-12-09 22:02:47 -05:00
rusefillc f44370a5b8 MAP phase sensing #3544
gauge name fix
2021-12-08 12:44:43 -05:00
Andrey 3a00fc4767 MAP phase sensing #3544
new implementation seems complete? 360 fix
2021-12-07 21:37:33 -05:00
Andrey 50038167d8 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey 940b04ab24 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
Andrey e72d57438a MAP phase sensing #3544
new implementation
2021-12-07 20:00:04 -05:00
Andrey 6e49d66385 MAP phase sensing #3544
look new unit test!
2021-12-07 16:58:10 -05:00
rusefillc f826fe13aa MAP phase sensing #3544
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
rusefillc 934b005acb trigger sync better gauges/logging 2021-12-06 13:08:41 -05:00
rusefillc 2f45ed205c MAP phase sensing #3544
option to look for high and low peaks
2021-12-05 14:25:26 -05:00
rusefillc 85da6d6ad1 MAP phase sensing #3544 2021-12-04 18:47:14 -05:00
rusefillc 0c91e77749 MAP phase sensing #3544
taking a step back to happy place
2021-12-04 18:21:10 -05:00
rusefillc 45a95db67f MAP phase sensing #3544
trying longer average
2021-12-04 17:06:59 -05:00
Matthew Kennedy 25beb610b0
log actual tooth angle (#3646) 2021-12-02 19:22:33 -05:00
rusefillc fda7a3a775 Engine phase wrap around in log #3645
refactoring & docs
2021-12-02 17:06:20 -05:00
rusefillc e896afe2f6 Engine phase wrap around in log #3645
refactoring & docs
2021-12-02 17:06:20 -05:00
rusefillc 168a899ba9 how many more spelling mistakes?! 2021-12-02 01:06:40 -05:00
GitHub build-firmware Action 36fb3c195d Auto-generated configs and docs 2021-12-01 00:36:32 +00:00
Matthew Kennedy 890cbd8cf2
remove define_constructor (#3640)
* no define_constructor

* jar

* sim needs live doc
2021-11-30 19:31:54 -05:00
rusefillc 5c0795f034 random note 2021-11-26 15:48:42 -05:00
Andrey 0ec8b8d46c reliable 32/2 trigger shape 2021-11-25 20:45:58 -05:00
Andrey 48ed80ffb9 MAP phase sensing #3544 2021-11-24 23:06:52 -05:00
Andrey 228d5ee810 MAP phase sensing #3544 2021-11-24 22:41:49 -05:00
Andrey e2fa1af527 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey c2fa1cea78 minor progress 2021-11-24 22:35:56 -05:00
Matthew Kennedy 3334a6963c
oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
Scott Smith ba4a00d3bb
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData (#3519)
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData

Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp.  It could be better but this is simple
   and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays.  Makes the interface simpler
   and more rigid.  Also saves 4 bytes per Multi*.  Downside is access is now via -> and *,
   not . and (nothing).

Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA

* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?

* No magical templated StaticAlloc thingy.  Just virtual functions.
2021-11-21 04:56:07 -05:00
Matthew Kennedy 9a28e8d938
correctly compute engine revolution number (#3586)
* add param

* first revolution is revolution 0, not revolution 1

* would you look at that, we sync one rev quicker!

* changelog

* rpm value
2021-11-21 09:01:27 +03:00
Matthew Kennedy bb57a4b084
detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
rusefillc ecac07f938 brave refactoring 2021-11-19 23:56:52 -05:00
Matthew Kennedy 692e3d7e9f
adjust miata sync conditions (#3577) 2021-11-19 02:30:05 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Andrey 655b77dc3f random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00
Matthew Kennedy cb032fb1ea
(void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 145316c497
less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
rusefillc 0813266ee1 trigger refactoring & docs 2021-11-14 15:35:11 -05:00
Matthew Kennedy a7ba539e70
math is fun (#3545)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
rusefi e8aebc313a Something something Automatic Compression Release #3442 2021-11-14 15:04:10 -05:00
rusefillc a9bcce88d0 script settings need names! 2021-11-13 22:47:46 -05:00
Matthew Kennedy d591a5ad26
mercedes two lobe trigger testing (#3543)
* mercedes

* config

* break;

* I did the gap ratio math wrong

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
Scott Smith 713083baa5
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. (#3528)
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
Scott Smith 2f4d123052
Change users of MultiChannelStateSequence to use the API (#3524)
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
Scott Smith d4c4db9a12
Move phaseCount into MultiChannelStateSequence (#3520)
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
Scott Smith dac67235c4
Don't keep a separate MultiChannelStateSequence for the trigger emulator, version 2. (#3517)
All it wants is to use the main trigger state, so don't bother copying it.  Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt.  Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes.  And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)

Also remove SimplePwm's 2nd copy of SingleChannelStateSequence.  It served no purpose.

Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-10 07:01:20 -05:00
rusefillc 1db9a02f1d Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. (#3513)"
This reverts commit 280dfa94e7.
2021-11-09 20:42:23 -05:00
Scott Smith 280dfa94e7
Don't keep a separate MultiChannelStateSequence for the trigger emulator. (#3513)
All it wants is to use the main trigger state, so don't bother copying it.  Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt.  Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes.  And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)

Also remove SimplePwm's 2nd copy of SingleChannelStateSequence.  It served no purpose.

Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
Scott Smith 158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping (#3506)
Memory seems more valuable than CPU; use the O(lg n) lookup by angle.  A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Andrey 9ac1575777 reducing complexity 2021-11-07 01:57:32 -05:00
rusefillc 5de6c2a270 typo 2021-11-07 01:51:05 -05:00
rusefillc 20784db801 refactoring - magic constant bad
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
rusefillc 0af09f596c refactoring - magic constant bad
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
rusefillc 6d0dfe4542 refactoring - magic constant bad 2021-11-07 00:09:17 -04:00
rusefillc 656b8c3429 refactoring - magic constant bad 2021-11-07 00:03:16 -04:00
Matthew Kennedy 7590e4c679
log current engine phase on trigger teeth (#3471)
* log phase on trigger teeth

* ui

* guard
2021-11-05 20:02:15 -04:00
Matthew Kennedy 036c1b17d3
make master happy (#3467) 2021-11-05 16:01:13 -04:00
Matthew Kennedy 2b9696442e
nissan MR18DE VVT cam pattern (#3466)
* refactoring nissan trigger

* comments

* plumbing

* b

* enums

* image

* image

* implement decoder

* reshuffle

* don't case unused

* dead trigger enums
2021-11-05 15:33:22 -04:00
Matthew Kennedy 365691cb37
nissan 4yl crank pattern (#3462)
* refactoring nissan trigger

* comments

* plumbing

* b
2021-11-05 07:15:03 -04:00
Matthew Kennedy 59e9d05fc7
extract engine phase function (#3456)
* extract getCurrentEnginePhase

* inject engine ref

* never invalid RPM, use 0 instead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
Andrey 61777564d4 Honda K cam wheels #3405 2021-10-30 21:09:58 -04:00
rusefillc c62fedbe34 Override trigger gaps feature #2734 2021-10-30 10:45:32 -04:00
Andrey a6a969390f Honda K cam wheels #3405 2021-10-28 19:26:59 -04:00
Andrey fbd37ae0e7 dead magic macro 2021-10-28 19:18:50 -04:00
rusefi f0f4513998 VVT to be reported after primary 2021-10-28 16:46:54 -04:00
Andrey 463515e282 Honda K cam wheels #3405 2021-10-28 13:49:54 -04:00
Andrey de350131e6 Honda K cam wheels #3405 2021-10-28 11:40:31 -04:00
Andrey c96e52d6f3 Honda K cam wheels #3405 2021-10-28 10:36:41 -04:00
Andrey b5ae711e2f refactoring: extracting method to improve readability 2021-10-28 10:30:05 -04:00
Andrey 484d078752 Honda K cam wheels #3405 2021-10-26 22:47:19 -04:00
rusefi 30f9c57f70 Honda K cam wheels #3405 2021-10-26 17:29:26 -04:00
rusefillc 4ef959a60e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-25 11:05:45 -04:00
Andrey 229419d04b Honda K cam wheels #3405 2021-10-24 17:12:19 -04:00
rusefillc 8a3f93d6f6 progress 2021-10-24 15:30:17 -04:00
GitHub build-firmware Action 013cd08b35 Auto-generated configs and docs 2021-10-23 23:05:27 +00:00
rusefi 274a6d8ba6 triggerinfo progress 2021-10-23 19:01:31 -04:00
rusefillc eb05f4594e very old very dead code 2021-10-20 12:57:07 -04:00
rusefillc 1493973bea very old very dead code 2021-10-20 10:38:36 -04:00
GitHub build-firmware Action 981fc58297 Auto-generated configs and docs 2021-10-17 01:13:47 +00:00
rusefillc 292173f818 progress - live doc generator works again! 2021-10-16 21:08:50 -04:00
rusefillc 4cc1c352c2 better file locations 2021-10-16 20:17:01 -04:00
rusefillc ea87d9c9be Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
dead code
2021-10-14 15:17:09 -04:00
rusefillc 8a2472126a https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern 2021-10-04 19:59:51 -04:00
Andrey b0ae87054a https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern 2021-10-04 19:29:58 -04:00
rusefillc eccdf18eec https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern 2021-10-04 11:25:27 -04:00
rusefillc 308a798eaa Nick has RPM spikes and engine hiccups #3269 2021-10-03 01:48:34 -04:00
rusefillc 58cd414c0a miata NB1 is a weird half-VR/half-Hall sensor 2021-09-29 14:31:36 -04:00
Matthew Kennedy 35e1a7cc0c
fix (#3253) 2021-09-21 00:27:14 -04:00
rusefillc 7fc88fa304 https://rusefi.com/forum/viewtopic.php?f=5&t=2117 2021-09-12 13:58:03 -04:00
Andrey 301f5e7ec4 https://rusefi.com/forum/viewtopic.php?f=5&t=2117 2021-09-12 11:56:12 -04:00
rusefi 83c0372729 https://rusefi.com/forum/viewtopic.php?f=5&t=2117
Ford TFI PIP
2021-09-11 23:42:05 -04:00
rusefi 48c516f9f7 https://rusefi.com/forum/viewtopic.php?f=5&t=2117
Ford TFI PIP
2021-09-11 23:16:22 -04:00
Matthew Kennedy c72bd07179
enable address sanitizer (#3217)
* enable asan

* lua

* this is dead and leaky

* leaky nissan

* fix pwm generator use-after-stack

* initializers

* prevent problems in case of invalid trigger shape

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
Andrey G 39664d98a0
Subaru svx trigger update (not vvt) (#3210)
* trigger: subaru: SVX: some comments

* trigger: subaru: svx: fix crank 2 offset

* trigger: subaru: svx: rework a bit

* trigger: subaru: svx: fix dtc position
2021-09-04 11:42:12 -04:00
rusefillc 526340de78 Subaru svx vvt #3210
helping or not
2021-08-31 06:05:57 -04:00
rusefillc 1a1b7f95c0 Subaru svx vvt #3210
helping or not
2021-08-31 05:54:04 -04:00
rusefillc 6ea76921f4 docs 2021-08-31 04:27:31 -04:00
rusefillc 3d4ff9083b Pavel says there are issues 2021-08-11 04:16:51 -04:00
Andrey 08dff4ceb6 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 06:16:19 -04:00
Andrey 167f2dbba0 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 04:56:56 -04:00
Andrey a2d18fa0b7 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 04:45:40 -04:00
rusefillc c1275af29c reduce chance of invalid CAM setting fix #3105 2021-08-03 22:15:40 -04:00
Matthew Kennedy 25414ebdad
yet more pch (#3068)
* big pch energy

* put back ramdisk stub

* tests are happy

* h743 nucleo

* kinetis

* I love deleting code!

* make stepper happy

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy 0d983855b9
instant rpm uses full engine cycle (#3077)
* instant rpm uses full engine cycle

* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Matthew Kennedy b52d50bbf2
Use pch in lots of files (#3066)
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
2021-07-26 01:05:17 -04:00
rusefillc 23842bf143
safer NB2 progress (#3041)
* safer NB2 progress

* one step back
2021-07-23 16:43:24 -04:00
Andrey 6fc693aea2 VVT position of first cam is off on first cycle fix #2987 2021-07-22 01:02:37 -04:00
Andrey 24cfbeba35 Nissan VVT trigger decoder #2887 2021-07-21 23:08:56 -04:00
Matthew Kennedy d520d12490
adjust nb2 vvt sync (#3019)
* test existing implementation

* nb2 vvt pattern sync

* update test
2021-07-21 20:07:28 -04:00
Andrey f2cb242090 simplify quad vvt test #3018
better parameter name and explicit constraint clarification
2021-07-21 17:45:35 -04:00
Matthew Kennedy 5f3464b204
Fix prepareEventAngles for symmetrical crank triggers (#2982)
* fix and make code legible

* update test to check every tooth

* symmetrical crank

* simplify findTriggerPosition

* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey 9345e5d2e0 NB2 trigger shape does not seem to match JimStim #2980
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc 6da3310d97 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 02:03:55 -04:00
Andrey 180d7bc899 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 01:10:13 -04:00
Andrey ffe2fe3271 refactoring 2021-07-17 00:56:50 -04:00
Andrey d583c91a7a refactoring 2021-07-17 00:53:51 -04:00
Andrey d16d6dd58d kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:46:39 -04:00
Andrey f54b3cd1b2 refactoring 2021-07-17 00:46:39 -04:00
Andrey df558303d3 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:27:56 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey f87d1c425e trigger signal debug pins - logic level output #2959 2021-07-16 17:18:03 -04:00
Andrey ee91af5c73 trigger signal debug pins - logic level output #2959 2021-07-16 16:42:26 -04:00
rusefi 92dee23061 FATAL on NB2 tune jim stim input signal fix #2965 2021-07-14 21:18:05 -04:00
Andrey 2442d8f2d8 FATAL on NB2 tune jim stim input signal #2965 2021-07-14 16:05:53 -04:00
Andrey e1c41ff798 FATAL on NB2 tune jim stim input signal #2965 2021-07-14 16:03:00 -04:00
Andrey bb9835fe58 trigger signal debug pins - logic level output #2959 2021-07-13 20:33:27 -04:00
Andrey 994230be65 trigger signal debug pins - logic level output #2959 2021-07-13 20:15:55 -04:00
Andrey f028c4d727 trigger signal debug pins - logic level output #2959 2021-07-13 18:16:32 -04:00
rusefillc 090725d273 reducing warnings 2021-07-13 14:50:10 -04:00
Matthew Kennedy aef0732509
fix vvt indication (#2926)
* wrap logic

* rename gauges

* names and ranges

* binary log

* we actually don't need that warning

* values auto wrap

* values auto wrap

* bye warnings

* comparison
2021-07-12 16:29:07 -04:00
Andrey f92bf80e3f reducing code duplication 2021-07-06 00:09:35 -04:00
Andrey 8e30c513da unit tests pass on Linux fail on Windows fix #2902
reducing code duplication
2021-07-05 23:51:13 -04:00
Andrey 9fb7e39864 Nissan VVT trigger decoder #2887 2021-07-05 23:39:39 -04:00
Andrey 70424ac7b5 Nissan VVT trigger decoder #2887
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
Andrey 293bf45763 refactoring - reusing magic constant 2021-07-05 23:07:36 -04:00
Andrey cf2e2a6451 Nissan VVT trigger decoder #2887
that looks like one bug
2021-07-05 22:44:20 -04:00
Andrey 1b174bd4b3 Nissan VVT trigger decoder #2887
that's all very strange
2021-07-05 22:17:26 -04:00
Andrey 064c1612e3 restore testQuadCam #2911 2021-07-05 21:04:09 -04:00
rusefi de63a5cd17 Nissan progress!!! 2021-07-05 20:29:49 -04:00
Andrey c2fafbb695 Nissan 2021-07-05 18:43:39 -04:00
rusefillc f498524611 Nissan 2021-07-05 18:38:34 -04:00
rusefillc 9814264bdf Nissan 2021-07-05 18:37:53 -04:00
Andrey 3853e7721a Nissan VVT trigger decoder #2887
one step back
2021-07-03 12:42:07 -04:00
Andrey 2737045eab Nissan VVT trigger decoder #2887 2021-07-03 12:26:31 -04:00
Andrey 0cf095a943 Nissan VVT trigger decoder #2887 2021-07-03 12:02:00 -04:00
Andrey 23e7022e55 Nissan VVT trigger decoder #2887 2021-07-03 11:08:22 -04:00
Andrey f5e937fe2b refactoring: getShaftSynchronized 2021-07-03 10:37:03 -04:00
Andrey 152eea43b1 Nissan VVT trigger decoder #2887 2021-07-03 10:15:41 -04:00
Andrey 36165bed44 Nissan VVT trigger decoder #2887 2021-07-03 09:43:27 -04:00
Andrey e5a1b68eb2 Nissan VVT trigger decoder #2887 2021-07-02 20:28:15 -04:00
Andrey 0af1e8ee59 Nissan progress 2021-07-02 20:12:31 -04:00
Andrey 1660a5b3fd Nissan progress 2021-07-02 19:57:26 -04:00
Andrey 00ea760979 wow we have weird code! 2021-07-02 19:49:00 -04:00
Andrey 9cc82f5068 todo: vvt 2021-07-02 19:06:07 -04:00
Andrey ab8bb3a5cb Nissan VVT trigger decoder #2887 2021-07-01 23:53:53 -04:00
Andrey ae7937402c Nissan VVT trigger decoder #2887 2021-07-01 22:27:43 -04:00
Andrey fccd13247b Nissan VVT trigger decoder #2887 2021-07-01 21:48:47 -04:00
Matthew Kennedy 025c32de00
Stricter miata sync (#2891)
* strict mazda trigger shape

* this is an even better gap

* sync point moved so things are different now

* fix

* update instantrpm in test

* s

* s

* this is safer

* test

* tests

* instant rpm

* cleanup
2021-07-01 21:29:04 -04:00
Matthew Kennedy 8569f028d6
Fix pre sync timestamp copy (#2892)
* fix tests

* fix pre sync copy

* this fixes the issue
2021-07-01 18:58:28 -04:00
Andrey 50e25605b8 Nissan VVT trigger decoder #2887 2021-07-01 17:28:52 -04:00
Matthew Kennedy 5c60973dd8
Consolidate hwHandleShaftSignal (#2875)
* consolidate trigger input

* merge functions

* comment

* dead

* hw vs. not hw

* stray comma

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Andrey 41060a1235 VW warnings on cranking #2861
same resilience for some other triggers
2021-06-27 13:29:09 -04:00
Andrey 21c06e1514 refactoring maybe making code reuse more possible in the future 2021-06-27 13:00:01 -04:00
Andrey 2e252022aa VW warnings on cranking #2861 2021-06-27 12:31:18 -04:00
Andrey 82439b3ffd so many wonderful discoveries 2021-06-27 00:54:38 -04:00
Andrey 4463ca1fdb depressing code comment 2021-06-26 23:01:47 -04:00
Andrey 5adb42f939 refactoring - crankDivider etc etc 2021-06-26 22:42:53 -04:00
Andrey eaff083377 refactoring - explicit read method 2021-06-26 22:17:07 -04:00
Andrey 1822426d0c refactoring - explicit read method 2021-06-26 22:11:42 -04:00
Andrey a5eeb19c4d refactoring - explicit read method 2021-06-26 22:07:45 -04:00
Matthew Kennedy ce4eb2b55d
fix trigger changed logic (#2860)
* reenable

* fix

* longer interval between updates

* only deinit hard trigger outputs if necessary

* init logic

* init order

* warning

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
rusefillc 0af5de0934
Minor change of Miata NA trigger shape #2855 #669 (#2856)
* Minor change of Miata NA trigger shape #2855 #669

* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey 942eb46471 Trigger: warning code on normal engine start up #669
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
Andrey c40f801e6d Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 12:50:19 -04:00
Andrey 12067584e9 helping build? 2021-06-25 12:28:55 -04:00
Andrey 5e87b326f2 refactoring 2021-06-25 12:01:59 -04:00
Andrey 266e50f4ca Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey 66b091a5a5 Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:30:06 -04:00
Andrey 0c97b4bc83 refactoring: reducing code duplication 2021-06-25 10:55:46 -04:00
Andrey 71fdfe6756 giving unit tests a chance to use tdcMarkCallback 2021-06-25 01:31:53 -04:00
Andrey 3092164e48 Minor change of Miata NA trigger shape #2855 #669 2021-06-24 22:21:30 -04:00
Andrey 03f18cd0c8 OMG dead code?! 2021-06-24 22:01:57 -04:00
Andrey c13bb8dbe1 looks like this parameter is very well used now? 2021-06-21 02:12:14 -04:00
Andrey G e561836c58
trigger: subaru 7+6: update cranck angles, add comments (#2789) 2021-06-02 19:19:52 +03:00
Andrey G 8ee700bf76
Subaru svx (#2777)
* Revert "hiding 3rd channel for now"

This reverts commit 50682816ac.

* trigger subaru SVX: disable cranck #2 channel

* Board subaru-eg33: fix D10 pin defined twice

* Board subaru-eg33: renumber ignition ouput according cylinder order

* board subaru eg33: use common_make.sh to get dfu files

* board subaru-eg33: update default configuration
2021-05-31 04:25:57 -04:00
Andrey 39bc62ff2e SVX 2021-05-30 19:59:13 -04:00
Andrey 50682816ac hiding 3rd channel for now 2021-05-29 04:09:12 -04:00
rusefillc 157732d5aa https://rusefi.com/forum/viewtopic.php?f=16&t=2027 2021-05-27 05:50:59 -04:00
Andrey 4216080e49 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 06:07:31 -04:00
Andrey 9f6ed75582 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 05:29:41 -04:00
Andrey 2581a53e0d subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 04:46:17 -04:00
Andrey 0ad11168e8 Override trigger gaps feature #2734 2021-05-25 17:19:20 -04:00
rusefillc cc861e1862 Subaru 7+6 trigger refactoring, not changing gap ratio much 2021-05-25 16:31:37 -04:00
Andrey cd5653ff84 Override trigger gaps feature #2734 2021-05-23 20:52:18 -04:00
Andrey bd48753682 Override trigger gaps feature #2734 2021-05-23 20:06:19 -04:00
Andrey cbb6ca0c7c Override trigger gaps feature #2734 2021-05-23 19:58:03 -04:00
Andrey 17f07b6b0e Override trigger gaps feature #2734 2021-05-23 19:51:00 -04:00
David Holdeman 6d4060d824
Doxygen titles (#2728)
* move addRow call

* undo submo bump

* add header titles
2021-05-22 22:10:58 +03:00
rusefillc be931e41d5 docs 2021-05-02 23:46:30 -04:00
rusefillc 2575c8beeb Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2021-04-30 01:05:23 -04:00
rusefillc 10858ae371 https://rusefi.com/forum/viewtopic.php?f=16&t=1996 2021-04-25 09:34:40 -04:00
rusefillc 02d4cde3c4 https://rusefi.com/forum/viewtopic.php?f=16&t=1996 2021-04-25 09:18:35 -04:00
rusefillc ac2d0b99cd https://rusefi.com/forum/viewtopic.php?f=2&t=1993 2021-04-24 22:54:50 -04:00
rusefi 3c9f7174ba improving QC process 2021-04-23 00:45:36 -04:00
rusefi 3e44135947 improving QC process 2021-04-22 21:23:20 -04:00
Matthew Kennedy a70f113b77
finish it off: remove scheduleMsg (#2575)
* finish it off

* one more logger ptr

* fwd decl

* Revert "one more logger ptr"

This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.

* unused

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
Matthew Kennedy c26987b96b
Destroy all shared logger (#2574)
* most of shared logger

* a few more

* one more

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy ad71016862
rip the bandaid: find-replace most of scheduleMsg (#2572)
* biiiig find replace

* more trivial find replace

* pwm

* almost all of them

* few more

* gpio

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefillc 2b6345070f WOW major scheduling drama on NB2 running with Proteus #2533 2021-04-15 19:12:09 -04:00
rusefillc 2b8ec15071 WOW major scheduling drama on NB2 running with Proteus #2533
totally same numbers for NB1 just simpler code
2021-04-15 18:44:37 -04:00
rusefillc 3c6c4595c2 WOW major scheduling drama on NB2 running with Proteus #2533
removing weird comments
2021-04-15 18:22:23 -04:00
rusefillc 79e0d6ebd4 dead code - same value set by 's->initialize' 2021-04-13 01:11:03 -04:00
rusefillc 01344ec851 Kawasaki KX450F trigger wheel #2538 2021-04-13 00:24:52 -04:00
rusefillc 027a9efdc8 https://rusefi.com/forum/viewtopic.php?p=40383 2021-04-11 18:20:35 -04:00
rusefillc debd15991e Kawasaki KX450F trigger wheel #2538 2021-04-09 12:44:28 -04:00
rusefillc 2032e5fdb8 Kawasaki KX450F trigger wheel #2538 2021-04-08 22:16:14 -04:00
rusefillc 6c89cdf637 CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534 2021-04-08 14:39:26 -04:00
rusefi 3f914bf3ed trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 15:17:01 -04:00
rusefillc 40c50adf88 trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 12:16:23 -04:00
rusefillc e02f09495b trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 01:21:28 -04:00
rusefillc 9753b6e020 'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528 2021-04-04 23:12:07 -04:00
rusefillc f3c46f2720 refactoring 2021-04-04 23:03:51 -04:00
rusefillc 488f6fed47 todo? 2021-04-04 22:05:55 -04:00
Andrey G bbe3291ccd
hip9011: get callback from spark on each cylinder (#2499)
* hip9011: get callback from spark on each cylinder

* hip9011: cleanup unused
2021-03-27 14:12:49 -04:00
Matthew Kennedy 1c473934b9
plumbing for multiple vvt (#2488)
* plumb multiple vvt

* fix test

* s

* fix barra while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
Matthew Kennedy 5e88376e2c
barra vvt cam pattern (#2483)
* barra vvt cam pattern

* two tooth sync

* I think this needs to be here too
2021-03-22 07:48:29 -04:00
Andrey G 89b631a794
Hip9011 and cleanups (#2477)
* hip9011: move hipCs out of EnginePins to hip9011 driver

* hip9011: cleanup debug output, save few RAM bytes

* Supress few signed vs unsigned warnings
2021-03-20 08:40:36 -04:00
Matthew Kennedy be70524ced
harden against various no-boot scenarios (#2468)
* zero length trigger

* validate config

* validate cylinder count

* wrong type on cylinder count

* invalid comment

* invalid SPI
2021-03-17 09:24:13 -04:00
Matthew Kennedy 3072d54717
dead code, warnings (#2461) 2021-03-15 10:23:19 -04:00
Matthew Kennedy e0763c6994
stop trigger emulator PWM when disabled (#2443)
* simplify trig emulator

* spelling is hard

* fix various builds

* spelling again

* add command/button for external stimulation

* enable hw stim for HW-in-loop test

* s

* I does spelling good

* clear flag when disabled

* generate enough for console build

* don't disable that

* this test needs external stimulation enabled

* import

* ui improvements

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-11 08:38:52 -05:00
rusefillc 4e35176e81 TDC Trigger Position #2428
any single-tooth primary trigger should automatically run with "useOnlyPrimaryForSync = true;"
2021-03-08 00:00:48 -05:00
rusefillc e4bd0f6815 removing dead code - initialize() sets 'true' already 2021-03-07 23:37:54 -05:00
Matthew Kennedy 57b79ab6bb
trigger decoder timer (#2427)
* part 2

* stale comment

* include

* why was this a macro

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 16:35:58 -05:00
Matthew Kennedy 5a4c24f9a5
virtual zero timer (#2426)
* virtual zero timer

* it would help to call the correct function

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 15:32:41 -05:00
rusefillc ce78123eb0 M62T vanos support #2243 2021-02-08 22:21:02 -05:00
rusefillc 081357ca5e M62T vanos support #2243 2021-02-08 22:07:14 -05:00
rusefillc 2d99e77c95 M62T vanos support #2243 2021-02-08 21:50:31 -05:00
rusefi 0d6dfbb501 M62T vanos support #2243 2021-02-08 21:28:57 -05:00
rusefi 6793b5d8fc M62T vanos support #2243 2021-02-08 20:38:38 -05:00
rusefi 6b10de5616 refactoring: naming consistency 2021-02-08 18:20:53 -05:00
rusefillc 953990d10b Trigger pattern request Škoda Favorit fix #2302 2021-02-06 20:53:30 -05:00
rusefillc d95ba6b443 Trigger pattern request Škoda Favorit #2302 2021-02-06 20:12:58 -05:00
Matthew Kennedy 870857df36
add option to disable ETB if engine not spinning (#2280)
* config/ui

* trigger central mods

* implement
2021-02-05 17:19:57 -06:00
rusefillc 29db28f077 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 11:06:32 -05:00
rusefillc 8ff61e9e68 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 09:50:20 -05:00
rusefillc 7eb5816c33 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:44:14 -05:00
rusefillc 11f9bf16f6 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:18:11 -05:00
rusefillc 9a2cc6b3c9 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 22:49:49 -05:00
rusefillc 4bb9762e2e extracting runtime state from trigger central 2021-01-31 22:41:17 -05:00
rusefillc 869e4cfc49 vvt/cam events to pass index 2021-01-31 22:24:45 -05:00
rusefillc dc80e4e6cb M62T vanos support #2243 2021-01-26 22:54:25 -05:00
rusefillc e219638f60 M62T vanos support #2243 2021-01-26 21:43:23 -05:00
rusefillc b6f5e5f34d M62T vanos support #2243 2021-01-26 21:16:47 -05:00
rusefi 10e980e293 Revert "Save more space in the angle cache (#2228)"
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
Matthew Kennedy c7ca1b2ef4
Save more space in the angle cache (#2228)
* store event angles in a scaled field

* tests

* comment
2021-01-18 18:31:06 -05:00
Andrey G baea67eccf
Simplify Makefile, unify board.mk files (#2229)
* Proper way to add lis302 driver

* Proper way to add license directory to includes

* Makefile: simplify

All ChibiOS stuff is accumulated in ALLCSRC, ALLINC and so on.

* board.mk: append sources and includes to ALLSRC, ALLCPPSRC, ALLINC

* Cypress: fix CANv2 includence into build
2021-01-17 09:32:06 -05:00
Matthew Kennedy 6a1b9db952
save 1440 bytes (#2226) 2021-01-16 21:22:30 -05:00
Matthew Kennedy 60f70a3721
clean up some includes (#2227)
* cleanup

* make c happy
2021-01-16 09:45:45 -05:00
Matthew Kennedy bdacda558c
fix instant rpm (#2180)
* consumers

* impl

* instant rpm in idle timing
2021-01-14 20:45:55 -05:00
Matthew Kennedy a5266cd6ef
part of 2217 which may fix it alone (#2220) 2021-01-11 08:01:54 -05:00
Andrey G 2af32084f4
gpio helper (#2195)
* gpios: isBrainPinValid helper

* LCD HD44780: do not touch pins if DM_NONE or invalid gpio

* Fix isEnabled checks for GPS and Joystick

* LCD HD44780: writePad use this method wider
2021-01-08 20:01:26 -05:00
Matthew Kennedy f4dcf0f397
generate triggers.txt from parametric test (#2186)
* add new test

* comment

* remove old

* main cleanup

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
rusefillc 6c01aedbb0 RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
2021-01-04 23:44:31 -05:00
rusefillc 8c38664084 RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
2021-01-04 23:34:19 -05:00
rusefillc 43f37c677a RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912

fixing build?
2021-01-04 22:13:59 -05:00
rusefillc 8c7ab1cbe3 RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
2021-01-04 22:00:37 -05:00
rusefillc 8fb32b517b Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-04 21:30:54 -05:00
rusefillc 9b5d45cb04 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-04 21:05:16 -05:00
rusefillc b1499d8a7f RAM efficiency of VR crank trigger shapes #2182 2021-01-04 00:26:05 -05:00
rusefillc b3e3248d71 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 14:05:24 -05:00
rusefillc 15665484e5 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 13:52:53 -05:00
rusefillc 8f06008239 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 13:34:00 -05:00
rusefi 719ad92681 FATAL while bench testing VR #2153 2021-01-01 14:07:52 -05:00
Matthew Kennedy 19bf208cde
use limp mgr for trigger disable (#2145)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 18:12:36 -05:00
rusefillc c0cbc2a31f VR_HW_CHECK_MODE 2020-12-21 13:33:09 -05:00
rusefi 3bafda26cd proteus_f4_hardware_QC_special_build 2020-12-20 11:17:38 -05:00
Matthew Kennedy 6168bcea80
Fix gpio reinit race condition (#2098)
* fix unregister api for gpio

* consumers

* guard with a critical section

* index

* guard less

* unregister under lock

* fix reinit

* dead flag

* fix most tests

* initialize properly

* initialize properly

* assertions in tests

* fix message

* we must lock earlier to be truly safe

* this was using huge memory

* devirtualize
2020-12-18 17:18:12 -05:00
Matthew Kennedy ebc786bc94
init pins (#2095) 2020-12-18 01:30:17 -05:00
rusefillc 314e9ef580 TT_SUBARU_7_WITHOUT_6 2020-12-13 17:46:48 -05:00
rusefi eae865d4de subi ops 2020-12-13 16:41:53 -05:00
rusefi f8803da107 poke 2020-12-13 16:31:47 -05:00
rusefi 38bcd63e13 maybe this would just work? 2020-12-13 16:22:02 -05:00
rusefillc 9b4a1fff7b clang warnings again #2055 2020-12-11 10:33:00 -05:00
rusefillc 64fdfba435 dead code 2020-12-10 21:45:25 -05:00
rusefillc 9400af5452 GM x24 is a well defined trigger needs hard-coded tdcPosition fix #2054 2020-12-10 19:38:33 -05:00
rusefillc e6bfd9a2ed trigger lifecycle 2020-12-09 12:19:25 -05:00
rusefillc 7bdd047955 basic hw in the loop - pwm self validation #2028 2020-12-08 05:30:12 -05:00
rusefillc 5cda628c8b basic hw in the loop - pwm self validation #2028 2020-12-08 05:07:03 -05:00
rusefillc 824f87c2d0 basic hw in the loop - pwm self validation #2028 2020-12-08 04:52:49 -05:00
Matthew Kennedy 22c74895a6
put back safe part of #2005 (#2036)
* put back some safe bits

* dumb typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 22:28:29 -05:00
rusefillc 9efd231915 minor fixes 2020-12-06 19:25:48 -05:00
rusefillc b3d45b909f Revert "switch rpm calculator to use timer class (#2005)"
This reverts most of a26ed3eb5a commit.
2020-12-06 18:05:53 -05:00
Matthew Kennedy a26ed3eb5a
switch rpm calculator to use timer class (#2005)
* add api

* rpm calculator

* fix fsio

* fix float

* remove wrong comment

* fix timer

* clang didn't like this

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
rusefillc 6200569f28 6.1 Hemi V8 decoder fix #2010 2020-12-04 16:50:26 -05:00
rusefillc eaba91e1fd 6.1 Hemi V8 decoder #2010 2020-12-04 16:33:29 -05:00
rusefillc be2a34a956 refactoring: magic constants 2020-12-04 16:24:19 -05:00
rusefillc 2524b7b8c2 6.1 Hemi V8 decoder #2010 2020-12-04 16:03:27 -05:00
rusefillc e730c2c0b1 6.1 Hemi V8 decoder #2010 2020-12-04 15:33:07 -05:00
rusefillc 9221a12d95 6.1 Hemi V8 decoder #2010 2020-12-04 15:22:53 -05:00
rusefillc 61925aad15 all triggers should be documented way nicer #2001 2020-12-04 14:00:49 -05:00
rusefillc 6496fd5a64 all triggers should be documented way nicer #2001 2020-12-04 13:54:16 -05:00
rusefillc e138621202 all triggers should be documented way nicer #2001 2020-12-04 11:58:26 -05:00
rusefillc 8e13892736 6.1 Hemi V8 decoder #2010 2020-12-04 01:02:09 -05:00
rusefillc 0a23e82baf 6.1 Hemi V8 decoder #2010 2020-12-04 00:30:22 -05:00
rusefillc 4c3eae5676 FORD ST170 CAM TRIGGER PATTERN fix #2009 2020-12-03 23:54:08 -05:00
rusefillc f021c37cc1 DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT fix #2008 2020-12-03 23:12:30 -05:00
rusefillc c55120372b DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT #2008 2020-12-03 21:31:58 -05:00
Matthew Kennedy f1f64bd3e5
add timer since last trigger tooth (#2004)
* add elapsed time to timer

* store trigger time

* fsio method

* don't do a 64b divide

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-03 11:13:45 -05:00
rusefillc 745038c4a7 more dead code 2020-12-03 10:49:20 -05:00
rusefillc dd9e431782 dead code matches Mazda SOHC 2020-12-03 01:36:43 -05:00
rusefillc a2036ebc70 dead trigger, this would now be vvt+60/2 2020-12-03 01:22:57 -05:00
rusefillc 0ba97379fb all triggers should be documented way nicer #2001 2020-12-02 22:17:38 -05:00
Matthew Kennedy 55379463c0
remove (#1985) 2020-11-23 20:10:17 -05:00
Matthew Kennedy a68cbae0dc
Remove trigger listener list (#1886)
* avoid 64b on hot path

* no tooth log when fast

* use crit section locker

* final

* only flip pins if not also self stim

* only trace if doing work

* slightly drop lateDelay

* trace if not bailing out

* remove listener array
2020-10-17 08:00:11 -04:00
Matthew Kennedy 7eeb60a8a0
trigger/scheduler perf improvements (#1885)
* avoid 64b on hot path

* no tooth log when fast

* use crit section locker

* final

* only flip pins if not also self stim

* only trace if doing work

* slightly drop lateDelay

* trace if not bailing out
2020-10-16 11:04:27 -04:00
Matthew Kennedy a9e2a5cd1e
fix (#1863) 2020-10-07 14:59:24 -04:00
Matthew Kennedy c9fdde4472
remove virtual calls from hot path (#1857)
* const ref-ify

* no virtual 

* even more const

* tests

* fix tests
2020-10-05 16:42:50 -04:00
Matthew Kennedy 5925a5f4bd
const ref-ify trigger (#1856)
* const ref-ify

* tests
2020-10-05 14:22:59 -04:00
Matthew Kennedy dd6b02d555
we don't need two loops (#1855) 2020-10-05 08:57:00 -04:00
Matthew Kennedy 3aa4f2bd97
trigger decode cleanup and perf (#1853)
* trigger decode cleanup

* test config ptr patchup

* disable CDM by default
2020-10-04 19:29:26 -04:00
rusefillc 348b387483 Trigger performance: variable gapTrackingLength #1851
cool change but looks to have made zero difference
2020-10-04 13:05:49 -04:00
rusefillc 53ece86a88 fixing Kinetis build 2020-10-04 03:04:01 -04:00
rusefillc 96a126d60f 60/2 perf grab #1850
unused parameter
2020-10-04 02:09:12 -04:00
rusefillc 030ec42ac7 60/2 perf grab #1850
a) removing more of stack validating - one validation within the deepest method would be enough

b) un-wrapping main callback loop for explicit order of execution
2020-10-04 01:43:02 -04:00
rusefillc 6b95579706 60/2 perf grab #1850 2020-10-04 01:26:29 -04:00
rusefillc c9d3d1f01a 60/2 perf grab #1850 2020-10-04 01:04:15 -04:00
rusefillc e2ca642f97 60/2 perf grab #1850 2020-10-04 00:15:40 -04:00
rusefillc e5b8e0e515 new VVT trigger shape? #1847 2020-10-03 10:39:43 -04:00
rusefi 23e0851101 adding 1+16 trigger 2020-09-28 21:18:47 -04:00
rusefi 1adc9444a8 removing third copy of same values 2020-09-28 20:58:21 -04:00
rusefi a086b64361 VVT support for VAG trigger #883 2020-08-29 18:37:13 -04:00
rusefi 16d16f9634 TriggerConfiguration getPrintPrefix 2020-08-29 17:25:42 -04:00
rusefi 327b67c1db VVT support for VAG trigger fix #883 2020-08-27 01:01:03 -04:00
rusefi 4e5f53493d common sense change? "should be safe" famous last words 2020-08-27 00:31:59 -04:00
rusefi 2b77901e53 VVT support for VAG trigger #883 2020-08-27 00:06:10 -04:00
rusefi 10a6661fa5 VVT support for VAG trigger #883 2020-08-26 23:35:11 -04:00
rusefi e4386be937 VVT support for VAG trigger #883 2020-08-26 20:57:11 -04:00
rusefi c27a79760c const 2020-08-26 17:37:15 -04:00
rusefi 0c5db46438 const 2020-08-26 17:30:13 -04:00
rusefi 2ddf6ad717 VVT support for VAG trigger #883 2020-08-25 16:19:23 -04:00
rusefi 639e5be4d9 another attempt at dead code 2020-08-25 15:58:56 -04:00
rusefi ce01c1bfaa VVT support for VAG trigger #883 2020-08-25 13:14:46 -04:00
rusefi b09091774a VVT support for VAG trigger #883 2020-08-25 12:45:18 -04:00
rusefi bfd5fb88d5 oh, here it is 2020-08-25 01:38:56 -04:00
rusefi b5098eb331 VVT support for VAG trigger #883 2020-08-25 01:24:15 -04:00
rusefi b0ad2fcb29 better variable name 2020-08-25 01:07:32 -04:00
rusefi 540eef5e0d VVT support for VAG trigger #883 2020-08-25 00:59:07 -04:00
rusefi 5f5a16867a VVT support for VAG trigger #883
a bit of dead code?
2020-08-24 02:31:27 -04:00
rusefi a98c622b54 VVT support for VAG trigger #883 2020-08-24 02:23:13 -04:00
rusefi 3a2670d5de VVT support for VAG trigger #883 2020-08-24 02:07:58 -04:00
rusefi 7867e83e43 VVT support for VAG trigger #883 2020-08-24 02:01:50 -04:00
rusefi 95bd50da94 VVT support for VAG trigger #883 2020-08-24 01:21:42 -04:00
rusefi adf899e338 Allow negative VVT position feedback #1713 2020-08-23 11:49:46 -04:00
rusefi e936c2742c self-stimulation RPM is wrong by 50% if switching from NA6 to NB2 configuration fix #1682 2020-08-08 17:00:14 -04:00
rusefi 5925ca5125 trigger and VSS hw integrated testing #1668 2020-08-08 11:45:02 -04:00
rusefi 74f8efd7e1 Trigger gap-check toothDuration array samples time at any event? fix #1658 2020-07-30 19:24:55 -04:00
Matthew Kennedy fc112d2526 dead code 2020-07-29 02:32:48 -07:00
rusefi d52fb0b168 better unit test logging 2020-07-20 13:38:33 -04:00
rusefi 49e9e08c65 better unit test logging 2020-07-19 15:47:21 -04:00
rusefi fbfef8290c better unit test logging 2020-07-19 14:17:15 -04:00
Matthew Kennedy b11c5cd8c8
switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi afc763f068 better VVT progress 2020-05-15 21:33:25 -04:00
rusefi 194e85b855 VVT progress 2020-05-15 21:10:15 -04:00
rusefi 18760bb699 toyota 2jz progress 2020-05-15 16:35:18 -04:00
rusefi d3785b543e VVT_INACTIVE 2020-05-14 23:13:32 -04:00
dron0gus a2565b7849
triggers: add Subaru SVX trigger (3 sensors) (#1433) 2020-05-14 20:40:47 -04:00
rusefi f233628c2c lovely, yet another minor confusion 2020-05-13 01:16:05 -04:00
rusefi 38ec6d812d https://github.com/rusefi/hw_microRusEfi/issues/157 2020-05-12 23:37:12 -04:00
rusefi 8bc2c403d6 34-2 3 cam Toyota wheel progress 2020-05-10 18:10:50 -04:00
rusefi 1f692c4a9b 34-2 3 cam Toyota wheel progress 2020-05-10 18:03:11 -04:00
rusefi 3e506a674a 34-2 3 cam Toyota wheel progress 2020-05-10 15:22:50 -04:00
rusefi 342a331e1c 34-2 3 cam Toyota wheel progress 2020-05-10 11:54:21 -04:00
rusefi 7071d63cad 34-2 3 cam Toyota wheel progress 2020-05-10 11:54:04 -04:00
rusefi a9b15e3cee that's embarrassing 2020-05-10 02:36:01 -04:00
rusefi 919afd35e8 removing some unneeded flexibility 2020-05-10 01:34:43 -04:00
rusefi d18bf76fb5 34-2 3 cam Toyota wheel progress 2020-05-10 00:42:33 -04:00
rusefi 8d91cc65cc 34-2 3 cam Toyota wheel progress 2020-05-09 23:47:51 -04:00
rusefi e451e3c4aa 34-2 3 cam Toyota wheel 2020-05-09 01:51:04 -04:00
rusefi 4ea0a3de26 nicer error messages 2020-05-09 01:49:17 -04:00
rusefi 6661c66e62 34-2 3 cam Toyota wheel progress 2020-05-09 01:15:55 -04:00
rusefi 3575962da6 docs 2020-05-04 22:31:47 -04:00
Matthew Kennedy 1f16228bdb
Perf Trace Improvements (#1383)
* add tid field to thread

* change perf trace format

* trace consumers

* Update java parsing

* guard for test + kinetis

* stubs

* ram

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-29 10:53:35 -04:00
rusefi 88bbbb6c33 VVT miata trying to crank with random phase #1278 2020-04-26 20:50:49 -04:00
rusefi 1b84406e77 dead code 2020-04-26 17:40:12 -04:00
rusefi e18ee8c097 Bosch vvt shape #1368 2020-04-25 22:23:53 -04:00
rusefi 23e3d05d35 Bosch vvt shape #1368
skeleton
2020-04-25 19:50:43 -04:00
Matthew Kennedy a8f466c615
trigger emulator refactoring (#1358)
* trigger gen refactoring

* missed one

* fix makefile

* commentary

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-24 14:00:06 -04:00
Matthew Kennedy 1bad5f3047
don't store self stim in config (#1356)
* kill

* add bench test

* fix
2020-04-23 22:38:14 -04:00
rusefi 387643047f docs 2020-04-20 23:44:59 -04:00
rusefi bae38f03ce docs 2020-04-20 22:42:34 -04:00
rusefi 71e7fb7e50 TT_RENIX_66_2_2_2 2020-04-19 14:54:02 -04:00
rusefi b287b2f339 TT_HONDA_K_12_1 2020-04-19 14:23:01 -04:00
rusefi c665e6b65d progress towards renix 66-2-2-2 2020-04-19 09:59:55 -04:00
rusefi be497685a0 Renix 44-2-2 2020-04-18 22:20:17 -04:00
rusefi 114b34a583 better trigger definition API 2020-04-18 20:28:03 -04:00
rusefi c166ee9d58 Fresh generated - auto 2020-04-18 16:40:59 -04:00
rusefi 1ee95abde8 progress 2020-04-17 14:02:10 -04:00
rusefi ed0e5e2aac multi-channel Tuner Studio tooth logger #1284 2020-04-17 12:14:45 -04:00
rusefi 205f6fea83 fixing build 2020-04-15 21:09:05 -04:00
rusefi e5f97a4ccf more verbose 2020-04-15 20:07:56 -04:00
rusefi 04f652b7e4 fixing build? 2020-04-15 19:50:07 -04:00
rusefi 5c4eb10c52 multi-channel Tuner Studio tooth logger #1284 2020-04-15 19:10:54 -04:00
rusefi e32aa5266b multi-channel Tuner Studio tooth logger #1284 2020-04-14 15:17:15 -04:00
Matthew Kennedy ff867b9301
fix warnings (#1282)
* warnings

* don't need to template those
2020-04-12 09:39:14 -04:00
rusefi b51da343d1 making magic constants a bit less fragile 2020-04-11 01:22:31 -04:00
rusefi 6a94a58796 progress 2020-04-10 13:32:06 -04:00
rusefi fb06813e12 DBG_TRIGGER_SYNC merged into DBG_TRIGGER_COUNTERS 2020-04-10 13:19:54 -04:00
rusefi 607692695e safer version by Dron0Gus 2020-04-06 11:29:09 -04:00
rusefi b43da0d0f8 killing nbVvtIndex 2020-04-05 11:43:45 -04:00
rusefi 907b80efa9 code style 2020-04-01 19:00:56 -04:00
Matthew Kennedy 8fd9842310
cleanup extern mess (#1237)
* cleanup

* move outside define
2020-03-29 19:06:03 -04:00
Matthew Kennedy 2c809e4475
Remove old monitoring timestamps (#1217)
* remove monitoring timestamps

* adv map

* fuel calc

* map avg

* printing

* spark logic

* hip 9011

* new traces

* s

* missed a few
2020-03-24 20:19:19 -04:00
Matthew Kennedy 4740f525ee
save some ram (#1211)
* remove dead stuff

* why store those pointers twice?
2020-03-22 19:06:29 -04:00
rusefi 16930da2d3 hard-coding miata Nb2 VVT Ratio magic 2020-03-09 16:59:19 -04:00
Matthew Kennedy 9f26e6d894
fix icu trigger polarity (#1177)
* fix polarity

* fix confusing names
2020-03-08 08:57:21 -04:00
rusefi a33d479683 CLT stops working when using 2-0 custom trigger wheel #1171 2020-03-06 01:31:04 -05:00
Matthew Kennedy 986b80671b
warnings (#1169) 2020-03-03 08:37:02 -05:00
Matthew Kennedy 397907a06f
Support disabling most/all features (#1162)
* this flag did nothing

* guard features properly
2020-02-26 18:16:35 -05:00
rusEfi 299dd7e836 better trigger LiveDocs 2020-02-22 15:39:00 -05:00
rusefi e9a3b218c4 miata vvt trigger decoding is broken #1145 2020-02-14 13:02:27 -05:00
rusefi ed2b7578a5 Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:50:50 -05:00
rusefi 75d9417131 miata vvt trigger decoding is broken #1145 2020-02-14 00:37:36 -05:00
rusefi 0d1f45422e cam/vvt decoder 2020-02-05 01:49:33 -05:00
rusefi f6e7e8871a VVT refactoring & assertions for VVT test 2020-01-31 01:49:10 -05:00
rusefi d48a57d599 refactoring: extracting DEEP_IN_THE_PAST_SECONDS contant 2020-01-31 01:21:56 -05:00
rusefi b6fe6555e0 lovely tiny bug which mostly affects NB2 with an impossible one tooth crank trigger wheel 2020-01-30 01:47:34 -05:00
rusefi cf087218c9 micro refactoring 2020-01-30 01:20:41 -05:00
rusefi 688a85a25d reusing constant 2020-01-28 00:27:30 -05:00
rusefi d9b96fe509 extracting class & codes clean-up 2020-01-28 00:16:33 -05:00
rusefi 282cd8e1ac trigger refactoring 2020-01-26 14:20:55 -05:00
rusefi a53d9c587a trigger refactoring 2020-01-26 13:51:35 -05:00
rusefi 241d491625 trigger refactoring 2020-01-26 12:02:54 -05:00
rusefi 67bda5f088 good thing we have CI - fixing build 2020-01-26 09:00:46 -05:00
rusefi 03d2aae681 reducing code duplication 2020-01-26 06:35:51 -05:00
rusefi 51ab9f5b57 reducing code duplication 2020-01-26 06:28:33 -05:00
rusefi 080e7e12db trigger refactoring 2020-01-26 06:12:01 -05:00
rusefi 154b679491 refactoring: de-coupling trigger decoder and engine 2020-01-26 03:48:25 -05:00
rusefi db2ab72d12 refactoring trigger 2020-01-26 03:33:45 -05:00
rusefi af8383ae3a trigger refactoring 2020-01-25 11:22:25 -05:00
rusefi 0f23faba28 trigger refactoring 2020-01-25 02:00:33 -05:00
rusefi aabc50e7a9 refactoring trigger 2020-01-24 13:42:09 -05:00
rusefi 3056154fe6 refactoring trigger 2020-01-23 13:39:50 -05:00
rusefi cc1c4c9dcb refactoring - de-coupling trigger 2020-01-22 13:25:35 -05:00
rusefi 06cdb7cde6 refactoring 2020-01-22 01:22:44 -05:00
rusefi 9d0c5540d8 refactoring 2020-01-22 00:40:26 -05:00
rusefi 0c3f73c2b4 code style 2020-01-21 01:47:58 -05:00
rusefi 83b1ca00a4 code style 2020-01-21 01:40:11 -05:00
Matthew Kennedy ba0c48e0ac use NT_PER_SECOND instead of convert from microseconds (#1107)
* add NT_PER_SECOND

* missed a few

* inject tooth logger timestamp

* inject
2020-01-19 22:23:41 -05:00
rusefi 53433c88a7 trigger shape constraint validation 2020-01-14 03:54:46 -05:00
rusefi 27c44f08f4 reducing complexity? 2020-01-13 22:25:51 -05:00
rusefi 4cc206a393 reducing complexity 2020-01-13 22:23:46 -05:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 713ccf76bb header style 2020-01-13 02:30:49 -05:00
rusefi 0bab01369a refactoring: no need to specify parameter manually 2020-01-12 10:43:02 -05:00
rusefi 113fc4be36 refactoring 2020-01-12 05:17:42 -05:00
Matthew Kennedy a6a1335adb Require tooth reference time for scheduleByAngle (#1091)
* injection

* injectors

* add edge timestamp to ShaftPositionListener

* scheduleByAngle require edgeTimestamp

* schedule with nt not us

* oops, these were missing from this branch
2020-01-09 23:45:13 +03:00
Matthew Kennedy 851c6041b1 Inject timestamps in to hwHandleShaftSignal (#1090)
* injection

* injectors
2020-01-09 21:19:11 +03:00
rusefi b83a5310be happy new year 2020-01-08 00:02:40 -05:00
rusefi 9956ee6c15 maybe improvement to console trigger messages 2019-12-25 15:05:02 -05:00
rusefi 537a95a9b4 removing legacy perf code 2019-12-23 21:56:16 -05:00
rusefi fde9a449cf random refactoring: hopefully not changing byte size of any variables but clarifying/fixing type between ticks, US and MS 2019-12-21 21:11:09 -05:00
rusefi 6ca549ca34 refactoring & fixing build 2019-12-21 20:43:11 -05:00
rusefi 9403b2a8fc fixing build is my most favourite time! 2019-12-13 18:02:24 -05:00
rusefi af4f20551b getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi 62481d7fe8 The Big Refactoring of 2019: folder structure #723 2019-12-08 13:21:35 -05:00
rusefi c5cfd21a70 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi d6471a84bc Refactor Trigger System #635
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
rusefi 717abd6b67 Refactor Trigger System #635
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
rusefi 28a12d9d04 typo 2019-12-06 00:07:27 -05:00
rusefi c0450ebd9b following the pattern 2019-12-04 07:33:56 -05:00
rusefi 5055797f6b The Big Refactoring of 2019: folder structure #723 2019-12-04 01:15:52 -05:00
rusefi 813b6aa6ce The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
rusefi 500315b042 refactoring - updating name according to new reality 2019-12-03 14:39:11 -05:00
rusefi eb305f0265 #490 2019-12-03 00:29:12 -05:00
rusefi d007a7f902 making new scheduling API avalable 2019-12-02 22:28:32 -05:00
rusefi 12a828b391 codes clean-up 2019-12-02 20:16:41 -05:00
rusefi 0583fd0b6c misc clean-up 2019-12-02 10:03:50 -05:00
rusefi 366805a1ab MapAveragingCallback schedules all cylinders at once #974 2019-11-24 23:20:24 -05:00
rusefi 04f6913d56 MapAveragingCallback schedules all cylinders at once #974
saving pennies
2019-11-24 20:48:25 -05:00
rusefi 730df561df pausing aux work for now 2019-11-24 12:45:38 -05:00
rusefi 6f50cae286 improving API? 2019-11-24 00:15:44 -05:00
rusefi 1cb2f92142 more correct variable names 2019-11-23 23:49:39 -05:00
rusefi 7ee657d238 aux valves unit test 2019-11-23 22:55:21 -05:00
rusefi af60a46229 making progres on angle-based scheduling 2019-11-23 20:36:40 -05:00
rusefi 1bb3f2698c making progres on angle-based scheduling 2019-11-23 19:47:53 -05:00
rusefi f0c4817e1b 'triggerEventAngle' not really needed 2019-11-23 17:44:44 -05:00
rusefi aa4967383a explicit list field to simplify code navigation 2019-11-23 17:04:51 -05:00
rusefi 56ff75004b consistency 2019-11-23 15:53:22 -05:00
rusefi 8edf6c8d38 bug: aux valve actions can overlap 2019-11-23 10:34:43 -05:00
rusefi c606bb27ac aux overlap debugging 2019-11-22 18:50:46 -05:00
rusefi b8ce0daf85 more code into unit tests 2019-11-20 01:42:03 -05:00
rusefi ad7e36c228 refactoring 2019-11-20 01:35:08 -05:00
Matthew Kennedy 93d24dfc0b Merge remote-tracking branch 'origin/master' into perf-tracing 2019-11-19 16:28:58 -08:00
rusefi 7dfdfc6378 docs & code formatting 2019-11-19 18:17:03 -05:00
rusefi ebe6a4b981 v12 done right 2019-11-17 09:32:12 -05:00
rusefi 6b3b090eea refactoring: reducing complexity? 2019-11-17 09:02:49 -05:00
rusefi 6456374eb8 v12 2019-11-16 16:00:50 -05:00
rusefi 15a571fb3e this is not great :(
#639
#971
2019-11-11 22:19:35 -05:00
rusefi 79e049a5f8 Strange INJ1 signal behavior (when the frequency of scheduler's timer is less than 1MHz) #996
new advanced debugging: hardware pins
2019-11-10 12:39:47 -05:00
rusefi 42cd78fbd5 Trying latest gcc 9 #1001 2019-11-07 11:28:49 -05:00
rusefi d2e24cf2e5 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-06 20:33:40 -05:00
rusefi 8525c48036 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-06 18:26:50 -05:00
andreika-git 4e19c96cb6 Kinetis timer freq. fix & config update (#999)
* Kinetis: fix timer frequency

* More silentTriggerError - it really helps a lot!

* Kinetis: gen_config.bat update
2019-11-06 14:45:55 -05:00
rusefi df291f4421 Missing dwell altogether in some corner cases fix #796 2019-11-06 00:31:24 -05:00
rusefi 5106ada9ce Missing dwell altogether in some corner cases #796
flirting with the fix but not yet the fix
2019-11-06 00:10:44 -05:00
rusefi eb4ceda52b refactoring: removing unused parameter 2019-11-05 22:49:11 -05:00
rusefi d4574a3cab evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 22:40:33 -05:00
rusefi 22453f8392 nicer enum name 2019-11-03 21:19:13 -05:00
rusefi 5c46ad25a7 review feedback 2019-11-03 10:36:35 -05:00
rusefi 47eaea3da3 scramblr reports sync issues on NB1 fix #990 2019-10-30 21:01:23 -04:00
rusefi 74e0c20235 flipping NB1 trigger definition 2019-10-29 21:19:00 -04:00
rusefi 8cf19d3d12 refactoring & verbose trigger to simulator 2019-10-29 21:12:44 -04:00
rusefi fe77766b2b bugfix around verboseTriggerSynchDetails - 64 bits on stack was causing broken messages 2019-10-29 18:20:55 -04:00
rusefi 88348ebd09 refactoring: reducing code duplication 2019-10-21 23:47:40 -04:00
Matthew Kennedy 10a6d6eb8b fix wwae (#980) 2019-10-17 00:06:54 -04:00
rusefi 5f9fdfe9a6 Revert "Revert "Performance improvement: call GetBaseFuel less (#979)""
This reverts commit 7eb9947fd4.
2019-10-16 23:02:24 -04:00
rusefi 7eb9947fd4 Revert "Performance improvement: call GetBaseFuel less (#979)"
This reverts commit 95e51f13
2019-10-16 22:29:19 -04:00
Matthew Kennedy 95e51f1399 Performance improvement: call GetBaseFuel less (#979)
* Remove extra calls to getInjectionDuration

* increase callback frequency
2019-10-16 22:13:10 -04:00
Matthew Kennedy 4db3fa46cd fix #977 (#978) 2019-10-15 05:24:33 -04:00
Matthew Kennedy d6e065f99e Merge remote-tracking branch 'upstream/master' into perf-tracing 2019-10-14 23:45:39 -07:00
Matthew Kennedy d76670d946 trace all the things 2019-10-14 23:34:12 -07:00
rusefi 12137fc7cd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
Matthew Kennedy f52bdecb80 profile all the things 2019-10-13 13:14:08 -07:00
rusefi 5cb90d0e1b preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
Matthew Kennedy 763b17fb50 experiment 2019-10-11 17:43:21 -07:00
Matthew Kennedy 29804cbc8a move tsOutputChannels to header (#970) 2019-10-08 21:02:51 -04:00
rusefi 4574aaccce I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 2acdbf308b something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi a65c8c9295 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi 4e26bd2fd2 refactoring 2019-10-08 02:01:41 -04:00
rusefi ade7ad158a typo & better field name 2019-10-08 01:36:03 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 1ab488e4b4 refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi ca67249522 refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi 8424723024 refactoring: better variable names 2019-10-08 00:42:47 -04:00
rusefi 0d31cdddea refactoring: better parameter name 2019-10-08 00:30:20 -04:00
rusefi 53231f7b49 refactoring: smarter C++ initialization 2019-10-08 00:27:49 -04:00
Matthew Kennedy d1da567b85 fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
rusefi 533087f475 ETB target is using integer values #945
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
rusEfi d5ef749761 s/NULL/nullptr/ 2019-09-22 08:22:35 -04:00
rusefi c59d8164c6 unit tests progress 2019-09-19 21:41:52 -04:00
rusefi db018723f7 refactoring: better field name 2019-09-09 19:39:13 -04:00
rusefi 8d1d88bf73 instant RPM for idle control #925
refactoring
2019-09-09 14:41:26 -04:00