rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,974 Commits 1 Branch 0 Tags 1.2 GiB
Commit Graph

560 Commits

Author SHA1 Message Date
rusefi bb3cb0ba22 Revert "Require redundant tps for ETB (#2037)" 
This reverts commit 4f1085a8
 2020-12-07 01:11:32 -05:00
rusefi 4f4bb95770 Revert "Split ETB in to interface + implementation headers (#2040)" 
This reverts commit d9a82c09
 2020-12-07 01:11:19 -05:00
Matthew Kennedy d9a82c09af
Split ETB in to interface + implementation headers (#2040) 
* split etb interface

* mocks

* fix master while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-12-07 00:29:09 -05:00
Matthew Kennedy 4f1085a87a
Require redundant tps for ETB (#2037) 
* mod sensor api

* require redundancy

* fix tests

* check that it fails

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-12-07 00:05:06 -05:00
rusefillc 2e8ae3ca94 refactoring 2020-12-06 19:04:23 -05:00
rusefillc 8739e192f5 basic hw in the loop - pwm self validation #2028 2020-12-06 18:39:50 -05:00
Matthew Kennedy a5ba9d54dc
fix etb unit test idle hardware (#1991) 
* move check to etb

* give it a sensor to read
 2020-11-26 19:21:42 -05:00
rusefillc d4d7e7583b Starter is engaged on start-up in pull-up configuration #1969 2020-11-26 10:41:22 -05:00
Matthew Kennedy 750070a496
fix etb wastegate percent output (#1988) 
* wastegate etb should use percent

* percent_t

* fix test
 2020-11-25 21:14:06 -05:00
Matthew Kennedy 492498f8d0
Boost tolerance (#1986) 
* tolerate invalid closed loop config when in open loop mode

* fix test
 2020-11-25 07:27:24 -05:00
Matthew Kennedy 866038900f
adjust boost (#1975) 2020-11-22 18:30:19 -05:00
Matthew Kennedy 66687158c5
no feed forward for wastegate (#1971) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-11-19 20:51:30 -05:00
rusefillc ee7e1880a2 Something something unit test ETB does not work #1966 2020-11-18 20:12:58 -05:00
rusefillc e29911114a Starter seems to be engaged forever #1965 2020-11-18 20:01:02 -05:00
rusefillc 4c9c8d42bf Starter seems to be engaged forever #1965 2020-11-18 19:51:51 -05:00
Matthew Kennedy 774de10f40
undo 1946 (#1957) 2020-11-17 17:07:56 -05:00
rusefillc 014cae25db DC not ETB refactoring 2020-11-16 20:07:12 -05:00
rusefillc cd7cefb669 DC not ETB refactoring 2020-11-16 20:05:35 -05:00
rusefillc 5ad36e655f DC not ETB refactoring 2020-11-16 19:51:36 -05:00
rusefillc 2a3a2d7191 DC not ETB refactoring 2020-11-16 19:43:00 -05:00
rusefillc 724abc68f5 DC not ETB refactoring 2020-11-16 19:28:30 -05:00
Matthew Kennedy 2f4294ac4d
minor perf tweaks (#1946) 
* only start PWM if needed

* put important stuff first

* use conversion

* this broke the logic
 2020-11-16 00:06:11 -05:00
Matthew Kennedy 0e3673e78c
remove idle thread; just call from periodicSlowCallback (#1924) 
* remove thread

* remove ui
 2020-11-11 21:47:19 -05:00
Matthew Kennedy d992bab241
Move all DECLARE_ENGINE_PTR etc to one place (#1937) 
* restructure

* guard c++

* idle too

* status_loop.h
 2020-11-11 19:06:04 -05:00
Matthew Kennedy 3241a43a2d
extract idle hardware to its own file (#1923) 
* extract idle hardware

* should fix the build
 2020-11-03 18:06:32 -05:00
rusefi 2c322006d8 Output pin init/deinit needs a linked list #1803 2020-11-03 00:09:42 -05:00
Matthew Kennedy 6605877326
gppwm debug (#1895) 
* dbg gppwm

* fix channel

* TS guard
 2020-10-21 22:49:38 -04:00
rusefi 9060aff46c code style 2020-10-21 22:13:18 -04:00
rusefi 2ce0bef9b9 refactoring 2020-10-19 22:44:44 -04:00
Matthew Kennedy 06f92807cc
second PID config for wastegate (#1889) 
* remove

* cleanup

* implement ETB parts

* hook up to boost controller

* tests

* consume

* add cfg field

* ui maybe

* fix

* fix

* add wastegate config test
 2020-10-19 08:04:27 -04:00
Matthew Kennedy 42bfad807b
Etb wastegate hookup (#1888) 
* remove

* cleanup

* implement ETB parts

* hook up to boost controller

* tests
 2020-10-18 21:57:04 -04:00
Matthew Kennedy ee5d0bf07b
remove (#1887) 2020-10-18 20:49:42 -04:00
Matthew Kennedy 44653da2e5
Etb function cfg: actually read config (#1884) 
* two throttles one thread

* look at all this RAM!

* add enum

* switch from index to function

* test fixup

* improve init logic

* remove old vw idle mode bit

* add config

* better spot for it

* use config init values

* handle null controller array

* fatal error testability

* test new init config

* defaults

* fix for default config
 2020-10-18 17:26:38 -04:00
Matthew Kennedy 749282c807
more safe parts probably (#1883) 2020-10-15 22:04:42 -04:00
Matthew Kennedy 299a345c1c
etb function config 1 (#1881) 
* this should all be safe...

* test fix
 2020-10-14 22:02:09 -04:00
rusefillc 07a905b1fe revering functional part of 
Etb function cfg, try again #1860
try again from #1831
 2020-10-08 17:09:00 -04:00
Matthew Kennedy 1bce3aa4c0
Etb function cfg, try again (#1860) 
* two throttles one thread

* look at all this RAM!

* add enum

* switch from index to function

* test fixup

* improve init logic

* remove old vw idle mode bit

* add config

* better spot for it

* use config init values

* handle null controller array

* fatal error testability

* test new init config

* defaults

* fix for default config
 2020-10-08 14:12:03 -04:00
rusefillc 367436454d HW CI has failed 11 times since Oct 2 #1849 
Revert "ETB function config (#1831)"

This reverts commit af59c45a
 2020-10-03 22:00:00 -04:00
Matthew Kennedy af59c45adb
ETB function config (#1831) 
* two throttles one thread

* look at all this RAM!

* add enum

* switch from index to function

* test fixup

* improve init logic

* remove old vw idle mode bit

* add config

* better spot for it

* use config init values

* handle null controller array

* fatal error testability

* test new init config

* defaults

* fix for default config
 2020-10-02 20:51:02 -04:00
Matthew Kennedy f1c04efefa
replace ETB index with function enum (#1807) 
* two throttles one thread

* look at all this RAM!

* add enum

* switch from index to function

* test fixup

* improve init logic

* remove old vw idle mode bit
 2020-09-28 16:33:07 -04:00
Matthew Kennedy 1fc55da3ca
two throttles one thread (#1806) 
* two throttles one thread

* look at all this RAM!
 2020-09-18 13:47:49 -04:00
Matthew Kennedy eebded8caa
scale tables using type system (#1776) 
* store scale in the type

* efi ratio

* boost control scaling

* fix boost tests
 2020-09-10 18:44:10 -04:00
rusefi cb2173aad2 merge got confused 2020-09-07 15:05:47 -04:00
rusefi f33b3eda8a Merge remote-tracking branch 'origin/Hellen_fork_point' into master 
# Conflicts:
#	firmware/controllers/algo/engine.h
#	firmware/hw_layer/drivers/drivers.mk
#	firmware/hw_layer/stepper.h
#	firmware/integration/rusefi_config.txt
#	firmware/tunerstudio/rusefi.input
#	simulator/simulator/efifeatures.h
 2020-09-07 15:02:11 -04:00
rusefi ec0d3a8eb2 Hellen says isIdleMotorBusy 
(cherry picked from commit b24246791e)
 2020-09-07 14:43:29 -04:00
rusefi b24246791e Hellen says isIdleMotorBusy 2020-09-07 14:12:21 -04:00
Matthew Kennedy 95798a5246
fix broken master, inject engine ptr to rpmcalculator (#1759) 
* fix

* oops
 2020-09-05 18:49:42 -04:00
rusefi 675cce3854 less hacky testing implementation 2020-09-03 22:52:29 -04:00
rusefi ca21d5b4c2 refactoring 2020-09-03 19:29:15 -04:00
rusefi 540eef5e0d VVT support for VAG trigger #883 2020-08-25 00:59:07 -04:00
Matthew Kennedy 7a3b87656f
guard (#1726) 
* implement

* add bench mode

* add ts cal mode

* TS impl

* include guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-08-23 23:46:33 -04:00
Matthew Kennedy 12bc5eb28b
Auto cal dual etb (#1725) 
* implement

* add bench mode

* add ts cal mode

* TS impl

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-08-23 23:41:35 -04:00
Matthew Kennedy 225e403973 parameter names 2020-07-29 02:22:31 -07:00
rusefi b2db6b604d Weird VAG: DC motor idle valve not ETB #1637 
misc progress
 2020-07-26 15:22:14 -04:00
rusefi a8f45d960a Weird VAG: DC motor idle valve not ETB #1637 
etbTarget gauge in DC idle mode
 2020-07-26 15:07:45 -04:00
rusefi c649b05ebd Weird VAG: DC motor idle valve not ETB #1637 
should be better this way
 2020-07-26 12:19:30 -04:00
rusefi 3857607fc2 Weird VAG: DC motor idle valve not ETB 
#1637
Seattle we might have a problem!
 2020-07-26 12:03:36 -04:00
rusefi d5739815b4 Weird VAG: DC motor idle valve not ETB #1637 2020-07-26 10:54:51 -04:00
Matthew Kennedy d1fde4fe93 make reality match the test 2020-07-26 03:15:17 -07:00
Matthew Kennedy 51a69c7478 clamp idle in VW mode 2020-07-26 03:05:59 -07:00
Matthew Kennedy 7003d6c7ba implement 2020-07-26 02:55:35 -07:00
Matthew Kennedy 5e681cac1a add new options 2020-07-23 02:51:08 -07:00
Andrei b7b50e5cb3 Idle PID improvements 2020-07-22 18:39:09 +03:00
rusefi 5feb91dc8f EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 21:35:01 -04:00
rusefi f7da86983a EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 21:13:04 -04:00
rusefi 0079e8d3f0 EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 19:06:26 -04:00
rusefi 13aef2dd77 EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 18:25:48 -04:00
rusefi 677d5888ed EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 18:11:10 -04:00
rusefi 8f4dd3e175 https://rusefi.com/forum/viewtopic.php?p=37401#p37401 2020-07-10 15:06:55 -04:00
rusefi 29e3c71df4 https://rusefi.com/forum/viewtopic.php?p=37401#p37401 2020-07-10 14:19:51 -04:00
rusefi 1f4c632cf2 https://rusefi.com/forum/viewtopic.php?p=37401#p37401 2020-07-10 14:03:07 -04:00
rusefi 720ade2319 migrate amazing idle from FSIO to less opaque TS #1581 2020-07-08 01:12:08 -04:00
rusefi b1ab455f31 idle_min through FSIO not working as intended 
#1553

we now re-activated idle PID even in deadzone for half a second after A/C toggle
 2020-07-06 16:40:16 -04:00
Matthew Kennedy 26478ec394
Switch fueling to new axes (#1574) 
* switch tables

* missed one
 2020-07-05 18:14:55 -04:00
rusefi 23e6ea5475 idle_min through FSIO not working as intended #1553 2020-07-04 22:01:12 -04:00
rusefi e854410778 idle_min through FSIO not working as intended #1553 
better idle state logging
 2020-07-01 19:10:42 -04:00
rusefi 33eb2eab62 idle_min through FSIO not working as intended #1553 
making logging less confusing
 2020-07-01 16:37:25 -04:00
rusefi 127dd67838 restoring ldmp 2020-06-17 19:03:10 -04:00
Matthew Kennedy 65625deb32
only setup etb if primary sensor configured instead of proxy (#1489) 
* only setup etb if primary sensor configured instead of proxy

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-06-16 21:38:09 -04:00
Matthew Kennedy b906d12268
Fix gppwm properly (#1487) 
* directly control output in onoff mode

* test fixing
 2020-06-11 20:43:26 -04:00
rusefi 98e73987a3 docs 2020-06-01 08:50:54 -04:00
Matthew Kennedy 3a7c6f242b
Hardware pwm (#1283) 
* hard pwm

* fix, comments

* PC6-9 and PD12-15

* PB6-9

* dynamic frequency

* f7 mcuconf

* format

* relocate to common, support variable frequency

* error handling

* oops

* fix test build

* noop kinetis

* better guards

* guard for bl

* guards don't work if they have typos

* more mapping

* oops

* don't use for slow pwm

* enable pwm

* guard properly

* save a little memory

* use less mem

* correct timers

* all your ram are belong to us

* update limit & comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-28 16:02:41 -04:00
rusefi a4329169e9 better file name 2020-05-25 13:02:05 -04:00
Matthew Kennedy 4f334c91d5
warnings (#1462) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-21 01:08:07 -04:00
Matthew Kennedy 9dda1a21bc
Redundant tps (#1427) 
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* partial hookup

* fix

* fix

* bad makefile merge

* use second TPS config

* update test

* update test

* sensor names

* set second pin by default

* fix auto cal

* auto cal both sensors

* add reconfigure of secondary sensors

* gobblin' up your ram

* slow down write a little bit

* put split in debug gauge

* s

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-18 14:32:00 -04:00
rusefi 4364eea7a2 refactoring: extracting magic constant 2020-05-08 22:05:44 -04:00
rusefi b4f6c6488f helping build 2020-05-08 21:39:35 -04:00
dron0gus f78889c1b3
idle thread: debug output for bipolar stepper (#1409) 2020-05-08 20:05:05 -04:00
dron0gus 5987fb8b88
[SAFE] Debug cleanups (#1403) 
* electronic throttle: inprove debug

* idle thread: show debug info for configured idle driver

* gpio-chips: make private functions static
 2020-05-06 20:06:50 -04:00
Matthew Kennedy 74d13c391f
Rewrite boost control in new closed loop framework (#1342) 
* rewrite boost

* test

* fix build

* tests

* open loop test

* test closed loop

* fix names

* typo

* tests

* mock boost setOutput

* needs more virtual

* fix boost logic

* switch to TPS based open loop

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-06 08:40:42 -04:00
Matthew Kennedy 20a95bdcf1
ETB auto-PID: auto set values in TS (#1400) 
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* auto cal

* wire up bench testing

* auto gains too

* s

* fix

* rearrange a bit

* inject

* remove unused bit

* mock repair

* move

* add maintainconstantvalue

* add disable button

* cleaning

* move state inside

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-06 08:39:02 -04:00
Matthew Kennedy 3052f2ab7b
Support 4 h-bridges (#1392) 
* update dc motor api

* add more etbio

* get out of two arrays

* hand generate enough

* forgot engine param

* ram

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-05-02 17:54:28 -04:00
rusefi 965c06c079 https://github.com/rusefi/rusefi_documentation/issues/37 2020-04-29 18:41:40 -04:00
Matthew Kennedy ba6ec4ac51
TPS Auto Calibration with ETB (#1382) 
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* auto cal

* wire up bench testing

* s

* fix

* rearrange a bit

* inject

* remove unused bit

* mock repair

* guard for ECUs without ETB
 2020-04-28 19:31:41 -04:00
Matthew Kennedy d728b1ca48
Minor ETB improvements (#1381) 
* fix pid reset and pedal failure

* pause control later

* test pauseEtbControl

* update tooltip + field name

* update test
 2020-04-28 16:52:40 -04:00
rusefi 44facf1140 useful content from Move ETB control to a thread #1374 2020-04-28 08:05:18 -04:00
Matthew Kennedy fe4b531aeb
Move ETB control to a thread (#1374) 
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* fix dt

* re-resize ram
 2020-04-28 07:22:31 -04:00
rusefi 1b84406e77 dead code 2020-04-26 17:40:12 -04:00
Matthew Kennedy f128b33694
General purpose PWM: implementation & tests (#1366) 
* config

* significant digits

* renumber enum, no need for a "none"

* ui

* impl base

* error handle MAP

* init & update

* don't need arg

* don't lie about sensor

* fix test build

* test stub

* initialize

* null check

* fix clamping

* test output

* types & enums

* don't need param

* test getOutput

* fix

* output pin instead of brain pin

* default config
 2020-04-26 14:06:28 -04:00
Matthew Kennedy df2db7036d
ETB autotune in its own function (#1350) 
* pull out autotune

* oops
 2020-04-22 22:22:28 -04:00
Matthew Kennedy 99489cff67
Improve ETB idle control (#1319) 
* compress idle pos

* fix tests for new behavior
 2020-04-20 17:29:03 -04:00
Matthew Kennedy 1a5e0a42f8
Inject idle to ETB (#1335) 
* inject idle position

* pointer

* etb idle tests

* extract mocks

* ops

* test negative case too

* don't convert for etb

* guard
 2020-04-20 16:26:35 -04:00
rusefi 656331ebe9 reducing code duplication 2020-04-20 15:57:03 -04:00
Matthew Kennedy e04008610a
ETB: inject pedal map (#1334) 
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

* inject pedal map

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-20 14:34:45 -04:00
rusefi 934898f903 idle duty cycle clamping 2020-04-20 14:11:40 -04:00
Matthew Kennedy 0619575716
ETB testing: output, position clamping (#1333) 
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-20 13:52:20 -04:00
rusefi ad7c4f23bc Better handling in case of ETB idle without ETB #1332 2020-04-19 23:55:27 -04:00
Matthew Kennedy 8aac233a5f
rewrite etb tests with gmock (#1330) 2020-04-19 20:32:41 -04:00
Matthew Kennedy 75b009bbae
Closed loop controller base & ETB testing (#1322) 
* closed loop controller base

* etb tps test

* closed loop controller tests

* test support

* update gtest

* fix for change

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-19 17:18:47 -04:00
Matthew Kennedy 044766ec70
New clt consumers part 1 (#1301) 
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup
 2020-04-15 09:48:17 -04:00
Matthew Kennedy 6481b9df0a
filter ETB autotune results (#1281) 
* Astrom-Hagglund

* enums

* comments

* dead

* fix

* changed enum

* ts guard

* safety

* etb autotune debug channels

* filter results

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-11 22:28:50 -04:00
Matthew Kennedy b526b43864
etb autotune (#1274) 
* Astrom-Hagglund

* enums

* comments

* dead

* fix

* changed enum

* ts guard

* safety

* etb autotune debug channels

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-11 22:15:49 -04:00
Matthew Kennedy 001ef27eb8
support ETB disable pin (#1273) 
* config & hand gen

* board configs

* add dc motor support

* initialization

* also set duty to zero

* use disable in etb

* fix proteus default

* add TS fields

* I guess we needed 8 bytes

* :D

* comment

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-10 17:27:13 -04:00
Matthew Kennedy 9831c8c874
simplify (#1275) 2020-04-10 08:12:16 -04:00
dron0gus 00417b1040
idle: add two coil idle valve support (#1271) 2020-04-06 17:55:41 -04:00
Matthew Kennedy 345bf61bd5
Goodbye, old TPS (#1266) 
* clear out tps

* boost control

* aux valves

* launch, aux valves

* unused field
 2020-04-05 19:33:33 -04:00
Matthew Kennedy 7d5df29fbd
yet more tps consumers (#1258) 
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

* old tests

* kill dead stuff

* cleanup

* more

* fix

* test

* s

* fix signature

* fix test

* comment

* priming pulse

* remove mock tps

* remove more dead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-05 09:11:25 -04:00
Matthew Kennedy 36477d348d
remove ETB controlPinMode (#1260) 2020-04-04 08:41:45 -04:00
Matthew Kennedy 9f75c0cea6
TPS consumers: idle and ignition and obd2 and lcd (#1254) 
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-03 19:59:08 -04:00
Matthew Kennedy 1fe39e81e0
fix (#1251) 2020-04-03 07:48:12 -04:00
Matthew Kennedy b197c6ff07
run ETB on new TPS (#1248) 
* run ETB on new TPS

* why did we include all those...?

* init tps for etb test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-02 21:33:49 -04:00
Matthew Kennedy 22267e5479
Replace hasPedalPositionSensor (#1245) 
* remove

* add Sensor::hasSensor

* consume in etb

* remove unused state

* don't use it there either

* format

* fix up tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2020-04-02 08:04:12 -04:00
rusefi 0edb791cff partial revert 2020-04-02 00:37:02 -04:00
rusefi e9665e1ddc less ETB in case of critical 2020-04-02 00:32:03 -04:00
Matthew Kennedy 50cd6549a2
Fully switch acc pedal to new sensors (#1212) 
* proxy sensor

* header

* idle

* can

* settings

* remove old mocking

* remove old impl

* etb

* oops, gotta actually register it

* fix test

* structured bindings ftw!

* driver intent for stepper

* tear out old

* oops too much
 2020-04-01 20:21:03 -04:00
Matthew Kennedy d541e04a7d
Friendlier pin names (#1233) 
* enable TS error readout

* friendlier text for common errors

* improve comment

* friendlier ADC errors

* ign/inj names

* more pin names
 2020-03-29 19:07:07 -04:00
Matthew Kennedy 8fd9842310
cleanup extern mess (#1237) 
* cleanup

* move outside define
 2020-03-29 19:06:03 -04:00
rusefi d1b5a51400 progress 2020-03-28 20:56:58 -04:00
rusefi c778a44c8f #203 2020-03-26 19:22:14 -04:00
Matthew Kennedy 53679fab54
Finally rename injector_central to bench_test (#1229) 
* bench test rename

* rename consumers

* good lord what are all of these externs doing

* fix tests
 2020-03-26 08:03:55 -04:00
Matthew Kennedy 2349d74f0b
Default to applyPinState (#1219) 
* make applyPinState default

* consumers

* format
 2020-03-25 18:14:09 -04:00
rusefi 1955af0b6c random code inspired by Ola 2020-03-24 19:50:04 -04:00
rusefi 391b0ec368 progress 2020-03-23 23:51:51 -04:00
rusefi dc769e7a2a progress 2020-03-23 23:15:44 -04:00
rusefi 0e6aacb3b8 progress 2020-03-23 23:06:52 -04:00
rusefi c0e141026c code style 2020-03-23 22:31:24 -04:00
rusefi 165160bb40 random header clean-up 2020-03-23 09:00:57 -04:00
Matthew Kennedy 4740f525ee
save some ram (#1211) 
* remove dead stuff

* why store those pointers twice?
 2020-03-22 19:06:29 -04:00
Matthew Kennedy c19f3e4caa
Control stepper with dual H-bridges (#1121) 
* divorce stepper from hw

* oops

* ptr not ref

* hbridge stepper

* typo

* hook up twin h

* hook up hardware

* use config field

* hook up motor repo

* guard tests

* whoops

* ok fix for real

* ok that's the right thing

* do full stepping

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.stagpad.local>
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
 2020-03-10 15:18:29 -04:00
Matthew Kennedy 40b0783205
Split out EtbHardware (#1168) 
* start tear out motor

* fix

* nuke reconfig

* guard for test

* test fixing

* format, condense headers

* fix todos

* undo todo

* format
 2020-03-03 17:56:50 -05:00
rusefi 04a4e2bca3 ETB: expand automated testing #115 2020-02-22 23:18:02 -05:00
Matthew Kennedy 20465107ed
boost format & cleanup (#1126) 2020-02-05 06:47:31 +05:30
rusefi 6888b09c53 Three wire idle air valve #1122 
ugly but should work to begin with
 2020-02-04 01:22:04 -05:00
960 4b4e683957
Boost pr (#1114) 
* boost control

* cleanup

* Delete rusefi_config.txt

* Add files via upload

* Delete rusefi_config.txt

* Add files via upload

* Update rusefi.input

* Update boost_control.cpp
 2020-02-02 03:56:21 -05:00
rusefi 7c714e5727 opening the door to boost controller! 2020-01-31 14:29:52 -05:00
rusefi f6e7e8871a VVT refactoring & assertions for VVT test 2020-01-31 01:49:10 -05:00
Matthew Kennedy fa5b5b76fb Separate stepper control logic from hardware (#1101) 
* divorce stepper from hw

* oops

* ptr not ref

* ptr not ref

* whitespace

* null check
 2020-01-15 02:18:15 -05:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 19df4661ab better method name 2020-01-10 02:02:22 -05:00
rusefi b83a5310be happy new year 2020-01-08 00:02:40 -05:00
Matthew Kennedy 5c85d53e16 Pass action_s instead of callback/param (#1084) 
* change action

* consumers

* fix test

* didn't mean to add those

* simplify

* fix simulator

* fix sim for real

* oy

* maybe this time the simulator will actually be fixed, for real

* don't rely on undefined behavior
 2020-01-07 00:41:18 -05:00
rusefi 0075f9492c ETB documentation improvement? 2019-12-30 10:25:52 -05:00
rusefi 1c7de824e2 typo 2019-12-14 18:33:08 -05:00
rusefi 236d952335 progress towards ETB controller mocking 2019-12-13 13:52:34 -05:00
rusefi e9e7a66cf8 etbActualCount logic to handle the scenario where only one ETB is present 2019-12-13 12:50:34 -05:00
rusefi af4f20551b getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
Matthew Kennedy 0e674f7eca ETB Encapsulation & C++ Conventions (#1049) 
* encapsulate etb stuff, c++ conventions

* remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE

* reduce include dependencies

* Revert "reduce include dependencies"

This reverts commit c529bbbf757cd9070f6e00616f84b1229eeb768e.

* Revert "remove DECLARE_ENGINE_PTR/INJECT_ENGINE_REFERENCE"

This reverts commit ca98b18cd4dae24b993d1263a18daf509dcd54b9.
 2019-12-10 19:37:04 -05:00
rusefi 813b6aa6ce The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
andreika-git 2a39c69f51 iacPidMultTbl + EFI_IDLE_PID_CIC + kinetis_hysteresis (#1043) 
* rename EFI_IDLE_INCREMENTAL_PID_CIC -> EFI_IDLE_PID_CIC

* Impl. IacPidMultTable

* Kinetis: Trigger Comparator Hysteresis settings (+adaptive mode)
 2019-12-04 00:37:32 -05:00
rusefi de36f76882 The Big Refactoring of 2019: folder structure #723 2019-12-03 23:52:44 -05:00
rusefi 1c96d9541e refactoring 2019-12-02 23:08:18 -05:00
rusefi 1d817e9768 dual throttle re-init bugfix thank you andreika! 2019-12-01 09:39:34 -05:00
rusefi 3ed889486e making things nicer with dual ETB settings 2019-11-30 17:38:33 -05:00
rusefi b961edc654 refactoring 2019-11-30 16:49:40 -05:00
rusefi b04166d173 that's how we can move all fields one by one from boardConfiguration to engineConfiguration 
my approach is to move fields from the bottom of BC struct
 2019-11-30 10:24:37 -05:00
rusefi f80fe51092 all ETBs to run in same HW mode 2019-11-30 01:00:54 -05:00
rusefi 5fa7e082c8 all ETBs to run in same HW mode 
taking a step back and going to bed :(
 2019-11-30 00:39:00 -05:00
rusefi 2952cd923e all ETBs to run in same HW mode 2019-11-30 00:25:33 -05:00
rusefi a78dc22bf1 better state validation, better error codes 2019-11-29 23:41:26 -05:00
rusefi 73e3edc3d8 dual ETB seems to work! 2019-11-29 20:15:29 -05:00
rusEfi e2074388ff dual ETB seems to work! 2019-11-29 19:06:50 -05:00
rusefi 76ca1aacb7 all ETBs to run in same HW mode 2019-11-29 19:02:12 -05:00
rusEfi 799027c2e9 all ETBs to run in same HW mode 2019-11-29 16:51:51 -05:00
rusefi 07f71c8dfa steps towards dual ETB 2019-11-28 15:24:30 -05:00
rusefi 067aa0aeee steps towards dual ETB 2019-11-27 22:07:36 -05:00
andreika-git 1808642af1 Starter relay + Hardcoded 'FSIO' + simulator fix (#1032) 
* Starter Relay: gui + built-in FSIO impl.

* Hardcoded 'FSIO' replacement for RAM-limited boards

* fix simulator
 2019-11-25 20:08:01 -05:00
Matthew Kennedy 9ee8616cb0 Use templated array references (#1027) 
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
 2019-11-22 23:27:24 -05:00
rusEfi 547d9749df v12 and minor ETB 2019-11-22 23:27:03 -05:00
Matthew Kennedy 579219e8cc inject interfaces to ETB, renaming (#1026) 
* inject interfaces, renaming

* format

* null check

* that was a dumb typo

* fix indent
 2019-11-22 20:53:54 -05:00
Matthew Kennedy bb22296f61 DC motor improvements (#1025) 
* extract interface, comments, conform names

* fwd declare
 2019-11-22 16:30:44 -05:00
rusefi 4faca85fdd following the pattern 2019-11-21 13:35:57 -05:00
rusEfi f9ccaf5f01 steps towards dual ETB 2019-11-21 00:49:38 -05:00
rusefi a5db4819ae making more code testable 2019-11-20 08:46:54 -05:00
rusefi a7b7fd1005 making more code testable 2019-11-20 02:18:17 -05:00
rusefi ad7e36c228 refactoring 2019-11-20 01:35:08 -05:00
rusEfi 36dba6274a ETB docs 2019-11-18 22:25:07 -05:00
rusefi 669c75d44f trying to fix integration tests 
[java] 2019-11-10_13_31_42_194<EOT>: msg,FATAL error: PID::isSame invalid,
     [java] 2019-11-10_13_31_42_194<EOT>: postMessage EngineState: FATAL error: PID::isSame invalid
     [java] 2019-11-10_13_31_42_289<EOT>: Sending packet 4F 00 00 64 01
     [java] 2019-11-10_13_31_42_289<EOT>: output channels header: waiting for 2 byte(s)
     [java] 2019-11-10_13_31_42_290<EOT>: IncomingDataBuffer: 256 byte(s) arrived
     [java] 2019-11-10_13_31_42_290<EOT>: output channels body: waiting for 361 byte(s)
     [java] 2019-11-10_13_31_42_291<EOT>: IncomingDataBuffer: 107 byte(s) arrived
 2019-11-10 16:07:13 -05:00
andreika-git b996190707 Industrial PID Controller (#1002) 
* Implement Industrial PID controller

* Test-Use PidIndustrial in alternator

* Meaningful unit-tests for PidIndustrial
 2019-11-10 13:04:27 -05:00
rusefi ae0456e5fb fine, taking care of more warnings 2019-11-06 19:53:09 -05:00
rusefi cc6381fe96 evil manual merge of https://github.com/DonaldBecker/rusefi 2019-11-05 20:07:55 -05:00
rusefi bab1744d1d progress towards #961 2019-11-04 22:44:52 -05:00
rusefi 4d095d4844 60/2 VW trigger has running issue on 19/10/19 snapshot fix #986 2019-10-30 20:51:20 -04:00
rusefi 627f73502b steps towards #975 2019-10-18 19:45:32 -04:00
rusefi d9401fbdbc steps towards #975 2019-10-18 19:39:06 -04:00
rusefi 0e01355c15 steps towards #975 2019-10-18 18:54:32 -04:00
rusefi 62577c47da preparation for #961 
more unified access to pre-calculated value
 2019-10-10 08:25:58 -04:00
rusefi 71e904e421 preparation for #961 
more unified access to pre-calculated value
 2019-10-10 08:16:21 -04:00
rusefi ca6e49dcbc preparation for #961 
macro as a syntax sugar for method invocation
 2019-10-10 07:28:52 -04:00
Matthew Kennedy 29804cbc8a move tsOutputChannels to header (#970) 2019-10-08 21:02:51 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 62bbdbb33b docs 2019-09-29 15:14:08 -04:00
rusefi df7fe0ec3b fixing build 2019-09-29 14:22:51 -04:00
rusEfi fc3b7ec1bd etbCalibrationOnStart 2019-09-29 14:00:04 -04:00
rusefi d520e0734f docs 2019-09-28 09:59:40 -04:00
rusEfi 44b2c2f89e new command 'etb_freq X' 2019-09-27 23:37:40 -04:00
rusEfi 17dc0908f2 it's a cruel world 2019-09-27 23:01:47 -04:00
rusefi 8c5be72106 idle&ETB progress 2019-09-26 00:02:47 -04:00
rusefi ff8a3f2988 fixing build 2019-09-25 08:46:26 -04:00
rusefi bc572bef51 reducing hell in unit tests 2019-09-25 08:40:33 -04:00
rusefi 2bacf53c0d HardFault related to auto r = convertFromInputValue(inputValue); #948 
wow, it's a miracle anything ever worked!
 2019-09-23 01:55:23 -04:00
rusefi b66f3a8229 ETB is sticky around zero and does not want to close all the way #943 
fixing build
 2019-09-23 00:41:35 -04:00
rusEfi 89ed15838f ETB is sticky around zero and does not want to close all the way #943 2019-09-22 23:28:11 -04:00
rusefi e7b658547b ETB target is using integer values #945 
now we have a unit test! now we can fix the issue :)
 2019-09-22 17:58:27 -04:00
rusefi d09e096874 ETB target is using integer values #945 
refactoring
 2019-09-22 08:51:02 -04:00
rusefi 1b604359a9 ETB target is using integer values #945 
refactoring
 2019-09-22 08:44:51 -04:00
rusEfi 9b98446846 ETB target is using integer values #945 
first we will write a unit test
 2019-09-22 07:58:03 -04:00
rusEfi e29318b939 ETB target is using integer values #945 
first we will write a unit test
 2019-09-22 00:36:13 -04:00
rusEfi f843968636 ETB target is using integer values #945 
first we will write a unit test
 2019-09-22 00:16:46 -04:00
rusefi 4ba441fd49 "set_etb" is now "set_etb_duty" 2019-09-21 22:15:34 -04:00
rusefi 3646ef4406 ETB idle bugfix: do not use once turned off 2019-09-21 01:22:21 -04:00
rusefi f588224559 NB2 miata on Frankenso with ETB 2019-09-21 01:21:53 -04:00
rusefi 2bbbc1c787 ETB pinEnableMode 2019-09-20 22:16:54 -04:00
rusefi b9f649a93c ETB to SD logs 2019-09-20 20:41:45 -04:00
rusefi a72d2834fb unit tests progress 2019-09-20 00:46:35 -04:00
rusefi 154092bbf5 unit tests progress 2019-09-19 22:56:54 -04:00
rusefi 221ef7d9bb unit tests progress 2019-09-19 22:10:39 -04:00
rusefi 4f4f4ddfd9 FSIO progress 2019-09-13 21:07:34 -04:00
rusefi a6fbc5036a Delayed A/C compressor switch #922 2019-09-11 20:46:50 -04:00
rusefi cc011ee081 instant RPM for idle control #925 2019-09-10 23:03:55 -04:00
rusefi d90f0481b0 one step back :) instant RPM does not look right 2019-09-10 21:35:10 -04:00
rusefi 7676261ec6 instant RPM for idle control #925 2019-09-09 19:41:41 -04:00
rusefi e79287f537 Delayed A/C compressor switch #922 2019-09-08 21:05:03 -04:00
rusefi a585835add docs 2019-09-07 22:16:56 -04:00
rusefi 270565e593 docs 2019-09-07 21:35:55 -04:00
rusefi 2e27a94ee7 BUGFIX: ETB idle should care about pedal position, not TPS position 2019-09-03 21:45:42 -04:00
rusefi 98a391011a better field name 2019-09-03 19:12:04 -04:00
rusefi 2343cd6b12 make iTerm limits visible for idle RPM pid #913 2019-09-02 00:24:10 -04:00
rusefi be1b32abf0 make iTerm limits visible for idle RPM pid #913 2019-09-02 00:19:06 -04:00
rusEfi 8126b700de NB2 progress, ETB Live Docs progress 2019-09-01 19:37:58 -04:00
rusEfi daec071b6b mock PPS voltage command in addition to mock PPS position 
ETB pane progress
 2019-09-01 17:35:43 -04:00
rusefi ebcb0cdf4c Live Data: more Idle & ETB data points! 2019-09-01 15:46:40 -04:00
rusefi 33cc21225c Live Data progress: using field's context 2019-09-01 15:01:57 -04:00
rusefi 1ffaa8eea2 Live Data progress 2019-09-01 13:56:46 -04:00
rusefi 4141c7b4c2 typo 2019-09-01 11:39:09 -04:00
rusefi 7842c7305f Live Data progress 2019-09-01 00:45:36 -04:00
rusEfi 47bbd6ebe4 ETB progress 2019-08-31 20:17:17 -04:00
rusEfi 7efe5cdd5c reducing dead code 2019-08-31 17:59:18 -04:00
rusefi 4ddb0aeace LiveData progress: isChanking & hasEtbPedalPositionSensor 2019-08-31 17:07:21 -04:00
andreika-git 27fccf0a7f mightResetPid docs (#912) 2019-08-31 15:38:01 -04:00
rusefi 840b165f12 NA6 pnp: automatic idle VS TPS #800 2019-08-30 18:17:10 -04:00
rusefi 162264fe08 progress towards idle unit test 2019-08-29 23:50:20 -04:00
rusefi 375d64417d progress towards idle unit test 2019-08-29 00:10:47 -04:00
rusefi bde4e88468 refactoring towards idle unit test 2019-08-26 00:19:13 -04:00
rusEfi 1c0d38abef new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
rusefi efeb6eeadc ETB live docs 2019-08-15 21:01:04 -04:00
rusefi a3667eda8b dead code 2019-07-29 21:44:33 -04:00
rusefi 6fb2b34120 setDefaultBoardConfiguration shouldn't have Frankenso pinout #852 2019-07-24 21:15:18 -04:00
rusEfi 335a154a5a miata NA6 progress 2019-07-21 20:11:12 -04:00
rusefi 39630855fb live docs for idle state 2019-07-21 18:34:37 -04:00
rusefi 84955cdedb throttle pedal up switch for Miata NA6 2019-07-21 17:06:16 -04:00
rusefi 4b0ed3751f More than one aux pid #866 
progress!
 2019-07-12 08:31:38 -04:00
rusefi 8dcb49bdf9 More than one aux pid #866 
progress!
 2019-07-12 08:00:07 -04:00
rusefi 974f80988f refactoring - type/macro name/docs 2019-07-12 07:48:28 -04:00
rusefi 2580831b9c nano progress 2019-07-10 02:27:24 -04:00
Matthew Kennedy 77075fce3d Fix some maf logic (#880) 
* fix maf

* thank you vscode for mangling ANSI -> utf8
 2019-07-10 09:14:47 +03:00
rusefi b4e9503fab More than one aux pid #866 
progress!
 2019-07-09 16:24:14 -04:00
rusefi 4ef2a72930 refactoring: wider usage of new periodic task 2019-07-09 16:08:49 -04:00
Matthew Kennedy e0db83e027 Template-ize bin/value length for interpolation (#878) 
* update consumers

* tests

* whitespace

* format
 2019-07-09 21:16:36 +03:00
rusefi 34acd20833 More than one aux pid #866 
renaming this class since we will probably have two different implementations for two different cases
 2019-07-08 03:35:41 -04:00
rusefi 05fac9e869 Refactoring: OS access should be explicit #867 2019-07-05 19:00:44 -04:00
rusefi 83ad64eade Refactoring: OS access should be explicit #867 2019-07-04 03:57:21 -04:00
rusefi b2dece5269 undoing wrong fix & better fix for #805 
also generator logging improvements
This reverts commit f07f96599b.
 2019-06-30 14:28:47 -04:00
Matthew Kennedy e3a14e5979 Add ETB status gauges, fix gauge menus (#863) 
* testing

* fix offsets

* consolidate ts config

* cleanup

* typo

* unwind some

* fix etb idle range setting

* unwind
 2019-06-26 19:24:32 -04:00
rusefi f07f96599b "Calibrate TPS" broken in TS fix #805 2019-06-17 22:00:34 -04:00
rusefi 1e3758c6d3 ETB: TPS should be f(RPM, pedal) - target table fix #835 
oooooops
 2019-06-16 09:08:01 -04:00
rusefi 995cf20b4b ETB: TPS should be f(RPM, pedal) - target table fix #835 2019-06-15 14:33:41 -04:00
rusefi e1c0557f4d idle using ETB #783 2019-06-15 13:33:14 -04:00
Matthew Kennedy e47bc4b952 Fix tunerstudio ratio vs. percent (#838) 
* fix ratio vs pct

* fix idle cranking clt position

* fix defaults

* fix typo

* fix baro corr gauge

* baro default

* fix degree symbols

* fix testFuelMap

* fix testPlainCrankingWithoutAdvancedFeatures

* test testFasterEngineSpinningUp
 2019-06-13 09:05:22 -04:00
rusefi 8406be52f0 refactoring: extracting constant 2019-06-11 21:44:16 -04:00
rusefi a3581b06f9 ETB: TPS should be f(RPM, pedal) #835 2019-06-10 23:57:35 -04:00
rusefi 837492c9f0 ETB: TPS should be f(RPM, pedal) #835 2019-06-10 23:38:44 -04:00
rusefi 5f642ac254 unit tests should not have global context, including mock values 2019-05-27 15:56:12 -04:00
rusefi 01e481db31 fix #802 2019-05-25 13:36:29 -04:00
rusefi e0f9ba8a2a idle usability 2019-05-11 10:41:04 -04:00
rusefi 4faf9ff8fa docs 2019-05-05 18:09:52 -04:00
rusefi a59ac4ad0e 8888 usability 2019-05-05 12:48:04 -04:00
rusefi d09bcad3e7 dreams of two ETBs 2019-05-05 12:02:42 -04:00
Matthew Kennedy 5a15b449c0 rename enum (#791) 2019-05-05 00:53:24 -04:00
Matthew Kennedy 6810aa3268 fix etb (#789) 2019-05-05 00:42:50 -04:00
rusefi 8bbd5c0514 idle using ETB #783 
configuration fields
 2019-05-02 22:12:43 -04:00
rusefi e13193a832 ETB pause feature - useful while playing on the bench 2019-04-26 13:46:58 -04:00
rusefi f04732830f PID - fix dTime usages #776 2019-04-25 21:31:33 -04:00
rusefi 05d43db76f PID - fix dTime usages #776 2019-04-25 18:49:16 -04:00
rusefi 7a857ae298 ETB progress 2019-04-24 23:46:49 -04:00
rusefi 24818929d2 docs 2019-04-24 20:47:38 -04:00
rusefi c8859d651c docs 2019-04-24 17:00:05 -04:00
rusefi 9f29f30950 ETB progress 2019-04-23 23:18:48 -04:00
rusefi 3d5338c1de docs 2019-04-21 12:24:31 -04:00
rusefi 5ad1044d19 The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-04-15 21:09:43 -04:00
rusefi 16cf6388b6 ETB using tle7209 fix #746 2019-04-13 01:03:12 -04:00